hello Emilio,
Thanks for looking at this issue. After adding -DBUILDING_DLL to
QEMU_CFLAGS, I still got linking error as follows, and it seems $LDLIB is empty:
x86_64-w64-mingw32-gcc -shared -Wl,-soname,libbb.so -o libbb.so bb.o
C:/msys64/mingw64/bin/../lib/gcc/x86_64-w64-mingw32/10.1.0/../..
I never built the plugin code on anything other than Linux :(
All I did for Windows is to try to follow https://gcc.gnu.org/wiki/Visibility
Can you please try the following patch (with no other changes)?
The patch applies on top of v4.2.0.
diff --git a/tests/plugin/Makefile b/tests/plugin/Makefil
On Fri, Jul 3, 2020 at 3:24 PM Philippe Mathieu-Daudé wrote:
>
> On 7/3/20 11:07 PM, Havard Skinnemoen wrote:
> > On Fri, Jul 3, 2020 at 6:46 AM Philippe Mathieu-Daudé
> > wrote:
> >>
> >> On 6/27/20 1:55 AM, Havard Skinnemoen wrote:
> >>> +static void npcm7xx_otp_realize(DeviceState *dev, Error
On 7/3/20 5:16 PM, Philippe Mathieu-Daudé wrote:
> On 7/3/20 3:23 PM, Peter Maydell wrote:
>> On Tue, 30 Jun 2020 at 14:39, Philippe Mathieu-Daudé wrote:
>>>
>>> As we have no interest in the underlying block geometry,
>>> directly call blk_getlength(). We have to care about machines
>>> creating
On Wednesday, July 1, 2020, Alex Bennée wrote:
>
> Ahmed Karaman writes:
>
> > On Mon, Jun 29, 2020 at 6:03 PM Alex Bennée
> wrote:
> >>
> >> Assuming your test case is constant execution (i.e. runs the same each
> >> time) you could run in through a plugins build to extract the number of
> >>
On 7/3/20 11:15 PM, Havard Skinnemoen wrote:
> On Fri, Jul 3, 2020 at 6:35 AM Philippe Mathieu-Daudé
> wrote:
>>
>> On 7/3/20 2:27 PM, Peter Maydell wrote:
>>> On Sat, 27 Jun 2020 at 00:55, Havard Skinnemoen
>>> wrote:
Time for another refresh of this patchset. Sorry it took so long -
On 7/3/20 10:56 PM, Havard Skinnemoen wrote:
> On Fri, Jul 3, 2020 at 6:32 AM Philippe Mathieu-Daudé wrote:
>>
>> On 6/27/20 1:55 AM, Havard Skinnemoen wrote:
>>> +/*
>>> + * This covers the whole MMIO space. We'll use this to catch any MMIO
>>> accesses
>>> + * that aren't handled by any device.
On 2020-07-03 09:25, Brijesh Singh wrote:
On 7/3/20 6:11 AM, Dr. David Alan Gilbert wrote:
* Tobin Feldman-Fitzthum (to...@linux.vnet.ibm.com) wrote:
From: Tobin Feldman-Fitzthum
AMD SEV allows a guest owner to inject a secret blob
into the memory of a virtual machine. The secret is
encrypted
On 7/3/20 11:07 PM, Havard Skinnemoen wrote:
> On Fri, Jul 3, 2020 at 6:46 AM Philippe Mathieu-Daudé wrote:
>>
>> On 6/27/20 1:55 AM, Havard Skinnemoen wrote:
>>> +static void npcm7xx_otp_realize(DeviceState *dev, Error **errp)
>>> +{
>>> +NPCM7xxOTPClass *oc = NPCM7XX_OTP_GET_CLASS(dev);
>>>
On 7/3/20 9:58 PM, BALATON Zoltan wrote:
> On Fri, 3 Jul 2020, Philippe Mathieu-Daudé wrote:
>> By using the TYPE_* definitions for devices, we can:
>> - quickly find where devices are used with 'git-grep'
>
> You could just as well grep for the type name but it's true if some
> files use name and
On 7/3/20 11:35 PM, Michele Denber wrote:
>
>>
>> It appears that _IOR & friends are defined in
>> /usr/include/sys/ioccom.h, but I can't figure out how to point gmake
>> to that. Do I need some sort of "-I" in the Makefile?
>>
>>
>> When I built QEMU 2.12, I ran into this too and ended up just
>
On Fri, Jul 3, 2020 at 11:19 PM Havard Skinnemoen
wrote:
>
> On Fri, Jul 3, 2020 at 2:07 PM Havard Skinnemoen
> wrote:
> >
> > On Fri, Jul 3, 2020 at 6:46 AM Philippe Mathieu-Daudé
> > wrote:
> > >
> > > On 6/27/20 1:55 AM, Havard Skinnemoen wrote:
> > > > +static void npcm7xx_otp_realize(Devi
It appears that _IOR & friends are defined in
/usr/include/sys/ioccom.h, but I can't figure out how to point gmake
to that. Do I need some sort of "-I" in the Makefile?
When I built QEMU 2.12, I ran into this too and ended up just
commenting out all the references to _IOR, etc. in hw/tpm
On Fri, Jul 3, 2020, 20:49 Philippe Mathieu-Daudé wrote:
> By using the TYPE_* definitions for devices, we can:
> - quickly find where devices are used with 'git-grep'
> - easily rename a non-user-creatable device (one-line change).
>
> Signed-off-by: Philippe Mathieu-Daudé
>
Reviewed-By: Niek L
On Fri, Jul 3, 2020 at 2:07 PM Havard Skinnemoen wrote:
>
> On Fri, Jul 3, 2020 at 6:46 AM Philippe Mathieu-Daudé wrote:
> >
> > On 6/27/20 1:55 AM, Havard Skinnemoen wrote:
> > > +static void npcm7xx_otp_realize(DeviceState *dev, Error **errp)
> > > +{
> > > +NPCM7xxOTPClass *oc = NPCM7XX_OT
On Fri, Jul 3, 2020 at 6:35 AM Philippe Mathieu-Daudé wrote:
>
> On 7/3/20 2:27 PM, Peter Maydell wrote:
> > On Sat, 27 Jun 2020 at 00:55, Havard Skinnemoen
> > wrote:
> >>
> >> Time for another refresh of this patchset. Sorry it took so long -- I've
> >> been
> >> trying to figure out why the
On Fri, Jul 3, 2020 at 6:46 AM Philippe Mathieu-Daudé wrote:
>
> On 6/27/20 1:55 AM, Havard Skinnemoen wrote:
> > +static void npcm7xx_otp_realize(DeviceState *dev, Error **errp)
> > +{
> > +NPCM7xxOTPClass *oc = NPCM7XX_OTP_GET_CLASS(dev);
> > +NPCM7xxOTPState *s = NPCM7XX_OTP(dev);
> > +
Patchew URL: https://patchew.org/QEMU/20200703201911.26573-1-f4...@amsat.org/
Hi,
This series failed the docker-quick@centos7 build test. Please find the testing
commands and
their output below. If you have Docker installed, you can probably reproduce it
locally.
=== TEST SCRIPT BEGIN ===
#!/
On Fri, Jul 3, 2020 at 9:35 AM Philippe Mathieu-Daudé wrote:
>
> On 6/27/20 1:55 AM, Havard Skinnemoen wrote:
> > +The Nuvoton machines can boot from an OpenBMC firmware image, or directly
> > into
> > +a kernel using the ``-kernel`` option. OpenBMC images for `quanta-gsj` and
> > +possibly other
On Fri, Jul 3, 2020 at 6:32 AM Philippe Mathieu-Daudé wrote:
>
> On 6/27/20 1:55 AM, Havard Skinnemoen wrote:
> > +/*
> > + * This covers the whole MMIO space. We'll use this to catch any MMIO
> > accesses
> > + * that aren't handled by any device.
> > + */
> > +#define NPCM7XX_MMIO_BA (0
Patchew URL: https://patchew.org/QEMU/cover.1593806826.git@tribudubois.net/
Hi,
This series failed the docker-quick@centos7 build test. Please find the testing
commands and
their output below. If you have Docker installed, you can probably reproduce it
locally.
=== TEST SCRIPT BEGIN ===
#
On Fri, Jul 3, 2020 at 5:27 AM Peter Maydell
wrote:
> On Sat, 27 Jun 2020 at 00:55, Havard Skinnemoen
> wrote:
> >
> > Time for another refresh of this patchset. Sorry it took so long -- I've
> been
> > trying to figure out why the Winbond flash model isn't working with
> > npcm750-evb, and I'm
This device doesn't have fields to migrate. Be explicit
by using vmstate_qdev_no_state_to_migrate.
Signed-off-by: Philippe Mathieu-Daudé
---
hw/misc/unimp.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/hw/misc/unimp.c b/hw/misc/unimp.c
index bc4084d344..8a0db25a77 100644
--- a/hw/misc/uni
This device doesn't have fields to migrate. Be explicit
by using vmstate_qdev_no_state_to_migrate.
Signed-off-by: Philippe Mathieu-Daudé
---
hw/nubus/mac-nubus-bridge.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/hw/nubus/mac-nubus-bridge.c b/hw/nubus/mac-nubus-bridge.c
index 7c329300b8.
When built with --enable-qdev-debug, QEMU displays warnings
listing devices missing migration state:
$ qemu-system-arm -S -M spitz
qemu-system-arm: warning: missing migration state for type:
'pxa270-c0-arm-cpu'
qemu-system-arm: warning: missing migration state for type: 'serial'
qemu-syst
These devices don't have fields to migrate. Be explicit
by using vmstate_qdev_no_state_to_migrate.
Add a more descriptive comment to keep a clear separation
between static property vs runtime changeable.
Signed-off-by: Philippe Mathieu-Daudé
---
hw/sparc64/sun4u.c | 7 ++-
1 file changed, 6
This device doesn't have fields to migrate. Be explicit
by using vmstate_qdev_no_state_to_migrate.
Signed-off-by: Philippe Mathieu-Daudé
---
hw/core/split-irq.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/hw/core/split-irq.c b/hw/core/split-irq.c
index 3b90af2e8f..a7072f922c 100644
--- a
This device doesn't have fields to migrate. Be explicit
by using vmstate_qdev_no_state_to_migrate.
Add a more descriptive comment to keep a clear separation
between static property vs runtime changeable.
Signed-off-by: Philippe Mathieu-Daudé
---
hw/intc/arm_gicv2m.c | 2 ++
1 file changed, 2 in
This device doesn't have fields to migrate. Be explicit
by using vmstate_qdev_no_state_to_migrate.
Signed-off-by: Philippe Mathieu-Daudé
---
hw/misc/iotkit-sysinfo.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/hw/misc/iotkit-sysinfo.c b/hw/misc/iotkit-sysinfo.c
index b2dcfc4376..8bb9a2ef
This device doesn't have fields to migrate. Be explicit
by using vmstate_qdev_no_state_to_migrate.
Add a more descriptive comment to keep a clear separation
between static property vs runtime changeable.
Signed-off-by: Philippe Mathieu-Daudé
---
hw/usb/hcd-ohci.h | 2 ++
hw/usb/hcd-ohci.c | 1 +
This device doesn't have fields to migrate. Be explicit
by using vmstate_qdev_no_state_to_migrate.
Signed-off-by: Philippe Mathieu-Daudé
---
hw/misc/armsse-cpuid.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/hw/misc/armsse-cpuid.c b/hw/misc/armsse-cpuid.c
index d58138dc28..61251d538b 100
This device doesn't have fields to migrate. Be explicit
by using vmstate_qdev_no_state_to_migrate.
Signed-off-by: Philippe Mathieu-Daudé
---
hw/arm/aspeed_soc.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/hw/arm/aspeed_soc.c b/hw/arm/aspeed_soc.c
index 311458aa76..b15984e4d3 100644
--- a
This device doesn't have fields to migrate. Be explicit
by using vmstate_qdev_no_state_to_migrate.
Signed-off-by: Philippe Mathieu-Daudé
---
hw/cpu/cluster.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/hw/cpu/cluster.c b/hw/cpu/cluster.c
index e444b7c29d..95653a643a 100644
--- a/hw/cpu/c
These devices don't have fields to migrate. Be explicit
by using vmstate_qdev_no_state_to_migrate.
Add a more descriptive comment to keep a clear separation
between static property vs runtime changeable.
Signed-off-by: Philippe Mathieu-Daudé
---
include/hw/arm/bcm2836.h | 7 ---
hw/arm/
This device doesn't have fields to migrate. Be explicit
by using vmstate_qdev_no_state_to_migrate.
Add a more descriptive comment to keep a clear separation
between static property vs runtime changeable.
Signed-off-by: Philippe Mathieu-Daudé
---
include/hw/cpu/a9mpcore.h | 3 ++-
hw/cpu/a9mpcor
This device doesn't have fields to migrate. Be explicit
by using vmstate_qdev_no_state_to_migrate.
Signed-off-by: Philippe Mathieu-Daudé
---
hw/arm/armv7m.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/hw/arm/armv7m.c b/hw/arm/armv7m.c
index 3308211e9c..3f78fccc12 100644
--- a/hw/arm/armv
Add vmstate_qdev_no_state_to_migrate, which is simply a
pointer to vmstate_no_state_to_migrate. This way all
qdev devices (including "hw/qdev-core.h") don't have to
include "migration/vmstate.h".
Signed-off-by: Philippe Mathieu-Daudé
---
include/hw/qdev-core.h | 2 ++
hw/core/qdev.c | 3
This device doesn't have fields to migrate. Be explicit
by using vmstate_qdev_no_state_to_migrate.
Add a more descriptive comment to keep a clear separation
between static property vs runtime changeable.
Signed-off-by: Philippe Mathieu-Daudé
---
include/hw/arm/msf2-soc.h | 11 ++-
hw/ar
Introduce a special state to indicate when an object doesn't
have anything in its state to migrate.
Suggested-by: Peter Maydell
Signed-off-by: Philippe Mathieu-Daudé
---
include/migration/vmstate.h | 1 +
migration/vmstate.c | 7 +++
2 files changed, 8 insertions(+)
diff --git a/in
vmstate_dummy is special and restricted to linux-user. See commit
c71c3e99b8 ("Add a vmstate_dummy struct for CONFIG_USER_ONLY").
Signed-off-by: Philippe Mathieu-Daudé
---
include/migration/vmstate.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/migration/vmstate.h
This is a proof-of-concept after chatting with Peter Maydell
on IRC earlier.
Introduce the vmstate_no_state_to_migrate structure, and
a reference to it: vmstate_qdev_no_state_to_migrate.
Use this reference in devices with no fields to migrate.
This is useful to catch devices missing vmstate, such
Signed-off-by: Jean-Christophe Dubois
---
hw/arm/fsl-imx25.c | 7 +++
include/hw/arm/fsl-imx25.h | 1 +
2 files changed, 8 insertions(+)
diff --git a/hw/arm/fsl-imx25.c b/hw/arm/fsl-imx25.c
index 7ab5c98fbe1..35874aac00b 100644
--- a/hw/arm/fsl-imx25.c
+++ b/hw/arm/fsl-imx25.c
@@ -18
This patch set adds the ability to select the Ethernet PHY device number
for the i.MX25 processor, the i.MX6 processor and the i.MX7 processor.
Note: the i.MX6UL processor was addressed in a previous patch.
Jean-Christophe Dubois (3):
Add the ability to change the FEC PHY MDIO device number on
Signed-off-by: Jean-Christophe Dubois
---
hw/arm/fsl-imx7.c | 9 +
include/hw/arm/fsl-imx7.h | 1 +
2 files changed, 10 insertions(+)
diff --git a/hw/arm/fsl-imx7.c b/hw/arm/fsl-imx7.c
index b49d895a412..5dbf0e500aa 100644
--- a/hw/arm/fsl-imx7.c
+++ b/hw/arm/fsl-imx7.c
@@ -364,6
Signed-off-by: Jean-Christophe Dubois
---
hw/arm/fsl-imx6.c | 7 +++
include/hw/arm/fsl-imx6.h | 1 +
2 files changed, 8 insertions(+)
diff --git a/hw/arm/fsl-imx6.c b/hw/arm/fsl-imx6.c
index 4ae3c3efc28..0721f333497 100644
--- a/hw/arm/fsl-imx6.c
+++ b/hw/arm/fsl-imx6.c
@@ -402,6 +4
On 03.07.2020 16:13, Andrey Shinkevich wrote:
Add bitmap table information to the QCOW2 metadata dump.
...
--- a/tests/qemu-iotests/qcow2_format.py
+++ b/tests/qemu-iotests/qcow2_format.py
@@ -171,14 +171,56 @@ class Qcow2BitmapDirEntry(Qcow2Struct):
entry_raw_size = self.bitmap_dir_e
The 'cpu_type' has been moved from BCM283XState to BCM283XClass
in commit 210f47840d, but we forgot to remove the old variable.
Do it now.
Fixes: 210f47840d ("hw/arm/bcm2836: Hardcode correct CPU type")
Signed-off-by: Philippe Mathieu-Daudé
---
include/hw/arm/bcm2836.h | 1 -
1 file changed, 1 d
On Fri, 3 Jul 2020, Philippe Mathieu-Daudé wrote:
By using the TYPE_* definitions for devices, we can:
- quickly find where devices are used with 'git-grep'
You could just as well grep for the type name but it's true if some files
use name and others the constant then you need to grep for both
On Fri, Jul 03, 2020 at 09:09:43AM -0400, Michael S. Tsirkin wrote:
> On Thu, Jul 02, 2020 at 10:48:46PM +0200, Gerd Hoffmann wrote:
> > +/* copy AML table into ACPI tables blob and patch header there */
> > +g_array_append_vals(table_data, dsdt->buf->data, dsdt->buf->len);
> > +build_h
Public bug reported:
We already have handy VMs to build QEMU within:
$ git grep -l basevm.BaseVM
tests/vm/centos
tests/vm/fedora
tests/vm/freebsd
tests/vm/netbsd
tests/vm/openbsd
tests/vm/ubuntu.i386
Some people have interest in building QEMU on Solaris:
https://lists.gnu.org/archive/html/qemu-d
Add more descriptive comments to keep a clear separation
between static property vs runtime changeable.
Signed-off-by: Philippe Mathieu-Daudé
---
include/hw/char/serial.h | 7 +--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/include/hw/char/serial.h b/include/hw/char/serial.
We migrate the memory mapped device, but not the I/O one.
No particular reason, so let it be migratable.
Philippe Mathieu-Daudé (2):
hw/char/serial: Separate and document static properties
hw/char/serial: Allow migration of the I/O serial device
include/hw/char/serial.h | 7 +--
hw/char
The serial device mapped on the I/O bus hold a migratable
SerialState. Keep the same version range from SerialState:
837 const VMStateDescription vmstate_serial = {
838 .name = "serial",
839 .version_id = 3,
840 .minimum_version_id = 2,
Fixes: 10315a7089 ("serial: make SerialIO a
By using the TYPE_* definitions for devices, we can:
- quickly find where devices are used with 'git-grep'
- easily rename a non-user-creatable device (one-line change).
Signed-off-by: Philippe Mathieu-Daudé
---
hw/display/sm501.c | 3 ++-
hw/ppc/sam460ex.c | 3 ++-
2 files changed, 4 insertion
By using the TYPE_* definitions for devices, we can:
- quickly find where devices are used with 'git-grep'
- easily rename a non-user-creatable device (one-line change).
Signed-off-by: Philippe Mathieu-Daudé
---
hw/arm/allwinner-h3.c | 9 +
hw/arm/pxa2xx.c | 3 ++-
2 files changed,
On 07/03/20 12:50, Peter Maydell wrote:
...
This is because you're trying to apply the patch to the
5.0.0 release, but it was made against the current head-of-git,
and this file has changed a little between the two.
Generally we do all development against head-of-git, so
I would suggest that you
Trivial patches to use the TYPE_* definitions instead of
hardcoded names.
Philippe Mathieu-Daudé (2):
hw/arm: Use TYPE_SYSBUS_OHCI instead of hardcoded string
hw/ppc: Use TYPE_SYSBUS_OHCI instead of hardcoded string
hw/arm/allwinner-h3.c | 9 +
hw/arm/pxa2xx.c | 3 ++-
hw/displ
Hi Alex,
On 7/3/20 6:15 PM, Alex Richardson wrote:
> After merging latest QEMU upstream into our CHERI fork, I noticed that
> some of the FPU tests in our MIPS baremetal testsuite
I understand by baremetal your soft core implementation running on
a FPGA, right?
> (https://github.com/CTSRD-CHERI/
Add an entry to cover firmware.json (see commit 3a0adfc9bf:
schema that describes the different uses and properties of
virtual machine firmware).
Cc: Laszlo Ersek
Cc: Gerd Hoffmann
Cc: Michael S. Tsirkin
Cc: Kashyap Chamarthy
Cc: Daniel P. Berrange
Suggested-by: Laszlo Ersek
Signed-off-by: P
On 7/3/20 7:06 PM, Daniel P. Berrangé wrote:
> On Fri, Jul 03, 2020 at 06:58:45PM +0200, Laszlo Ersek wrote:
>> On 07/03/20 18:18, Daniel P. Berrangé wrote:
>>> On Fri, Jul 03, 2020 at 06:14:53PM +0200, Philippe Mathieu-Daudé wrote:
Add an entry to cover firmware.json (see commit 3a0adfc9bf:
>
On Freitag, 3. Juli 2020 18:08:21 CEST Greg Kurz wrote:
> On Fri, 03 Jul 2020 10:08:09 +0200
>
> Christian Schoenebeck wrote:
> > On Donnerstag, 2. Juli 2020 19:23:35 CEST Christian Schoenebeck wrote:
> > > > > Back to the actual topic: so what do we do about the mutex then?
> > > > > CoMutex
> >
On Freitag, 3. Juli 2020 17:53:15 CEST Greg Kurz wrote:
> > > I don't remember questioning the overall concept behind these changes
> > > because it looks reasonable enough (even if I would appreciate to be
> > > able to verify them with a working reproducer).
> >
> > What exactly do you mean here
03.07.2020 17:06, Max Reitz wrote:
On 28.05.20 11:43, Vladimir Sementsov-Ogievskiy wrote:
This is first step to block-status refactoring, and solves most simple
problem mentioned in my investigation of block-status described in
the thread "backing chain & block status & filters":
https://list
03.07.2020 21:05, Vladimir Sementsov-Ogievskiy wrote:
02.07.2020 18:49, Markus Armbruster wrote:
The object_property_set_FOO() setters take property name and value in
an unusual order:
void object_property_set_FOO(Object *obj, FOO_TYPE value,
const char *n
02.07.2020 18:49, Markus Armbruster wrote:
The object_property_set_FOO() setters take property name and value in
an unusual order:
void object_property_set_FOO(Object *obj, FOO_TYPE value,
const char *name, Error **errp)
Having to pass value before name fe
Your pipeline has failed.
Project: QEMU ( https://gitlab.com/qemu-project/qemu )
Branch: master ( https://gitlab.com/qemu-project/qemu/-/commits/master )
Commit: 5f42c337 (
https://gitlab.com/qemu-project/qemu/-/commit/5f42c3375d45108cf14f50ac8ba57c2865e75e9c
)
Commit Message: Merge remote-tr
Patchew URL:
https://patchew.org/QEMU/20200703165405.17672-1-peter.mayd...@linaro.org/
Hi,
This series seems to have some coding style problems. See output below for
more information:
Subject: [PULL 00/34] target-arm queue
Type: series
Message-id: 20200703165405.17672-1-peter.mayd...@linaro.o
This series do standard basic things:
- it creates intermediate buffer for all writes from QEMU migration code
to QCOW2 image,
- this buffer is sent to disk asynchronously, allowing several writes to
run in parallel.
In general, migration code is fantastically inefficent (by observation),
buff
This patch does 2 standard basic things:
- it creates intermediate buffer for all writes from QEMU migration code
to block driver,
- this buffer is sent to disk asynchronously, allowing several writes to
run in parallel.
Thus bdrv_vmstate_write() is becoming asynchronous. All pending operation
While working on some test cases I realised there was quite a lot of
assumed knowledge about how things boot up. I thought it would be
worth gathering this together in a user facing document where we could
pour in the details and background to the boot process. The consensus
seems to be this is bet
bdrv_save_vmstate() returns either error with negative return value or
size. Thus this check is useless.
Signed-off-by: Denis V. Lunev
Suggested-by: Eric Blake
Reviewed-by: Vladimir Sementsov-Ogievskiy
CC: Kevin Wolf
CC: Max Reitz
CC: Stefan Hajnoczi
CC: Fam Zheng
CC: Juan Quintela
CC: "Dr
This patch creates intermediate buffer for reading from block driver
state and performs read-ahead to this buffer. Snapshot code performs
reads sequentially and thus we know what offsets will be required
and when they will become not needed.
Results are fantastic. Switch to snapshot times of 2GB F
On 6/11/20 8:16 PM, Denis V. Lunev wrote:
> Nowaday SCSI drivers in guests are able to align UNMAP requests before
> sending to the device. Right now QEMU provides an ability to set
> this via "discard_granularity" property of the block device which could
> be used by management layer.
>
> Though,
From: Vladimir Sementsov-Ogievskiy
Currently, aio task pool assumes that there is a main coroutine, which
creates tasks and wait for them. Let's remove the restriction by using
CoQueue. Code becomes clearer, interface more obvious.
Signed-off-by: Vladimir Sementsov-Ogievskiy
Signed-off-by: Deni
qemu_fclose() could return error, f.e. if bdrv_co_flush() will return
the error.
This validation will become more important once we will start waiting of
asynchronous IO operations, started from bdrv_write_vmstate(), which are
coming soon.
Signed-off-by: Denis V. Lunev
Reviewed-by: "Dr. David Al
Right now bdrv_fclose() is just calling bdrv_flush().
The problem is that migration code is working inefficiently from block
layer terms and are frequently called for very small pieces of
unaligned data. Block layer is capable to work this way, but this is very
slow.
This patch is a preparation f
It is not used outside the module.
Actually there are 2 kind of waiters:
- for a slot and
- for all tasks to finish
This patch limits external API to listed types.
Signed-off-by: Denis V. Lunev
Suggested-by: Vladimir Sementsov-Ogievskiy
Reviewed-by: Vladimir Sementsov-Ogievskiy
CC: Kevin Wolf
On 7/3/20 8:22 PM, Daniel P. Berrangé wrote:
> On Fri, Jul 03, 2020 at 08:15:44PM +0300, Denis V. Lunev wrote:
>> On 7/2/20 8:57 PM, Daniel P. Berrangé wrote:
>>> When QMP was first introduced some 10+ years ago now, the snapshot
>>> related commands (savevm/loadvm/delvm) were not converted. This w
* Daniel P. Berrangé (berra...@redhat.com) wrote:
> On Fri, Jul 03, 2020 at 06:00:50PM +0100, Dr. David Alan Gilbert wrote:
> > * Daniel P. Berrangé (berra...@redhat.com) wrote:
> > > On Fri, Jul 03, 2020 at 05:22:46PM +0100, Dr. David Alan Gilbert wrote:
> > > > * Daniel P. Berrang̮̩ (berr
On 03/07/20 07:34, Thomas Huth wrote:
> On 18/06/2020 09.40, Thomas Huth wrote:
>> The new -accel option does not accept colons in the parameters anymore
>> (since it does not convert the parameters to -machine accel=...
>> parameters
>> anymore). Thus we can now remove the check for colons in -acc
On 7/2/20 8:57 PM, Daniel P. Berrangé wrote:
> savevm, loadvm and delvm are some of the few commands that have never
> been converted to use QMP. The primary reason for this lack of
> conversion is that they block execution of the thread for as long as
> they run.
>
> Despite this downside, however
On Fri, Jul 03, 2020 at 08:15:44PM +0300, Denis V. Lunev wrote:
> On 7/2/20 8:57 PM, Daniel P. Berrangé wrote:
> > When QMP was first introduced some 10+ years ago now, the snapshot
> > related commands (savevm/loadvm/delvm) were not converted. This was
> > primarily because their implementation ca
On 02/07/20 08:27, Claudio Fontana wrote:
> Hi Alex, Markus, Paolo,
>
> maybe this could be queued in one of your queues?
Nevermind, Thunderbird was acting funny. Queued all now.
Paolo
> Thanks a lot,
>
> Claudio
>
> On 6/29/20 11:35 AM, Claudio Fontana wrote:
>> Motivation and higher level
On 29/06/20 11:35, Claudio Fontana wrote:
> move arch_init, balloon, cpus, ioport, memory, memory_mapping, qtest.
>
> They are all specific to CONFIG_SOFTMMU.
>
> Signed-off-by: Claudio Fontana
> Reviewed-by: Alex Bennée
> Reviewed-by: Laurent Vivier
> Reviewed-by: Thomas Huth
> ---
> MAINTA
Your pipeline has failed.
Project: QEMU ( https://gitlab.com/qemu-project/qemu )
Branch: master ( https://gitlab.com/qemu-project/qemu/-/commits/master )
Commit: 4abf70a6 (
https://gitlab.com/qemu-project/qemu/-/commit/4abf70a661a5df3886ac9d7c19c3617fa92b922a
)
Commit Message: Merge remote-tr
* Daniel P. Berrangé (berra...@redhat.com) wrote:
> On Fri, Jul 03, 2020 at 05:22:46PM +0100, Dr. David Alan Gilbert wrote:
> > * Daniel P. Berrang̮̩ (berra...@redhat.com) wrote:
> > > On Fri, Jul 03, 2020 at 05:10:12PM +0100, Dr. David Alan Gilbert wrote:
> > > > * Daniel P. Berrang̮̩
Patchew URL: https://patchew.org/QEMU/20200703161130.23772-1-...@openvz.org/
Hi,
This series failed the docker-quick@centos7 build test. Please find the testing
commands and
their output below. If you have Docker installed, you can probably reproduce it
locally.
=== TEST SCRIPT BEGIN ===
#!/b
On Thu, 2 Jul 2020 at 17:33, Alistair Francis wrote:
>
> The following changes since commit 64f0ad8ad8e13257e7c912df470d46784b55c3fd:
>
> Merge remote-tracking branch 'remotes/armbru/tags/pull-error-2020-07-02'
> into staging (2020-07-02 15:54:09 +0100)
>
> are available in the Git repository a
Deprecate our TileGX target support:
* we have no active maintainer for it
* it has had essentially no contributions (other than tree-wide cleanups
and similar) since it was first added
* the Linux kernel dropped support in 2018, as has glibc
Note the deprecation in the manual, but don't try
Create a header file for the hw/misc/max111x device, in the
usual modern style for QOM devices:
* definition of the TYPE_ constants and macros
* definition of the device's state struct so that it can
be embedded in other structs if desired
* documentation of the interface
This allows us to u
On 7/2/20 8:57 PM, Daniel P. Berrangé wrote:
> When QMP was first introduced some 10+ years ago now, the snapshot
> related commands (savevm/loadvm/delvm) were not converted. This was
> primarily because their implementation causes blocking of the thread
> running the monitor commands. This was (an
The QOM types "spitz-lcdtg" and "corgi-ssp" are missing the
usual QOM TYPE and casting macros; provide and use them.
In particular, we can safely use the QOM cast macros instead of
FROM_SSI_SLAVE() because in both cases the 'ssidev' field of
the instance state struct is the first field in it.
Sig
Keep pointers to scp0, scp1 in SpitzMachineState, and just pass
that to spitz_scoop_gpio_setup().
(We'll want to use some of the other fields in SpitzMachineState
in that function in the next commit.)
Signed-off-by: Peter Maydell
Reviewed-by: Alistair Francis
Message-id: 20200628142429.17111-5-
On Fri, Jul 03, 2020 at 06:00:50PM +0100, Dr. David Alan Gilbert wrote:
> * Daniel P. Berrangé (berra...@redhat.com) wrote:
> > On Fri, Jul 03, 2020 at 05:22:46PM +0100, Dr. David Alan Gilbert wrote:
> > > * Daniel P. Berrangé (berra...@redhat.com) wrote:
> > > > On Fri, Jul 03, 2020 at 05:10:12
Keep pointers to the MPU and the SSI devices in SpitzMachineState.
We're going to want to make GPIO connections between some of the
SSI devices and the SCPs, so we want to keep hold of a pointer to
those; putting the MPU into the struct allows us to pass just
one thing to spitz_ssp_attach() rather
Instead of logging guest accesses to invalid register offsets in the
Spitz flash device with zaurus_printf() (which just prints to stderr),
use the usual qemu_log_mask(LOG_GUEST_ERROR,...).
Signed-off-by: Peter Maydell
Reviewed-by: Philippe Mathieu-Daudé
Reviewed-by: Alistair Francis
Message-id
On 07/03/20 18:18, Daniel P. Berrangé wrote:
> On Fri, Jul 03, 2020 at 06:14:53PM +0200, Philippe Mathieu-Daudé wrote:
>> Add an entry to cover firmware.json (see commit 3a0adfc9bf:
>> schema that describes the different uses and properties of
>> virtual machine firmware).
>> Cc the libvirt maintai
On Fri, Jul 03, 2020 at 06:58:45PM +0200, Laszlo Ersek wrote:
> On 07/03/20 18:18, Daniel P. Berrangé wrote:
> > On Fri, Jul 03, 2020 at 06:14:53PM +0200, Philippe Mathieu-Daudé wrote:
> >> Add an entry to cover firmware.json (see commit 3a0adfc9bf:
> >> schema that describes the different uses and
For the four Spitz-family machines (akita, borzoi, spitz, terrier)
create a proper abstract class SpitzMachineClass which encapsulates
the common behaviour, rather than having them all derive directly
from TYPE_MACHINE:
* instead of each machine class setting mc->init to a wrapper
function whic
Instead of logging guest accesses to invalid register offsets in this
device using zaurus_printf() (which just prints to stderr), use the
usual qemu_log_mask(LOG_GUEST_ERROR,...).
Since this was the only use of the zaurus_printf() macro outside
spitz.c, we can move the definition of that macro fro
1 - 100 of 477 matches
Mail list logo
