[PATCH v2 05/18] modules: add chardev module annotations

Signed-off-by: Gerd Hoffmann --- chardev/baum.c | 1 + chardev/spice.c | 4 2 files changed, 5 insertions(+) diff --git a/chardev/baum.c b/chardev/baum.c index 5deca778bc44..79d618e35045 100644 --- a/chardev/baum.c +++ b/chardev/baum.c @@ -680,6 +680,7 @@ static const TypeInfo

[PATCH v2 02/18] qapi: add ModuleInfo schema

Add QAPI schema for the module info database. Signed-off-by: Gerd Hoffmann --- qapi/meson.build | 1 + qapi/modules.json | 36 qapi/qapi-schema.json | 1 + 3 files changed, 38 insertions(+) create mode 100644 qapi/modules.json diff --git

[PATCH v2 00/18] modules: add metadata database

This patch series adds support for module metadata. Here are the pieces of the puzzle: (1) Macros are added to store metadata in a .modinfo elf section (idea stolen from the linux kernel). (2) A utility to scan modules, collect metadata from the .modinfo sections, store it in a

Re: [PULL 00/12] Machine and OS X changes for 2021-06-08

Daniel P. Berrangé writes: > On Tue, Jun 08, 2021 at 11:40:05AM +0200, Paolo Bonzini wrote: >> The following changes since commit 6f398e533f5e259b4f937f4aa9de970f7201d166: >> >> Merge remote-tracking branch 'remotes/rth-gitlab/tags/pull-tcg-20210604' >> into staging (2021-06-05 11:25:52

Re: [PATCH 1/1] hw/nvme: namespace parameter for EUI64

On Jun 9 22:15, Heinrich Schuchardt wrote: Am 9. Juni 2021 21:57:26 MESZ schrieb Klaus Jensen : On Jun 9 20:13, Heinrich Schuchardt wrote: Am 9. Juni 2021 16:39:20 MESZ schrieb "Daniel P. Berrangé" : On Wed, Jun 09, 2021 at 02:33:08PM +0200, Klaus Jensen wrote: On Jun 9 14:21, Heinrich

Re: [RFC QEMU PATCH] ui: Make the DisplayType enum entries conditional

On 09/06/2021 14.50, Gerd Hoffmann wrote: Hi, The #if CONFIG_SDL approach will not work because qemu will continue to report sdl as supported even when the sdl module is not installed any more. I guess we'd need a separate QMP command to fix that, which tries to load the modules first

Re: [RFC QEMU PATCH] ui: Make the DisplayType enum entries conditional

Gerd Hoffmann writes: > Hi, > >> > The #if CONFIG_SDL approach will not work because qemu will continue to >> > report sdl as supported even when the sdl module is not installed any >> > more. >> >> I guess we'd need a separate QMP command to fix that, which tries to load >> the modules first

Re: [PATCH 53/55] target/arm: Implement MVE VHCADD

On 6/7/21 9:58 AM, Peter Maydell wrote: +#define DO_HADD(N, M) (((int64_t)(N) + (int64_t)(M)) >> 1) +#define DO_HSUB(N, M) (((int64_t)(N) - (int64_t)(M)) >> 1) You've already got do_vhadd_[us] defined from vadd[su]... r~

[Bug 1921948] Re: MTE tags not checked properly for unaligned accesses at EL1

I happened to notice that you're moving your bug tracker to gitlab so I refiled this issue over there: https://gitlab.com/qemu- project/qemu/-/issues/403 ** Bug watch added: gitlab.com/qemu-project/qemu/-/issues #403 https://gitlab.com/qemu-project/qemu/-/issues/403 -- You received this bug

Re: [PATCH V2 0/2] vhost-vDPA: vq notification map support

在 2021/6/2 下午4:41, Jason Wang 写道: Hi All: This series tries to implement doorbell mapping support for vhost-vDPA. Tested with virtio-pci vDPA driver. Please review. Changes since V1: - use dev->vq_index to calculate the virtqueue index - remove the unused host_notifier_set Jason Wang (2):

Re: [PATCH] vl: Fix an assert failure in error path

On 6/9/2021 8:15 PM, Daniel P. Berrangé wrote: > On Wed, Jun 09, 2021 at 02:09:47PM +0200, Markus Armbruster wrote: >> Paolo Bonzini writes: >> >>> On 10/06/21 10:47, Zhenzhong Duan wrote: Based on the description of error_setg(), the local variable err in qemu_maybe_daemonize() should

Re: TCG op for 32 bit only cpu on qemu-riscv64

On 6/7/21 11:52 PM, Richard Henderson wrote: On 6/6/21 8:07 PM, LIU Zhiwei wrote: Hi Alistair, As I see,  we are moving  on to remove TARGET_RISCV64 macro. I have some questions: 1) Which tcg op should use when translate an instruction for 32bit cpu. The tcg_*_i64, tcg_*_i32 or tcg_*_tl?

Re: [PATCH v7 0/4] Add support for ipv6 host forwarding

Ping. On Fri, May 28, 2021 at 4:53 PM Doug Evans wrote: > This patchset takes the original patch from Maxim, > https://www.mail-archive.com/qemu-devel@nongnu.org/msg569573.html > and updates it. > > Option hostfwd is extended to support ipv6 addresses. > Commands hostfwd_add, hostfwd_remove are

[RFC v1] virtio/vsock: add two more queues for datagram types

Datagram sockets are connectionless and unreliable. The sender does not know the capacity of the receiver and may send more packets than the receiver can handle. Add two more dedicate virtqueues for datagram sockets, so that it will not unfairly steal resources from stream and future

[PATCH 1/2] tests: migration-test: Still run the rest even if uffd missing

Currently we'll skip the whole migration-test if uffd missing. It's a bit harsh - we can still run the rest besides postcopy! Enable them when we still can. It'll happen more frequently now after kernel UFFD_USER_MODE_ONLY introduced in commit 37cd0575b8510159, as qemu test normally requires

[PATCH 0/2] tests: migration-test: Fix agressive test skip, add dirty ring test

Based-on: <20210609014355.217110-1-pet...@redhat.com> Patch 1 is a fix for migration test not really running on new kernels. The problem is uffd check now will constantly fail after upstream commit 37cd0575b8510159 - that means any host kernel newer than 5.11. Patch 1 makes it slightly better

[PATCH 2/2] tests: migration-test: Add dirty ring test

Add dirty ring test if kernel supports it. Add the dirty ring parameter on source should be mostly enough, but let's change the dest too to make them match always. Signed-off-by: Peter Xu --- tests/qtest/migration-test.c | 51 +--- 1 file changed, 48

Re: [PATCH 2/2] nbd: Add new qemu:joint-allocation metadata context

On Wed, Jun 9, 2021 at 9:01 PM Eric Blake wrote: > > When trying to reconstruct a qcow2 chain using information provided > over NBD, ovirt had been relying on an unsafe assumption that any > portion of the qcow2 file advertised as sparse would defer to the > backing image; this worked with what

Re: [RFC libnbd PATCH] info: Add support for new qemu:joint-allocation

On Thu, Jun 10, 2021 at 12:32 AM Eric Blake wrote: > > Qemu is adding qemu:joint-allocation as a single context combining the > two bits of base:allocation and a compression of qemu:allocation-depth > into two bits [1]. Decoding the bits makes it easier for humans to > see the result of that

[RFC libnbd PATCH] info: Add support for new qemu:joint-allocation

Qemu is adding qemu:joint-allocation as a single context combining the two bits of base:allocation and a compression of qemu:allocation-depth into two bits [1]. Decoding the bits makes it easier for humans to see the result of that context. [1]

Re: [PATCH 52/55] target/arm: Implement MVE VCADD

On 6/7/21 9:58 AM, Peter Maydell wrote: +#define DO_VCADD(OP, ESIZE, TYPE, H, FN0, FN1) \ +void HELPER(glue(mve_, OP))(CPUARMState *env, void *vd, void *vn, void *vm) \ +{ \ +TYPE *d = vd,

Re: [PATCH 51/55] target/arm: Implement MVE VADC, VSBC

On 6/7/21 9:58 AM, Peter Maydell wrote: +#define DO_VADC(OP, INV)\ +uint32_t HELPER(glue(mve_, OP))(CPUARMState *env, void *vd, \ +void *vn, void *vm, uint32_t nzcv) \ +{

Re: [PATCH 4/4] Jobs based on custom runners: add CentOS Stream 8

On Tue, Jun 8, 2021 at 10:10 AM Cleber Rosa wrote: > > This introduces three different parts of a job designed to run > on a custom runner managed by Red Hat. The goals include: > > a) serve as a model for other organizations that want to onboard > their own runners, with their specific

Re: [PATCH v2 2/2] tpm: Return QMP error when TPM is disabled in build

On Wed, Jun 09, 2021 at 08:49:55PM +0200, Philippe Mathieu-Daudé wrote: > When the management layer queries a binary built using --disable-tpm > for TPM devices, it gets confused by getting empty responses: > ... > > To make it clearer by returning an error: > - Make the TPM QAPI schema

Re: [PATCH v3 00/19] Python: move /scripts/qmp/qom* to /python/qemu/qmp/qom*

On 6/2/21 8:37 PM, John Snow wrote: Closes: https://gitlab.com/qemu-project/qemu/-/issues/202 GitLab: https://gitlab.com/jsnow/qemu/-/commits/python-package-qom CI: https://gitlab.com/jsnow/qemu/-/pipelines/313932818 Hello! -- This series applies the usual linting cleanups to modernize the

Re: [RFC PATCH v2 1/2] qapi: Inline qmp_marshal_output() functions

On Wed, Jun 09, 2021 at 08:49:54PM +0200, Philippe Mathieu-Daudé wrote: > In case we need to use QAPI types but no QAPI command / QAPI event > actually use them, the generated qmp_marshal_output() function will > trigger the compiler 'unused-function' warnings. > To prevent that, emit these

Re: [PATCH 50/55] target/arm: Implement MVE VRHADD

On 6/7/21 9:58 AM, Peter Maydell wrote: Implement the MVE VRHADD insn, which performs a rounded halving addition. Signed-off-by: Peter Maydell --- target/arm/helper-mve.h| 8 target/arm/mve.decode | 3 +++ target/arm/mve_helper.c| 6 ++ target/arm/translate-mve.c

Re: [PATCH v2 2/2] hw/nvme: documentation fix

On Jun 1 20:32, Gollu Appalanaidu wrote: In the documentation of the '-detached' param "be" and "not" has been used side by side, fix that. Signed-off-by: Gollu Appalanaidu --- hw/nvme/ctrl.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/nvme/ctrl.c b/hw/nvme/ctrl.c

Re: [PATCH v2 1/2] hw/nvme: fix endianess conversion and add controller list

On Jun 1 20:32, Gollu Appalanaidu wrote: Add the controller identifiers list CNS 0x13, available list of ctrls in NVM Subsystem that may or may not be attached to namespaces. In Identify Ctrl List of the CNS 0x12 and 0x13 no endian conversion for the nsid field. Signed-off-by: Gollu

Re: [PATCH 49/55] target/arm: Implement MVE VQDMULL (vector)

On 6/7/21 9:58 AM, Peter Maydell wrote: +++ b/target/arm/mve.decode @@ -39,6 +39,8 @@ @1op_nosz &1op qd=%qd qm=%qm size=0 @2op .. size:2 &2op qd=%qd qm=%qm qn=%qn @2op_nosz

Re: [PATCH 1/1] hw/nvme: namespace parameter for EUI64

Am 9. Juni 2021 21:57:26 MESZ schrieb Klaus Jensen : >On Jun 9 20:13, Heinrich Schuchardt wrote: >>Am 9. Juni 2021 16:39:20 MESZ schrieb "Daniel P. Berrangé" >: >>>On Wed, Jun 09, 2021 at 02:33:08PM +0200, Klaus Jensen wrote: On Jun 9 14:21, Heinrich Schuchardt wrote: > On 6/9/21 2:14

Re: [PATCH v2] hw/nvme/ctrl: fix csi field for cns 0x00 and 0x11

On Apr 27 12:00, Gollu Appalanaidu wrote: As per the TP 4056d Namespace types CNS 0x00 and CNS 0x11 CSI field shouldn't use but it is being used for these two Identify command CNS values, fix that. Remove 'nvme_csi_has_nvm_support()' helper as suggested by Klaus we can safely assume NVM command

Re: [PATCH 48/55] target/arm: Implement MVE VQDMLSDH and VQRDMLSDH

On 6/7/21 9:58 AM, Peter Maydell wrote: Implement the MVE VQDMLSDH and VQRDMLSDH insns, which are like VQDMLADH and VQRDMLADH except that products are subtracted rather than added. Signed-off-by: Peter Maydell --- target/arm/helper-mve.h| 16 ++ target/arm/mve.decode |

Re: [PATCH 47/55] target/arm: Implement MVE VQDMLADH and VQRDMLADH

On 6/7/21 9:58 AM, Peter Maydell wrote: +static int32_t do_vqdmladh_w(int32_t a, int32_t b, int32_t c, int32_t d, + int round, bool *sat) +{ +int64_t m1 = (int64_t)a * b; +int64_t m2 = (int64_t)c * d; +int64_t r; +/* + * Architecturally we should

Re: QEmu ARC port - decoder implementation feedback

Hi Richard > Why would you be maintaining another description?  Your approach below > with the simple recursive algorithm appears to be no different. We initially considered to drop our tables completely replacing it by decodetree. > >> Also that decodetree alone would not allow us to

Re: [PATCH 1/1] hw/nvme: namespace parameter for EUI64

On Jun 9 20:13, Heinrich Schuchardt wrote: Am 9. Juni 2021 16:39:20 MESZ schrieb "Daniel P. Berrangé" : On Wed, Jun 09, 2021 at 02:33:08PM +0200, Klaus Jensen wrote: On Jun 9 14:21, Heinrich Schuchardt wrote: > On 6/9/21 2:14 PM, Klaus Jensen wrote: > > On Jun  9 13:46, Heinrich Schuchardt

Re: [PATCH 46/55] target/arm: Implement MVE VRSHL

On 6/7/21 9:58 AM, Peter Maydell wrote: Implement the MVE VRSHL insn (vector form). Signed-off-by: Peter Maydell --- target/arm/helper-mve.h| 8 target/arm/mve.decode | 3 +++ target/arm/mve_helper.c| 36

Re: [PATCH 45/55] target/arm: Implement MVE VSHL insn

On 6/7/21 9:58 AM, Peter Maydell wrote: +static inline uint32_t do_ushl(uint32_t n, int8_t shift, int esize) +{ +if (shift >= esize || shift <= -esize) { +return 0; +} else if (shift < 0) { +return n >> -shift; +} else { +return n << shift; +} +} Current

Re: [PATCH 44/55] target/arm: Implement MVE VQRSHL

On 6/7/21 9:58 AM, Peter Maydell wrote: Implement the MV VQRSHL (vector) insn. Again, the code to perform the actual shifts is borrowed from neon_helper.c. Again, there are helpers in vec_internal.h now. Otherwise, Reviewed-by: Richard Henderson r~

Re: [PATCH 43/55] target/arm: Implement MVE VQSHL (vector)

On 6/7/21 9:58 AM, Peter Maydell wrote: Implement the MVE VQSHL insn (encoding T4, which is the vector-shift-by-vector version). The DO_SQSHL_OP and DO_UQSHL_OP macros here are derived from the neon_helper.c code for qshl_u{8,16,32} and qshl_s{8,16,32}. Ah, from before the sve2 merge, and

Re: [PATCH 42/55] target/arm: Implement MVE VQADD, VQSUB (vector)

On 6/7/21 9:58 AM, Peter Maydell wrote: Implement the vector forms of the MVE VQADD and VQSUB insns. Signed-off-by: Peter Maydell --- target/arm/helper-mve.h| 16 target/arm/mve.decode | 5 + target/arm/mve_helper.c| 14 ++

Re: [PATCH 41/55] target/arm: Implement MVE VQDMULH, VQRDMULH (vector)

On 6/7/21 9:58 AM, Peter Maydell wrote: Implement the vector forms of the MVE VQDMULH and VQRDMULH insns. Signed-off-by: Peter Maydell --- target/arm/helper-mve.h| 8 target/arm/mve.decode | 3 +++ target/arm/mve_helper.c| 27 +++

Re: [PATCH 40/55] target/arm: Implement MVE VQDMULL scalar

On 6/7/21 9:58 AM, Peter Maydell wrote: Implement the MVE VQDMULL scalar insn. This multiplies the top or bottom half of each element by the scalar, doubles and saturates to a double-width result. Note that this encoding overlaps with VQADD and VQSUB; it uses what in VQADD and VQSUB would be

[Bug 1921061] Re: Corsair iCUE Install Fails, qemu VM Reboots

Hi Russel, this bug has been migrated to the new GitLab issue tracker; can you provide me with some extra information over on the new tracker, please? (I am *very* likely to miss updates here.) 1. What is your QEMU command line? (A full, working command-line, but the smallest one you can

Re: [PATCH 39/55] target/arm: Implement MVE VQDMULH and VQRDMULH (scalar)

On 6/7/21 9:58 AM, Peter Maydell wrote: Implement the MVE VQDMULH and VQRDMULH scalar insns, which multiply elements by the scalar, double, possibly round, take the high half and saturate. Signed-off-by: Peter Maydell --- target/arm/helper-mve.h| 8 target/arm/mve.decode |

Re: [PATCH v6 4/4] Jobs based on custom runners: add job definitions for QEMU's machines

On Tue, Jun 8, 2021 at 12:14 AM Cleber Rosa wrote: > > The QEMU project has two machines (aarch64 and s390x) that can be used > for jobs that do build and run tests. This introduces those jobs, > which are a mapping of custom scripts used for the same purpose. > > Signed-off-by: Cleber Rosa >

Re: [PATCH] hmp: Add "calc_dirty_rate" and "info dirty_rate" cmds

On Tue, Jun 08, 2021 at 08:36:23PM +0100, Dr. David Alan Gilbert wrote: > * Peter Xu (pet...@redhat.com) wrote: > > On Tue, Jun 08, 2021 at 07:49:56PM +0100, Dr. David Alan Gilbert wrote: > > > * Peter Xu (pet...@redhat.com) wrote: > > > > These two commands are missing when adding the QMP sister

[PATCH v2 2/2] tpm: Return QMP error when TPM is disabled in build

When the management layer queries a binary built using --disable-tpm for TPM devices, it gets confused by getting empty responses: { "execute": "query-tpm" } { "return": [ ] } { "execute": "query-tpm-types" } { "return": [ ] } { "execute": "query-tpm-models"

[RFC PATCH v2 1/2] qapi: Inline qmp_marshal_output() functions

In case we need to use QAPI types but no QAPI command / QAPI event actually use them, the generated qmp_marshal_output() function will trigger the compiler 'unused-function' warnings. To prevent that, emit these functions inlined: the compiler will ignore such unused functions. Signed-off-by:

[PATCH v2 0/2] tpm: Return QMP error when TPM is disabled in build

Since v1: - make the qapi schema conditional (Marc-André) Philippe Mathieu-Daudé (2): qapi: Inline qmp_marshal_output() functions tpm: Return QMP error when TPM is disabled in build qapi/tpm.json| 9 ++--- monitor/hmp-cmds.c | 4 stubs/tpm.c | 16

Re: [PATCH 38/55] target/arm: Implement MVE VQADD and VQSUB

On 6/7/21 9:58 AM, Peter Maydell wrote: +#define DO_2OP_SAT_SCALAR(OP, ESIZE, TYPE, H, FN) \ +void HELPER(glue(mve_, OP))(CPUARMState *env, void *vd, void *vn, \ +uint32_t rm)\ +{

Re: [PATCH v3 19/33] block/nbd: split nbd_handle_updated_info out of nbd_client_handshake()

On Wed, Jun 09, 2021 at 08:23:06PM +0300, Vladimir Sementsov-Ogievskiy wrote: > > > +if (s->x_dirty_bitmap) { > > > +if (!s->info.base_allocation) { > > > +error_setg(errp, "requested x-dirty-bitmap %s not found", > > > + s->x_dirty_bitmap); > > > +

Re: [PATCH 37/55] target/arm: Implement MVE VPST

On 6/7/21 9:58 AM, Peter Maydell wrote: Implement the MVE VPST insn, which sets the predicate mask fields in the VPR to the immediate value encoded in the insn. Signed-off-by: Peter Maydell --- target/arm/mve.decode | 4 +++ target/arm/translate-mve.c | 59

Re: [PATCH v3 7/7] migration/dirtyrate: implement dirty-ring dirtyrate calculation

On Mon, Jun 07, 2021 at 09:15:20AM +0800, huang...@chinatelecom.cn wrote: > +static void calculate_dirtyrate_vcpu(struct DirtyRateConfig config) > +{ > +CPUState *cpu; > +int64_t msec = 0; > +int64_t start_time; > +uint64_t dirtyrate = 0; > +uint64_t dirtyrate_sum = 0; > +

Re: [PATCH 1/1] hw/nvme: namespace parameter for EUI64

Am 9. Juni 2021 16:39:20 MESZ schrieb "Daniel P. Berrangé" : >On Wed, Jun 09, 2021 at 02:33:08PM +0200, Klaus Jensen wrote: >> On Jun 9 14:21, Heinrich Schuchardt wrote: >> > On 6/9/21 2:14 PM, Klaus Jensen wrote: >> > > On Jun  9 13:46, Heinrich Schuchardt wrote: >> > > > The EUI64 field is the

Re: [PATCH 36/55] target/arm: Implement MVE VBRSR

On 6/7/21 9:58 AM, Peter Maydell wrote: Implement the MVE VBRSR insn, which reverses a specified number of bits in each element, setting the rest to zero. Signed-off-by: Peter Maydell --- target/arm/helper-mve.h| 4 target/arm/mve.decode | 1 + target/arm/mve_helper.c|

Re: [PATCH 35/55] target/arm: Implement MVE VHADD, VHSUB (scalar)

On 6/7/21 9:58 AM, Peter Maydell wrote: Implement the scalar variants of the MVE VHADD and VHSUB insns. Signed-off-by: Peter Maydell --- target/arm/helper-mve.h| 16 target/arm/mve.decode | 4 target/arm/mve_helper.c| 8

[PATCH 2/2] nbd: Add new qemu:joint-allocation metadata context

When trying to reconstruct a qcow2 chain using information provided over NBD, ovirt had been relying on an unsafe assumption that any portion of the qcow2 file advertised as sparse would defer to the backing image; this worked with what qemu 5.2 reports for a qcow2 BSD loaded with "backing":null.

[PATCH 1/2] iotests: Improve and rename test 309 to nbd-qemu-allocation

Enhance the test to inspect what qemu-nbd is advertising during handshake, and rename it now that we support useful iotest names. Signed-off-by: Eric Blake --- .../qemu-iotests/{309 => tests/nbd-qemu-allocation} | 5 - .../{309.out => tests/nbd-qemu-allocation.out} | 12 +++-

[RFC PATCH 0/2] New NBD metacontext

This is my counter-proposal to Nir's request [1] to revert a 6.0 behavior change. It does not expose any new information over NBD, but does make it easier to collect necessary information from a single context rather than requiring the client to have to request two contexts in parallel, then

Re: [PATCH 34/55] target/arm: Implement MVE VSUB, VMUL (scalar)

On 6/7/21 9:58 AM, Peter Maydell wrote: Implement the scalar forms of the MVE VSUB and VMUL insns. Signed-off-by: Peter Maydell --- target/arm/helper-mve.h| 8 target/arm/mve.decode | 2 ++ target/arm/mve_helper.c| 2 ++ target/arm/translate-mve.c | 2 ++ 4 files

Re: [PATCH 33/55] target/arm: Implement MVE VADD (scalar)

On 6/7/21 9:57 AM, Peter Maydell wrote: Implement the scalar form of the MVE VADD insn. This takes the scalar operand from a general purpose register. Signed-off-by: Peter Maydell --- target/arm/helper-mve.h| 4 target/arm/mve.decode | 7 ++ target/arm/mve_helper.c|

Re: [PATCH v6 3/4] Jobs based on custom runners: docs and gitlab-runner setup playbook

On Tue, Jun 8, 2021 at 12:14 AM Cleber Rosa wrote: > > To have the jobs dispatched to custom runners, gitlab-runner must > be installed, active as a service and properly configured. The > variables file and playbook introduced here should help with those > steps. > > The playbook introduced here

Re: [PATCH] tpm: Return QMP error when TPM is disabled in build

On 6/9/21 7:36 PM, Daniel P. Berrangé wrote: > On Wed, Jun 09, 2021 at 07:34:32PM +0200, Philippe Mathieu-Daudé wrote: >> On 6/9/21 7:27 PM, Philippe Mathieu-Daudé wrote: >>> On 6/9/21 6:01 PM, Marc-André Lureau wrote: Hi On Wed, Jun 9, 2021 at 7:33 PM Philippe Mathieu-Daudé >>>

Re: [PATCH] block: Move read-only check during truncation earlier

Am 09.06.2021 um 18:30 hat Eric Blake geschrieben: > No need to start a tracked request that will always fail. The choice > to check read-only after bdrv_inc_in_flight() predates 1bc5f09f2e > (block: Use tracked request for truncate), but waiting for serializing > requests can make the effect

Re: [PATCH v14 1/8] arm64: mte: Handle race when synchronising tags

On Wed, Jun 09, 2021 at 12:19:31PM +0100, Marc Zyngier wrote: > On Wed, 09 Jun 2021 11:51:34 +0100, > Steven Price wrote: > > On 09/06/2021 11:30, Marc Zyngier wrote: > > > On Mon, 07 Jun 2021 12:08:09 +0100, > > > Steven Price wrote: > > >> diff --git a/arch/arm64/kernel/mte.c

Re: [PATCH] tpm: Return QMP error when TPM is disabled in build

On Wed, Jun 09, 2021 at 07:34:32PM +0200, Philippe Mathieu-Daudé wrote: > On 6/9/21 7:27 PM, Philippe Mathieu-Daudé wrote: > > On 6/9/21 6:01 PM, Marc-André Lureau wrote: > >> Hi > >> > >> On Wed, Jun 9, 2021 at 7:33 PM Philippe Mathieu-Daudé >> > wrote: > >> > >>

Re: [PATCH] tpm: Return QMP error when TPM is disabled in build

On 6/9/21 7:27 PM, Philippe Mathieu-Daudé wrote: > On 6/9/21 6:01 PM, Marc-André Lureau wrote: >> Hi >> >> On Wed, Jun 9, 2021 at 7:33 PM Philippe Mathieu-Daudé > > wrote: >> >> When the management layer queries a binary built using --disable-tpm >> for TPM

Re: [PATCH] tpm: Return QMP error when TPM is disabled in build

On 6/9/21 6:01 PM, Marc-André Lureau wrote: > Hi > > On Wed, Jun 9, 2021 at 7:33 PM Philippe Mathieu-Daudé > wrote: > > When the management layer queries a binary built using --disable-tpm > for TPM devices, it gets confused by getting empty responses: > >

Re: [PATCH v3 3/4] scripts: helper to generate x86_64 CPU ABI compat info

On Mon, Jun 07, 2021 at 02:58:42PM +0100, Daniel P. Berrangé wrote: > This script is what is used to generate the docs data table in: > > docs/system/cpu-models-x86-abi.csv > > It can be useful to run if adding new CPU models / versions and > the csv needs updating. > > Signed-off-by: Daniel

Re: [PATCH v3 19/33] block/nbd: split nbd_handle_updated_info out of nbd_client_handshake()

03.06.2021 19:29, Eric Blake wrote: On Fri, Apr 16, 2021 at 11:08:57AM +0300, Vladimir Sementsov-Ogievskiy wrote: To be reused in the following patch. Signed-off-by: Vladimir Sementsov-Ogievskiy --- block/nbd.c | 99 ++--- 1 file changed, 57

Re: [PATCH v6 2/4] Jobs based on custom runners: build environment docs and playbook

On Tue, Jun 8, 2021 at 12:14 AM Cleber Rosa wrote: > > To run basic jobs on custom runners, the environment needs to be > properly set up. The most common requirement is having the right > packages installed. > > The playbook introduced here covers the QEMU's project s390x and > aarch64

Re: [PATCH 20/55] target/arm: Implement MVE VDUP

On 6/9/21 3:06 AM, Peter Maydell wrote: Mmm. I think some of this structure is holdover from an initial misinterpretation of the spec that all these ops looked at the predicate bit for the LS byte of the element to see if the entire element was acted upon, in which case you do need to work

Re: [PATCH v6 2/4] Jobs based on custom runners: build environment docs and playbook

On Wed, Jun 9, 2021 at 11:26 AM Alex Bennée wrote: > > Cleber Rosa Junior writes: > > > On Wed, Jun 9, 2021 at 9:36 AM Alex Bennée > wrote: > > > > Cleber Rosa writes: > > > > > To run basic jobs on custom runners, the environment needs to be > > > properly set up. The most common

Re: [PATCH 11/55] target/arm: Implement MVE VLDR/VSTR (non-widening forms)

On 6/9/21 3:01 AM, Peter Maydell wrote: Is the spec forward looking to more than 7 Q registers? It's tempting to just drop the D:Qd from the decode... I don't know, but looking at the decode it certainly seems like the door is being left open to Q8..Q15. Other signs of this include the

Re: GSoC Intro - TUI interface for QMP

On 6/9/21 7:56 AM, Markus Armbruster wrote: The client could cache the information. (Against what kind of an identifier? Can QEMU report some kind of token that uniquely identifies its binary or uniquely identifies the set of QAPI commands it supports?) I proposed something like it to permit

Re: [PULL 0/9] migration queue

On Wed, 9 Jun 2021 at 15:47, Dr. David Alan Gilbert (git) wrote: > > From: "Dr. David Alan Gilbert" > > The following changes since commit a4716fd8d7c877185652f5f8e25032dc7699d51b: > > Merge remote-tracking branch > 'remotes/alistair/tags/pull-riscv-to-apply-20210608-1' into staging >

Re: [PATCH 05/26] configure, meson: convert pam detection to meson

On 6/9/21 8:57 AM, Daniel P. Berrangé wrote: On Wed, Jun 09, 2021 at 08:46:22AM -0700, Richard Henderson wrote: If not have_system, there's no point in looking for pam *at all* regardless of get_option(). In theory we can simplify to if have_system pam = cc.find_library('pam',

Re: [PATCH] block: Move read-only check during truncation earlier

09.06.2021 19:30, Eric Blake wrote: No need to start a tracked request that will always fail. The choice to check read-only after bdrv_inc_in_flight() predates 1bc5f09f2e (block: Use tracked request for truncate), but waiting for serializing requests can make the effect more noticeable.

Re: [PATCH v4 0/6] Allow changing bs->file on reopen

09.06.2021 18:53, Kevin Wolf wrote: Am 14.05.2021 um 17:53 hat Vladimir Sementsov-Ogievskiy geschrieben: Hi Alberto! What are your plans for v5? I'm now finishing a new series which makes backup-top filter public, and I want to base it on your series (otherwise I can't add a test). Berto,

Re: QEmu ARC port - decoder implementation feedback

On 6/9/21 2:58 AM, Cupertino Miranda wrote: We started to do that and in the process we realize that the approach would bring us yet another encoding language description to maintain. Why would you be maintaining another description? Your approach below with the simple recursive algorithm

[PATCH] block: Move read-only check during truncation earlier

No need to start a tracked request that will always fail. The choice to check read-only after bdrv_inc_in_flight() predates 1bc5f09f2e (block: Use tracked request for truncate), but waiting for serializing requests can make the effect more noticeable. Signed-off-by: Eric Blake --- block/io.c |

Re: [PATCH v4 3/7] block: add max_hw_transfer to BlockLimits

On Tue, 2021-06-08 at 15:16 +0200, Paolo Bonzini wrote: > For block host devices, I/O can happen through either the kernel file > descriptor I/O system calls (preadv/pwritev, io_submit, io_uring) > or the SCSI passthrough ioctl SG_IO. > > In the latter case, the size of each transfer can be

Re: [PATCH v4 2/7] scsi-generic: pass max_segments via max_iov field in BlockLimits

On Tue, 2021-06-08 at 15:16 +0200, Paolo Bonzini wrote: > I/O to a disk via read/write is not limited by the number of segments allowed > by the host adapter; the kernel can split requests if needed, and the limit > imposed by the host adapter can be very low (256k or so) to avoid that SG_IO >

Re: [PATCH v4 1/7] file-posix: fix max_iov for /dev/sg devices

On Tue, 2021-06-08 at 22:14 +0300, Vladimir Sementsov-Ogievskiy wrote: > 08.06.2021 16:16, Paolo Bonzini wrote: > > Even though it was only called for devices that have bs->sg set (which > > must be character devices), sg_get_max_segments looked at /sys/dev/block > > which only works for block

Re: [PATCH v4 4/7] file-posix: try BLKSECTGET on block devices too, do not round to power of 2

On Tue, 2021-06-08 at 15:16 +0200, Paolo Bonzini wrote: > bs->sg is only true for character devices, but block devices can also > be used with scsi-block and scsi-generic. Unfortunately BLKSECTGET > returns bytes in an int for /dev/sgN devices, and sectors in a short > for block devices, so

Re: [PATCH v6 2/4] Jobs based on custom runners: build environment docs and playbook

On Tue, Jun 8, 2021 at 3:48 PM Wainer dos Santos Moschetta wrote: > > Hi, > > On 6/8/21 12:14 AM, Cleber Rosa wrote: > > To run basic jobs on custom runners, the environment needs to be > > properly set up. The most common requirement is having the right > > packages installed. > > > > The

Re: [PATCH] tpm: Return QMP error when TPM is disabled in build

Hi On Wed, Jun 9, 2021 at 7:33 PM Philippe Mathieu-Daudé wrote: > When the management layer queries a binary built using --disable-tpm > for TPM devices, it gets confused by getting empty responses: > > { "execute": "query-tpm" } > { > "return": [ > ] > } > { "execute":

Re: [RFC PATCH v2 0/2] cputlb: implement load_helper_unaligned() for unaligned loads

On 09/06/2021 15:10, Philippe Mathieu-Daudé wrote: (Added gitlab issue email) Reposting Mark's patch: https://www.mail-archive.com/qemu-devel@nongnu.org/msg814227.html but split in 2 patches for easier review. Mark Cave-Ayland (1): cputlb: implement load_helper_unaligned() for unaligned

[PATCH v2 9/9] virtiofsd: Add lazy lo_do_find()

lo_find() right now takes two lookup keys for two maps, namely the file handle for inodes_by_handle and the statx information for inodes_by_ids. However, we only need the statx information if looking up the inode by the file handle failed. There are two callers of lo_find(): The first one,

[PATCH v2 4/9] virtiofsd: Let lo_fd() return a TempFd

Accessing lo_inode.fd must generally happen through lo_inode_fd(), and lo_fd() is no exception; and then it must pass on the TempFd it has received from lo_inode_fd(). (Note that all lo_fd() calls now use proper error handling, where all of them were in-line before; i.e. they were used in place

Re: [PATCH 05/26] configure, meson: convert pam detection to meson

On Wed, Jun 09, 2021 at 08:46:22AM -0700, Richard Henderson wrote: > On 6/8/21 1:20 PM, Daniel P. Berrangé wrote: > > On Tue, Jun 08, 2021 at 12:45:51PM -0700, Richard Henderson wrote: > > > On 6/8/21 4:22 AM, Paolo Bonzini wrote: > > > > +pam = not_found > > > > +if not

[PATCH v2 8/9] virtiofsd: Optionally fill lo_inode.fhandle

When the inode_file_handles option is set, try to generate a file handle for new inodes instead of opening an O_PATH FD. Being able to open these again will require CAP_DAC_READ_SEARCH, so the description text tells the user they will also need to specify -o modcaps=+dac_read_search. Generating

[PATCH v2 2/9] virtiofsd: Use lo_inode_open() instead of openat()

The xattr functions want a non-O_PATH FD, so they reopen the lo_inode.fd with the flags they need through /proc/self/fd. Similarly, lo_opendir() needs an O_RDONLY FD. Instead of the /proc/self/fd trick, it just uses openat(fd, "."), because the FD is guaranteed to be a directory, so this works.

[PATCH v2 6/9] virtiofsd: Add lo_inode.fhandle

This new field is an alternative to lo_inode.fd: Either of the two must be set. In case an O_PATH FD is needed for some lo_inode, it is either taken from lo_inode.fd, if valid, or a temporary FD is opened with open_by_handle_at(). Using a file handle instead of an FD has the advantage of keeping

Re: [PATCH v3 14/33] nbd: move connection code from block/nbd to nbd/client-connection

28.04.2021 11:14, Vladimir Sementsov-Ogievskiy wrote: +struct NBDClientConnection { +    /* Initialization constants */ +    SocketAddress *saddr; /* address to connect to */ + +    /* + * Result of last attempt. Valid in FAIL and SUCCESS states. + * If you want to steal error, don't

[PATCH v2 5/9] virtiofsd: Let lo_inode_open() return a TempFd

Strictly speaking, this is not necessary, because lo_inode_open() will always return a new FD owned by the caller, so TempFd.owned will always be true. However, auto-cleanup is nice, and in some cases this plays nicely with an lo_inode_fd() call in another conditional branch (see lo_setattr()).

[PATCH v2 7/9] virtiofsd: Add inodes_by_handle hash table

Currently, lo_inode.fhandle is always NULL and so always keep an O_PATH FD in lo_inode.fd. Therefore, when the respective inode is unlinked, its inode ID will remain in use until we drop our lo_inode (and lo_inode_put() thus closes the FD). Therefore, lo_find() can safely use the inode ID as an

[PATCH 6/7] vhost-user-blk: Factor out vhost_user_blk_realize_connect()

This function is the part that we will want to retry if the connection is lost during initialisation, so factor it out to keep the following patch simpler. The error path for vhost_dev_get_config() forgot disconnecting the chardev, add this while touching the code. Signed-off-by: Kevin Wolf ---

[PATCH v2 3/9] virtiofsd: Add lo_inode_fd() helper

Once we let lo_inode.fd be optional, we will need its users to open the file handle stored in lo_inode instead. This function will do that. For now, it just returns lo_inode.fd, though. Signed-off-by: Max Reitz Reviewed-by: Connor Kuehl --- tools/virtiofsd/passthrough_ll.c | 138

  1   2   3   >