Re: [PULL 09/20] target/tricore: Fix out-of-bounds index in imask instruction

2023-06-22 Thread Michael Tokarev
22.06.2023 17:51, Bastian Koppelmann wrote: .. Is it a -stable material? Yes. If you pick this up, make sure you also pick up https://lore.kernel.org/qemu-devel/20230621161422.1652151-1-kbast...@mail.uni-paderborn.de/T/#md18391dd165c4fc2e60ddefb886f3522e715f487 which applies the same fix to ot

Re: [PATCH v4 08/17] tcg: Fix temporary variable in tcg_gen_gvec_andcs

2023-06-22 Thread Richard Henderson
On 6/22/23 19:30, Daniel Henrique Barboza wrote: On 6/22/23 13:16, Max Chou wrote: The 5th parameter of tcg_gen_gvec_2s should be replaces by the temporary s/replaces/replaced tmp variable in the tcg_gen_gvec_andcs function. Signed-off-by: Max Chou --- Reviewed-by: Daniel Henrique Bar

Re: [PATCH v3 0/4] Virtio shared dma-buf

2023-06-22 Thread Michael S. Tsirkin
On Wed, May 24, 2023 at 11:13:29AM +0200, Albert Esteve wrote: > v1 link -> https://lists.gnu.org/archive/html/qemu-devel/2023-05/msg00598.html > v2 link -> https://lists.gnu.org/archive/html/qemu-devel/2023-05/msg04530.html > v2 -> v3: > - Change UUID hash function strategy to djb > - Add

Re: [PATCH v3 4/4] vhost-user: refactor send_resp code

2023-06-22 Thread Michael S. Tsirkin
On Wed, May 24, 2023 at 11:13:33AM +0200, Albert Esteve wrote: > Refactor code to send response message so that > all common parts both for the common REPLY_ACK > case, and other data responses, can call it and > avoid code repetition. > > Signed-off-by: Albert Esteve > --- > hw/virtio/vhost-use

Re: [PATCH v3 3/4] vhost-user: add shared_object msg

2023-06-22 Thread Michael S. Tsirkin
On Wed, May 24, 2023 at 11:13:32AM +0200, Albert Esteve wrote: > Add new vhost-user protocol message > `VHOST_USER_BACKEND_SHARED_OBJECT`. This new > message is sent from vhost-user back-ends > to interact with the virtio-dmabuf table > in order to add, remove, or lookup for > virtio dma-buf shared

Re: [PATCH v2 5/7] spapr: TCG allow up to 8-thread SMT on POWER8 and newer CPUs

2023-06-22 Thread Cédric Le Goater
On 6/22/23 12:49, Cédric Le Goater wrote: On 6/22/23 12:06, Cédric Le Goater wrote: On 6/22/23 11:33, Nicholas Piggin wrote: PPC TCG supports SMT CPU configurations for non-hypervisor state, so permit POWER8-10 pseries machines to enable SMT. This requires PIR and TIR be set, because that's ho

[PATCH v1] virtio-gpu: Make non-gl display updates work again when blob=true

2023-06-22 Thread Vivek Kasireddy
In the case where the console does not have gl capability, and if blob is set to true, make sure that the display updates still work. Commit e86a93f55463 accidentally broke this by misplacing the return statement (in resource_flush) causing the updates to be silently ignored. Fixes: e86a93f55463 (

Re: [PATCH v1 0/5] virtio-mem: Device unplug support

2023-06-22 Thread Michael S. Tsirkin
On Tue, Jun 13, 2023 at 05:02:05PM +0200, David Hildenbrand wrote: > One limitation of virtio-mem is that we cannot currently unplug virtio-mem > devices that have all memory unplugged from the VM. > > Let's properly handle forced unplug (as can be triggered by the VM) and > add support for ordina

Re: [PATCH v3 00/12] Start replacing target_ulong with vaddr

2023-06-22 Thread Richard Henderson
On 6/21/23 15:56, Anton Johansson wrote: This is a first patchset in removing target_ulong from non-target/ directories. As use of target_ulong is spread accross the codebase we are attempting to target as few maintainers as possible with each patchset in order to ease reviewing. The following

Re: [RFC PATCH] softfloat: use QEMU_FLATTEN to avoid mistaken isra inlining

2023-06-22 Thread Richard Henderson
On 6/22/23 22:55, BALATON Zoltan wrote: Hello, What happened to this patch? Will this be merged by somebody? Thanks for the reminder. Queued to tcg-next. r~ Regards, BALATON Zoltan On Tue, 23 May 2023, BALATON Zoltan wrote: On Tue, 23 May 2023, Alex Bennée wrote: Balton discovered that

Re: [PATCH v2 1/2] qmp: remove virtio_list, search QOM tree instead

2023-06-22 Thread Michael S. Tsirkin
On Fri, Jun 09, 2023 at 09:20:39AM -0400, Jonah Palmer wrote: > The virtio_list duplicates information about virtio devices that already > exist in the QOM composition tree. Instead of creating this list of > realized virtio devices, search the QOM composition tree instead. > > This patch modifies

Re: [PULL 00/30] Next patches

2023-06-22 Thread Richard Henderson
On 6/22/23 18:54, Juan Quintela wrote: The following changes since commit b455ce4c2f300c8ba47cba7232dd03261368a4cb: Merge tag 'q800-for-8.1-pull-request' ofhttps://github.com/vivier/qemu-m68k into staging (2023-06-22 10:18:32 +0200) are available in the Git repository at: https://gitla

Re: [PATCH v2 2/2] qmp: update virtio feature maps, vhost-user-gpio instrospection

2023-06-22 Thread Michael S. Tsirkin
On Fri, Jun 09, 2023 at 09:20:40AM -0400, Jonah Palmer wrote: > Add new virtio transport feature to transport feature map: > - VIRTIO_F_RING_RESET > > Add new vhost-user protocol feature to vhost-user protocol feature map > and enumeration: > - VHOST_USER_PROTOCOL_F_STATUS > > Add new virtio de

Re: [PATCH] vhost: fix vhost_dev_enable_notifiers() error case

2023-06-22 Thread Michael S. Tsirkin
On Wed, Jun 07, 2023 at 12:32:31PM +0300, Michael Tokarev wrote: > 02.06.2023 19:27, Laurent Vivier wrote: > > in vhost_dev_enable_notifiers(), if virtio_bus_set_host_notifier(true) > > fails, we call vhost_dev_disable_notifiers() that executes > > virtio_bus_set_host_notifier(false) on all queues,

[PATCH] gdbstub: Permit reverse step/break to provide stop response

2023-06-22 Thread Nicholas Piggin
The final part of the reverse step and break handling is to bring the machine back to a debug stop state. gdb expects a response. A gdb 'rsi' command hangs forever because the gdbstub filters out the response (also observable with reverse_debugging.py avocado tests). Fix by setting allow_stop_rep

Re: How do you represent a host gcc and a cross gcc in lcitool?

2023-06-22 Thread Alistair Francis
On Thu, Jun 1, 2023 at 4:58 AM Alex Bennée wrote: > > > Brian Cain writes: > > >> -Original Message- > >> From: Alex Bennée > >> Sent: Wednesday, May 31, 2023 6:24 AM > >> To: Daniel P.Berrangé > >> Cc: qemu-devel ; Michael Tokarev > >> ; Erik Skultety ; Brian Cain > >> ; Palmer Dabbelt

Re: [PATCH] linux-user/riscv: Add syscall riscv_hwprobe

2023-06-22 Thread Alistair Francis
On Mon, Jun 19, 2023 at 6:25 PM Robbin Ehn wrote: > > This patch adds the new syscall for the > "RISC-V Hardware Probing Interface" > (https://docs.kernel.org/riscv/hwprobe.html). > > Reviewed-by: Palmer Dabbelt > Signed-off-by: Robbin Ehn Thanks for the patch! Do you mind re-sending this when

Re: [PATCH 0/2] target/riscv: Fix the xlen for data address when MPRV=1

2023-06-22 Thread Alistair Francis
On Wed, Jun 14, 2023 at 1:27 PM Weiwei Li wrote: > > Currently, we use the current env->xl as the xlen for address. However, the > xlen for data address should be changed to the xlen related to MPP when > MPRV=1. > > The port is available here: > https://github.com/plctlab/plct-qemu/tree/plct-ad

Re: [PATCH] target/riscv: fix the issue of guest reboot then no response or crash in kvm-mode

2023-06-22 Thread Alistair Francis
On Mon, Jun 12, 2023 at 11:07 PM liguang.zhang <18622748...@163.com> wrote: > > From: "liguang.zhang" Hello, thanks for the patch > > There have a issue of guest reboot bug in kvm-mode: > 1. in guest shell just run the reboot, guest can't reboot success, and host > kvm stop the vcpu schedual. >

Re: [PATCH] STM32F100: add support for external memory via FSMC

2023-06-22 Thread Alistair Francis
On Wed, Jun 21, 2023 at 5:44 AM Lucas Villa Real wrote: > > Add support for FSMC on high-density STM32F100 devices and enable > mapping of additional memory via the `-m SIZE` command-line option. > FSMC Bank1 can address up to 4x64MB of PSRAM memory at 0x6000. Thanks for the patches! > > RCC

Re: [PATCH] STM32F100: support different density lines

2023-06-22 Thread Alistair Francis
On Tue, Jun 20, 2023 at 8:20 AM Lucas Villa Real wrote: > > This patch adds support for the emulation of different density lines > (low, medium, and high). A new class property stm32f100-soc.density= > has been introduced to allow users to state the desired configuration. > That property is recogn

Re: [PATCH v4 0/2] vhost: register and change IOMMU flag depending on ATS state

2023-06-22 Thread Michael S. Tsirkin
On Thu, May 25, 2023 at 03:57:40PM +0300, Viktor Prutyanov wrote: > When IOMMU and vhost are enabled together, QEMU tracks IOTLB or > Device-TLB unmap events depending on whether Device-TLB is enabled. But > even if Device-TLB and PCI ATS is enabled, the guest can reject to use > it. For example, t

Re: [PATCH v4 00/15] vfio: VFIO migration support with vIOMMU

2023-06-22 Thread Joao Martins
On 22/06/2023 22:48, Joao Martins wrote: > Hey, > > This series introduces support for vIOMMU with VFIO device migration, > particurlarly related to how we do the dirty page tracking. > > Today vIOMMUs serve two purposes: 1) enable interrupt remaping 2) > provide dma translation services for gues

[PATCH] net: add initial support for AF_XDP network backend

2023-06-22 Thread Ilya Maximets
AF_XDP is a network socket family that allows communication directly with the network device driver in the kernel, bypassing most or all of the kernel networking stack. In the essence, the technology is pretty similar to netmap. But, unlike netmap, AF_XDP is Linux-native and works with any networ

Re: [PATCH RFC 0/6] Switch iotests to pyvenv

2023-06-22 Thread Paolo Bonzini
Il gio 22 giu 2023, 23:18 John Snow ha scritto: > Possibly I could teach mkvenv a new trick, like "mkvenv init iotests" > and have the mkvenv script DTRT at that point, whatever that is -- > ideally exiting very quickly without doing anything. > Or maybe check itself should do the bootstrap if i

[PATCH v4 12/15] vfio/common: Support device dirty page tracking with vIOMMU

2023-06-22 Thread Joao Martins
Currently, device dirty page tracking with vIOMMU is not supported, and a blocker is added and the migration is prevented. When vIOMMU is used, IOVA ranges are DMA mapped/unmapped on the fly as requesting by the vIOMMU. These IOVA ranges can potentially be mapped anywhere in the vIOMMU IOVA space

[PATCH v4 10/15] intel-iommu: Implement IOMMU_ATTR_MAX_IOVA get_attr() attribute

2023-06-22 Thread Joao Martins
From: Avihai Horon Implement get_attr() method and use the address width property to report the IOMMU_ATTR_MAX_IOVA attribute. Signed-off-by: Avihai Horon Signed-off-by: Joao Martins --- hw/i386/intel_iommu.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/hw/i386/intel_iommu.c b/h

[PATCH v4 11/15] vfio/common: Move dirty tracking ranges update to helper

2023-06-22 Thread Joao Martins
Separate the changes that updates the ranges from the listener, to make it reusable in preparation to expand its use to vIOMMU support. Signed-off-by: Joao Martins --- hw/vfio/common.c | 36 +--- 1 file changed, 21 insertions(+), 15 deletions(-) diff --git a/hw/v

[PATCH v4 14/15] vfio/common: Optimize device dirty page tracking with vIOMMU

2023-06-22 Thread Joao Martins
From: Avihai Horon When vIOMMU is enabled, syncing dirty page bitmaps is done by replaying the vIOMMU mappings and querying the dirty bitmap for each mapping. With device dirty tracking this causes a lot of overhead, since the HW is queried many times (even with small idle guest this can end up

[PATCH v4 13/15] vfio/common: Extract vIOMMU code from vfio_sync_dirty_bitmap()

2023-06-22 Thread Joao Martins
From: Avihai Horon Extract vIOMMU code from vfio_sync_dirty_bitmap() to a new function and restructure the code. This is done in preparation for optimizing vIOMMU deviice dirty page tracking. No functional changes intended. Signed-off-by: Avihai Horon Signed-off-by: Joao Martins --- hw/vfio/

[PATCH v4 02/15] hw/pci: Refactor pci_device_iommu_address_space()

2023-06-22 Thread Joao Martins
From: Yi Liu Refactor pci_device_iommu_address_space() and move the code that fetches the device bus and iommu bus into its own private helper pci_device_get_iommu_bus_devfn(). This is in preparation to introduce pci_device_iommu_get_attr() which will need to use it too. Signed-off-by: Yi Liu

[PATCH v4 09/15] memory/iommu: Add IOMMU_ATTR_MAX_IOVA attribute

2023-06-22 Thread Joao Martins
From: Avihai Horon Add a new IOMMU attribute IOMMU_ATTR_MAX_IOVA which indicates the maximal IOVA that an IOMMU can use. This attribute will be used by VFIO device dirty page tracking so it can track the entire IOVA space when needed (i.e. when vIOMMU is enabled). Signed-off-by: Avihai Horon S

[PATCH v4 05/15] memory/iommu: Add IOMMU_ATTR_DMA_TRANSLATION attribute

2023-06-22 Thread Joao Martins
Add a new IOMMU attribute IOMMU_ATTR_DMA_TRANSLATION which indicates whether the IOMMU supports DMA Translation. This attribute will be used by VFIO device dirty page tracking so it can restrict the IOVA under tracking to the memory map when vIOMMU is enabled only for interrupt remapping without d

[PATCH v4 03/15] hw/pci: Introduce pci_device_iommu_get_attr()

2023-06-22 Thread Joao Martins
From: Yi Liu Introduce pci_device_iommu_get_attr() to get vIOMMU attributes from the PCI device. This is in preparation to ask if vIOMMU has dma translation enabled and also to get IOVA boundaries. Signed-off-by: Yi Liu [joao: Massage commit message; add one more argument in pci_device_get_io

[PATCH v4 15/15] vfio/common: Block migration with vIOMMUs without address width limits

2023-06-22 Thread Joao Martins
Only block the case when the underlying vIOMMU model does not report any address space limits, in addition to DMA translation being off or no vIOMMU present. The limits are needed such that can define the IOVA limits that arm the device dirty tracker. Additionally, reword the migration blocker err

[PATCH v4 08/15] vfio/common: Relax vIOMMU detection when DMA translation is off

2023-06-22 Thread Joao Martins
Relax the vIOMMU migration blocker when the underlying IOMMU reports DMA translation disabled. When it is disabled there will be no DMA mappings via the vIOMMU and the guest can only use it for Interrupt Remapping. The latter is done via vfio_viommu_preset() return value where in addition to valid

[PATCH v4 06/15] intel-iommu: Implement get_attr() method

2023-06-22 Thread Joao Martins
Implement IOMMU MR get_attr() method and use the dma_translation property to report the IOMMU_ATTR_DMA_TRANSLATION attribute. Additionally add the necessary get_iommu_attr into the PCIIOMMUOps to support pci_device_iommu_get_attr(). The callback in there acts as a IOMMU-specific address space walk

[PATCH v4 00/15] vfio: VFIO migration support with vIOMMU

2023-06-22 Thread Joao Martins
Hey, This series introduces support for vIOMMU with VFIO device migration, particurlarly related to how we do the dirty page tracking. Today vIOMMUs serve two purposes: 1) enable interrupt remaping 2) provide dma translation services for guests to provide some form of guest kernel managed DMA e.g

[PATCH v4 04/15] intel-iommu: Switch to pci_setup_iommu_ops()

2023-06-22 Thread Joao Martins
From: Yi Liu Use the PCI IOMMU setup function that supply a PCIIOMMUOps argument. This is in preparation to support fetching vIOMMU information via pci_device_get_iommu_attr() which will require switching the driver to pci_setup_iommu_ops(). Signed-off-by: Yi Liu [joao: Split from the original

[PATCH v4 07/15] vfio/common: Track whether DMA Translation is enabled on the vIOMMU

2023-06-22 Thread Joao Martins
vfio_get_group() allocates and fills the group/container/space on success which will store the AddressSpace inside the VFIOSpace struct. Use the newly added pci_device_iommu_get_attr() to see if DMA translation is enabled or not. Assume that by default it is enabled. Today, this means only intel-i

[PATCH v4 01/15] hw/pci: Add a pci_setup_iommu_ops() helper

2023-06-22 Thread Joao Martins
From: Yi Liu Add a pci_setup_iommu_ops() that uses a newly added structure (PCIIOMMUOps) instead of using PCIIOMMUFunc. The old pci_setup_iommu() that uses PCIIOMMUFunc is still kept for other IOMMUs to get an an address space for a PCI device in vendor specific way. In preparation to expand to

Re: [PATCH V1 3/3] tests/qtest: live migration suspended state

2023-06-22 Thread Steven Sistare
On 6/21/2023 4:00 PM, Peter Xu wrote: > On Wed, Jun 21, 2023 at 03:39:44PM -0400, Steven Sistare wrote: -jmp mainloop +# should this test suspend? +mov (suspend_me),%eax +cmp $0,%eax +je mainloop + +# are we waking a

Re: [PATCH RFC 0/6] Switch iotests to pyvenv

2023-06-22 Thread John Snow
On Thu, Jun 22, 2023 at 5:12 PM Paolo Bonzini wrote: > > On Thu, Jun 22, 2023 at 11:08 PM John Snow wrote: > > > > On Thu, Jun 22, 2023 at 5:05 PM Paolo Bonzini wrote: > > > > > > On Thu, Jun 22, 2023 at 11:03 PM John Snow wrote: > > > > If we always install it in editable mode, and the path wh

Re: [PATCH v4 1/1] target/riscv: Add RVV registers to log

2023-06-22 Thread Daniel Henrique Barboza
On 6/22/23 06:43, Ivan Klokov wrote: Print RvV extesion register to log if VPU option is enabled. Typo: extesion -> extension Signed-off-by: Ivan Klokov --- v4: - General part of patch has been merged, rebase riscv part and resend. --- target/riscv/cpu.c | 56 ++

Re: [PATCH RFC 0/6] Switch iotests to pyvenv

2023-06-22 Thread Paolo Bonzini
On Thu, Jun 22, 2023 at 11:08 PM John Snow wrote: > > On Thu, Jun 22, 2023 at 5:05 PM Paolo Bonzini wrote: > > > > On Thu, Jun 22, 2023 at 11:03 PM John Snow wrote: > > > If we always install it in editable mode, and the path where it is > > > "installed" is what we expect it to be, it shouldn't

Re: [PATCH RFC 0/6] Switch iotests to pyvenv

2023-06-22 Thread John Snow
On Thu, Jun 22, 2023 at 5:05 PM Paolo Bonzini wrote: > > On Thu, Jun 22, 2023 at 11:03 PM John Snow wrote: > > If we always install it in editable mode, and the path where it is > > "installed" is what we expect it to be, it shouldn't have any problems > > with being out of date I think. We c

Re: [PATCH RFC 0/6] Switch iotests to pyvenv

2023-06-22 Thread Paolo Bonzini
On Thu, Jun 22, 2023 at 11:03 PM John Snow wrote: > If we always install it in editable mode, and the path where it is > "installed" is what we expect it to be, it shouldn't have any problems > with being out of date I think. We could conceivably use the > "faux" package version the internal p

Re: [PATCH RFC 0/6] Switch iotests to pyvenv

2023-06-22 Thread John Snow
On Thu, Jun 22, 2023 at 5:24 AM Paolo Bonzini wrote: > > On Wed, Jun 21, 2023 at 9:08 AM Paolo Bonzini wrote: > > Maybe patch 4 can use distlib.scripts as well to create the check script in > > the build directory? (Yes that's another mkvenv functionality...) On a > > phone and don't have the d

Re: [PATCH v3 01/15] hw/pci: Refactor pci_device_iommu_address_space()

2023-06-22 Thread Joao Martins
On 22/06/2023 21:50, Michael S. Tsirkin wrote: > On Wed, May 31, 2023 at 11:03:23AM +0100, Joao Martins wrote: >> On 30/05/2023 23:04, Philippe Mathieu-Daudé wrote: >>> Hi Joao, >>> >>> On 30/5/23 19:59, Joao Martins wrote: Rename pci_device_iommu_address_space() into pci_device_iommu_info(

Re: [RFC PATCH] softfloat: use QEMU_FLATTEN to avoid mistaken isra inlining

2023-06-22 Thread BALATON Zoltan
Hello, What happened to this patch? Will this be merged by somebody? Regards, BALATON Zoltan On Tue, 23 May 2023, BALATON Zoltan wrote: On Tue, 23 May 2023, Alex Bennée wrote: Balton discovered that asserts for the extract/deposit calls had a Missing an a in my name and my given name is Zol

Re: [PATCH v3 01/15] hw/pci: Refactor pci_device_iommu_address_space()

2023-06-22 Thread Michael S. Tsirkin
On Wed, May 31, 2023 at 11:03:23AM +0100, Joao Martins wrote: > On 30/05/2023 23:04, Philippe Mathieu-Daudé wrote: > > Hi Joao, > > > > On 30/5/23 19:59, Joao Martins wrote: > >> Rename pci_device_iommu_address_space() into pci_device_iommu_info(). > >> In the new function return a new type PCIAdd

Re: [PATCH V2] migration: file URI

2023-06-22 Thread Steven Sistare
On 6/22/2023 8:20 AM, Fabiano Rosas wrote: > Steve Sistare writes: > >> Extend the migration URI to support file:. This can be used for >> any migration scenario that does not require a reverse path. It can be used >> as an alternative to 'exec:cat > file' in minimized containers that do not >>

[PATCH V3 1/2] migration: file URI

2023-06-22 Thread Steve Sistare
Extend the migration URI to support file:. This can be used for any migration scenario that does not require a reverse path. It can be used as an alternative to 'exec:cat > file' in minimized containers that do not contain /bin/sh, and it is easier to use than the fd: URI. It can be used in HMP c

[PATCH V3 2/2] migration: file URI offset

2023-06-22 Thread Steve Sistare
Allow an offset option to be specified as part of the file URI, in the form "file:filename,offset=offset", where offset accepts the common size suffixes, or the 0x prefix, but not both. Migration data is written to and read from the file starting at offset. If unspecified, it defaults to 0. This

[PATCH V3 0/2] migration file URI

2023-06-22 Thread Steve Sistare
Add the migration URI "file:filename[,offset=offset]". Fabiano Rosas has also written preliminary patches for the file uri, and he will submit the unit test(s). Steve Sistare (2): migration: file URI migration: file URI offset migration/file.c | 103 +++

Re: [PATCH 0/4] hw: Minor simplifications using proper QOM getter macros

2023-06-22 Thread Michael S. Tsirkin
On Thu, Jun 08, 2023 at 09:41:58PM +0300, Michael Tokarev wrote: > 23.05.2023 09:12, Philippe Mathieu-Daudé wrote: > > Enforce QOM style. Besides, using the proper QOM macros > > slightly simplifies the code. > > Applied to my trivial-patches branch (Maybe it's time to resurrect it). > > Thanks,

Re: [PATCH v4 0/5] Support x2APIC mode with TCG accelerator

2023-06-22 Thread Michael S. Tsirkin
On Mon, May 22, 2023 at 11:31:52PM +0700, Bui Quang Minh wrote: > Hi everyone, > > This series implements x2APIC mode in userspace local APIC and the > RDMSR/WRMSR helper to access x2APIC registers in x2APIC mode. Intel iommu > and AMD iommu are adjusted to support x2APIC interrupt remapping. With

Re: [PATCH v4 5/5] amd_iommu: report x2APIC support to the operating system

2023-06-22 Thread Michael S. Tsirkin
On Mon, May 22, 2023 at 11:31:57PM +0700, Bui Quang Minh wrote: > This commit adds XTSup configuration to let user choose to whether enable > this feature or not. When XTSup is enabled, additional bytes in IRTE with > enabled guest virtual VAPIC are used to support 32-bit destination id. > > Addit

Re: [PATCH v3 3/4] vhost-user: add shared_object msg

2023-06-22 Thread Marc-André Lureau
Hi On Wed, May 24, 2023 at 11:13 AM Albert Esteve wrote: > Add new vhost-user protocol message > `VHOST_USER_BACKEND_SHARED_OBJECT`. This new > message is sent from vhost-user back-ends > to interact with the virtio-dmabuf table > in order to add, remove, or lookup for > virtio dma-buf shared ob

Re: [PATCH v2 00/17] Support smp.clusters for x86

2023-06-22 Thread Michael S. Tsirkin
On Mon, May 29, 2023 at 08:30:44PM +0800, Zhao Liu wrote: > From: Zhao Liu > > Hi list, > > This is the our v2 patch series, rebased on the master branch at the > commit ac84b57b4d74 ("Merge tag 'for-upstream' of > https://gitlab.com/bonzini/qemu into staging"). > > Comparing with v1 [1], v2 ma

Re: [PATCH 00/10] memory-device: Some cleanups

2023-06-22 Thread Michael S. Tsirkin
On Tue, May 30, 2023 at 01:38:28PM +0200, David Hildenbrand wrote: > Working on adding multi-memslot support for virtio-mem (teaching memory > device code about memory devices that can consume multiple memslots), I > have some preparatory cleanups in my queue that make sense independent of > the ac

Re: [PATCH 0/4] tests/qtest: Check for devices before using them

2023-06-22 Thread Michael S. Tsirkin
On Thu, May 25, 2023 at 10:10:12AM +0200, Thomas Huth wrote: > Here are some more patches that are required for running the qtests > with builds that have been configured with "--without-default-devices". > We need to check whether the required devices are really available > in the binaries before

Re: [PATCH v3 3/4] vhost-user: add shared_object msg

2023-06-22 Thread Michael S. Tsirkin
On Wed, May 24, 2023 at 11:13:32AM +0200, Albert Esteve wrote: > Add new vhost-user protocol message > `VHOST_USER_BACKEND_SHARED_OBJECT`. This new > message is sent from vhost-user back-ends > to interact with the virtio-dmabuf table > in order to add, remove, or lookup for > virtio dma-buf shared

Re: [PATCH v3 0/4] Virtio shared dma-buf

2023-06-22 Thread Michael S. Tsirkin
On Wed, Jun 21, 2023 at 10:20:25AM +0200, Albert Esteve wrote: > Hi! > > It has been a month since I sent this patch, so I'll give it a bump to get > some > attention back. > > @mst and @Fam any comments? What would be the next steps to take to move this > forward? > > BR, > Albert No one seem

[PATCH v2 5/5] migration: Deprecate old compression method

2023-06-22 Thread Juan Quintela
Signed-off-by: Juan Quintela --- docs/about/deprecated.rst | 8 +++ qapi/migration.json | 102 -- migration/options.c | 13 + 3 files changed, 86 insertions(+), 37 deletions(-) diff --git a/docs/about/deprecated.rst b/docs/about/deprecated.r

[PATCH v2 1/5] migration: Use proper indentation for migration.json

2023-06-22 Thread Juan Quintela
We broke it with dirtyrate limit patches. Signed-off-by: Juan Quintela --- qapi/migration.json | 67 ++--- 1 file changed, 33 insertions(+), 34 deletions(-) diff --git a/qapi/migration.json b/qapi/migration.json index 6ff39157ba..ad8cc57071 100644 --- a/q

[PATCH v2 4/5] migration: Deprecate block migration

2023-06-22 Thread Juan Quintela
It is obsolete. It is better to use driver-mirror with NBD instead. CC: Kevin Wolf CC: Eric Blake CC: Stefan Hajnoczi CC: Hanna Czenczek Signed-off-by: Juan Quintela --- docs/about/deprecated.rst | 10 ++ qapi/migration.json | 30 +- migration/bloc

[PATCH v2 0/5] Migration deprecated parts

2023-06-22 Thread Juan Quintela
On this v2: - dropped -incoming deprecation Paolo came with a better solution using keyvalues. - skipped field is already ready for next pull request, so dropped. - dropped the RFC bits, nermal PATCH. - Assessed all the review comments. - Added indentation of migration.json. - Used the doc

[PATCH v2 2/5] migration: migrate 'inc' command option is deprecated.

2023-06-22 Thread Juan Quintela
Set the 'block_incremental' migration parameter to 'true' instead. Signed-off-by: Juan Quintela --- docs/about/deprecated.rst | 7 +++ qapi/migration.json | 12 ++-- migration/migration.c | 6 ++ 3 files changed, 23 insertions(+), 2 deletions(-) diff --git a/docs/abo

[PATCH v2 3/5] migration: migrate 'blk' command option is deprecated.

2023-06-22 Thread Juan Quintela
Set the 'block' migration capability to 'true' instead. Signed-off-by: Juan Quintela --- docs/about/deprecated.rst | 7 +++ qapi/migration.json | 10 +++--- migration/migration.c | 5 + 3 files changed, 19 insertions(+), 3 deletions(-) diff --git a/docs/about/deprecated.

Re: [RFC 4/6] migration: Deprecate -incoming

2023-06-22 Thread Juan Quintela
Peter Xu wrote: > On Thu, Jun 22, 2023 at 11:22:56AM +0200, Thomas Huth wrote: >> Then simply forbid "migrate_set_parameter multifd-channels ..." if the uri >> has been specified on the command line? > > Yeah, actually already in a pull (even though the pr may need a new one..): > > https://lore.k

Re: [RFC 4/6] migration: Deprecate -incoming

2023-06-22 Thread Juan Quintela
Peter Xu wrote: > On Mon, Jun 12, 2023 at 10:51:08PM +0200, Juan Quintela wrote: >> Peter Xu wrote: >> > On Mon, Jun 12, 2023 at 09:33:42PM +0200, Juan Quintela wrote: >> >> Only "defer" is recommended. After setting all migation parameters, >> >> start incoming migration with "migrate-incoming

Re: [RFC 6/6] migration: Deprecated old compression method

2023-06-22 Thread Juan Quintela
Daniel P. Berrangé wrote: > On Mon, Jun 12, 2023 at 09:33:44PM +0200, Juan Quintela wrote: >> Signed-off-by: Juan Quintela >> --- >> docs/about/deprecated.rst | 8 >> qapi/migration.json | 92 --- >> migration/options.c | 13 ++ >> 3 file

Re: [RFC 6/6] migration: Deprecated old compression method

2023-06-22 Thread Juan Quintela
Thomas Huth wrote: > On 12/06/2023 21.33, Juan Quintela wrote: >> Signed-off-by: Juan Quintela >> --- >> docs/about/deprecated.rst | 8 >> qapi/migration.json | 92 --- >> migration/options.c | 13 ++ >> 3 files changed, 79 insertions

Re: [RFC 4/6] migration: Deprecate -incoming

2023-06-22 Thread Peter Xu
On Thu, Jun 22, 2023 at 05:33:29PM +0100, Daniel P. Berrangé wrote: > On Thu, Jun 22, 2023 at 11:54:43AM -0400, Peter Xu wrote: > > I can try to move the todo even higher. Trying to list the initial goals > > here: > > > > - One extra phase of handshake between src/dst (maybe the time to boost >

Re: [PATCH][RESEND v5 3/3] Add a Hyper-V Dynamic Memory Protocol driver (hv-balloon)

2023-06-22 Thread Maciej S. Szmigiero
On 22.06.2023 14:52, David Hildenbrand wrote: On 22.06.23 14:14, Maciej S. Szmigiero wrote: On 22.06.2023 14:06, David Hildenbrand wrote: On 22.06.23 13:17, Maciej S. Szmigiero wrote: On 22.06.2023 13:15, David Hildenbrand wrote: On 22.06.23 13:12, Maciej S. Szmigiero wrote: On 22.06.2023 13

Re: [PATCH qemu v2] change the fdt_load_addr variable datatype to handle 64-bit DRAM address

2023-06-22 Thread Daniel Henrique Barboza
(CC-ing Alistair) On 6/20/23 14:44, ~rlakshmibai wrote: From: Lakshmi Bai Raja Subramanian fdt_load_addr is getting overflowed when there is no DRAM at lower 32 bit address space. To support pure 64-bit DRAM address, fdt_load_addr variable's data type is changed to uint64_t instead of uint3

Re: [RFC 5/6] migration: Deprecate block migration

2023-06-22 Thread Juan Quintela
Stefan Hajnoczi wrote: > On Mon, Jun 12, 2023 at 09:33:43PM +0200, Juan Quintela wrote: >> It is obsolete. It is better to use driver_mirror+NBD instead. >> >> CC: Kevin Wolf >> CC: Eric Blake >> CC: Stefan Hajnoczi >> CC: Hanna Czenczek >> >> Signed-off-by: Juan Quintela >> >> --- >> >>

Re: [RFC 4/6] migration: Deprecate -incoming

2023-06-22 Thread Juan Quintela
Juan Quintela wrote: > Only "defer" is recommended. After setting all migation parameters, > start incoming migration with "migrate-incoming uri" command. > > Signed-off-by: Juan Quintela Nack myself. Dropped on next submissiong. keyfile properties suggested by paolo is a much better suggesti

Re: [RFC 3/6] migration: migrate 'blk' command option is deprecated.

2023-06-22 Thread Juan Quintela
Daniel P. Berrangé wrote: > On Mon, Jun 12, 2023 at 09:33:41PM +0200, Juan Quintela wrote: >> Use 'migrate_set_capability block true' instead. >> >> Signed-off-by: Juan Quintela >> --- >> docs/about/deprecated.rst | 7 +++ >> qapi/migration.json | 11 +++ >> migration/migrati

Re: [RFC 2/6] migration: migrate 'inc' command option is deprecated.

2023-06-22 Thread Juan Quintela
Daniel P. Berrangé wrote: > On Mon, Jun 12, 2023 at 09:33:40PM +0200, Juan Quintela wrote: >> Use 'migrate_set_parameter block_incremental true' instead. >> >> Signed-off-by: Juan Quintela >> --- >> docs/about/deprecated.rst | 7 +++ >> qapi/migration.json | 11 +-- >> migrat

Re: [PATCH v4 13/17] target/riscv: Add Zvkg ISA extension support

2023-06-22 Thread Daniel Henrique Barboza
On 6/22/23 13:16, Max Chou wrote: From: Nazar Kazakov This commit adds support for the Zvkg vector-crypto extension, which consists of the following instructions: * vgmul.vv * vghsh.vv Translation functions are defined in `target/riscv/insn_trans/trans_rvvk.c.inc` and helpers are defined i

Re: [PATCH v4 12/17] target/riscv: Add Zvksh ISA extension support

2023-06-22 Thread Daniel Henrique Barboza
On 6/22/23 13:16, Max Chou wrote: From: Lawrence Hunter This commit adds support for the Zvksh vector-crypto extension, which consists of the following instructions: * vsm3me.vv * vsm3c.vi Translation functions are defined in `target/riscv/insn_trans/trans_rvvk.c.inc` and helpers are defin

Re: [PATCH v4 11/17] target/riscv: Add Zvknh ISA extension support

2023-06-22 Thread Daniel Henrique Barboza
On 6/22/23 13:16, Max Chou wrote: From: Kiran Ostrolenk This commit adds support for the Zvknh vector-crypto extension, which consists of the following instructions: * vsha2ms.vv * vsha2c[hl].vv Translation functions are defined in `target/riscv/insn_trans/trans_rvvk.c.inc` and helpers are

Re: [PATCH v4 10/17] target/riscv: Add Zvkned ISA extension support

2023-06-22 Thread Daniel Henrique Barboza
On 6/22/23 13:16, Max Chou wrote: From: Nazar Kazakov This commit adds support for the Zvkned vector-crypto extension, which consists of the following instructions: * vaesef.[vv,vs] * vaesdf.[vv,vs] * vaesdm.[vv,vs] * vaesz.vs * vaesem.[vv,vs] * vaeskf1.vi * vaeskf2.vi Translation function

Re: [PATCH v2 15/16] accel: Rename 'cpu_state' -> 'cpu'

2023-06-22 Thread Richard Henderson
On 6/22/23 18:08, Philippe Mathieu-Daudé wrote: Most of the codebase uses 'CPUState *cpu' or 'CPUState *cs'. While 'cpu_state' is kind of explicit, it makes the code harder to review. Simply rename as 'cpu' like the rest. Signed-off-by: Philippe Mathieu-Daudé I would have chosen 'cs', since '

Re: [RFC 1/6] migration: skipped field is really obsolete.

2023-06-22 Thread Juan Quintela
Daniel P. Berrangé wrote: > On Mon, Jun 12, 2023 at 09:33:39PM +0200, Juan Quintela wrote: >> Has return zero for more than 10 years. Just mark it deprecated. > > Specifically we introduced the field in 1.5.0 > > commit f1c72795af573b24a7da5eb52375c9aba8a37972 > Author: Peter Lieven > Date: Tu

Re: [PATCH v2 5/5] hw/pci: ensure PCIE devices are plugged into only slot 0 of PCIE port

2023-06-22 Thread Michael S. Tsirkin
On Thu, Jun 22, 2023 at 05:46:40PM +0200, Julia Suvorova wrote: > On Thu, Jun 22, 2023 at 12:34 PM Ani Sinha wrote: > > > > PCI Express ports only have one slot, so PCI Express devices can only be > > plugged into slot 0 on a PCIE port. Enforce it. > > > > CC: jus...@redhat.com > > CC: imamm...@re

Re: [PATCH v4 09/17] target/riscv: Add Zvbb ISA extension support

2023-06-22 Thread Daniel Henrique Barboza
On 6/22/23 13:16, Max Chou wrote: From: Dickon Hood This commit adds support for the Zvbb vector-crypto extension, which consists of the following instructions: * vrol.[vv,vx] * vror.[vv,vx,vi] * vbrev8.v * vrev8.v * vandn.[vv,vx] * vbrev.v * vclz.v * vctz.v * vcpop.v * vwsll.[vv,vx,vi] Tr

Re: [PATCH v2 12/16] accel: Remove WHPX unreachable error path

2023-06-22 Thread Richard Henderson
On 6/22/23 18:08, Philippe Mathieu-Daudé wrote: g_new0() can not fail. Remove the unreachable error path. https://developer-old.gnome.org/glib/stable/glib-Memory-Allocation.html#glib-Memory-Allocation.description Reported-by: Richard Henderson Signed-off-by: Philippe Mathieu-Daudé --- targe

Re: [PATCH v2 09/16] accel: Remove NVMM unreachable error path

2023-06-22 Thread Richard Henderson
On 6/22/23 18:08, Philippe Mathieu-Daudé wrote: g_malloc0() can not fail. Remove the unreachable error path. https://developer-old.gnome.org/glib/stable/glib-Memory-Allocation.html#glib-Memory-Allocation.description Signed-off-by: Philippe Mathieu-Daudé --- target/i386/nvmm/nvmm-all.c | 4 --

Re: [PATCH v2 07/16] accel: Rename HAX 'struct hax_vcpu_state' -> AccelCPUState

2023-06-22 Thread Richard Henderson
On 6/22/23 18:08, Philippe Mathieu-Daudé wrote: |+ struct AccelvCPUState *accel;| ... +typedef struct AccelCPUState { hax_fd fd; int vcpu_id; struct hax_tunnel *tunnel; unsigned char *iobuf; -}; +} hax_vcpu_state; Discussed face to face, but for the record: Put the typed

Re: [PATCH v1 02/23] pc/q35: Apply PCI bus BSEL property for Xen PCI device hotplug

2023-06-22 Thread Julia Suvorova
On Thu, Jun 22, 2023 at 9:36 AM Igor Mammedov wrote: > > On Wed, 21 Jun 2023 13:24:42 -0400 > Joel Upham wrote: > > > On Wed, Jun 21, 2023 at 7:28 AM Igor Mammedov wrote: > > > > > On Tue, 20 Jun 2023 13:24:36 -0400 > > > Joel Upham wrote: > > > > > > > On Q35 we still need to assign BSEL prope

Re: [PATCH] migration.json: Don't use space before colon

2023-06-22 Thread Markus Armbruster
Juan Quintela writes: > Markus Armbruster wrote: >> Juan Quintela writes: >> >>> So all the file is consistent. >>> >>> Signed-off-by: Juan Quintela >> >> Reviewed-by: Markus Armbruster >> >> Queued. thanks! > > My deprecated series depend on this, so I will got it through the > migration tr

Re: [PATCH v4 17/17] target/riscv: Expose Zvk* and Zvb[b,c] cpu properties

2023-06-22 Thread Daniel Henrique Barboza
On 6/22/23 13:16, Max Chou wrote: From: Nazar Kazakov Exposes earlier CPU flags allowing the use of the vector cryptography extensions. Signed-off-by: Nazar Kazakov Signed-off-by: Max Chou --- target/riscv/cpu.c | 10 ++ 1 file changed, 10 insertions(+) diff --git a/target/ri

Re: [PATCH v2 05/16] accel: Destroy HAX vCPU threads once done

2023-06-22 Thread Richard Henderson
On 6/22/23 18:08, Philippe Mathieu-Daudé wrote: When the vCPU thread finished its processing, destroy it and signal its destruction to generic vCPU management layer. Add a sanity check for the vCPU accelerator context. Signed-off-by: Philippe Mathieu-Daudé --- target/i386/hax/hax-accel-ops.c

Re: [PATCH v2 1/7] target/ppc: Add initial flags and helpers for SMT support

2023-06-22 Thread Cédric Le Goater
On 6/22/23 11:33, Nicholas Piggin wrote: TGC SMT emulation needs to know whether it is running with SMT siblings, to be able to iterate over siblings in a core, and to serialise threads to access per-core shared SPRs. Add infrastructure to do these things. For now the sibling iteration and seria

Re: [PATCH v2 3/7] target/ppc: Add msgsnd/p and DPDES SMT support

2023-06-22 Thread Cédric Le Goater
On 6/22/23 11:33, Nicholas Piggin wrote: Doorbells in SMT need to coordinate msgsnd/msgclr and DPDES access from multiple threads that affect the same state. Signed-off-by: Nicholas Piggin Reviewed-by: Cédric Le Goater Thanks, C. --- hw/ppc/ppc.c | 6 ++ include/hw/

Re: [PATCH v2 7/7] tests/avocado: Add ppc64 pseries multiprocessor boot tests

2023-06-22 Thread Cédric Le Goater
On 6/22/23 11:33, Nicholas Piggin wrote: Add mult-thread/core/socket Linux boot tests that ensure the right topology comes up. Of particular note is a SMT test, which is a new capability for TCG. Signed-off-by: Nicholas Piggin Reviewed-by: Cédric Le Goater Thanks, C. --- tests/avocad

Re: [PATCH v2 6/7] tests/avocado: boot ppc64 pseries to Linux VFS mount

2023-06-22 Thread Cédric Le Goater
On 6/22/23 11:33, Nicholas Piggin wrote: This machine can boot Linux to VFS mount, so don't stop in early boot. Signed-off-by: Nicholas Piggin Reviewed-by: Cédric Le Goater Thanks, C. --- tests/avocado/ppc_pseries.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

  1   2   3   4   >