From: Pierre Morel
S390 topology adds books and drawers topology containers.
Let's add these to the HMP information for hotpluggable cpus.
Signed-off-by: Pierre Morel
Reviewed-by: Nina Schoetterl-Glausch
---
hw/core/machine-hmp-cmds.c | 6 ++
1 file changed, 6 insertions(+)
diff --git
From: Pierre Morel
The modification of the CPU attributes are done through a monitor
command.
It allows to move the core inside the topology tree to optimize
the cache usage in the case the host's hypervisor previously
moved the CPU.
The same command allows to modify the CPU attributes
From: Pierre Morel
Polarization is changed on a request from the guest.
Let's verify the polarization is accordingly set by QEMU.
Signed-off-by: Pierre Morel
Co-developed-by: Nina Schoetterl-Glausch
Signed-off-by: Nina Schoetterl-Glausch
---
tests/avocado/s390_topology.py | 45
From: Pierre Morel
This test verifies that QMP set-cpu-topology does not accept
to overload a socket.
Signed-off-by: Pierre Morel
Reviewed-by: Thomas Huth
---
tests/avocado/s390_topology.py | 26 ++
1 file changed, 26 insertions(+)
diff --git
From: Pierre Morel
Let's test that QEMU refuses to setup a dedicated CPU with
low or medium entitlement.
Signed-off-by: Pierre Morel
Reviewed-by: Thomas Huth
---
tests/avocado/s390_topology.py | 48 ++
1 file changed, 48 insertions(+)
diff --git
From: Pierre Morel
This test verifies that QEMU refuses to move a CPU to an
nonexistent location.
Signed-off-by: Pierre Morel
Reviewed-by: Thomas Huth
---
tests/avocado/s390_topology.py | 25 +
1 file changed, 25 insertions(+)
diff --git
On Wed, Aug 23, 2023 at 4:56 PM Philippe Mathieu-Daudé
wrote:
> Signed-off-by: Philippe Mathieu-Daudé
>
Reviewed-by: Edgar E. Iglesias
> ---
> target/cris/translate.c | 20 +++-
> 1 file changed, 11 insertions(+), 9 deletions(-)
>
> diff --git a/target/cris/translate.c
From: Pierre Morel
S390 adds two new SMP levels, drawers and books to the CPU
topology.
S390 CPUs have specific topology features like dedication and
entitlement. These indicate to the guest information on host
vCPU scheduling and help the guest make better scheduling decisions.
Let us provide
From: Pierre Morel
During a subsystem reset the Topology-Change-Report is cleared
by the machine.
Let's ask KVM to clear the Modified Topology Change Report (MTCR)
bit of the SCA in the case of a subsystem reset.
Signed-off-by: Pierre Morel
Reviewed-by: Thomas Huth
Reviewed-by: Nina
From: Pierre Morel
The topology information are attributes of the CPU and are
specified during the CPU device creation.
On hot plug we:
- calculate the default values for the topology for drawers,
books and sockets in the case they are not specified.
- verify the CPU attributes
- check that
From: Pierre Morel
The query-cpu-polarization qmp command returns the current
CPU polarization of the machine.
Signed-off-by: Pierre Morel
Reviewed-by: Thomas Huth
Co-developed-by: Nina Schoetterl-Glausch
Signed-off-by: Nina Schoetterl-Glausch
---
qapi/machine-target.json | 29
From: Pierre Morel
The KVM capability KVM_CAP_S390_CPU_TOPOLOGY is used to
activate the S390_FEAT_CONFIGURATION_TOPOLOGY feature and
the topology facility in the host CPU model for the guest
in the case the topology is available in QEMU and in KVM.
The feature is disabled by default and fenced
From: Pierre Morel
The maximum nested topology entries is used by the guest to
know how many nested topology are available on the machine.
Let change the MNEST value from 2 to 4 in the SCLP READ INFO
structure now that we support books and drawers.
Signed-off-by: Pierre Morel
Reviewed-by:
On Thu, Aug 31, 2023 at 03:57:02PM +0300, Avihai Horon wrote:
> Background snapshot allows creating a snapshot of the VM while it's
> running and keeping it small by not including dirty RAM pages.
>
> The way it works is by first stopping the VM, saving the non-iterable
> devices' state and then
On Thu, Aug 31, 2023 at 03:57:01PM +0300, Avihai Horon wrote:
> VFIO migration is not compatible with postcopy migration. A VFIO device
> in the destination can't handle page faults for pages that have not been
> sent yet.
>
> Doing such migration will cause the VM to crash in the destination:
>
On Thu, Aug 31, 2023 at 03:57:00PM +0300, Avihai Horon wrote:
> Add a new .save_prepare() handler to struct SaveVMHandlers. This handler
> is called early, even before migration starts, and can be used by
> devices to perform early checks.
>
> Suggested-by: Peter Xu
> Signed-off-by: Avihai Horon
On 9/1/23 04:32, Richard Henderson wrote:
Ping.
Basic testing with my chroots seems to give no
problems, so for the series:
Tested-by: Helge Deller
Helge
On 8/23/23 18:02, Richard Henderson wrote:
Combine a bunch of smaller linux-user patches:
Supercedes:
On 8/24/23 03:02, Richard Henderson wrote:
Remove the fixed size shm_regions[] array.
Remove references when other mappings completely remove
or replace a region.
Signed-off-by: Richard Henderson
Reviewed-by: Helge Deller
On Tue, 2023-08-29 at 17:50 -0400, leon@is.currently.online wrote:
> From: Leon Schuermann
>
> When the rule-lock bypass (RLB) bit is set in the mseccfg CSR, the
> PMP
> configuration lock bits must not apply. While this behavior is
> implemented for the pmpcfgX CSRs, this bit is not respected
On 8/24/23 03:02, Richard Henderson wrote:
Move the CF_PARALLEL setting outside of the mmap lock.
Signed-off-by: Richard Henderson
Reviewed-by: Helge Deller
---
linux-user/mmap.c | 98 ++-
1 file changed, 46 insertions(+), 52 deletions(-)
On 9/1/23 16:50, Markus Armbruster wrote:
Cédric Le Goater writes:
On 8/31/23 16:30, Eric Blake wrote:
On Thu, Aug 31, 2023 at 03:25:46PM +0200, Markus Armbruster wrote:
[This paragraph written last: Bear with my stream of consciousness
review below, where I end up duplicating some of the
Cédric Le Goater writes:
> On 8/31/23 16:30, Eric Blake wrote:
>> On Thu, Aug 31, 2023 at 03:25:46PM +0200, Markus Armbruster wrote:
>> [This paragraph written last: Bear with my stream of consciousness
>> review below, where I end up duplicating some of the conslusions you
>> reached before the
On Fri, Sep 01, 2023 at 09:37:32AM +0100, Daniel P. Berrangé wrote:
> > Hi Peter. I'm curious if we specify max-switchover-bandwidth to 5Gbps over a
> > 10Gbps network, in the completion stage will it send the remaining data in
> > 5Gbps
> > using downtime_limit time or in 10Gbps (saturate the
On Wed, Aug 30, 2023 at 01:38:12PM +0400, marcandre.lur...@redhat.com wrote:
> From: Marc-André Lureau
>
> The QemuTextConsole code paths assume a surface is being used as
> scanout, let's make this more explicit.
>
> Signed-off-by: Marc-André Lureau
> ---
> ui/console.c | 4
> 1 file
On Wed, Aug 30, 2023 at 01:38:09PM +0400, marcandre.lur...@redhat.com wrote:
> From: Marc-André Lureau
>
> We are going to split the console.c unit next, and implement
> separately. But we need to check the underlying type in various places.
>
> Signed-off-by: Marc-André Lureau
> ---
>
On 24/8/23 03:02, Richard Henderson wrote:
Tested-by: Helge Deller
Reviewed-by: Ilya Leoshkevich
Signed-off-by: Richard Henderson
---
linux-user/syscall.c | 2 ++
1 file changed, 2 insertions(+)
Reviewed-by: Philippe Mathieu-Daudé
On 24/8/23 03:02, Richard Henderson wrote:
If the shm region is not mapped at shmaddr, EINVAL.
Do not unmap the region until the syscall succeeds.
Use mmap_reserve_or_unmap to preserve reserved_va semantics.
Signed-off-by: Richard Henderson
---
linux-user/mmap.c | 17 ++---
1
On Wed, Aug 30, 2023 at 01:38:08PM +0400, marcandre.lur...@redhat.com wrote:
> From: Marc-André Lureau
>
> Signed-off-by: Marc-André Lureau
> ---
> ui/console.c | 9 ++---
> 1 file changed, 2 insertions(+), 7 deletions(-)
Reviewed-by: Daniel P. Berrangé
With regards,
Daniel
--
|:
On Wed, Aug 30, 2023 at 01:38:07PM +0400, marcandre.lur...@redhat.com wrote:
> From: Marc-André Lureau
>
> Signed-off-by: Marc-André Lureau
> ---
> ui/console.c | 8 +++-
> 1 file changed, 3 insertions(+), 5 deletions(-)
Reviewed-by: Daniel P. Berrangé
With regards,
Daniel
--
|:
On 24/8/23 03:02, Richard Henderson wrote:
From: Ilya Leoshkevich
Core dumps produced by gdb's gcore when connected to qemu's gdbstub
lack stack. The reason is that gdb includes only anonymous memory in
core dumps, which is distinguished by a non-0 Anonymous: value.
Consider the mappings with
On Wed, Aug 30, 2023 at 01:38:06PM +0400, marcandre.lur...@redhat.com wrote:
> From: Marc-André Lureau
>
> We can get the active console dimension regardless of its kind, by
> simply giving NULL as argument. It will fallback with the given value
> when the dimensions aren't known.
>
> This will
Hi,
FWIW I am unable to run 'check-avocado' after commit c03f57fd5b ("Revert
"tests: Use
separate virtual environment for avocado"). The error being thrown:
[20/20] Generating docs/QEMU man pages with a custom command
VENVPIP install -e /home/danielhb/work/test/qemu/python/
On Wed, Aug 30, 2023 at 01:38:05PM +0400, marcandre.lur...@redhat.com wrote:
> From: Marc-André Lureau
>
> Signed-off-by: Marc-André Lureau
> ---
> ui/console.c | 22 +++---
> 1 file changed, 11 insertions(+), 11 deletions(-)
Reviewed-by: Daniel P. Berrangé
With regards,
On Wed, Aug 30, 2023 at 01:38:04PM +0400, marcandre.lur...@redhat.com wrote:
> From: Marc-André Lureau
>
> Signed-off-by: Marc-André Lureau
> ---
> ui/console.c | 80
> 1 file changed, 31 insertions(+), 49 deletions(-)
> @@ -2612,12
On 24/8/23 03:02, Richard Henderson wrote:
Move the various open_cpuinfo functions into new files.
Move the m68k open_hardware function as well.
All other guest architectures get a boilerplate empty file.
Signed-off-by: Richard Henderson
---
linux-user/aarch64/target_proc.h | 1 +
On Wed, Aug 30, 2023 at 01:38:03PM +0400, marcandre.lur...@redhat.com wrote:
> From: Marc-André Lureau
>
> Move fields specific to graphic console to the console subclass.
>
> qemu_console_get_head() is adapated to accomodate QemuTextConsole, and
> always returns 0.
>
> Signed-off-by:
On 1/9/23 14:59, Cédric Le Goater wrote:
On 8/31/23 16:30, Eric Blake wrote:
On Thu, Aug 31, 2023 at 03:25:46PM +0200, Markus Armbruster wrote:
[This paragraph written last: Bear with my stream of consciousness
review below, where I end up duplicating some of the conslusions you
reached before
On 230112 0412, Lev Kujawski wrote:
>
> John Snow writes:
>
> > On Mon, Oct 10, 2022 at 4:52 AM Lev Kujawski wrote:
> >>
> >> Always use the native CHS device parameters for the ATA commands READ
> >> NATIVE MAX ADDRESS and READ NATIVE MAX ADDRESS EXT, not those limited
> >> by the ATA command
On Wed, Aug 30, 2023 at 01:38:02PM +0400, marcandre.lur...@redhat.com wrote:
> From: Marc-André Lureau
>
> Now we can instantiate the specific console with its own fields. Pass
> the most appropriate type to the various functions, and cast up to
> QEMU_CONSOLE as necessary.
>
> Signed-off-by:
On Wed, Aug 30, 2023 at 01:38:01PM +0400, marcandre.lur...@redhat.com wrote:
> From: Marc-André Lureau
>
> This code path is probably not executed at this point, since console
> aren't being released.
>
> Signed-off-by: Marc-André Lureau
> ---
> ui/console.c | 5 -
> 1 file changed, 4
On 1/9/23 14:45, Bilal Elmoussaoui wrote:
Fixes: 142ca628a7 ("ui: add a D-Bus display backend")
Fixes: de9f844ce2 ("ui/dbus: Expose a touch device interface")
Signed-off-by: Bilal Elmoussaoui
---
ui/dbus-console.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/ui/dbus-console.c
On Wed, Aug 30, 2023 at 01:38:00PM +0400, marcandre.lur...@redhat.com wrote:
> From: Marc-André Lureau
>
> The timer is only relevant when a text console exists.
>
> Signed-off-by: Marc-André Lureau
> ---
> ui/console.c | 6 --
> 1 file changed, 4 insertions(+), 2 deletions(-)
On Wed, Aug 30, 2023 at 01:37:59PM +0400, marcandre.lur...@redhat.com wrote:
> From: Marc-André Lureau
>
> Although at this point only QemuGraphicConsole have hw_ops that
> implements ui_info() callback, it makes sense to keep the code in the
> base QemuConsole, to simplify conditions for the
On Wed, Aug 30, 2023 at 01:37:58PM +0400, marcandre.lur...@redhat.com wrote:
> From: Marc-André Lureau
>
> When recycling unused QemuConsole, we should still set the associated
> head number for correct information and lookups.
>
> Signed-off-by: Marc-André Lureau
> ---
> ui/console.c | 2 +-
On Wed, Aug 30, 2023 at 01:37:57PM +0400, marcandre.lur...@redhat.com wrote:
> From: Marc-André Lureau
>
> graphics_console_init() is expected to return a graphic console.
>
> The function doesn't need to be exported.
>
> We are going to specialize further QemuGraphicConsole & QemuTextConsole.
On Wed, Aug 30, 2023 at 01:37:56PM +0400, marcandre.lur...@redhat.com wrote:
> From: Marc-André Lureau
>
> The constructor helper isn't of much used now.
>
> "head" is only specified for graphic console (and default to 0), and we
> are going to move it to QemuGraphicConsole next.
>
>
On Wed, Aug 30, 2023 at 01:37:55PM +0400, marcandre.lur...@redhat.com wrote:
> From: Marc-André Lureau
>
> Signed-off-by: Marc-André Lureau
> ---
> ui/console.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
Reviewed-by: Daniel P. Berrangé
With regards,
Daniel
--
|:
On 8/31/23 09:57, Alex Bennée wrote:
Richard Henderson writes:
On 8/30/23 07:52, Helge Deller wrote:
On 8/30/23 00:02, Richard Henderson wrote:
Changes for v5:
* Integrated cross-compile, via new build-vdso.sh and meson rules.
However, keep the binaries in the tree for hosts
On Wed, Aug 30, 2023 at 01:37:54PM +0400, marcandre.lur...@redhat.com wrote:
> From: Marc-André Lureau
>
> This will allow to move code/data to the specific console types.
>
> Replace console_type_t with object type check.
>
> QemuConsole can be abstract.
>
> Signed-off-by: Marc-André Lureau
On Wed, Aug 30, 2023 at 01:37:53PM +0400, marcandre.lur...@redhat.com wrote:
> From: Marc-André Lureau
>
> Boilerplate code to introduce different object types for the different
> console types.
>
> Signed-off-by: Marc-André Lureau
> ---
> ui/console.c | 84
On Wed, Aug 30, 2023 at 01:37:52PM +0400, marcandre.lur...@redhat.com wrote:
> From: Marc-André Lureau
>
> Object construction should be done in respective object instance and
> class handlers.
>
> Introduce qemu_console_register() to split out the registration logic.
>
> Signed-off-by:
On Wed, Aug 30, 2023 at 01:37:50PM +0400, marcandre.lur...@redhat.com wrote:
> From: Marc-André Lureau
>
> Signed-off-by: Marc-André Lureau
> ---
> ui/console.c | 147 +--
> 1 file changed, 73 insertions(+), 74 deletions(-)
Reviewed-by: Daniel
On Wed, Aug 30, 2023 at 01:37:49PM +0400, marcandre.lur...@redhat.com wrote:
> From: Marc-André Lureau
>
> Even though the actually use more QemuConsole at this point, it makes it
word missing here ??
> clear those functions are only used from the chardev implementation.
On Wed, Aug 30, 2023 at 01:37:43PM +0400, marcandre.lur...@redhat.com wrote:
> From: Marc-André Lureau
>
> There is no obvious reason to defer text console initialization. We can
> simply take the global display state in new_console().
>
> This simplify somewhat the code to allow moving the VC
Am 01.09.2023 um 13:26 hat Дмитрий Фролов geschrieben:
> Hello, Kevin.
>
> This was just cleanup, based on the inspection.
Thanks for clarifying. I've updated the subject line to "vmdk: Clean up
bdrv_open_child() return value check" to avoid misunderstandings and
applied this to my block branch.
On Wed, Aug 30, 2023 at 01:37:47PM +0400, marcandre.lur...@redhat.com wrote:
> From: Marc-André Lureau
>
> Signed-off-by: Marc-André Lureau
> ---
> ui/console.c | 30 +-
> 1 file changed, 13 insertions(+), 17 deletions(-)
Reviewed-by: Daniel P. Berrangé
With
On Wed, Aug 30, 2023 at 01:37:45PM +0400, marcandre.lur...@redhat.com wrote:
> From: Marc-André Lureau
>
> Signed-off-by: Marc-André Lureau
> ---
> ui/console.c | 4
> 1 file changed, 4 deletions(-)
Reviewed-by: Daniel P. Berrangé
With regards,
Daniel
--
|: https://berrange.com
Stefan Hajnoczi writes:
> On Wed, Aug 23, 2023 at 04:54:06PM -0400, Peter Xu wrote:
>> On Wed, Aug 23, 2023 at 10:08:08PM +0200, Mattias Nissler wrote:
>> > On Wed, Aug 23, 2023 at 7:35 PM Peter Xu wrote:
>> > > On Wed, Aug 23, 2023 at 02:29:02AM -0700, Mattias Nissler wrote:
>> > > > diff
On Fri, Sep 01, 2023 at 10:48:26AM +0200, Markus Armbruster wrote:
> > Indeed, not fully understanding the preprocessor makes for some
> > interesting death traps.
>
> We use ALL_CAPS for macros to signal "watch out for traps".
>
> >> -#define QOBJECT(obj) ({
On 8/31/23 16:30, Eric Blake wrote:
On Thu, Aug 31, 2023 at 03:25:46PM +0200, Markus Armbruster wrote:
[This paragraph written last: Bear with my stream of consciousness
review below, where I end up duplicating some of the conslusions you
reached before the point where I saw where the patch was
On Sat, Aug 12, 2023 at 03:47:54PM +0300, Michael Tokarev wrote:
> qemu_init() calls os_parse_cmd_args(), which is obviously a very vl.c-specicic
> piece of code. It looks like when moving vl.c to softmmu/, os-posix.c
> should've
> been moved too (together with os-win32.c). But there are other
David Hildenbrand writes:
> On 25.08.23 11:59, David Hildenbrand wrote:
[...]
>> ... hopefully I'm done with that error-handling pain in QEMU soon and
>> can continue focusing on things that make me feel more productive :P
I'm afraid you'll be done with error handling right when you're done
David Hildenbrand writes:
> For now, "share=off,readonly=on" would always result in us opening the
> file R/O and mmap'ing the opened file MAP_PRIVATE R/O -- effectively
> turning it into ROM.
>
> Especially for VM templating, "share=off" is a common use case. However,
> that use case is
Hi Philippe,
Sorry, I forgot that again. Sent a v2
On Fri, Sep 1, 2023 at 12:48 PM Philippe Mathieu-Daudé
wrote:
> Hi Bilal,
>
> Fixes: 142ca628a7 ("ui: add a D-Bus display backend")
> Fixes: de9f844ce2 ("ui/dbus: Expose a touch device interface")
>
> See
>
>
Signed-off-by: Bilal Elmoussaoui
---
ui/dbus-console.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/ui/dbus-console.c b/ui/dbus-console.c
index e19774f985..36f7349585 100644
--- a/ui/dbus-console.c
+++ b/ui/dbus-console.c
@@ -150,6 +150,8 @@ dbus_display_console_dispose(GObject *object)
On Thu, 3 Aug 2023 at 15:42, Richard Henderson
wrote:
>
> On 8/3/23 06:10, Peter Maydell wrote:
> > On Thu, 27 Jul 2023 at 17:33, Richard Henderson
> >> -mop = MO_128;
> >> -if (s->align_mem) {
> >> -mop |= MO_ALIGN_8;
> >> -}
> >> -mop = finalize_memop_pair(s, mop);
> >>
When qcrypto_builtin_rsa_public_key_parse() is about to fail, but no
error has been set, it makes one up. Actually, there's just one way
to fail without setting an error. Set it there instead.
Same for qcrypto_builtin_rsa_private_key_parse().
Signed-off-by: Markus Armbruster
---
Nick,
On 8/8/23 06:19, Nicholas Piggin wrote:
When storing a large decrementer value with the most significant
implemented bit set, it is to be treated as a negative and sign
extended.
This isn't hit for book3s DEC because of another bug, fixing it
in the next patch exposes this one and can
While this is not expected to happen, it could still
be that a vhost_dev did not set its nvqs member.
Since `vhost_dev_start` access the device's vqs array
later without checking its size, it would cause a
Segmentation fault when nvqs is 0.
To avoid this `rare` case and made the code safer,
add
Li Feng writes:
> Add a Error parameter to report the real error, like vhost-user-blk.
>
> Signed-off-by: Li Feng
> ---
> hw/scsi/vhost-scsi-common.c | 16 +---
> hw/scsi/vhost-scsi.c | 5 +++--
> hw/scsi/vhost-user-scsi.c | 14 --
Li Feng writes:
> If the backend crashes and restarts, the device is broken.
> This patch adds reconnect for vhost-user-scsi.
>
> Tested with spdk backend.
>
> Signed-off-by: Li Feng
> ---
> hw/scsi/vhost-user-scsi.c | 199 +---
>
This looks great! Thanks for this proposal.
On Fri, Sep 1, 2023 at 1:00 PM Alex Bennée wrote:
> Currently QEMU has to know some details about the VirtIO device
> supported by a vhost-user daemon to be able to setup the guest. This
> makes it hard for QEMU to add support for additional
Adding more reviewers since this patch is modifying a common service.
Thanks,
C.
On 8/8/23 06:19, Nicholas Piggin wrote:
This will be used for converting time intervals in different base units
to host units, for the purpose of scheduling timers to emulate target
timers. Timers typically must
Bound APQNs have to be reset before tearing down the secure config via
s390_machine_unprotect(). Otherwise the Ultravisor will return a error
code.
So let's do a subsystem_reset() which includes a AP reset before the
unprotect call. We'll do a full device_reset() afterwards which will
reset some
Li Feng writes:
> Let's keep the same behavior as vhost-user-blk.
>
> Some old guests kick virtqueue before setting VIRTIO_CONFIG_S_DRIVER_OK.
>
> Signed-off-by: Li Feng
> ---
> hw/scsi/vhost-user-scsi.c | 48 +++
> 1 file changed, 44 insertions(+), 4
On Thu, 31 Aug 2023 at 23:58, Philippe Mathieu-Daudé wrote:
>
> Fix:
>
> target/m68k/translate.c:828:18: error: declaration shadows a local variable
> [-Werror,-Wshadow]
> TCGv tmp = tcg_temp_new();
> ^
> target/m68k/translate.c:801:15: note: previous declaration
On Thu, 31 Aug 2023 at 23:56, Philippe Mathieu-Daudé wrote:
>
> Fix:
>
> hw/arm/allwinner-r40.c:412:14: error: declaration shadows a local variable
> [-Werror,-Wshadow]
> for (int i = 0; i < AW_R40_NUM_MMCS; i++) {
> ^
> hw/arm/allwinner-r40.c:299:14: note: previous
On Thu, 31 Aug 2023 at 23:56, Philippe Mathieu-Daudé wrote:
>
> Fix:
>
> hw/arm/virt.c:821:22: error: declaration shadows a local variable
> [-Werror,-Wshadow]
> qemu_irq irq = qdev_get_gpio_in(vms->gic,
> ^
> hw/arm/virt.c:803:13: note: previous declaration
Hello, Kevin.
This was just cleanup, based on the inspection.
Dmitry.
01.09.2023 14:15, Kevin Wolf пишет:
Am 31.08.2023 um 14:59 hat Dmitry Frolov geschrieben:
bdrv_open_child() may return NULL.
Usually return value is checked for this function.
Check for return value is more reliable.
Am 31.08.2023 um 14:59 hat Dmitry Frolov geschrieben:
> bdrv_open_child() may return NULL.
> Usually return value is checked for this function.
> Check for return value is more reliable.
>
> Fixes: 24bc15d1f6 ("vmdk: Use BdrvChild instead of BDS for references to
> extents")
>
> Signed-off-by:
Sam Li writes:
> To configure the zoned format feature on the qcow2 driver, it
> requires following arguments: the device size, zoned profile,
"Zoned profile" is gone in v3.
> zone model, zone size, zone capacity, number of conventional
> zones, limits on zone resources (max append sectors,
Currently QEMU has to know some details about the VirtIO device
supported by a vhost-user daemon to be able to setup the guest. This
makes it hard for QEMU to add support for additional vhost-user
daemons without adding specific stubs for each additional VirtIO
device.
This patch suggests a new
Hi Bilal,
Fixes: 142ca628a7 ("ui: add a D-Bus display backend")
Fixes: de9f844ce2 ("ui/dbus: Expose a touch device interface")
See
https://www.qemu.org/docs/master/devel/submitting-a-patch.html#patch-emails-must-include-a-signed-off-by-line
Your patches must include a Signed-off-by: line.
On Thu, 31 Aug 2023 at 23:56, Philippe Mathieu-Daudé wrote:
>
> Fix:
>
> target/arm/tcg/translate-m-nocp.c:509:18: error: declaration shadows a
> local variable [-Werror,-Wshadow]
> TCGv_i32 tmp = load_cpu_field(v7m.fpdscr[M_REG_NS]);
> ^
>
On 26/07/2023 21:41, John Allen wrote:
> Add cpuid bit definition for the SUCCOR feature. This cpuid bit is required to
> be exposed to guests to allow them to handle machine check exceptions on AMD
> hosts.
>
> Reported-by: William Roche
> Signed-off-by: John Allen
I think this is matching
---
ui/dbus-console.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/ui/dbus-console.c b/ui/dbus-console.c
index e19774f985..36f7349585 100644
--- a/ui/dbus-console.c
+++ b/ui/dbus-console.c
@@ -150,6 +150,8 @@ dbus_display_console_dispose(GObject *object)
DBusDisplayConsole *ddc =
On Fri, Sep 01, 2023 at 12:24:30PM +0200, Kevin Wolf wrote:
> Document the 'compression_type' option for qcow2, and mention that
> streamOptimized vmdk supports compression, too.
>
> Reported-by: Richard W.M. Jones
> Signed-off-by: Kevin Wolf
Looks good, so:
Reviewed-by: Richard W.M. Jones
Document the 'compression_type' option for qcow2, and mention that
streamOptimized vmdk supports compression, too.
Reported-by: Richard W.M. Jones
Signed-off-by: Kevin Wolf
---
docs/tools/qemu-img.rst | 19 +--
1 file changed, 17 insertions(+), 2 deletions(-)
diff --git
On Fri, Sep 01, 2023 at 11:08:15AM +0100, Alex Bennée wrote:
>
> Philippe Mathieu-Daudé writes:
>
> > Ping?
> >
> > On 5/7/23 13:44, Philippe Mathieu-Daudé wrote:
> >> Hi Alex,
> >> On 17/11/22 18:25, Alex Bennée wrote:
> >>> The bullet points are quite long and contain process tips. Move those
25.08.2023 20:51, Thomas Huth wrote:
The NIC init code of the jazz machines is rather cumbersome, with
a for-loop around it that is always left after the first iteration.
This patch series reworks this a little bit to make the code more
readable and shorter.
Thomas Huth (3):
hw/mips/jazz:
When try to do the vfio post-copy migration, we can get an expected
internal error now: "unable to execute QEMU command 'migrate':
:b1:00.2: VFIO migration is not supported with postcopy migration"
Tested-by: Yanghang Liu
Best Regards,
YangHang Liu
On Thu, Aug 31, 2023 at 8:57 PM Avihai
This is the same patchset as the previous RFC,
https://lists.nongnu.org/archive/html/qemu-devel/2023-08/msg02145.html .
qemu_init() calls os_parse_cmd_args(), which is obviously a very vl.c-specicic
piece of code. It looks like when moving vl.c to softmmu/, os-posix.c should've
been moved
Signed-off-by: Michael Tokarev
Reviewed-by: Eric Blake
---
os-posix.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/os-posix.c b/os-posix.c
index 340373d972..d3490b0a9b 100644
--- a/os-posix.c
+++ b/os-posix.c
@@ -29,8 +29,6 @@
#include
#include
-/* Needed early for CONFIG_BSD etc.
this moves code blocks so that functions and variables which
belongs to the same concept are now close to each other.
There's no actual code changes in there.
Signed-off-by: Michael Tokarev
Reviewed-by: Eric Blake
---
os-posix.c | 49 +++--
1 file
Signed-off-by: Michael Tokarev
Reviewed-by: Eric Blake
---
{util => softmmu}/async-teardown.c | 0
softmmu/meson.build| 1 +
util/meson.build | 1 -
3 files changed, 1 insertion(+), 1 deletion(-)
rename {util => softmmu}/async-teardown.c (100%)
diff --git
qemu-options.h just includes qemu-options.def with some #defines.
We already do this in vl.c in other place. Since no other file
includes qemu-options.h anymore, just inline it in vl.c.
This effectively reverts second half of commit 59a5264b99434.
Signed-off-by: Michael Tokarev
Reviewed-by:
Signed-off-by: Michael Tokarev
Reviewed-by: Eric Blake
---
include/sysemu/os-posix.h | 1 +
os-posix.c| 23 ---
2 files changed, 17 insertions(+), 7 deletions(-)
diff --git a/include/sysemu/os-posix.h b/include/sysemu/os-posix.h
index 65b9c94e91..d32630f9e7
Signed-off-by: Michael Tokarev
Reviewed-by: Eric Blake
---
include/sysemu/os-posix.h | 1 +
os-posix.c| 9 +++--
2 files changed, 8 insertions(+), 2 deletions(-)
diff --git a/include/sysemu/os-posix.h b/include/sysemu/os-posix.h
index d32630f9e7..8a66763395 100644
---
Signed-off-by: Michael Tokarev
Reviewed-by: Eric Blake
---
include/sysemu/os-posix.h | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/include/sysemu/os-posix.h b/include/sysemu/os-posix.h
index 1030d39904..65b9c94e91 100644
--- a/include/sysemu/os-posix.h
+++
This will stop linking softmmu-specific os_parse_cmd_args() into every
qemu executable which happens to use other functions from os-posix.c,
such as os_set_line_buffering() or os_setup_signal_handling().
Also, since there's no win32-specific options, *all* option parsing is
now done in
101 - 200 of 283 matches
Mail list logo
