[PULL 00/10] loongarch-to-apply queue

2023-11-02 Thread Song Gao
The following changes since commit d762bf97931b58839316b68a570eecc6143c9e3e: Merge tag 'pull-target-arm-20231102' of https://git.linaro.org/people/pmaydell/qemu-arm into staging (2023-11-03 10:04:12 +0800) are available in the Git repository at: https://gitlab.com/gaosong/qem

[PULL 01/10] target/loongarch: Add cpu model 'max'

2023-11-02 Thread Song Gao
We use cpu la464 for the 'max' cpu. Signed-off-by: Song Gao Reviewed-by: Richard Henderson Message-Id: <20231020084925.3457084-2-gaos...@loongson.cn> --- target/loongarch/cpu.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/target/loongarch/cpu.c b/target/loongarch/cpu.c index ef1bf

[PULL 10/10] linux-user/loongarch64: Add LASX sigcontext save/restore

2023-11-02 Thread Song Gao
Signed-off-by: Song Gao Reviewed-by: Richard Henderson Message-Id: <20231101030816.2353416-7-gaos...@loongson.cn> --- linux-user/loongarch64/signal.c | 68 ++--- 1 file changed, 62 insertions(+), 6 deletions(-) diff --git a/linux-user/loongarch64/signal.c b/linux-use

[PULL 05/10] linux-user/loongarch64: Use traps to track LSX/LASX usage

2023-11-02 Thread Song Gao
From: Richard Henderson Signed-off-by: Richard Henderson Message-Id: <20231101030816.2353416-2-gaos...@loongson.cn> Signed-off-by: Song Gao --- linux-user/loongarch64/cpu_loop.c | 13 + target/loongarch/insn_trans/trans_vec.c.inc | 11 --- 2 files changed, 13 inse

[PULL 04/10] target/loongarch: Support 4K page size

2023-11-02 Thread Song Gao
The LoongArch kernel supports 4K page size. Change TARGET_PAGE_BITS to 12. Signed-off-by: Song Gao Message-Id: <20231023024059.3858349-1-gaos...@loongson.cn> --- target/loongarch/cpu-param.h | 2 +- target/loongarch/tlb_helper.c | 9 - 2 files changed, 5 insertions(+), 6 deletions(-) d

[PULL 07/10] linux-user/loongarch64: setup_sigframe() set 'end' context size 0

2023-11-02 Thread Song Gao
See: https://github.com/torvalds/linux/blob/master/arch/loongarch/kernel/signal.c The kernel setup_sigcontext() set end context size 0. Signed-off-by: Song Gao Reviewed-by: Richard Henderson Message-Id: <20231101030816.2353416-4-gaos...@loongson.cn> --- linux-user/loongarch64/signal.c | 2 +-

[PULL 09/10] linux-user/loongarch64: Add LSX sigcontext save/restore

2023-11-02 Thread Song Gao
Signed-off-by: Song Gao Reviewed-by: Richard Henderson Message-Id: <20231101030816.2353416-6-gaos...@loongson.cn> --- linux-user/loongarch64/signal.c | 107 ++-- 1 file changed, 87 insertions(+), 20 deletions(-) diff --git a/linux-user/loongarch64/signal.c b/linux-us

[PULL 08/10] linux-user/loongarch64: Use abi_{ulong,uint} types

2023-11-02 Thread Song Gao
Signed-off-by: Song Gao Reviewed-by: Richard Henderson Message-Id: <20231101030816.2353416-5-gaos...@loongson.cn> --- linux-user/loongarch64/signal.c | 24 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/linux-user/loongarch64/signal.c b/linux-user/loonga

[PULL 03/10] target/loongarch: Implement query-cpu-model-expansion

2023-11-02 Thread Song Gao
Add support for the query-cpu-model-expansion QMP command to LoongArch. We support query the cpu features. e.g la464 and max cpu support LSX/LASX, default enable, la132 not support LSX/LASX. 1. start with '-cpu max,lasx=off' (QEMU) query-cpu-model-expansion type=static model={

[PULL 02/10] target/loongarch: Allow user enable/disable LSX/LASX features

2023-11-02 Thread Song Gao
Some users may not need LSX/LASX, this patch allows the user enable/disable LSX/LASX features. e.g '-cpu max,lsx=on,lasx=on' (default); '-cpu max,lsx=on,lasx=off' (enabled LSX); '-cpu max,lsx=off,lasx=on' (enabled LASX, LSX); '-cpu max,lsx=off' (disable LSX and LASX). Signed-off

[PULL 06/10] linux-user/loongarch64: Fix setup_extcontext alloc wrong fpu_context size

2023-11-02 Thread Song Gao
See: https://github.com/torvalds/linux/blob/master/arch/loongarch/kernel/signal.c The alloc size is sizeof(struct target_fpu_context). Signed-off-by: Song Gao Reviewed-by: Richard Henderson Message-Id: <20231101030816.2353416-3-gaos...@loongson.cn> --- linux-user/loongarch64/signal.c | 2 +-

Re: [PATCH 0/1] sphinx/qapidoc: pylint cleanups

2023-11-02 Thread Markus Armbruster
Markus Armbruster writes: > There are a few more reports left. Before I try to address them, I'd > like to know: > > 1. Do we still need to support Sphinx older than 1.7? > > 2. What should intersperse() do when the first argument is empty? Patch queued, questions remain open. [...]

Re: [PATCH] tests/qapi-schema: Tidy up pylint warnings and advice

2023-11-02 Thread Markus Armbruster
Markus Armbruster writes: > Pylint warns: > > tests/qapi-schema/test-qapi.py:139:13: W1514: Using open without > explicitly specifying an encoding (unspecified-encoding) > tests/qapi-schema/test-qapi.py:143:13: W1514: Using open without > explicitly specifying an encoding (unspecified-e

Re: [PATCH v2 1/4] exec/memattrs: Add iopmp source id, start address, end address to MemTxAttrs

2023-11-02 Thread Ethan Chen via
On Thu, Nov 02, 2023 at 01:53:05PM +, Peter Maydell wrote: > On Thu, 2 Nov 2023 at 13:49, Peter Xu wrote: > > > > On Thu, Nov 02, 2023 at 05:40:12PM +0800, Ethan Chen wrote: > > > Signed-off-by: Ethan Chen > > > --- > > > include/exec/memattrs.h | 6 ++ > > > 1 file changed, 6 insertions

Re: [PATCH v2 1/4] exec/memattrs: Add iopmp source id, start address, end address to MemTxAttrs

2023-11-02 Thread Ethan Chen via
On Thu, Nov 02, 2023 at 09:49:17AM -0400, Peter Xu wrote: > On Thu, Nov 02, 2023 at 05:40:12PM +0800, Ethan Chen wrote: > > Signed-off-by: Ethan Chen > > --- > > include/exec/memattrs.h | 6 ++ > > 1 file changed, 6 insertions(+) > > > > diff --git a/include/exec/memattrs.h b/include/exec/me

Re: [PATCH v5 2/4] qcow2: add configurations for zoned format extension

2023-11-02 Thread Stefan Hajnoczi
On Mon, Oct 30, 2023 at 11:01:26PM +0800, Sam Li wrote: > Hi Eric, > > Eric Blake 于2023年10月30日周一 22:53写道: > > > > On Mon, Oct 30, 2023 at 08:18:45PM +0800, Sam Li wrote: > > > To configure the zoned format feature on the qcow2 driver, it > > > requires settings as: the device size, zone model, zo

Re: [PULL 00/33] target-arm queue

2023-11-02 Thread Stefan Hajnoczi
Applied, thanks. Please update the changelog at https://wiki.qemu.org/ChangeLog/8.2 for any user-visible changes. signature.asc Description: PGP signature

Re: [PATCH v5 2/4] qcow2: add configurations for zoned format extension

2023-11-02 Thread Stefan Hajnoczi
On Mon, Oct 30, 2023 at 08:18:45PM +0800, Sam Li wrote: > To configure the zoned format feature on the qcow2 driver, it > requires settings as: the device size, zone model, zone size, > zone capacity, number of conventional zones, limits on zone > resources (max append bytes, max open zones, and ma

Re: [PULL 00/40] Migration 20231102 patches

2023-11-02 Thread Stefan Hajnoczi
Applied, thanks. Please update the changelog at https://wiki.qemu.org/ChangeLog/8.2 for any user-visible changes. signature.asc Description: PGP signature

Re: [PULL 00/10] m68k patches

2023-11-02 Thread Stefan Hajnoczi
Applied, thanks. Please update the changelog at https://wiki.qemu.org/ChangeLog/8.2 for any user-visible changes. signature.asc Description: PGP signature

Re: [PATCH v5 2/4] qcow2: add configurations for zoned format extension

2023-11-02 Thread Stefan Hajnoczi
On Mon, Oct 30, 2023 at 08:18:45PM +0800, Sam Li wrote: > +typedef struct Qcow2ZoneListEntry { > +QLIST_ENTRY(Qcow2ZoneListEntry) exp_open_zone_entry; > +QLIST_ENTRY(Qcow2ZoneListEntry) imp_open_zone_entry; > +QLIST_ENTRY(Qcow2ZoneListEntry) closed_zone_entry; Where is closed_zone_entr

Re: [PATCH v6 00/13] RISC-V: ACPI: Enable AIA, PLIC and update RHCT

2023-11-02 Thread Sunil V L
On Thu, Nov 02, 2023 at 06:00:22PM -0300, Daniel Henrique Barboza wrote: > Sunil, > > > While doing unrelated work (running Gitlab on my series built on top of > current riscv-to-apply.next), I hit the following error: > > https://gitlab.com/danielhb/qemu/-/jobs/5448178994 > > == > > 4

Re: [PATCH] tests/qapi-schema: Tidy up pylint warnings and advice

2023-11-02 Thread John Snow
On Wed, Oct 25, 2023 at 5:36 AM Markus Armbruster wrote: > > Pylint warns: > > tests/qapi-schema/test-qapi.py:139:13: W1514: Using open without > explicitly specifying an encoding (unspecified-encoding) > tests/qapi-schema/test-qapi.py:143:13: W1514: Using open without > explicitly speci

[PATCH v7 06/13] hw/riscv/virt-acpi-build.c: Add IMSIC in the MADT

2023-11-02 Thread Sunil V L
Add IMSIC structure in MADT when IMSIC is configured. Signed-off-by: Sunil V L Reviewed-by: Daniel Henrique Barboza Reviewed-by: Andrew Jones Acked-by: Alistair Francis Acked-by: Michael S. Tsirkin --- hw/riscv/virt-acpi-build.c | 35 +++ 1 file changed, 35 in

[PATCH v7 13/13] hw/riscv/virt-acpi-build.c: Add PLIC in MADT

2023-11-02 Thread Sunil V L
Add PLIC structures for each socket in the MADT when system is configured with PLIC as the external interrupt controller. Signed-off-by: Haibo Xu Signed-off-by: Sunil V L Reviewed-by: Daniel Henrique Barboza Reviewed-by: Andrew Jones Acked-by: Alistair Francis Acked-by: Michael S. Tsirkin --

[PATCH v7 07/13] hw/riscv/virt-acpi-build.c: Add APLIC in the MADT

2023-11-02 Thread Sunil V L
Add APLIC structures for each socket in the MADT when system is configured with APLIC as the external wired interrupt controller. Signed-off-by: Sunil V L Reviewed-by: Daniel Henrique Barboza Reviewed-by: Andrew Jones Acked-by: Alistair Francis Acked-by: Michael S. Tsirkin --- hw/riscv/virt-

[PATCH v7 12/13] hw/riscv/virt-acpi-build.c: Add IO controllers and devices

2023-11-02 Thread Sunil V L
Add basic IO controllers and devices like PCI, VirtIO and UART in the ACPI namespace. Signed-off-by: Sunil V L Reviewed-by: Daniel Henrique Barboza Acked-by: Alistair Francis Acked-by: Michael S. Tsirkin --- hw/riscv/Kconfig | 1 + hw/riscv/virt-acpi-build.c | 79 ++

[PATCH v7 10/13] hw/pci-host/gpex: Define properties for MMIO ranges

2023-11-02 Thread Sunil V L
ACPI DSDT generator needs information like ECAM range, PIO range, 32-bit and 64-bit PCI MMIO range etc related to the PCI host bridge. Instead of making these values machine specific, create properties for the GPEX host bridge with default value 0. During initialization, the firmware can initialize

[PATCH v7 03/13] hw/i386/acpi-microvm.c: Use common function to add virtio in DSDT

2023-11-02 Thread Sunil V L
With common function to add virtio in DSDT created now, update microvm code also to use it instead of duplicate code. Suggested-by: Andrew Jones Signed-off-by: Sunil V L Acked-by: Alistair Francis Acked-by: Michael S. Tsirkin --- hw/i386/acpi-microvm.c | 15 ++- 1 file changed, 2

[PATCH v7 09/13] hw/riscv/virt-acpi-build.c: Add MMU node in RHCT

2023-11-02 Thread Sunil V L
MMU type information is available via MMU node in RHCT. Add this node in RHCT. Signed-off-by: Sunil V L Reviewed-by: Daniel Henrique Barboza Reviewed-by: Andrew Jones Acked-by: Alistair Francis Acked-by: Michael S. Tsirkin --- hw/riscv/virt-acpi-build.c | 36 +

[PATCH v7 11/13] hw/riscv/virt: Update GPEX MMIO related properties

2023-11-02 Thread Sunil V L
Update the GPEX host bridge properties related to MMIO ranges with values set for the virt machine. Suggested-by: Igor Mammedov Signed-off-by: Sunil V L Reviewed-by: Alistair Francis Acked-by: Michael S. Tsirkin --- hw/riscv/virt.c | 47 - inclu

[PATCH v7 04/13] hw/riscv: virt: Make few IMSIC macros and functions public

2023-11-02 Thread Sunil V L
Some macros and static function related to IMSIC are defined in virt.c. They are required in virt-acpi-build.c. So, make them public. Signed-off-by: Sunil V L Reviewed-by: Daniel Henrique Barboza Reviewed-by: Alistair Francis Reviewed-by: Andrew Jones Acked-by: Michael S. Tsirkin --- hw/risc

[PATCH v7 00/13] RISC-V: ACPI: Enable AIA, PLIC and update RHCT

2023-11-02 Thread Sunil V L
This series primarily enables external interrupt controllers (AIA and PLIC) in ACPI tables for RISC-V virt platform. It also updates RHCT with CMO and MMU related information. Below ECRs for these changes are approved by ASWG and will be available in next ACPI spec release. 1) MADT (AIA) - https

[PATCH v7 08/13] hw/riscv/virt-acpi-build.c: Add CMO information in RHCT

2023-11-02 Thread Sunil V L
When CMO related extensions like Zicboz, Zicbom and Zicbop are enabled, the block size for those extensions need to be communicated via CMO node in RHCT. Add CMO node in RHCT if any of those CMO extensions are detected. Signed-off-by: Sunil V L Reviewed-by: Daniel Henrique Barboza Reviewed-by: A

[PATCH v7 05/13] hw/riscv/virt-acpi-build.c: Add AIA support in RINTC

2023-11-02 Thread Sunil V L
Update the RINTC structure in MADT with AIA related fields. Signed-off-by: Sunil V L Reviewed-by: Daniel Henrique Barboza Acked-by: Alistair Francis Reviewed-by: Andrew Jones Acked-by: Michael S. Tsirkin --- hw/riscv/virt-acpi-build.c | 43 ++ 1 file chang

[PATCH v7 02/13] hw/arm/virt-acpi-build.c: Migrate virtio creation to common location

2023-11-02 Thread Sunil V L
RISC-V also needs to create the virtio in DSDT in the same way as ARM. So, instead of duplicating the code, move this function to the device specific file which is common across architectures. Suggested-by: Igor Mammedov Signed-off-by: Sunil V L Reviewed-by: Alistair Francis Reviewed-by: Andrew

[PATCH v7 01/13] hw/arm/virt-acpi-build.c: Migrate fw_cfg creation to common location

2023-11-02 Thread Sunil V L
RISC-V also needs to use the same code to create fw_cfg in DSDT. So, avoid code duplication by moving the code in arm and riscv to a device specific file. Suggested-by: Igor Mammedov Signed-off-by: Sunil V L Reviewed-by: Daniel Henrique Barboza Reviewed-by: Alistair Francis Reviewed-by: Andrew

Re: [PATCH 1/1] sphinx/qapidoc: Tidy up pylint warning raise-missing-from

2023-11-02 Thread John Snow
On Wed, Oct 25, 2023 at 6:10 AM Markus Armbruster wrote: > > Pylint advises: > > docs/sphinx/qapidoc.py:518:12: W0707: Consider explicitly re-raising > using 'raise ExtensionError(str(err)) from err' (raise-missing-from) > > From its manual: > > Python's exception chaining shows the trace

Re: [PATCH v4 05/14] tpm_crb: move ACPI table building to device interface

2023-11-02 Thread Joelle van Dyne
On Thu, Nov 2, 2023 at 11:50 AM Stefan Berger wrote: > > > > On 10/31/23 00:00, Joelle van Dyne wrote: > > This logic is similar to TPM TIS ISA device. Since TPM CRB can only > > support TPM 2.0 backends, we check for this in realize. > > The problem on x86_64 is that the creation of the ACPI does

Re: [PATCH 0/3] Hexagon (target/hexagon) Enable more short-circuit packets

2023-11-02 Thread Anton Johansson via
Hi, Taylor!:) Always nice to see your name pop up here. The patches seem to have been sent as attachments for whatever reason. / Anton

[PATCH v9 12/19] target/riscv/tcg: add riscv_cpu_write_misa_bit()

2023-11-02 Thread Daniel Henrique Barboza
We have two instances of the setting/clearing a MISA bit from env->misa_ext and env->misa_ext_mask pattern. And the next patch will end up adding one more. Create a helper to avoid code repetition. Signed-off-by: Daniel Henrique Barboza Reviewed-by: Alistair Francis Reviewed-by: LIU Zhiwei Rev

[PATCH v9 09/19] target/riscv/kvm: add 'rva22u64' flag as unavailable

2023-11-02 Thread Daniel Henrique Barboza
KVM does not have the means to support enabling the rva22u64 profile. The main reasons are: - we're missing support for some mandatory rva22u64 extensions in the KVM module; - we can't make promises about enabling a profile since it all depends on host support in the end. We'll revisit this

[PATCH v9 13/19] target/riscv/tcg: handle profile MISA bits

2023-11-02 Thread Daniel Henrique Barboza
The profile support is handling multi-letter extensions only. Let's add support for MISA bits as well. We'll go through every known MISA bit. If the profile doesn't declare the bit as mandatory, ignore it. Otherwise, set the bit in env->misa_ext and env->misa_ext_mask. Now that we're setting prof

[PATCH v9 06/19] target/riscv/tcg: add 'zic64b' support

2023-11-02 Thread Daniel Henrique Barboza
zic64b is defined in the RVA22U64 profile [1] as a named feature for "Cache blocks must be 64 bytes in size, naturally aligned in the address space". It's a fantasy name for 64 bytes cache blocks. The RVA22U64 profile mandates this feature, meaning that applications using this profile expects 64 by

[PATCH v9 07/19] riscv-qmp-cmds.c: expose named features in cpu_model_expansion

2023-11-02 Thread Daniel Henrique Barboza
Named features (zic64b the sole example at this moment) aren't expose to users, thus we need another way to expose them. Go through each named feature, get its boolean value, do the needed conversions (bool to qbool, qbool to QObject) and add it to output dict. Another adjustment is needed: named

[PATCH v9 11/19] target/riscv/tcg: add MISA user options hash

2023-11-02 Thread Daniel Henrique Barboza
We already track user choice for multi-letter extensions because we needed to honor user choice when enabling/disabling extensions during realize(). We refrained from adding the same mechanism for MISA extensions since we didn't need it. Profile support requires tne need to check for user choice f

[PATCH v9 14/19] target/riscv/tcg: add hash table insert helpers

2023-11-02 Thread Daniel Henrique Barboza
Previous patches added several g_hash_table_insert() patterns. Add two helpers, one for each user hash, to make the code cleaner. Signed-off-by: Daniel Henrique Barboza Reviewed-by: Andrew Jones --- target/riscv/tcg/tcg-cpu.c | 28 1 file changed, 16 insertions(+),

[PATCH v9 15/19] target/riscv/tcg: honor user choice for G MISA bits

2023-11-02 Thread Daniel Henrique Barboza
RVG behaves like a profile: a single flag enables a set of bits. Right now we're considering user choice when handling RVG and zicsr/zifencei and ignoring user choice on MISA bits. We'll add user warnings for profiles when the user disables its mandatory extensions in the next patch. We'll do the

[PATCH v9 10/19] target/riscv/tcg: add user flag for profile support

2023-11-02 Thread Daniel Henrique Barboza
The TCG emulation implements all the extensions described in the RVA22U64 profile, both mandatory and optional. The mandatory extensions will be enabled via the profile flag. We'll leave the optional extensions to be enabled by hand. Given that this is the first profile we're implementing in TCG w

[PATCH v9 16/19] target/riscv/tcg: validate profiles during finalize

2023-11-02 Thread Daniel Henrique Barboza
Enabling a profile and then disabling some of its mandatory extensions is a valid use. It can be useful for debugging and testing. But the common expected use of enabling a profile is to enable all its mandatory extensions. Add an user warning when mandatory extensions from an enabled profile are

[PATCH v9 18/19] target/riscv: add 'rva22u64' CPU

2023-11-02 Thread Daniel Henrique Barboza
This CPU was suggested by Alistair [1] and others during the profile design discussions. It consists of the bare 'rv64i' CPU with rva22u64 enabled by default, like an alias of '-cpu rv64i,rva22u64=true'. Users now have an even easier way of consuming this user-mode profile by doing '-cpu rva22u64'

[PATCH v9 17/19] riscv-qmp-cmds.c: add profile flags in cpu-model-expansion

2023-11-02 Thread Daniel Henrique Barboza
Expose all profile flags for all CPUs when executing query-cpu-model-expansion. This will allow callers to quickly determine if a certain profile is implemented by a given CPU. This includes vendor CPUs - the fact that they don't have profile user flags doesn't mean that they don't implement the pr

[PATCH v9 19/19] target/riscv/tcg: do not support profiles for 'max' CPU

2023-11-02 Thread Daniel Henrique Barboza
There's no gain in allowing the 'max' CPU to support profiles, since it already contains everything that QEMU can support. And we'll open the door for 'unorthodox' stuff like users disabling profiles of the 'max' CPU. Signed-off-by: Daniel Henrique Barboza --- target/riscv/tcg/tcg-cpu.c | 16 +++

[PATCH v9 08/19] target/riscv: add rva22u64 profile definition

2023-11-02 Thread Daniel Henrique Barboza
The rva22U64 profile, described in: https://github.com/riscv/riscv-profiles/blob/main/profiles.adoc#rva22-profiles Contains a set of CPU extensions aimed for 64-bit userspace applications. Enabling this set to be enabled via a single user flag makes it convenient to enable a predictable set of fe

[PATCH v9 04/19] target/riscv: add rv64i CPU

2023-11-02 Thread Daniel Henrique Barboza
We don't have any form of a 'bare bones' CPU. rv64, our default CPUs, comes with a lot of defaults. This is fine for most regular uses but it's not suitable when more control of what is actually loaded in the CPU is required. A bare-bones CPU would be annoying to deal with if not by profile suppor

[PATCH v9 03/19] target/riscv/tcg: update priv_ver on user_set extensions

2023-11-02 Thread Daniel Henrique Barboza
We'll add a new bare CPU type that won't have any default priv_ver. This means that the CPU will default to priv_ver = 0, i.e. 1.10.0. At the same we'll allow these CPUs to enable extensions at will, but then, if the extension has a priv_ver newer than 1.10, we'll end up disabling it. Users will t

[PATCH v9 05/19] target/riscv: add zicbop extension flag

2023-11-02 Thread Daniel Henrique Barboza
QEMU already implements zicbom (Cache Block Management Operations) and zicboz (Cache Block Zero Operations). Commit 59cb29d6a5 ("target/riscv: add Zicbop cbo.prefetch{i, r, m} placeholder") added placeholders for what would be the instructions for zicbop (Cache Block Prefetch Operations), which are

[PATCH v9 01/19] target/riscv: create TYPE_RISCV_VENDOR_CPU

2023-11-02 Thread Daniel Henrique Barboza
We want to add a new CPU type for bare CPUs that will inherit specific traits of the 2 existing types: - it will allow for extensions to be enabled/disabled, like generic CPUs; - it will NOT inherit defaults, like vendor CPUs. We can make this conditions met by adding an explicit type for the

[PATCH v9 00/19] rv64i and rva22u64 CPUs, RVA22U64 profile support

2023-11-02 Thread Daniel Henrique Barboza
Hi, In this version two new patches were added, both while discussing v6 with Alistair: - new 'rva22u64' CPU. This is a CPU suggested by Alistair and others to allow users to use a profile without having to deal with profile enablement. This is done in patch 18; - 'max' CPU profile restricti

[PATCH v9 02/19] target/riscv/tcg: do not use "!generic" CPU checks

2023-11-02 Thread Daniel Henrique Barboza
Our current logic in get/setters of MISA and multi-letter extensions works because we have only 2 CPU types, generic and vendor, and by using "!generic" we're implying that we're talking about vendor CPUs. When adding a third CPU type this logic will break so let's handle it beforehand. In set_mis

Re: [PATCH v2 00/35] tcg: Introduce TCG_COND_TST{EQ,NE}

2023-11-02 Thread Richard Henderson
Ping. Running out of days before soft-freeze. :-) r~ On 10/28/23 12:44, Richard Henderson wrote: Expose a pair of comparison operators that map to the "test" comparison that is available on many architectures. Changes for v2: * Add TCGCond to tcg_target_const_match. This fixes a long

Re: [PATCH v6 00/13] RISC-V: ACPI: Enable AIA, PLIC and update RHCT

2023-11-02 Thread Daniel Henrique Barboza
Sunil, While doing unrelated work (running Gitlab on my series built on top of current riscv-to-apply.next), I hit the following error: https://gitlab.com/danielhb/qemu/-/jobs/5448178994 == 4/257 ERROR:../tests/qtest/bios-tables-test.c:535:test_acpi_asl: assertion failed: (all_tables

[PATCH 3/3] Hexagon (target/hexagon) Enable more short-circuit packets (HVX)

2023-11-02 Thread Taylor Simpson
binstlsT1oUDf.bin Description: test/plain

[PATCH 0/3] Hexagon (target/hexagon) Enable more short-circuit packets

2023-11-02 Thread Taylor Simpson
binQUp8uBOBfS.bin Description: test/plain

[PATCH 1/3] Hexagon (target/hexagon) Analyze reads before writes

2023-11-02 Thread Taylor Simpson
binJqsrgMI63R.bin Description: test/plain

[PATCH 2/3] Hexagon (target/hexagon) Enable more short-circuit packets (scalar core)

2023-11-02 Thread Taylor Simpson
binBoZeeZ311a.bin Description: test/plain

Re: [PATCH] s390/sclp: fix SCLP facility map

2023-11-02 Thread Eric Farman
(+cc qemu-devel) On Tue, 2023-10-24 at 12:07 +0200, Heiko Carstens wrote: > Qemu's SCLP implementation incorrectly reports that it supports CPU > reconfiguration. If a guest issues a CPU reconfiguration request it > is rejected as invalid command. > > Fix the SCLP_HAS_CPU_INFO mask, and remove th

Re: [PATCH v4 05/14] tpm_crb: move ACPI table building to device interface

2023-11-02 Thread Stefan Berger
On 10/31/23 00:00, Joelle van Dyne wrote: This logic is similar to TPM TIS ISA device. Since TPM CRB can only support TPM 2.0 backends, we check for this in realize. The problem on x86_64 is that the creation of the ACPI doesn't seem to get invoked. The device then ends up not working under

[PULL 20/33] hw/misc/imx7_snvs: Trace MMIO access

2023-11-02 Thread Peter Maydell
From: Bernhard Beschow Signed-off-by: Bernhard Beschow Reviewed-by: Philippe Mathieu-Daudé Message-id: 20231028122415.14869-4-shen...@gmail.com Signed-off-by: Peter Maydell --- hw/misc/imx7_snvs.c | 5 + hw/misc/trace-events | 4 2 files changed, 9 insertions(+) diff --git a/hw/mis

[PATCH v2 1/4] plugins: add dllexport and dllimport to api funcs

2023-11-02 Thread Greg Manning
In qemu-plugin.h, mark all API functions as __declspec(dllexport) when compiling the executables, and as __declspec(dllimport) when being used to compile plugins against. Signed-off-by: Greg Manning --- include/qemu/qemu-plugin.h | 50 +++--- 1 file changed, 47 in

Re: [PATCH v3 qemu 2/3] dump: Allow directly outputting raw kdump format

2023-11-02 Thread Stephen Brennan
Marc-André Lureau writes: > Hi Stephen > > On Tue, Sep 19, 2023 at 3:32 AM Stephen Brennan > wrote: >> >> The flattened format (currently output by QEMU) is used by makedumpfile >> only when it is outputting a vmcore to a file which is not seekable. The >> flattened format functions essentially

[PULL 21/33] hw/misc/imx6_ccm: Convert DPRINTF to trace events

2023-11-02 Thread Peter Maydell
From: Bernhard Beschow Signed-off-by: Bernhard Beschow Reviewed-by: Philippe Mathieu-Daudé Message-id: 20231028122415.14869-5-shen...@gmail.com [PMM: Add "Hz" unit indicator to frequency traces] Signed-off-by: Peter Maydell --- hw/misc/imx6_ccm.c | 41 ++-

[PULL 08/33] docs/specs/vmw_pvscsi-spec: Convert to rST

2023-11-02 Thread Peter Maydell
Convert the docs/specs/vmw_pvscsi-spec.txt file to rST format. This conversion includes some minor wordsmithing of the text to fix some grammar nits. Signed-off-by: Peter Maydell Reviewed-by: Thomas Huth Message-id: 20230927151205.70930-2-peter.mayd...@linaro.org --- MAINTAINERS

[PATCH v6 12/13] hw/riscv/virt-acpi-build.c: Add IO controllers and devices

2023-11-02 Thread Sunil V L
Add basic IO controllers and devices like PCI, VirtIO and UART in the ACPI namespace. Signed-off-by: Sunil V L Reviewed-by: Daniel Henrique Barboza Acked-by: Alistair Francis Acked-by: Michael S. Tsirkin --- hw/riscv/Kconfig | 1 + hw/riscv/virt-acpi-build.c | 79 ++

[PULL 29/33] hw/char/stm32f2xx_usart: Add more definitions for CR1 register

2023-11-02 Thread Peter Maydell
From: Hans-Erik Floryd Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson Acked-by: Alistair Francis Signed-off-by: Hans-Erik Floryd Message-id: 20231030151528.1138131-4-hans-erik.flo...@rt-labs.com Signed-off-by: Peter Maydell --- include/hw/char/stm32f2xx_usart.h | 10 ++

[PULL 16/33] MAINTAINERS: Make sure that gicv3_internal.h is covered, too

2023-11-02 Thread Peter Maydell
From: Thomas Huth gic_internal.h is already covered by the "ARM cores" section. Let's adapt the entry with a wildcard to cover gicv3_internal.h, too. Signed-off-by: Thomas Huth Reviewed-by: Philippe Mathieu-Daudé Message-id: 20231027060709.242388-1-th...@redhat.com Signed-off-by: Peter Maydell

Re: [PATCH v2 4/4] plugins: allow plugins to be enabled on windows

2023-11-02 Thread Alex Bennée
Greg Manning writes: > allow plugins to be enabled in the configure script on windows. Also, > add the qemu_plugin_api.lib to the installer. > > Signed-off-by: Greg Manning Reviewed-by: Alex Bennée -- Alex Bennée Virtualisation Tech Lead @ Linaro

Re: [PATCH v2 3/4] plugins: disable lockstep plugin on windows

2023-11-02 Thread Alex Bennée
Greg Manning writes: > The lockstep plugin uses unix sockets and would require a different > communication mechanism to work on Windows. > > Signed-off-by: Greg Manning Reviewed-by: Alex Bennée -- Alex Bennée Virtualisation Tech Lead @ Linaro

[PULL 18/33] hw/watchdog/wdt_imx2: Trace MMIO access

2023-11-02 Thread Peter Maydell
From: Bernhard Beschow Signed-off-by: Bernhard Beschow Reviewed-by: Philippe Mathieu-Daudé Message-id: 20231028122415.14869-2-shen...@gmail.com Signed-off-by: Peter Maydell --- hw/watchdog/wdt_imx2.c | 24 ++-- hw/watchdog/trace-events | 4 2 files changed, 22 inse

Re: [PATCH v2 2/4] plugins: make test/example plugins work on windows

2023-11-02 Thread Alex Bennée
Greg Manning writes: > Generate a qemu_plugin_api.lib delay import lib on windows, for > windows qemu plugins to link against. > > Implement an example dll load fail hook to link up the API functions > correctly when a plugin is loaded on windows. > > Update the build scripts for the test and exa

[PULL 30/33] target/arm: Correctly propagate stage 1 BTI guarded bit in a two-stage walk

2023-11-02 Thread Peter Maydell
In a two-stage translation, the result of the BTI guarded bit should be the guarded bit from the first stage of translation, as there is no BTI guard information in stage two. Our code tried to do this, but got it wrong, because we currently have two fields where the GP bit information might live

Re: [PATCH v2 1/4] plugins: add dllexport and dllimport to api funcs

2023-11-02 Thread Alex Bennée
Greg Manning writes: > In qemu-plugin.h, mark all API functions as __declspec(dllexport) when > compiling the executables, and as __declspec(dllimport) when being used > to compile plugins against. > > Signed-off-by: Greg Manning Reviewed-by: Alex Bennée -- Alex Bennée Virtualisation Tech Le

Re: Configuring migration (was: [PATCH v3 3/4] migration/qapi: Replace @MigrateSetParameters with @MigrationParameters)

2023-11-02 Thread Peter Xu
On Thu, Nov 02, 2023 at 03:25:25PM +0100, Markus Armbruster wrote: > Juan Quintela writes: > > > Markus Armbruster wrote: > >> Peter Xu writes: > >> > >>> On Wed, Oct 11, 2023 at 04:21:02PM +0200, Markus Armbruster wrote: > > > >>> IIRC both of them used to be the goals: either allow compat pro

[PULL 12/33] docs/specs/standard-vga: Convert to rST

2023-11-02 Thread Peter Maydell
Convert docs/specs/standard-vga.txt to rST format. Signed-off-by: Peter Maydell Message-id: 20230927151205.70930-6-peter.mayd...@linaro.org Reviewed-by: Philippe Mathieu-Daudé --- MAINTAINERS | 1 + docs/specs/index.rst| 1 + docs/specs/standard-vga.rst | 94 ++

[PULL 00/33] target-arm queue

2023-11-02 Thread Peter Maydell
ommit 6c9ae1ce82b65faa3f266fd103729878cf11e07e: Merge tag 'for-upstream' of https://repo.or.cz/qemu/kevin into staging (2023-11-01 06:58:11 +0900) are available in the Git repository at: https://git.linaro.org/people/pmaydell/qemu-arm.git tags/pull-target-arm-20231102 for you to fetc

[PATCH v6 04/13] hw/riscv: virt: Make few IMSIC macros and functions public

2023-11-02 Thread Sunil V L
Some macros and static function related to IMSIC are defined in virt.c. They are required in virt-acpi-build.c. So, make them public. Signed-off-by: Sunil V L Reviewed-by: Daniel Henrique Barboza Reviewed-by: Alistair Francis Reviewed-by: Andrew Jones Acked-by: Michael S. Tsirkin --- hw/risc

[PATCH v2 3/4] plugins: disable lockstep plugin on windows

2023-11-02 Thread Greg Manning
The lockstep plugin uses unix sockets and would require a different communication mechanism to work on Windows. Signed-off-by: Greg Manning --- contrib/plugins/Makefile | 6 ++ 1 file changed, 6 insertions(+) diff --git a/contrib/plugins/Makefile b/contrib/plugins/Makefile index 751fa38619.

[PULL 11/33] docs/specs/pvpanic: Convert to rST

2023-11-02 Thread Peter Maydell
Convert docs/specs/pvpanic.txt to rST format. Signed-off-by: Peter Maydell Message-id: 20230927151205.70930-5-peter.mayd...@linaro.org Reviewed-by: Philippe Mathieu-Daudé --- docs/specs/index.rst| 1 + docs/specs/{pvpanic.txt => pvpanic.rst} | 41 -

[PULL 05/33] hw/input/stellaris_gamepad: Remove StellarisGamepadButton struct

2023-11-02 Thread Peter Maydell
Currently for each button on the device we have a StellarisGamepadButton struct which has the irq, keycode and pressed state for it. When we convert to qdev, the qdev property and GPIO APIs are going to require that we have separate arrays for the irqs and keycodes. Convert from array-of-structs

[PULL 09/33] docs/specs/edu: Convert to rST

2023-11-02 Thread Peter Maydell
Convert docs/specs/edu.txt to rST format. Signed-off-by: Peter Maydell Reviewed-by: Thomas Huth Message-id: 20230927151205.70930-3-peter.mayd...@linaro.org --- MAINTAINERS | 1 + docs/specs/{edu.txt => edu.rst} | 84 - docs/specs/index.rst

[PULL 17/33] hw/arm/pxa2xx_gpio: Pass CPU using QOM link property

2023-11-02 Thread Peter Maydell
From: Philippe Mathieu-Daudé Instead of passing the CPU index and resolving it, use a QOM link to directly pass the CPU. Signed-off-by: Philippe Mathieu-Daudé Message-id: 20231030083706.63685-1-phi...@linaro.org Reviewed-by: Peter Maydell Signed-off-by: Peter Maydell --- hw/arm/pxa2xx_gpio.c

[PULL 22/33] hw/i2c/pm_smbus: Convert DPRINTF to trace events

2023-11-02 Thread Peter Maydell
From: Bernhard Beschow Let the trace messages slightly deviate from the function names ("smb" -> "smbus") being traced in order to avoid conflights with the SMB protocol. Signed-off-by: Bernhard Beschow Reviewed-by: Philippe Mathieu-Daudé Acked-by: Corey Minyard Message-id: 20231028122415.148

[PULL 27/33] hw/char/stm32f2xx_usart: Extract common IRQ update code to update_irq()

2023-11-02 Thread Peter Maydell
From: Hans-Erik Floryd Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson Reviewed-by: Alistair Francis Signed-off-by: Hans-Erik Floryd Message-id: 20231030151528.1138131-2-hans-erik.flo...@rt-labs.com Signed-off-by: Peter Maydell --- hw/char/stm32f2xx_usart.c | 28 +++

[PULL 24/33] linux-user: Report AArch64 hwcap2 fields above bit 31

2023-11-02 Thread Peter Maydell
The AArch64 ELF hwcap2 field is 64 bits, but our get_elf_hwcap2() works with uint32_t, so it accidentally fails to report any hwcaps over bit 31. Use uint64_t here. The Arm hwcap2 is only 32 bits (because the ELF format makes these fields be the size of "long" in the ABI), but since it shares the

[PULL 33/33] tests/qtest: Introduce tests for AMD/Xilinx Versal TRNG device

2023-11-02 Thread Peter Maydell
From: Tong Ho Signed-off-by: Tong Ho Message-id: 20231031184611.3029156-4-tong...@amd.com Reviewed-by: Peter Maydell Signed-off-by: Peter Maydell --- tests/qtest/xlnx-versal-trng-test.c | 485 tests/qtest/meson.build | 2 +- 2 files changed, 486 inse

[PULL 25/33] target/arm: Make FEAT_MOPS SET* insns handle Xs == XZR correctly

2023-11-02 Thread Peter Maydell
Most of the registers used by the FEAT_MOPS instructions cannot use 31 as a register field value; this is CONSTRAINED UNPREDICTABLE to NOP or UNDEF (we UNDEF). However, it is permitted for the "source value" register for the memset insns SET* to be 31, which (as usual for most data-processing insn

[PULL 03/33] hw/input/stellaris_gamepad: Rename structs to our usual convention

2023-11-02 Thread Peter Maydell
Rename the structs in stellaris_gamepad.c to our now-standard CamelCase convention. Signed-off-by: Peter Maydell Reviewed-by: Philippe Mathieu-Daudé Tested-by: Philippe Mathieu-Daudé Message-id: 20231030114802.3671871-3-peter.mayd...@linaro.org --- hw/input/stellaris_gamepad.c | 22 +++

[PULL 07/33] hw/input/stellaris_gamepad: Convert to qemu_input_handler_register()

2023-11-02 Thread Peter Maydell
Now that we have converted to qdev, we can use the newer qemu_input_handler_register() API rather than the legacy qemu_add_kbd_event_handler(). Since we only have one user, take the opportunity to convert from scancodes to QCodes, rather than using qemu_input_key_value_to_scancode() (which adds an

[PULL 15/33] docs/specs/vmgenid: Convert to rST

2023-11-02 Thread Peter Maydell
Convert docs/specs/vmgenid.txt to rST format. Reviewed-by: Ani Sinha Signed-off-by: Peter Maydell Message-id: 20230927151205.70930-9-peter.mayd...@linaro.org --- MAINTAINERS| 2 +- docs/specs/index.rst | 1 + docs/specs/vmgenid.rst | 246 +++

[PULL 31/33] hw/misc: Introduce AMD/Xilix Versal TRNG device

2023-11-02 Thread Peter Maydell
From: Tong Ho This adds a non-cryptographic grade implementation of the model for the True Random Number Generator (TRNG) component in AMD/Xilinx Versal device family. This implements all 3 modes defined by the actual hardware specs, all of which selectable by guest software at will at anytime:

  1   2   3   4   >