[PATCH v3 09/16] qtest: bump qos-test timeout to 2 minutes

2023-12-14 Thread Thomas Huth
From: Daniel P. Berrangé The qos-test takes just under 1 minute in a --enable-debug build. Bumping to 2 minutes will give more headroom. Signed-off-by: "Daniel P. Berrangé" Reviewed-by: Thomas Huth Message-ID: <20230717182859.707658-10-berra...@redhat.com> Signed-off-by: Thomas Huth --- test

[PATCH v3 14/16] tests/unit: Bump test-crypto-block test timeout to 5 minutes

2023-12-14 Thread Thomas Huth
When running the tests in slow mode on a very loaded system and with --enable-debug, the test-crypto-block can take longer than 4 minutes. Bump the timeout to 5 minutes to make sure that it also passes in such situations. Signed-off-by: Thomas Huth --- tests/unit/meson.build | 1 + 1 file change

[PATCH v3 11/16] qtest: bump bios-table-test timeout to 9 minutes

2023-12-14 Thread Thomas Huth
From: Daniel P. Berrangé This is reliably hitting the current 2 minute timeout in GitLab CI, and for the TCI job, it even hits a 6 minute timeout. Reviewed-by: Thomas Huth Signed-off-by: "Daniel P. Berrangé" Message-ID: <20230717182859.707658-12-berra...@redhat.com> Signed-off-by: Thomas Huth

[PATCH v3 02/16] qtest: bump migration-test timeout to 8 minutes

2023-12-14 Thread Thomas Huth
From: Daniel P. Berrangé The migration test should take between 1 min 30 and 2 mins on reasonably modern hardware. The test is not especially compute bound, rather its running time is dominated by the guest RAM size relative to the bandwidth cap, which forces each iteration to take at least 30 se

[PATCH v3 12/16] tests/qtest: Bump the device-introspect-test timeout to 12 minutes

2023-12-14 Thread Thomas Huth
When running the test in slow mode on a very loaded system with the arm/aarch64 target and with --enable-debug, it can take longer than 10 minutes to finish the introspection test. Bump the timeout to twelve minutes to make sure that it also finishes in such situations. Signed-off-by: Thomas Huth

[PATCH v3 08/16] qtest: bump boot-serial-test timeout to 3 minutes

2023-12-14 Thread Thomas Huth
From: Daniel P. Berrangé The boot-serial-test takes about 1 + 1/2 minutes in a --enable-debug build. Bumping to 3 minutes will give more headroom. Signed-off-by: "Daniel P. Berrangé" Reviewed-by: Thomas Huth Message-ID: <20230717182859.707658-9-berra...@redhat.com> Signed-off-by: Thomas Huth

[PATCH v3 13/16] tests/unit: Bump test-aio-multithread test timeout to 2 minutes

2023-12-14 Thread Thomas Huth
When running the tests in slow mode on a very loaded system and with --enable-debug, the test-aio-multithread can take longer than 1 minute. Bump the timeout to two minutes to make sure that it also passes in such situations. Signed-off-by: Thomas Huth --- tests/unit/meson.build | 1 + 1 file ch

[PATCH v3 00/16] tests: enable meson test timeouts to improve debuggability

2023-12-14 Thread Thomas Huth
This is a respin of Daniel's series that re-enables the meson test runner timeouts. To make sure that we do not get into trouble on older systems, I ran all the tests with "make check SPEED=slow -j32" on my laptop that has only 16 SMT threads, so each test was running quite a bit slower than with a

[PATCH v3 06/16] qtest: bump pxe-test timeout to 10 minutes

2023-12-14 Thread Thomas Huth
From: Daniel P. Berrangé The pxe-test uses the boot_sector_test() function, and that already uses a timeout of 600 seconds. So adjust the timeout on the meson side accordingly. Signed-off-by: "Daniel P. Berrangé" [thuth: Bump timeout to 600s and adjust commit description] Signed-off-by: Thomas

[PATCH v3 15/16] tests/fp: Bump fp-test-mulAdd test timeout to 3 minutes

2023-12-14 Thread Thomas Huth
When running the tests in slow mode with --enable-debug on a very loaded system, the fp-test-mulAdd test can take longer than 2 minutes. Bump the timeout to three minutes to make sure it passes in such situations, too. Signed-off-by: Thomas Huth --- tests/fp/meson.build | 2 +- 1 file changed,

[PATCH v3 01/16] qtest: bump min meson timeout to 60 seconds

2023-12-14 Thread Thomas Huth
From: Daniel P. Berrangé Even some of the relatively fast qtests can sometimes hit the 30 second timeout in GitLab CI under high parallelism/load conditions. Bump the min to 60 seconds to give a higher margin for reliability. Reviewed-by: Thomas Huth Signed-off-by: "Daniel P. Berrangé" Message

[PATCH v3 10/16] qtest: bump aspeed_smc-test timeout to 6 minutes

2023-12-14 Thread Thomas Huth
From: Daniel P. Berrangé On a loaded system with --enable-debug, this test can take longer than 5 minutes. Raising the timeout to 6 minutes gives greater headroom for such situations. Signed-off-by: "Daniel P. Berrangé" [thuth: Increase the timeout to 6 minutes for very loaded systems] Signed-o

[PATCH v3 04/16] qtest: bump npcm7xx_pwn-test timeout to 5 minutes

2023-12-14 Thread Thomas Huth
From: Daniel P. Berrangé The npcm7xx_pwn-test takes 3 & 1/2 minutes in a --enable-debug build. Bumping to 5 minutes will give more headroom. Signed-off-by: "Daniel P. Berrangé" Reviewed-by: Thomas Huth Message-ID: <20230717182859.707658-5-berra...@redhat.com> Signed-off-by: Thomas Huth --- t

[PATCH v3 05/16] qtest: bump test-hmp timeout to 4 minutes

2023-12-14 Thread Thomas Huth
From: Daniel P. Berrangé The hmp test takes just under 3 minutes in a --enable-debug build. Bumping to 4 minutes will give more headroom. Signed-off-by: "Daniel P. Berrangé" Reviewed-by: Thomas Huth Message-ID: <20230717182859.707658-6-berra...@redhat.com> [thuth: fix copy-n-paste error in the

[PATCH v3 16/16] mtest2make: stop disabling meson test timeouts

2023-12-14 Thread Thomas Huth
From: Daniel P. Berrangé The mtest2make.py script passes the arg '-t 0' to 'meson test' which disables all test timeouts. This is a major source of pain when running in GitLab CI and a test gets stuck. It will stall until GitLab kills the CI job. This leaves us with little easily consumable infor

[PATCH v3 03/16] qtest: bump qom-test timeout to 15 minutes

2023-12-14 Thread Thomas Huth
From: Daniel P. Berrangé The qom-test is periodically hitting the 5 minute timeout when running on the aarch64 emulator under GitLab CI. With an --enable-debug build it can take over 10 minutes for arm/aarch64 targets. Setting timeout to 15 minutes gives enough headroom to hopefully make it relia

[PATCH v3 07/16] qtest: bump prom-env-test timeout to 6 minutes

2023-12-14 Thread Thomas Huth
From: Daniel P. Berrangé The prom-env-test can take more than 5 minutes in a --enable-debug build on a loaded system. Bumping to 6 minutes will give more headroom. Signed-off-by: "Daniel P. Berrangé" [thuth: Bump timeout to 6 minutes instead of 3] Signed-off-by: Thomas Huth --- tests/qtest/me

Re: [RFC 1/1] hw: tpmtisspi: add SPI support to QEMU TPM implementation

2023-12-14 Thread Iris Chen
Hi Guenter, Not from me at this moment :) Thanks, Iris On Wed, Dec 13, 2023 at 9:39 AM Guenter Roeck wrote: > Hi, > > On Tue, Aug 02, 2022 at 07:32:41PM -0700, Iris Chen wrote: > > From: Iris Chen > > > > Signed-off-by: Iris Chen > > --- > > Are there any plans to submit a new version of thi

Re: [PATCH v6 1/5] hw/riscv: Use misa_mxl instead of misa_mxl_max

2023-12-14 Thread Akihiko Odaki
On 2023/12/15 14:34, Alistair Francis wrote: On Thu, Nov 23, 2023 at 5:24 PM Akihiko Odaki wrote: On 2023/11/23 12:04, Alistair Francis wrote: On Mon, Oct 30, 2023 at 3:50 PM Akihiko Odaki wrote: The effective MXL value matters when booting. This doesn't sound right. Surely the max is wh

Re: [PATCH v7 4/4] target/riscv: Validate misa_mxl_max only once

2023-12-14 Thread Alistair Francis
On Wed, Dec 13, 2023 at 4:12 PM Akihiko Odaki wrote: > > misa_mxl_max is now a class member and initialized only once for each > class. This also moves the initialization of gdb_core_xml_file which > will be referenced before realization in the future. > > Signed-off-by: Akihiko Odaki Reviewed-b

Re: [PATCH v7 3/4] target/riscv: Move misa_mxl_max to class

2023-12-14 Thread Alistair Francis
On Wed, Dec 13, 2023 at 3:20 PM Akihiko Odaki wrote: > > misa_mxl_max is common for all instances of a RISC-V CPU class so they > are better put into class. > > Signed-off-by: Akihiko Odaki Reviewed-by: Alistair Francis Alistair > --- > target/riscv/cpu.h | 4 +- > target/riscv/cpu

Re: [PATCH v6 1/5] hw/riscv: Use misa_mxl instead of misa_mxl_max

2023-12-14 Thread Alistair Francis
On Thu, Nov 23, 2023 at 5:24 PM Akihiko Odaki wrote: > > On 2023/11/23 12:04, Alistair Francis wrote: > > On Mon, Oct 30, 2023 at 3:50 PM Akihiko Odaki > > wrote: > >> > >> The effective MXL value matters when booting. > > > > This doesn't sound right. Surely the max is what matters here > > > >

Re: [PATCH qemu v3 2/2] hw/arm: Add minimal support for the B-L475E-IOT01A board

2023-12-14 Thread Alistair Francis
On Fri, Dec 15, 2023 at 1:24 AM ~inesvarhol wrote: > > From: Inès Varhol > > This commit adds a new B-L475E-IOT01A board using the STM32L475VG SoC. > The implementation is derived from the Netduino Plus 2 machine. > There are no peripherals implemented yet, only memory regions. > > Reviewed-by: P

Re: [PATCH qemu v3 1/2] hw/arm: Add minimal support for the STM32L4x5 SoC

2023-12-14 Thread Alistair Francis
On Fri, Dec 15, 2023 at 1:24 AM ~inesvarhol wrote: > > From: Inès Varhol > > This patch adds a new STM32L4x5 SoC, it is necessary to add support for > the B-L475E-IOT01A board. > The implementation is derived from the STM32F405 SoC. > The implementation contains no peripherals, only memory region

Re: [PATCH v5] target/riscv: update checks on writing pmpcfg for Smepmp to version 1.0

2023-12-14 Thread Alistair Francis
On Wed, Dec 6, 2023 at 3:37 PM Alvin Chang wrote: > > > -Original Message- > > > From: Alistair Francis > > > Sent: Wednesday, December 6, 2023 11:39 AM > > > To: Alvin Che-Chia Chang(張哲嘉) > > > Cc: qemu-ri...@nongnu.org; qemu-devel@nongnu.org; > > > alistair.fran...@wdc.com; liwei...@is

Re: [PATCH qemu 1/2] hw/arm: Add minimal support for the STM32L4x5 SoC

2023-12-14 Thread Alistair Francis
On Thu, Dec 7, 2023 at 2:04 AM Alex Bennée wrote: > > Alistair Francis writes: > > > On Mon, Nov 27, 2023 at 12:44 AM ~inesvarhol wrote: > >> > >> From: Inès Varhol > >> > >> This patch adds a new STM32L4x5 SoC, it is necessary to add support for > >> the B-L475E-IOT01A board. > >> The implemen

Re: [PATCH] docs: fix typo

2023-12-14 Thread Zhao Liu
On Thu, Dec 14, 2023 at 11:53:18PM +0100, Samuel Tardieu wrote: > Date: Thu, 14 Dec 2023 23:53:18 +0100 > From: Samuel Tardieu > Subject: [PATCH] docs: fix typo > X-Mailer: git-send-email 2.42.0 > > Signed-off-by: Samuel Tardieu > --- Reviewed-by: Zhao Liu > docs/tools/qemu-img.rst | 2 +- >

[PATCH 1/1] target/riscv: Not allow write mstatus_vs without RVV

2023-12-14 Thread LIU Zhiwei
If CPU does not implement the Vector extension, it usually means mstatus vs hardwire to zero. So we should not allow write a non-zero value to this field. Signed-off-by: LIU Zhiwei --- target/riscv/csr.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/target/riscv/csr.c b

Re: [PATCH 1/2] system/memory.c: support unaligned access

2023-12-14 Thread Tomoyuki Hirose
On Mon, Dec 11, 2023 at 10:31 PM Cédric Le Goater wrote: > FWIW, there has been a previous proposal for unaligned accesses support [1]. > > Thanks, > > C. > > [1] https://lore.kernel.org/qemu-devel/20170630030058.28943-1-and...@aj.id.au/ > Thanks for your information. This patch is an RFC, and un

[PATCH 2/2] tcg: Jump after always false condition

2023-12-14 Thread Samuel Tardieu
`buf_rw` is always `NULL` when jumping to the `fail` label. Move the label `down` after the `if (buf_rw) { ... }` statement. Signed-off-by: Samuel Tardieu --- tcg/region.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tcg/region.c b/tcg/region.c index 6d657e8c33..691a726eae

[PATCH 1/2] tcg: Remove unreachable code

2023-12-14 Thread Samuel Tardieu
The `fail_rx`/`fail` block is only entered while `buf_rx` is equal to its initial value `MAP_FAILED`. The `munmap(buf_rx, size);` was never executed. Resolves: https://gitlab.com/qemu-project/qemu/-/issues/2030 Signed-off-by: Samuel Tardieu --- tcg/region.c | 3 --- 1 file changed, 3 deletions(-

[PATCH 0/2] Remove unreachable code and move label after unreachable condition

2023-12-14 Thread Samuel Tardieu
Unreachable code in an error handling block is listed in issue https://gitlab.com/qemu-project/qemu/-/issues/2030. After removing this code, the `fail` label is now immediately followed by a test whose condition can never be true when coming explicitly via this label. Moving the label down preserv

[PATCH] docs: fix typo

2023-12-14 Thread Samuel Tardieu
Signed-off-by: Samuel Tardieu --- docs/tools/qemu-img.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/tools/qemu-img.rst b/docs/tools/qemu-img.rst index 4459c065f1..3653adb963 100644 --- a/docs/tools/qemu-img.rst +++ b/docs/tools/qemu-img.rst @@ -406,7 +406,7 @@ Comma

Re: [PATCH v3] fsl-imx: add simple RTC emulation for i.MX6 and i.MX7 boards

2023-12-14 Thread Nikita Ostrenkov
Sorry again. Honestly, I was in a hurry. Unfortunately, I'm currently using a different PC, and git publish doesn't work on it (some issues with SSL certificates). I sent the first and second versions of the patch from my main home PC through this way, but, regrettably, I had to manually send the

[PATCH v8 06/11] tests/qtest: Creating qtest for GMAC Module

2023-12-14 Thread Nabih Estefan
From: Nabih Estefan Diaz - Created qtest to check initialization of registers in GMAC Module. - Implemented test into Build File. Signed-off-by: Nabih Estefan Reviewed-by: Tyrone Ting --- tests/qtest/meson.build | 2 + tests/qtest/npcm_gmac-test.c | 209 ++

[PATCH v8 11/11] tests/qtest: Adding PCS Module test to GMAC Qtest

2023-12-14 Thread Nabih Estefan
From: Nabih Estefan Diaz - Add PCS Register check to npcm_gmac-test Signed-off-by: Nabih Estefan Reviewed-by: Tyrone Ting --- tests/qtest/npcm_gmac-test.c | 134 ++- 1 file changed, 133 insertions(+), 1 deletion(-) diff --git a/tests/qtest/npcm_gmac-test.c b/

[PATCH v8 04/11] hw/net: Add NPCMXXX GMAC device

2023-12-14 Thread Nabih Estefan
From: Hao Wu This patch implements the basic registers of GMAC device and sets registers for networking functionalities. Tested: The following message shows up with the change: Broadcom BCM54612E stmmac-0:00: attached PHY driver [Broadcom BCM54612E] (mii_bus:phy_addr=stmmac-0:00, irq=POLL) stmm

[PATCH v8 01/11] hw/misc: Add Nuvoton's PCI Mailbox Module

2023-12-14 Thread Nabih Estefan
From: Hao Wu The PCI Mailbox Module is a high-bandwidth communcation module between a Nuvoton BMC and CPU. It features 16KB RAM that are both accessible by the BMC and core CPU. and supports interrupt for both sides. This patch implements the BMC side of the PCI mailbox module. Communication wit

[PATCH v8 08/11] hw/net: General GMAC Implementation

2023-12-14 Thread Nabih Estefan
From: Nabih Estefan Diaz - General GMAC Register handling - GMAC IRQ Handling - Added traces in some methods for debugging - Lots of declarations for accessing information on GMAC Descriptors (npcm_gmac.h file) NOTE: With code on this state, the GMAC can boot-up properly and will show up in th

[PATCH v8 05/11] hw/arm: Add GMAC devices to NPCM7XX SoC

2023-12-14 Thread Nabih Estefan
From: Hao Wu Signed-off-by: Hao Wu Signed-off-by: Nabih Estefan Reviewed-by: Tyrone Ting --- hw/arm/npcm7xx.c | 36 ++-- include/hw/arm/npcm7xx.h | 2 ++ 2 files changed, 36 insertions(+), 2 deletions(-) diff --git a/hw/arm/npcm7xx.c b/hw/arm/npcm7xx.

[PATCH v8 00/11] Implementation of NPI Mailbox and GMAC Networking Module

2023-12-14 Thread Nabih Estefan
From: Nabih Estefan Diaz [Changes since v7] Fixed patch 4 declaration of new NIC based on comments by Peter Maydell (peter.mayd...@linaro.org) [Changes since v6] Remove the Change-Ids from the commit messages. [Changes since v5] Undid remove of some qtests that seem to have been caused by a mer

[PATCH v8 10/11] hw/net: GMAC Tx Implementation

2023-12-14 Thread Nabih Estefan
From: Nabih Estefan Diaz - Implementation of Transmit function for packets - Implementation for reading and writing from and to descriptors in memory for Tx NOTE: This function implements the steps detailed in the datasheet for transmitting messages from the GMAC. Signed-off-by: Nabih Estefan

[PATCH v8 03/11] hw/misc: Add qtest for NPCM7xx PCI Mailbox

2023-12-14 Thread Nabih Estefan
From: Hao Wu This patches adds a qtest for NPCM7XX PCI Mailbox module. It sends read and write requests to the module, and verifies that the module contains the correct data after the requests. Signed-off-by: Hao Wu Signed-off-by: Nabih Estefan Reviewed-by: Tyrone Ting --- tests/qtest/meson.

[PATCH v8 07/11] include/hw/net: Implemented Classes and Masks for GMAC Descriptors

2023-12-14 Thread Nabih Estefan
From: Nabih Estefan Diaz - Implemeted classes for GMAC Receive and Transmit Descriptors - Implemented Masks for said descriptors Signed-off-by: Nabih Estefan Reviewed-by: Tyrone Ting --- hw/net/npcm_gmac.c | 183 +++ hw/net/trace-events |

[PATCH v8 02/11] hw/arm: Add PCI mailbox module to Nuvoton SoC

2023-12-14 Thread Nabih Estefan
From: Hao Wu This patch wires the PCI mailbox module to Nuvoton SoC. Signed-off-by: Hao Wu Signed-off-by: Nabih Estefan Reviewed-by: Tyrone Ting --- docs/system/arm/nuvoton.rst | 2 ++ hw/arm/npcm7xx.c| 3 ++- include/hw/arm/npcm7xx.h| 1 + 3 files changed, 5 insertions(+), 1

[PATCH v8 09/11] hw/net: GMAC Rx Implementation

2023-12-14 Thread Nabih Estefan
From: Nabih Estefan Diaz - Implementation of Receive function for packets - Implementation for reading and writing from and to descriptors in memory for Rx When RX starts, we need to flush the queued packets so that they can be received by the GMAC device. Without this it won't work with TAP N

Re: [RFC 3/3] aio-posix: call ->poll_end() when removing AioHandler

2023-12-14 Thread Paolo Bonzini
Il gio 14 dic 2023, 21:12 Stefan Hajnoczi ha scritto: > Since the fd may be bypassed until ->io_poll_end() returns, we must poll > one last time to check if an event snuck in right at the end without > making the fd readable. If polling detected an event, then we must do > something. We cannot dr

Re: [RFC 3/3] aio-posix: call ->poll_end() when removing AioHandler

2023-12-14 Thread Stefan Hajnoczi
On Wed, Dec 13, 2023 at 10:52:58PM +0100, Paolo Bonzini wrote: > On Wed, Dec 13, 2023 at 10:15 PM Stefan Hajnoczi wrote: > > -/* If a read is in progress, just mark the node as deleted */ > > -if (ctx->walking_handlers > 0) { > > -QLIST_INSERT_HEAD_RCU(&ctx->deleted_aio_handlers, n

Re: [RFC 0/3] aio-posix: call ->poll_end() when removing AioHandler

2023-12-14 Thread Stefan Hajnoczi
On Thu, Dec 14, 2023 at 02:38:47PM +0100, Fiona Ebner wrote: > Am 13.12.23 um 22:15 schrieb Stefan Hajnoczi: > > But there you have it. Please let me know what you think and try your > > reproducers to see if this fixes the missing io_poll_end() issue. Thanks! > > > > Thanks to you! I applied the

Re: [RFC 0/3] aio-posix: call ->poll_end() when removing AioHandler

2023-12-14 Thread Stefan Hajnoczi
On Thu, Dec 14, 2023 at 12:10:32AM +0100, Paolo Bonzini wrote: > On Wed, Dec 13, 2023 at 10:15 PM Stefan Hajnoczi wrote: > > Alternatives welcome! (A cleaner version of this approach might be to forbid > > cross-thread aio_set_fd_handler() calls and to refactor all > > aio_set_fd_handler() callers

Re: [PATCH] vl: Print display options for -display help

2023-12-14 Thread Marc-André Lureau
Hi On Thu, Dec 14, 2023 at 1:29 PM Philippe Mathieu-Daudé wrote: > > Hi Akihiko, > > On 14/12/23 07:47, Akihiko Odaki wrote: > > -display lists display backends, but does not tell their options. > > Use the help messages from qemu-options.def, which include the list of > > options. > > > > Signed

Re: [PATCH] target/i386: Fix CPUID encoding of Fn8000001E_ECX

2023-12-14 Thread Moger, Babu
Hi Zhao, On 12/14/2023 8:08 AM, Zhao Liu wrote: On Fri, Nov 10, 2023 at 11:08:06AM -0600, Babu Moger wrote: Date: Fri, 10 Nov 2023 11:08:06 -0600 From: Babu Moger Subject: [PATCH] target/i386: Fix CPUID encoding of Fn801E_ECX X-Mailer: git-send-email 2.34.1 Observed the following failure

Re: [PATCH v2 19/23] exec/user: Do not include 'cpu.h' in 'abitypes.h'

2023-12-14 Thread Thomas Huth
On 12/12/2023 13.33, Philippe Mathieu-Daudé wrote: "exec/user/abitypes.h" requires: - "exec/cpu-defs.h" (TARGET_LONG_BITS) - "exec/tswap.h" (tswap32) In order to avoid "cpu.h", pick the minimum required headers. Assert this user-specific header is only included from

Re: [PATCH v2 17/23] target/ppc/excp_helper: Avoid 'abi_ptr' in system emulation

2023-12-14 Thread Thomas Huth
On 12/12/2023 13.33, Philippe Mathieu-Daudé wrote: 'abi_ptr' is a user specific type. The system emulation equivalent is 'target_ulong'. Use it in ppc_ldl_code() to emphasis this is not an user emulation function. Signed-off-by: Philippe Mathieu-Daudé --- target/ppc/excp_helper.c | 2 +- 1 f

[PATCH v2] spapr: Tag pseries-2.1 - 2.11 machines as deprecated

2023-12-14 Thread Cédric Le Goater
pseries machines before version 2.11 have undergone many changes to correct issues, mostly regarding migration compatibility. This is obfuscating the code uselessly and makes maintenance more difficult. Remove them and only keep the last version of the 2.x series, 2.12, still in use by old distros.

Re: [PATCH] spapr: Tag pseries-2.1 - 2.11 machines as deprecated

2023-12-14 Thread Cédric Le Goater
On 12/14/23 18:58, Thomas Huth wrote: On 14/12/2023 18.43, Cédric Le Goater wrote: pseries machines before version 2.11 have undergone many changes to correct issues, mostly regarding migration compatibility. This is obfuscating the code uselessly and makes maintenance more difficult. Remove the

Re: [PATCH v4] arm/kvm: Enable support for KVM_ARM_VCPU_PMU_V3_FILTER

2023-12-14 Thread Eric Auger
Hi Shaoqin, On 12/7/23 11:36, Shaoqin Huang wrote: > The KVM_ARM_VCPU_PMU_V3_FILTER provide the ability to let the VMM decide > which PMU events are provided to the guest. Add a new option > `pmu-filter` as -accel sub-option to set the PMU Event Filtering. > Without the filter, the KVM will expose

Re: [PATCH] spapr: Tag pseries-2.1 - 2.11 machines as deprecated

2023-12-14 Thread Thomas Huth
On 14/12/2023 18.43, Cédric Le Goater wrote: pseries machines before version 2.11 have undergone many changes to correct issues, mostly regarding migration compatibility. This is obfuscating the code uselessly and makes maintenance more difficult. Remove them and only keep the last version of the

Re: [PATCH 1/4] hw/ppc/spapr_hcall: Remove unused 'exec/exec-all.h' included header

2023-12-14 Thread Richard Henderson
On 12/12/23 03:36, Philippe Mathieu-Daudé wrote: Signed-off-by: Philippe Mathieu-Daudé --- hw/ppc/spapr_hcall.c | 1 - 1 file changed, 1 deletion(-) Reviewed-by: Richard Henderson r~

[PATCH] spapr: Tag pseries-2.1 - 2.11 machines as deprecated

2023-12-14 Thread Cédric Le Goater
pseries machines before version 2.11 have undergone many changes to correct issues, mostly regarding migration compatibility. This is obfuscating the code uselessly and makes maintenance more difficult. Remove them and only keep the last version of the 2.x series, 2.12, still in use by old distros.

Re: [RFC PATCH] hw/arm: Prefer arm_feature() over object_property_find()

2023-12-14 Thread Peter Maydell
On Thu, 14 Dec 2023 at 17:14, Philippe Mathieu-Daudé wrote: > > QOM properties are added on the ARM vCPU object when a > feature is present. Rather than checking the property > is present, check the feature. > > Suggested-by: Markus Armbruster > Signed-off-by: Philippe Mathieu-Daudé > --- > RFC:

Re: [PATCH v3] fsl-imx: add simple RTC emulation for i.MX6 and i.MX7 boards

2023-12-14 Thread Peter Maydell
On Thu, 14 Dec 2023 at 11:49, Nikita Ostrenkov wrote: > > Signed-off-by: Nikita Ostrenkov > --- > hw/misc/imx7_snvs.c | 91 ++--- > hw/misc/trace-events| 4 +- > include/hw/misc/imx7_snvs.h | 7 ++- > 3 files changed, 92 insertions(+), 10 deletio

[RFC PATCH] hw/arm: Prefer arm_feature() over object_property_find()

2023-12-14 Thread Philippe Mathieu-Daudé
QOM properties are added on the ARM vCPU object when a feature is present. Rather than checking the property is present, check the feature. Suggested-by: Markus Armbruster Signed-off-by: Philippe Mathieu-Daudé --- RFC: If there is no objection on this patch, I can split as a per-feature ser

Re: [PATCH v2] Optimize buffer_is_zero

2023-12-14 Thread Alexander Monakov
Ping^2. On Thu, 9 Nov 2023, Alexander Monakov wrote: > I'd like to ping this patch on behalf of Mikhail. > > https://patchew.org/QEMU/20231027143704.7060-1-mmroma...@ispras.ru/ > > If this needs to be split up a bit to ease review, please let us know. > > On Fri, 27 Oct 2023, Mikhail Romanov

Re: [PATCH 4/4] target: Restrict 'sysemu/reset.h' to system emulation

2023-12-14 Thread Thomas Huth
On 12/12/2023 12.36, Philippe Mathieu-Daudé wrote: vCPU "reset" is only possible with system emulation. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Warner Losh Reviewed-by: Song Gao --- target/i386/cpu.c | 2 +- target/loongarch/cpu.c | 2 ++ 2 files changed, 3 insertions(+),

Re: [PATCH 2/4] hw/misc/mips_itu: Remove unnecessary 'exec/exec-all.h' header

2023-12-14 Thread Thomas Huth
On 12/12/2023 12.36, Philippe Mathieu-Daudé wrote: mips_itu.c only requires declarations from "hw/core/cpu.h" and "cpu.h". Avoid including the huge "exec/exec-all.h" header. Signed-off-by: Philippe Mathieu-Daudé --- hw/misc/mips_itu.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)

Re: [PATCH 1/4] hw/ppc/spapr_hcall: Remove unused 'exec/exec-all.h' included header

2023-12-14 Thread Thomas Huth
On 12/12/2023 12.36, Philippe Mathieu-Daudé wrote: Signed-off-by: Philippe Mathieu-Daudé --- hw/ppc/spapr_hcall.c | 1 - 1 file changed, 1 deletion(-) diff --git a/hw/ppc/spapr_hcall.c b/hw/ppc/spapr_hcall.c index 522a2396c7..fcefd1d1c7 100644 --- a/hw/ppc/spapr_hcall.c +++ b/hw/ppc/spapr_hc

Re: [PATCH] hw/net/can/sja1000: fix bug for single acceptance filer and standard frame

2023-12-14 Thread Philippe Mathieu-Daudé
On 14/12/23 11:46, Pavel Pisa wrote: From: Pavel Pisa A CAN sja1000 standard frame filter mask has been computed and applied incorrectly for standard frames when single Acceptance Filter Mode (MOD_AFM = 1) has been selected. The problem has not been found by Linux kernel testing because it uses

Re: [PATCH 3/4] hw/s390x/ipl: Remove unused 'exec/exec-all.h' included header

2023-12-14 Thread Eric Farman
On Tue, 2023-12-12 at 12:36 +0100, Philippe Mathieu-Daudé wrote: > Signed-off-by: Philippe Mathieu-Daudé > --- >  hw/s390x/ipl.c | 1 - >  1 file changed, 1 deletion(-) > > Yup, this appears no longer relevant since commit 3549118b4988 Reviewed-by: Eric Farman

Re: [risu PATCH v2 0/6] Add LoongArch LSX/LASX instructions

2023-12-14 Thread Peter Maydell
On Wed, 13 Dec 2023 at 08:31, Song Gao wrote: > > Hi, Peter! > > This series adds LSX/LASX instructions. > > We tested 10 million instructions with no problems. > > client: > QEMU master + patch [1] > > server: > 3A5000 host. > > [1]: > https://patchew.org/QEMU/20220917075950.1412309-1-gaos...@lo

Re: [PATCH 1/1] vhost-scsi: fix usage of error_reportf_err()

2023-12-14 Thread Raphael Norwitz
> On Dec 13, 2023, at 7:31 PM, Dongli Zhang wrote: > > It is required to use error_report() instead of error_reportf_err(), if the > prior function does not take local_err as the argument. As a result, the > local_err is always NULL and segment fault may happen. > > vhost_scsi_start() > -> vhost

[PATCH v7 4/4] scripts: add script to compare compatibility properties

2023-12-14 Thread Maksim Davydov
This script runs QEMU to obtain compat_props of machines and default values of different types of drivers to produce comparison table. This table can be used to compare machine types to choose the most suitable machine or compare binaries to be sure that migration to the newer version will save all

[PATCH v7 0/4] compare machine type compat_props

2023-12-14 Thread Maksim Davydov
This script can be used to choose the best machine type in the appropriate cases. Also we have to check compat_props of the old MT after changes to be sure that they haven't broken old the MT. For example, pc_compat_3_1 of pc-q35-3.1 has Icelake-Client which was removed. v7 -> v6: * minor fixes v

[PATCH v7 1/4] qom: qom-list-properties: add default value

2023-12-14 Thread Maksim Davydov
qmp_qom_list_properties can print default values if they are available as qmp_device_list_properties does, because both of them use the ObjectPropertyInfo structure with default_value field. This can be useful when working with "not device" types (e.g. memory-backend). Signed-off-by: Maksim Davydo

[PATCH v7 3/4] python/qemu/machine: add method to retrieve QEMUMachine::binary field

2023-12-14 Thread Maksim Davydov
Add a supportive property to access the path to the QEMU binary Signed-off-by: Maksim Davydov Reviewed-by: John Snow Reviewed-by: Philippe Mathieu-Daud?? --- python/qemu/machine/machine.py | 5 + 1 file changed, 5 insertions(+) diff --git a/python/qemu/machine/machine.py b/python/qemu/mac

[PATCH v7 2/4] qmp: add dump machine type compatibility properties

2023-12-14 Thread Maksim Davydov
To control that creating new machine type doesn't affect the previous types (their compat_props) and to check complex compat_props inheritance we need qmp command to print machine type compatibility properties. This patch adds the ability to get list of all the compat_props of the corresponding sup

Re: [PULL 02/13] target/arm: Handle overflow in calculation of next timer tick

2023-12-14 Thread Peter Maydell
On Thu, 14 Dec 2023 at 08:20, Michael Tokarev wrote: > > 27.11.2023 20:08, Peter Maydell: > > In commit edac4d8a168 back in 2015 when we added support for > > the virtual timer offset CNTVOFF_EL2, we didn't correctly update > > the timer-recalculation code that figures out when the timer > > inter

Re: [PATCH-for-9.0 00/16] target/arm/kvm: Unify kvm_arm_FOO() API

2023-12-14 Thread Peter Maydell
On Wed, 13 Dec 2023 at 09:42, Philippe Mathieu-Daudé wrote: > > On 11/12/23 15:36, Peter Maydell wrote: > > On Thu, 23 Nov 2023 at 18:35, Philippe Mathieu-Daudé > > wrote: > >> > >> Half of the API takes CPUState, the other ARMCPU... > >> > >> $ git grep -F 'CPUState *' target/arm/kvm_arm.h | wc

[PATCH qemu v3 2/2] hw/arm: Add minimal support for the B-L475E-IOT01A board

2023-12-14 Thread ~inesvarhol
From: Inès Varhol This commit adds a new B-L475E-IOT01A board using the STM32L475VG SoC. The implementation is derived from the Netduino Plus 2 machine. There are no peripherals implemented yet, only memory regions. Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Arnaud Minier Signed-off-b

[PATCH qemu v3 0/2] Add minimal support for the B-L475E-IOT01A board

2023-12-14 Thread ~inesvarhol
This patch adds a new STM32L4x5 SoC, it is necessary to add support for the B-L475E-IOT01A board. The implementation is derived from the STM32F405 SoC and NetduinoPlus2 board. The implementation contains no peripherals, only memory regions are implemented. Sorry about the inconsistency in licenses

[PATCH qemu v3 1/2] hw/arm: Add minimal support for the STM32L4x5 SoC

2023-12-14 Thread ~inesvarhol
From: Inès Varhol This patch adds a new STM32L4x5 SoC, it is necessary to add support for the B-L475E-IOT01A board. The implementation is derived from the STM32F405 SoC. The implementation contains no peripherals, only memory regions are implemented. Reviewed-by: Philippe Mathieu-Daudé Signed-

[RFC PATCH] tests/avocado: avoid a copy to support read/write rootfs

2023-12-14 Thread Alex Bennée
While the test causes the rootfs to be updated we don't actually need to persist anything between runs. Avoid the copy by enabling "snapshot=on" for the drive instead. Signed-off-by: Alex Bennée --- tests/avocado/kvm_xen_guest.py | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff -

Re: [PATCH] target/i386: Fix CPUID encoding of Fn8000001E_ECX

2023-12-14 Thread Zhao Liu
On Fri, Nov 10, 2023 at 11:08:06AM -0600, Babu Moger wrote: > Date: Fri, 10 Nov 2023 11:08:06 -0600 > From: Babu Moger > Subject: [PATCH] target/i386: Fix CPUID encoding of Fn801E_ECX > X-Mailer: git-send-email 2.34.1 > > Observed the following failure while booting the SEV-SNP guest and the

Re: [RFC 0/3] aio-posix: call ->poll_end() when removing AioHandler

2023-12-14 Thread Fiona Ebner
Am 13.12.23 um 22:15 schrieb Stefan Hajnoczi: > But there you have it. Please let me know what you think and try your > reproducers to see if this fixes the missing io_poll_end() issue. Thanks! > Thanks to you! I applied the RFC (and the series it depends on) on top of 8.2.0-rc4 and this fixes my

Re: [PATCH 03/10] tests/avocado/intel_iommu.py: increase timeout

2023-12-14 Thread Eric Auger
On 12/14/23 10:41, Alex Bennée wrote: > Eric Auger writes: > >> Hi Cleber, >> >> On 12/13/23 21:08, Cleber Rosa wrote: >>> Alex Bennée writes: >>> Cleber Rosa writes: > Based on many runs, the average run time for these 4 tests is around > 250 seconds, with 320 seconds being

Re: [PATCH] vl: Print display options for -display help

2023-12-14 Thread BALATON Zoltan
On Thu, 14 Dec 2023, Philippe Mathieu-Daudé wrote: Hi Akihiko, On 14/12/23 07:47, Akihiko Odaki wrote: -display lists display backends, but does not tell their options. Use the help messages from qemu-options.def, which include the list of options. Signed-off-by: Akihiko Odaki --- include/u

Re: [PATCH v7 00/11] Implementation of NPI Mailbox and GMAC Networking Module

2023-12-14 Thread Peter Maydell
On Thu, 14 Dec 2023 at 11:43, Peter Maydell wrote: > > On Mon, 11 Dec 2023 at 17:52, Nabih Estefan wrote: > > > > From: Nabih Estefan Diaz > > > > [Changes since v6] > > Remove the Change-Ids from the commit messages. > > > > This doesn't compile: > > ../../hw/net/npcm_gmac.c:889:43: error: too

[PATCH v3] fsl-imx: add simple RTC emulation for i.MX6 and i.MX7 boards

2023-12-14 Thread Nikita Ostrenkov
Signed-off-by: Nikita Ostrenkov --- hw/misc/imx7_snvs.c | 91 ++--- hw/misc/trace-events| 4 +- include/hw/misc/imx7_snvs.h | 7 ++- 3 files changed, 92 insertions(+), 10 deletions(-) diff --git a/hw/misc/imx7_snvs.c b/hw/misc/imx7_snvs.c index a

Re: [PATCH v7 00/11] Implementation of NPI Mailbox and GMAC Networking Module

2023-12-14 Thread Peter Maydell
On Mon, 11 Dec 2023 at 17:52, Nabih Estefan wrote: > > From: Nabih Estefan Diaz > > [Changes since v6] > Remove the Change-Ids from the commit messages. > This doesn't compile: ../../hw/net/npcm_gmac.c:889:43: error: too few arguments to function call, expected 6, have 5

Re: [PATCH 1/1] target/riscv: Clear vstart_qe_zero flag

2023-12-14 Thread Daniel Henrique Barboza
On 12/14/23 08:18, Ivan Klokov wrote: The vstart_qe_zero flag is set at the beginning of the translation phase from the env->vstart variable. During the execution phase, some instructions may change env->vstart, but the flag remains the same as at the start of the block. With some combinations

Re: [PATCH qemu v2 2/2] hw/arm: Add minimal support for the B-L475E-IOT01A board

2023-12-14 Thread Peter Maydell
On Thu, 7 Dec 2023 at 21:57, ~inesvarhol wrote: > > From: Inès Varhol > > This commit adds a new B-L475E-IOT01A board using the STM32L475VG SoC. > The implementation is derived from the Netduino Plus 2 machine. > There are no peripherals implemented yet, only memory regions. > > Reviewed-by: Phil

[PATCH 1/1] target/riscv: Clear vstart_qe_zero flag

2023-12-14 Thread Ivan Klokov
The vstart_qe_zero flag is set at the beginning of the translation phase from the env->vstart variable. During the execution phase, some instructions may change env->vstart, but the flag remains the same as at the start of the block. With some combinations of instructions this causes an illegal ins

Re: [PATCH] target/arm: Restrict ARM_FEATURE_PMU to system emulation

2023-12-14 Thread Peter Maydell
On Thu, 7 Dec 2023 at 13:19, Philippe Mathieu-Daudé wrote: > > On 7/12/23 12:10, Philippe Mathieu-Daudé wrote: > > ARM Performance Monitor Unit is not reachable from user > > emulation, restrict it to system emulation. > > > > Signed-off-by: Philippe Mathieu-Daudé What's the aim of this patch? I

[PATCH] hw/net/can/sja1000: fix bug for single acceptance filer and standard frame

2023-12-14 Thread Pavel Pisa
From: Pavel Pisa A CAN sja1000 standard frame filter mask has been computed and applied incorrectly for standard frames when single Acceptance Filter Mode (MOD_AFM = 1) has been selected. The problem has not been found by Linux kernel testing because it uses dual filter mode (MOD_AFM = 0) and lea

RE: [PATCH] accel/tcg: Expose translation block flags to plugins

2023-12-14 Thread Mikhail Tyutin
Hi Alex, > > Exposing appropriate translation block flag allows plugins to > > handle "memory only" blocks in appropriate way. > > We don't want to expose internal details to the plugin. It shouldn't > need to care. > > Do you have a test case where you missed counting the execution of the > ins

Re: [PATCH 04/10] tests/avocado: machine aarch64: standardize location and RO/RW access

2023-12-14 Thread Alex Bennée
Cleber Rosa writes: > Alex Bennée writes: > >> Cleber Rosa writes: >> >>> The tests under machine_aarch64_virt.py do not need read-write access >>> to the ISOs. The ones under machine_aarch64_sbsaref.py, on the other >>> hand, will need read-write access, so let's give each test an unique >>>

Re: [PATCH 04/10] tests/avocado: machine aarch64: standardize location and RO/RW access

2023-12-14 Thread Alex Bennée
Cleber Rosa writes: > Marcin Juszkiewicz writes: > >> W dniu 8.12.2023 o 20:09, Cleber Rosa pisze: >>> The tests under machine_aarch64_virt.py do not need read-write access >>> to the ISOs. The ones under machine_aarch64_sbsaref.py, on the other >>> hand, will need read-write access, so let's g

Re: [PATCH v7 5/5] ebpf: Updated eBPF program and skeleton.

2023-12-14 Thread Yuri Benditovich
Hi Jason, As we anyway missed the timeframe of 8.2 please remove this v7 series from the pull, we will send v8 in which we want to take in account most of Akihiko comments (especially DEFINE_PROP_ARRAY and naming of the properties). Thank you very much Yuri On Wed, Dec 13, 2023 at 9:23 AM Yuri B

Re: [PATCH] qemu-options: Clarify handling of commas in options parameters

2023-12-14 Thread Thomas Huth
On 13/12/2023 15.17, Yihuan Pan wrote: Provide explicit guidance on dealing with option parameters as arbitrary strings containing commas, such as in "file=my,file" and "string=a,b". The updated documentation emphasizes the need to double commas when they appear within such parameters. Resolves:

Re: [PATCH 1/2] qemu-options: Unify the help entries for cocoa

2023-12-14 Thread Philippe Mathieu-Daudé
On 14/12/23 07:31, Akihiko Odaki wrote: Apparently the help entries were not merged when the patches got in. Fixes: f844cdb99714 ("ui/cocoa: capture all keys and combos when mouse is grabbed") Signed-off-by: Akihiko Odaki --- qemu-options.hx | 4 +--- 1 file changed, 1 insertion(+), 3 delet

  1   2   >