Re: [PATCH] linux-user: Make TARGET_NR_setgroups affect only the current thread

2024-01-30 Thread Helge Deller
On 1/31/24 01:18, Ilya Leoshkevich wrote: Like TARGET_NR_setuid, TARGET_NR_setgroups should affect only the calling thread, and not the entire process. Therefore, implement it using a syscall, and not a libc call. Cc: qemu-sta...@nongnu.org Fixes: 19b84f3c35d7 ("added setgroups and getgroups

Re: [PATCH v2 02/14] plugins: scoreboard API

2024-01-30 Thread Pierrick Bouvier
On 1/26/24 19:14, Alex Bennée wrote: +need_realloc = TRUE; +} +plugin.scoreboard_size = cpu->cpu_index + 1; +g_assert(plugin.scoreboard_size <= plugin.scoreboard_alloc_size); + +if (g_hash_table_size(plugin.scoreboards) == 0) { +/* nothing to do, we just updated

[PATCH] tcg: Fixes set const_args[i] wrong value when instructions imm is 0

2024-01-30 Thread Song Gao
It seems that tcg_reg_alloc_op() set const_args[i] wrong value when instructions imm is 0. The LoongArch tcg_out_vec_op() cmp_vec use the wrong const_args[2]. e.g The wrong const_args[2] is 0. IN: vslti.w v5, v4, 0x0 OUT: vslt.w v1, v1, v0 The right const_args[2] is 1. IN: vslti.w

Re: [PATCH 1/5] migration/multifd: Separate compression ops from non-compression

2024-01-30 Thread Peter Xu
On Tue, Jan 30, 2024 at 12:11:47PM -0300, Fabiano Rosas wrote: > Peter Xu writes: > > > On Mon, Jan 29, 2024 at 09:42:24AM -0300, Fabiano Rosas wrote: > >> Peter Xu writes: > >> > >> > On Fri, Jan 26, 2024 at 07:19:39PM -0300, Fabiano Rosas wrote: > >> >> +static MultiFDMethods

Re: [PATCH 2/3] ui/gtk: set the ui size to 0 when invisible

2024-01-30 Thread Marc-André Lureau
Hi On Wed, Jan 31, 2024 at 3:50 AM wrote: > > From: Dongwon Kim > > UI size is set to 0 when the VC is invisible, which will prevent > the further scanout update by notifying the guest that the display > is not in active state. Then it is restored to the original size > whenever the VC becomes

Re: [PATCH 1/3] ui/gtk: skip drawing guest scanout when associated VC is invisible

2024-01-30 Thread Marc-André Lureau
Hi Dongwon On Wed, Jan 31, 2024 at 3:50 AM wrote: > > From: Dongwon Kim > > A new flag "visible" is added to show visibility status of the gfx console. > The flag is set to 'true' when the VC is visible but set to 'false' when > it is hidden or closed. When the VC is invisible, drawing guest

Re: [PATCH v4 28/47] hw/arm/npcm7xx: use qemu_configure_nic_device, allow emc0/emc1 as aliases

2024-01-30 Thread Thomas Huth
On 26/01/2024 18.25, David Woodhouse wrote: From: David Woodhouse Also update the test to specify which device to attach the test socket to, and remove the comment lamenting the fact that we can't do so. Signed-off-by: David Woodhouse --- hw/arm/npcm7xx.c | 16

Re: [PATCH v4 26/47] hw/net/lan9118: use qemu_configure_nic_device()

2024-01-30 Thread Thomas Huth
On 26/01/2024 18.25, David Woodhouse wrote: From: David Woodhouse Some callers instantiate the device unconditionally, others will do so only if there is a NICInfo to go with it. This appears to be fairly random, but preseve the existing behaviour for now. Signed-off-by: David Woodhouse ---

Re: [PATCH v2] pc: q35: Bump max_cpus to 1856 vcpus

2024-01-30 Thread Zhao Liu
On Wed, Jan 31, 2024 at 10:47:29AM +0530, Ani Sinha wrote: > Date: Wed, 31 Jan 2024 10:47:29 +0530 > From: Ani Sinha > Subject: Re: [PATCH v2] pc: q35: Bump max_cpus to 1856 vcpus > > On Wed, Jan 31, 2024 at 9:27 AM Zhao Liu wrote: > > > > Hi Ani, > > > > On Wed, Jan 31, 2024 at 08:19:06AM

Re: [PATCH 2/2] target/riscv: Support xtheadmaee for thead-c906

2024-01-30 Thread LIU Zhiwei
On 2024/1/31 13:07, Richard Henderson wrote: On 1/30/24 21:11, LIU Zhiwei wrote: +riscv_csr_operations th_csr_ops[CSR_TABLE_SIZE] = { +#if !defined(CONFIG_USER_ONLY) +    [CSR_TH_MXSTATUS] = { "th_mxstatus", th_maee_check, read_th_mxstatus, + write_th_mxstatus}, +#endif /*

Re: [PATCH v3 02/29] hw/core: Declare CPUArchId::cpu as CPUState instead of Object

2024-01-30 Thread Thomas Huth
On 29/01/2024 17.44, Philippe Mathieu-Daudé wrote: Do not accept any Object for CPUArchId::cpu field, restrict it to CPUState type. Signed-off-by: Philippe Mathieu-Daudé --- include/hw/boards.h| 2 +- hw/core/machine.c | 4 ++-- hw/i386/x86.c | 2 +-

Re: [PATCH 1/2] target/riscv: Register vendors CSR

2024-01-30 Thread LIU Zhiwei
On 2024/1/31 13:06, Richard Henderson wrote: On 1/30/24 21:11, LIU Zhiwei wrote: +/* This stub just works for making vendors array not empty */ +riscv_csr_operations stub_csr_ops[CSR_TABLE_SIZE]; +static inline bool never_p(const RISCVCPUConfig *cfg) +{ +    return false; +} + +void

Re: [PATCH v4 8/8] Add tests for the STM32L4x5_RCC

2024-01-30 Thread Thomas Huth
On 30/01/2024 17.13, Arnaud Minier wrote: Tests: - the ability to change the sysclk of the device - the ability to enable/disable/configure the PLLs - if the clock multiplexers work - the register flags and the generation of irqs Signed-off-by: Arnaud Minier Signed-off-by: Inès Varhol ---

Re: [PATCH v2] pc: q35: Bump max_cpus to 1856 vcpus

2024-01-30 Thread Ani Sinha
On Wed, Jan 31, 2024 at 9:27 AM Zhao Liu wrote: > > Hi Ani, > > On Wed, Jan 31, 2024 at 08:19:06AM +0530, Ani Sinha wrote: > > Date: Wed, 31 Jan 2024 08:19:06 +0530 > > From: Ani Sinha > > Subject: [PATCH v2] pc: q35: Bump max_cpus to 1856 vcpus > > X-Mailer: git-send-email 2.42.0 > > > > Since

Re: [PATCH 2/2] target/riscv: Support xtheadmaee for thead-c906

2024-01-30 Thread Richard Henderson
On 1/30/24 21:11, LIU Zhiwei wrote: +riscv_csr_operations th_csr_ops[CSR_TABLE_SIZE] = { +#if !defined(CONFIG_USER_ONLY) +[CSR_TH_MXSTATUS] = { "th_mxstatus", th_maee_check, read_th_mxstatus, +write_th_mxstatus}, +#endif /*

Re: [PATCH 1/2] target/riscv: Register vendors CSR

2024-01-30 Thread Richard Henderson
On 1/30/24 21:11, LIU Zhiwei wrote: +/* This stub just works for making vendors array not empty */ +riscv_csr_operations stub_csr_ops[CSR_TABLE_SIZE]; +static inline bool never_p(const RISCVCPUConfig *cfg) +{ +return false; +} + +void riscv_tcg_cpu_register_vendor_csr(RISCVCPU *cpu) +{ +

Re: [PATCH 05/17] migration/multifd: Wait for multifd channels creation before proceeding

2024-01-30 Thread Peter Xu
On Tue, Jan 30, 2024 at 06:32:21PM -0300, Fabiano Rosas wrote: > Avihai Horon writes: > > > On 29/01/2024 16:34, Fabiano Rosas wrote: > >> External email: Use caution opening links or attachments > >> > >> > >> Avihai Horon writes: > >> > >>> Currently, multifd channels are created

Re: [PULL 06/15] tests/qtest/migration: Don't use -cpu max for aarch64

2024-01-30 Thread Peter Xu
On Tue, Jan 30, 2024 at 06:23:10PM -0300, Fabiano Rosas wrote: > Peter Xu writes: > > > On Tue, Jan 30, 2024 at 10:18:07AM +, Peter Maydell wrote: > >> On Mon, 29 Jan 2024 at 23:31, Fabiano Rosas wrote: > >> > > >> > Fabiano Rosas writes: > >> > > >> > > Peter Xu writes: > >> > > > >> >

Re: [PATCH v2] pc: q35: Bump max_cpus to 1856 vcpus

2024-01-30 Thread Zhao Liu
Hi Ani, On Wed, Jan 31, 2024 at 08:19:06AM +0530, Ani Sinha wrote: > Date: Wed, 31 Jan 2024 08:19:06 +0530 > From: Ani Sinha > Subject: [PATCH v2] pc: q35: Bump max_cpus to 1856 vcpus > X-Mailer: git-send-email 2.42.0 > > Since commit f10a570b093e6 ("KVM: x86: Add CONFIG_KVM_MAX_NR_VCPUS to

Re: [PATCH 5/5] hw/core: Remove transitional infrastructure from BusClass

2024-01-30 Thread Zhao Liu
On Fri, Jan 19, 2024 at 04:35:12PM +, Peter Maydell wrote: > Date: Fri, 19 Jan 2024 16:35:12 + > From: Peter Maydell > Subject: [PATCH 5/5] hw/core: Remove transitional infrastructure from > BusClass > X-Mailer: git-send-email 2.34.1 > > BusClass currently has transitional

Re: [PATCH 4/5] hw/s390x/css-bridge: switch virtual-css bus to 3-phase-reset

2024-01-30 Thread Zhao Liu
On Fri, Jan 19, 2024 at 04:35:11PM +, Peter Maydell wrote: > Date: Fri, 19 Jan 2024 16:35:11 + > From: Peter Maydell > Subject: [PATCH 4/5] hw/s390x/css-bridge: switch virtual-css bus to > 3-phase-reset > X-Mailer: git-send-email 2.34.1 > > Switch the s390x virtual-css bus from using

Re: [PATCH 2/5] vmbus: Switch bus reset to 3-phase-reset

2024-01-30 Thread Zhao Liu
On Fri, Jan 19, 2024 at 04:35:09PM +, Peter Maydell wrote: > Date: Fri, 19 Jan 2024 16:35:09 + > From: Peter Maydell > Subject: [PATCH 2/5] vmbus: Switch bus reset to 3-phase-reset > X-Mailer: git-send-email 2.34.1 > > Switch vmbus from using BusClass::reset to the Resettable interface.

Re: [PATCH 3/5] adb: Switch bus reset to 3-phase-reset

2024-01-30 Thread Zhao Liu
On Fri, Jan 19, 2024 at 04:35:10PM +, Peter Maydell wrote: > Date: Fri, 19 Jan 2024 16:35:10 + > From: Peter Maydell > Subject: [PATCH 3/5] adb: Switch bus reset to 3-phase-reset > X-Mailer: git-send-email 2.34.1 > > Switch the ADB bus from using BusClass::reset to the Resettable >

Re: [PATCH 1/5] pci: Switch bus reset to 3-phase-reset

2024-01-30 Thread Zhao Liu
On Fri, Jan 19, 2024 at 04:35:08PM +, Peter Maydell wrote: > Date: Fri, 19 Jan 2024 16:35:08 + > From: Peter Maydell > Subject: [PATCH 1/5] pci: Switch bus reset to 3-phase-reset > X-Mailer: git-send-email 2.34.1 > > Switch the PCI bus from using BusClass::reset to the Resettable >

Re: [libvirt PATCH V2 0/4] add loongarch support for libvirt

2024-01-30 Thread lixianglai
Hi Philippe:     When developing libvirt on loongarch, we encountered some problems related to pflash. libvirt and qemu met some difficulties in the coordination of UEFI loading. I think we need your suggestions and opinions on the solution. Anyway, I fetched and installed this. The

Re: [PATCH v15 0/9] rutabaga_gfx + gfxstream

2024-01-30 Thread Gurchetan Singh
On Fri, Jan 26, 2024 at 6:23 AM Alyssa Ross wrote: > Gurchetan Singh writes: > > > On Sat, Jan 20, 2024 at 4:19 AM Alyssa Ross wrote: > > > >> Gurchetan Singh writes: > >> > >> > On Fri, Jan 19, 2024 at 1:13 PM Alyssa Ross wrote: > >> >> > >> >> Hi Gurchetan, > >> >> > >> >> > Thanks for the

Re: [PATCH v3 3/3] virtio-gpu-rutabaga.c: override resource_destroy method

2024-01-30 Thread Gurchetan Singh
On Tue, Jan 30, 2024 at 7:00 AM Manos Pitsidianakis < manos.pitsidiana...@linaro.org> wrote: > When the Rutabaga GPU device frees resources, it calls > rutabaga_resource_unref for that resource_id. However, when the generic > VirtIOGPU functions destroys resources, it only removes the >

Re: [PATCH] migration/docs: Explain two solutions for VMSD compatibility

2024-01-30 Thread Peter Xu
On Tue, Jan 30, 2024 at 10:58:24AM -0300, Fabiano Rosas wrote: > Peter Xu writes: > > > On Mon, Jan 29, 2024 at 10:44:46AM -0300, Fabiano Rosas wrote: > >> > Since we're at it, I would also like to know how you think about whether > >> > we > >> > should still suggest people using VMSD

[PATCH v2] pc: q35: Bump max_cpus to 1856 vcpus

2024-01-30 Thread Ani Sinha
Since commit f10a570b093e6 ("KVM: x86: Add CONFIG_KVM_MAX_NR_VCPUS to allow up to 4096 vCPUs") Linux kernel can support upto a maximum number of 4096 vCPUS when MAXSMP is enabled in the kernel. At present, QEMU has been tested to correctly boot a linux guest with 1856 vcpus and no more both with

RE: [PATCH v3 0/4] Live Migration Acceleration with IAA Compression

2024-01-30 Thread Liu, Yuan1
> -Original Message- > From: Peter Xu > Sent: Tuesday, January 30, 2024 6:32 PM > To: Liu, Yuan1 > Cc: faro...@suse.de; leob...@redhat.com; qemu-devel@nongnu.org; Zou, > Nanhai > Subject: Re: [PATCH v3 0/4] Live Migration Acceleration with IAA > Compression > > On Tue, Jan 30, 2024 at

Re: Call for GSoC/Outreachy internship project ideas

2024-01-30 Thread Palmer Dabbelt
On Tue, 30 Jan 2024 17:26:11 PST (-0800), alistai...@gmail.com wrote: On Wed, Jan 31, 2024 at 10:30 AM Palmer Dabbelt wrote: On Tue, 30 Jan 2024 12:28:27 PST (-0800), stefa...@gmail.com wrote: > On Tue, 30 Jan 2024 at 14:40, Palmer Dabbelt wrote: >> >> On Mon, 15 Jan 2024 08:32:59 PST

Re: [PATCH v1 1/1] migration: prevent migration when VM has poisoned memory

2024-01-30 Thread Peter Xu
On Tue, Jan 30, 2024 at 07:06:40PM +, “William Roche wrote: > From: William Roche > > A memory page poisoned from the hypervisor level is no longer readable. > The migration of a VM will crash Qemu when it tries to read the > memory address space and stumbles on the poisoned page with a

Re: Call for GSoC/Outreachy internship project ideas

2024-01-30 Thread Alistair Francis
On Wed, Jan 31, 2024 at 10:30 AM Palmer Dabbelt wrote: > > On Tue, 30 Jan 2024 12:28:27 PST (-0800), stefa...@gmail.com wrote: > > On Tue, 30 Jan 2024 at 14:40, Palmer Dabbelt wrote: > >> > >> On Mon, 15 Jan 2024 08:32:59 PST (-0800), stefa...@gmail.com wrote: > >> > Dear QEMU and KVM

[PATCH] linux-user/aarch64: Extend PR_SET_TAGGED_ADDR_CTRL for FEAT_MTE3

2024-01-30 Thread Richard Henderson
When MTE3 is supported, the kernel maps PR_MTE_TCF_ASYNC | PR_MTE_TCF_SYNC to MTE_CTRL_TCF_ASYMM and from there to SCTLR_EL1.TCF0 = 3 There is no error reported for setting ASYNC | SYNC when MTE3 is not supported; the kernel simply selects the ASYNC behavior of TCG0=2. Signed-off-by:

Re: Call for GSoC/Outreachy internship project ideas

2024-01-30 Thread Palmer Dabbelt
On Tue, 30 Jan 2024 12:28:27 PST (-0800), stefa...@gmail.com wrote: On Tue, 30 Jan 2024 at 14:40, Palmer Dabbelt wrote: On Mon, 15 Jan 2024 08:32:59 PST (-0800), stefa...@gmail.com wrote: > Dear QEMU and KVM communities, > QEMU will apply for the Google Summer of Code and Outreachy internship

[PATCH v16 1/6] hw/net: Add NPCMXXX GMAC device

2024-01-30 Thread Nabih Estefan
From: Hao Wu This patch implements the basic registers of GMAC device and sets registers for networking functionalities. Squashed IRQ Implementation patch into this one for compliation. Tested: The following message shows up with the change: Broadcom BCM54612E stmmac-0:00: attached PHY driver

[PATCH v16 0/6] Implementation of GMAC Networking Module

2024-01-30 Thread Nabih Estefan
From: Nabih Estefan Diaz [Changes since v15] Dropped PCI MBox patches. They were presenting a lot of problems with endianness and are not directly related to the GMAC. Breaking them apart to debug separately and let the GMAC itself be upstreamed faster. [Changes since v14] Expanded comment

[PATCH v16 4/6] hw/net: GMAC Rx Implementation

2024-01-30 Thread Nabih Estefan
From: Nabih Estefan Diaz - Implementation of Receive function for packets - Implementation for reading and writing from and to descriptors in memory for Rx When RX starts, we need to flush the queued packets so that they can be received by the GMAC device. Without this it won't work with TAP

[PATCH v16 5/6] hw/net: GMAC Tx Implementation

2024-01-30 Thread Nabih Estefan
From: Nabih Estefan Diaz - Implementation of Transmit function for packets - Implementation for reading and writing from and to descriptors in memory for Tx Added relevant trace-events NOTE: This function implements the steps detailed in the datasheet for transmitting messages from the GMAC.

[PATCH v16 6/6] tests/qtest: Adding PCS Module test to GMAC Qtest

2024-01-30 Thread Nabih Estefan
From: Nabih Estefan Diaz - Add PCS Register check to npcm_gmac-test Change-Id: I34821beb5e0b1e89e2be576ab58eabe41545af12 Signed-off-by: Nabih Estefan Reviewed-by: Tyrone Ting --- tests/qtest/npcm_gmac-test.c | 132 +++ 1 file changed, 132 insertions(+) diff

[PATCH v16 2/6] hw/arm: Add GMAC devices to NPCM7XX SoC

2024-01-30 Thread Nabih Estefan
From: Hao Wu Change-Id: Id8a3461fb5042adc4c3fd6f4fbd1ca0d33e22565 Signed-off-by: Hao Wu Signed-off-by: Nabih Estefan Reviewed-by: Tyrone Ting --- hw/arm/npcm7xx.c | 37 +++-- include/hw/arm/npcm7xx.h | 2 ++ 2 files changed, 37 insertions(+), 2

[PATCH v16 3/6] tests/qtest: Creating qtest for GMAC Module

2024-01-30 Thread Nabih Estefan
From: Nabih Estefan Diaz - Created qtest to check initialization of registers in GMAC Module. - Implemented test into Build File. Change-Id: I8b2fe152d3987a7eec4cf6a1d25ba92e75a5391d Signed-off-by: Nabih Estefan Reviewed-by: Tyrone Ting --- tests/qtest/meson.build | 1 +

[PATCH v16 6/6] tests/qtest: Adding PCS Module test to GMAC Qtest

2024-01-30 Thread Nabih Estefan
From: Nabih Estefan Diaz - Add PCS Register check to npcm_gmac-test Change-Id: I34821beb5e0b1e89e2be576ab58eabe41545af12 Signed-off-by: Nabih Estefan Reviewed-by: Tyrone Ting --- tests/qtest/npcm_gmac-test.c | 132 +++ 1 file changed, 132 insertions(+) diff

[PATCH v16 0/6] Implementation of NPI Mailbox and GMAC Networking Module

2024-01-30 Thread Nabih Estefan
From: Nabih Estefan Diaz [Changes since v15] Dropped PCI MBox patches. They were presenting a lot of problems with endianness and are not directly related to the GMAC. Breaking them apart to debug separately and let the GMAC itself be upstreamed faster. [Changes since v14] Expanded comment

[PATCH v16 4/6] hw/net: GMAC Rx Implementation

2024-01-30 Thread Nabih Estefan
From: Nabih Estefan Diaz - Implementation of Receive function for packets - Implementation for reading and writing from and to descriptors in memory for Rx When RX starts, we need to flush the queued packets so that they can be received by the GMAC device. Without this it won't work with TAP

[PATCH v16 5/6] hw/net: GMAC Tx Implementation

2024-01-30 Thread Nabih Estefan
From: Nabih Estefan Diaz - Implementation of Transmit function for packets - Implementation for reading and writing from and to descriptors in memory for Tx Added relevant trace-events NOTE: This function implements the steps detailed in the datasheet for transmitting messages from the GMAC.

[PATCH v16 2/6] hw/arm: Add GMAC devices to NPCM7XX SoC

2024-01-30 Thread Nabih Estefan
From: Hao Wu Change-Id: Id8a3461fb5042adc4c3fd6f4fbd1ca0d33e22565 Signed-off-by: Hao Wu Signed-off-by: Nabih Estefan Reviewed-by: Tyrone Ting --- hw/arm/npcm7xx.c | 37 +++-- include/hw/arm/npcm7xx.h | 2 ++ 2 files changed, 37 insertions(+), 2

[PATCH v16 3/6] tests/qtest: Creating qtest for GMAC Module

2024-01-30 Thread Nabih Estefan
From: Nabih Estefan Diaz - Created qtest to check initialization of registers in GMAC Module. - Implemented test into Build File. Change-Id: I8b2fe152d3987a7eec4cf6a1d25ba92e75a5391d Signed-off-by: Nabih Estefan Reviewed-by: Tyrone Ting --- tests/qtest/meson.build | 1 +

[PATCH v16 1/6] hw/net: Add NPCMXXX GMAC device

2024-01-30 Thread Nabih Estefan
From: Hao Wu This patch implements the basic registers of GMAC device and sets registers for networking functionalities. Squashed IRQ Implementation patch into this one for compliation. Tested: The following message shows up with the change: Broadcom BCM54612E stmmac-0:00: attached PHY driver

[PATCH] linux-user: Make TARGET_NR_setgroups affect only the current thread

2024-01-30 Thread Ilya Leoshkevich
Like TARGET_NR_setuid, TARGET_NR_setgroups should affect only the calling thread, and not the entire process. Therefore, implement it using a syscall, and not a libc call. Cc: qemu-sta...@nongnu.org Fixes: 19b84f3c35d7 ("added setgroups and getgroups syscalls") Signed-off-by: Ilya Leoshkevich

[PATCH 0/3] ui/gtk: introducing vc->visible

2024-01-30 Thread dongwon . kim
From: Dongwon Kim Drawing guest display frames can't be completed while the VC is not in visible state, which could result in timeout in both the host and the guest especially when using blob scanout. Therefore it is needed to update and track the visiblity status of the VC and unblock the

[PATCH 1/3] ui/gtk: skip drawing guest scanout when associated VC is invisible

2024-01-30 Thread dongwon . kim
From: Dongwon Kim A new flag "visible" is added to show visibility status of the gfx console. The flag is set to 'true' when the VC is visible but set to 'false' when it is hidden or closed. When the VC is invisible, drawing guest frames should be skipped as it will never be completed and it

[PATCH 3/3] ui/gtk: reset visible flag when window is minimized

2024-01-30 Thread dongwon . kim
From: Dongwon Kim Adding a callback for window-state-event that resets the flag, 'visible' when associated window is minimized or restored. When minimizing, it cancels any of queued draw events associated with the VC. Cc: Marc-André Lureau Cc: Gerd Hoffmann Cc: Vivek Kasireddy Signed-off-by:

[PATCH 2/3] ui/gtk: set the ui size to 0 when invisible

2024-01-30 Thread dongwon . kim
From: Dongwon Kim UI size is set to 0 when the VC is invisible, which will prevent the further scanout update by notifying the guest that the display is not in active state. Then it is restored to the original size whenever the VC becomes visible again. Cc: Marc-André Lureau Cc: Gerd Hoffmann

Re: [PATCH] pc: q35: Bump max_cpus to 1728 vcpus

2024-01-30 Thread Michael S. Tsirkin
On Tue, Jan 30, 2024 at 10:39:51PM +0530, Ani Sinha wrote: > > > > On 30-Jan-2024, at 22:17, Daniel P. Berrangé wrote: > > > > On Tue, Jan 30, 2024 at 10:14:28PM +0530, Ani Sinha wrote: > >> Since commit f10a570b093e6 ("KVM: x86: Add CONFIG_KVM_MAX_NR_VCPUS to > >> allow up to 4096 vCPUs") >

Re: [PATCH] virtio-blk: avoid using ioeventfd state in irqfd conditional

2024-01-30 Thread Stefan Hajnoczi
On Mon, 22 Jan 2024 at 12:27, Stefan Hajnoczi wrote: > > Requests that complete in an IOThread use irqfd to notify the guest > while requests that complete in the main loop thread use the traditional > qdev irq code path. The reason for this conditional is that the irq code > path requires the

[PULL 5/5] hw/block/block.c: improve confusing blk_check_size_and_read_all() error

2024-01-30 Thread Stefan Hajnoczi
From: Manos Pitsidianakis In cases where a device tries to read more bytes than the block device contains, the error is vague: "device requires X bytes, block backend provides Y bytes". This patch changes the errors of this function to include the block backend name, the device id and device

[PULL 2/5] block/blkio: Make s->mem_region_alignment be 64 bits

2024-01-30 Thread Stefan Hajnoczi
From: "Richard W.M. Jones" With GCC 14 the code failed to compile on i686 (and was wrong for any version of GCC): ../block/blkio.c: In function ‘blkio_file_open’: ../block/blkio.c:857:28: error: passing argument 3 of ‘blkio_get_uint64’ from incompatible pointer type

Re: [PATCH v3 0/2] hw/block/block.c: improve confusing error

2024-01-30 Thread Stefan Hajnoczi
On Tue, Jan 30, 2024 at 09:30:30AM +0200, Manos Pitsidianakis wrote: > In cases where a device tries to read more bytes than the block device > contains with the blk_check_size_and_read_all() function, the error is > vague: "device requires X bytes, block backend provides Y bytes". > > This patch

[PULL 1/5] block/io_uring: improve error message when init fails

2024-01-30 Thread Stefan Hajnoczi
From: Fiona Ebner The man page for io_uring_queue_init states: > io_uring_queue_init(3) returns 0 on success and -errno on failure. and the man page for io_uring_setup (which is one of the functions where the return value of io_uring_queue_init() can come from) states: > On error, a negative

[PULL 4/5] hw/core/qdev.c: add qdev_get_human_name()

2024-01-30 Thread Stefan Hajnoczi
From: Manos Pitsidianakis Add a simple method to return some kind of human readable identifier for use in error messages. Reviewed-by: Stefan Hajnoczi Signed-off-by: Manos Pitsidianakis Message-id: 8b566bfced98ae44be1fcc1f8e7215f0c3393aa1.1706598705.git.manos.pitsidiana...@linaro.org

[PULL 3/5] pflash: fix sectors vs bytes confusion in blk_pread_nonzeroes()

2024-01-30 Thread Stefan Hajnoczi
The following expression is incorrect because blk_pread_nonzeroes() deals in units of bytes, not sectors: bytes = MIN(size - offset, BDRV_REQUEST_MAX_SECTORS) ^^^ BDRV_REQUEST_MAX_BYTES is the appropriate constant. Fixes: a4b15a8b9ef2

[PULL 0/5] Block patches

2024-01-30 Thread Stefan Hajnoczi
The following changes since commit 11be70677c70fdccd452a3233653949b79e97908: Merge tag 'pull-vfio-20240129' of https://github.com/legoater/qemu into staging (2024-01-29 10:53:56 +) are available in the Git repository at: https://gitlab.com/stefanha/qemu.git tags/block-pull-request for

Re: [PATCH v2 2/4] scripts/replay-dump.py: Update to current rr record format

2024-01-30 Thread John Snow
On Thu, Jan 25, 2024 at 11:09 AM Nicholas Piggin wrote: > > The v12 format support for replay-dump has a few issues still. This > fixes async decoding; adds event, shutdown, and end decoding; fixes > audio in / out events, fixes checkpoint checking of following async > events. > > Signed-off-by:

Re: [PATCH 05/17] migration/multifd: Wait for multifd channels creation before proceeding

2024-01-30 Thread Fabiano Rosas
Avihai Horon writes: > On 29/01/2024 16:34, Fabiano Rosas wrote: >> External email: Use caution opening links or attachments >> >> >> Avihai Horon writes: >> >>> Currently, multifd channels are created asynchronously without waiting >>> for their creation -- migration simply proceeds and may

Re: [PULL 06/15] tests/qtest/migration: Don't use -cpu max for aarch64

2024-01-30 Thread Fabiano Rosas
Peter Xu writes: > On Tue, Jan 30, 2024 at 10:18:07AM +, Peter Maydell wrote: >> On Mon, 29 Jan 2024 at 23:31, Fabiano Rosas wrote: >> > >> > Fabiano Rosas writes: >> > >> > > Peter Xu writes: >> > > >> > >> On Fri, Jan 26, 2024 at 11:54:32AM -0300, Fabiano Rosas wrote: >> > > The issue

Re: [PATCH] pflash: fix sectors vs bytes confusion in blk_pread_nonzeroes()

2024-01-30 Thread Stefan Hajnoczi
On Mon, Jan 29, 2024 at 07:27:12PM -0500, Stefan Hajnoczi wrote: > The following expression is incorrect because blk_pread_nonzeroes() > deals in units of bytes, not sectors: > > bytes = MIN(size - offset, BDRV_REQUEST_MAX_SECTORS) > ^^^ > >

Re: [PATCH v2] block/blkio: Make s->mem_region_alignment be 64 bits

2024-01-30 Thread Stefan Hajnoczi
On Tue, Jan 30, 2024 at 12:20:01PM +, Richard W.M. Jones wrote: > With GCC 14 the code failed to compile on i686 (and was wrong for any > version of GCC): > > ../block/blkio.c: In function ‘blkio_file_open’: > ../block/blkio.c:857:28: error: passing argument 3 of ‘blkio_get_uint64’ from >

Re: [PATCH [repost]] block/blkio: Don't assume size_t is 64 bit

2024-01-30 Thread Stefan Hajnoczi
On Tue, Jan 30, 2024 at 12:19:37PM +, Richard W.M. Jones wrote: > On Tue, Jan 30, 2024 at 01:04:46PM +0100, Kevin Wolf wrote: > > Am 30.01.2024 um 11:30 hat Richard W.M. Jones geschrieben: > > > On Tue, Jan 30, 2024 at 09:51:59AM +0100, Kevin Wolf wrote: > > > > Am 29.01.2024 um 19:53 hat

Re: [PATCH v5 0/9] Misc clean ups to target/ppc exception handling

2024-01-30 Thread BALATON Zoltan
On Thu, 18 Jan 2024, BALATON Zoltan wrote: These are some small clean ups for target/ppc/excp_helper.c trying to make this code a bit simpler. No functional change is intended. This series was submitted before but only partially merged due to freeze and conflicting series os thia was postponed

Re: Call for GSoC/Outreachy internship project ideas

2024-01-30 Thread Stefan Hajnoczi
On Tue, 30 Jan 2024 at 14:40, Palmer Dabbelt wrote: > > On Mon, 15 Jan 2024 08:32:59 PST (-0800), stefa...@gmail.com wrote: > > Dear QEMU and KVM communities, > > QEMU will apply for the Google Summer of Code and Outreachy internship > > programs again this year. Regular contributors can submit

Re: Call for GSoC/Outreachy internship project ideas

2024-01-30 Thread Stefan Hajnoczi
On Tue, 30 Jan 2024 at 14:16, Alexander Graf wrote: > === Implement -M nitro-enclave in QEMU === > > '''Summary:''' AWS EC2 provides the ability to create an isolated > sibling VM context from within a VM. This project implements the machine > model and input data format parsing needed to run

Re: Call for GSoC/Outreachy internship project ideas

2024-01-30 Thread Palmer Dabbelt
On Mon, 15 Jan 2024 08:32:59 PST (-0800), stefa...@gmail.com wrote: Dear QEMU and KVM communities, QEMU will apply for the Google Summer of Code and Outreachy internship programs again this year. Regular contributors can submit project ideas that they'd like to mentor by replying to this email

Re: Call for GSoC/Outreachy internship project ideas

2024-01-30 Thread Stefan Hajnoczi
Hi Eugenio, Stefano Garzarella and I had a SVQ-related project idea that I have added: https://wiki.qemu.org/Google_Summer_of_Code_2024#vhost-user_memory_isolation We want to support vhost-user devices without exposing guest RAM. This is attractive for security reasons in vhost-user-vsock where a

Re: Call for GSoC/Outreachy internship project ideas

2024-01-30 Thread Alexander Graf
Hey Stefan, Thanks a lot for setting up GSoC this year again! On 15.01.24 17:32, Stefan Hajnoczi wrote: Dear QEMU and KVM communities, QEMU will apply for the Google Summer of Code and Outreachy internship programs again this year. Regular contributors can submit project ideas that they'd like

Re: [PATCH v2] scripts/checkpatch.pl: check for placeholders in cover letter patches

2024-01-30 Thread Philippe Mathieu-Daudé
On 30/1/24 16:11, Alex Bennée wrote: Manos Pitsidianakis writes: On Tue, 30 Jan 2024 12:15, "Daniel P. Berrangé" wrote: On Tue, Jan 30, 2024 at 12:11:07PM +0200, Manos Pitsidianakis wrote: Check if a file argument is a cover letter patch produced by git-format-patch --cover-letter; It is

Re: [PATCH] pc: q35: Bump max_cpus to 1728 vcpus

2024-01-30 Thread Philippe Mathieu-Daudé
On 30/1/24 18:09, Ani Sinha wrote: On 30-Jan-2024, at 22:17, Daniel P. Berrangé wrote: On Tue, Jan 30, 2024 at 10:14:28PM +0530, Ani Sinha wrote: Since commit f10a570b093e6 ("KVM: x86: Add CONFIG_KVM_MAX_NR_VCPUS to allow up to 4096 vCPUs") Linux kernel can support upto a maximum number

[PATCH v1 0/1] Qemu crashes on VM migration after an handled memory error

2024-01-30 Thread “William Roche
From: William Roche Problem: A Qemu VM can survive a memory error, as qemu can relay the error to the VM kernel which could also deal with it -- poisoning/off-lining the impacted page. This situation creates a hole in the VM memory address space (an unreadable page or set of pages). A

[PATCH v1 1/1] migration: prevent migration when VM has poisoned memory

2024-01-30 Thread “William Roche
From: William Roche A memory page poisoned from the hypervisor level is no longer readable. The migration of a VM will crash Qemu when it tries to read the memory address space and stumbles on the poisoned page with a similar stack trace: Program terminated with signal SIGBUS, Bus error. #0

[PATCH 1/4] hw/arm/stellaris: Convert ADC controller to Resettable interface

2024-01-30 Thread Philippe Mathieu-Daudé
Signed-off-by: Philippe Mathieu-Daudé --- hw/arm/stellaris.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/hw/arm/stellaris.c b/hw/arm/stellaris.c index d18b1144af..afbc83f1e6 100644 --- a/hw/arm/stellaris.c +++ b/hw/arm/stellaris.c @@ -773,8 +773,9 @@ static void

[PATCH 4/4] hw/arm/stellaris: Add missing QOM 'SoC' parent

2024-01-30 Thread Philippe Mathieu-Daudé
QDev objects created with qdev_new() need to manually add their parent relationship with object_property_add_child(). Since we don't model the SoC, just use a QOM container. Signed-off-by: Philippe Mathieu-Daudé --- hw/arm/stellaris.c | 11 ++- 1 file changed, 10 insertions(+), 1

[PATCH v4] doc/sphinx/hxtool.py: add optional label argument to SRST directive

2024-01-30 Thread David Woodhouse
From: David Woodhouse We can't just embed labels directly into files like qemu-options.hx which are included from multiple top-level rST files, because Sphinx sees the labels as duplicate: https://github.com/sphinx-doc/sphinx/issues/9707 So add an optional argument to the SRST directive which

[PATCH 3/4] hw/arm/stellaris: Add missing QOM 'machine' parent

2024-01-30 Thread Philippe Mathieu-Daudé
QDev objects created with qdev_new() need to manually add their parent relationship with object_property_add_child(). Signed-off-by: Philippe Mathieu-Daudé --- hw/arm/stellaris.c | 4 1 file changed, 4 insertions(+) diff --git a/hw/arm/stellaris.c b/hw/arm/stellaris.c index

[PATCH 2/4] hw/arm/stellaris: Convert I2C controller to Resettable interface

2024-01-30 Thread Philippe Mathieu-Daudé
Signed-off-by: Philippe Mathieu-Daudé --- hw/arm/stellaris.c | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/hw/arm/stellaris.c b/hw/arm/stellaris.c index afbc83f1e6..284b95005f 100644 --- a/hw/arm/stellaris.c +++ b/hw/arm/stellaris.c @@ -607,8 +607,11 @@ static void

[PATCH 0/4] hw/arm/stellaris: QOM/QDev cleanups

2024-01-30 Thread Philippe Mathieu-Daudé
Gustavo wants to access the QOM path of an input IRQ line from the NVIC, but since the device is orphan he ends up with this nasty path [*]: -device ivshmem-flat,chardev=ivshmem_flat,x-irq-qompath='/machine/unattached/device[1]/nvic/unnamed-gpio-in[0]',x-bus-qompath='/sysbus' Add the missing

Re: [PATCH] hw/pci: migration: Skip config space check for vendor specific capability during restore/load

2024-01-30 Thread Alex Williamson
On Tue, 30 Jan 2024 23:32:26 +0530 Vinayak Kale wrote: > Missed adding Michael, Marcel, Alex and Avihai earlier, apologies. > > Regards, > Vinayak > > On 30/01/24 3:26 pm, Vinayak Kale wrote: > > In case of migration, during restore operation, qemu checks the config > > space of the pci

Re: [PATCH v3] doc/sphinx/hxtool.py: add optional label argument to SRST directive

2024-01-30 Thread David Woodhouse
On Tue, 2024-01-30 at 17:55 +, Peter Maydell wrote: > > This looks good so > Reviewed-by: Peter Maydell Thanks. > but something has got mangled somewhere: patchew can't apply it: > https://patchew.org/QEMU/4114f7204e892316d66be8f810eb5b8de4c0f75f.ca...@infradead.org/ > and patches doesn't

Re: [PATCH 04/17] migration/multifd: Set p->running = true in the right place

2024-01-30 Thread Avihai Horon
On 30/01/2024 7:57, Peter Xu wrote: External email: Use caution opening links or attachments On Mon, Jan 29, 2024 at 02:20:35PM +0200, Avihai Horon wrote: On 29/01/2024 6:17, Peter Xu wrote: External email: Use caution opening links or attachments On Sun, Jan 28, 2024 at 05:43:52PM

Re: [PATCH] hw/scsi/lsi53c895a: add missing decrement of reentrancy counter

2024-01-30 Thread Helge Deller
On 1/28/24 21:22, Sven Schnelle wrote: When the maximum count of SCRIPTS instructions is reached, the code stops execution and returns, but fails to decrement the reentrancy counter. This effectively renders the SCSI controller unusable because on next entry the reentrancy counter is still above

Re: [PATCH 05/17] migration/multifd: Wait for multifd channels creation before proceeding

2024-01-30 Thread Avihai Horon
On 29/01/2024 16:34, Fabiano Rosas wrote: External email: Use caution opening links or attachments Avihai Horon writes: Currently, multifd channels are created asynchronously without waiting for their creation -- migration simply proceeds and may wait in multifd_send_sync_main(), which is

Re: [RFC 0/7] VIRTIO-IOMMU/VFIO: Fix host iommu geometry handling for hotplugged devices

2024-01-30 Thread Jean-Philippe Brucker
On Mon, Jan 29, 2024 at 05:38:55PM +0100, Eric Auger wrote: > > There may be a separate argument for clearing bypass. With a coldplugged > > VFIO device the flow is: > > > > 1. Map the whole guest address space in VFIO to implement boot-bypass. > >This allocates all guest pages, which takes a

Re: [PATCH] hw/pci: migration: Skip config space check for vendor specific capability during restore/load

2024-01-30 Thread Vinayak Kale
Missed adding Michael, Marcel, Alex and Avihai earlier, apologies. Regards, Vinayak On 30/01/24 3:26 pm, Vinayak Kale wrote: In case of migration, during restore operation, qemu checks the config space of the pci device with the config space in the migration stream captured during save

Re: [PATCH v3] doc/sphinx/hxtool.py: add optional label argument to SRST directive

2024-01-30 Thread Peter Maydell
On Sat, 27 Jan 2024 at 23:18, David Woodhouse wrote: > > From: David Woodhouse > > We can't just embed labels directly into files like qemu-options.hx which > are included from multiple top-level rST files, because Sphinx sees the > labels as duplicate:

Re: [PATCH] pc: q35: Bump max_cpus to 1728 vcpus

2024-01-30 Thread Daniel P . Berrangé
On Tue, Jan 30, 2024 at 10:39:51PM +0530, Ani Sinha wrote: > > > > On 30-Jan-2024, at 22:17, Daniel P. Berrangé wrote: > > > > On Tue, Jan 30, 2024 at 10:14:28PM +0530, Ani Sinha wrote: > >> Since commit f10a570b093e6 ("KVM: x86: Add CONFIG_KVM_MAX_NR_VCPUS to > >> allow up to 4096 vCPUs") >

Re: [PATCH v15 3/9] hw/misc: Add qtest for NPCM7xx PCI Mailbox

2024-01-30 Thread Peter Maydell
On Thu, 25 Jan 2024 at 19:42, Nabih Estefan wrote: > > From: Hao Wu > > This patches adds a qtest for NPCM7XX PCI Mailbox module. > It sends read and write requests to the module, and verifies that > the module contains the correct data after the requests. > > Change-Id:

Re: [PATCH v15 1/9] hw/misc: Add Nuvoton's PCI Mailbox Module

2024-01-30 Thread Peter Maydell
On Thu, 25 Jan 2024 at 19:42, Nabih Estefan wrote: > > From: Hao Wu > > The PCI Mailbox Module is a high-bandwidth communcation module > between a Nuvoton BMC and CPU. It features 16KB RAM that are both > accessible by the BMC and core CPU. and supports interrupt for > both sides. > > This patch

Re: [PATCH 1/3] hw/i386: Add `\n` to hint message

2024-01-30 Thread Greg Kurz
On Tue, 30 Jan 2024 21:43:27 +0530 Ani Sinha wrote: > > > > On 30-Jan-2024, at 21:26, Greg Kurz wrote: > > > > error_fprintf() doesn't add newlines. > > ^ > > Should be error_printf(). Ditto for other patches. > Thanks. Posted a v2. > > > > Signed-off-by: Greg Kurz > >

Re: [PATCH v2 3/3] hw/arm: Add `\n` to hint message

2024-01-30 Thread Ani Sinha
> On 30-Jan-2024, at 22:07, Greg Kurz wrote: > > error_printf() doesn't add newlines. > > Signed-off-by: Greg Kurz Reviewed-by: Ani Sinha > --- > hw/arm/virt-acpi-build.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/hw/arm/virt-acpi-build.c

Re: [PATCH] pc: q35: Bump max_cpus to 1728 vcpus

2024-01-30 Thread Ani Sinha
> On 30-Jan-2024, at 22:17, Daniel P. Berrangé wrote: > > On Tue, Jan 30, 2024 at 10:14:28PM +0530, Ani Sinha wrote: >> Since commit f10a570b093e6 ("KVM: x86: Add CONFIG_KVM_MAX_NR_VCPUS to allow >> up to 4096 vCPUs") >> Linux kernel can support upto a maximum number of 4096 vCPUS when

Re: [PATCH v2 1/3] hw/i386: Add `\n` to hint message

2024-01-30 Thread Ani Sinha
> On 30-Jan-2024, at 22:07, Greg Kurz wrote: > > error_printf() doesn't add newlines. > > Signed-off-by: Greg Kurz Reviewed-by: Ani Sinha > --- > hw/i386/acpi-build.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/hw/i386/acpi-build.c b/hw/i386/acpi-build.c

  1   2   3   >