Re: [PATCH 0/3] virtio-gpu: Enable virglrenderer backend for rutabaga

2024-06-06 Thread Weifeng Liu
Hi Alex, On Thu, 2024-06-06 at 11:43 +0100, Alex Bennée wrote: > Weifeng Liu writes: > > > Greetings, > > > > I'd like to introduce you my attempt to enable virglrenderer backend for > > rutabaga empowered virtio-gpu device. I am aware that there have been > > effort in supporting venus in vir

Re: [PATCH v3 1/4] qom: allow to mark objects as deprecated or not secure.

2024-06-06 Thread Philippe Mathieu-Daudé
On 6/6/24 16:30, Gerd Hoffmann wrote: Add flags to ObjectClass for objects which are deprecated or not secure. Add 'deprecated' and 'not-secure' bools to ObjectTypeInfo, report in 'qom-list-types'. Print the flags when listing devices via '-device help'. Signed-off-by: Gerd Hoffmann --- incl

Re: [PATCH 0/5] s390x: Add Full Boot Order Support

2024-06-06 Thread Thomas Huth
On 06/06/2024 21.22, Jared Rossi wrote: On 6/5/24 4:02 AM, Thomas Huth wrote: On 29/05/2024 17.43, jro...@linux.ibm.com wrote: From: Jared Rossi This patch set primarily adds support for the specification of multiple boot devices, allowing for the guest to automatically use an alternative

Re: [PATCH] i386/apic: Add hint on boot failure because of disabling x2APIC

2024-06-06 Thread Philippe Mathieu-Daudé
On 6/6/24 16:08, Zhao Liu wrote: Currently, the Q35 supports up to 4096 vCPUs (since v9.0), but for TCG cases, if x2APIC is not actively enabled to boot more than 255 vCPUs ( e.g., qemu-system-i386 -M pc-q35-9.0 -smp 666), the following error is reported: Unexpected error in apic_common_set_id()

Re: [PATCH v3 5/6] Move tcg implementation of x86 get_physical_address into common helper code.

2024-06-06 Thread Philippe Mathieu-Daudé
On 6/6/24 16:02, Don Porter wrote: Signed-off-by: Don Porter --- target/i386/cpu.h| 42 ++ target/i386/helper.c | 515 + target/i386/tcg/sysemu/excp_helper.c | 555 +-- 3 files changed, 562 insertions(+), 5

Re: [PATCH 3/5] s390x: Build IPLB chain for multiple boot devices

2024-06-06 Thread Thomas Huth
On 05/06/2024 22.01, Jared Rossi wrote: On 6/4/24 2:26 PM, Thomas Huth wrote: On 29/05/2024 17.43, jro...@linux.ibm.com wrote: From: Jared Rossi Write a chain of IPLBs into memory for future use. The IPLB chain is placed immediately before the BIOS in memory at the highest unused page boun

Re: [PATCH v3 1/6] Add an "info pg" command that prints the current page tables

2024-06-06 Thread Philippe Mathieu-Daudé
On 6/6/24 16:02, Don Porter wrote: The new "info pg" monitor command prints the current page table, including virtual address ranges, flag bits, and snippets of physical page numbers. Completely filled regions of the page table with compatible flags are "folded", with the result that the complet

Re: [PULL 07/20] virtio-net: Do not propagate ebpf-rss-fds errors

2024-06-06 Thread Akihiko Odaki
On 2024/06/06 16:59, Daniel P. Berrangé wrote: On Thu, Jun 06, 2024 at 04:19:11PM +0900, Akihiko Odaki wrote: On 2024/06/06 16:14, Daniel P. Berrangé wrote: On Thu, Jun 06, 2024 at 05:14:20AM +0900, Akihiko Odaki wrote: On 2024/06/05 19:23, Daniel P. Berrangé wrote: On Tue, Jun 04, 2024 at 03

Re: [PATCH v3 2/6] Convert 'info tlb' to use generic iterator

2024-06-06 Thread Philippe Mathieu-Daudé
Hi Don, (Cc'ing Daniel for HumanReadableText) On 6/6/24 16:02, Don Porter wrote: Signed-off-by: Don Porter --- include/hw/core/sysemu-cpu-ops.h | 7 + monitor/hmp-cmds-target.c| 1 + target/i386/cpu.h| 2 + target/i386/monitor.c| 217 ++---

Re: [PATCH 5/5] s390x: Enable and document boot device fallback on panic

2024-06-06 Thread Thomas Huth
On 05/06/2024 16.48, Jared Rossi wrote: diff --git a/pc-bios/s390-ccw/s390-ccw.h b/pc-bios/s390-ccw/s390-ccw.h index c977a52b50..de3d1f0d5a 100644 --- a/pc-bios/s390-ccw/s390-ccw.h +++ b/pc-bios/s390-ccw/s390-ccw.h @@ -43,6 +43,7 @@ typedef unsigned long long u64;   #include "iplb.h"     /* sta

Re: [PATCH 0/6] refactor RDMA live migration based on rsocket API

2024-06-06 Thread Jinpu Wang
Hi Gonglei, hi folks on the list, On Tue, Jun 4, 2024 at 2:14 PM Gonglei wrote: > > From: Jialin Wang > > Hi, > > This patch series attempts to refactor RDMA live migration by > introducing a new QIOChannelRDMA class based on the rsocket API. > > The /usr/include/rdma/rsocket.h provides a higher

Re: [PATCH v4 0/6] target/riscv: Support RISC-V privilege 1.13 spec

2024-06-06 Thread Alistair Francis
On Thu, Jun 6, 2024 at 11:50 PM Fea.Wang wrote: > > Based on the change log for the RISC-V privilege 1.13 spec, add the > support for ss1p13. > > base-commit: 7a2356147f3a5faebf95dba4140247ec6e5607b1 > > * Reorder commits > > [v3] > * Correct the mstateen0 for P1P13 in commit message > * Refactor

Re: [PATCH 2/3] plugins: Free CPUPluginState before destroying vCPU state

2024-06-06 Thread Philippe Mathieu-Daudé
On 6/6/24 23:14, Pierrick Bouvier wrote: On 6/6/24 05:40, Philippe Mathieu-Daudé wrote: cpu::plugin_state is allocated in cpu_common_initfn() when the vCPU state is created. Release it in cpu_common_finalize() when we are done. Signed-off-by: Philippe Mathieu-Daudé ---   include/qemu/plugin.h

[PATCH 1/3] linux-user: Adjust comment to reflect the code.

2024-06-06 Thread Warner Losh
If the user didn't specify a reserved_va, there's an else for 64-bit host 32-bit (or fewer) target to reserve 32-bits of address space. Update the comments to reflect this, and rejustify comment to 80 columns. Signed-off-by: Warner Losh --- linux-user/main.c | 8 1 file changed, 4 inser

[PATCH 2/3] bsd-user: port linux-user:ff8a8bbc2ad1 for variable page sizes

2024-06-06 Thread Warner Losh
Bring in Richard Henderson's ff8a8bbc2ad1 to finalize the page size to allow TARGET_PAGE_BITS_VARY. bsd-user's "blitz" fork has aarch64 support, which is now variable page size. Add support for it here, even though it's effectively a nop in upstream qemu. Signed-off-by: Warner Losh --- bsd-user/

[PATCH 3/3] bsd-user: Catch up to run-time reserved_va math

2024-06-06 Thread Warner Losh
Catch up to linux-user's 8f67b9c694d0, 13c13397556a, 2f7828b57293, and 95059f9c313a by Richard Henderson which made reserved_va a run-time calculation, defaulting to nothing except in the case of 64-bit host 32-bit target. Also include the adjustment of the comment heading that work submitted in th

[PATCH 0/3] bsd-user: Baby Steps towards eliminating qemu_host_page_size, et al

2024-06-06 Thread Warner Losh
First baby-steps towards eliminating qemu_host_page_size: tackle the reserve_va calculation (which is easier to copy from linux-user than to fix). Warner Losh (3): linux-user: Adjust comment to reflect the code. bsd-user: port linux-user:ff8a8bbc2ad1 for variable page sizes bsd-user: Catch u

[PATCH v3] target/loongarch/kvm: Add software breakpoint support

2024-06-06 Thread Bibo Mao
With KVM virtualization, debug exception is injected to guest kernel rather than host for normal break intruction. Here hypercall instruction with special code is used for sw breakpoint usage, and detailed instruction comes from kvm kernel with user API KVM_REG_LOONGARCH_DEBUG_INST. Now only softw

Re: [PATCH v2 2/2] util/bufferiszero: Add loongarch64 vector acceleration

2024-06-06 Thread maobibo
On 2024/6/7 上午8:24, Richard Henderson wrote: Use inline assembly because no release compiler allows per-function selection of the ISA. Signed-off-by: Richard Henderson --- .../loongarch64/host/bufferiszero.c.inc | 143 ++ 1 file changed, 143 insertions(+) create mo

Re: [RFC PATCH] migration/savevm: do not schedule snapshot_save_job_bh in qemu_aio_context

2024-06-06 Thread Stefan Hajnoczi
On Wed, Jun 05, 2024 at 02:08:48PM +0200, Fiona Ebner wrote: > The fact that the snapshot_save_job_bh() is scheduled in the main > loop's qemu_aio_context AioContext means that it might get executed > during a vCPU thread's aio_poll(). But saving of the VM state cannot > happen while the guest or d

Re: [PATCH v4 6/6] target/riscv: Support the version for ss1p13

2024-06-06 Thread Alistair Francis
On Thu, Jun 6, 2024 at 11:51 PM Fea.Wang wrote: > > Add RISC-V privilege 1.13 support. > > Signed-off-by: Fea.Wang > Signed-off-by: Fea.Wang > Reviewed-by: Frank Chang > Reviewed-by: Weiwei Li > Reviewed-by: LIU Zhiwei Reviewed-by: Alistair Francis Alistair > --- > target/riscv/cpu.c

Re: [PATCH 0/6] refactor RDMA live migration based on rsocket API

2024-06-06 Thread Zhijian Li (Fujitsu)
On 06/06/2024 19:31, Leon Romanovsky wrote: > On Wed, Jun 05, 2024 at 10:00:24AM +, Gonglei (Arei) wrote: >> >> >>> -Original Message- >>> From: Michael S. Tsirkin [mailto:m...@redhat.com] >>> Sent: Wednesday, June 5, 2024 3:57 PM >>> To: Gonglei (Arei) >>> Cc: qemu-devel@nongnu.org;

Re: [PATCH 2/2] util/bufferiszero: Add simd acceleration for loongarch64

2024-06-06 Thread Richard Henderson
On 6/5/24 21:00, maobibo wrote: No, because the ifdef checks that the *compiler* is prepared to use LASX/LSX instructions itself without further checks.  There's no point in qemu checking further. By my understanding, currently compiler option is the same with all files, there is no separate com

[PATCH v2 0/2] util/bufferiszero: Split out hosts, add loongarch64

2024-06-06 Thread Richard Henderson
Based-on: 20240527211912.14060-1-richard.hender...@linaro.org ("[PATCH 00/18] tcg/loongarch64: Support v64 and v256") For "util/loongarch64: Detect LASX vector support" For v2: * Rename to bufferiszero.c.inc (philmd). * Add inline assembly for loongarch64. On cfarm400.cfarm.net (Loongson-3C50

[PATCH v2 1/2] util/bufferiszero: Split out host include files

2024-06-06 Thread Richard Henderson
Split out host/bufferiszero.h.inc for x86, aarch64 and generic in order to avoid an overlong ifdef ladder. Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Richard Henderson --- util/bufferiszero.c | 191 +-- host/include/aarch64/host/bufferiszero.c.in

[PATCH v2 2/2] util/bufferiszero: Add loongarch64 vector acceleration

2024-06-06 Thread Richard Henderson
Use inline assembly because no release compiler allows per-function selection of the ISA. Signed-off-by: Richard Henderson --- .../loongarch64/host/bufferiszero.c.inc | 143 ++ 1 file changed, 143 insertions(+) create mode 100644 host/include/loongarch64/host/bufferiszero.

Re: [PULL 0/6] loongarch-to-apply queue

2024-06-06 Thread Richard Henderson
om/gaosong/qemu.git tags/pull-loongarch-20240606 for you to fetch changes up to 78f932ea1f7b3b9b0ac628dc2a91281318fe51fa: target/loongarch: fix a wrong print in cpu dump (2024-06-06 11:58:06 +0800) pull-loongarch-20240606 Appli

Re: [PATCH RFC] hw/arm/virt: Avoid unexpected warning from Linux guest on host with Fujitsu CPUs

2024-06-06 Thread Robin Murphy
On 2024-06-06 6:13 pm, Jonathan Cameron wrote: On Thu, 6 Jun 2024 12:56:59 +0100 Peter Maydell wrote: On Thu, 6 Jun 2024 at 11:48, Zhenyu Zhang wrote: Multiple warning messages and corresponding backtraces are observed when Linux guest is booted on the host with Fujitsu CPUs. One of them is

Re: [PATCH 2/3] plugins: Free CPUPluginState before destroying vCPU state

2024-06-06 Thread Pierrick Bouvier
On 6/6/24 05:40, Philippe Mathieu-Daudé wrote: cpu::plugin_state is allocated in cpu_common_initfn() when the vCPU state is created. Release it in cpu_common_finalize() when we are done. Signed-off-by: Philippe Mathieu-Daudé --- include/qemu/plugin.h | 3 +++ hw/core/cpu-common.c | 5 +

Re: [PATCH 1/3] plugins: Ensure vCPU index is assigned in init/exit hooks

2024-06-06 Thread Pierrick Bouvier
On 6/6/24 05:40, Philippe Mathieu-Daudé wrote: Since vCPUs are hashed by their index, this index can't be uninitialized (UNASSIGNED_CPU_INDEX). Signed-off-by: Philippe Mathieu-Daudé --- plugins/core.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/plugins/core.c b/plugins/core.c index

Re: [PATCH v3 03/13] hw/riscv: add RISC-V IOMMU base emulation

2024-06-06 Thread Daniel Henrique Barboza
On 5/29/24 10:39 PM, Eric Cheng wrote: On 5/24/2024 1:39 AM, Daniel Henrique Barboza wrote: From: Tomasz Jeznach The RISC-V IOMMU specification is now ratified as-per the RISC-V international process. The latest frozen specifcation can be found at: https://github.com/riscv-non-isa/riscv-io

Re: [PATCH 0/5] s390x: Add Full Boot Order Support

2024-06-06 Thread Jared Rossi
On 6/5/24 4:02 AM, Thomas Huth wrote: On 29/05/2024 17.43, jro...@linux.ibm.com wrote: From: Jared Rossi This patch set primarily adds support for the specification of multiple boot devices, allowing for the guest to automatically use an alternative device on a failed boot without needing

Re: [PULL 00/12] testing cleanups (ci, vm, lcitool, ansible)

2024-06-06 Thread Richard Henderson
On 6/6/24 04:50, Alex Bennée wrote: The following changes since commit db2feb2df8d19592c9859efb3f682404e0052957: Merge tag 'pull-misc-20240605' ofhttps://gitlab.com/rth7680/qemu into staging (2024-06-05 14:17:01 -0700) are available in the Git repository at: https://gitlab.com/stsquad/

Re: [PATCH 0/6] target/riscv: Add support for Control Transfer Records Ext.

2024-06-06 Thread Beeman Strong
PR for the spec fix, in case anyone is interested. Found a couple of other references to Smcsrind that I also removed. https://github.com/riscv/riscv-control-transfer-records/pull/29 On Tue, Jun 4, 2024 at 8:41 PM Beeman Strong wrote: > Ah, good catch. We removed that dependency late. I'll

Re: [PATCH qemu ] hw/acpi: Fix big endian host creation of Generic Port Affinity Structures

2024-06-06 Thread Jonathan Cameron via
On Thu, 6 Jun 2024 16:06:53 +0200 Igor Mammedov wrote: > On Wed, 5 Jun 2024 19:04:55 +0100 > Jonathan Cameron wrote: > > > Treating the HID as an integer caused it to get bit reversed > > on big endian hosts running little endian guests. Treat it > > as a character array instead. > > > > Fixe

Re: [PATCH] target/sparc: use signed denominator in sdiv helper

2024-06-06 Thread Mark Cave-Ayland
On 06/06/2024 15:43, Clément Chigot wrote: The result has to be done with the signed denominator (b32) instead of the unsigned value passed in argument (b). Fixes: 1326010322d6 ("target/sparc: Remove CC_OP_DIV") Signed-off-by: Clément Chigot --- target/sparc/helper.c | 2 +- 1 file changed,

Re: Historical QMP schema

2024-06-06 Thread John Snow
Adding upstream because I think there's little reason to keep this discussion off-list. The context of this mailing thread is that we are discussing how we might want to store and record historical QMP API interface information such that we can programmatically answer questions like "when was X co

Re: [PATCH RFC] hw/arm/virt: Avoid unexpected warning from Linux guest on host with Fujitsu CPUs

2024-06-06 Thread Jonathan Cameron via
On Thu, 6 Jun 2024 12:56:59 +0100 Peter Maydell wrote: > On Thu, 6 Jun 2024 at 11:48, Zhenyu Zhang wrote: > > > > Multiple warning messages and corresponding backtraces are observed when > > Linux > > guest is booted on the host with Fujitsu CPUs. One of them is shown as > > below. > > > > [

Re: [PATCH] target/sparc: use signed denominator in sdiv helper

2024-06-06 Thread Richard Henderson
On 6/6/24 07:43, Clément Chigot wrote: The result has to be done with the signed denominator (b32) instead of the unsigned value passed in argument (b). Fixes: 1326010322d6 ("target/sparc: Remove CC_OP_DIV") Signed-off-by: Clément Chigot --- target/sparc/helper.c | 2 +- 1 file changed, 1 in

Re: [PATCH 0/6] host/i386: require x86-64-v2 ISA

2024-06-06 Thread Alexander Monakov
Hi, On Fri, 31 May 2024, Paolo Bonzini wrote: > x86-64-v2 processors were released in 2008, assume that we have one. > This provides CMOV on 32-bit processors, and also POPCNT and various > vector ISA extensions. If my contributions to recent cleanups and speedups for buffer_is_zero count for so

Re: [PATCH v1 0/8] PRI support for VT-d

2024-06-06 Thread CLEMENT MATHIEU--DRIF
Hi, Just adding Michael in Cc: Thanks >cmd On 30/05/2024 14:24, CLEMENT MATHIEU--DRIF wrote: > This series belongs to a list of series that add SVM support for VT-d. > > Here we focus on the implementation of PRI support in the IOMMU and on a > PCI-level > API for PRI to be used by virtual de

Re: [PATCH] target/i386: SEV: do not assume machine->cgs is SEV

2024-06-06 Thread Paolo Bonzini
On Thu, Jun 6, 2024 at 6:07 PM Xiaoyao Li wrote: > > On 6/6/2024 6:44 AM, Paolo Bonzini wrote: > > There can be other confidential computing classes that are not derived > > from sev-common. Avoid aborting when encountering them. > > I hit it today when rebasing TDX patches to latest QEMU master,

Re: [PATCH] target/i386: SEV: do not assume machine->cgs is SEV

2024-06-06 Thread Xiaoyao Li
On 6/6/2024 6:44 AM, Paolo Bonzini wrote: There can be other confidential computing classes that are not derived from sev-common. Avoid aborting when encountering them. I hit it today when rebasing TDX patches to latest QEMU master, which has the SEV-SNP series merged. (I didn't get time to r

Re: [PATCH v5 0/3] Fix MCE handling on AMD hosts

2024-06-06 Thread John Allen
On Thu, Jun 06, 2024 at 11:09:05AM +0200, Paolo Bonzini wrote: > Queued, thanks. I added a note to the commit message in the third patch: Thanks, Paolo! > > By the time the MCE reaches the guest, the overflow has been handled > by the host and has not caused a shutdown, so include the b

Re: [PATCH v4 00/15] vfio: VFIO migration support with vIOMMU

2024-06-06 Thread Cédric Le Goater
Hello Joao, On 6/22/23 23:48, Joao Martins wrote: Hey, This series introduces support for vIOMMU with VFIO device migration, particurlarly related to how we do the dirty page tracking. Today vIOMMUs serve two purposes: 1) enable interrupt remaping 2) provide dma translation services for guests

[PATCH] hw/net: cadence_gem: fix: type2_compare_x_word_0 error

2024-06-06 Thread Andrew.Yuan
In the Cadence IP for Gigabit Ethernet MAC Part Number: IP7014 IP Rev: R1p12 - Doc Rev: 1.3 User Guide, the specification for the type2_compare_x_word_0 register is as follows: The byte stored in bits [23:16] is compared against the byte in the received frame from the selected of

Re: [PATCH v2 5/9] target/i386: Split out gdb-internal.h

2024-06-06 Thread Richard Henderson
On 6/5/24 23:51, Philippe Mathieu-Daudé wrote: Shouldn't we remove the definitions from the source to complete the "split"? Gah, I thought I had done that. r~

Re: [PATCH] target/s390x: Fix tracing header path in TCG mem_helper.c

2024-06-06 Thread Stefan Hajnoczi
On Thu, Jun 06, 2024 at 12:30:26PM +0200, Philippe Mathieu-Daudé wrote: > Commit c9274b6bf0 ("target/s390x: start moving TCG-only code > to tcg/") moved mem_helper.c, but the trace-events file is > still in the parent directory, so is the generated trace.h. > > Signed-off-by: Philippe Mathieu-Daud

Re: kvm crash with virtiofs

2024-06-06 Thread German Maglione
On Thu, Jun 6, 2024 at 10:40 AM Miklos Szeredi wrote: > > Hi, > > I get the below crash when running virtio-fs on fedora 39. > > Note: weirdly this makes chrome running on the host also crash. > > Eric Sandeen also reported some bad behavior of virtio-fs on fc39, > which might be related. > > Vers

Re: [PATCH v3 4/4] qdev: add device policy [RfC]

2024-06-06 Thread Peter Maydell
On Thu, 6 Jun 2024 at 15:31, Gerd Hoffmann wrote: > > Add policies for devices which are deprecated or not secure. > There are three options: allow, warn and deny. > > It's implemented for devices only. Devices will probably be the main > user of this. Also object_new() can't fail as of today so

[PATCH] target/sparc: use signed denominator in sdiv helper

2024-06-06 Thread Clément Chigot
The result has to be done with the signed denominator (b32) instead of the unsigned value passed in argument (b). Fixes: 1326010322d6 ("target/sparc: Remove CC_OP_DIV") Signed-off-by: Clément Chigot --- target/sparc/helper.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tar

Re: [PATCH v3 2/4] usb/hub: mark as deprecated

2024-06-06 Thread Daniel P . Berrangé
On Thu, Jun 06, 2024 at 04:30:08PM +0200, Gerd Hoffmann wrote: > The hub supports only USB 1.1. When running out of usb ports it is in > almost all cases the much better choice to add another usb host adapter > (or increase the number of root ports when using xhci) instead of using > the usb hub.

Re: [PATCH v3 1/4] qom: allow to mark objects as deprecated or not secure.

2024-06-06 Thread Daniel P . Berrangé
On Thu, Jun 06, 2024 at 04:30:07PM +0200, Gerd Hoffmann wrote: > Add flags to ObjectClass for objects which are deprecated or not secure. > Add 'deprecated' and 'not-secure' bools to ObjectTypeInfo, report in > 'qom-list-types'. Print the flags when listing devices via '-device > help'. > > Signe

Re: [PATCH v3 3/4] vga/cirrus: mark as not secure

2024-06-06 Thread Daniel P . Berrangé
On Thu, Jun 06, 2024 at 04:30:09PM +0200, Gerd Hoffmann wrote: What's the justification for declaring cirrus to be insecure ? It is shipped as a driver in RHEL for years, was the default graphics adapter for most of this time, and bugs in it are considered CVEs still. > Signed-off-by: Gerd Hoffm

[PATCH v3 1/4] qom: allow to mark objects as deprecated or not secure.

2024-06-06 Thread Gerd Hoffmann
Add flags to ObjectClass for objects which are deprecated or not secure. Add 'deprecated' and 'not-secure' bools to ObjectTypeInfo, report in 'qom-list-types'. Print the flags when listing devices via '-device help'. Signed-off-by: Gerd Hoffmann --- include/qom/object.h | 3 +++ qom/qom-qmp-cm

[PATCH v3 4/4] qdev: add device policy [RfC]

2024-06-06 Thread Gerd Hoffmann
Add policies for devices which are deprecated or not secure. There are three options: allow, warn and deny. It's implemented for devices only. Devices will probably be the main user of this. Also object_new() can't fail as of today so it's a bit hard to implement policy checking at object level,

[PATCH v3 0/4] allow to deprecate objects and devices

2024-06-06 Thread Gerd Hoffmann
Put some infrastructure in place to allow tagging objects (including devices) as deprected. Use it to mark the ohci pci host adapter and the usb hub as deprecated. v3: - switch to two properties: 'deprecated' and 'not secure' flags. - add rfc patch implementing policies for devices with flags.

[PATCH v3 3/4] vga/cirrus: mark as not secure

2024-06-06 Thread Gerd Hoffmann
Signed-off-by: Gerd Hoffmann --- hw/display/cirrus_vga.c | 1 + hw/display/cirrus_vga_isa.c | 1 + 2 files changed, 2 insertions(+) diff --git a/hw/display/cirrus_vga.c b/hw/display/cirrus_vga.c index 150883a97166..1f4c55b21415 100644 --- a/hw/display/cirrus_vga.c +++ b/hw/display/cirrus_vga

[PATCH v3 2/4] usb/hub: mark as deprecated

2024-06-06 Thread Gerd Hoffmann
The hub supports only USB 1.1. When running out of usb ports it is in almost all cases the much better choice to add another usb host adapter (or increase the number of root ports when using xhci) instead of using the usb hub. Signed-off-by: Gerd Hoffmann --- hw/usb/dev-hub.c | 1 + 1 file chan

RE: [PATCH v7 6/7] migration/multifd: implement qpl compression and decompression

2024-06-06 Thread Liu, Yuan1
> -Original Message- > From: Fabiano Rosas > Sent: Thursday, June 6, 2024 9:52 PM > To: Liu, Yuan1 ; pet...@redhat.com; > pbonz...@redhat.com; marcandre.lur...@redhat.com; berra...@redhat.com; > th...@redhat.com; phi...@linaro.org > Cc: qemu-devel@nongnu.org; Zou, Nanhai ; > shameerali.k

Re: linux-user emulation hangs during fork

2024-06-06 Thread Richard Henderson
On 6/6/24 01:27, Andreas Schwab wrote: Which ruby? $ ruby --version ruby 3.3.1 (2024-04-23 revision c56cd86388) [x86_64-linux-gnu] ruby 3.0.2p107 (2021-07-07 revision 0db68f0233) [x86_64-linux-gnu] That might have been handy to have with your original report. r~

Re: [PATCH] tracetool: Remove unused vcpu.py script

2024-06-06 Thread Zhao Liu
On Thu, Jun 06, 2024 at 12:26:31PM +0200, Philippe Mathieu-Daudé wrote: > Date: Thu, 6 Jun 2024 12:26:31 +0200 > From: Philippe Mathieu-Daudé > Subject: [PATCH] tracetool: Remove unused vcpu.py script > X-Mailer: git-send-email 2.41.0 > > vcpu.py is pointless since commit 89aafcf2a7 ("trace: > r

Re: [PATCH qemu ] hw/acpi: Fix big endian host creation of Generic Port Affinity Structures

2024-06-06 Thread Igor Mammedov
On Wed, 5 Jun 2024 19:04:55 +0100 Jonathan Cameron wrote: > Treating the HID as an integer caused it to get bit reversed > on big endian hosts running little endian guests. Treat it > as a character array instead. > > Fixes hw/acpi: Generic Port Affinity Structure Support > Tested-by: Richard H

Re: [PATCH] qapi: clarify that the default is backend dependent

2024-06-06 Thread Stefano Garzarella
On Tue, Jun 04, 2024 at 04:58:49PM GMT, Markus Armbruster wrote: Stefano Garzarella writes: On Mon, Jun 03, 2024 at 11:34:10AM GMT, Markus Armbruster wrote: Stefano Garzarella writes: The default value of the @share option of the @MemoryBackendProperties eally depends on the backend type,

[PATCH v3 5/6] Move tcg implementation of x86 get_physical_address into common helper code.

2024-06-06 Thread Don Porter
Signed-off-by: Don Porter --- target/i386/cpu.h| 42 ++ target/i386/helper.c | 515 + target/i386/tcg/sysemu/excp_helper.c | 555 +-- 3 files changed, 562 insertions(+), 550 deletions(-) diff --git a/target/i386

[PATCH v3 6/6] Convert x86_mmu_translate() to use common code.

2024-06-06 Thread Don Porter
Signed-off-by: Don Porter --- target/i386/arch_memory_mapping.c| 44 +++- target/i386/cpu.h| 5 +- target/i386/helper.c | 374 +++ target/i386/tcg/sysemu/excp_helper.c | 2 +- 4 files changed, 129 insertions(+), 296 deletions(-)

[PATCH v3 3/6] Convert 'info mem' to use generic iterator

2024-06-06 Thread Don Porter
Signed-off-by: Don Porter --- include/hw/core/sysemu-cpu-ops.h | 6 + include/monitor/monitor.h| 4 + monitor/hmp-cmds-target.c| 5 +- target/i386/cpu.c| 1 + target/i386/cpu.h| 1 + target/i386/monitor.c| 354 -

[PATCH v3 2/6] Convert 'info tlb' to use generic iterator

2024-06-06 Thread Don Porter
Signed-off-by: Don Porter --- include/hw/core/sysemu-cpu-ops.h | 7 + monitor/hmp-cmds-target.c| 1 + target/i386/cpu.h| 2 + target/i386/monitor.c| 217 ++- 4 files changed, 53 insertions(+), 174 deletions(-) diff --git a/inc

[PATCH v3 4/6] Convert x86_cpu_get_memory_mapping() to use generic iterators

2024-06-06 Thread Don Porter
Signed-off-by: Don Porter --- target/i386/arch_memory_mapping.c | 320 -- 1 file changed, 43 insertions(+), 277 deletions(-) diff --git a/target/i386/arch_memory_mapping.c b/target/i386/arch_memory_mapping.c index 562a00b5a7..b52e98133c 100644 --- a/target/i386/arch_

[PATCH v3 0/6] Rework x86 page table walks

2024-06-06 Thread Don Porter
This version of the 'info pg' command adopts Peter Maydell's request to write guest-agnostic page table iterator and accessor code, along with architecture-specific hooks. The first patch in this series contributes a generic page table iterator and an x86 instantiation. As a client, we first intro

[PATCH v3 1/6] Add an "info pg" command that prints the current page tables

2024-06-06 Thread Don Porter
The new "info pg" monitor command prints the current page table, including virtual address ranges, flag bits, and snippets of physical page numbers. Completely filled regions of the page table with compatible flags are "folded", with the result that the complete output for a freshly booted x86-64

Re: [PATCH] hw/net: cadence_gem: fix: type2_compare_x_word_0 error

2024-06-06 Thread Edgar E. Iglesias
On Thu, Jun 6, 2024 at 2:06 PM Peter Maydell wrote: > On Thu, 6 Jun 2024 at 12:04, Edgar E. Iglesias > wrote: > > > > On Thu, Jun 6, 2024 at 12:00 PM Andrew.Yuan > wrote: > >> > >> In the Cadence IP for Gigabit Ethernet MAC Part Number: IP7014 > IP Rev: R1p12 - Doc Rev: 1.3 User Guide,

[PATCH] i386/apic: Add hint on boot failure because of disabling x2APIC

2024-06-06 Thread Zhao Liu
Currently, the Q35 supports up to 4096 vCPUs (since v9.0), but for TCG cases, if x2APIC is not actively enabled to boot more than 255 vCPUs ( e.g., qemu-system-i386 -M pc-q35-9.0 -smp 666), the following error is reported: Unexpected error in apic_common_set_id() at ../hw/intc/apic_common.c:449: q

RE: [PATCH v7 6/7] migration/multifd: implement qpl compression and decompression

2024-06-06 Thread Fabiano Rosas
"Liu, Yuan1" writes: >> -Original Message- >> From: Fabiano Rosas >> Sent: Thursday, June 6, 2024 6:26 AM >> To: Liu, Yuan1 ; pet...@redhat.com; >> pbonz...@redhat.com; marcandre.lur...@redhat.com; berra...@redhat.com; >> th...@redhat.com; phi...@linaro.org >> Cc: qemu-devel@nongnu.org;

[PATCH v4 5/6] target/riscv: Reserve exception codes for sw-check and hw-err

2024-06-06 Thread Fea.Wang
Based on the priv-1.13.0, add the exception codes for Software-check and Hardware-error. Signed-off-by: Fea.Wang Reviewed-by: Frank Chang Reviewed-by: LIU Zhiwei Reviewed-by: Alistair Francis --- target/riscv/cpu_bits.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/target/riscv/cpu_bi

[PATCH v4 1/6] target/riscv: Reuse the conversion function of priv_spec

2024-06-06 Thread Fea.Wang
From: Jim Shu Public the conversion function of priv_spec in cpu.h, so that tcg-cpu.c could also use it. Signed-off-by: Jim Shu Signed-off-by: Fea.Wang Reviewed-by: Frank Chang Reviewed-by: LIU Zhiwei Reviewed-by: Alistair Francis --- target/riscv/cpu.c | 2 +- target/riscv/cpu.h

[PATCH v4 2/6] target/riscv: Define macros and variables for ss1p13

2024-06-06 Thread Fea.Wang
Add macros and variables for RISC-V privilege 1.13 support. Signed-off-by: Fea.Wang Reviewed-by: Frank Chang Reviewed-by: Weiwei Li Reviewed-by: LIU Zhiwei Reviewed-by: Alistair Francis --- target/riscv/cpu.h | 4 +++- target/riscv/cpu_cfg.h | 1 + 2 files changed, 4 insertions(+), 1 del

[PATCH v4 4/6] target/riscv: Add MEDELEGH, HEDELEGH csrs for RV32

2024-06-06 Thread Fea.Wang
Based on privileged spec 1.13, the RV32 needs to implement MEDELEGH and HEDELEGH for exception codes 32-47 for reserving and exception codes 48-63 for custom use. Add the CSR number though the implementation is just reading zero and writing ignore. Besides, for accessing HEDELEGH, it should be cont

[PATCH v4 3/6] target/riscv: Add 'P1P13' bit in SMSTATEEN0

2024-06-06 Thread Fea.Wang
Based on privilege 1.13 spec, there should be a bit56 for 'P1P13' in mstateen0 that controls access to the hedeleg. Signed-off-by: Fea.Wang Reviewed-by: Frank Chang Reviewed-by: Weiwei Li Reviewed-by: Alistair Francis --- target/riscv/cpu_bits.h | 1 + target/riscv/csr.c | 8 2

[PATCH v4 0/6] target/riscv: Support RISC-V privilege 1.13 spec

2024-06-06 Thread Fea.Wang
Based on the change log for the RISC-V privilege 1.13 spec, add the support for ss1p13. base-commit: 7a2356147f3a5faebf95dba4140247ec6e5607b1 * Reorder commits [v3] * Correct the mstateen0 for P1P13 in commit message * Refactor commit by splitting to two commits [v2] * Check HEDELEGH by hmode32

[PATCH v4 6/6] target/riscv: Support the version for ss1p13

2024-06-06 Thread Fea.Wang
Add RISC-V privilege 1.13 support. Signed-off-by: Fea.Wang Signed-off-by: Fea.Wang Reviewed-by: Frank Chang Reviewed-by: Weiwei Li Reviewed-by: LIU Zhiwei --- target/riscv/cpu.c | 6 +- target/riscv/tcg/tcg-cpu.c | 4 2 files changed, 9 insertions(+), 1 deletion(-) diff --g

Re: [PATCH v3 3/6] target/riscv: Support the version for ss1p13

2024-06-06 Thread Fea Wang
Sure, I will reorder the commits in the next patch series. Thank you Sincerely, Fea On Thu, Jun 6, 2024 at 7:58 AM Alistair Francis wrote: > On Tue, Jun 4, 2024 at 4:23 PM Fea.Wang wrote: > > > > Add RISC-V privilege 1.13 support. > > > > Signed-off-by: Fea.Wang > > Signed-off-by: Fea.Wang >

Re: [PATCH v2 0/3] semihosting: Restrict to TCG

2024-06-06 Thread Anton Johansson via
On 06/06/24, Philippe Mathieu-Daudé wrote: > Kind ping :) I'm off today, I'll take a look tomorrow morning!:) //Anton

Re: [PATCH 3/6] io/channel-rdma: support working in coroutine

2024-06-06 Thread Haris Iqbal
On Tue, Jun 4, 2024 at 2:14 PM Gonglei wrote: > > From: Jialin Wang > > It is not feasible to obtain RDMA completion queue notifications > through poll/ppoll on the rsocket fd. Therefore, we create a thread > named rpoller for each rsocket fd and two eventfds: pollin_eventfd > and pollout_eventfd

Re: [RFC PATCH v2 4/5] Revert "meson: Propagate gnutls dependency"

2024-06-06 Thread Philippe Mathieu-Daudé
On 27/5/24 12:49, Paolo Bonzini wrote: From: Akihiko Odaki This reverts commit 3eacf70bb5a83e4775ad8003cbca63a40f70c8c2. It was only needed because of duplicate objects caused by declare_dependency(link_whole: ...), and can be dropped now that meson.build specifies objects and dependencies sep

Re: [RFC PATCH v2 3/5] meson: Pass objects and dependencies to declare_dependency()

2024-06-06 Thread Philippe Mathieu-Daudé
On 27/5/24 12:49, Paolo Bonzini wrote: From: Akihiko Odaki We used to request declare_dependency() to link_whole static libraries. If a static library is a thin archive, GNU ld keeps all object files referenced by the archive open, and sometimes exceeds the open file limit. Another problem wit

Re: [RFC PATCH v2 1/5] meson: move shared_module() calls where modules are already walked

2024-06-06 Thread Philippe Mathieu-Daudé
On 27/5/24 12:49, Paolo Bonzini wrote: Signed-off-by: Paolo Bonzini --- meson.build | 34 +++--- 1 file changed, 19 insertions(+), 15 deletions(-) + if emulator_modules.length() > 0 +alias_target('modules', emulator_modules) + endif endif nm = find

Re: [PATCH v2 0/3] semihosting: Restrict to TCG

2024-06-06 Thread Philippe Mathieu-Daudé
Kind ping :) On 3/6/24 10:27, Philippe Mathieu-Daudé wrote: On 30/5/24 16:53, Philippe Mathieu-Daudé wrote: v2: Address Paolo's comment Missing review: 1 & 2 Semihosting currently uses the TCG probe_access API, so it is pointless to have it in the binary when TCG isn't. It could be impleme

[PATCH 2/3] plugins: Free CPUPluginState before destroying vCPU state

2024-06-06 Thread Philippe Mathieu-Daudé
cpu::plugin_state is allocated in cpu_common_initfn() when the vCPU state is created. Release it in cpu_common_finalize() when we are done. Signed-off-by: Philippe Mathieu-Daudé --- include/qemu/plugin.h | 3 +++ hw/core/cpu-common.c | 5 + 2 files changed, 8 insertions(+) diff --git a/inc

[PATCH 3/3] accel/tcg: Move qemu_plugin_vcpu_init__async() to plugins/

2024-06-06 Thread Philippe Mathieu-Daudé
Calling qemu_plugin_vcpu_init__async() on the vCPU thread is a detail of plugins, not relevant to TCG vCPU management. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Richard Henderson Reviewed-by: Pierrick Bouvier --- hw/core/cpu-common.c | 9 + plugins/core.c | 8 +++- 2

[PATCH 1/3] plugins: Ensure vCPU index is assigned in init/exit hooks

2024-06-06 Thread Philippe Mathieu-Daudé
Since vCPUs are hashed by their index, this index can't be uninitialized (UNASSIGNED_CPU_INDEX). Signed-off-by: Philippe Mathieu-Daudé --- plugins/core.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/plugins/core.c b/plugins/core.c index badede28cf..d339b3db4d 100644 --- a/plugins/core.c

[PATCH 0/3] plugins: Few debugging cleanups

2024-06-06 Thread Philippe Mathieu-Daudé
- Assert cpu_index is assigned in INIT/EXIT hooks - Free cpu->plugin_state - Restrict qemu_plugin_vcpu_init__async() to plugins/ Philippe Mathieu-Daudé (3): plugins: Ensure vCPU index is assigned in init/exit hooks plugins: Free CPUPluginState before destroying vCPU state accel/tcg: Move qem

[PATCH v5 09/10] hw/nvme: add reservation protocal command

2024-06-06 Thread Changqi Lu
Add reservation acquire, reservation register, reservation release and reservation report commands in the nvme device layer. By introducing these commands, this enables the nvme device to perform reservation-related tasks, including querying keys, querying reservation status, registering reservati

[PATCH v5 06/10] block/nvme: add reservation command protocol constants

2024-06-06 Thread Changqi Lu
Add constants for the NVMe persistent command protocol. The constants include the reservation command opcode and reservation type values defined in section 7 of the NVMe 2.0 specification. Signed-off-by: Changqi Lu Signed-off-by: zhenwei pi --- include/block/nvme.h | 61

[PATCH v5 02/10] block/raw: add persistent reservation in/out driver

2024-06-06 Thread Changqi Lu
Add persistent reservation in/out operations for raw driver. The following methods are implemented: bdrv_co_pr_read_keys, bdrv_co_pr_read_reservation, bdrv_co_pr_register, bdrv_co_pr_reserve, bdrv_co_pr_release, bdrv_co_pr_clear and bdrv_co_pr_preempt. Signed-off-by: Changqi Lu Signed-off-by: zhe

[PATCH v5 10/10] block/iscsi: add persistent reservation in/out driver

2024-06-06 Thread Changqi Lu
Add persistent reservation in/out operations for iscsi driver. The following methods are implemented: bdrv_co_pr_read_keys, bdrv_co_pr_read_reservation, bdrv_co_pr_register, bdrv_co_pr_reserve, bdrv_co_pr_release, bdrv_co_pr_clear and bdrv_co_pr_preempt. Signed-off-by: Changqi Lu Signed-off-by: z

[PATCH v5 05/10] hw/scsi: add persistent reservation in/out api for scsi device

2024-06-06 Thread Changqi Lu
Add persistent reservation in/out operations in the SCSI device layer. By introducing the persistent reservation in/out api, this enables the SCSI device to perform reservation-related tasks, including querying keys, querying reservation status, registering reservation keys, initiating and releasin

[PATCH v5 08/10] hw/nvme: enable ONCS and rescap function

2024-06-06 Thread Changqi Lu
This commit enables ONCS to support the reservation function at the controller level. Also enables rescap function in the namespace by detecting the supported reservation function in the backend driver. Signed-off-by: Changqi Lu Signed-off-by: zhenwei pi --- hw/nvme/ctrl.c | 3 ++- hw/nvme/ns.c

[PATCH v5 01/10] block: add persistent reservation in/out api

2024-06-06 Thread Changqi Lu
Add persistent reservation in/out operations at the block level. The following operations are included: - read_keys:retrieves the list of registered keys. - read_reservation: retrieves the current reservation status. - register: registers a new reservation key. - reserve:

[PATCH v5 04/10] scsi/util: add helper functions for persistent reservation types conversion

2024-06-06 Thread Changqi Lu
This commit introduces two helper functions that facilitate the conversion between the persistent reservation types used in the SCSI protocol and those used in the block layer. Signed-off-by: Changqi Lu Signed-off-by: zhenwei pi --- include/scsi/utils.h | 8 + scsi/utils.c | 81 +++

  1   2   3   >