Introduce new functions to remove and free no longer used fds and
fdsets.
We need those to decouple the remove/free routines from
monitor_fdset_cleanup() which will go away in the next patches.
The new functions:
- monitor_fdset_free/_if_empty() will be used when a monitor
connection closes an
https://github.com/legoater/qemu/ tags/pull-aspeed-20240617
for you to fetch changes up to 5f44521242d2fdfa190206a6be40577a58a71ef9:
MAINTAINERS: Add reviewers for ASPEED BMCs (2024-06-16 21:08:54 +0200)
aspeed queue:
* Add AST27
On 6/17/24 08:15, Philippe Mathieu-Daudé wrote:
On 17/6/24 15:07, Michael Tokarev wrote:
17.06.2024 10:19, Philippe Mathieu-Daudé wrote:
Hi Trent,
On 14/6/24 23:06, Trent Huber wrote:
Darwin uses a subtly different version of the setrlimit() syscall as
described in the COMPATIBILITY section o
Destination QEMU can setup incoming ports for two purposes: either a fresh
new incoming migration, in which QEMU will switch to SETUP for channel
establishment, or a paused postcopy migration, in which QEMU will stay in
POSTCOPY_PAUSED until kicking off the RECOVER phase.
Now the state machine wor
Most of them are not needed, we can stick with one ifdef inside
postcopy_recover_fail() so as to cover the scm right tricks only.
The tests won't run on windows anyway due to has_uffd always false.
Signed-off-by: Peter Xu
---
tests/qtest/migration-test.c | 10 ++
1 file changed, 2 insert
Make sure there will be an event for postcopy recovery, irrelevant of
whether the reconnect will success, or when the failure happens.
The added new case is to fail early in postcopy recovery, in which case it
didn't even reach RECOVER stage on src (and in real life it'll be the same
to dest, but
This patch adds a migration state on src called "postcopy-recover-setup".
The new state will describe the intermediate step starting from when the
src QEMU received a postcopy recovery request, until the migration channels
are properly established, but before the recovery process take place.
The r
QEMU uses "int" in most cases even if it stores MigrationStatus. I don't
know why, so let's try to do that right and see what blows up..
Signed-off-by: Peter Xu
---
migration/migration.h | 9 +
migration/migration.c | 24 +++-
2 files changed, 12 insertions(+), 21 d
The postcopy thread names on dest QEMU are slightly confusing, partly I'll
need to blame myself on 36f62f11e4 ("migration: Postcopy preemption
preparation on channel creation"). E.g., "fault-fast" reads like a fast
version of "fault-default", but it's actually the fast version of
"postcopy/listen"
Libvirt should always enable it, so it'll be nice qtest also cover that for
all tests. Though this patch only enables it, no extra tests are done on
these events yet.
Signed-off-by: Peter Xu
---
tests/qtest/migration-test.c | 7 +++
1 file changed, 7 insertions(+)
diff --git a/tests/qtest/
We always do the flush when finishing one round of scan, and during
complete() phase we should scan one more round making sure no dirty page
existed. In that case we shouldn't need one explicit FLUSH at the end of
complete(), as when reaching there all pages should have been flushed.
Reviewed-by:
Making sure the postcopy-recover-setup status is present in the postcopy
failure unit test. Note that it only applies to src QEMU not dest.
This also introduces the tiny but helpful migration_event_wait() helper.
Signed-off-by: Peter Xu
---
tests/qtest/migration-helpers.h | 2 ++
tests/qtest/
v2:
- Collect tags
- Patch 3
- cover all states in migration_postcopy_is_alive()
- Patch 4 (old)
- English changes [Fabiano]
- Split the migration_incoming_state_setup() cleanup into a new patch
[Fabiano]
- Drop RECOVER_SETUP in fill_destination_migration_info() [Fabiano]
- Keep using
Firstly, the "Paused" state was added in the wrong place before. The state
machine section was describing PostcopyState, rather than MigrationStatus.
Drop the Paused state descriptions.
Then in the postcopy recover session, add more information on the state
machine for MigrationStatus in the lines
On 6/17/24 06:07, Feiyang Chen wrote:
Since srai.w is a valid instruction on la32, simply remove the avail_64 check.
Fixes: c0c0461e3a06 ("target/loongarch: Add avail_64 to check la64-only
instructions")
Signed-off-by: Feiyang Chen
---
target/loongarch/tcg/insn_trans/trans_shift.c.inc | 4 --
On 6/17/24 04:51, Chinmay Rath wrote:
Hi Richard,
On 6/17/24 00:43, Richard Henderson wrote:
On 6/13/24 02:33, Chinmay Rath wrote:
+/* EA <- (ra == 0) ? 0 : GPR[ra] */
+static TCGv do_ea_calc_ra(DisasContext *ctx, int ra)
+{
+ TCGv EA;
+ if (!ra) {
+ EA = tcg_constant_tl(0);
+
On Fri, Jun 14, 2024, 7:24 AM Markus Armbruster wrote:
> John Snow writes:
>
> > Transactions have the only instance of an Errors section that isn't a
> > rST list; turn it into one.
>
> Just for consistency? Or do you have other shenanigans up your sleeve?
>
Just consistency at this precise m
On Fri, Jun 14, 2024, 6:55 AM Markus Armbruster wrote:
> John Snow writes:
>
> > If we parse all examples as QMP, we need them to conform to a standard
> > so that they render correctly. Once the QMP lexer is active for
> > examples, these will produce warning messages and fail the build.
> >
>
On 6/17/24 03:40, Chinmay Rath wrote:
static TCGv do_ea_calc_ra(DisasContext *ctx, int ra)
{
TCGv EA;
if (!ra) {
return tcg_constant_tl(0);
}
if (NARROW_MODE(ctx)) {
EA = tcg_temp_new();
tcg_gen_ext32u_tl(EA, cpu_gpr[ra]);
} else {
retu
On Fri, Jun 14, 2024, 5:46 AM Markus Armbruster wrote:
> John Snow writes:
>
> > Sphinx does not like sections without titles, because it wants to
> > convert every section into a reference. When there is no title, it
> > struggles to do this and transforms the tree inproperly.
> >
> > Depending
Hello Michael,
On 6/5/24 10:30 AM, Zhenzhong Duan wrote:
Hi,
This series introduce a HostIOMMUDevice abstraction and sub-classes.
Also HostIOMMUDeviceCaps structure in HostIOMMUDevice and a new interface
between vIOMMU and HostIOMMUDevice.
A HostIOMMUDevice is an abstraction for an assigned de
On Fri, Jun 14, 2024, 5:40 AM Markus Armbruster wrote:
> John Snow writes:
>
> > The intent here is to mark only certain definitions as visible in the
> > end-user docs.
> >
> > All commands and events are inherently visible. Everything else is
> > visible only if it is a member (or a branch mem
In this commit, create SPI controller on p10 chip and connect cs irq.
The QOM tree of pnv-spi and seeprom are.
/machine (powernv10-machine)
/chip[0] (power10_v2.0-pnv-chip)
/pib_spic[2] (pnv-spi)
/pnv-spi-bus.2 (SSI)
/xscom-spi-regs[0] (memory-region)
/machine (powernv10-machine
SPI controller device model supports a connection to a single SPI responder.
This provide access to SPI seeproms, TPM, flash device and an ADC controller.
All SPI function control is mapped into the SPI register space to enable full
control by firmware. In this commit SPI configuration component i
In this commit Write a qtest pnv-spi-seeprom-test to check the
SPI transactions between spi controller and seeprom device.
Signed-off-by: Chalapathi V
---
tests/qtest/pnv-spi-seeprom-test.c | 110 +
tests/qtest/meson.build| 1 +
2 files changed, 111 inse
Hello,
Thank You so much for reviewing patch v3.
In patch v4,
- Renamed hw/ppc/pnv_spi_controller.c to /hw/ssi/pnv_spi.c
- To improve the readability register/field names is shortened.
- SPI registers are put in array to simplify read/write method.
- In seeprom qtest generated the tmp_image to te
Add Microchip's 25CSM04 Serial EEPROM to m25p80. 25CSM04 provides 4 Mbits
of Serial EEPROM utilizing the Serial Peripheral Interface (SPI) compatible
bus. The device is organized as 524288 bytes of 8 bits each (512Kbyte) and
is optimized for use in consumer and industrial applications where reliab
In this commit SPI shift engine and sequencer logic is implemented.
Shift engine performs serialization and de-serialization according to the
control by the sequencer and according to the setup defined in the
configuration registers. Sequencer implements the main control logic and
FSM to handle dat
On Fri, Jun 14, 2024 at 4:53 AM Markus Armbruster wrote:
> John Snow writes:
>
> > This helps simplify the doc generator if it doesn't have to check for
> > undocumented members.
> >
> > Signed-off-by: John Snow
> > ---
> > scripts/qapi/parser.py | 20 ++--
> > 1 file changed,
On Mon, Jun 17, 2024 at 06:41:55AM -0400, Michael S. Tsirkin wrote:
> On Thu, Jun 13, 2024 at 04:48:02PM -0700, Nicolin Chen wrote:
> > The IORT doc defines "Number of IDs" ("id_count" in the virt-acpi-build)
> > to be "the number of IDs in the range minus one". Otherwise, Linux kernel
> > reports
On 6/17/24 00:57, gaosong wrote:
在 2024/5/28 上午5:18, Richard Henderson 写道:
Signed-off-by: Richard Henderson
---
tcg/loongarch64/tcg-insn-defs.c.inc | 6181 +--
1 file changed, 2123 insertions(+), 4058 deletions(-)
diff --git a/tcg/loongarch64/tcg-insn-defs.c.inc
b/t
On Mon, Jun 17, 2024 at 06:25:18PM +0200, Clément Léger wrote:
> Since commit 03e471c41d8b ("qemu_init: increase NOFILE soft limit on
> POSIX"), the maximum number of file descriptors that can be opened are
> raised to nofile.rlim_max. On recent debian distro, this yield a maximum
> of 1073741816 f
On 17/06/2024 18:36, Peter Maydell wrote:
> On Mon, 17 Jun 2024 at 17:25, Clément Léger wrote:
>>
>> Since commit 03e471c41d8b ("qemu_init: increase NOFILE soft limit on
>> POSIX"), the maximum number of file descriptors that can be opened are
>> raised to nofile.rlim_max. On recent debian dist
On Mon, 17 Jun 2024 at 17:25, Clément Léger wrote:
>
> Since commit 03e471c41d8b ("qemu_init: increase NOFILE soft limit on
> POSIX"), the maximum number of file descriptors that can be opened are
> raised to nofile.rlim_max. On recent debian distro, this yield a maximum
> of 1073741816 file descr
Since commit 03e471c41d8b ("qemu_init: increase NOFILE soft limit on
POSIX"), the maximum number of file descriptors that can be opened are
raised to nofile.rlim_max. On recent debian distro, this yield a maximum
of 1073741816 file descriptors. Now, when forking to start
qemu-bridge-helper, this ac
Hi Cédric,
On 6/17/24 08:33, Cédric Le Goater wrote:
> Hello,
>
> The series starts with simple changes (patch 1-4). Two of which were
> initially sent by Joao in a series adding VFIO migration support with
> vIOMMU [1].
>
> The changes following prepare VFIOContainer for QOMification, switch
> th
Disconnect mmu index computation from the current pl
as stored in env->hflags.
Signed-off-by: Richard Henderson
---
target/i386/cpu.h | 12 +++-
target/i386/cpu.c | 27 ---
2 files changed, 27 insertions(+), 12 deletions(-)
diff --git a/target/i386/cpu.h b/target
Hi Paolo,
Thanks for offering to do the work to fix the memory access issues
identified by Robert.
Here is a code dump from this weekend that I noodled with -- it is
prep work only, not intending to change any semantics, but it may
be helpful in finishing the work.
I considered adding a MemOp me
Use a structure to contain the stack parameters,
env, unwind return address, and mmu index.
Rewrite the macros into functions.
Signed-off-by: Richard Henderson
---
target/i386/tcg/seg_helper.c | 465 +++
1 file changed, 253 insertions(+), 212 deletions(-)
diff --
This truncation is now handled by MMU_*32_IDX, which is how
this was working for PUSHW/POPW, which did not use SEG_ADDL.
Signed-off-by: Richard Henderson
---
target/i386/tcg/seg_helper.c | 8 ++--
1 file changed, 2 insertions(+), 6 deletions(-)
diff --git a/target/i386/tcg/seg_helper.c b/ta
dirtylimit-dirtyrate-pull-request-20240617
for you to fetch changes up to e65152d5483b2c847ec7a947ed52650152cfdcc0:
migration/dirtyrate: Fix segmentation fault (2024-06-17 23:29:21 +0800)
dirtylimit-dirtyrate-pull-request-20240
From: Masato Imai
Since the kvm_dirty_ring_enabled function accesses a null kvm_state
pointer when the KVM acceleration parameter is not specified, running
calc_dirty_rate with the -r or -b option causes a segmentation fault.
Signed-off-by: Masato Imai
Message-ID: <20240507025010.1968881-1-...@
On Thu, Jun 13, 2024 at 10:46 AM Markus Armbruster
wrote:
> John Snow writes:
>
> > On Thu, May 16, 2024, 2:18 AM Markus Armbruster
> wrote:
> >
> >> John Snow writes:
> >>
> >> > When iterating all_sections, this is helpful to be able to distinguish
> >> > "members" from "features"; the only
On Thu, Jun 13, 2024 at 10:32 AM Markus Armbruster
wrote:
> John Snow writes:
>
> > On Thu, May 16, 2024 at 2:01 AM Markus Armbruster
> wrote:
> >
> >> John Snow writes:
> >>
> >> > If a comment immediately follows a doc block, the parser doesn't
> ignore
> >> > that token appropriately. Fix t
Hi Cédric,
On 6/17/24 08:34, Cédric Le Goater wrote:
> vfio_container_destroy() clears the resources allocated
> VFIOContainerBase object. Now that VFIOContainerBase is a QOM object,
> add an instance_finalize() handler to do the cleanup. It will be
> called through object_unref().
>
> Suggested-b
On 6/17/24 08:34, Cédric Le Goater wrote:
> Just as we did for the VFIOContainerBase object, introduce an
> instance_init() handler for the legacy VFIOContainer object and do the
> specific initialization there.
>
> Signed-off-by: Cédric Le Goater
> Reviewed-by: Zhenzhong Duan
Reviewed-by: Eri
On 6/17/24 08:34, Cédric Le Goater wrote:
> It's now empty.
>
> Signed-off-by: Cédric Le Goater
> Reviewed-by: Zhenzhong Duan
Reviewed-by: Eric Auger
Eric
> ---
> include/hw/vfio/vfio-container-base.h | 2 --
> hw/vfio/container-base.c | 5 -
> hw/vfio/container.c
On 6/17/24 08:34, Cédric Le Goater wrote:
> Instead, use VFIO_IOMMU_GET_CLASS() to get the class pointer.
>
> Signed-off-by: Cédric Le Goater
> Reviewed-by: Zhenzhong Duan
Reviewed-by: Eric Auger
Eric
> ---
> include/hw/vfio/vfio-container-base.h | 1 -
> hw/vfio/common.c
On 6/17/24 08:34, Cédric Le Goater wrote:
> Instead of allocating the container struct, create a QOM object of the
> appropriate type.
>
> Signed-off-by: Cédric Le Goater
> Reviewed-by: Zhenzhong Duan
Reviewed-by: Eric Auger
Eric
> ---
> hw/vfio/container.c | 6 +++---
> hw/vfio/iommufd.c
On 6/17/24 08:34, Cédric Le Goater wrote:
> This allows us to move the initialization code from vfio_container_init(),
> which we will soon remove.
>
> Signed-off-by: Cédric Le Goater
> Reviewed-by: Zhenzhong Duan
Reviewed-by: Eric Auger
Eric
> ---
> hw/vfio/container-base.c | 19 ++
On 6/17/24 08:34, Cédric Le Goater wrote:
> VFIOContainerBase was made a QOM interface because we believed that a
> QOM object would expose all the IOMMU backends to the QEMU machine and
> human interface. This only applies to user creatable devices or objects.
>
> Change the VFIOContainerBase n
On 17/6/24 15:07, Michael Tokarev wrote:
17.06.2024 10:19, Philippe Mathieu-Daudé wrote:
Hi Trent,
On 14/6/24 23:06, Trent Huber wrote:
Darwin uses a subtly different version of the setrlimit() syscall as
described in the COMPATIBILITY section of the macOS man page. The value
of the rlim_cur m
Hi Eric,
On Mon, May 20, 2024 at 03:30:58PM +0200, Eric Auger wrote:
>
>
> On 4/29/24 05:23, Mostafa Saleh wrote:
> > QEMU doesn's support memory attributes, so FWB is NOP, this
> > might change in the future if memory attributre would be supported.
> if mem attributes get supported
> >
> > Sign
Hi Eric,
On Mon, May 20, 2024 at 03:16:40PM +0200, Eric Auger wrote:
> Hi Mostafa,
>
> On 4/29/24 05:23, Mostafa Saleh wrote:
> > Everything is in place, add the last missing bits:
> > - Handle fault checking according to the actual PTW event and not the
> > the translation stage.
> missing the
Hi Eric,
On Mon, May 20, 2024 at 12:37:55PM +0200, Eric Auger wrote:
> Hi Mostafa,
>
> On 4/29/24 05:23, Mostafa Saleh wrote:
> > IOMMUTLBEvent only understands IOVA, for stage-2 only SMMUs keep
> > the implementation, while only notify for stage-1 invalidation
> > in case of nesting.
> >
> > Sig
Hi Eric,
On Mon, May 20, 2024 at 12:24:22PM +0200, Eric Auger wrote:
> Hi Mostafa,
>
> On 4/29/24 05:23, Mostafa Saleh wrote:
> > Some commands need rework for nesting, as they used to assume S1
> > and S2 are mutually exclusive:
> >
> > - CMD_TLBI_NH_ASID: Consider VMID if stage-2 is supported
>
Hi Eric,
On Mon, May 20, 2024 at 11:48:18AM +0200, Eric Auger wrote:
> Hi Mostafa,
>
> On 4/29/24 05:23, Mostafa Saleh wrote:
> > When nested translation is requested, do the following:
> >
> > - Translate stage-1 IPA using stage-2 to a physical address.
> stage-1 table address IPA into PA throug
On Wed, May 22, 2024 at 1:44 PM Mostafa Saleh wrote:
>
> Hi Eric,
>
> On Mon, May 20, 2024 at 10:20:43AM +0200, Eric Auger wrote:
> > Hi Mostafa,
> > On 5/16/24 17:20, Mostafa Saleh wrote:
> > > Hi Eric,
> > >
> > > On Wed, May 15, 2024 at 03:48:05PM +0200, Eric Auger wrote:
> > >> Hi Mostafa,
> >
Hi Eric,
Sorry no updates for a while, I have been away for some time,
but I am now back to working on this.
On Wed, May 15, 2024 at 02:41:42PM +0200, Eric Auger wrote:
> Hi Mostafa,
> On 4/29/24 05:23, Mostafa Saleh wrote:
> > ASID and VMID used to be uint16_t in the translation config, however,
Am 05.06.24 um 15:37 schrieb Thomas Huth:
On 29/05/2024 17.43, jro...@linux.ibm.com wrote:
From: Jared Rossi
On a panic during IPL (i.e. a device failed to boot) check for another device
to boot from, as indicated by the presence of an unused IPLB.
If an IPLB is successfully loaded, then j
On 6/17/24 08:34, Cédric Le Goater wrote:
> Since the QEMU struct type representing the VFIO container is deduced
> from the IOMMU type exposed by the host, this type should be well
> defined *before* creating the container struct. This will be necessary
> to instantiate a QOM object of the corr
On Mon, Jun 17, 2024 at 09:42:21AM GMT, Michael S. Tsirkin wrote:
On Mon, Jun 17, 2024 at 02:59:14PM +0200, Stefano Garzarella wrote:
On Mon, Jun 17, 2024 at 02:02:30PM GMT, Markus Armbruster wrote:
> Stefano Garzarella writes:
>
> > Hi Michael,
> >
> > On Wed, Jun 12, 2024 at 03:01:28PM GMT, S
On Mon, 2024-06-17 at 15:15 +0100, Peter Maydell wrote:
> On Mon, 17 Jun 2024 at 14:46, David Woodhouse wrote:
> >
> > From: David Woodhouse
> >
> > In e820_add_entry() the e820_table is reallocated with g_renew() to make
> > space for a new entry. However, fw_cfg_arch_create() just uses the ex
On Mon, Jun 17, 2024 at 4:04 PM Manos Pitsidianakis
wrote:
> I respectfully disagree and recommend taking another look at the code.
>
> The device actually performs all logic in non-unsafe methods and is
> typed instead of operating on raw integers as fields/state. The C stuff
> is the FFI boundar
On 6/17/24 08:34, Cédric Le Goater wrote:
> Rework vfio_get_iommu_class() to return a literal class name instead
> of a class object. We will need this name to instantiate the object
> later on. Since the default case asserts, remove the error report as
> QEMU will simply abort before.
>
> Signe
On 6/17/24 08:34, Cédric Le Goater wrote:
> This routine allocates the QEMU struct type representing the VFIO
> container. It is minimal currently and future changes will do more
> initialization.
>
> Signed-off-by: Cédric Le Goater
> Reviewed-by: Zhenzhong Duan
Reviewed-by: Eric Auger
Eric
On 6/17/24 08:33, Cédric Le Goater wrote:
> The 'container' pointer has no other use than its 'fd' attribute.
> Simplify the prototype to ease future changes.
>
> Signed-off-by: Cédric Le Goater
> Reviewed-by: Zhenzhong Duan
Reviewed-by: Eric Auger
Eric
> ---
> hw/vfio/container.c | 6 +++--
Hi Cédric,
On 6/17/24 08:33, Cédric Le Goater wrote:
> Assign the base container VFIOAddressSpace 'space' pointer in
> vfio_address_space_insert().
OK I get it now. Maybe in the previous patch, say that the
vfio_address_space_insert() will be enhanced with additional initializations.
>
> To be
On Mon, 17 Jun 2024 at 14:46, David Woodhouse wrote:
>
> From: David Woodhouse
>
> In e820_add_entry() the e820_table is reallocated with g_renew() to make
> space for a new entry. However, fw_cfg_arch_create() just uses the existing
> e820_table pointer.
>
> This leads to a use-after-free if any
On 6/17/24 08:33, Cédric Le Goater wrote:
> It will ease future changes.
Does it, really?
Besides
Reviewed-by: Eric Auger
Eric
>
> Signed-off-by: Cédric Le Goater
> Reviewed-by: Zhenzhong Duan
> ---
> include/hw/vfio/vfio-common.h | 2 ++
> hw/vfio/common.c | 6 ++
> hw/vf
On Mon, 17 Jun 2024 14:32, Paolo Bonzini wrote:
Il lun 17 giu 2024, 10:59 Manos Pitsidianakis <
manos.pitsidiana...@linaro.org> ha scritto:
>qdev_define_type!(c"test-device", TestDevice);
>impl ObjectImpl for TestDevice {}
>impl DeviceImpl for TestDevice {}
>
>fn main() {
>let d = TestDevi
Hi Cédric,
On 6/17/24 08:33, Cédric Le Goater wrote:
> From: Avihai Horon
>
> Extract vIOMMU code from vfio_sync_dirty_bitmap() to a new function and
> restructure the code.
>
> This is done in preparation for optimizing vIOMMU deviice dirty page
device
> tracking. No functional changes intended.
Hi Cédric,
On 6/17/24 14:34, Cédric Le Goater wrote:
> Hello Eric,
>
> On 6/17/24 1:31 PM, Eric Auger wrote:
>> Hi Cédric,
>>
>> On 6/17/24 08:33, Cédric Le Goater wrote:
>>> Since vfio_devices_dma_logging_start() takes an 'Error **' argument,
>>> best practices suggest to return a bool. See the a
hi,
subject should list the affected component, and be shorter.
ok, I will rewrite the subject:
"update the latest available idx seen by the host to event idx"
Fixes: 06b12970174 ("virtio-net: fix network stall under load")
this should come at the end.
I have submitted v2, it's at the end now.
From: David Woodhouse
In e820_add_entry() the e820_table is reallocated with g_renew() to make
space for a new entry. However, fw_cfg_arch_create() just uses the existing
e820_table pointer.
This leads to a use-after-free if anything adds a new entry after fw_cfg
is set up. Shift the addition of
On Mon, Jun 17, 2024 at 02:59:14PM +0200, Stefano Garzarella wrote:
> On Mon, Jun 17, 2024 at 02:02:30PM GMT, Markus Armbruster wrote:
> > Stefano Garzarella writes:
> >
> > > Hi Michael,
> > >
> > > On Wed, Jun 12, 2024 at 03:01:28PM GMT, Stefano Garzarella wrote:
> > > > This series should be
Since srai.w is a valid instruction on la32, simply remove the avail_64 check.
Fixes: c0c0461e3a06 ("target/loongarch: Add avail_64 to check la64-only
instructions")
Signed-off-by: Feiyang Chen
---
target/loongarch/tcg/insn_trans/trans_shift.c.inc | 4
1 file changed, 4 deletions(-)
diff
On 6/10/24 11:50, Philippe Mathieu-Daudé wrote:
Hi,
This series remove uses of Monitor in hw/ppc/,
replacing by the more generic HumanReadableText.
Care is taken to keep the commit bisectables by
updating functions one by one, also easing review.
For rationale see previous series from Daniel
On 6/14/24 11:52 AM, Eric Auger wrote:
Introduce a new HostIOMMUDevice callback that allows to
retrieve the usable IOVA ranges.
Implement this callback in the legacy VFIO and IOMMUFD VFIO
host iommu devices. This relies on the VFIODevice agent's
base container iova_ranges resource.
Signed-off-b
On Mon, Jun 17, 2024 at 04:05:07PM +0300, Konstantin Kostiuk wrote:
> Hi All,
>
> During the investigation of a possible memory leak in the `guest-exec`
> command of guest-agent, I found unexpected behavior for me. When we execute
> the `guest-exec` command with `capture-output = true`, guest-agen
17.06.2024 10:19, Philippe Mathieu-Daudé wrote:
Hi Trent,
On 14/6/24 23:06, Trent Huber wrote:
Darwin uses a subtly different version of the setrlimit() syscall as
described in the COMPATIBILITY section of the macOS man page. The value
of the rlim_cur member has been adjusted accordingly for Da
Hi All,
During the investigation of a possible memory leak in the `guest-exec`
command of guest-agent, I found unexpected behavior for me. When we execute
the `guest-exec` command with `capture-output = true`, guest-agent stores
stdout/stderr until someone calls `guest-exec-status`.
Just for test
On Mon, Jun 17, 2024 at 02:02:30PM GMT, Markus Armbruster wrote:
Stefano Garzarella writes:
Hi Michael,
On Wed, Jun 12, 2024 at 03:01:28PM GMT, Stefano Garzarella wrote:
This series should be in a good shape, in which tree should we queue it?
@Micheal would your tree be okay?
Markus sugges
07.06.2024 17:04, Dr. David Alan Gilbert пишет:
* Dr. David Alan Gilbert (d...@treblig.org) wrote:
A bunch of structs that are currently unused,
found with a simple script and a bit of eyeballing.
The only one I'm that suspicious of is the SPARC
one, where the patch which removed the use is a b
10.06.2024 09:39, Philippe Mathieu-Daudé wrote:
hmp_info_roms() was removed in commit dd98234c05 ("qapi:
introduce x-query-roms QMP command"),
hmp_info_numa() in commit 1b8ae799d8 ("qapi: introduce
x-query-numa QMP command"),
hmp_info_ramblock() in commit ca411b7c8a ("qapi: introduce
x-query-ra
On Fri, Jun 14, 2024 at 05:06:38PM -0400, Trent Huber wrote:
> Darwin uses a subtly different version of the setrlimit() syscall as
> described in the COMPATIBILITY section of the macOS man page. The value
> of the rlim_cur member has been adjusted accordingly for Darwin-based
> systems.
>
> Signe
Adding Cc's.
/mjt
29.05.2024 16:53, Frank Mehnert wrote:
The correct bitmask is cpuid_features rather than cpuid_ext_features.
---
target/i386/tcg/decode-new.c.inc | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/target/i386/tcg/decode-new.c.inc b/target/i386/tcg/decod
On 6/10/24 11:50, Philippe Mathieu-Daudé wrote:
@@ -203,10 +201,8 @@ static void spapr_xive_pic_print_info(SpaprXive *xive,
Monitor *mon)
spapr_xive_end_pic_print_info(xive, end, buf);
}
-info = human_readable_text_from_str(buf);
-mo
12.06.2024 20:04, Matheus Tavares Bernardino wrote:
Since a4c2735f35 (cpu: move Qemu[Thread|Cond] setup into common code,
2024-05-30) these fields are now allocated at cpu_common_initfn(). So
let's make sure we also free them at cpu_common_finalize().
Furthermore, the code also frees these on ro
Applied to trivial-patches, thanks!
/mjt
--
GPG Key transition (from rsa2048 to rsa4096) since 2024-04-24.
New key: rsa4096/61AD3D98ECDF2C8E 9D8B E14E 3F2A 9DD7 9199 28F1 61AD 3D98
ECDF 2C8E
Old key: rsa2048/457CE0A0804465C5 6EE1 95D1 886E 8FFB 810D 4324 457C E0A0
8044 65C5
Transition stat
04.06.2024 03:02, Zide Chen wrote:
Currently, if running "-overcommit cpu-pm=on" on hosts that don't
have MWAIT support, the MWAIT/MONITOR feature is advertised to the
guest and executing MWAIT/MONITOR on the guest triggers #UD.
Typically #UD takes priority over VM-Exit interception checks and
K
On 6/10/24 11:50, Philippe Mathieu-Daudé wrote:
@@ -198,13 +193,18 @@ static void spapr_xive_pic_print_info(SpaprXive *xive,
Monitor *mon)
if (!xive_eas_is_masked(eas)) {
uint32_t end_idx = xive_get_field64(EAS_END_INDEX, eas->w);
XiveEND *end;
+
On 6/10/24 11:50, Philippe Mathieu-Daudé wrote:
@@ -1389,8 +1392,10 @@ void xive_end_pic_print_info(XiveEND *end, uint32_t
end_idx, Monitor *mon)
if (qaddr_base) {
monitor_printf(mon, " eq:@%08"PRIx64"% 6d/%5d ^%d",
qaddr_base, qindex, qentries, qgen);
Hello Eric,
On 6/17/24 1:31 PM, Eric Auger wrote:
Hi Cédric,
On 6/17/24 08:33, Cédric Le Goater wrote:
Since vfio_devices_dma_logging_start() takes an 'Error **' argument,
best practices suggest to return a bool. See the api/error.h Rules
section. It will simplify potential changes coming afte
Am 12.06.24 um 05:17 schrieb Ethan Chen via:
Support basic functions of IOPMP specification v0.9.1 rapid-k model.
The specification url:
https://github.com/riscv-non-isa/iopmp-spec/releases/tag/v0.9.1
IOPMP check memory access from device is valid or not. This implementation uses
IOMMU to change
On Fri, 14 Jun 2024 15:08:35 +0100
Jonathan Cameron wrote:
> On Fri, 14 Jun 2024 12:57:25 +0200
> Igor Mammedov wrote:
>
> > On Thu, 6 Jun 2024 18:47:16 +0100
> > Jonathan Cameron wrote:
> >
> > > On Thu, 6 Jun 2024 16:06:53 +0200
> > > Igor Mammedov wrote:
> > >
> > > > On Wed, 5 Jun
Stefano Garzarella writes:
> Hi Michael,
>
> On Wed, Jun 12, 2024 at 03:01:28PM GMT, Stefano Garzarella wrote:
>>This series should be in a good shape, in which tree should we queue it?
>>@Micheal would your tree be okay?
>
> Markus suggested a small change to patch 10, so do you want me to resen
Hi Richard,
On 6/17/24 00:43, Richard Henderson wrote:
On 6/13/24 02:33, Chinmay Rath wrote:
+/* EA <- (ra == 0) ? 0 : GPR[ra] */
+static TCGv do_ea_calc_ra(DisasContext *ctx, int ra)
+{
+ TCGv EA;
+ if (!ra) {
+ EA = tcg_constant_tl(0);
+ return EA;
+ }
+ EA = tcg_t
On 2024/06/17 19:35, Alex Bennée wrote:
Akihiko Odaki writes:
On 2024/06/05 22:35, Alex Bennée wrote:
As the latest features for virtio-gpu need a pretty recent version of
libvirglrenderer. When it is not available on the system we can use a
meson wrapper and provide it when --download is spe
Hi Cédric,
On 6/17/24 08:33, Cédric Le Goater wrote:
> From: Joao Martins
>
> Separate the changes that updates the ranges from the listener, to
s/updates/update
> make it reusable in preparation to expand its use to vIOMMU support.
>
> [ clg: - Rebased on upstream
>- Introduced vfio_dirty
101 - 200 of 273 matches
Mail list logo
