Re: [PATCH v2 1/3] migration: Support background ramblock dirty sync

2024-09-30 Thread Yong Huang
On Tue, Oct 1, 2024 at 4:41 AM Peter Xu wrote: > On Mon, Sep 30, 2024 at 01:14:26AM +0800, yong.hu...@smartx.com wrote: > > From: Hyman Huang > > > > When VM is configured with huge memory, the current throttle logic > > doesn't look like to scale, because migration_trigger_throttle() > > is onl

RE: [PATCH v6 8/8] hw/gpio/aspeed: Add test case for AST2700

2024-09-30 Thread Jamin Lin
Hi Thomas, Cedric > Subject: Re: [PATCH v6 8/8] hw/gpio/aspeed: Add test case for AST2700 > > On 30/09/2024 18.48, Cédric Le Goater wrote: > > On 9/30/24 18:36, Thomas Huth wrote: > >> On 30/09/2024 10.52, Jamin Lin wrote: > >>> Add test case to test GPIO output and input pins from A0 to D7 for >

Re: [PATCH] block/file-posix: optimize append write

2024-09-30 Thread Damien Le Moal
On 9/30/24 01:03, Sam Li wrote: > When the file-posix driver emulates append write, it holds the lock > whenever accessing wp, which limits the IO queue depth to one. > > The write IO flow can be optimized to allow concurrent writes. The lock > is held in two cases: > 1. Assumed that the write IO

Re: [PATCH] hmp: allow filtering `info tlb` entries by address on i386

2024-09-30 Thread Dr. David Alan Gilbert
* Josh Junon (ju...@oro.sh) wrote: > This change adds an optional virtual address parameter > to the `info tlb` monitor command on i386 targets, > only printing a specific entry if found. Hi Josh, > Signed-off-by: Josh Junon > --- > hmp-commands-info.hx | 5 + > target/i386/monitor.c | 45

Re: [PATCH 7/7] hmp: Add "info migrationthreads"

2024-09-30 Thread Dr. David Alan Gilbert
* Peter Xu (pet...@redhat.com) wrote: > The QMP command was added in 671326201d ("migration: Introduce interface > query-migrationthreads", v8.0). Add the HMP version of it. > > Cc: Markus Armbruster > Cc: Dr. David Alan Gilbert > Signed-off-by: Peter Xu > --- > include/monitor/hmp.h

Re: [PULL v2 00/47] riscv-to-apply queue

2024-09-30 Thread Daniel Henrique Barboza
On 9/30/24 9:10 AM, Ilya Leoshkevich wrote: On Sat, 2024-09-28 at 17:40 -0300, Daniel Henrique Barboza wrote: On 9/28/24 8:34 AM, Peter Maydell wrote: On Tue, 24 Sept 2024 at 23:18, Alistair Francis wrote: The following changes since commit 01dc65a3bc262ab1bec8fe89775e9bbfa627becb:   

[PATCH 0/2] hw/core/machine: Extract compat properties to machine-compat.c

2024-09-30 Thread Philippe Mathieu-Daudé
Extract machine compat properties to machine-compat.c, make the unit target specific to be able to compile with target specific compat properties. Philippe Mathieu-Daudé (2): hw/core/machine: Add missing 'units.h' and 'error-report.h' headers hw/core/machine: Extract compat properties to machi

[PATCH 1/2] hw/core/machine: Add missing 'units.h' and 'error-report.h' headers

2024-09-30 Thread Philippe Mathieu-Daudé
Include the missing "qemu/units.h" to fix when refactoring code: ../hw/core/machine.c:743:34: error: use of undeclared identifier 'MiB' 743 | mc->default_ram_size = 128 * MiB; | ^ ../hw/core/machine.c:750:44: error: use of undeclared identifier 'TiB

[PATCH 2/2] hw/core/machine: Extract compat properties to machine-compat.c

2024-09-30 Thread Philippe Mathieu-Daudé
Extract machine compat properties to machine-compat.c. Add the unit to the meson specific_ss[] source set so we can use target specific (poisoned) definitions. Signed-off-by: Philippe Mathieu-Daudé --- MAINTAINERS | 1 + hw/core/machine-compat.c | 287 +

[PATCH 2/3] hw/arm: Have arm_write_bootloader() take a ARMCPU argument

2024-09-30 Thread Philippe Mathieu-Daudé
The next commit will replace tswap32() calls by stl_endian_p() ones in bootloader.c. In order to do that, we'll need to know the vCPU endianness. This information is retrievable with arm_cpu_code_is_big_endian(), but we need to access CPUARMState. As a first step, pass ARMCPU as argument to arm_wri

[PATCH 0/3] hw/arm: Replace tswap32() by stl_endian_p()

2024-09-30 Thread Philippe Mathieu-Daudé
- Expose arm_cpu_code_is_big_endian() - pass ARMCPU argument to arm_write_bootloader() so we can call arm_cpu_code_is_big_endian() on it, - Replace target specific tswap32() by target agnostic stl_endian_p() Tested on little & big endian hosts. Philippe Mathieu-Daudé (3): target/arm: Expose a

[PATCH 3/3] hw/arm: Replace tswap32() calls by target agnostic stl_endian_p()

2024-09-30 Thread Philippe Mathieu-Daudé
Replace the target-specific tswap32() calls by stl_endian_p() which does the same but takes the endianness as argument, thus is target-agnostic. Get the vCPU endianness calling arm_cpu_code_is_big_endian(). Signed-off-by: Philippe Mathieu-Daudé --- hw/arm/boot.c| 8 +--- hw/arm/exyno

[PATCH 1/3] target/arm: Expose arm_cpu_code_is_big_endian() prototype in 'cpu.h'

2024-09-30 Thread Philippe Mathieu-Daudé
Expose arm_cpu_code_is_big_endian() so it can be used by hw/ code. Use it in few places where it was open coded. Signed-off-by: Philippe Mathieu-Daudé --- target/arm/cpu.h | 7 +++ linux-user/aarch64/cpu_loop.c | 4 ++-- linux-user/arm/cpu_loop.c | 4 ++-- target/arm/cpu.c

[PATCH] hw/sh4/r2d: Replace tswap32() by stl_endian_p()

2024-09-30 Thread Philippe Mathieu-Daudé
Replace the target-specific tswap32() calls by stl_endian_p() which does the same but takes the endianness as argument, thus is target-agnostic. Signed-off-by: Philippe Mathieu-Daudé --- Based-on: <20240930073450.33195-2-phi...@linaro.org> "qemu/bswap: Introduce ld/st_endian_p() API" --

Re: [PATCH v2 08/17] migration: Add load_finish handler and associated functions

2024-09-30 Thread Peter Xu
On Mon, Sep 30, 2024 at 09:25:54PM +0200, Maciej S. Szmigiero wrote: > On 27.09.2024 02:53, Peter Xu wrote: > > On Fri, Sep 27, 2024 at 12:34:31AM +0200, Maciej S. Szmigiero wrote: > > > On 20.09.2024 18:45, Peter Xu wrote: > > > > On Fri, Sep 20, 2024 at 05:23:08PM +0200, Maciej S. Szmigiero wrote

Re: [PATCH v1 00/14] s390x: virtio-mem support

2024-09-30 Thread Halil Pasic
On Fri, 27 Sep 2024 20:29:19 +0200 David Hildenbrand wrote: > On 27.09.24 20:20, Halil Pasic wrote: > > On Wed, 11 Sep 2024 21:09:27 +0200 > > David Hildenbrand wrote: > > > >>> Anyway, if we want to proceed with the gitlab project, would it make > >>> sense to create an org for it, so that i

Re: [PATCH] {hw/ssi,docs/system/arm}: Allwinner A10 SPI emulation

2024-09-30 Thread Strahinja Jankovic
Hi Peter, Thank you very much for the review and detailed comments. I will try to address all comments in the v2 of the patches, but I have some questions I added below. On Mon, Sep 30, 2024 at 4:45 PM Peter Maydell wrote: > On Thu, 19 Sept 2024 at 22:55, Strahinja Jankovic > wrote: > > > > T

[PATCH V2 13/13] migration: cpr-transfer mode

2024-09-30 Thread Steve Sistare
Add the cpr-transfer migration mode. Usage: qemu-system-$arch -machine anon-alloc=memfd ... start new QEMU with "-incoming -cpr-uri " Issue commands to old QEMU: migrate_set_parameter mode cpr-transfer migrate_set_parameter cpr-uri migrate -d The migrate command stops the VM, sav

Re: [PATCH v2 3/3] migration: Support responsive CPU throttle

2024-09-30 Thread Peter Xu
On Mon, Sep 30, 2024 at 01:14:28AM +0800, yong.hu...@smartx.com wrote: > From: Hyman Huang > > Currently, the convergence algorithm determines that the migration > cannot converge according to the following principle: > The dirty pages generated in current iteration exceed a specific > percentage

Re: [PATCH v2 1/3] migration: Support background ramblock dirty sync

2024-09-30 Thread Peter Xu
On Mon, Sep 30, 2024 at 01:14:26AM +0800, yong.hu...@smartx.com wrote: > From: Hyman Huang > > When VM is configured with huge memory, the current throttle logic > doesn't look like to scale, because migration_trigger_throttle() > is only called for each iteration, so it won't be invoked for a lo

Re: [PATCH v2 6/7] migration/postcopy: Use uffd helpers

2024-09-30 Thread Dr. David Alan Gilbert
* Peter Xu (pet...@redhat.com) wrote: > On Thu, Sep 19, 2024 at 02:46:25PM +0100, d...@treblig.org wrote: > > From: "Dr. David Alan Gilbert" > > > > Use the uffd_copy_page, uffd_zero_page and uffd_wakeup helpers > > rather than calling ioctl ourselves. > > > > They return -errno on error, and pr

Re: [PATCH 0/6] refactor RDMA live migration based on rsocket API

2024-09-30 Thread Peter Xu
On Mon, Sep 30, 2024 at 07:20:56PM +, Sean Hefty wrote: > > > I'm sure rsocket has its place with much smaller transfer sizes, but > > > this is very different. > > > > Is it possible to make rsocket be friendly with large buffers (>4GB) like > > the VM > > use case? > > If you can perform l

[PATCH 6/7] migration: Remove MigrationThread and threadinfo.h

2024-09-30 Thread Peter Xu
The MigrationThread struct is mostly the same as MigrationThreadInfoList, except that it's a double-linked list so removal doesn't need to remember prev pointer. That might not be necessary, especially considering that the defintion of that struct is the only thing in threadinfo.h now. Reuse Migr

[PATCH 4/7] migration: Simplify migration-threads API

2024-09-30 Thread Peter Xu
There's no need to return a thread struct, because both the add/remove APIs must be used in the working threads so tid would work. Similar to the fact we don't need to pass in tid in each call sites, we don't need the thread struct for removal too because tid is always in the context. Remove it i

Re: [PATCH] hw/sd/sdcard: Fix handling of disabled boot partitions

2024-09-30 Thread Jan Lübbe
On Mon, 2024-09-30 at 15:18 +0100, Peter Maydell wrote: > On Fri, 6 Sept 2024 at 17:51, Jan Luebbe wrote: > > > > The enable bits in the EXT_CSD_PART_CONFIG ext_csd register do *not* > > specify whether the boot partitions exist, but whether they are enabled > > for booting. Existence of the boot

Re: [PATCH v2 08/17] migration: Add load_finish handler and associated functions

2024-09-30 Thread Maciej S. Szmigiero
On 27.09.2024 02:53, Peter Xu wrote: On Fri, Sep 27, 2024 at 12:34:31AM +0200, Maciej S. Szmigiero wrote: On 20.09.2024 18:45, Peter Xu wrote: On Fri, Sep 20, 2024 at 05:23:08PM +0200, Maciej S. Szmigiero wrote: On 19.09.2024 23:11, Peter Xu wrote: On Thu, Sep 19, 2024 at 09:49:10PM +0200, Ma

[PATCH V2 03/13] migration: save cpr mode

2024-09-30 Thread Steve Sistare
Save the mode in CPR state, so the user does not need to explicitly specify it for the target. Modify migrate_mode() so it returns the incoming mode on the target. Signed-off-by: Steve Sistare --- include/migration/cpr.h | 7 +++ migration/cpr.c | 23 ++- migrat

[PATCH 5/7] migration: Add all threads with QMP query-migrationthreads

2024-09-30 Thread Peter Xu
The QMP interface query-migrationthreads lacks a lot of migration threads but only reports multifd sender threads. That's incomplete. Since I'm at this, make all threads available to the QMP responses. NOTE: there're a few changes that should fix some bugs on e.g. not unregister rcu threads on f

[PATCH 0/7] migration: query-migrationthreads enhancements and cleanups

2024-09-30 Thread Peter Xu
Prasad reported a misalignment issue with query-migrationthreads v.s. the recently migration thread name changes. So I prepared patch 1, which will make the main thread on src be named the same way reported either in pthread or QMP query-migrationthreads API. Then I found quite something missing

[PATCH 7/7] hmp: Add "info migrationthreads"

2024-09-30 Thread Peter Xu
The QMP command was added in 671326201d ("migration: Introduce interface query-migrationthreads", v8.0). Add the HMP version of it. Cc: Markus Armbruster Cc: Dr. David Alan Gilbert Signed-off-by: Peter Xu --- include/monitor/hmp.h | 1 + migration/migration-hmp-cmds.c | 25 +

[PATCH 3/7] migration: Remove thread_id in migration_threads_add()

2024-09-30 Thread Peter Xu
It always fetches the ID of the curren thread, so there's no point passing it over. Signed-off-by: Peter Xu --- migration/threadinfo.h | 2 +- migration/migration.c | 3 +-- migration/multifd.c| 2 +- migration/threadinfo.c | 5 +++-- 4 files changed, 6 insertions(+), 6 deletions(-) diff -

[PATCH 1/7] migration: Unify names of migration src main thread

2024-09-30 Thread Peter Xu
Make pthread name match with what we report in query-migrationthreads. We used to report the same, but not anymore after 60ce47675d ("migration: Rename thread debug names"). Not a huge deal but it was still good to follow. Multifd threads are still matched because at least on the src the QMP fac

[PATCH 2/7] migration: Put thread names together with macros

2024-09-30 Thread Peter Xu
Since we have places where there can be more than one reference to the thread names, time to clean up the thread names with macros so that they're even cleaner when put together. Still two functional changes below: - There's one dirty rate thread that we overlooked before, now we add that too

Re: [PATCH v2 6/7] migration/postcopy: Use uffd helpers

2024-09-30 Thread Peter Xu
On Thu, Sep 19, 2024 at 02:46:25PM +0100, d...@treblig.org wrote: > From: "Dr. David Alan Gilbert" > > Use the uffd_copy_page, uffd_zero_page and uffd_wakeup helpers > rather than calling ioctl ourselves. > > They return -errno on error, and print an error_report themselves. > I think this actua

[PATCH V2 12/13] migration: split qmp_migrate

2024-09-30 Thread Steve Sistare
Split qmp_migrate into start and finish functions. Finish will be called asynchronously in a subsequent patch, but for now, call it immediately. No functional change. Signed-off-by: Steve Sistare --- migration/migration.c | 36 1 file changed, 28 insertions

[PATCH V2 00/13] Live update: cpr-transfer

2024-09-30 Thread Steve Sistare
What? This patch series adds the live migration cpr-transfer mode, which allows the user to transfer a guest to a new QEMU instance on the same host with minimal guest pause time, by preserving guest RAM in place, albeit with new virtual addresses in new QEMU, and by preserving device file descrip

[PATCH V2 01/13] machine: alloc-anon option

2024-09-30 Thread Steve Sistare
Allocate anonymous memory using mmap MAP_ANON or memfd_create depending on the value of the anon-alloc machine property. This option applies to memory allocated as a side effect of creating various devices. It does not apply to memory-backend-objects, whether explicitly specified on the command li

Re: nested-smmuv3 topic, Sep 2024

2024-09-30 Thread Nicolin Chen
On Mon, Sep 30, 2024 at 10:45:31AM +, Shameerali Kolothum Thodi wrote: > > -Original Message- > > From: Nicolin Chen > > Sent: Thursday, September 5, 2024 9:37 PM > > To: Shameerali Kolothum Thodi > > Cc: Eric Auger ; Mostafa Saleh > > ; qemu-...@nongnu.org; qemu- > > de...@nongnu.org

[PATCH V2 05/13] physmem: preserve ram blocks for cpr

2024-09-30 Thread Steve Sistare
Save the memfd for anonymous ramblocks in CPR state, along with a name that uniquely identifies it. The block's idstr is not yet set, so it cannot be used for this purpose. Find the saved memfd in new QEMU when creating a block. QEMU hard-codes the length of some internally-created blocks, so to

[PATCH V2 08/13] migration: VMSTATE_FD

2024-09-30 Thread Steve Sistare
Define VMSTATE_FD for declaring a file descriptor field in a VMStateDescription. Signed-off-by: Steve Sistare --- include/migration/vmstate.h | 9 + migration/vmstate-types.c | 32 2 files changed, 41 insertions(+) diff --git a/include/migration/vmsta

[PATCH V2 09/13] migration: cpr-transfer save and load

2024-09-30 Thread Steve Sistare
Add functions to create a QEMUFile based on a unix URI, for saving or loading, for use by cpr-transfer mode to preserve CPR state. Signed-off-by: Steve Sistare --- include/migration/cpr.h | 3 ++ migration/cpr-transfer.c | 81 migration/meson.bu

[PATCH V2 06/13] hostmem-memfd: preserve for cpr

2024-09-30 Thread Steve Sistare
Preserve memory-backend-memfd memory objects during cpr-transfer. Signed-off-by: Steve Sistare --- backends/hostmem-memfd.c | 12 +--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/backends/hostmem-memfd.c b/backends/hostmem-memfd.c index 6a3c89a..2740222 100644 --- a/bac

[PATCH V2 04/13] migration: stop vm earlier for cpr

2024-09-30 Thread Steve Sistare
Stop the vm earlier for cpr, to guarantee consistent device state when CPR state is saved. Signed-off-by: Steve Sistare --- migration/migration.c | 22 +- 1 file changed, 13 insertions(+), 9 deletions(-) diff --git a/migration/migration.c b/migration/migration.c index df00e5

[PATCH V2 07/13] migration: SCM_RIGHTS for QEMUFile

2024-09-30 Thread Steve Sistare
Define functions to put/get file descriptors to/from a QEMUFile, for qio channels that support SCM_RIGHTS. Maintain ordering such that put(A), put(fd), put(B) followed by get(A), get(fd), get(B) always succeeds. Other get orderings may succeed but are not guaranteed. Signed-off-by: Steve Sis

[PATCH V2 11/13] migration: cpr-uri option

2024-09-30 Thread Steve Sistare
Define the cpr-uri QEMU command-line option to specify the URI from which CPR vmstate is loaded for cpr-transfer mode. Signed-off-by: Steve Sistare --- include/migration/cpr.h | 1 + migration/cpr.c | 7 +++ qemu-options.hx | 8 system/vl.c | 3 +++ 4 fil

[PATCH V2 10/13] migration: cpr-uri parameter

2024-09-30 Thread Steve Sistare
Define the cpr-uri migration parameter to specify the URI to which CPR vmstate is saved for cpr-transfer mode. Signed-off-by: Steve Sistare --- migration/migration-hmp-cmds.c | 10 ++ migration/options.c| 28 migration/options.h| 1 +

[PATCH V2 02/13] migration: cpr-state

2024-09-30 Thread Steve Sistare
CPR must save state that is needed after QEMU is restarted, when devices are realized. Thus the extra state cannot be saved in the migration stream, as objects must already exist before that stream can be loaded. Instead, define auxilliary state structures and vmstate descriptions, not associated

RE: [PATCH 0/6] refactor RDMA live migration based on rsocket API

2024-09-30 Thread Sean Hefty
> > I'm sure rsocket has its place with much smaller transfer sizes, but > > this is very different. > > Is it possible to make rsocket be friendly with large buffers (>4GB) like the > VM > use case? If you can perform large VM migrations using streaming sockets, rsockets is likely usable, but

Re: [PATCH 0/6] refactor RDMA live migration based on rsocket API

2024-09-30 Thread Peter Xu
On Sat, Sep 28, 2024 at 12:52:08PM -0500, Michael Galaxy wrote: > On 9/27/24 16:45, Sean Hefty wrote: > > !---| > >This Message Is From an External Sender > >This message came from outside your organization. > > |--

Re: Looking for help and advice on using RPMSG-over-VIRTIO

2024-09-30 Thread Doug Miller
On 9/19/2024 7:26 AM, Doug Miller wrote: I am working on adding SR-IOV for a new adapter and need to find a way to communicate between guest and host drivers without using the adapter hardware. I have been looking at RPMSG-over-VIRTIO as a way to this, but have not been able to figure out how the

Re: [PATCH v6 8/8] hw/gpio/aspeed: Add test case for AST2700

2024-09-30 Thread Thomas Huth
On 30/09/2024 18.48, Cédric Le Goater wrote: On 9/30/24 18:36, Thomas Huth wrote: On 30/09/2024 10.52, Jamin Lin wrote: Add test case to test GPIO output and input pins from A0 to D7 for AST2700. Signed-off-by: Jamin Lin ---   tests/qtest/aspeed_gpio-test.c | 77 ++

Re: [PULL 02/44] tests/functional: Convert the vexpressa9 Avocado test

2024-09-30 Thread Thomas Huth
On 30/09/2024 18.47, Peter Maydell wrote: On Wed, 25 Sept 2024 at 12:10, Thomas Huth wrote: Use the new launch_kernel function to convert this test in a simple way. Message-ID: <20240919185749.71222-3-th...@redhat.com> Reviewed-by: Richard Henderson Signed-off-by: Thomas Huth --- MAINTAIN

[PATCH] tests/functional: Switch back to the gitlab URLs for the advent calendar tests

2024-09-30 Thread Thomas Huth
Shortly after we switched to the original URLs on qemu-advent-calendar.org, the server went offline - looks like we are better off using the gitlab URLs again instead. Signed-off-by: Thomas Huth --- tests/functional/test_arm_vexpress.py| 2 +- tests/functional/test_m68k_mcf5208evb.py

Minimum sphinx version?

2024-09-30 Thread John Snow
Hi, following up from my KVM forum talk ( https://www.youtube.com/watch?v=GGbz3WwvqLw ) I wanted to ask about what version of Sphinx we could use as a minimum version to help ease the burden of modernizing our QMP docs without a long backwards compatibility tail (and hundreds of lines of compatibil

[PATCH v8 2/2] linux-user: add strace support for openat2

2024-09-30 Thread Michael Vogt
This commit adds support for the `openat2()` to `QEMU_STRACE`. It will use the `openat2.h` header if available to create user readable flags for the `resolve` argument but does not require the header otherwise. It also makes `copy_struct_from_user()` available via `qemu.h` and `open_how_ver0` via

[PATCH v8 0/2] linux-user: add openat2 support in linux-user

2024-09-30 Thread Michael Vogt
This is v8 of the openat2 support in linux-user. Thanks for the feedback from Laurent on v7, really appreciated. This version addresses the feedback for v7. It's mostly details, see the changelog below. Looking forward to your feedback/ideas! Thanks, Michael v7 -> v8 - use "tswap64(how.flags

[PATCH v8 1/2] linux-user: add openat2 support in linux-user

2024-09-30 Thread Michael Vogt
This commit adds support for the `openat2()` syscall in the `linux-user` userspace emulator. It is implemented by extracting a new helper `maybe_do_fake_open()` out of the exiting `do_guest_openat()` and share that with the new `do_guest_openat2()`. Unfortunately we cannot just make do_guest_opena

[PATCH] target/riscv: Set vtype.vill on CPU reset

2024-09-30 Thread Rob Bradford
The RISC-V unprivileged specification "31.3.11. State of Vector Extension at Reset" has a note that recommends vtype.vill be set on reset as part of ensuring that the vector extension have a consistent state at reset. This change now makes QEMU consistent with Spike which sets vtype.vill on reset.

Re: [PATCH v2 14/18] util/timer: avoid deadlock when shutting down

2024-09-30 Thread Alex Bennée
Michael Tokarev writes: > On 16.09.2024 11:53, Alex Bennée wrote: >> When we shut down a guest we disable the timers. However this can >> cause deadlock if the guest has queued some async work that is trying >> to advance system time and spins forever trying to wind time forward. >> Pay attention

Re: [PATCH v6 8/8] hw/gpio/aspeed: Add test case for AST2700

2024-09-30 Thread Cédric Le Goater
On 9/30/24 18:36, Thomas Huth wrote: On 30/09/2024 10.52, Jamin Lin wrote: Add test case to test GPIO output and input pins from A0 to D7 for AST2700. Signed-off-by: Jamin Lin ---   tests/qtest/aspeed_gpio-test.c | 77 --   tests/qtest/meson.build    |  3 ++

Re: [PULL 02/44] tests/functional: Convert the vexpressa9 Avocado test

2024-09-30 Thread Peter Maydell
On Wed, 25 Sept 2024 at 12:10, Thomas Huth wrote: > > Use the new launch_kernel function to convert this test in a simple way. > > Message-ID: <20240919185749.71222-3-th...@redhat.com> > Reviewed-by: Richard Henderson > Signed-off-by: Thomas Huth > --- > MAINTAINERS |

Re: [PATCH v6 8/8] hw/gpio/aspeed: Add test case for AST2700

2024-09-30 Thread Thomas Huth
On 30/09/2024 10.52, Jamin Lin wrote: Add test case to test GPIO output and input pins from A0 to D7 for AST2700. Signed-off-by: Jamin Lin --- tests/qtest/aspeed_gpio-test.c | 77 -- tests/qtest/meson.build| 3 ++ 2 files changed, 76 insertions(+), 4

Re: [PATCH v2 14/18] util/timer: avoid deadlock when shutting down

2024-09-30 Thread Michael Tokarev
On 16.09.2024 11:53, Alex Bennée wrote: When we shut down a guest we disable the timers. However this can cause deadlock if the guest has queued some async work that is trying to advance system time and spins forever trying to wind time forward. Pay attention to the return code and bail early if

Re: [PATCH v2] hw: fix memory leak in IRQState allocation

2024-09-30 Thread Peter Maydell
On Wed, 18 Sept 2024 at 16:44, Matheus Tavares Bernardino wrote: > > At e72a7f65c1 (hw: Move declaration of IRQState to header and add init > function, 2024-06-29), we've changed qemu_allocate_irq() to use a > combination of g_new() + object_initialize() instead of > IRQ(object_new()). The latter

Re: [PATCH 1/1] hw/ssi/xilinx_spips: Fix flash earse assert in dual parallel configuration

2024-09-30 Thread Peter Maydell
On Mon, 30 Sept 2024 at 13:38, Francisco Iglesias wrote: > > Hi Shiva, > > On the subject: > > s/earse/erase/ > > On Tue, Sep 24, 2024 at 04:50:35PM +0530, Shiva sagar Myana wrote: > > Ensure that the FIFO is checked for emptiness before popping data from it. > > Previously, the code directly popp

Re: More than 255 vcpus Windows VM setup without viommu ?

2024-09-30 Thread David Woodhouse
On Sat, 2024-09-28 at 15:59 +0100, David Woodhouse wrote: > On Tue, 2024-07-02 at 05:17 +, Sandesh Patel wrote: > > > > The error is due to invalid MSIX routing entry passed to KVM. > > > > The VM boots fine if we attach a vIOMMU but adding a vIOMMU can > > potentially result in IO performanc

Re: [PATCH v7 0/5] AWS Nitro Enclave emulation support

2024-09-30 Thread Dorjoy Chowdhury
Ping Requesting for review on this one. v7 thread URL for convenience: https://lore.kernel.org/qemu-devel/20240922094441.23802-1-dorjoychy...@gmail.com/T/#t Thanks! Regards, Dorjoy

Re: [PATCH] qom: fix NULL pointer in object_initialize_with_type()

2024-09-30 Thread Peter Maydell
On Sun, 15 Sept 2024 at 17:12, wrote: > > From: Jinliang Zheng > > Currently, object_initialize_with_type() calls > object_class_property_init_all() > before initializing Object->properties. This may cause Object->properties to > still be NULL when we call object_property_add() on Object. > > Fo

Re: [PATCH 0/6] refactor RDMA live migration based on rsocket API

2024-09-30 Thread Yu Zhang
Hello Michael, That's true. To my understanding, to ease the maintenance, Gonglei's team has taken efforts to refactorize the RDMA migration code by using rsocket. However, due to a certain limitation in rsocket, it turned out that only small VM (in terms of core number and memory) can be migrated

Re: [PATCH 1/2] hw/arm/boot: Use hooks if PSCI is disabled

2024-09-30 Thread Peter Maydell
On Mon, 23 Sept 2024 at 04:57, Sebastian Huber wrote: > > In arm_load_kernel(), use the secondary boot hooks provided by the > platform if PSCI is disabled also while booting a non-Linux kernel. > While booting Linux with PSCI disabled, provide default hooks if needed. > > In do_cpu_reset(), use t

Re: [PATCH 0/6] refactor RDMA live migration based on rsocket API

2024-09-30 Thread Michael Galaxy
On 9/29/24 17:26, Michael S. Tsirkin wrote: !---| This Message Is From an External Sender This message came from outside your organization. |---! On Sun, Sep 29

Re: [PATCH v2] docs: Mark "gluster" support in QEMU as deprecated

2024-09-30 Thread Markus Armbruster
Daniel P. Berrangé writes: > On Wed, Sep 25, 2024 at 09:15:14AM +0200, Thomas Huth wrote: >> According to https://marc.info/?l=fedora-devel-list&m=171934833215726 >> the GlusterFS development effectively ended. Thus mark it as deprecated >> in QEMU, so we can remove it in a future release if the

Re: [PATCH] {hw/ssi,docs/system/arm}: Allwinner A10 SPI emulation

2024-09-30 Thread Peter Maydell
On Thu, 19 Sept 2024 at 22:55, Strahinja Jankovic wrote: > > This patch implements Allwinner A10 SPI controller emulation. > Only master-mode functionality is implemented. > > Since U-Boot and Linux SPI drivers for Allwinner A10 perform only > byte-wide CPU access (no DMA) to the peripheral, the e

Re: [PATCH 08/13] hw/xtensa/xtfpga: Replace memcpy()+tswap32() by stl_endian_p()

2024-09-30 Thread Thomas Huth
On 30/09/2024 09.34, Philippe Mathieu-Daudé wrote: Replace a pair of memcpy() + tswap32() by stl_endian_p(), which also swap the value using target endianness. Signed-off-by: Philippe Mathieu-Daudé --- hw/xtensa/xtfpga.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git

Re: [PATCH 07/13] hw/xtensa/xtfpga: Remove TARGET_BIG_ENDIAN #ifdef'ry

2024-09-30 Thread Thomas Huth
On 30/09/2024 09.34, Philippe Mathieu-Daudé wrote: Move code evaluation from preprocessor to compiler so both if() ladders are processed. Mostly style change. Signed-off-by: Philippe Mathieu-Daudé --- hw/xtensa/xtfpga.c | 12 +++- 1 file changed, 7 insertions(+), 5 deletions(-) Rev

Re: [PATCH v3 00/12] qcow2: make subclusters discardable

2024-09-30 Thread Andrey Drobyshev
On 9/13/24 7:39 PM, Andrey Drobyshev wrote: > v2: https://lists.nongnu.org/archive/html/qemu-devel/2024-05/msg02396.html > > v2 -> v3: > * Added patch 12/12 "qcow2: add discard-subclusters option" which > makes subcluster-based discards optional; > * Added a bunch of R-b's. > > Andrey Dro

Re: [PATCH V2 0/18] s390x: Add Full Boot Order Support

2024-09-30 Thread Jared Rossi
On 9/30/24 9:14 AM, Thomas Huth wrote: On 27/09/2024 02.50, jro...@linux.ibm.com wrote: From: Jared Rossi ... Thanks, this looks already much better than the "jump back to start" stuff in v1 ! One thing I noticed while testing your patches: Booting from ISO images seems to be broken fo

Re: [PATCH] hw/sd/sdcard: Fix handling of disabled boot partitions

2024-09-30 Thread Peter Maydell
On Fri, 6 Sept 2024 at 17:51, Jan Luebbe wrote: > > The enable bits in the EXT_CSD_PART_CONFIG ext_csd register do *not* > specify whether the boot partitions exist, but whether they are enabled > for booting. Existence of the boot partitions is specified by a > EXT_CSD_BOOT_MULT != 0. > > Current

Re: [PATCH v3 3/5] block: refactor error handling of commit_iteration

2024-09-30 Thread Vladimir Sementsov-Ogievskiy
On 01.09.24 17:24, Vincent Vanlaer wrote: Signed-off-by: Vincent Vanlaer --- block/commit.c | 37 ++--- 1 file changed, 22 insertions(+), 15 deletions(-) diff --git a/block/commit.c b/block/commit.c index 9eedd1fa47..288e413be3 100644 --- a/block/commit.c +++

Re: [Bug Report][RFC PATCH 1/1] block: fix failing assert on paused VM migration

2024-09-30 Thread Andrey Drobyshev
On 9/30/24 12:25 PM, Vladimir Sementsov-Ogievskiy wrote: > [add migration maintainers] > > On 24.09.24 15:56, Andrey Drobyshev wrote: >> [...] > > I doubt that this a correct way to go. > > As far as I understand, "inactive" actually means that "storage is not > belong to qemu, but to someone el

Re: [PULL 0/7] loongarch-to-apply queue

2024-09-30 Thread Peter Maydell
On Sun, 29 Sept 2024 at 09:35, Song Gao wrote: > > The following changes since commit 3b14a767eaca3df5534a162851f04787b363670e: > > Merge tag 'qemu-openbios-20240924' of https://github.com/mcayland/qemu into > staging (2024-09-28 12:34:44 +0100) > > are available in the Git repository at: > >

Re: [PATCH 1/1] virtio-pci: fix memory_region_find for VirtIOPCIRegion's MR

2024-09-30 Thread Michael S. Tsirkin
On Tue, Sep 24, 2024 at 02:31:20PM +0200, David Hildenbrand wrote: > On 24.09.24 03:11, Gao Shiyuan wrote: > > Make sure to version your patch series. For example, via > $ git format-patch -v1 ... > > > As shown below, if a virtio PCI device is attached under a pci-bridge, the > > MR > > o

Re: [PATCH v3 2/5] block: move commit_run loop to separate function

2024-09-30 Thread Vladimir Sementsov-Ogievskiy
On 01.09.24 17:24, Vincent Vanlaer wrote: +static int commit_iteration(CommitBlockJob *s, int64_t offset, int64_t *n, void *buf) { Hmm over-80 line. Didn't you forget run ./checkpatch.pl ? -- Best regards, Vladimir

Re: [PATCH RESEND v4 0/4] target/i386: Various Hyper-V related fixes

2024-09-30 Thread Vitaly Kuznetsov
Vitaly Kuznetsov writes: > Changes since '[PATCH RESEND v3 0/3] i386: Fix Hyper-V Gen1 guests stuck > on boot with 'hv-passthrough': > > - Added "target/i386: Make sure SynIC state is really updated before KVM_RUN" > to the set. > > This is a long pending collection of fixes for various Hyp

Re: [PATCH v3 2/5] block: move commit_run loop to separate function

2024-09-30 Thread Vladimir Sementsov-Ogievskiy
On 01.09.24 17:24, Vincent Vanlaer wrote: Signed-off-by: Vincent Vanlaer --- block/commit.c | 85 -- 1 file changed, 48 insertions(+), 37 deletions(-) diff --git a/block/commit.c b/block/commit.c index 8dee25b313..9eedd1fa47 100644 --- a/block/

Re: [PATCH 17/18] pc-bios/s390x: Enable multi-device boot loop

2024-09-30 Thread Jared Rossi
On 9/30/24 9:08 AM, Thomas Huth wrote: On 27/09/2024 02.51, jro...@linux.ibm.com wrote: From: Jared Rossi Allow attempts to boot from multiple IPL devices. If the first device fails to IPL, select the pre-built IPLB for the next device in the boot order and attempt to IPL from it. Continu

Re: [PATCH 2/3] hw/ppc/sam460ex: Replace tswap32() by stl_endian_p()

2024-09-30 Thread BALATON Zoltan
On Mon, 30 Sep 2024, Philippe Mathieu-Daudé wrote: Replace the target-specific tswap32() call by stl_endian_p() which does the same but takes the endianness as argument, thus is target-agnostic. Get the vCPU endianness calling ppc_cpu_is_big_endian(). Signed-off-by: Philippe Mathieu-Daudé --- h

Re: [PATCH 17/18] pc-bios/s390x: Enable multi-device boot loop

2024-09-30 Thread Jared Rossi
On 9/30/24 8:32 AM, Thomas Huth wrote: On 27/09/2024 02.51, jro...@linux.ibm.com wrote: From: Jared Rossi   -/* - * No boot device has been specified, so we have to scan through the - * channels to find one. - */ -static void probe_boot_device(void) -{ -    int ssid, sch_no, ret; - -    for

Re: [PATCH 16/18] s390x: Rebuild IPLB for SCSI device directly from DIAG308

2024-09-30 Thread Jared Rossi
On 9/30/24 8:15 AM, Thomas Huth wrote: On 27/09/2024 02.51, jro...@linux.ibm.com wrote: From: Jared Rossi ... @@ -661,35 +629,33 @@ IplParameterBlock *s390_ipl_get_iplb(void)   return &ipl->iplb;   }   -void s390_ipl_reset_request(CPUState *cs, enum s390_reset reset_type) +static void s

Re: [PATCH 15/18] hw/s390x: Build an IPLB for each boot device

2024-09-30 Thread Jared Rossi
On 9/30/24 7:59 AM, Thomas Huth wrote: On 27/09/2024 02.51, jro...@linux.ibm.com wrote: From: Jared Rossi ... @@ -484,8 +499,8 @@ static bool s390_gen_initial_iplb(S390IPLState *ipl)   lp = S390_CCW_MACHINE(qdev_get_machine())->loadparm;   }   -    s390_ipl_convert_

Re: [PATCH 13/18] include/hw/s390x: Add include files for common IPL structs

2024-09-30 Thread Jared Rossi
On 9/30/24 6:42 AM, Thomas Huth wrote: On 27/09/2024 02.51, jro...@linux.ibm.com wrote: ... + +struct IPLBlockPVComp { +    uint64_t tweak_pref; +    uint64_t addr; +    uint64_t size; +}  QEMU_PACKED; Could you please replace the two spaces in front of QEMU_PACKED with just one place? (als

Re: [PATCH 12/18] pc-bios/s390-ccw: Enable failed IPL to return after error

2024-09-30 Thread Jared Rossi
On 9/30/24 6:11 AM, Thomas Huth wrote: On 27/09/2024 02.51, jro...@linux.ibm.com wrote: From: Jared Rossi ...   unsigned long virtio_load_direct(unsigned long rec_list1, unsigned long rec_list2, @@ -73,13 +73,13 @@ unsigned long virtio_load_direct(unsigned long rec_list1, unsigned long r

Re: [PATCH v2 03/19] qapi/block-core: Drop temporary 'prefix'

2024-09-30 Thread Vladimir Sementsov-Ogievskiy
On 30.09.24 16:23, Vladimir Sementsov-Ogievskiy wrote: On 04.09.24 14:18, Markus Armbruster wrote: Recent commit "qapi: Smarter camel_to_upper() to reduce need for 'prefix'" added a temporary 'prefix' to delay changing the generated code. Revert it.  This improves XDbgBlockGraphNodeType's gener

Re: [PATCH v3 15/22] linux-user/hppa: fix -Werror=maybe-uninitialized false-positive

2024-09-30 Thread Marc-André Lureau
Hi Laurent On Mon, Sep 30, 2024 at 4:19 PM Laurent Vivier wrote: > > CC Helge Deller > > Le 30/09/2024 à 10:14, marcandre.lur...@redhat.com a écrit : > > From: Marc-André Lureau > > > > ../linux-user/hppa/cpu_loop.c: In function ‘hppa_lws’: > > ../linux-user/hppa/cpu_loop.c:106:17: error: ‘ret’

Re: [PATCH v1 10/14] s390x/pv: check initial, not maximum RAM size

2024-09-30 Thread Claudio Imbrenda
On Mon, 30 Sep 2024 15:14:52 +0200 David Hildenbrand wrote: > On 30.09.24 13:37, Claudio Imbrenda wrote: > > On Mon, 30 Sep 2024 13:15:52 +0200 > > Christian Borntraeger wrote: > > > >> Am 24.09.24 um 22:17 schrieb David Hildenbrand: > >>> On 24.09.24 18:22, Nina Schoetterl-Glausch wrote:

Re: [PATCH v2] chardev: introduce 'reconnect-ms' and deprecate 'reconnect'

2024-09-30 Thread Vladimir Sementsov-Ogievskiy
Hi Mark-Andre! Could you please take a look? We have collected acks for QAPI changes, could this be queued? On 13.09.24 12:46, Daniil Tatianin wrote: The 'reconnect' option only allows to specify the time in seconds, which is way too long for certain workflows. We have a lightweight disk back

Re: [PATCH v2 03/19] qapi/block-core: Drop temporary 'prefix'

2024-09-30 Thread Vladimir Sementsov-Ogievskiy
On 04.09.24 14:18, Markus Armbruster wrote: Recent commit "qapi: Smarter camel_to_upper() to reduce need for 'prefix'" added a temporary 'prefix' to delay changing the generated code. Revert it. This improves XDbgBlockGraphNodeType's generated enumeration constant prefix from X_DBG_BLOCK_GRAPH_

Re: [PATCH 11/18] pc-bios/s390-ccw: Remove panics from Netboot IPL path

2024-09-30 Thread Jared Rossi
On 9/30/24 5:39 AM, Thomas Huth wrote: On 27/09/2024 02.51, jro...@linux.ibm.com wrote: From: Jared Rossi Remove panic-on-error from Netboot specific functions so that error recovery may be possible in the future. Functions that would previously panic now provide a return code. Signed-o

Re: [PATCH V2 0/18] s390x: Add Full Boot Order Support

2024-09-30 Thread Thomas Huth
On 27/09/2024 02.50, jro...@linux.ibm.com wrote: From: Jared Rossi Loosely a v2, this updated patch set is a significant rework to most aspects of the initially proposed multi-device boot order. Of particular note, the original patch set used code jumps to restart the IPL while this version doe

Re: [PATCH v1 10/14] s390x/pv: check initial, not maximum RAM size

2024-09-30 Thread David Hildenbrand
On 30.09.24 13:37, Claudio Imbrenda wrote: On Mon, 30 Sep 2024 13:15:52 +0200 Christian Borntraeger wrote: Am 24.09.24 um 22:17 schrieb David Hildenbrand: On 24.09.24 18:22, Nina Schoetterl-Glausch wrote: On Tue, 2024-09-10 at 19:58 +0200, David Hildenbrand wrote: We actually want to check

  1   2   3   >