Re: [PATCH v2 08/17] migration: Add load_finish handler and associated functions

2024-10-02 Thread Peter Xu
On Wed, Oct 02, 2024 at 10:11:33PM +0200, Maciej S. Szmigiero wrote: > On 1.10.2024 23:30, Peter Xu wrote: > > On Tue, Oct 01, 2024 at 10:41:14PM +0200, Maciej S. Szmigiero wrote: > > > On 30.09.2024 23:57, Peter Xu wrote: > > > > On Mon, Sep 30, 2024 at 09:25:54PM +0200, Maciej S. Szmigiero wrote:

Re: [PATCH v2 08/17] migration: Add load_finish handler and associated functions

2024-10-02 Thread Maciej S. Szmigiero
On 1.10.2024 23:30, Peter Xu wrote: On Tue, Oct 01, 2024 at 10:41:14PM +0200, Maciej S. Szmigiero wrote: On 30.09.2024 23:57, Peter Xu wrote: On Mon, Sep 30, 2024 at 09:25:54PM +0200, Maciej S. Szmigiero wrote: On 27.09.2024 02:53, Peter Xu wrote: On Fri, Sep 27, 2024 at 12:34:31AM +0200, Mac

Re: {PATCH] accel/tcg: Fix CPU specific unaligned behaviour

2024-10-02 Thread Helge Deller
On 10/2/24 17:47, Peter Maydell wrote: On Wed, 2 Oct 2024 at 16:35, Alex Bennée wrote: Helge Deller writes: When the emulated CPU reads or writes to a memory location a) for which no read/write permissions exists, *and* b) the access happens unaligned (non-natural alignment), then the CPU s

Re: [PATCH] qapi, machine-qmp-cmds.c: query-accelerator support

2024-10-02 Thread Daniel Henrique Barboza
On 9/27/24 7:50 AM, Daniel P. Berrangé wrote: Markus: QAPI design Qs for you at the bottom On Wed, Sep 25, 2024 at 10:19:33AM -0300, Daniel Henrique Barboza wrote: On 9/19/24 9:22 AM, Daniel P. Berrangé wrote: On Thu, Sep 19, 2024 at 08:20:56AM -0300, Daniel Henrique Barboza wrote: Add a

Re: {PATCH] accel/tcg: Fix CPU specific unaligned behaviour

2024-10-02 Thread Alex Bennée
Peter Maydell writes: > On Wed, 2 Oct 2024 at 16:35, Alex Bennée wrote: >> >> Helge Deller writes: >> >> > When the emulated CPU reads or writes to a memory location >> > a) for which no read/write permissions exists, *and* >> > b) the access happens unaligned (non-natural alignment), >> > then

Re: [PATCH v1] linux-user: Add option to run `execve`d programs through QEMU

2024-10-02 Thread Noah Goldstein
On Wed, Oct 2, 2024 at 11:39 AM Ilya Leoshkevich wrote: > > On Wed, 2024-10-02 at 09:05 -0500, Noah Goldstein wrote: > > On Wed, Oct 2, 2024 at 3:08 AM Ilya Leoshkevich > > wrote: > > > > > > On Fri, 2024-08-30 at 15:36 -0700, Noah Goldstein wrote: > > > > The new option '-qemu-children' makes it

Re: [PATCH v1] linux-user: Add option to run `execve`d programs through QEMU

2024-10-02 Thread Ilya Leoshkevich
On Wed, 2024-10-02 at 09:05 -0500, Noah Goldstein wrote: > On Wed, Oct 2, 2024 at 3:08 AM Ilya Leoshkevich > wrote: > > > > On Fri, 2024-08-30 at 15:36 -0700, Noah Goldstein wrote: > > > The new option '-qemu-children' makes it so that on `execve` the > > > child > > > process will be launch by t

Re: [PATCH v1] linux-user: Add option to run `execve`d programs through QEMU

2024-10-02 Thread Noah Goldstein
On Wed, Oct 2, 2024 at 11:35 AM Ilya Leoshkevich wrote: > > On Wed, 2024-10-02 at 11:24 -0500, Noah Goldstein wrote: > > On Wed, Oct 2, 2024 at 11:14 AM Ilya Leoshkevich > > wrote: > > > > > > On Wed, 2024-10-02 at 10:10 -0500, Noah Goldstein wrote: > > > > On Wed, Oct 2, 2024 at 9:53 AM Ilya Leo

Re: [PATCH v1] linux-user: Add option to run `execve`d programs through QEMU

2024-10-02 Thread Ilya Leoshkevich
On Wed, 2024-10-02 at 11:24 -0500, Noah Goldstein wrote: > On Wed, Oct 2, 2024 at 11:14 AM Ilya Leoshkevich > wrote: > > > > On Wed, 2024-10-02 at 10:10 -0500, Noah Goldstein wrote: > > > On Wed, Oct 2, 2024 at 9:53 AM Ilya Leoshkevich > > > > > > wrote: > > > > > > > > On Wed, 2024-10-02 at 09

Re: [PATCH v1] linux-user: Add option to run `execve`d programs through QEMU

2024-10-02 Thread Noah Goldstein
On Wed, Oct 2, 2024 at 11:14 AM Ilya Leoshkevich wrote: > > On Wed, 2024-10-02 at 10:10 -0500, Noah Goldstein wrote: > > On Wed, Oct 2, 2024 at 9:53 AM Ilya Leoshkevich > > wrote: > > > > > > On Wed, 2024-10-02 at 09:44 -0500, Noah Goldstein wrote: > > > > On Wed, Oct 2, 2024 at 9:38 AM Ilya Leos

Re: [PATCH v1] linux-user: Add option to run `execve`d programs through QEMU

2024-10-02 Thread Ilya Leoshkevich
On Wed, 2024-10-02 at 10:10 -0500, Noah Goldstein wrote: > On Wed, Oct 2, 2024 at 9:53 AM Ilya Leoshkevich > wrote: > > > > On Wed, 2024-10-02 at 09:44 -0500, Noah Goldstein wrote: > > > On Wed, Oct 2, 2024 at 9:38 AM Ilya Leoshkevich > > > > > > wrote: > > > > > > > > On Wed, 2024-10-02 at 16:

Re: [PATCH v1] linux-user: Add option to run `execve`d programs through QEMU

2024-10-02 Thread Laurent Vivier
Le 02/10/2024 à 16:53, Ilya Leoshkevich a écrit : On Wed, 2024-10-02 at 09:44 -0500, Noah Goldstein wrote: On Wed, Oct 2, 2024 at 9:38 AM Ilya Leoshkevich wrote: On Wed, 2024-10-02 at 16:08 +0200, Laurent Vivier wrote: Le 02/10/2024 à 10:08, Ilya Leoshkevich a écrit : On Fri, 2024-08-30 at

Re: {PATCH] accel/tcg: Fix CPU specific unaligned behaviour

2024-10-02 Thread Peter Maydell
On Wed, 2 Oct 2024 at 16:35, Alex Bennée wrote: > > Helge Deller writes: > > > When the emulated CPU reads or writes to a memory location > > a) for which no read/write permissions exists, *and* > > b) the access happens unaligned (non-natural alignment), > > then the CPU should either > > - trig

Re: [PATCH RFC 3/5] acpi/generic_event_device: Update GHES migration to cover hest addr

2024-10-02 Thread Peter Xu
On Wed, Oct 02, 2024 at 05:15:43PM +0200, Igor Mammedov wrote: > On Tue, 1 Oct 2024 13:42:48 +0200 > Mauro Carvalho Chehab wrote: > > > The GHES migration logic at GED should now support HEST table > > location too. > > > > Increase migration version and change needed to check for both > > ghes

Re: {PATCH] accel/tcg: Fix CPU specific unaligned behaviour

2024-10-02 Thread Alex Bennée
Helge Deller writes: > When the emulated CPU reads or writes to a memory location > a) for which no read/write permissions exists, *and* > b) the access happens unaligned (non-natural alignment), > then the CPU should either > - trigger a permission fault, or > - trigger an unalign access fault.

Re: More than 255 vcpus Windows VM setup without viommu ?

2024-10-02 Thread David Woodhouse
On Wed, 2024-10-02 at 13:33 +0200, Igor Mammedov wrote: > > It's interesting as an experiment, to prove that Windows is riddled with bugs. > (well, and it could serve as starting point to report issue to MS) > But I'd rather Microsoft fix bugs on their side, instead of putting hacks in > QEMU. Ab

Re: [PATCH] vnc: fix crash when no console attached

2024-10-02 Thread Michael Tokarev
20.08.2024 16:11, marcandre.lur...@redhat.com wrote: From: Marc-André Lureau Since commit e99441a3793b5 ("ui/curses: Do not use console_select()") qemu_text_console_put_keysym() no longer checks for NULL console argument, which leads to a later crash: Thread 1 "qemu-system-x86" received signal

Re: [PATCH 2/2] nbd/server: Allow users to adjust handshake limit in QMP

2024-10-02 Thread Eric Blake
On Wed, Oct 02, 2024 at 05:14:42PM GMT, Markus Armbruster wrote: > >> Are we confident we'll never need less than a full second? > > > > Hmm, recent "[PATCH v2] chardev: introduce 'reconnect-ms' and deprecate > > 'reconnect'" shows that at least sometimes second is not enough precision. > > > > Ma

[PATCH v3 1/2] qapi: add qom-path to BLOCK_IO_ERROR event

2024-10-02 Thread Vladimir Sementsov-Ogievskiy
We need something more reliable than "device" (which absent in modern interfaces) and "node-name" (which may absent, and actually don't specify the device, which is a source of error) to make a per-device throttling for the event in the following commit. Signed-off-by: Vladimir Sementsov-Ogievskiy

[PATCH v3 0/2] throttling for BLOCK_IO_ERROR

2024-10-02 Thread Vladimir Sementsov-Ogievskiy
v2: switch to qom-path as discriminator, for this, add patch 01. Leonid Kaplan (1): block-backend: per-device throttling of BLOCK_IO_ERROR reports Vladimir Sementsov-Ogievskiy (1): qapi: add qom-path to BLOCK_IO_ERROR event block/block-backend.c | 21 + monitor/monitor.c

[PATCH v3 2/2] block-backend: per-device throttling of BLOCK_IO_ERROR reports

2024-10-02 Thread Vladimir Sementsov-Ogievskiy
From: Leonid Kaplan BLOCK_IO_ERROR events comes from guest, so we must throttle them. We still want per-device throttling, so let's use device id as a key. Signed-off-by: Leonid Kaplan Signed-off-by: Vladimir Sementsov-Ogievskiy --- monitor/monitor.c| 7 +-- qapi/block-core.json | 2 +

Re: [PATCH RFC 3/5] acpi/generic_event_device: Update GHES migration to cover hest addr

2024-10-02 Thread Igor Mammedov
On Tue, 1 Oct 2024 13:42:48 +0200 Mauro Carvalho Chehab wrote: > The GHES migration logic at GED should now support HEST table > location too. > > Increase migration version and change needed to check for both > ghes_addr_le and hest_addr_le. > > Signed-off-by: Mauro Carvalho Chehab other th

Re: [PATCH 2/2] nbd/server: Allow users to adjust handshake limit in QMP

2024-10-02 Thread Markus Armbruster
Vladimir Sementsov-Ogievskiy writes: > On 02.10.24 16:49, Markus Armbruster wrote: >> Eric Blake writes: >> >>> Although defaulting the handshake limit to 10 seconds was a nice QoI >>> change to weed out intentionally slow clients, it can interfere with >>> integration testing done with manual

Re: [PATCH] tests/tcg/plugins: Remove remainder of the cris target

2024-10-02 Thread Alex Bennée
Thomas Huth writes: > The cris target has recently been removed (see commit 44e4075bf4 - > "target/cris: Remove the deprecated CRIS target"), but apparently this > line has been forgotten. So clean it up now. > > Signed-off-by: Thomas Huth > --- > tests/tcg/plugins/syscall.c | 1 - > 1 file cha

Re: [PATCH v1] linux-user: Add option to run `execve`d programs through QEMU

2024-10-02 Thread Noah Goldstein
On Wed, Oct 2, 2024 at 9:53 AM Ilya Leoshkevich wrote: > > On Wed, 2024-10-02 at 09:44 -0500, Noah Goldstein wrote: > > On Wed, Oct 2, 2024 at 9:38 AM Ilya Leoshkevich > > wrote: > > > > > > On Wed, 2024-10-02 at 16:08 +0200, Laurent Vivier wrote: > > > > Le 02/10/2024 à 10:08, Ilya Leoshkevich a

Plea for advice with PCIe on QEMU for iMX6 and plan to add FlexCAN controller support

2024-10-02 Thread Pavel Pisa
Dear Nikita and other, my student Matyas Bobek has chosen to work on QEMU CAN support in a frame of his study final project. We have identified iMX6 FlexCAN as the next interesting CAN controller for emulation. One of our industrial partners is using iMX6 based system with CAN and iMX6 SabreLite

Re: [PATCH] linux-user/elfload.c: keep GNU0_MAGIC in host byte order

2024-10-02 Thread Michael Tokarev
02.10.2024 16:51, Laurent Vivier wrote: Le 02/10/2024 à 11:11, Michael Tokarev a écrit : Other places of this file operate in host byte order.  Only this constant is defined as little-endian.  This does not work, for example, on s390x host when running an arm64 binary:   qemu-arm64: /usr/bin/bu

Re: [PATCH] hw/riscv/spike: Replace tswap64() by ldq_endian_p()

2024-10-02 Thread Daniel Henrique Barboza
On 10/2/24 11:44 AM, Mark Cave-Ayland wrote: On 02/10/2024 15:17, Daniel Henrique Barboza wrote: Phil, this patch breaks 'make check-avocado' in my env:    AVOCADO tests/avocado JOB ID : 2e98b3ea8b63d22f092ff73bdadfd975cbc27026 JOB LOG    : /home/danielhb/work/qemu/build/tests/results

Re: [PATCH v1] linux-user: Add option to run `execve`d programs through QEMU

2024-10-02 Thread Ilya Leoshkevich
On Wed, 2024-10-02 at 09:44 -0500, Noah Goldstein wrote: > On Wed, Oct 2, 2024 at 9:38 AM Ilya Leoshkevich > wrote: > > > > On Wed, 2024-10-02 at 16:08 +0200, Laurent Vivier wrote: > > > Le 02/10/2024 à 10:08, Ilya Leoshkevich a écrit : > > > > On Fri, 2024-08-30 at 15:36 -0700, Noah Goldstein wr

[PATCH v2] linux-user: Add option to run `execve`d programs through QEMU

2024-10-02 Thread Noah Goldstein
The new option '-qemu-children' makes it so that on `execve` the child process will be launch by the same `qemu` executable that is currently running along with its current commandline arguments. The motivation for the change is to make it so that plugins running through `qemu` can continue to run

Re: [PATCH v1] linux-user: Add option to run `execve`d programs through QEMU

2024-10-02 Thread Noah Goldstein
On Wed, Oct 2, 2024 at 9:38 AM Ilya Leoshkevich wrote: > > On Wed, 2024-10-02 at 16:08 +0200, Laurent Vivier wrote: > > Le 02/10/2024 à 10:08, Ilya Leoshkevich a écrit : > > > On Fri, 2024-08-30 at 15:36 -0700, Noah Goldstein wrote: > > > > The new option '-qemu-children' makes it so that on `exec

Re: [PATCH] hw/riscv/spike: Replace tswap64() by ldq_endian_p()

2024-10-02 Thread Mark Cave-Ayland
On 02/10/2024 15:17, Daniel Henrique Barboza wrote: Phil, this patch breaks 'make check-avocado' in my env:   AVOCADO tests/avocado JOB ID : 2e98b3ea8b63d22f092ff73bdadfd975cbc27026 JOB LOG    : /home/danielhb/work/qemu/build/tests/results/job-2024-10-02T10.48-2e98b3e/job.log  (01/15)

Re: [PATCH v9 4/7] qapi: add blockdev-replace command

2024-10-02 Thread Vladimir Sementsov-Ogievskiy
On 26.06.24 14:53, Vladimir Sementsov-Ogievskiy wrote: diff --git a/qapi/block-core.json b/qapi/block-core.json index df5e07debd..0a6f08a6e0 100644 --- a/qapi/block-core.json +++ b/qapi/block-core.json @@ -6148,3 +6148,91 @@ ## { 'struct': 'DummyBlockCoreForceArrays', 'data': { 'unused-bl

Re: [PATCH v1] linux-user: Add option to run `execve`d programs through QEMU

2024-10-02 Thread Ilya Leoshkevich
On Wed, 2024-10-02 at 16:08 +0200, Laurent Vivier wrote: > Le 02/10/2024 à 10:08, Ilya Leoshkevich a écrit : > > On Fri, 2024-08-30 at 15:36 -0700, Noah Goldstein wrote: > > > The new option '-qemu-children' makes it so that on `execve` the > > > child > > > process will be launch by the same `qemu

[PATCH] tests/tcg/plugins: Remove remainder of the cris target

2024-10-02 Thread Thomas Huth
The cris target has recently been removed (see commit 44e4075bf4 - "target/cris: Remove the deprecated CRIS target"), but apparently this line has been forgotten. So clean it up now. Signed-off-by: Thomas Huth --- tests/tcg/plugins/syscall.c | 1 - 1 file changed, 1 deletion(-) diff --git a/tes

Re: [PATCH] util/iova-tree: Remove deadcode

2024-10-02 Thread Peter Xu
On Wed, Sep 18, 2024 at 03:25:15PM +0100, d...@treblig.org wrote: > From: "Dr. David Alan Gilbert" > > iova_tree_find_address, and iova_tree_foreach have never been > used since the code was originally added by: > eecf5eedbd ("util: implement simple iova tree") > > Remove them. > > Signed-off

Re: [PATCH] hw/riscv/spike: Replace tswap64() by ldq_endian_p()

2024-10-02 Thread Daniel Henrique Barboza
Phil, this patch breaks 'make check-avocado' in my env: AVOCADO tests/avocado JOB ID : 2e98b3ea8b63d22f092ff73bdadfd975cbc27026 JOB LOG: /home/danielhb/work/qemu/build/tests/results/job-2024-10-02T10.48-2e98b3e/job.log (01/15) tests/avocado/riscv_opensbi.py:RiscvOpenSBI.test_riscv32_

Re: [PATCH RFC 2/5] acpi/ghes: Use HEST table offsets when preparing GHES records

2024-10-02 Thread Igor Mammedov
On Tue, 1 Oct 2024 13:42:47 +0200 Mauro Carvalho Chehab wrote: > There are two pointers that are needed during error injection: > > 1. The start address of the CPER block to be stored; > 2. The address of the ack, which needs a reset before next error. > > Calculate them preferrable from the H

[PATCH v3 6/7] qapi/block-core: deprecate block-job-change

2024-10-02 Thread Vladimir Sementsov-Ogievskiy
That's a first step to move on newer job-* APIs. The difference between block-job-change and job-change is in find_block_job_locked() vs find_job_locked() functions. What's different? 1. find_block_job_locked() finds only block jobs, whereas find_job_locked() finds any kind of job. job-change

[PATCH v3 3/7] qapi: block-job-change: make copy-mode parameter optional

2024-10-02 Thread Vladimir Sementsov-Ogievskiy
We are going to add more parameters to change. We want to make possible to change only one or any subset of available options. So all the options should be optional. Signed-off-by: Vladimir Sementsov-Ogievskiy Acked-by: Markus Armbruster --- block/mirror.c | 4 qapi/block-core.json |

Re: [PATCH v1] linux-user: Add option to run `execve`d programs through QEMU

2024-10-02 Thread Laurent Vivier
Le 02/10/2024 à 10:08, Ilya Leoshkevich a écrit : On Fri, 2024-08-30 at 15:36 -0700, Noah Goldstein wrote: The new option '-qemu-children' makes it so that on `execve` the child process will be launch by the same `qemu` executable that is currently running along with its current commandline argu

[PATCH v3 0/7] introduce job-change qmp command

2024-10-02 Thread Vladimir Sementsov-Ogievskiy
Hi all! Here is new job-change command - a replacement for (becoming deprecated) block-job-change, as a first step of my "[RFC 00/15] block job API" v3: 01: add a-b by Markus 03: add a-b by Markus, s/9.1/9.2/ in QAPI 05: update commit message, s/9.1/9.2/ in QAPI 06: update commit message (and sub

[PATCH v3 4/7] blockjob: move change action implementation to job from block-job

2024-10-02 Thread Vladimir Sementsov-Ogievskiy
Like for other block-job-* APIs we want have the actual functionality in job layer and make block-job-change to be a deprecated duplication of job-change in the following commit. Signed-off-by: Vladimir Sementsov-Ogievskiy --- block/mirror.c | 7 +++ blockdev.c

[PATCH v3 1/7] qapi: rename BlockJobChangeOptions to JobChangeOptions

2024-10-02 Thread Vladimir Sementsov-Ogievskiy
We are going to move change action from block-job to job implementation, and then move to job-* extenral APIs, deprecating block-job-* APIs. This commit simplifies further transition. The commit is made by command git grep -l BlockJobChangeOptions | \ xargs sed -i 's/BlockJobChangeOpt

[PATCH v3 5/7] qapi: add job-change

2024-10-02 Thread Vladimir Sementsov-Ogievskiy
Add a new-style command job-change, doing same thing as block-job-change. The aim is finally deprecate block-job-* APIs and move to job-* APIs. We add a new command to qapi/block-core.json, not to qapi/job.json to avoid resolving json file including loops for now. This all would be a lot simple to

[PATCH v3 2/7] blockjob: block_job_change_locked(): check job type

2024-10-02 Thread Vladimir Sementsov-Ogievskiy
User may specify wrong type for the job id. Let's check it. Signed-off-by: Vladimir Sementsov-Ogievskiy --- blockjob.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/blockjob.c b/blockjob.c index 8cfbb15543..788cb1e07d 100644 --- a/blockjob.c +++ b/blockjob.c @@ -319,6 +319,12 @@ void

[PATCH v3 7/7] iotests/mirror-change-copy-mode: switch to job-change command

2024-10-02 Thread Vladimir Sementsov-Ogievskiy
block-job-change is deprecated, let's move test to job-change. Signed-off-by: Vladimir Sementsov-Ogievskiy --- tests/qemu-iotests/tests/mirror-change-copy-mode | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/qemu-iotests/tests/mirror-change-copy-mode b/tests/qemu-iotes

Re: [PATCH v1] linux-user: Add option to run `execve`d programs through QEMU

2024-10-02 Thread Noah Goldstein
On Wed, Oct 2, 2024 at 3:08 AM Ilya Leoshkevich wrote: > > On Fri, 2024-08-30 at 15:36 -0700, Noah Goldstein wrote: > > The new option '-qemu-children' makes it so that on `execve` the > > child > > process will be launch by the same `qemu` executable that is > > currently > > running along with i

[PATCH] tests/functional: Bump timeout of some tests

2024-10-02 Thread Thomas Huth
These tests occasionally time out when the host system is under heavy load. Increase the timeout setting to allow for more headroom here. Signed-off-by: Thomas Huth --- tests/functional/meson.build | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/tests/functional/meso

Re: [PATCH 2/2] nbd/server: Allow users to adjust handshake limit in QMP

2024-10-02 Thread Vladimir Sementsov-Ogievskiy
On 02.10.24 16:49, Markus Armbruster wrote: Eric Blake writes: Although defaulting the handshake limit to 10 seconds was a nice QoI change to weed out intentionally slow clients, it can interfere with integration testing done with manual NBD_OPT commands over 'nbdsh --opt-mode'. Expose a QMP

[RFC v2 2/2] target/riscv: use a simplified loop to emulate rvv loads/stores only in user mode.

2024-10-02 Thread Paolo Savini
The simplified emulation of vector loads and stores that bypasses the memory probing in the vext_ldst_us helper function seem to benefit only the user mode. We therefore limit this approach to the user mode configuration. Signed-off-by: Paolo Savini --- target/riscv/vector_helper.c | 3 ++- 1 fi

[RFC v2 1/2] target/riscv: rvv: reduce the overhead for simple RISC-V vector unit-stride loads and stores

2024-10-02 Thread Paolo Savini
From: Helene CHELIN This patch improves the performance of the emulation of the RVV unit-stride loads and stores in the following cases: - when the data being loaded/stored per iteration amounts to 8 bytes or less. - when the vector length is 16 bytes (VLEN=128) and there's no grouping of the

[RFC v2 0/2] target/riscv: use a simplified loop to emulate rvv loads/stores only in user mode.

2024-10-02 Thread Paolo Savini
The new version of the patch addresses the suggestion given by Richard Handerson here: https://patchew.org/QEMU/20240717153040.11073-1-paolo.sav...@embecosm.com/20240717153040.11073-2-paolo.sav...@embecosm.com/#aff5f930-d291-4ff5-8f24-53291059d...@linaro.org about the ineffectiveness of the optim

Re: [PATCH] linux-user/elfload.c: keep GNU0_MAGIC in host byte order

2024-10-02 Thread Laurent Vivier
Le 02/10/2024 à 11:11, Michael Tokarev a écrit : Other places of this file operate in host byte order. Only this constant is defined as little-endian. This does not work, for example, on s390x host when running an arm64 binary: qemu-arm64: /usr/bin/busybox: Invalid note in PT_GNU_PROPERTY T

Re: [PATCH 2/2] nbd/server: Allow users to adjust handshake limit in QMP

2024-10-02 Thread Markus Armbruster
Eric Blake writes: > Although defaulting the handshake limit to 10 seconds was a nice QoI > change to weed out intentionally slow clients, it can interfere with > integration testing done with manual NBD_OPT commands over 'nbdsh > --opt-mode'. Expose a QMP knob 'handshake-max-secs' to allow the

Re: [PATCH RFC 0/5] Change ghes driver to use HEST-based offsets

2024-10-02 Thread Igor Mammedov
On Tue, 1 Oct 2024 13:42:45 +0200 Mauro Carvalho Chehab wrote: > This RFC series was part of the previous PR to add generic error injection > support on GHES. > > It contains only the changes of the math used to calculate offsets at > HEST table and hardware_error firmware file. > > The first

Re: [PATCH V3] arm/kvm: add support for MTE

2024-10-02 Thread Cornelia Huck
On Thu, Sep 26 2024, Gustavo Romero wrote: > Hi Cornelia and Ganapatrao, > > On 9/25/24 14:54, Cornelia Huck wrote: >> On Fri, Sep 20 2024, Ganapatrao Kulkarni >> wrote: >>> + >>> +/* >>> + * Clear MTE bits, if not enabled in KVM mode. >> Maybe add "This matches the MTE bits bei

Re: [PATCH v3 02/14] hw/display/apple-gfx: Adds PCI implementation

2024-10-02 Thread Phil Dennis-Jordan
On Wed, 2 Oct 2024 at 09:14, Akihiko Odaki wrote: > On 2024/09/28 17:57, Phil Dennis-Jordan wrote: > > This change wires up the PCI variant of the paravirtualised > > graphics device, mainly useful for x86-64 macOS guests, implemented > > by macOS's ParavirtualizedGraphics.framework. It builds on

Re: [PATCH v3 01/14] hw/display/apple-gfx: Introduce ParavirtualizedGraphics.Framework support

2024-10-02 Thread Phil Dennis-Jordan
Hi, Thanks for taking a close look at this. There are some further comments, explanations, and also a few questions inline below. Where I've not commented, I'll just go ahead and make the suggested change for v4. On Tue, 1 Oct 2024 at 11:40, Akihiko Odaki wrote: > > > This patch implements a Q

Re: [PATCH v2 03/15] acpi/ghes: simplify the per-arch caller to build HEST table

2024-10-02 Thread Igor Mammedov
On Tue, 1 Oct 2024 09:03:40 +0200 Mauro Carvalho Chehab wrote: > The GHES driver requires not only a HEST table, but also a > separate firmware file to store Error Structure records. > It can't do one without the other. > > Simplify the caller logic for it to require one function. > This prepa

Re: [PATCH v2 04/15] acpi/ghes: better handle source_id and notification

2024-10-02 Thread Igor Mammedov
On Tue, 1 Oct 2024 09:03:41 +0200 Mauro Carvalho Chehab wrote: > GHES has two fields that are stored on HEST error source > blocks: > > - notification type, which is a number defined at the ACPI spec > containing several arch-specific synchronous and assynchronous > types; > - source id, wh

Re: [PATCH v2 05/15] acpi/ghes: Fix acpi_ghes_record_errors() argument

2024-10-02 Thread Igor Mammedov
On Tue, 1 Oct 2024 09:03:42 +0200 Mauro Carvalho Chehab wrote: > Align the header file with the actual implementation of > this function, as the first argument is source ID and not > notification type. > > Signed-off-by: Mauro Carvalho Chehab > Reviewed-by: Jonathan Cameron Reviewed-by: Igor

Re: [PATCH v2 10/15] acpi/ghes: move offset calculus to a separate function

2024-10-02 Thread Igor Mammedov
On Tue, 1 Oct 2024 09:03:47 +0200 Mauro Carvalho Chehab wrote: > Currently, CPER address location is calculated as an offset of > the hardware_errors table. It is also badly named, as the > offset actually used is the address where the CPER data starts, > and not the beginning of the error sourc

Re: [PATCH 2/2] nbd/server: Allow users to adjust handshake limit in QMP

2024-10-02 Thread Vladimir Sementsov-Ogievskiy
On 09.08.24 19:14, Eric Blake wrote: Although defaulting the handshake limit to 10 seconds was a nice QoI change to weed out intentionally slow clients, it can interfere with integration testing done with manual NBD_OPT commands over 'nbdsh --opt-mode'. Expose a QMP knob 'handshake-max-secs' to

Capstone v6-Alpha is released

2024-10-02 Thread Rot127
We are very happy to announce the release of Capstone v6-Alpha1. Although it is marked as Alpha, it runs just as stable and has at least the same quality as any other release before. In fact, it should be even better because we improved our testing significantly (clang-tidy, ASAN, Valgrind, tes

Re: [PATCH v2 09/15] acpi/ghes: make the GHES record generation more generic

2024-10-02 Thread Igor Mammedov
On Tue, 1 Oct 2024 09:03:46 +0200 Mauro Carvalho Chehab wrote: > Split the code into separate functions to allow using the > common CPER filling code by different error sources. > > The generic code was moved to ghes_record_cper_errors(), > and ghes_gen_err_data_uncorrectable_recoverable() now

Re: [PATCH] target/riscv: Set vtype.vill on CPU reset

2024-10-02 Thread Daniel Henrique Barboza
On 9/30/24 1:52 PM, Rob Bradford wrote: The RISC-V unprivileged specification "31.3.11. State of Vector Extension at Reset" has a note that recommends vtype.vill be set on reset as part of ensuring that the vector extension have a consistent state at reset. This change now makes QEMU consiste

Re: Corrupt VNC display for 1366x768

2024-10-02 Thread Simon Rowe
On 02/10/2024, 13:01, "Daniel P. Berrangé" wrote: > There's a newer bug report here, but not real progress: > > https://gitlab.com/qemu-project/qemu/-/issues/90 > > 1366 is particularly problematic as it apparently can't be represented > exactly in EDID which needs a x8 multiple. Thanks for the

Re: [PATCH v2 08/15] acpi/ghes: Prepare to support multiple sources on ghes

2024-10-02 Thread Igor Mammedov
On Tue, 1 Oct 2024 09:03:45 +0200 Mauro Carvalho Chehab wrote: > The current code is actually dependent on having just one > error structure with a single source. > > As the number of sources should be arch-dependent, as it > will depend on what kind of synchronous/assynchronous > notifications

[PULL 5/5] tests/tcg/s390x: Test modifying an EXECUTE target

2024-10-02 Thread Thomas Huth
From: Ilya Leoshkevich QEMU correctly implements the tracking of EXECUTE target modifications by storing the instruction text in env->ex_value and tb->cs_base, the latter of which is used for lookups. Still, EXECUTE is a tricky corner of the s390x emulation, which can benefit from having a regre

[PULL 3/5] Remove the unused sh4eb target

2024-10-02 Thread Thomas Huth
Since the "shix" machine has been removed, the "r2d" machine is the only machine that is still available for the sh4 and sh4eb targets. However, the "r2d" machine apparently does not work in big endian mode, see here: https://lore.kernel.org/qemu-devel/87a5fwjjew.wl-ys...@users.sourceforge.jp/ S

[PULL 2/5] configs: Fix typo in the sh4-softmmu devices config file

2024-10-02 Thread Thomas Huth
This is the config file for the little endian target, so there should not be a "eb" in here. Message-ID: <20240920161045.84622-1-th...@redhat.com> Reviewed-by: Richard Henderson Reviewed-by: Yoshinori Sato Signed-off-by: Thomas Huth --- configs/devices/sh4-softmmu/default.mak | 2 +- 1 file ch

[PULL 0/5] Fix mips64el CI job + some other misc patches

2024-10-02 Thread Thomas Huth
The following changes since commit 718780d20470c66a3a36d036b29148d5809dc855: Merge tag 'pull-nvme-20241001' of https://gitlab.com/birkelund/qemu into staging (2024-10-01 11:34:07 +0100) are available in the Git repository at: https://gitlab.com/thuth/qemu.git tags/pull-request-2024-10-02 f

[PULL 4/5] qemu-timer: Remove unused timer functions

2024-10-02 Thread Thomas Huth
From: "Dr. David Alan Gilbert" qemu_clock_get_main_loop_timerlist and timerlist_get_clock have been unused since they were originally added in ff83c66ecc ("aio / timers: Split QEMUClock into QEMUClock and QEMUTimerList") Remove them. Signed-off-by: Dr. David Alan Gilbert Reviewed-by: Bernhar

[PULL 1/5] testing: bump mips64el cross to bookworm and fix package list

2024-10-02 Thread Thomas Huth
From: Alex Bennée The mips64el cross setup is very broken for bullseye which has now entered LTS support so is unlikely to be fixed. While we still can't build the container with all packages for bookworm due to a single missing dependency that will hopefully get fixed in due course. For the sake

Re: [PATCH v2 12/15] acpi/ghes: don't crash QEMU if ghes GED is not found

2024-10-02 Thread Igor Mammedov
On Tue, 1 Oct 2024 09:03:49 +0200 Mauro Carvalho Chehab wrote: > Instead, produce an error and continue working s//make error handling within ... consistent, i.e. instead abort just print a error in case ... / > > Signed-off-by: Mauro Carvalho Chehab > --- > hw/acpi/ghes.c | 5 - >

Re: [PATCH 1/2] qemu-nbd: Allow users to adjust handshake limit

2024-10-02 Thread Vladimir Sementsov-Ogievskiy
On 09.08.24 19:14, Eric Blake wrote: Although defaulting the handshake limit to 10 seconds was a nice QoI change to weed out intentionally slow clients, it can interfere with integration testing done with manual NBD_OPT commands over 'nbdsh --opt-mode'. Expose a command line option to allow the

Re: [PATCH v2 14/15] acpi/ghes: better name the offset of the hardware error firmware

2024-10-02 Thread Igor Mammedov
On Tue, 1 Oct 2024 09:03:51 +0200 Mauro Carvalho Chehab wrote: > The hardware error firmware is where HEST error structures are > stored. Those can be GHESv2, but they can also be other types. > > Better name the location of the hardware error. > > No functional changes. > > Signed-off-by: Ma

[PULL v2 00/22] -Werror=maybe-uninitialized fixes

2024-10-02 Thread marcandre . lureau
From: Marc-André Lureau The following changes since commit 062cfce8d4c077800d252b84c65da8a2dd03fd6f: Merge tag 'pull-target-arm-20241001' of https://git.linaro.org/people/pmaydell/qemu-arm into staging (2024-10-01 17:40:25 +0100) are available in the Git repository at: https://gitlab.com

Re: [PATCH v2 07/15] acpi/ghes: Change the type for source_id

2024-10-02 Thread Igor Mammedov
On Tue, 1 Oct 2024 09:03:44 +0200 Mauro Carvalho Chehab wrote: > HEST source ID is actually a 16-bit value add here spec/ver/chapter/table reference as a confirmation of above statement. > Signed-off-by: Mauro Carvalho Chehab > Reviewed-by: Jonathan Cameron > --- > hw/acpi/ghes-stub.c|

Re: [PATCH 06/13] tests/tcg/plugins: Use the ld/st_endian_p() API

2024-10-02 Thread Alex Bennée
Philippe Mathieu-Daudé writes: > Refactor to use the recently introduced ld/st_endian_p() API > No logical change intended. > > Signed-off-by: Philippe Mathieu-Daudé Acked-by: Alex Bennée -- Alex Bennée Virtualisation Tech Lead @ Linaro

Re: [PULL 00/22] -Werror=maybe-uninitialized fixes

2024-10-02 Thread Peter Maydell
On Wed, 2 Oct 2024 at 09:45, Marc-André Lureau wrote: > > Hi > > On Wed, Oct 2, 2024 at 12:43 PM Thomas Huth wrote: >> >> On 02/10/2024 10.36, marcandre.lur...@redhat.com wrote: >> > From: Marc-André Lureau >> > >> > The following changes since commit >> > 718780d20470c66a3a36d036b29148d5809dc8

Re: [PULL 00/54] target-arm queue

2024-10-02 Thread Peter Maydell
On Tue, 1 Oct 2024 at 17:39, Peter Maydell wrote: > > This pullreq has a few miscellaneous fixes, plus the > non-controversial (and largely reviewed) parts of my > series removing deprecated arm boards. (The rest of that > series I will send out a v2 for once this lands.) > > -- PMM > > The follow

Re: Corrupt VNC display for 1366x768

2024-10-02 Thread Daniel P . Berrangé
On Wed, Oct 02, 2024 at 11:09:13AM +, Simon Rowe wrote: > I've been trying to track down the cause of a glitch that affects guest VNC > consoles when the resolution is set to 1366x768. This results in a "stair > case" effect where each successive row is offset to the right by a handful of >

Re: More than 255 vcpus Windows VM setup without viommu ?

2024-10-02 Thread Igor Mammedov
On Mon, 30 Sep 2024 16:50:21 +0100 David Woodhouse wrote: > On Sat, 2024-09-28 at 15:59 +0100, David Woodhouse wrote: > > On Tue, 2024-07-02 at 05:17 +, Sandesh Patel wrote: > > > > > > The error is due to invalid MSIX routing entry passed to KVM. > > > > > > The VM boots fine if we attac

Re: [PATCH 0/3] QOM: little improvements to object_resolve_path*()

2024-10-02 Thread Paolo Bonzini
Queued, thanks. Paolo

Corrupt VNC display for 1366x768

2024-10-02 Thread Simon Rowe
I've been trying to track down the cause of a glitch that affects guest VNC consoles when the resolution is set to 1366x768. This results in a "stair case" effect where each successive row is offset to the right by a handful of pixels. I believe this is related to the fact that the horizontal re

Re: [PATCH v2 0/2] kvm: Improve register failure reports for migration

2024-10-02 Thread Paolo Bonzini
Queued, thanks. Paolo

Re: [PATCH] qemu-keymap: Release local allocation references

2024-10-02 Thread Michael Tokarev
23.07.2024 11:49, Akihiko Odaki wrote: Commit 2523baf7fb4d ("qemu-keymap: Make references to allocations static") made references to allocations static to ensure LeakSanitizer can track them. This trick unfortunately did not work with gcc version 14.0.1; that compiler is clever enough to know tha

Capstone v6-Alpha is released

2024-10-02 Thread Rot127
We are very happy to announce the release of Capstone v6-Alpha1. Although it is marked as Alpha, it runs just as stable and has at least the same quality as any other release before. In fact, it should be even better because we improved our testing significantly (clang-tidy, ASAN, Valgrind, tes

Re: [PATCH] block-backend: Remove deadcode

2024-10-02 Thread Thomas Huth
On 17/09/2024 02.20, d...@treblig.org wrote: From: "Dr. David Alan Gilbert" blk_by_public last use was removed in 2017 by c61791fc23 ("block: add aio_context field in ThrottleGroupMember") blk_activate last use was removed earlier this year by eef0bae3a7 ("migration: Remove block migrati

Re: [PATCH] hw/net/rocker: Remove unused rocker_fp_ports

2024-10-02 Thread Thomas Huth
On 19/09/2024 01.14, d...@treblig.org wrote: From: "Dr. David Alan Gilbert" rocker_fp_ports hasn't been used since it was added back in 2015. Remove it. Signed-off-by: Dr. David Alan Gilbert --- hw/net/rocker/rocker.c | 5 - hw/net/rocker/rocker.h | 1 - 2 files changed, 6 deletions(-

Re: [PATCH] hw/pci: Remove unused pcie_chassis_find_slot

2024-10-02 Thread Thomas Huth
On 19/09/2024 01.47, d...@treblig.org wrote: From: "Dr. David Alan Gilbert" pcie_chassis_find_slot has been unused since it was added. Remove it. Signed-off-by: Dr. David Alan Gilbert --- hw/pci/pcie_port.c | 10 -- include/hw/pci/pcie_port.h | 1 - 2 files changed, 11 d

Re: [PATCH] replay: Remove unused replay_disable_events

2024-10-02 Thread Thomas Huth
On 19/09/2024 01.40, d...@treblig.org wrote: From: "Dr. David Alan Gilbert" replay_disable_events has been unused since 2019's c8aa7895eb ("replay: don't drain/flush bdrv queue while RR is working") Remove it. Signed-off-by: Dr. David Alan Gilbert --- include/sysemu/replay.h | 2 -- re

Re: [PATCH] remote: Remove unused remote_iohub_finalize

2024-10-02 Thread Thomas Huth
On 19/09/2024 18.58, d...@treblig.org wrote: From: "Dr. David Alan Gilbert" remote_iohub_finalize has never been used. Remove it. Signed-off-by: Dr. David Alan Gilbert --- hw/remote/iohub.c | 13 - include/hw/remote/iohub.h | 1 - 2 files changed, 14 deletions(-) di

Re: [PATCH] vhost: Remove unused vhost_dev_{load|save}_inflight

2024-10-02 Thread Thomas Huth
On 18/09/2024 14.10, d...@treblig.org wrote: From: "Dr. David Alan Gilbert" vhost_dev_load_inflight and vhost_dev_save_inflight have been unused since they were added in 2019 by: 5ad204bf2a ("vhost-user: Support transferring inflight buffer between qemu and backend") Remove them, and their h

Re: [PATCH] ui/cursor: remove cursor_get_mono_image

2024-10-02 Thread Thomas Huth
On 17/09/2024 02.23, d...@treblig.org wrote: From: "Dr. David Alan Gilbert" cursor_get_mono_image has been unused since 2018's 0015ca5cba ("ui: remove support for SDL1.2 in favour of SDL2") Remove it. Signed-off-by: Dr. David Alan Gilbert --- include/ui/console.h | 1 - ui/cursor.c

Re: [PATCH] hw: Remove unused fw_cfg_init_io

2024-10-02 Thread Thomas Huth
On 18/09/2024 14.35, d...@treblig.org wrote: From: "Dr. David Alan Gilbert" fw_cfg_init_io has been unused since 918a7f706b ("i386: load kernel on xen using DMA") Remove it. Signed-off-by: Dr. David Alan Gilbert --- hw/nvram/fw_cfg.c | 5 - include/hw/nvram/fw_cfg.h | 1 -

Re: [PATCH] linux-user: Remove unused handle_vm86_fault

2024-10-02 Thread Thomas Huth
On 18/09/2024 16.15, d...@treblig.org wrote: From: "Dr. David Alan Gilbert" handle_vm86_fault has been unused since: 1ade5b2fed ("linux-user/i386: Split out maybe_handle_vm86_trap") Remove it, and it's local macros. Signed-off-by: Dr. David Alan Gilbert --- linux-user/user-internals.h |

Re: [PATCH] hw/char: Remove unused serial_set_frequency

2024-10-02 Thread Thomas Huth
On 18/09/2024 16.41, d...@treblig.org wrote: From: "Dr. David Alan Gilbert" serial_set_frequnecy has been unused since it was added in 2009: 038eaf82c8 ("serial: Add interface to set reference oscillator frequency") It looks like the 'baudbase' is now a property anyway so the wrapper isn't

  1   2   >