[PATCH v2 3/5] target/mips: Demacro helpers for .

2020-10-07 Thread Aleksandar Markovic
Remove function definitions via macros to achieve better code clarity. Signed-off-by: Aleksandar Markovic --- target/mips/fpu_helper.c | 104 --- 1 file changed, 81 insertions(+), 23 deletions(-) diff --git a/target/mips/fpu_helper.c b/target/mips

[PATCH v2 2/5] target/mips: Demacro helpers for MF.

2020-10-07 Thread Aleksandar Markovic
Remove function definitions via macros to achieve better code clarity. Signed-off-by: Aleksandar Markovic --- target/mips/fpu_helper.c | 63 +++- 1 file changed, 46 insertions(+), 17 deletions(-) diff --git a/target/mips/fpu_helper.c b/target/mips

[PATCH v2 5/5] MAINTAINERS: Remove myself

2020-10-07 Thread Aleksandar Markovic
. Signed-off-by: Aleksandar Markovic --- MAINTAINERS | 17 + 1 file changed, 5 insertions(+), 12 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS index e9d85cc..426f52c 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -221,11 +221,10 @@ F: hw/microblaze/ F: disas/microblaze.c

[PATCH v2 4/5] target/mips: Refactor helpers for fp comparison instructions

2020-10-07 Thread Aleksandar Markovic
This change causes slighlty better performance of emulation of fp comparison instructions via better compiler optimization of refactored code. The functionality is otherwise unchanged. Signed-off-by: Aleksandar Markovic --- target/mips/fpu_helper.c | 56

[PATCH v2 1/5] target/mips: Demacro helpers for .

2020-10-07 Thread Aleksandar Markovic
Remove function definitions via macros to achieve better code clarity. Signed-off-by: Aleksandar Markovic --- target/mips/fpu_helper.c | 61 +++- 1 file changed, 40 insertions(+), 21 deletions(-) diff --git a/target/mips/fpu_helper.c b/target/mips

[PATCH v2 0/5] target/mips: Misc patches

2020-10-07 Thread Aleksandar Markovic
A set of several, mostly FP, refactorings and improvements. v1->v2: - added a patch on MAINTAINERS Aleksandar Markovic (5): target/mips: Demacro helpers for . target/mips: Demacro helpers for MF. target/mips: Demacro helpers for . target/mips: Refactor helpers for fp compari

Re: [PATCH 03/16] target/mips/cp0_timer: Explicit unit in variable name

2020-09-30 Thread Aleksandar Markovic
On Monday, September 28, 2020, Philippe Mathieu-Daudé wrote: > Name variables holding nanoseconds with the '_ns' suffix. > > Signed-off-by: Philippe Mathieu-Daudé > --- Reviewed-by: Aleksandar Markovic > target/mips/cp0_timer.c | 19 ++- > 1 file chan

Re: [PATCH 02/16] target/mips: Move cpu_mips_get_random() with CP0 helpers

2020-09-30 Thread Aleksandar Markovic
is get_random() helper with timer specific > code. Move it back to generic CP0 helpers. > > Signed-off-by: Philippe Mathieu-Daudé > --- Reviewed-by: Aleksandar Markovic > target/mips/internal.h | 2 +- > target/mips/cp0_helper.c | 25 ++

Re: [PATCH v3 1/1] accel/tcg: Fix computing of is_write for MIPS

2020-09-28 Thread Aleksandar Markovic
On Sunday, September 27, 2020, Kele Huang wrote: > Sorry about that, I only got maintainers by './scripts/get_maintainer.pl > -f accel/tcg/user-exec.c' and missed your advice about maintainers. > In another words, I thought I had Cc'ed the TCG MIPS maintainers.  > And sorry to maintainers.  >

Re: [PATCH 1/9] scripts/performance: Refactor topN_perf.py

2020-09-18 Thread Aleksandar Markovic
of the project "TCG Continuous Benchmarking". > -# > -# Copyright (C) 2020 Ahmed Karaman > -# Copyright (C) 2020 Aleksandar Markovic com> > -# > -# This program is free software: you can redistribute it and/or modify > -# it under the terms of the GNU General Public License

Re: [PATCH V9 0/6] mips: Add Loongson-3 machine support

2020-09-17 Thread Aleksandar Markovic
here and QEMU will use the correct > type for TCG/KVM automatically. > > V1 -> V2: > 1, Add a cover letter; > 2, Improve CPU definitions; > 3, Remove LS7A-related things (Use GPEX instead); > 4, Add a description of how to run QEMU/Loongson-3. > > V2 -> V3: > 1, Fix

Re: [PATCH 7/9] tests/performance: Add nightly tests

2020-09-15 Thread Aleksandar Markovic
On Wednesday, September 2, 2020, Alex Bennée wrote: > > Ahmed Karaman writes: > > > A nightly performance testing system to monitor any change in QEMU > > performance across seventeen different targets. > > > > The system includes eight different benchmarks to provide a variety > > of testing

Re: [REPORT] Nightly Performance Tests - Sunday, September 13, 2020

2020-09-14 Thread Aleksandar Markovic
On Mon, Sep 14, 2020 at 12:52 PM Ahmed Karaman wrote: > On Mon, Sep 14, 2020 at 8:46 AM Philippe Mathieu-Daudé > wrote: > > > > Hi Ahmed, > > > > On 9/14/20 12:07 AM, Ahmed Karaman wrote: > > > Host CPU : Intel(R) Core(TM) i7-8750H CPU @ 2.20GHz > > > Host Memory : 15.49 GB > > > >

[PATCH 4/4] target/mips: Refactor helpers for fp comparison instructions

2020-09-08 Thread Aleksandar Markovic
This change causes slighlty better performance of emulation of fp comparison instructions via better compiler optimization of refactored code. The functionality is otherwise unchanged. Signed-off-by: Aleksandar Markovic --- target/mips/fpu_helper.c | 56

[PATCH 2/4] target/mips: Demacro helpers for MF.

2020-09-08 Thread Aleksandar Markovic
Remove function definitions via macros to achieve better code clarity. Signed-off-by: Aleksandar Markovic --- target/mips/fpu_helper.c | 63 +--- 1 file changed, 46 insertions(+), 17 deletions(-) diff --git a/target/mips/fpu_helper.c b/target/mips

[PATCH 1/4] target/mips: Demacro helpers for .

2020-09-08 Thread Aleksandar Markovic
Remove function definitions via macros to achieve better code clarity. Signed-off-by: Aleksandar Markovic --- target/mips/fpu_helper.c | 61 ++-- 1 file changed, 40 insertions(+), 21 deletions(-) diff --git a/target/mips/fpu_helper.c b/target/mips

[PATCH 3/4] target/mips: Demacro helpers for .

2020-09-08 Thread Aleksandar Markovic
Remove function definitions via macros to achieve better code clarity. Signed-off-by: Aleksandar Markovic --- target/mips/fpu_helper.c | 104 ++- 1 file changed, 81 insertions(+), 23 deletions(-) diff --git a/target/mips/fpu_helper.c b/target/mips

[PATCH 0/4] target/mips: Misc patches

2020-09-08 Thread Aleksandar Markovic
A set of several, mostly FP, refactorings and improvements. Aleksandar Markovic (4): target/mips: Demacro helpers for . target/mips: Demacro helpers for MF. target/mips: Demacro helpers for . target/mips: Refactor helpers for fp comparison instructions target/mips/fpu_helper.c | 276

[PATCH 1/4] target/mips: Demacro helpers for .

2020-09-08 Thread Aleksandar Markovic
Remove function definitions via macros to achieve better code clarity. Signed-off-by: Aleksandar Markovic --- target/mips/fpu_helper.c | 61 ++-- 1 file changed, 40 insertions(+), 21 deletions(-) diff --git a/target/mips/fpu_helper.c b/target/mips

[PATCH 0/4] target/mips: Misc patches

2020-09-08 Thread Aleksandar Markovic
A set of several, mostly FP, refactorings and improvements. Aleksandar Markovic (4): target/mips: Demacro helpers for . target/mips: Demacro helpers for MF. target/mips: Demacro helpers for . target/mips: Refactor helpers for fp comparison instructions target/mips/fpu_helper.c | 276

[PATCH 2/9] scripts/performance: Refactor topN_callgrind.py

2020-09-07 Thread Aleksandar Markovic
On Friday, August 28, 2020, Ahmed Karaman wrote: > - Apply pylint and flake8 formatting rules to the script. > - Use 'tempfile' instead of '/tmp' for creating temporary files. > > Reviewed-by: Aleksandar Markovic Reply Reply all Forward View Gmail in: *Mobile* | Older ve

Re: [PATCH 1/9] scripts/performance: Refactor topN_perf.py

2020-09-07 Thread Aleksandar Markovic
On Friday, August 28, 2020, Ahmed Karaman wrote: > - Apply pylint and flake8 formatting rules to the script. > - Use 'tempfile' instead of '/tmp' for creating temporary files. > > Reviewed-by: Aleksandar Markovic Reply Reply all Forward View Gmail in: *Mobile* | Older ve

Re: [PATCH 3/9] scripts/performance: Refactor dissect.py

2020-09-02 Thread Aleksandar Markovic
in functions. > > Reviewed-by: Aleksandar Markovic > Signed-off-by: Ahmed Karaman > --- > scripts/performance/dissect.py | 123 ++--- > 1 file changed, 68 insertions(+), 55 deletions(-) > > diff --git a/scripts/performance/dissect.py b/scrip

Re: [PATCH 8/9] MAINTAINERS: Add 'tests/performance' to 'Performance Tools and Tests' subsection

2020-09-02 Thread Aleksandar Markovic
On Friday, August 28, 2020, Ahmed Karaman wrote: > Add a new 'tests/performance' directory under the 'Performance Tools > and Tests' subsection. > > Reviewed-by: Aleksandar Markovic > Signed-off-by: Ahmed Karaman > --- > MAINTAINERS | 1 + > 1 file changed, 1 ins

Re: [PATCH 7/9] tests/performance: Add nightly tests

2020-09-02 Thread Aleksandar Markovic
On Friday, August 28, 2020, Ahmed Karaman wrote: > A nightly performance testing system to monitor any change in QEMU > performance across seventeen different targets. > > Reviewed-by: Aleksandar Markovic > The system includes eight different benchmarks to provide a varie

Re: [REPORT] Nightly Performance Tests - Wednesday, August 19, 2020

2020-08-22 Thread Aleksandar Markovic
or qemu-5.1, let's say. I will try re-running the tests tonight from scratch as you've suggested to > see how things will go. > > I will also add the "---" line at the beginning as you've suggested. > > Best regards, > Ahmed > > On Sat, Aug 22, 2020, 2

Re: [REPORT] Nightly Performance Tests - Wednesday, August 19, 2020

2020-08-22 Thread Aleksandar Markovic
On Saturday, August 22, 2020, Aleksandar Markovic < aleksandar.qemu.de...@gmail.com> wrote: > > > On Wednesday, August 19, 2020, Ahmed Karaman > wrote: > >> Host CPU : Intel(R) Core(TM) i7-8750H CPU @ 2.20GHz >> Host Memory : 15.49 GB >> &g

Re: [PATCH V7 for-5.2] hw/mips: Add Loongson-3 machine support (with KVM)

2020-08-22 Thread Aleksandar Markovic
On Friday, August 7, 2020, Huacai Chen wrote: > Add Loongson-3 based machine support, it use liointc as the interrupt > controler and use GPEX as the pci controller. Currently it can only work > with KVM, but we will add TCG support in future. > > Huacai, We changed our build system yesterday,

Re: [REPORT] Nightly Performance Tests - Wednesday, August 19, 2020

2020-08-22 Thread Aleksandar Markovic
On Wednesday, August 19, 2020, Ahmed Karaman wrote: > Host CPU : Intel(R) Core(TM) i7-8750H CPU @ 2.20GHz > Host Memory : 15.49 GB > > Start Time (UTC) : 2020-08-19 21:00:01 > End Time (UTC) : 2020-08-19 21:32:15 > Execution Time : 0:32:14.021998 > > Status : SUCCESS >

Re: [REPORT] [GSoC - TCG Continuous Benchmarking] [#6] Performance Comparison of Two QEMU Builds

2020-08-22 Thread Aleksandar Markovic
Hi, Ahmed. The report, and the topic in general, look quite interesting. However, I would suggest two improvements: - The title should reflect the content in a clearer way. Let's say, "Compilers and QEMU performance" would be IMHO better. The expression "two builds" is just missing the central

Re: [PATCH] linux-user: warn if trying to use qemu-mipsn32[el] with non n32 ELF

2020-08-22 Thread Aleksandar Markovic
On Saturday, August 22, 2020, Laurent Vivier wrote: > Le 22/08/2020 à 00:28, Carlo Marcelo Arenas Belón a écrit : > > While technically compatible will (depending on the CPU) hopefully fail > > later with a cryptic error: > > > > qemu: Unexpected FPU mode > > > > Provide an earlier hint of

Re: [PATCH 1/2] target/mips: Coding style update to fix checkpatch errors

2020-08-13 Thread Aleksandar Markovic
On Thursday, August 13, 2020, Kaige Li wrote: > This will help ensure that style guidelines are being maintained during > subsequent changes. > > Signed-off-by: Kaige Li > --- Agreed. Reviewed-by: Aleksandar Markovic > target/mips/transla

Re: [PATCH v2 2/2] scripts/performance: Add list_helpers.py script

2020-07-28 Thread Aleksandar Markovic
On Tuesday, July 28, 2020, Aleksandar Markovic < aleksandar.qemu.de...@gmail.com> wrote: > > > On Tuesday, July 28, 2020, Aleksandar Markovic < > aleksandar.qemu.de...@gmail.com> wrote: > >> >> >> On Thursday, July 16, 2020, Ahmed Karaman >&g

Re: [PATCH v2 2/2] scripts/performance: Add list_helpers.py script

2020-07-28 Thread Aleksandar Markovic
On Tuesday, July 28, 2020, Aleksandar Markovic < aleksandar.qemu.de...@gmail.com> wrote: > > > On Thursday, July 16, 2020, Ahmed Karaman > wrote: > >> Python script that prints executed helpers of a QEMU invocation. >> >> > Hi, Ahmed. > > You

[PATCH v2 2/2] scripts/performance: Add list_helpers.py script

2020-07-28 Thread Aleksandar Markovic
bin/env python3 > + > +# Print the executed helpers of a QEMU invocation. > +# > +# Syntax: > +# list_helpers.py [-h] -- \ > +# [] \ > +# [] > +# > +# [-h] - Print the script arguments help message. > +# > +# Example of usag

Re: [PATCH 1/1] scripts/performance: Add bisect.py script

2020-07-27 Thread Aleksandar Markovic
On Monday, July 27, 2020, John Snow wrote: > On 7/25/20 8:31 AM, Aleksandar Markovic wrote: > >> >> >> On Wednesday, July 22, 2020, Ahmed Karaman > <mailto:ahmedkhaledkara...@gmail.com>> wrote: >> >> Python script that locates the com

Re: [PATCH 1/1] scripts/performance: Add bisect.py script

2020-07-25 Thread Aleksandar Markovic
On Saturday, July 25, 2020, Ahmed Karaman wrote: > On Sat, Jul 25, 2020 at 2:31 PM Aleksandar Markovic < > aleksandar.qemu.de...@gmail.com> wrote: > >> >> Hi, Ahmed. >> >> Yes, somewhat related to John's hints on these comments, it is customary >

Re: [PATCH 1/1] scripts/performance: Add bisect.py script

2020-07-25 Thread Aleksandar Markovic
(default: Path to a GitHub QEMU clone) > +# --target TARGET - QEMU target name > +# --tool {perf,callgrind} - Underlying tool used for measurements > + > +# Example of usage: > +# bisect.py --start=fdd76fecdd --qemu=/path/to/qemu --target=ppc > --tool=perf \ > +# -- coulomb_dou

Re: [PATCH v5 2/2] hw: hyperv: vmbus: Fix 32bit compilation

2020-07-25 Thread Aleksandar Markovic
d *)(uintptr_t)(((uintptr_t)iter->map & > TARGET_PAGE_MASK) | > +off_in_page); > if (iter->dir == DMA_DIRECTION_FROM_DEVICE) { > memcpy(p, buf, cplen); > } else { > -- > 2.24.1 > > > Tested-by: Aleksandar Markovic Reviewed-by: Aleksandar Markovic It looks to me this patch should definitely be selected for 5.1.?

[PULL 0/3] MIPS + TCG Continuous Benchmarking queue for July 7th, 2020

2020-07-07 Thread Aleksandar Markovic
new one, as soon as I can, most likely tomorrow, that will fully follow Paolo's and Thomas' recommendations, no need to worry. Thanks, Aleksamdar > Thanks, > > Paolo > > Il mar 7 lug 2020, 22:20 Thomas Huth ha scritto: > >> On 07/07/2020 18.40, Aleksandar Markovic wro

[PULL 3/3] scripts/performance: Add dissect.py script

2020-07-07 Thread Aleksandar Markovic
Markovic Reviewed-by: Aleksandar Markovic Message-Id: <20200702142942.4887-2-ahmedkhaledkara...@gmail.com> --- scripts/performance/dissect.py | 165 + 1 file changed, 165 insertions(+) create mode 100755 scripts/performance/dissect.py diff --git a/s

[PULL 0/3] MIPS + TCG Continuous Benchmarking queue for July 7th, 2020

2020-07-07 Thread Aleksandar Markovic
The following changes since commit 710fb08fd297d7a92163debce1959fae8f3b6ed7: Merge remote-tracking branch 'remotes/huth-gitlab/tags/pull-request-2020-07-06' into staging (2020-07-07 12:41:15 +0100) are available in the git repository at: https://github.com/AMarkovic/qemu

Re: [PATCH] Fix MIPS add.s after 1ace099f2acb952eaaef0ba7725879949a7e4406

2020-07-07 Thread Aleksandar Markovic
On Fri, Jul 3, 2020 at 6:33 PM Alex Richardson wrote: > > After merging latest QEMU upstream into our CHERI fork, I noticed that > some of the FPU tests in our MIPS baremetal testsuite > (https://github.com/CTSRD-CHERI/cheritest) started failing. It turns out > this commit accidentally changed

[PULL 1/3] target/mips: fpu: Fix recent regression in add.s after 1ace099f2a

2020-07-07 Thread Aleksandar Markovic
: 1ace099f2a ("target/mips: fpu: Demacro ADD.") Signed-off-by: Alex Richardson Signed-off-by: Aleksandar Markovic Reviewed-by: Philippe Mathieu-Daudé Message-Id: <20200703161515.25966-1-alexander.richard...@cl.cam.ac.uk> --- target/mips/fpu_helper.c | 2 +- 1 file changed, 1 insertio

Re: [PATCH v2 1/1] disas: mips: Add Loongson 2F disassembler

2020-07-05 Thread Aleksandar Markovic
On Sunday, July 5, 2020, Aleksandar Markovic < aleksandar.qemu.de...@gmail.com> wrote: > > > On Saturday, July 4, 2020, Aleksandar Markovic < > aleksandar.qemu.de...@gmail.com> wrote: > >> >> >> On Friday, July 3, 2020, Stefan Brankovic >

Re: [PATCH v2 1/1] disas: mips: Add Loongson 2F disassembler

2020-07-05 Thread Aleksandar Markovic
On Saturday, July 4, 2020, Aleksandar Markovic < aleksandar.qemu.de...@gmail.com> wrote: > > > On Friday, July 3, 2020, Stefan Brankovic > wrote: > >> Add disassembler for Loongson 2F instruction set. >> >> Testing is done by comparing qemu disassembly

Re: [REPORT] [GSoC - TCG Continuous Benchmarking] [#2] Dissecting QEMU Into Three Main Parts

2020-07-04 Thread Aleksandar Markovic
On Saturday, July 4, 2020, Alex Bennée wrote: > > Aleksandar Markovic writes: > > > On Wednesday, July 1, 2020, Alex Bennée wrote: > > > >> > >> Ahmed Karaman writes: > >> > >> > On Mon, Jun 29, 2020 at 6:03 PM Alex Bennée >

Re: [REPORT] [GSoC - TCG Continuous Benchmarking] [#2] Dissecting QEMU Into Three Main Parts

2020-07-04 Thread Aleksandar Markovic
On Saturday, July 4, 2020, Alex Bennée wrote: > > Aleksandar Markovic writes: > > > On Wednesday, July 1, 2020, Alex Bennée wrote: > > > >> > >> Ahmed Karaman writes: > >> > >> > On Mon, Jun 29, 2020 at 6:03 PM Alex Bennée >

Re: [PATCH v2 1/1] disas: mips: Add Loongson 2F disassembler

2020-07-04 Thread Aleksandar Markovic
On Friday, July 3, 2020, Stefan Brankovic wrote: > Add disassembler for Loongson 2F instruction set. > > Testing is done by comparing qemu disassembly output, obtained by > using -d in_asm command line option, with appropriate objdump output. > > This disassembler is written as a generic

Re: [REPORT] [GSoC - TCG Continuous Benchmarking] [#2] Dissecting QEMU Into Three Main Parts

2020-07-03 Thread Aleksandar Markovic
On Wednesday, July 1, 2020, Alex Bennée wrote: > > Ahmed Karaman writes: > > > On Mon, Jun 29, 2020 at 6:03 PM Alex Bennée > wrote: > >> > >> Assuming your test case is constant execution (i.e. runs the same each > >> time) you could run in through a plugins build to extract the number of > >>

Re: [PATCH] Fix MIPS add.s after 1ace099f2acb952eaaef0ba7725879949a7e4406

2020-07-03 Thread Aleksandar Markovic
On Friday, July 3, 2020, Alex Richardson wrote: > After merging latest QEMU upstream into our CHERI fork, I noticed that > some of the FPU tests in our MIPS baremetal testsuite > (https://github.com/CTSRD-CHERI/cheritest) started failing. It turns out > this commit accidentally changed add.s

Re: [PATCH v2 1/1] scripts/performance: Add dissect.py script

2020-07-02 Thread Aleksandar Markovic
Helpers: 3,505,065,52574.530% > > Signed-off-by: Ahmed Karaman > --- A very good script! Hopefully there will be some script in near future that will, for example, list all hepers used in the test program. Reviewed-by: Aleksandar Markovic > scripts/perfor

Re: [PATCH v4 28/40] tests/acceptance: skip multicore mips_malta tests on GitLab

2020-07-01 Thread Aleksandar Markovic
On Wed, Jul 1, 2020 at 4:03 PM Alex Bennée wrote: > > For some reason these tests fail all the time on GitLab. I can > re-create the hang around 3% of the time locally but it doesn't seem > to be MTTCG related. For now skipIf on GITLAB_CI. > > Signed-off-by: Alex Bennée > Cc

Re: [PATCH v2 2/2] MAINTAINERS: Adjust MIPS maintainership

2020-07-01 Thread Aleksandar Markovic
But you choose not to be here. And what can I do? I can't force you to be somewhere you don't want to be. I felt the loss of you not being here throughout all my online presence. Mixed feelings, ha? Truly yours, Aleksandar > Regards, > Aurelien > > > On 2020-06-30 18:46, Aleksand

Re: [PATCH v3 2/2] MAINTAINERS: Adjust MIPS maintainership

2020-07-01 Thread Aleksandar Markovic
On Wed, Jul 1, 2020 at 8:55 PM Aurelien Jarno wrote: > > NACK > > On 2020-07-01 20:25, Aleksandar Markovic wrote: > > Paul Burton and Aurelien Jarno removed for not being present. > > A polite email was sent to them with question whether they > >

Re: [PATCH v3 2/2] MAINTAINERS: Adjust MIPS maintainership

2020-07-01 Thread Aleksandar Markovic
On Wed, Jul 1, 2020 at 8:43 PM Paul Burton wrote: > > Hi Aleksandar, > > On Wed, Jul 1, 2020 at 11:26 AM Aleksandar Markovic > wrote: > > Paul Burton and Aurelien Jarno removed for not being present. > > A polite email was sent to them with question whether

Re: [PATCH v3 0/5] hw/mips/malta: Add the 'malta-strict' machine, matching Malta hardware

2020-07-01 Thread Aleksandar Markovic
On Wed, Jul 1, 2020 at 7:39 PM Aurelien Jarno wrote: > > Aleksandar, > > On 2020-06-30 23:54, Aleksandar Markovic wrote: > > As, in a very clear way, evidenced from the previous versions of this > > series, this series real goal was not not to create some new &g

[PATCH v3 0/2] target mips: Misc fixes and improvements

2020-07-01 Thread Aleksandar Markovic
A collection of pending fixes and improvements. v2->v3: - minor content and commit message changes v1->v2: - minor content and commit message changes Aleksandar Markovic (2): target/mips: Remove identical if/else branches MAINTAINERS: Adjust MIPS maintainership MAINT

[PATCH v3 2/2] MAINTAINERS: Adjust MIPS maintainership

2020-07-01 Thread Aleksandar Markovic
Burton CC: Aurelien Jarno CC: Huacai Chen CC: Jiaxun Yang Signed-off-by: Aleksandar Markovic --- MAINTAINERS | 11 +-- 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS index 5d8acf8d31..6f96c03f3e 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -213,7

[PATCH v3 1/2] target/mips: Remove identical if/else branches

2020-07-01 Thread Aleksandar Markovic
via mttr/mftr") Buglink: https://bugs.launchpad.net/qemu/+bug/1885718 Signed-off-by: Aleksandar Markovic --- target/mips/cp0_helper.c | 9 + 1 file changed, 1 insertion(+), 8 deletions(-) diff --git a/target/mips/cp0_helper.c b/target/mips/cp0_helper.c index bbf12e4a97..de64add038 10064

Re: [PATCH 2/2] checkpatch: Change occurences of 'kernel' to 'qemu' in user messages

2020-07-01 Thread Aleksandar Markovic
On Wed, Jul 1, 2020 at 4:20 PM Paolo Bonzini wrote: > > On 20/06/20 17:04, Peter Maydell wrote: > > On Sat, 20 Jun 2020 at 14:33, Aleksandar Markovic > > wrote: > >> > >> It is odd that we inform user that, for example, his current working > >> di

Re: [PATCH v2 2/2] MAINTAINERS: Adjust MIPS maintainership

2020-07-01 Thread Aleksandar Markovic
wrote: > > >> On 6/30/20 6:46 PM, Aleksandar Markovic wrote: > > >>> Paul Burton and Aurelien Jarno removed for not being present. > > >>> > > >>> Huacai Chen and Jiaxun Yang step in as new energy. > > >>> > > >>> CC: Pa

Re: [PATCH 2/2] checkpatch: Change occurences of 'kernel' to 'qemu' in user messages

2020-07-01 Thread Aleksandar Markovic
On Sat, Jun 20, 2020 at 9:32 AM Aleksandar Markovic wrote: > > It is odd that we inform user that, for example, his current working > directory is not kernel root, when, in face, we mean qemu root. > > Replace that and few other similar odd user messages. > > Signed-off-by

Re: [PATCH v3 0/5] hw/mips/malta: Add the 'malta-strict' machine, matching Malta hardware

2020-06-30 Thread Aleksandar Markovic
As, in a very clear way, evidenced from the previous versions of this series, this series real goal was not not to create some new "malta-strict" machine, but to prepare path to creation of some imagined "malta-unleashed" machine which will, to the contrary of proclaimed goal, create a machine

Re: [PATCH v2 0/6] hw/mips/malta: Add the 'malta-strict' machine, matching Malta hardware

2020-06-30 Thread Aleksandar Markovic
уто, 30. јун 2020. у 19:16 Philippe Mathieu-Daudé је написао/ла: > > On 6/30/20 6:55 PM, Aleksandar Markovic wrote: > > уто, 30. јун 2020. у 18:46 Philippe Mathieu-Daudé је > > написао/ла: > >> > >> On 6/30/20 5:38 PM, Aleksandar Markovic wrote: > >>

Re: [PATCH v2 0/6] hw/mips/malta: Add the 'malta-strict' machine, matching Malta hardware

2020-06-30 Thread Aleksandar Markovic
уто, 30. јун 2020. у 18:46 Philippe Mathieu-Daudé је написао/ла: > > On 6/30/20 5:38 PM, Aleksandar Markovic wrote: > > уто, 30. јун 2020. у 16:52 Philippe Mathieu-Daudé је > > написао/ла: > >> > >> Hi, > >> > >> This series add a new 'm

[PATCH v2 1/2] target/mips: Remove identical if/else branches

2020-06-30 Thread Aleksandar Markovic
Remove the segment: if (other_tc == other->current_tc) { tccause = other->CP0_Cause; } else { tccause = other->CP0_Cause; } Original contributor can't remember what was his intention. Bug: 1885718 Signed-off-by: Aleksandar Markovic --- ta

[PATCH v2 0/2] target mips: Misc fixes and improvements

2020-06-30 Thread Aleksandar Markovic
A collection of pending fixes and improvements. v1->v2: - minor content and commit message changes Aleksandar Markovic (2): target/mips: Remove identical if/else branches MAINTAINERS: Adjust MIPS maintainership MAINTAINERS | 15 ++- target/mips/cp0_helpe

[PATCH v2 2/2] MAINTAINERS: Adjust MIPS maintainership

2020-06-30 Thread Aleksandar Markovic
Paul Burton and Aurelien Jarno removed for not being present. Huacai Chen and Jiaxun Yang step in as new energy. CC: Paul Burton CC: Aurelien Jarno Signed-off-by: Aleksandar Markovic --- MAINTAINERS | 15 ++- 1 file changed, 10 insertions(+), 5 deletions(-) diff --git

Re: [PATCH v2 0/6] hw/mips/malta: Add the 'malta-strict' machine, matching Malta hardware

2020-06-30 Thread Aleksandar Markovic
уто, 30. јун 2020. у 16:52 Philippe Mathieu-Daudé је написао/ла: > > Hi, > > This series add a new 'malta-strict' machine, that aims to properly > model the real hardware (which is not what the current 'malta' > machine models). > > As a bonus for Debian builders, a 'malta-unleashed' machine RFC

[PATCH 2/2] MAINTAINERS: Adjust MIPS maintainership

2020-06-30 Thread Aleksandar Markovic
Paul Burton and Aurelien Jarno removed for not being present. Huacai Chen and Jiaxun Yang step in as reinforcement. CC: Paul Burton CC: Aurelien Jarno Signed-off-by: Aleksandar Markovic --- MAINTAINERS | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/MAINTAINERS

[PATCH 1/2] target/mips: Remove identical if/else branches

2020-06-30 Thread Aleksandar Markovic
Remove the segment: if (other_tc == other->current_tc) { tccause = other->CP0_Cause; } else { tccause = other->CP0_Cause; } Original contributor can't remember what was his intention. Signed-off-by: Aleksandar Markovic --- target/mips/cp0_hel

[PATCH 0/2] target mips: Misc fixes and improvements

2020-06-30 Thread Aleksandar Markovic
A collection of pendind fixes and improvements. Aleksandar Markovic (2): target/mips: Remove identical if/else branches MAINTAINERS: Adjust MIPS maintainership MAINTAINERS | 10 +- target/mips/cp0_helper.c | 9 + 2 files changed, 6 insertions(+), 13 deletions

[Bug 1885718] Re: qemu/target/mips/op_helper.c:943:5: style:inconclusive: Found duplicate branches for 'if' and 'else'

2020-06-30 Thread Aleksandar Markovic
*** This bug is a duplicate of bug 1856706 *** https://bugs.launchpad.net/bugs/1856706 Thank you for reporting this! Believe it or not, this has been a know issue to us for a while. We contacted the original contributor, and he says he can't recall what he actually meant when he wrote the

Re: [PATCH 0/7] hw/mips/malta: Rework to allow more than 2GB of RAM on 64-bit

2020-06-30 Thread Aleksandar Markovic
уто, 30. јун 2020. у 13:59 Philippe Mathieu-Daudé је написао/ла: > > On 6/30/20 1:55 PM, Aleksandar Markovic wrote: > > уто, 30. јун 2020. у 13:34 Philippe Mathieu-Daudé је > > написао/ла: > >> > >> On 6/30/20 1:17 PM, Aleksandar Markovic wrote: > >

Re: [PATCH 0/7] hw/mips/malta: Rework to allow more than 2GB of RAM on 64-bit

2020-06-30 Thread Aleksandar Markovic
уто, 30. јун 2020. у 13:34 Philippe Mathieu-Daudé је написао/ла: > > On 6/30/20 1:17 PM, Aleksandar Markovic wrote: > > уторак, 30. јун 2020., Philippe Mathieu-Daudé > <mailto:f4...@amsat.org>> је написао/ла: > > > > On 6/30/2

Re: [PATCH 0/7] hw/mips/malta: Rework to allow more than 2GB of RAM on 64-bit

2020-06-30 Thread Aleksandar Markovic
уторак, 30. јун 2020., Philippe Mathieu-Daudé је написао/ла: > On 6/30/20 1:01 PM, Aleksandar Markovic wrote: > > > > > > уторак, 30. јун 2020., Philippe Mathieu-Daudé > <mailto:f4...@amsat.org>> је написао/ла: > > > > On Tue, Ju

Re: [PATCH 0/7] hw/mips/malta: Rework to allow more than 2GB of RAM on 64-bit

2020-06-30 Thread Aleksandar Markovic
уторак, 30. јун 2020., Philippe Mathieu-Daudé је написао/ла: > On 6/30/20 12:54 PM, Aleksandar Markovic wrote: > > > > > > уторак, 30. јун 2020., Philippe Mathieu-Daudé > <mailto:f4...@amsat.org>> је написао/ла: > > > > O

Re: [PATCH 0/7] hw/mips/malta: Rework to allow more than 2GB of RAM on 64-bit

2020-06-30 Thread Aleksandar Markovic
уторак, 30. јун 2020., Philippe Mathieu-Daudé је написао/ла: > On Tue, Jun 30, 2020 at 12:52 PM Philippe Mathieu-Daudé > wrote: > > > > On 6/30/20 12:48 PM, Aleksandar Markovic wrote: > > > > > > > > > уторак, 30. јун 2020., Philippe Mathieu-Daudé

Re: [PATCH 0/7] hw/mips/malta: Rework to allow more than 2GB of RAM on 64-bit

2020-06-30 Thread Aleksandar Markovic
уторак, 30. јун 2020., Philippe Mathieu-Daudé је написао/ла: > On 6/30/20 12:48 PM, Aleksandar Markovic wrote: > > > > > > уторак, 30. јун 2020., Philippe Mathieu-Daudé > <mailto:f4...@amsat.org>> је написао/ла: > > > > Hi, > > &

Re: [PATCH 0/7] hw/mips/malta: Rework to allow more than 2GB of RAM on 64-bit

2020-06-30 Thread Aleksandar Markovic
уторак, 30. јун 2020., Philippe Mathieu-Daudé је написао/ла: > Hi, > > Following Jiaxun Yang's patch and discussion: > https://patchwork.kernel.org/patch/11416915/ > > - Rename the current machine as 'malta-virt' (keeping 'malta' aliased) > Suggestions for better names are welcome, maybe

Re: [REPORT] [GSoC - TCG Continuous Benchmarking] [#2] Dissecting QEMU Into Three Main Parts

2020-06-30 Thread Aleksandar Markovic
> As far as I know, this is how Ahmed test bed is setup: > > 1) Fresh installation on Ubuntu 18.04 on an Inter 64-bit host. > 2) Install QEMU build prerequisite packages. > 3) Install perf (this step is not necessary for Report 2, but it is > for Report 1). > 4) Install vallgrind. > 5) Install 16

Re: [REPORT] [GSoC - TCG Continuous Benchmarking] [#2] Dissecting QEMU Into Three Main Parts

2020-06-30 Thread Aleksandar Markovic
уто, 30. јун 2020. у 06:34 Lukáš Doktor је написао/ла: > > Dne 29. 06. 20 v 12:25 Ahmed Karaman napsal(a): > > Hi, > > > > The second report of the TCG Continuous Benchmarking series builds > > upon the QEMU performance metrics calculated in the previous report. > > This report presents a method

Re: [REPORT] [GSoC - TCG Continuous Benchmarking] [#2] Dissecting QEMU Into Three Main Parts

2020-06-30 Thread Aleksandar Markovic
уто, 30. јун 2020. у 09:19 Ahmed Karaman је написао/ла: > > On Tue, Jun 30, 2020 at 6:34 AM Lukáš Doktor wrote: > > > > Dne 29. 06. 20 v 12:25 Ahmed Karaman napsal(a): > > > Hi, > > > > > > The second report of the TCG Continuous Benchmarking series builds > > > upon the QEMU performance metrics

Re: [REPORT] [GSoC - TCG Continuous Benchmarking] [#2] Dissecting QEMU Into Three Main Parts

2020-06-30 Thread Aleksandar Markovic
уто, 30. јун 2020. у 09:30 Ahmed Karaman је написао/ла: > > On Tue, Jun 30, 2020 at 7:59 AM 罗勇刚(Yonggang Luo) > wrote: > > > > Wonderful work, May I reproduce the work on my local machine? > > > > On Mon, Jun 29, 2020 at 6:26 PM Ahmed Karaman > > wrote: > >> > >> Hi, > >> > >> The second

Re: [REPORT] [GSoC - TCG Continuous Benchmarking] [#2] Dissecting QEMU Into Three Main Parts

2020-06-29 Thread Aleksandar Markovic
> I should have also pointed out in your > by only having one benchmark you are going to miss out on the envelope > of use cases. > Alex, thank you for all your comments, and other perspectives that you always bring to Ahmed's and everyones else's attention. I always imagine you as a

Re: [REPORT] [GSoC - TCG Continuous Benchmarking] [#2] Dissecting QEMU Into Three Main Parts

2020-06-29 Thread Aleksandar Markovic
понедељак, 29. јун 2020., Ahmed Karaman је написао/ла: > Hi, > > The second report of the TCG Continuous Benchmarking series builds > upon the QEMU performance metrics calculated in the previous report. > This report presents a method to dissect the number of instructions > executed by a QEMU

Re: [PULL 6/6] MAINTAINERS: Add 'Performance Tools and Tests' subsection

2020-06-29 Thread Aleksandar Markovic
понедељак, 29. јун 2020., Philippe Mathieu-Daudé је написао/ла: > On 6/27/20 9:51 PM, Aleksandar Markovic wrote: > > This commit creates a new 'Miscellaneous' section which hosts a new > > 'Performance Tools and Tests' subsection. This subsection will contain > > the th

Re: [PULL 3/6] MAINTAINERS: Add Loongson-3 maintainer and reviewer

2020-06-29 Thread Aleksandar Markovic
понедељак, 29. јун 2020., Philippe Mathieu-Daudé је написао/ла: > On 6/27/20 9:51 PM, Aleksandar Markovic wrote: > > From: Huacai Chen > > > > Add myself as the maintainer for Loongson-3 virtual platforms, and > > also add Jiaxun Yang as the reviewer. > > >

Re: [REPORT] [GSoC - TCG Continuous Benchmarking] [#1] Measuring Basic Performance Metrics of QEMU

2020-06-28 Thread Aleksandar Markovic
пон, 22. јун 2020. у 12:31 Ahmed Karaman је написао/ла: > > Greetings, > > Welcome to the TCG Continuous Benchmarking GSoC project! > This is the first report in a series that will be posted here on the > mailing list as part of the project. > > During the project, multiple Linux profiling tools

[PULL 4/6] scripts/performance: Add topN_perf.py script

2020-06-27 Thread Aleksandar Markovic
qemu-x86_64 19 0.27% soft_f64_addsubqemu-x86_64 20 0.26% round_to_int qemu-x86_64 Signed-off-by: Ahmed Karaman Signed-off-by: Aleksandar Markovic Reviewed-by: Aleksandar Markovic Message-Id: <20200626164546.22102-2-ahmedkhaledkara...@gmail.

[PULL 3/6] MAINTAINERS: Add Loongson-3 maintainer and reviewer

2020-06-27 Thread Aleksandar Markovic
From: Huacai Chen Add myself as the maintainer for Loongson-3 virtual platforms, and also add Jiaxun Yang as the reviewer. Signed-off-by: Huacai Chen Co-developed-by: Jiaxun Yang Reviewed-by: Aleksandar Markovic Signed-off-by: Aleksandar Markovic Message-Id: <1592995531-32600-5-git-s

[PULL 6/6] MAINTAINERS: Add 'Performance Tools and Tests' subsection

2020-06-27 Thread Aleksandar Markovic
to this project, if any. Signed-off-by: Ahmed Karaman Reviewed-by: Alex Bennée Reviewed-by: Aleksandar Markovic Signed-off-by: Aleksandar Markovic Message-Id: <20200626164546.22102-4-ahmedkhaledkara...@gmail.com> --- MAINTAINERS | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-)

[PULL 0/6] MIPS + TCG Continuous Benchmarking queue for June 27th, 2020

2020-06-27 Thread Aleksandar Markovic
Ahmed Karaman (2): scripts/performance: Add topN_perf.py script scripts/performance: Add topN_callgrind.py script Aleksandar Markovic (1): MAINTAINERS: Add 'Performance Tools and Tests' subsection Huacai Chen (3): hw/mips: Implement the kvm_type() hook in MachineClass hw/intc: Add

[PULL 1/6] hw/mips: Implement the kvm_type() hook in MachineClass

2020-06-27 Thread Aleksandar Markovic
ds.] Reviewed-by: Aleksandar Markovic Signed-off-by: Aleksandar Markovic Signed-off-by: Huacai Chen Co-developed-by: Jiaxun Yang Message-Id: <1592995531-32600-2-git-send-email-che...@lemote.com> --- target/mips/kvm_mips.h | 11 +++ target/mips/kvm.c | 26 +++

[PULL 2/6] hw/intc: Add Loongson LIOINTC support

2020-06-27 Thread Aleksandar Markovic
; 2, The "I/O中断" section of Loongson-3's user mannual, part 1. Signed-off-by: Huacai Chen Signed-off-by: Jiaxun Yang Signed-off-by: Aleksandar Markovic Reviewed-by: Aleksandar Markovic Message-Id: <1592995531-32600-3-git-send-email-che...@lemote.com> --- hw/intc/loongson

[PULL 5/6] scripts/performance: Add topN_callgrind.py script

2020-06-27 Thread Aleksandar Markovic
-by: Aleksandar Markovic Reviewed-by: Aleksandar Markovic Message-Id: <20200626164546.22102-3-ahmedkhaledkara...@gmail.com> --- scripts/performance/topN_callgrind.py | 140 ++ 1 file changed, 140 insertions(+) create mode 100755 scripts/performance/topN_callgrind.py

Re: [PATCH v4 3/3] MAINTAINERS: Add 'Performance Tools and Tests'subsection

2020-06-27 Thread Aleksandar Markovic
us Benchmarking' project. > > Signed-off-by: Ahmed Karaman > Reviewed-by: Alex Bennée > --- Reviewed-by: Aleksandar Markovic Applied to "TCG Continuous Benchmarking" queue. > MAINTAINERS | 7 +++ > 1 file changed, 7 insertions(+) > > diff --git a/MAINTAI

Re: [PATCH v4 1/3] scripts/performance: Add topN_perf.py script

2020-06-27 Thread Aleksandar Markovic
he number of top functions to print. > +# - If this flag is not specified, the tool defaults to 25. > +# > +# Example of usage: > +# topN_perf.py -n 20 -- qemu-arm coulomb_double-arm > +# > +# This file is a part of the project "TCG Continuous Benchmarking". >

Re: [PATCH v4 2/3] scripts/performance: Add topN_callgrind.py script

2020-06-27 Thread Aleksandar Markovic
4% helper_pxor_xmm /target/i386/ops_sse.h > 19 0.353% round_to_int /fpu/softfloat.c > 20 0.347% helper_cc_compute_all /target/i386/cc_helper.c > > Signed-off-by: Ahmed Karaman > --- Reviewed-by: Aleksandar Markovic Applied to "TCG Continuous Benchmarkin

  1   2   3   4   5   6   7   8   9   10   >