Re: [PATCH] tests/avocado: Move LinuxTest related code into a separate file

2024-07-19 Thread Daniel P . Berrangé
- > tests/avocado/intel_iommu.py| 2 +- > tests/avocado/replay_linux.py | 2 +- > tests/avocado/smmu.py | 3 +- > 8 files changed, 262 insertions(+), 244 deletions(-) > create mode 100644 tests/avocado/avocado_qemu/linuxtest.py Reviewed-by: Daniel

Re: [PATCH] tests/avocado/mem-addr-space-check: Remove unused "import signal"

2024-07-19 Thread Daniel P . Berrangé
On Fri, Jul 19, 2024 at 11:54:08AM +0200, Thomas Huth wrote: > The "signal" module is not used here, so we can remove this import > statement. > > Signed-off-by: Thomas Huth > --- > tests/avocado/mem-addr-space-check.py | 1 - > 1 file changed, 1 deletion(-)

Re: [PULL 3/3] hw/loongarch: Modify flash block size to 256K

2024-07-19 Thread Daniel P . Berrangé
On Fri, Jul 19, 2024 at 10:12:20AM +0200, Philippe Mathieu-Daudé wrote: > On 19/7/24 04:26, Song Gao wrote: > > From: Xianglai Li > > > > loongarch added a common library for edk2 to > > parse flash base addresses through fdt. > > For compatibility with other architectures, > > the flash block

Re: [PATCH v2] vnc: increase max display size

2024-07-18 Thread Daniel P . Berrangé
On Thu, Jul 18, 2024 at 04:58:10PM +0100, Peter Maydell wrote: > On Thu, 30 May 2024 at 12:11, Gerd Hoffmann wrote: > > > > It's 2024. 4k display resolutions are a thing these days. > > Raise width and height limits of the qemu vnc server. > > > > Resolves:

Re: [PATCH v5 3/4] docs/interop/firmware.json: convert "Example" section

2024-07-18 Thread Daniel P . Berrangé
not detected earlier as firmware.json was not validated. > As this validation is about to be added, adapt firmware.json. > > Signed-off-by: Thomas Weißschuh > --- > docs/interop/firmware.json | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Daniel P. Berra

Re: [PATCH 1/2] ci: add gtk-vnc to the deps

2024-07-18 Thread Daniel P . Berrangé
On Thu, Jul 18, 2024 at 12:34:13PM +0200, Thomas Huth wrote: > On 18/07/2024 11.41, Daniel P. Berrangé wrote: > > The gtk-vnc package is used by the vnc-display-test qtest > > program. Technically only gvnc is needed, but since we > > already pull in the gtk3 dep, it

[PATCH 0/2] ci: fix running of vnc-display-test

2024-07-18 Thread Daniel P . Berrangé
The vnc-display-test is skipped in CI due to missing gvnc RPMs, fix that. Daniel P. Berrangé (2): ci: add gtk-vnc to the deps ci: refresh package lists with lcitool .gitlab-ci.d/cirrus/freebsd-13.vars | 2 +- .gitlab-ci.d/cirrus/macos-13.vars | 2

[PATCH 2/2] ci: refresh package lists with lcitool

2024-07-18 Thread Daniel P . Berrangé
Refresh with the newly added gtk-vnc package Signed-off-by: Daniel P. Berrangé --- .gitlab-ci.d/cirrus/freebsd-13.vars | 2 +- .gitlab-ci.d/cirrus/macos-13.vars | 2 +- .gitlab-ci.d/cirrus/macos-14.vars | 2 +- scripts/ci/setup/ubuntu

[PATCH 1/2] ci: add gtk-vnc to the deps

2024-07-18 Thread Daniel P . Berrangé
The gtk-vnc package is used by the vnc-display-test qtest program. Technically only gvnc is needed, but since we already pull in the gtk3 dep, it is harmless to depend on gtk-vnc. Signed-off-by: Daniel P. Berrangé --- tests/lcitool/projects/qemu.yml | 1 + 1 file changed, 1 insertion(+) diff

Re: [PATCH v3] chardev: add path option for pty backend

2024-07-18 Thread Daniel P . Berrangé
On Thu, Jul 18, 2024 at 08:15:01AM +0200, Markus Armbruster wrote: > Looks like this one fell through the cracks. > > Octavian Purdila writes: > > > Add path option to the pty char backend which will create a symbolic > > link to the given path that points to the allocated PTY. > > > > This

Re: [PATCH v4 3/3] docs: add test for firmware.json QAPI

2024-07-18 Thread Daniel P . Berrangé
ned-off-by: Thomas Weißschuh > --- > docs/meson.build | 5 + > 1 file changed, 5 insertions(+) Reviewed-by: Daniel P. Berrangé With regards, Daniel -- |: https://berrange.com -o-https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o-ht

Re: [PATCH v4 2/3] docs/interop/firmware.json: add new enum FirmwareArchitecture

2024-07-18 Thread Daniel P . Berrangé
gt; definitions. > > Suggested-by: Daniel P. Berrangé > Signed-off-by: Thomas Weißschuh > --- > docs/interop/firmware.json | 29 +++-- > 1 file changed, 27 insertions(+), 2 deletions(-) Reviewed-by: Daniel P. Berrangé With regards, Daniel -- |: https

Re: [PATCH v4 1/3] docs/interop/firmware.json: add new enum FirmwareFormat

2024-07-18 Thread Daniel P . Berrangé
gt; definitions. > > Suggested-by: Daniel P. Berrangé > Signed-off-by: Thomas Weißschuh > --- > docs/interop/firmware.json | 17 +++-- > 1 file changed, 15 insertions(+), 2 deletions(-) Reviewed-by: Daniel P. Berrangé With regards, Daniel -- |: https://berrange.com -o-

Re: [PATCH v2] scripts/checkpatch: more checks on files imported from Linux

2024-07-18 Thread Daniel P . Berrangé
24 > 1 file changed, 24 insertions(+) Reviewed-by: Daniel P. Berrangé With regards, Daniel -- |: https://berrange.com -o-https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o-https://fstop138.berrange.com

Re: [PATCH 04/14] qapi: add a 'command-features' pragma

2024-07-17 Thread Daniel P . Berrangé
On Tue, Jul 16, 2024 at 08:08:42PM +0200, Markus Armbruster wrote: > Sorry for the delay; too many distractions, and I needed a good think. > > Daniel P. Berrangé writes: > > > On Fri, Jul 12, 2024 at 10:50:54AM +0200, Markus Armbruster wrote: > >>

Re: [PATCH] scripts/checkpatch: emit a warning if an imported file is touched

2024-07-17 Thread Daniel P . Berrangé
On Wed, Jul 17, 2024 at 11:37:52AM +0200, Stefano Garzarella wrote: > If a file imported from Linux is touched, emit a warning and suggest > using scripts/update-linux-headers.sh > > Signed-off-by: Stefano Garzarella > --- > scripts/checkpatch.pl | 14 -- > 1 file changed, 12

Re: [PATCH v1 00/11] Convert avocado tests to normal Python unittests

2024-07-17 Thread Daniel P . Berrangé
On Wed, Jul 17, 2024 at 10:04:19AM +0200, Thomas Huth wrote: > On 16/07/2024 19.03, Thomas Huth wrote: > > On 16/07/2024 18.51, Daniel P. Berrangé wrote: > > > On Tue, Jul 16, 2024 at 01:26:03PM +0200, Thomas Huth wrote: > > ... > > > > So instead of trying t

Re: [RFC PATCH 0/8] Convert avocado tests to normal Python unittests

2024-07-16 Thread Daniel P . Berrangé
On Tue, Jul 16, 2024 at 09:34:41PM +0200, Paolo Bonzini wrote: > Il mar 16 lug 2024, 20:10 Daniel P. Berrangé ha > scritto: > > > On Tue, Jul 16, 2024 at 08:03:54PM +0200, Paolo Bonzini wrote: > > > Il mar 16 lug 2024, 18:45 John Snow ha scritto: > > > &g

Re: [PATCH 11/11] gitlab-ci: Add "check-functional" to the build tests

2024-07-16 Thread Daniel P . Berrangé
t; .gitlab-ci.d/buildtest.yml | 60 ++--- > 2 files changed, 32 insertions(+), 31 deletions(-) Reviewed-by: Daniel P. Berrangé With regards, Daniel -- |: https://berrange.com -o-https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o-https

Re: [PATCH 10/11] tests/functional: Convert the s390x avocado tests into standalone tests

2024-07-16 Thread Daniel P . Berrangé
On Tue, Jul 16, 2024 at 01:26:13PM +0200, Thomas Huth wrote: > These tests use archive.lzma_uncompress() from the Avocado utils, > so provide a small helper function for this, based on the > standard lzma module from Python instead. > > And while we're at it, replace the MD5 hashes in the

Re: [PATCH 09/11] tests/functional: Set up logging

2024-07-16 Thread Daniel P . Berrangé
t/__init__.py | 24 +++- > 1 file changed, 23 insertions(+), 1 deletion(-) Reviewed-by: Daniel P. Berrangé With regards, Daniel -- |: https://berrange.com -o-https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o-https://fstop138.berrange.com :

Re: [PATCH 08/11] tests/functional: Convert some avocado tests that needed avocado.utils.archive

2024-07-16 Thread Daniel P . Berrangé
py => functional/test_ppc_bamboo.py} (75%) > mode change 100644 => 100755 > rename tests/{avocado/machine_sparc64_sun4u.py => > functional/test_sparc64_sun4u.py} (60%) > mode change 100644 => 100755 Reviewed-by: Daniel P. Berrangé With regards, Daniel -- |: https://ber

Re: [PATCH 07/11] tests/functional: Add a function for extracting files from an archive

2024-07-16 Thread Daniel P . Berrangé
ged, 21 insertions(+) > create mode 100644 tests/functional/qemu_test/utils.py Reviewed-by: Daniel P. Berrangé With regards, Daniel -- |: https://berrange.com -o-https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o-https://fstop138.berrange.com :|

Re: [PATCH 06/11] tests/functional: Convert some tests that download files via fetch_asset()

2024-07-16 Thread Daniel P . Berrangé
tool.py => > functional/test_netdev_ethtool.py} (81%) > mode change 100644 => 100755 > rename tests/{avocado/ppc_405.py => functional/test_ppc_405.py} (73%) > mode change 100644 => 100755 Reviewed-by: Daniel P. Berrangé With regards, Daniel -- |: https://berrange

Re: [PATCH 05/11] tests/functional: Implement fetch_asset() method for downloading assets

2024-07-16 Thread Daniel P . Berrangé
On Tue, Jul 16, 2024 at 01:26:08PM +0200, Thomas Huth wrote: > In the new python test framework, we cannot use the fetch_asset() > function from Avocado anymore, so we have to provide our own > implementation now instead. Thus add such a function based on the > urllib python module for this

Re: [PATCH 03/11] tests/functional: Convert avocado tests that just need a small adjustment

2024-07-16 Thread Daniel P . Berrangé
nge 100644 => 100755 > rename tests/{avocado/version.py => functional/test_version.py} (78%) > mode change 100644 => 100755 Reviewed-by: Daniel P. Berrangé With regards, Daniel -- |: https://berrange.com -o-https://www.flickr.com/photos/dberrange :| |: https://libvirt.org

Re: [PATCH 02/11] tests/functional: Convert simple avocado tests into standalone python tests

2024-07-16 Thread Daniel P . Berrangé
-8,8 +10,7 @@ > # > # SPDX-License-Identifier: GPL-2.0-or-later > > -from avocado_qemu import QemuSystemTest > -import signal Nit-pick - cleanup of an unrelated existing bug - 'signal' wasn't used. Suggest doing it in a separate patch Aside from that: Reviewed-by: Daniel P

Re: [RFC PATCH 0/8] Convert avocado tests to normal Python unittests

2024-07-16 Thread Daniel P . Berrangé
On Tue, Jul 16, 2024 at 08:03:54PM +0200, Paolo Bonzini wrote: > Il mar 16 lug 2024, 18:45 John Snow ha scritto: > > > My only ask is that we keep the tests running in the custom venv > > environment we set up at build time > > > > Yes, they do, however pytest should also be added to

Re: [PATCH 04/11] tests/functional: Add python-based tests to the meson build system

2024-07-16 Thread Daniel P . Berrangé
@echo " $(MAKE) check-functional Run python-based functional > tests" > + @echo " $(MAKE) check-functional-TARG Run functional tests for a given > target" We could increase whitespace by 2 to fit TARGET, or shorten all cases to TGT ? > @echo &quo

Re: [PATCH v1 00/11] Convert avocado tests to normal Python unittests

2024-07-16 Thread Daniel P . Berrangé
t; QEMU binary via QEMU_TEST_QEMU_BINARY. For example: > > export PYTHONPATH=$HOME/qemu/python > export QEMU_TEST_QEMU_BINARY=qemu-system-x86_64 > export PYTHONPATH=$HOME/qemu/build > ~/qemu/tests/functional/test_virtio_version.py For the whole series as is Tested-by: Daniel P. B

Re: [PATCH v4 1/7] util: Introduce qemu_get_runtime_dir()

2024-07-16 Thread Daniel P . Berrangé
On Tue, Jul 16, 2024 at 07:52:00PM +0900, Akihiko Odaki wrote: > On 2024/07/16 18:53, Daniel P. Berrangé wrote: > > On Tue, Jul 16, 2024 at 04:27:31PM +0900, Akihiko Odaki wrote: > > > qemu_get_runtime_dir() returns a dynamically allocated directory path > > > that

Re: [PATCH v4 0/7] util: Introduce qemu_get_runtime_dir()

2024-07-16 Thread Daniel P . Berrangé
On Tue, Jul 16, 2024 at 11:06:57AM +0300, Michael Tokarev wrote: > 16.07.2024 10:27, Akihiko Odaki wrote: > > qemu_get_runtime_dir() returns a dynamically allocated directory path > > that is appropriate for storing runtime files. It corresponds to "run" > > directory in Unix. > > Since runtime

Re: [PATCH v4 1/7] util: Introduce qemu_get_runtime_dir()

2024-07-16 Thread Daniel P . Berrangé
On Tue, Jul 16, 2024 at 04:27:31PM +0900, Akihiko Odaki wrote: > qemu_get_runtime_dir() returns a dynamically allocated directory path > that is appropriate for storing runtime files. It corresponds to "run" > directory in Unix. > > With a tree-wide search, it was found that there are several

Re: [PATCH] meson: Update meson-buildoptions.sh

2024-07-15 Thread Daniel P . Berrangé
CC qemu-trivial On Mon, Jul 15, 2024 at 09:00:51PM +0800, Zhao Liu wrote: > Hi Daniel, > > On Fri, Jul 05, 2024 at 10:20:27AM +0100, Daniel P. Berrangé wrote: > > Date: Fri, 5 Jul 2024 10:20:27 +0100 > > From: "Daniel P. Berrangé" > > Subject: Re: [PATCH

Re: [PATCH v3 2/5] qdev-properties: Add DEFINE_PROP_ON_OFF_AUTO_BIT64()

2024-07-15 Thread Daniel P . Berrangé
On Sun, Jul 14, 2024 at 02:11:02PM +0900, Akihiko Odaki wrote: > DEFINE_PROP_ON_OFF_AUTO_BIT64() corresponds to DEFINE_PROP_ON_OFF_AUTO() > as DEFINE_PROP_BIT64() corresponds to DEFINE_PROP_BOOL(). The difference > is that DEFINE_PROP_ON_OFF_AUTO_BIT64() exposes OnOffAuto instead of > bool. IMHO

Re: [PATCH v3 1/5] qdev-properties: Accept bool for OnOffAuto

2024-07-15 Thread Daniel P . Berrangé
On Sun, Jul 14, 2024 at 02:11:01PM +0900, Akihiko Odaki wrote: > Accept bool literals for OnOffAuto properties for consistency with bool > properties. > > Signed-off-by: Akihiko Odaki > --- > hw/core/qdev-properties.c | 17 - > 1 file changed, 16 insertions(+), 1 deletion(-) >

Re: [PATCH 00/14] Improve mechanism for configuring allowed commands

2024-07-15 Thread Daniel P . Berrangé
On Mon, Jul 15, 2024 at 11:52:10AM +0200, Markus Armbruster wrote: > Hi Daniel, got a public branch I could pull? This particular v1 posting: https://gitlab.com/berrange/qemu/-/tags/qga-features-v1 Or latest git master rebase https://gitlab.com/berrange/qemu/-/tree/qga-features NB, this

Re: [PATCH v2] osdep: add a qemu_close_all_open_fd() helper

2024-07-12 Thread Daniel P . Berrangé
On Tue, Jun 18, 2024 at 01:17:03PM +0200, Clément Léger wrote: > Since commit 03e471c41d8b ("qemu_init: increase NOFILE soft limit on > POSIX"), the maximum number of file descriptors that can be opened are > raised to nofile.rlim_max. On recent debian distro, this yield a maximum > of 1073741816

Re: [RFC PATCH 0/8] Convert avocado tests to normal Python unittests

2024-07-12 Thread Daniel P . Berrangé
On Fri, Jul 12, 2024 at 03:25:23PM +0100, Alex Bennée wrote: > Daniel P. Berrangé writes: > > > On Thu, Jul 11, 2024 at 07:44:39PM +0200, Thomas Huth wrote: > >> On 11/07/2024 16.39, Fabiano Rosas wrote: > >> > Thomas Huth writes: > >> ... > >

Re: [PATCH] meson.build: fix libgcrypt detection on system without libgcrypt-config

2024-07-12 Thread Daniel P . Berrangé
method: 'config-tool', > required: get_option('gcrypt')) > # Debian has removed -lgpg-error from libgcrypt-config > # as it "spreads unnecessary dependencies" which in Despite the misleading commit message the change is good and I'll queue it.

Re: [PATCH] docs/devel: Add introduction to LUKS volume with detached header

2024-07-12 Thread Daniel P . Berrangé
On Tue, Feb 20, 2024 at 12:04:42AM +0800, Hyman Huang wrote: > Signed-off-by: Hyman Huang > --- > MAINTAINERS | 1 + > docs/devel/luks-detached-header.rst | 182 > 2 files changed, 183 insertions(+) > create mode 100644

[PATCH v3 10/22] qga: conditionalize schema for commands requiring getifaddrs

2024-07-12 Thread Daniel P . Berrangé
"The command FOO has not been found"} This has the additional benefit that the QGA protocol reference now documents what conditions enable use of the command. Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Konstantin Kostiuk Signed-off-by: Daniel P. Berrangé --- qga/commands-posix.c |

[PATCH v3 05/22] qga: move linux disk/cpu stats command impls to commands-linux.c

2024-07-12 Thread Daniel P . Berrangé
iewed-by: Konstantin Kostiuk Signed-off-by: Daniel P. Berrangé --- qga/commands-linux.c | 195 ++ qga/commands-posix.c | 199 --- 2 files changed, 195 insertions(+), 199 deletions(-) diff --git a/qga/commands-li

[PATCH v3 06/22] qga: move linux memory block command impls to commands-linux.c

2024-07-12 Thread Daniel P . Berrangé
ilippe Mathieu-Daudé Reviewed-by: Konstantin Kostiuk Signed-off-by: Daniel P. Berrangé --- qga/commands-linux.c | 308 ++ qga/commands-posix.c | 311 +-- 2 files changed, 309 insertions(+), 310 deletions(-) diff --git a/qg

[PATCH v3 13/22] qga: conditionalize schema for commands requiring fsfreeze

2024-07-12 Thread Daniel P . Berrangé
"The command FOO has not been found"} This has the additional benefit that the QGA protocol reference now documents what conditions enable use of the command. Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Konstantin Kostiuk Signed-off-by: Daniel P. Berrangé --- qga/commands-posi

[PATCH v3 16/22] qga: conditionalize schema for commands requiring utmpx

2024-07-12 Thread Daniel P . Berrangé
"The command FOO has not been found"} This has the additional benefit that the QGA protocol reference now documents what conditions enable use of the command. Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Konstantin Kostiuk Signed-off-by: Daniel P. Berrangé --- qga/commands-posix.c | 10 +-

[PATCH v3 08/22] qga: conditionalize schema for commands unsupported on Windows

2024-07-12 Thread Daniel P . Berrangé
command is not currently supported"} to {"class": "CommandNotFound", "desc": "The command FOO has not been found"} The final additional benefit is that the QGA protocol reference now documents what conditions enable use of the command. Review

[PATCH v3 21/22] qga: allow configuration file path via the cli

2024-07-12 Thread Daniel P . Berrangé
that we parse the comamnd line twice, since we want the command line arguments to take priority over the configuration file settings in general. Signed-off-by: Daniel P. Berrangé --- docs/interop/qemu-ga.rst | 5 + qga/main.c | 43 ++-- 2 files

[PATCH v3 22/22] qga: centralize logic for disabling/enabling commands

2024-07-12 Thread Daniel P . Berrangé
technical reason to prevent concurrent setting of both the allow and block lists, so this flawed restriction is removed. Signed-off-by: Daniel P. Berrangé --- docs/interop/qemu-ga.rst | 14 + qga/commands-posix.c | 6 -- qga/commands-win32.c | 6 -- qga/main.c

[PATCH v3 15/22] qga: conditionalize schema for commands requiring libudev

2024-07-12 Thread Daniel P . Berrangé
"The command FOO has not been found"} This has the additional benefit that the QGA protocol reference now documents what conditions enable use of the command. Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Konstantin Kostiuk Signed-off-by: Daniel P. Berrangé --- qga/commands-linux.

[PATCH v3 18/22] qga: don't disable fsfreeze commands if vss_init fails

2024-07-12 Thread Daniel P . Berrangé
sidianakis Signed-off-by: Daniel P. Berrangé --- qga/commands-win32.c | 18 +++--- qga/main.c | 4 2 files changed, 7 insertions(+), 15 deletions(-) diff --git a/qga/commands-win32.c b/qga/commands-win32.c index 2533e4c748..5866cc2e3c 100644 --- a/qga/commands-win32.c

[PATCH v3 20/22] qga: remove pointless 'blockrpcs_key' variable

2024-07-12 Thread Daniel P . Berrangé
' argument / config key Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Konstantin Kostiuk Signed-off-by: Daniel P. Berrangé --- qga/main.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/qga/main.c b/qga/main.c index 647d27037c..6ff022a85d 100644 --- a/qga/main.c +++ b

[PATCH v3 11/22] qga: conditionalize schema for commands requiring linux/win32

2024-07-12 Thread Daniel P . Berrangé
CommandNotFound", "desc": "Command FOO has been disabled"} to {"class": "CommandNotFound", "desc": "The command FOO has not been found"} This has the additional benefit that the QGA protocol reference now documents what conditions

[PATCH v3 17/22] qga: conditionalize schema for commands not supported on other UNIX

2024-07-12 Thread Daniel P . Berrangé
ound"} This has the additional benefit that the QGA protocol reference now documents what conditions enable use of the command. Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Konstantin Kostiuk Signed-off-by: Daniel P. Berrangé --- meson.build | 1 + qga/commands-posix.c | 8 -

[PATCH v3 12/22] qga: conditionalize schema for commands only supported on Windows

2024-07-12 Thread Daniel P . Berrangé
ound"} This has the additional benefit that the QGA protocol reference now documents what conditions enable use of the command. Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Konstantin Kostiuk Signed-off-by: Daniel P. Berrangé --- qga/commands-posix.c | 9 - qga/qapi-schema.json | 15

[PATCH v3 19/22] qga: move declare of QGAConfig struct to top of file

2024-07-12 Thread Daniel P . Berrangé
It is referenced by QGAState already, and it is clearer to declare all data types at the top of the file, rather than have them mixed with code later. Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Konstantin Kostiuk Signed-off-by: Daniel P. Berrangé --- qga/main.c | 44

[PATCH v3 09/22] qga: conditionalize schema for commands unsupported on non-Linux POSIX

2024-07-12 Thread Daniel P . Berrangé
en found"} This has the additional benefit that the QGA protocol reference now documents what conditions enable use of the command. Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Konstantin Kostiuk Signed-off-by: Daniel P. Berrangé --- qga/commands-posix.c | 66 -

[PATCH v3 03/22] qga: move linux suspend command impls to commands-linux.c

2024-07-12 Thread Daniel P . Berrangé
The qmp_guest_suspend_{disk,ram,hybrid} command impls in commands-posix.c are surrounded by '#ifdef __linux__' so should instead live in commands-linux.c Reviewed-by: Manos Pitsidianakis Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Konstantin Kostiuk Signed-off-by: Daniel P. Berrangé

[PATCH v3 04/22] qga: move linux fs/disk command impls to commands-linux.c

2024-07-12 Thread Daniel P . Berrangé
The qmp_guest_{fstrim, get_fsinfo, get_disks} command impls in commands-posix.c are surrounded by '#ifdef __linux__' so should instead live in commands-linux.c Reviewed-by: Manos Pitsidianakis Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Konstantin Kostiuk Signed-off-by: Daniel P. Berrangé

[PATCH v3 14/22] qga: conditionalize schema for commands requiring fstrim

2024-07-12 Thread Daniel P . Berrangé
": "The command FOO has not been found"} This has the additional benefit that the QGA protocol reference now documents what conditions enable use of the command. Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Konstantin Kostiuk Signed-off-by: Daniel P. Berrangé --- qga/commands-pos

[PATCH v3 02/22] qga: move linux vcpu command impls to commands-linux.c

2024-07-12 Thread Daniel P . Berrangé
The qmp_guest_set_vcpus and qmp_guest_get_vcpus command impls in commands-posix.c are surrounded by '#ifdef __linux__' so should instead live in commands-linux.c Reviewed-by: Manos Pitsidianakis Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Konstantin Kostiuk Signed-off-by: Daniel P

[PATCH v3 07/22] qga: move CONFIG_FSFREEZE/TRIM to be meson defined options

2024-07-12 Thread Daniel P . Berrangé
Defining these at the meson level allows them to be used a conditional tests in the QAPI schemas. Signed-off-by: Daniel P. Berrangé --- meson.build | 15 +++ qga/commands-common.h | 9 - 2 files changed, 15 insertions(+), 9 deletions(-) diff --git a/meson.build b

[PATCH v3 01/22] qga: drop blocking of guest-get-memory-block-size command

2024-07-12 Thread Daniel P . Berrangé
This command has never existed in tree, since it was renamed to guest-get-memory-block-info before being merged. Reviewed-by: Manos Pitsidianakis Reviewed-by: Konstantin Kostiuk Signed-off-by: Daniel P. Berrangé --- qga/commands-posix.c | 2 +- qga/commands-win32.c | 2 +- 2 files changed, 2

[PATCH v3 00/22] qga: clean up command source locations and conditionals

2024-07-12 Thread Daniel P . Berrangé
, or by well defined rule ie not permitted during FS freeze. - Apply rules later in startup to avoid crash from NULL config pointer - Document changed error messages in commit messages - Add -c / --config command line parameter - Fix mistaken enabling of fsfreeze hooks on win32 Daniel P

Re: [PATCH v2 22/22] qga: centralize logic for disabling/enabling commands

2024-07-12 Thread Daniel P . Berrangé
On Wed, Jul 03, 2024 at 01:01:11PM +0300, Manos Pitsidianakis wrote: > Hello Daniel, > > This cleanup seems like a good idea, > > On Thu, 13 Jun 2024 18:44, "Daniel P. Berrangé" wrote: > > It is confusing having many different pieces of code enab

Re: [PATCH v2 0/9] RISC-V: ACPI: Namespace updates

2024-07-12 Thread Daniel P . Berrangé
On Fri, Jul 12, 2024 at 02:43:19PM +0200, Igor Mammedov wrote: > On Mon, 8 Jul 2024 17:17:32 +0530 > Sunil V L wrote: > > > This series adds few updates to RISC-V ACPI namespace for virt platform. > > Additionally, it has patches to enable ACPI table testing for RISC-V. > > > > 1) PCI Link

Re: [PATCH v2 18/22] qga: don't disable fsfreeze commands if vss_init fails

2024-07-12 Thread Daniel P . Berrangé
On Wed, Jul 03, 2024 at 01:21:29PM +0300, Manos Pitsidianakis wrote: > On Thu, 13 Jun 2024 18:44, "Daniel P. Berrangé" wrote: > > The fsfreeze commands are already written to report an error if > > vss_init() fails. Reporting a more specific error message is more &

Re: [RFC PATCH 7/8] tests/pytest: Add a function for extracting files from an archive

2024-07-12 Thread Daniel P . Berrangé
On Fri, Jul 12, 2024 at 01:52:03PM +0200, Thomas Huth wrote: > On 12/07/2024 11.14, Daniel P. Berrangé wrote: > > On Thu, Jul 11, 2024 at 01:55:45PM +0200, Thomas Huth wrote: > > > Some Avocado-based tests use the "archive" module from avocado.utils > >

Re: [RFC PATCH 4/8] tests/pytest: add pytest to the meson build system

2024-07-12 Thread Daniel P . Berrangé
On Fri, Jul 12, 2024 at 12:14:45PM +0200, Thomas Huth wrote: > On 12/07/2024 11.01, Daniel P. Berrangé wrote: > > On Thu, Jul 11, 2024 at 01:55:42PM +0200, Thomas Huth wrote: > > > From: Ani Sinha > > > > > > Integrate the pytest framework with the meson buil

Re: [RFC PATCH 4/8] tests/pytest: add pytest to the meson build system

2024-07-12 Thread Daniel P . Berrangé
On Fri, Jul 12, 2024 at 12:14:45PM +0200, Thomas Huth wrote: > On 12/07/2024 11.01, Daniel P. Berrangé wrote: > > On Thu, Jul 11, 2024 at 01:55:42PM +0200, Thomas Huth wrote: > > > From: Ani Sinha > > > > > > Integrate the pytest framework with the meson buil

Re: [RFC PATCH] build deps: update lcitool to include rust bits

2024-07-12 Thread Daniel P . Berrangé
| 3 +++ > tests/vm/generated/freebsd.json | 2 ++ > 24 files changed, 71 insertions(+), 4 deletions(-) Reviewed-by: Daniel P. Berrangé With regards, Daniel -- |: https://berrange.com -o-https://www.flickr.com/photos/dberrange :| |: https:/

Re: [PATCH v2 21/22] qga: allow configuration file path via the cli

2024-07-12 Thread Daniel P . Berrangé
On Fri, Jul 12, 2024 at 12:05:23PM +0300, Konstantin Kostiuk wrote: > On Thu, Jun 13, 2024 at 6:45 PM Daniel P. Berrangé > wrote: > > > Allowing the user to set the QGA_CONF environment variable to change > > the default configuration file path is very unusual practice,

Re: [PATCH 04/14] qapi: add a 'command-features' pragma

2024-07-12 Thread Daniel P . Berrangé
On Fri, Jul 12, 2024 at 10:50:54AM +0200, Markus Armbruster wrote: > Daniel P. Berrangé writes: > > > On Fri, Jul 12, 2024 at 10:07:34AM +0200, Markus Armbruster wrote: > >> Daniel P. Berrangé writes: > >> > >> > The 'command-features' pragma all

Re: [RFC PATCH 7/8] tests/pytest: Add a function for extracting files from an archive

2024-07-12 Thread Daniel P . Berrangé
On Thu, Jul 11, 2024 at 01:55:45PM +0200, Thomas Huth wrote: > Some Avocado-based tests use the "archive" module from avocado.utils > to extract files from an archive. To be able to use these tests > without Avocado, we have to provide our own function for extracting > files. Fortunately, there is

Re: [RFC PATCH 6/8] tests/pytest: Convert some tests that download files via fetch_asset()

2024-07-12 Thread Daniel P . Berrangé
ename tests/{avocado/machine_loongarch.py => > pytest/test_machine_loongarch.py} (89%) > rename tests/{avocado/machine_mips_loongson3v.py => > pytest/test_machine_mips_loongson3v.py} (59%) If you take my suggestion in the previous patch, the sha1 hashes would need updating to sha256 hashes here. Asi

Re: [RFC PATCH 5/8] tests_pytest: Implement fetch_asset() method for downloading assets

2024-07-12 Thread Daniel P . Berrangé
On Thu, Jul 11, 2024 at 01:55:43PM +0200, Thomas Huth wrote: > In the pytests, we cannot use the fetch_asset() function from Avocado > anymore, so we have to provide our own implementation now instead. > Thus add such a function based on the _download_with_cache() function > from

Re: [RFC PATCH 4/8] tests/pytest: add pytest to the meson build system

2024-07-12 Thread Daniel P . Berrangé
On Thu, Jul 11, 2024 at 01:55:42PM +0200, Thomas Huth wrote: > From: Ani Sinha > > Integrate the pytest framework with the meson build system. This > will make meson run all the pytests under the pytest directory. Lets add a note about the compelling benefit of this new approach With this

Re: [RFC PATCH 3/8] tests/pytest: Convert info_usernet and version test with small adjustments

2024-07-12 Thread Daniel P . Berrangé
1%) > rename tests/{avocado/version.py => pytest/test_version.py} (82%) Reviewed-by: Daniel P. Berrangé > diff --git a/tests/avocado/version.py b/tests/pytest/test_version.py > similarity index 82% > rename from tests/avocado/version.py > rename to tests/pytest/test_version.py &g

Re: [RFC PATCH 2/8] tests/pytest: Convert some simple avocado tests into pytests

2024-07-12 Thread Daniel P . Berrangé
=> > pytest/test_mem_addr_space.py} (99%) > rename tests/{avocado/virtio_version.py => pytest/test_virtio_version.py} > (99%) Reviewed-by: Daniel P. Berrangé though if you take my suggestion in the previous patch, then this patch should 'chmod +x' all the test files, and a

Re: [RFC PATCH 1/8] tests/pytest: Add base classes for the upcoming pytest-based tests

2024-07-12 Thread Daniel P . Berrangé
On Thu, Jul 11, 2024 at 01:55:39PM +0200, Thomas Huth wrote: > The file is a copy of the tests/avocado/avocado_qemu/__init__.py file > with some adjustments to get rid of the Avocado dependencies (i.e. > we also have to drop the LinuxSSHMixIn and LinuxTest for now). > > The emulator binary,

Re: [PATCH 04/14] qapi: add a 'command-features' pragma

2024-07-12 Thread Daniel P . Berrangé
On Fri, Jul 12, 2024 at 10:07:34AM +0200, Markus Armbruster wrote: > Daniel P. Berrangé writes: > > > The 'command-features' pragma allows for defining additional > > special features that are unique to a particular QAPI schema > > instance and its implementation. >

Re: [RFC PATCH 0/8] Convert avocado tests to normal Python unittests

2024-07-12 Thread Daniel P . Berrangé
On Thu, Jul 11, 2024 at 07:44:39PM +0200, Thomas Huth wrote: > On 11/07/2024 16.39, Fabiano Rosas wrote: > > Thomas Huth writes: > ... > > > Things that need further attention though: > > > > > > - All tests that use the LinuxTest / LinuxDistro classes (e.g. based > > >on cloud-init images)

Re: [PATCH] contrib/elf2dmp: a workaround for the buggy msvcrt.dll!fwrite

2024-07-11 Thread Daniel P . Berrangé
On Mon, Jul 08, 2024 at 07:25:20PM +0800, junjiehua wrote: > when building elf2dump with x86_64-w64-mingw32-gcc, fwrite is imported from > msvcrt.dll. However, the implementation of msvcrt.dll!fwrite is buggy: > it enters an infinite loop when the size of a single write exceeds 4GB. > This patch

Re: [PATCH] contrib/elf2dmp: a workaround for the buggy msvcrt.dll!fwrite

2024-07-11 Thread Daniel P . Berrangé
On Thu, Jul 11, 2024 at 04:53:50PM +0900, Akihiko Odaki wrote: > On 2024/07/10 17:02, hellord wrote: > > > > note: > > 1. The path of buggy msvcrt.dll is c:\windows\system32\msvcrt.dll( > > mingw64 links to it ); > > 2. fwrite implementation in another msvc library which is called > >

Re: [PATCH v1] target/i386: kvm: Block migration when enfore_cpuid is set to false

2024-07-11 Thread Daniel P . Berrangé
On Thu, Jul 11, 2024 at 03:09:28PM +, Wang, Wei W wrote: > On Thursday, July 11, 2024 10:14 PM, Daniel P. Berrangé wrote: > > On Thu, Jul 11, 2024 at 02:13:31PM +, Wang, Wei W wrote: > > > On Thursday, July 11, 2024 8:25 PM, Daniel P. Berrangé wrote: > > > >

Re: [PATCH v1] target/i386: kvm: Block migration when enfore_cpuid is set to false

2024-07-11 Thread Daniel P . Berrangé
On Thu, Jul 11, 2024 at 02:13:31PM +, Wang, Wei W wrote: > On Thursday, July 11, 2024 8:25 PM, Daniel P. Berrangé wrote: > > On Thu, Jul 11, 2024 at 12:10:34PM +, Wang, Wei W wrote: > > > On Thursday, July 11, 2024 7:48 PM, Daniel P. Berrangé wrote: > > > >

Re: [PATCH v1] target/i386: kvm: Block migration when enfore_cpuid is set to false

2024-07-11 Thread Daniel P . Berrangé
On Thu, Jul 11, 2024 at 01:48:59PM +, Wang, Wei W wrote: > On Thursday, July 11, 2024 8:25 PM, Daniel P. Berrangé wrote: > > On Thu, Jul 11, 2024 at 12:10:34PM +, Wang, Wei W wrote: > > > On Thursday, July 11, 2024 7:48 PM, Daniel P. Berrangé wrote: > > > >

Re: [RFC PATCH 0/8] Convert avocado tests to normal Python unittests

2024-07-11 Thread Daniel P . Berrangé
On Thu, Jul 11, 2024 at 01:55:38PM +0200, Thomas Huth wrote: > The Avocado v88 that we use in QEMU is already on a life support > system: It is not supported by upstream anymore, and with the latest > versions of Python, it won't work anymore since it depends on the > "imp" module that has been

Re: Avocado 88.1 vs Python 3.12

2024-07-11 Thread Daniel P . Berrangé
On Thu, Jul 11, 2024 at 02:01:25PM +0200, Thomas Huth wrote: > On 10/07/2024 01.45, Richard Henderson wrote: > > On 7/9/24 09:26, Philippe Mathieu-Daudé wrote: > > > On 9/7/24 17:41, Richard Henderson wrote: > > > > Hi guys, > > > > > > > > I have reinstalled my development box to ubuntu 24

Re: [PATCH v1] target/i386: kvm: Block migration when enfore_cpuid is set to false

2024-07-11 Thread Daniel P . Berrangé
On Thu, Jul 11, 2024 at 12:10:34PM +, Wang, Wei W wrote: > On Thursday, July 11, 2024 7:48 PM, Daniel P. Berrangé wrote: > > On Wed, Jul 03, 2024 at 10:49:12PM +0800, Wei Wang wrote: > > > When enforce_cpuid is set to false, the guest is launched with a > > > filter

Re: [PATCH v1] target/i386: kvm: Block migration when enfore_cpuid is set to false

2024-07-11 Thread Daniel P . Berrangé
On Wed, Jul 03, 2024 at 10:49:12PM +0800, Wei Wang wrote: > When enforce_cpuid is set to false, the guest is launched with a filtered > set of features, meaning that unsupported features by the host are removed > from the guest's vCPU model. This could cause issues for live migration. > For

Re: [PATCH] smbios: make memory device size configurable per Machine

2024-07-11 Thread Daniel P . Berrangé
On Thu, Jul 11, 2024 at 09:48:22AM +0200, Igor Mammedov wrote: > Currently SMBIOS maximum memory device chunk is capped at 16Gb, > which is fine for the most cases (QEMU uses it to describe initial > RAM (type 17 SMBIOS table entries)). > However when starting guest with terabytes of RAM this

Re: [PATCH v2 4/4] virtio-net: Remove fallback from ebpf-rss-fds

2024-07-10 Thread Daniel P . Berrangé
On Mon, Jul 08, 2024 at 04:38:09PM +0900, Akihiko Odaki wrote: > If ebpf-rss-fds is specified but we fail to use, we should not fall > back to loading eBPF programs by ourselves as such makes the situation > complicated. > > Suggested-by: Daniel P. Berrangé > Signed-off

Re: [PATCH v2 1/4] qdev-properties: Add DEFINE_PROP_ON_OFF_AUTO_BIT64()

2024-07-10 Thread Daniel P . Berrangé
On Mon, Jul 08, 2024 at 06:43:02AM -0400, Michael S. Tsirkin wrote: > On Mon, Jul 08, 2024 at 04:38:06PM +0900, Akihiko Odaki wrote: > > DEFINE_PROP_ON_OFF_AUTO_BIT64() corresponds to DEFINE_PROP_ON_OFF_AUTO() > > as DEFINE_PROP_BIT64() corresponds to DEFINE_PROP_BOOL(). The difference > > is that

Re: [PATCH] i386/sev: Don't allow automatic fallback to legacy KVM_SEV*_INIT

2024-07-10 Thread Daniel P . Berrangé
On Tue, Jul 09, 2024 at 11:03:19PM -0500, Michael Roth wrote: > On Thu, Jul 04, 2024 at 11:53:33AM +0200, Paolo Bonzini wrote: > > On Thu, Jul 4, 2024 at 11:39 AM Daniel P. Berrangé > > wrote: > > > > The debug_swap parameter simply could not be enabled in the old A

Re: [PATCH v2] i386/sev: Don't allow automatic fallback to legacy KVM_SEV*_INIT

2024-07-10 Thread Daniel P . Berrangé
ould only be used in cases > where users opt into newer features that are only available via > KVM_SEV_INIT2 and newer kernels, and provide better default behavior > than the legacy-vm-type=off behavior that was previously in place, so > make it the default for 9.1+ machine types.

Re: [PATCH] qdev-monitor: QAPIfy QMP device_add

2024-07-09 Thread Daniel P . Berrangé
milar reasoning. > > Markus helped me figure this out and even provided a draft patch. The > code ended up very close to what he suggested. > > Suggested-by: Markus Armbruster > Cc: Daniel P. Berrangé > Signed-off-by: Stefan Hajnoczi > --- > system/qdev-monitor.c | 4

Re: [RFC PATCH v4 2/7] rust: add bindgen step as a meson dependency

2024-07-09 Thread Daniel P . Berrangé
On Tue, Jul 09, 2024 at 02:28:38PM +0200, Paolo Bonzini wrote: > On Tue, Jul 9, 2024 at 2:09 PM Peter Maydell wrote: > > * what is the actual baseline requirement? We definitely want > >to support "using rustup on an older system" (should be no > >problem) and "current distro building

Re: [RFC PATCH v4 0/7] Add Rust support, implement ARM PL011

2024-07-09 Thread Daniel P . Berrangé
On Tue, Jul 09, 2024 at 09:54:43AM +0200, Paolo Bonzini wrote: > On Tue, Jul 9, 2024 at 9:38 AM Manos Pitsidianakis > wrote: > > Ah, alright. That wasn't obvious because that e-mail was not directed > > to me nor did it mention my name :) > > Oh, ok. Sorry about that. Generally when I say "we" I

Re: [RFC PATCH v4 0/7] Add Rust support, implement ARM PL011

2024-07-08 Thread Daniel P . Berrangé
On Mon, Jul 08, 2024 at 06:55:40PM +0200, Paolo Bonzini wrote: > Il lun 8 lug 2024, 18:33 Daniel P. Berrangé ha > scritto: > > > This series is still missing changes to enable build on all targets > > during CI, including cross-compiles, to prove that we're doing the > &g

  1   2   3   4   5   6   7   8   9   10   >