Re: [Qemu-devel] [PATCH] opts: fix NULL pointer derefernce in get_opt_value

On Mon, Jul 16, 2018 at 06:41:46PM +0100, Mike Krinkin wrote: > The value argument can be NULL, for example, in hw/i386/multiboot.c > in the load_multiboot function get_opt_value is explicitly called > with NULL as the second argument. > > The problem was introduced in commit 950c4e6c94b1 ("opts:

Re: [Qemu-devel] [PATCH v12 28/28] tests/qmp-test: blacklist sev specific qmp commands

On Thu, Mar 08, 2018 at 06:45:04PM -0300, Eduardo Habkost wrote: > On Thu, Mar 08, 2018 at 02:18:55PM -0600, Brijesh Singh wrote: > > > > > > On 3/8/18 11:08 AM, Daniel P. Berrangé wrote: > > > On Thu, Mar 08, 2018 at 06:49:01AM -0600, Brijesh Singh wrote: > > >> Blacklist the following commands

Re: [Qemu-devel] [PATCH v1 2/2] make: fix help message reference to bogus V=0 variable

On Tue, Jan 23, 2018 at 01:05:31PM -0600, Eric Blake wrote: > On 01/23/2018 10:47 AM, Daniel P. Berrange wrote: > > The make rules for building QEMU are mostly silent by default. They can > > be made verbose by setting the variable V=1. The default state does not > > howeve

Re: [Qemu-devel] [PULL 10/51] build-sys: silence make by default or V=0

On Tue, Jan 23, 2018 at 05:08:08PM +0100, Marc-Andre Lureau wrote: > Hi > > On Tue, Jan 23, 2018 at 4:38 PM, Daniel P. Berrange <berra...@redhat.com> > wrote: > > On Tue, Jan 16, 2018 at 03:16:52PM +0100, Paolo Bonzini wrote: > >> From: Marc-André Lu

[Qemu-devel] [PATCH v1 2/2] make: fix help message reference to bogus V=0 variable

The make rules for building QEMU are mostly silent by default. They can be made verbose by setting the variable V=1. The default state does not however correspond to a V=0 setting - $(V) must be undefined / empty to get the default quiet build. Signed-off-by: Daniel P. Berrange <be

[Qemu-devel] [PATCH v1 0/2] Two fixes to make rules

The primary goal of this was to fix the recent regression that made everything done by make completely silent, causing things like "make install" to emit no output. In doing so I noticed a small mistake in the help text. Daniel P. Berrange (2): Revert "build-sys: silence make by

[Qemu-devel] [PATCH v1 1/2] Revert "build-sys: silence make by default or V=0"

uiet to the SUBDIR_MAKEVARS variable, so it only affects us on recursive make calls. Signed-off-by: Daniel P. Berrange <berra...@redhat.com> --- Makefile | 2 +- rules.mak | 2 -- 2 files changed, 1 insertion(+), 3 deletions(-) diff --git a/Makefile b/Makefile index f26ef1b1df..c263190b8d 100644

Re: [Qemu-devel] [PULL 10/51] build-sys: silence make by default or V=0

On Tue, Jan 16, 2018 at 03:16:52PM +0100, Paolo Bonzini wrote: > From: Marc-André Lureau > > Move generic make flags in MAKEFLAGS (SUBDIR_MAKEFLAGS is more qemu specific). > > Use --quiet to silence make 'is up to date' message. > > Signed-off-by: Marc-André Lureau

Re: [Qemu-devel] [PATCH QEMU v1 0/4] multiboot: bss_end_addr can be zero / cleanup

On Fri, Jan 19, 2018 at 04:18:07PM -0800, Jack Schwartz wrote: > Hi Anatol, Daniel and Kevin. > > On 01/19/18 10:36, Anatol Pomozov wrote: > > Hello Jack > > > > On Wed, Jan 17, 2018 at 12:06 PM, Jack Schwartz > > wrote: > > > Hi Kevin and Anatol. > > > > > > Kevin,

Re: [Qemu-devel] [PATCH V4 2/7] CAN bus support to connect bust to Linux host SocketCAN interface.

On Mon, Jan 15, 2018 at 09:12:09PM -0300, Philippe Mathieu-Daudé wrote: > On 01/15/2018 06:29 PM, Pavel Pisa wrote: > >>> +/* open socket */ > >>> +s = socket(PF_CAN, SOCK_RAW, CAN_RAW); > >> > >> I never used it, but I think QEMU uses his socket API: "qemu/sockets.h" > > > > The

Re: [Qemu-devel] [PATCH] allow to build with older sed

> Signed-off-by: Jan Beulich <jbeul...@suse.com> Reviewed-by: Daniel P. Berrange <berra...@redhat.com> > --- a/Makefile > +++ b/Makefile > @@ -242,8 +242,7 @@ GENERATED_FILES += $(KEYCODEMAP_FILES) > > ui/input-keymap-%.c: $(KEYCODEMAP_GEN) $(KEYCODEMAP_CSV) > $(SR

Re: [Qemu-devel] [PATCH] block: implement the bdrv_reopen_prepare helper for LUKS driver

On Thu, Jan 18, 2018 at 01:51:36PM -0600, Eric Blake wrote: > On 01/18/2018 04:31 AM, Daniel P. Berrange wrote: > > If the bdrv_reopen_prepare helper isn't provided, the qemu-img commit > > command fails to re-open the base layer after committing changes into > > it. Provide a

[Qemu-devel] [PATCH] ui: avoid sign extension using client width/height

vs->client_width * vs->client_height * vs->client_pf.bytes_per_pixel; Change client_width / client_height to be a size_t to avoid sign extension and integer promotion. Then validate that dimensions are in range wrt the RFB protocol u16 limits. Signed-off-by: Daniel P. Berrang

Re: [Qemu-devel] [PULL 10/14] ui: fix VNC client throttling when audio capture is active

On Thu, Jan 18, 2018 at 02:54:48PM +0100, Paolo Bonzini wrote: > On 18/01/2018 14:36, Daniel P. Berrange wrote: > >>> +/* > >>> + * Figure out how much pending data we should allow in the output > >>> + * buffer before we throttle incremental display updat

Re: [Qemu-devel] [PATCH v2 0/4] QIOChannelFile bug fixes

On Wed, Nov 01, 2017 at 02:25:22PM +, Ross Lagerwall wrote: > Hi, > > Here is a bug fix with the use of QIOChannelFile and 2 bug fixes and an > improvement to implementation of QIOChannelFile. > > Regards, > Ross Lagerwall > > Ross Lagerwall (4): > migration: Don't leak IO channels >

Re: [Qemu-devel] [PATCH v2 4/4] io: Add /dev/fdset/ support to QIOChannelFile

esn't affect any of the users of the function. > > Signed-off-by: Ross Lagerwall <ross.lagerw...@citrix.com> > --- > Changed in v2: > * Split into separate patch. > > io/channel-file.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) Reviewed-by: Daniel

Re: [Qemu-devel] [PATCH v2 3/4] io: Don't call close multiple times in QIOChannelFile

ed-off-by: Ross Lagerwall <ross.lagerw...@citrix.com> > --- > New in v2. > > io/channel-file.c | 1 + > 1 file changed, 1 insertion(+) Reviewed-by: Daniel P. Berrange <berra...@redhat.com> Regards, Daniel -- |: https://berrange.com -o-https://www.flickr.com/

Re: [Qemu-devel] [PATCH v2 2/4] io: Fix QIOChannelFile when creating and opening read-write

from qemu_open() change. > > include/io/channel-file.h| 2 +- > io/channel-file.c| 6 +- > tests/test-io-channel-file.c | 29 + > 3 files changed, 27 insertions(+), 10 deletions(-) Reviewed-by: Daniel P. Berrange <berra...@

Re: [Qemu-devel] [PATCH v2 0/4] QIOChannelFile bug fixes

upport to QIOChannelFile > > > > include/io/channel-file.h| 2 +- > > io/channel-file.c| 11 --- > > migration/savevm.c | 2 ++ > > tests/test-io-channel-file.c | 29 + > > 4 files changed, 32

Re: [Qemu-devel] [PATCH v2 1/4] migration: Don't leak IO channels

w in v2. > > migration/savevm.c | 2 ++ > 1 file changed, 2 insertions(+) Reviewed-by: Daniel P. Berrange <berra...@redhat.com> > > diff --git a/migration/savevm.c b/migration/savevm.c > index 4a88228..87557dd 100644 > --- a/migration/savevm.c >

Re: [Qemu-devel] [PULL 10/14] ui: fix VNC client throttling when audio capture is active

On Thu, Jan 18, 2018 at 01:29:35PM +, Peter Maydell wrote: > On 12 January 2018 at 12:58, Gerd Hoffmann <kra...@redhat.com> wrote: > > From: "Daniel P. Berrange" <berra...@redhat.com> > > > > The VNC server must throttle data sent to the client to p

Re: [Qemu-devel] [PATCH QEMU v1 0/4] multiboot: bss_end_addr can be zero / cleanup

On Thu, Jan 18, 2018 at 12:35:00PM +0100, Kevin Wolf wrote: > Am 17.01.2018 um 21:06 hat Jack Schwartz geschrieben: > > Before I proceed with adding my multiboot test file, I'll clarify here that > > I started with a version from the grub2 tree.  In that file I expanded a > > header file, also

Re: [Qemu-devel] Do I need update the microcode of virtual machine

On Thu, Jan 18, 2018 at 06:38:57PM +0800, Li Qiang wrote: > Hi Paolo, all, > > I have a question about the intel microcode update for spectre variant#2. > From my understanding, there is no need to update the microcode of VMs > because the kvm has expose the SPEC_CTL and PRED_CMD to the guest. >

[Qemu-devel] [PATCH] block: implement the bdrv_reopen_prepare helper for LUKS driver

If the bdrv_reopen_prepare helper isn't provided, the qemu-img commit command fails to re-open the base layer after committing changes into it. Provide a no-op implementation for the LUKS driver, since there is not any custom work that needs doing to re-open it. Signed-off-by: Daniel P. Berrange

Re: [Qemu-devel] [PATCH] chardev/char-socket: add POLLHUP handler

On Thu, Jan 18, 2018 at 12:41:08PM +0300, klim wrote: > On 01/16/2018 08:25 PM, Paolo Bonzini wrote: > > On 10/01/2018 14:18, Klim Kireev wrote: > > > The following behavior was observed for QEMU configured by libvirt > > > to use guest agent as usual for the guests without virtio-serial > > >

[Qemu-devel] [PATCH v7 3/4] ui: fix alphabetical ordering of keymaps

eymaps Signed-off-by: Daniel P. Berrange <berra...@redhat.com> --- Makefile | 2 +- include/ui/input.h | 6 +++--- ui/input-keymap.c | 2 +- 3 files changed, 5 insertions(+), 5 deletions(-) diff --git a/Makefile b/Makefile index c62e96b6c7..e3f960905f 100644 --- a/Makefile ++

[Qemu-devel] [PATCH v7 2/4] ui: convert GTK and SDL1 frontends to keycodemapdb

map_windowing(const char *name) "backend=%s" # ui/vnc.c vnc_key_guest_leds(bool caps, bool num, bool scroll) "caps %d, num %d, scroll %d" @@ -79,3 +80,9 @@ qemu_spice_create_update(uint32_t left, uint32_t right, uint32_t top, uint32_t b keymap_parse(const char *file) "file %

[Qemu-devel] [PATCH v7 3/4] ui: add fix for GTK Pause key handling on Win32

Versions of GTK prior to 3.22 did not correctly set the keyval field when VK_PAUSE was received on Windows. Signed-off-by: Daniel P. Berrange <berra...@redhat.com> --- ui/gtk.c | 9 - 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/ui/gtk.c b/ui/gtk.c index 1217

[Qemu-devel] [PATCH v7 0/4] Convert frontends to use keycodemapdb

hack Daniel P. Berrange (4): ui: convert the SDL2 frontend to keycodemapdb ui: convert GTK and SDL1 frontends to keycodemapdb ui: add fix for GTK Pause key handling on Win32 ui: ignore hardware keycode 255 on win32 Makefile | 8 ++ include/ui/input.h | 24 + ui

[Qemu-devel] [PATCH v7 4/4] hw: convert virtio-input-hid device to keycodemapdb

this behaviour should perhaps be formalized in the virtio-input spec to declare how guest OS drivers should be written to be robust in their handling of the potentially changable key bitmaps. Signed-off-by: Daniel P. Berrange <berra...@redhat.com> --- hw/input/virtio-input-hid.c | 136 +++--

[Qemu-devel] [PATCH v7 1/4] hw: convert ps2 device to keycodemapdb

ODE_CALCULATOR -> 0xa3 - Q_KEY_CODE_AC_HOME -> 0x97 And some mistakes corrected: - Q_KEY_CODE_MENU was incorrectly mapped to the compose scancode (0x8d) and is now 0x91 Signed-off-by: Daniel P. Berrange <berra...@redhat.com> --- Makefile | 3 + hw/input/ps2.c

[Qemu-devel] [PATCH v7 0/4] Convert hw backends to use keycodemapdb

benefit is adding various missing key mappings that were previously accidentally left out Changed in v7: - Drop Xen patch as equiv already merged - Add patch to fix keycodemap ordering in source Daniel P. Berrange (4): hw: convert ps2 device to keycodemapdb hw: convert the escc device

[Qemu-devel] [PATCH v7 1/4] ui: convert the SDL2 frontend to keycodemapdb

0xf1 -> Q_KEY_CODE_AC_BACK - 0xf2 -> Q_KEY_CODE_AC_FORWARD - 0xf3 -> Q_KEY_CODE_STOP - 0xf4 -> Q_KEY_CODE_FIND - 0xf8 -> Q_KEY_CODE_SLEEP - 0xfa -> Q_KEY_CODE_AC_REFRESH - 0xfb -> Q_KEY_CODE_CALCULATOR And some mistakes corrected: - 0x65 -> Q_KEY_COD

[Qemu-devel] [PATCH v7 4/4] ui: ignore hardware keycode 255 on win32

It is a reserved value and doesn't have a corresponding valid scancode. Signed-off-by: Daniel P. Berrange <berra...@redhat.com> --- ui/gtk.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/ui/gtk.c b/ui/gtk.c index 188c40eef5..f0ad63e431 100644 --- a/ui/gtk.c +++ b/ui/gtk.c @@ -

[Qemu-devel] [PATCH v7 2/4] hw: convert the escc device to keycodemapdb

Replace the qcode_to_keycode table with automatically generated tables. Missing entries in qcode_to_keycode now fixed: - Q_KEY_CODE_KP_COMMA -> 0x2d Signed-off-by: Daniel P. Berrange <berra...@redhat.com> --- Makefile | 1 + hw/char/escc.c

Re: [Qemu-devel] [RFC PATCH 1/3] compiler: add QEMU_WARN_NONNULL_ARGS()

On Wed, Jan 17, 2018 at 11:33:34AM -0300, Philippe Mathieu-Daudé wrote: > On 01/17/2018 10:32 AM, Daniel P. Berrange wrote: > > On Wed, Jan 17, 2018 at 10:18:19AM -0300, Philippe Mathieu-Daudé wrote: > >> Signed-off-by: Philippe Mathieu-Daudé <f4...@amsat.org> >

Re: [Qemu-devel] [PATCH 0/7] docker: update Ubuntu and Fedora images, deprecate old ones

On Wed, Jan 17, 2018 at 10:58:21AM -0300, Philippe Mathieu-Daudé wrote: > On 01/17/2018 07:25 AM, Daniel P. Berrange wrote: > > On Wed, Jan 17, 2018 at 10:26:36AM +0800, Fam Zheng wrote: > >> On 01/12/2018 08:49 PM, Philippe Mathieu-Daudé wrote: > >>> Hi, > >&

Re: [Qemu-devel] [RFC PATCH 1/3] compiler: add QEMU_WARN_NONNULL_ARGS()

On Wed, Jan 17, 2018 at 10:18:19AM -0300, Philippe Mathieu-Daudé wrote: > Signed-off-by: Philippe Mathieu-Daudé > --- > include/qemu/compiler.h | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/include/qemu/compiler.h b/include/qemu/compiler.h > index

Re: [Qemu-devel] [PATCH] Add ability to provide ifname when using netdev bridge or tap helper

On Wed, Jan 17, 2018 at 06:53:30PM +0800, Jason Wang wrote: > > > On 2018年01月17日 18:31, Daniel P. Berrange wrote: > > On Tue, Jan 16, 2018 at 03:18:24PM -0800, Shaun Reitan wrote: > > > This patch replaces the patch I sent yesturday. This one fixes > > >

Re: [Qemu-devel] [PATCH] Add ability to provide ifname when using netdev bridge or tap helper

On Tue, Jan 16, 2018 at 03:18:24PM -0800, Shaun Reitan wrote: > This patch replaces the patch I sent yesturday. This one fixes > a bug in my original code as well as corrects a few styling > issues. Hopfully this one comes out correct! Sorry for the > inconvienece. > > When currently using

Re: [Qemu-devel] [PATCH 0/7] docker: update Ubuntu and Fedora images, deprecate old ones

On Wed, Jan 17, 2018 at 10:26:36AM +0800, Fam Zheng wrote: > > > On 01/12/2018 08:49 PM, Philippe Mathieu-Daudé wrote: > > Hi, > > > > This series is to be clearer about which upstream version we are using. > > > > All "FROM distrib:latest" entries have now been removed and replaced by > >

Re: [Qemu-devel] [PATCH] chardev/char-socket: add POLLHUP handler

On Tue, Jan 16, 2018 at 06:56:20PM +0100, Marc-André Lureau wrote: > Hi > > On Wed, Jan 10, 2018 at 2:18 PM, Klim Kireev > wrote: > > The following behavior was observed for QEMU configured by libvirt > > to use guest agent as usual for the guests without

Re: [Qemu-devel] [PATCH x86-next v2] target-i386: add PCID flag to Westmere, Sandy Bridge and Ivy Bridge

On Tue, Jan 16, 2018 at 03:08:15PM -0200, Eduardo Habkost wrote: > [CCing Daniel] > > On Tue, Jan 16, 2018 at 04:33:00PM +0100, Kashyap Chamarthy wrote: > > On Tue, Jan 16, 2018 at 01:55:22PM +0100, Vincent Bernat wrote: > > > ❦ 16 janvier 2018 10:41 -0200, Eduardo Habkost  

Re: [Qemu-devel] [PULL 08/51] chardev: introduce qemu_chr_timeout_add_ms()

On Tue, Jan 16, 2018 at 03:16:50PM +0100, Paolo Bonzini wrote: > From: Peter Xu > > It's a replacement of g_timeout_add[_seconds]() for chardevs. Chardevs > now can have dedicated gcontext, we should always bind chardev tasks > onto those gcontext rather than the default main

[Qemu-devel] [PATCH v5 12/14] ui: update keycodemapdb to get py3 fixes

Signed-off-by: Daniel P. Berrange <berra...@redhat.com> --- ui/keycodemapdb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ui/keycodemapdb b/ui/keycodemapdb index 05dad417e9..6b3d716e2b 16 --- a/ui/keycodemapdb +++ b/ui/keycodemapdb @@ -1 +1 @@ -Subproject

[Qemu-devel] [PATCH v5 11/14] input: add missing JIS keys to virtio input

From: Miika S keycodemapdb updated to add the QKeyCodes muhenkan and katakanahiragana Signed-off-by: Miika S --- hw/input/virtio-input-hid.c | 7 +++ qapi/ui.json| 5 - ui/keycodemapdb | 2 +- 3 files changed, 12

[Qemu-devel] [PATCH v5 09/14] scripts: ensure signrom treats data as bytes

Reviewed-by: Philippe Mathieu-Daudé <f4...@amsat.org> Signed-off-by: Daniel P. Berrange <berra...@redhat.com> --- scripts/signrom.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/scripts/signrom.py b/scripts/signrom.py index d1dabe0240..0497a1c32e 100644 -

[Qemu-devel] [PATCH v5 04/14] qapi: adapt to moved location of StringIO module in py3

Reviewed-by: Philippe Mathieu-Daudé <f4...@amsat.org> Signed-off-by: Daniel P. Berrange <berra...@redhat.com> --- scripts/qapi.py | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/scripts/qapi.py b/scripts/qapi.py index 514b7bb5a4..514cca44bf 100644 --- a/scr

[Qemu-devel] [PATCH v5 06/14] qapi: remove '-q' arg to diff when comparing QAPI output

of the incorrect output. Reviewed-by: Eric Blake <ebl...@redhat.com> Signed-off-by: Daniel P. Berrange <berra...@redhat.com> --- tests/Makefile.include | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/tests/Makefile.include b/tests/Makefile.include index 39a4b5359d..d65fb

[Qemu-devel] [PATCH v5 01/14] qapi: convert to use python print function instead of statement

easy to support Python 2 and 3 in parallel. Reviewed-by: Philippe Mathieu-Daudé <f4...@amsat.org> Signed-off-by: Daniel P. Berrange <berra...@redhat.com> --- scripts/qapi.py| 12 ++-- scripts/qapi2texi.py | 9 + tests/qapi-schema/test-qapi.py | 41 ++

[Qemu-devel] [PATCH v5 14/14] docker: change Fedora images to run with python3

Fedora has switched to Python 3 by default, so it makes sense to use that for testing QEMU builds, so we get testing of Python 3 compatibility. Signed-off-by: Daniel P. Berrange <berra...@redhat.com> --- tests/docker/dockerfiles/fedora.docker | 3 ++- 1 file changed, 2 insertions(+), 1 de

[Qemu-devel] [PATCH v5 02/14] qapi: use items()/values() intead of iteritems()/itervalues()

Mathieu-Daudé <f4...@amsat.org> Signed-off-by: Daniel P. Berrange <berra...@redhat.com> --- scripts/qapi.py| 12 ++-- scripts/qapi2texi.py | 2 +- tests/qapi-schema/test-qapi.py | 2 +- 3 files changed, 8 insertions(+), 8 deletions(-) diff --git a/scrip

[Qemu-devel] [PATCH v5 00/14] Support building with py2 or py3

images - Fix for sort ordering to fix 'make check-qapi-schema' - Fix for signrom data Daniel P. Berrange (13): qapi: convert to use python print function instead of statement qapi: use items()/values() intead of iteritems()/itervalues() qapi: Use OrderedDict from standard library if available

[Qemu-devel] [PATCH v5 13/14] travis: improve python version test coverage

test matrix entries to build with python 3.0 and 3.6, to extend coverage of python versions, without increasing job count or build time. Signed-off-by: Daniel P. Berrange <berra...@redhat.com> --- .travis.yml | 14 +- 1 file changed, 9 insertions(+), 5 deletions(-) diff

[Qemu-devel] [PATCH v5 10/14] configure: allow use of python 3

Signed-off-by: Daniel P. Berrange <berra...@redhat.com> --- configure | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/configure b/configure index b272a0336b..60b99f45f6 100755 --- a/configure +++ b/configure @@ -1598,9 +1598,8 @@ fi # Note that if the

[Qemu-devel] [PATCH v5 08/14] qapi: force a UTF-8 locale for running Python

y close to C.UTF-8, but in a way that should be portable to everywhere QEMU builds. This patch only forces UTF-8 for QAPI scripts, since that is the one showing the immediate error under Python3 with C locale, but potentially we ought to force this for all python scripts used in the build process.

[Qemu-devel] [PATCH v5 03/14] qapi: Use OrderedDict from standard library if available

The OrderedDict class appeared in the 'collections' module from python 2.7 onwards, so use that in preference to our local backport if available. Reviewed-by: Philippe Mathieu-Daudé <f4...@amsat.org> Signed-off-by: Daniel P. Berrange <berra...@redhat.com> --- scripts/qapi.py | 5 +

[Qemu-devel] [PATCH v5 07/14] qapi: ensure stable sort ordering when checking QAPI entities

Some early python 3.x versions will have different default ordering when calling the 'values()' method on a dict, compared to python 2.x and later 3.x versions. Explicitly sort the items to get a stable ordering. Reviewed-by: Philippe Mathieu-Daudé <f4...@amsat.org> Signed-off-by: Da

[Qemu-devel] [PATCH v5 05/14] qapi: Adapt to moved location of 'maketrans' function in py3

Reviewed-by: Eric Blake <ebl...@redhat.com> Signed-off-by: Daniel P. Berrange <berra...@redhat.com> --- scripts/qapi.py | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/scripts/qapi.py b/scripts/qapi.py index 514cca44bf..1fdd189c0d 100644 --- a/scripts/qapi.py +

Re: [Qemu-devel] RFE for patchew docker result reporting

On Tue, Jan 16, 2018 at 10:16:28AM +0800, Fam Zheng wrote: > On Mon, Jan 15, 2018 at 8:26 PM, Cornelia Huck <coh...@redhat.com> wrote: > > On Mon, 15 Jan 2018 11:48:41 +0000 > > "Daniel P. Berrange" <berra...@redhat.com> wrote: > > > >> Curre

Re: [Qemu-devel] [PATCH v4 10/13] input: add missing JIS keys to virtio input

On Mon, Jan 15, 2018 at 11:17:15AM -0600, Eric Blake wrote: > On 01/15/2018 11:02 AM, Daniel P. Berrange wrote: > > From: Miika S <miika9...@gmail.com> > > > > keycodemapdb updated to add the QKeyCodes muhenkan and katakanahiragana > > > > Sign

Re: [Qemu-devel] [PATCH v4 07/13] qapi: force a UTF-8 locale for running Python

On Mon, Jan 15, 2018 at 11:15:01AM -0600, Eric Blake wrote: > On 01/15/2018 11:02 AM, Daniel P. Berrange wrote: > > Python2 did not validate locale correctness when reading input data, so > > would happily read UTF-8 data in non-UTF-8 locales. Python3 is strict so > > if you t

[Qemu-devel] [PATCH v4 13/13] docker: change Fedora images to run with python3

Fedora has switched to Python 3 by default, so it makes sense to use that for testing QEMU builds, so we get testing of Python 3 compatibility. Signed-off-by: Daniel P. Berrange <berra...@redhat.com> --- tests/docker/dockerfiles/fedora.docker | 3 ++- 1 file changed, 2 insertions(+), 1 de

[Qemu-devel] [PATCH v4 11/13] ui: update keycodemapdb to get py3 fixes

Signed-off-by: Daniel P. Berrange <berra...@redhat.com> --- ui/keycodemapdb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ui/keycodemapdb b/ui/keycodemapdb index 05dad417e9..6b3d716e2b 16 --- a/ui/keycodemapdb +++ b/ui/keycodemapdb @@ -1 +1 @@ -Subproject

[Qemu-devel] [PATCH v4 09/13] configure: allow use of python 3

Signed-off-by: Daniel P. Berrange <berra...@redhat.com> --- configure | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/configure b/configure index b272a0336b..60b99f45f6 100755 --- a/configure +++ b/configure @@ -1598,9 +1598,8 @@ fi # Note that if the

[Qemu-devel] [PATCH v4 07/13] qapi: force a UTF-8 locale for running Python

of the user's locale settings. This patch only forces UTF-8 for QAPI scripts, since that is the one showing the immediate error under Python3 with C locale, but potentially we ought to force this for all python scripts used in the build process. Signed-off-by: Daniel P. Berrange <berra...@redhat

[Qemu-devel] [PATCH v4 05/13] qapi: remove '-q' arg to diff when comparing QAPI output

of the incorrect output. Signed-off-by: Daniel P. Berrange <berra...@redhat.com> --- tests/Makefile.include | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/tests/Makefile.include b/tests/Makefile.include index 39a4b5359d..d65fb4e1b3 100644 --- a/tests/Makefile.include +++ b

[Qemu-devel] [PATCH v4 10/13] input: add missing JIS keys to virtio input

From: Miika S keycodemapdb updated to add the QKeyCodes muhenkan and katakanahiragana Signed-off-by: Miika S --- hw/input/virtio-input-hid.c | 7 +++ qapi/ui.json| 5 - ui/keycodemapdb | 2 +- 3 files changed, 12

[Qemu-devel] [PATCH v4 04/13] qapi: Adapt to moved location of 'maketrans' function in py3

Signed-off-by: Daniel P. Berrange <berra...@redhat.com> --- scripts/qapi.py | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/scripts/qapi.py b/scripts/qapi.py index 514cca44bf..1fdd189c0d 100644 --- a/scripts/qapi.py +++ b/scripts/qapi.py @@ -1734,7 +1734,10

[Qemu-devel] [PATCH v4 08/13] scripts: ensure signrom treats data as bytes

Reviewed-by: Philippe Mathieu-Daudé <f4...@amsat.org> Signed-off-by: Daniel P. Berrange <berra...@redhat.com> --- scripts/signrom.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/scripts/signrom.py b/scripts/signrom.py index d1dabe0240..0497a1c32e 100644 -

[Qemu-devel] [PATCH v4 03/13] qapi: adapt to moved location of StringIO module in py3

Reviewed-by: Philippe Mathieu-Daudé <f4...@amsat.org> Signed-off-by: Daniel P. Berrange <berra...@redhat.com> --- scripts/qapi.py | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/scripts/qapi.py b/scripts/qapi.py index 514b7bb5a4..514cca44bf 100644 --- a/scr

[Qemu-devel] [PATCH v4 06/13] qapi: ensure stable sort ordering when checking QAPI entities

Some early python 3.x versions will have different default ordering when calling the 'values()' method on a dict, compared to python 2.x and later 3.x versions. Explicitly sort the items to get a stable ordering. Reviewed-by: Philippe Mathieu-Daudé <f4...@amsat.org> Signed-off-by: Da

[Qemu-devel] [PATCH v4 12/13] travis: improve python version test coverage

test matrix entries to build with python 3.0 and 3.6, to extend coverage of python versions, without increasing job count or build time. Signed-off-by: Daniel P. Berrange <berra...@redhat.com> --- .travis.yml | 14 +- 1 file changed, 9 insertions(+), 5 deletions(-) diff

[Qemu-devel] [PATCH v4 01/13] qapi: use items()/values() intead of iteritems()/itervalues()

Mathieu-Daudé <f4...@amsat.org> Signed-off-by: Daniel P. Berrange <berra...@redhat.com> --- scripts/qapi.py| 24 +++ scripts/qapi2texi.py | 11 ++- tests/qapi-schema/test-qapi.py | 43 +- 3 files

[Qemu-devel] [PATCH v4 02/13] qapi: Use OrderedDict from standard library if available

The OrderedDict class appeared in the 'collections' module from python 2.7 onwards, so use that in preference to our local backport if available. Reviewed-by: Philippe Mathieu-Daudé <f4...@amsat.org> Signed-off-by: Daniel P. Berrange <berra...@redhat.com> --- scripts/qapi.py | 5 +

[Qemu-devel] [PATCH v4 00/13] Support building with py2 or py3

ble testing with Fedora Docker images - Fix for sort ordering to fix 'make check-qapi-schema' - Fix for signrom data Daniel P. Berrange (12): qapi: use items()/values() intead of iteritems()/itervalues() qapi: Use OrderedDict from standard library if available qapi: adapt to moved locat

Re: [Qemu-devel] [PATCH v2 6/8] docker: add the Fedora 27 base image

On Mon, Jan 15, 2018 at 11:34:57AM -0300, Philippe Mathieu-Daudé wrote: > straight copy on Fedora 25 base. > > Suggested-by: Paolo Bonzini > Signed-off-by: Philippe Mathieu-Daudé > --- > tests/docker/dockerfiles/fedora27.docker | 18 ++ > 1

Re: [Qemu-devel] [PATCH v2 3/8] docker: add the Ubuntu Trusty base image

On Mon, Jan 15, 2018 at 11:34:54AM -0300, Philippe Mathieu-Daudé wrote: > based on QEMU v2.10 ubuntu.docker (ca853f0c76e3 and 2346b12fc52d) > > Signed-off-by: Philippe Mathieu-Daudé > --- > tests/docker/dockerfiles/ubuntu14.04.docker | 17 + > 1 file changed, 17

Re: [Qemu-devel] [PATCH 0/3] input: add keys and mouse buttons to virtio input

On Mon, Jan 15, 2018 at 04:18:53PM +0100, Gerd Hoffmann wrote: > Hi, > > > Miika S (3): > > input: add mouse side buttons to virtio input > > input: virtio: don't send mouse wheel event twice > > Cherry-picked these two ad the kbd update depends on the not-yet merged > keycodemapdb update

[Qemu-devel] [PATCH] ui: deprecate use of SDL 1.2 in favour of 2.0 series

, SDL 2.0 will be more than 5 years old. Signed-off-by: Daniel P. Berrange <berra...@redhat.com> --- configure | 6 ++ qemu-doc.texi | 7 +++ ui/sdl.c | 3 +++ 3 files changed, 16 insertions(+) diff --git a/configure b/configure index b272a0336b..dc2615a0cb 100755 --- a/con

Re: [Qemu-devel] [RFC PATCH 02/10] block/qapi: Add qcow2 create options to schema

On Mon, Jan 15, 2018 at 03:07:15PM +0100, Kevin Wolf wrote: > Am 15.01.2018 um 14:51 hat Daniel P. Berrange geschrieben: > > On Mon, Jan 15, 2018 at 02:38:48PM +0100, Kevin Wolf wrote: > > > Am 12.01.2018 um 11:53 hat Daniel P. Berrange geschrieben: > > > > On Thu, Ja

Re: [Qemu-devel] [RFC PATCH 02/10] block/qapi: Add qcow2 create options to schema

On Mon, Jan 15, 2018 at 02:38:48PM +0100, Kevin Wolf wrote: > Am 12.01.2018 um 11:53 hat Daniel P. Berrange geschrieben: > > On Thu, Jan 11, 2018 at 08:52:17PM +0100, Kevin Wolf wrote: > > > Signed-off-by: Kevin Wolf <kw...@redhat.com> > > > ---

[Qemu-devel] RFE for patchew docker result reporting

Currently if I look at the patchew website for build logs, the 'docker' job results are listed as a single expandable item. Patchew runs 3 separate docker builds, however, and there's a tonne of output to scroll through to find which one actually failed. Thus, my RFE is to split the build log up

Re: [Qemu-devel] [PATCH v3 13/13] docker: change Fedora images to run with python3

On Mon, Jan 15, 2018 at 07:47:29AM -0300, Philippe Mathieu-Daudé wrote: > Hi Daniel, > > On 01/15/2018 07:26 AM, Daniel P. Berrange wrote: > > Fedora has switched to Python 3 by default, so it makes sense to use that > > for testing QEMU builds, so we get testing of P

Re: [Qemu-devel] [PATCH 1/3] input: add missing JIS keys to virtio input

- > ui/keycodemapdb | 2 +- > 3 files changed, 12 insertions(+), 2 deletions(-) Reviewed-by: Daniel P. Berrange <berra...@redhat.com> Regards, Daniel -- |: https://berrange.com -o-https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o-

[Qemu-devel] [PATCH v3 11/13] ui: update keycodemapdb to get py3 fixes

Signed-off-by: Daniel P. Berrange <berra...@redhat.com> --- ui/keycodemapdb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ui/keycodemapdb b/ui/keycodemapdb index 05dad417e9..6b3d716e2b 16 --- a/ui/keycodemapdb +++ b/ui/keycodemapdb @@ -1 +1 @@ -Subproject

[Qemu-devel] [PATCH v3 09/13] configure: allow use of python 3

Signed-off-by: Daniel P. Berrange <berra...@redhat.com> --- configure | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/configure b/configure index b272a0336b..60b99f45f6 100755 --- a/configure +++ b/configure @@ -1598,9 +1598,8 @@ fi # Note that if the

[Qemu-devel] [PATCH v3 08/13] scripts: ensure signrom treats data as bytes

Signed-off-by: Daniel P. Berrange <berra...@redhat.com> --- scripts/signrom.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/scripts/signrom.py b/scripts/signrom.py index d1dabe0240..0497a1c32e 100644 --- a/scripts/signrom.py +++ b/scripts/signrom.py @@ -18,7

[Qemu-devel] [PATCH v3 13/13] docker: change Fedora images to run with python3

Fedora has switched to Python 3 by default, so it makes sense to use that for testing QEMU builds, so we get testing of Python 3 compatibility. Signed-off-by: Daniel P. Berrange <berra...@redhat.com> --- tests/docker/dockerfiles/fedora.docker | 3 ++- 1 file changed, 2 insertions(+), 1 de

[Qemu-devel] [PATCH v3 12/13] travis: improve python version test coverage

test matrix entries to build with python 3.0 and 3.6, to extend coverage of python versions, without increasing job count or build time. Signed-off-by: Daniel P. Berrange <berra...@redhat.com> --- .travis.yml | 14 +- 1 file changed, 9 insertions(+), 5 deletions(-) diff

[Qemu-devel] [PATCH v3 05/13] qapi: Adapt to moved location of 'maketrans' function in py3

Signed-off-by: Daniel P. Berrange <berra...@redhat.com> --- scripts/qapi.py | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/scripts/qapi.py b/scripts/qapi.py index eaa63a58be..b6a7b5139f 100644 --- a/scripts/qapi.py +++ b/scripts/qapi.py @@ -1734,7 +1734,10

[Qemu-devel] [PATCH v3 06/13] qapi: remove '-q' arg to diff when comparing QAPI output

of the incorrect output. Signed-off-by: Daniel P. Berrange <berra...@redhat.com> --- tests/Makefile.include | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/tests/Makefile.include b/tests/Makefile.include index 39a4b5359d..d65fb4e1b3 100644 --- a/tests/Makefile.include +++ b

[Qemu-devel] [PATCH v3 07/13] qapi: ensure stable sort ordering when checking QAPI entities

Some early python 3.x versions will have different default ordering when calling the 'values()' method on a dict, compared to python 2.x and later 3.x versions. Explicitly sort the items to get a stable ordering. Signed-off-by: Daniel P. Berrange <berra...@redhat.com> --- scripts/qapi.

[Qemu-devel] [PATCH v3 04/13] qapi: adapt to moved location of StringIO module in py3

Signed-off-by: Daniel P. Berrange <berra...@redhat.com> --- scripts/qapi.py | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/scripts/qapi.py b/scripts/qapi.py index 7ec2e00b2c..eaa63a58be 100644 --- a/scripts/qapi.py +++ b/scripts/qapi.py @@ -22,6 +22,10

[Qemu-devel] [PATCH v3 10/13] input: add missing JIS keys to virtio input

From: Miika S keycodemapdb updated to add the QKeyCodes muhenkan and katakanahiragana Signed-off-by: Miika S --- hw/input/virtio-input-hid.c | 7 +++ qapi/ui.json| 5 - ui/keycodemapdb | 2 +- 3 files changed, 12

[Qemu-devel] [PATCH v3 00/13] Support building with py2 or py3

ary pre-requisite of pulling in the keycodemapdb update. Changes since v2: - Pull in fix for keycodemapdb - Enable testing with Travis - Enable testing with Fedora Docker images - Fix for sort ordering to fix 'make check-qapi-schema' - Fix for signrom data Daniel P. Berrange (12): q

[Qemu-devel] [PATCH v3 02/13] qapi: use items()/values() intead of iteritems()/itervalues()

The iteritems()/itervalues() methods are gone in py3, but the items()/values() methods are still around. The latter are less efficient than the former in py2, but this has unmeasurably small impact on QEMU build time, so taking portability over efficiency is a net win Signed-off-by: Daniel P

[Qemu-devel] [PATCH v3 03/13] qapi: Use OrderedDict from standard library if available

The OrderedDict class appeared in the 'collections' module from python 2.7 onwards, so use that in preference to our local backport if available. Signed-off-by: Daniel P. Berrange <berra...@redhat.com> --- scripts/qapi.py | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff

[Qemu-devel] [PATCH v3 01/13] qapi: convert to use python print function instead of statement

Get Py2 + 3 compatibility by using the print function instead of print statement. This works for 2.6 onwards. Signed-off-by: Daniel P. Berrange <berra...@redhat.com> --- scripts/qapi.py| 12 ++-- scripts/qapi2texi.py | 9 + tests/qapi-schem

Re: [Qemu-devel] [PATCH v4] Add ability for user to specify mouse ungrab key

On Fri, Jan 12, 2018 at 10:15:24PM -0500, Programmingkid wrote: > > > On Jan 10, 2018, at 11:14 AM, Daniel P. Berrange <berra...@redhat.com> > > wrote: > > > > On Tue, Dec 26, 2017 at 08:14:28PM -0500, John Arbuckle wrote: > >> Currently the u

  1   2   3   4   5   6   7   8   9   10   >