Introduce accessor function to know INTx levels.
It will be used later by q35.
Although piix_pci tracks the intx line levels, it can be eliminated
by this helper function.
Cc: Michael S. Tsirkin m...@redhat.com
Signed-off-by: Isaku Yamahata yamah...@valinux.co.jp
---
hw/pci.c |7 +++
hw
It looks good, except the unnecessary black line after return 0;
Reviewed-by: Isaku Yamahata yamah...@valinux.co.jp
On Thu, Mar 17, 2011 at 01:00:54PM +0300, Michael Tokarev wrote:
This patch almost rewrites acpi_table_add() function
(but still leaves it using old get_param_value() interface
[810ae364] ? sys_ioctl+0x42/0x65
[81001f3b] ? system_call_fastpath+0x16/0x1b
handlers:
[8120e3c5] (e1000_intr+0x0/0x103)
Disabling IRQ #18
Signed-off-by: Isaku Yamahata yamah...@valinux.co.jp
---
hw/ioapic.c |1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff
pci_bridge_to_pci() which converts PCIBridge into PCIDevice which will
be used later by pci_p2pbr.
Cc: Michael S. Tsirkin m...@redhat.com
Signed-off-by: Isaku Yamahata yamah...@valinux.co.jp
---
hw/pci_bridge.c |6 ++
hw/pci_bridge.h |1 +
2 files changed, 7 insertions(+), 0
add uhci device which has ich9 device id.
Signed-off-by: Isaku Yamahata yamah...@valinux.co.jp
---
hw/pci_ids.h |2 ++
hw/usb-uhci.c |8
2 files changed, 10 insertions(+), 0 deletions(-)
diff --git a/hw/pci_ids.h b/hw/pci_ids.h
index ea3418c..9daea23 100644
--- a/hw/pci_ids.h
use DeviceInfo::reset callback instead of qemu_register_reset().
With this patch, its reset is done before parent pci device's reset.
Cc: Alexander Graf ag...@suse.de
Signed-off-by: Isaku Yamahata yamah...@valinux.co.jp
---
hw/ide/ich.c |9 ++---
1 files changed, 6 insertions(+), 3
Factor out pc nic initialization.
This simplifies the pc initialization and will reduce the code
duplication of q35 pc initialization.
Signed-off-by: Isaku Yamahata yamah...@valinux.co.jp
---
hw/pc.c | 15 +++
hw/pc.h |1 +
hw/pc_piix.c |9 +
3 files
Factor out the logic of allocating isa irqs.
This simplifies the pc initialization and will reduce the code
duplication of q35 pc initialization.
Signed-off-by: Isaku Yamahata yamah...@valinux.co.jp
---
hw/pc.c | 16 ++--
hw/pc.h |2 +-
hw/pc_piix.c |8 +---
3
Introduce a helper function which initialize ahci port with ide device
It will be used by q35 support later.
Cc: Alexander Graf ag...@suse.de
Signed-off-by: Isaku Yamahata yamah...@valinux.co.jp
---
hw/ide.h |3 +++
hw/ide/ahci.c | 15 +++
2 files changed, 18 insertions
ioapic isn't piix specific. And q35 pc will use it.
So move ioapic_init() from pc_piix.c to common place, pc.c.
Signed-off-by: Isaku Yamahata yamah...@valinux.co.jp
---
hw/pc.c | 16
hw/pc.h |2 ++
hw/pc_piix.c | 16
3 files changed, 18
factor out ide initialization to call drive_get(IF_IDE)
Signed-off-by: Isaku Yamahata yamah...@valinux.co.jp
---
hw/ide.h |3 +++
hw/ide/core.c | 14 ++
hw/mips_fulong2e.c |9 +
hw/mips_malta.c| 10 +-
hw/mips_r4k.c | 10
-by: Isaku Yamahata yamah...@valinux.co.jp
---
hw/apb_pci.c |4 ++--
hw/bonito.c|2 +-
hw/dec_pci.c |2 +-
hw/grackle_pci.c |2 +-
hw/gt64xxx.c |2 +-
hw/pci.c |2 +-
hw/pci.h |2 +-
hw/piix_pci.c |2 +-
hw/ppc4xx_pci.c
simply i440fx initialization by eliminating
i440fx_init_memory_mappings().
Signed-off-by: Isaku Yamahata yamah...@valinux.co.jp
---
hw/pc.h |2 +-
hw/pc_piix.c |8 +---
hw/piix_pci.c | 15 ++-
3 files changed, 8 insertions(+), 17 deletions(-)
diff --git a/hw
introduce pci_swizzle_map_irq_fn() for interrupt pin swizzle which is
standardized. PCI bridge swizzle is common logic, by introducing
this function duplicated swizzle logic will be avoided later.
Cc: Michael S. Tsirkin m...@redhat.com
Signed-off-by: Isaku Yamahata yamah...@valinux.co.jp
---
hw
factor out PM_TMR logic. Later This will be used by ich9 acpi.
Signed-off-by: Isaku Yamahata yamah...@valinux.co.jp
---
hw/acpi.c | 45 +
hw/acpi.h | 24
hw/acpi_piix4.c | 45
Introduce symbol PCI_SLOT_MAX for the maximum of slot.
and replace the magic, 256.
Cc: Michael S. Tsirkin m...@redhat.com
Signed-off-by: Isaku Yamahata yamah...@valinux.co.jp
---
hw/pci.h |1 +
hw/pci_internals.h |2 +-
2 files changed, 2 insertions(+), 1 deletions(-)
diff
factor out ACPI GPE logic. Later it will be used by ICH9 ACPI.
Signed-off-by: Isaku Yamahata yamah...@valinux.co.jp
---
hw/acpi.c | 66 ++
hw/acpi.h | 17 ++
hw/acpi_piix4.c | 95
unnecessary braces.
Changes from v1:
- make patches full bisectable
- typo s/allocte/allocate/
- some minor fixes
- dropped a merged patch
Isaku Yamahata (26):
pci: replace the magic, 256, for the maximum of slot
pci: add opaque argument to pci_map_irq_fn
pci: introduce pci_swizzle_map_irq_fn
apply pci_p2pbr for dec_pci.c.
Cc: Michael S. Tsirkin m...@redhat.com
Cc: Blue Swirl blauwir...@gmail.com
Signed-off-by: Isaku Yamahata yamah...@valinux.co.jp
---
hw/dec_pci.c | 49 ++---
1 files changed, 14 insertions(+), 35 deletions(-)
diff --git
Introduce accessor function to know INTx levels.
It will be used later by q35.
Although piix_pci tracks the intx line levels, it can be eliminated
by this helper function.
Cc: Michael S. Tsirkin m...@redhat.com
Signed-off-by: Isaku Yamahata yamah...@valinux.co.jp
---
hw/pci.c |7 +++
hw
factor out ACPI PM1_CNT logic. This will be used by ich9 acpi.
Signed-off-by: Isaku Yamahata yamah...@valinux.co.jp
---
hw/acpi.c | 49 +
hw/acpi.h | 14 ++
hw/acpi_piix4.c | 40
Adds pci id constants which will be used by q35.
Signed-off-by: Isaku Yamahata yamah...@valinux.co.jp
---
hw/pci_ids.h |2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/hw/pci_ids.h b/hw/pci_ids.h
index 9daea23..a597a7b 100644
--- a/hw/pci_ids.h
+++ b/hw/pci_ids.h
factor out ACPI PM1a EVT logic.
Later this will be used by ich9 acpi.
Signed-off-by: Isaku Yamahata yamah...@valinux.co.jp
---
hw/acpi.c | 37 +
hw/acpi.h | 13 +
hw/acpi_piix4.c | 52
Create generic pci p2p bridge device which can be customized
via properties like vendor id/device id and so on.
With this, we can avoid to create many pci p2p bridge which only
differs in those ids.
Cc: Michael S. Tsirkin m...@redhat.com
Signed-off-by: Isaku Yamahata yamah...@valinux.co.jp
PIIX3State::pci_irq_levels are redundant which is already tracked by
PCIBus layer. So eliminate them.
Signed-off-by: Isaku Yamahata yamah...@valinux.co.jp
---
hw/piix_pci.c | 31 +--
1 files changed, 21 insertions(+), 10 deletions(-)
diff --git a/hw/piix_pci.c b/hw
apply pci_p2pbr for apb_pci.c.
Cc: Michael S. Tsirkin m...@redhat.com
Cc: Blue Swirl blauwir...@gmail.com
Signed-off-by: Isaku Yamahata yamah...@valinux.co.jp
---
hw/apb_pci.c | 63 -
1 files changed, 27 insertions(+), 36 deletions
consolidate smbus initialization for pc_piix, mips_malta and mips_fulong.
Signed-off-by: Isaku Yamahata yamah...@valinux.co.jp
Cc: Aurelien Jarno aurel...@aurel32.net
Cc: Huacai Chen zltjiang...@gmail.com
Signed-off-by: Isaku Yamahata yamah...@valinux.co.jp
---
hw/mips_fulong2e.c |9
Factor out smram/pam logic for later use.
Which will be used by q35 too.
Signed-off-by: Isaku Yamahata yamah...@valinux.co.jp
---
Makefile.target |2 +-
hw/pam.c| 128 +++
hw/pam.h| 96
generalize initialization to make vendir/device id
customizable.
Signed-off-by: Isaku Yamahata yamah...@valinux.co.jp
---
hw/usb-uhci.c | 87 -
1 files changed, 43 insertions(+), 44 deletions(-)
diff --git a/hw/usb-uhci.c b/hw/usb-uhci.c
On Wed, Mar 16, 2011 at 01:12:27PM +0300, Michael Tokarev wrote:
16.03.2011 12:29, Isaku Yamahata wrote:
This patch series adds basic q35 chipset support for native pci express
support. Some bios related patches are still needed.
For those who want to try it, the following repo is avaiable
On Wed, Mar 16, 2011 at 11:34:42PM +0200, Michael S. Tsirkin wrote:
On Wed, Mar 16, 2011 at 06:29:18PM +0900, Isaku Yamahata wrote:
Create generic pci p2p bridge device which can be customized
via properties like vendor id/device id and so on.
With this, we can avoid to create many pci p2p
The behavior seems reasonable. So I cleaned it up for upstream merge.
thanks,
From cd336e50ebda63ecd84f8172dcf4d4456059d615 Mon Sep 17 00:00:00 2001
Message-Id:
cd336e50ebda63ecd84f8172dcf4d4456059d615.1300332741.git.yamah...@valinux.co.jp
From: Isaku Yamahata yamah...@valinux.co.jp
Date: Thu
Ouch. You already clean it up.
Here is my diff from your patch. Can you please merged into the patch?
changes are
- eliminate unaligned access
- error report
- replace magic number with symbolic constants
- unconverted strtol(base=10)
Signed-off-by: Isaku Yamahata yamah...@valinux.co.jp
On Thu, Mar 17, 2011 at 07:17:18AM +0200, Michael S. Tsirkin wrote:
Anyway this patch isn't very critical. I think the available choice is
- this patch
- modify the patch to use 14 arguments function.
Thus we can save much more lines.
- Add one more p2p bridge code which q35 uses,
. The only effect is that
neither VGA nor
serial console is not functioning. After short investigation I have
discovered
that this functionality was broken by this commit:
commit 9bb3358627d87d8de25fb41b7276575539d799a7
Author: Isaku Yamahata yamah...@valinux.co.jp
Date: Fri Nov 19 18:56
On Thu, Mar 03, 2011 at 12:03:53PM +0900, Isaku Yamahata wrote:
Hi. Thank you for reporting.
Can you elaborate on the changeset that you pointed out and
your work around?
Regarding to the changeset, it had the issue, but I suppose
80376c3fc2c38fdd45354e4b0eb45031f35587ed fixed it.
Do you
-wmask + PCI_STATUS) |
pci_get_word(dev-w1cmask + PCI_STATUS));
So probably the problem is in EFI BIOS. But I was not able to find
its source code. Anyone knows how is it built?
Best regards,
Artyom.
Isaku Yamahata wrote:
On Thu, Mar 03, 2011 at 12:03:53PM
+ PCI_STATUS) |
pci_get_word(dev-w1cmask + PCI_STATUS));
So probably the problem is in EFI BIOS. But I was not able to find
its source code. Anyone knows how is it built?
Best regards,
Artyom.
Isaku Yamahata wrote:
On Thu, Mar 03, 2011 at 12:03:53PM +0900, Isaku
Added CC to Tristan. I doubt that he is still interested in EFI, though.
On Thu, Mar 03, 2011 at 04:46:34PM +0900, Isaku Yamahata wrote:
Seabios has the patch to address the similar issue with
the changeset of b82a1e49fc0e72fb9bf1a642d6aa707345b0f398,
which enables memory/io unconditionally
Markus Armbruster
At 02/23/2011 04:30 PM, Markus Armbruster Write:
Isaku Yamahata yamah...@valinux.co.jp writes:
snip
I don't think this patch is correct. Let me explain.
Device hot unplug is *not* guaranteed to succeed.
For some buses, such as USB, it always succeeds
-related commands are somewhat broken,
and needs clean up with multifunction hotplug support which is
on my todo list.
thanks
On Mon, Feb 28, 2011 at 10:52:40AM +0800, Wen Congyang wrote:
Hi Markus Armbruster
At 02/23/2011 04:30 PM, Markus Armbruster Write:
Isaku Yamahata yamah...@valinux.co.jp
On Tue, Mar 01, 2011 at 02:58:44PM +0800, Wen Congyang wrote:
At 03/01/2011 12:11 PM, Isaku Yamahata Write:
Hi.
I don't suppose that just introducing pending bits solve the issue.
Your test only use single hot plug/unplug. How about mixing of multiple
hot plug/unplug with different
On Thu, Feb 24, 2011 at 06:57:05PM +0100, Juan Quintela wrote:
Signed-off-by: Juan Quintela quint...@redhat.com
---
hw/hw.h |8
1 files changed, 8 insertions(+), 0 deletions(-)
diff --git a/hw/hw.h b/hw/hw.h
index 0dfc053..f874dd0 100644
--- a/hw/hw.h
+++ b/hw/hw.h
@@
On Tue, Feb 22, 2011 at 06:36:20PM +0100, William Dauchy wrote:
`qdev_free` when unplug a pci device
It resolves a bug when detaching/attaching a network device
# virsh detach-interface dom0 network --mac 52:54:00:f6:84:ba
Interface detached successfully
# virsh attach-interface dom0
On Fri, Feb 04, 2011 at 01:24:14AM +0200, Eduard - Gabriel Munteanu wrote:
This initializes the AMD IOMMU and creates ACPI tables for it.
Signed-off-by: Eduard - Gabriel Munteanu eduard.munte...@linux360.ro
---
src/acpi.c | 84
On Thu, Jan 27, 2011 at 10:42:53AM +0200, Michael S. Tsirkin wrote:
On Thu, Jan 27, 2011 at 03:56:34PM +0900, Isaku Yamahata wrote:
Changes v1 - v2:
- dropped PCI_DEVFN_MAX
- use uint8_t for devfn instead of int
- move pcie_check_slot into pci.h and made it static inline
- minor clean
(slot, fn) pair is somewhat confusing because of ARI.
So use devfn for pci_find_device() instead of (slot, fn).
Signed-off-by: Isaku Yamahata yamah...@valinux.co.jp
---
hw/pci-hotplug.c |5 +++--
hw/pci.c |5 +++--
hw/pci.h |2 +-
hw/pci_host.c|2 +-
hw
This patch series implements ARI enable bit in root/downstream port
correctly.
Isaku Yamahata (3):
pci: replace the magic, 256, for the maximum of devfn
pci: use devfn for pci_find_device() instead of (slot, fn) pair
pci/pcie: make pci_find_device() ARI aware.
hw/pci-hotplug.c |5
make pci_find_device() ARI aware.
Signed-off-by: Isaku Yamahata yamah...@valinux.co.jp
---
hw/pci.c |6 ++
hw/pcie.c | 33 +
hw/pcie.h |2 +-
3 files changed, 36 insertions(+), 5 deletions(-)
diff --git a/hw/pci.c b/hw/pci.c
index ac16029..daba310
pci_init_wmask_bridge() incorrectly set w1cmask[PCI_BRIDGE_CONTROL].
This patch removes the line otherwise the assert(!(wmask w1cmask)) in
pci_default_write_config() is hit.
Signed-off-by: Isaku Yamahata yamah...@valinux.co.jp
---
hw/pci.c |4
1 files changed, 0 insertions(+), 4
Introduce symbol PCI_DEVFN_MAX for the maximum of devfn
and replace the magic, 256.
Signed-off-by: Isaku Yamahata yamah...@valinux.co.jp
---
hw/pci.h |2 ++
hw/pci_internals.h |2 +-
2 files changed, 3 insertions(+), 1 deletions(-)
diff --git a/hw/pci.h b/hw/pci.h
index
alex.william...@redhat.com
Signed-off-by: Isaku Yamahata yamah...@valinux.co.jp
---
savevm.c |2 --
1 files changed, 0 insertions(+), 2 deletions(-)
diff --git a/savevm.c b/savevm.c
index fcd8db4..cd29eb8 100644
--- a/savevm.c
+++ b/savevm.c
@@ -1126,7 +1126,6 @@ int register_savevm_live
the Primary Discard Timer or Secondary Discard
Timer expires and a Delayed Transaction
On Wed, Jan 26, 2011 at 02:09:59PM +0200, Michael S. Tsirkin wrote:
On Wed, Jan 26, 2011 at 06:45:27PM +0900, Isaku Yamahata wrote:
pci_init_wmask_bridge() incorrectly set w1cmask[PCI_BRIDGE_CONTROL
On Wed, Jan 26, 2011 at 03:46:01PM +0200, Michael S. Tsirkin wrote:
On Wed, Jan 26, 2011 at 10:17:48PM +0900, Isaku Yamahata wrote:
The bit should be writable, not w1c.
3.2.5.18 bridge control register
bit 11 Discard Timer SERR# Enable
When set to 1, this bit enables the bridge
I sent the patch out too early.
I found the issue is in pcibus_get_dev_path(). Sorry for noise.
On Wed, Jan 26, 2011 at 07:04:51AM -0700, Alex Williamson wrote:
On Wed, 2011-01-26 at 18:45 +0900, Isaku Yamahata wrote:
This patch unbreaks 7685ee6abcb939104801f84b3fe9645412528088
This patch fixes typo in pcibus_get_dev_path().
Without this patch, the result of pcibus_get_dev_path() isn't unique.
Signed-off-by: Isaku Yamahata yamah...@valinux.co.jp
---
hw/pci.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/hw/pci.c b/hw/pci.c
index d2a0cee
On Wed, Jan 26, 2011 at 03:57:15PM +0200, Michael S. Tsirkin wrote:
On Wed, Jan 26, 2011 at 10:53:42PM +0900, Isaku Yamahata wrote:
On Wed, Jan 26, 2011 at 03:46:01PM +0200, Michael S. Tsirkin wrote:
On Wed, Jan 26, 2011 at 10:17:48PM +0900, Isaku Yamahata wrote:
The bit should
Changes v1 - v2:
- dropped PCI_DEVFN_MAX
- use uint8_t for devfn instead of int
- move pcie_check_slot into pci.h and made it static inline
- minor clean ups
Isaku Yamahata (5):
pci: replace the magic, 256, for the maximum of devfn
pci: use devfn for pci_find_device() instead of (slot, fn
make pci_find_device() ARI aware.
Signed-off-by: Isaku Yamahata yamah...@valinux.co.jp
---
hw/pci.c |6 ++
hw/pci.h | 42 ++
hw/pcie.c | 13 -
hw/pcie.h |1 -
4 files changed, 48 insertions(+), 14 deletions(-)
diff --git a/hw
use PCI_SLOT in pci_get_bus_devfn().
Signed-off-by: Isaku Yamahata yamah...@valinux.co.jp
---
hw/pci.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/hw/pci.c b/hw/pci.c
index 471d4d7..e25bf7a 100644
--- a/hw/pci.c
+++ b/hw/pci.c
@@ -558,7 +558,7 @@ PCIBus
use uint8_t for devfn_min instead of int.
Signed-off-by: Isaku Yamahata yamah...@valinux.co.jp
---
hw/pci.c |6 +++---
hw/pci.h |6 +++---
hw/pci_internals.h |2 +-
3 files changed, 7 insertions(+), 7 deletions(-)
diff --git a/hw/pci.c b/hw/pci.c
index e25bf7a
Introduce symbol PCI_DEVFN_MAX for the maximum of devfn
and replace the magic, 256.
Signed-off-by: Isaku Yamahata yamah...@valinux.co.jp
---
hw/pci.h |1 +
hw/pci_internals.h |2 +-
2 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/hw/pci.h b/hw/pci.h
index 0d2753f
(slot, fn) pair is somewhat confusing because of ARI.
So use devfn for pci_find_device() instead of (slot, fn).
Signed-off-by: Isaku Yamahata yamah...@valinux.co.jp
---
hw/pci-hotplug.c |5 +++--
hw/pci.c |4 ++--
hw/pci.h |2 +-
hw/pci_host.c|2 +-
hw
On Tue, Jan 25, 2011 at 02:29:20PM +, anthony.per...@citrix.com wrote:
From: Anthony PERARD anthony.per...@citrix.com
Signed-off-by: Anthony PERARD anthony.per...@citrix.com
---
hw/acpi_piix4.c |4
hw/xen.h|2 ++
xen-all.c |7 +++
xen-stub.c |
PCIDevice::rom_file is leaked.
PCIDevice::rom_file is allocated in pci_qdev_init(), but not freed anywhere.
free it in qemu_unregister_device().
Signed-off-by: Isaku Yamahata yamah...@valinux.co.jp
---
hw/pci.c |1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/hw/pci.c b
fix memory leak in rom_add_file().
Signed-off-by: Isaku Yamahata yamah...@valinux.co.jp
---
hw/loader.c |2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/hw/loader.c b/hw/loader.c
index 35d792e..6cba8c5 100644
--- a/hw/loader.c
+++ b/hw/loader.c
@@ -618,6 +618,8 @@ int
On Sun, Jan 23, 2011 at 05:57:53PM +0200, Michael S. Tsirkin wrote:
On Sat, Jan 22, 2011 at 01:39:57AM +0900, Isaku Yamahata wrote:
On Fri, Jan 21, 2011 at 04:29:41PM +0200, Michael S. Tsirkin wrote:
On Fri, Jan 21, 2011 at 07:44:16PM +0900, Isaku Yamahata wrote:
On Thu, Jan 20, 2011
On Sun, Jan 23, 2011 at 04:50:34PM +0100, Andreas Färber wrote:
Am 21.01.2011 um 23:27 schrieb malc:
On Fri, 21 Jan 2011, Blue Swirl wrote:
On Fri, Jan 21, 2011 at 10:53 AM, Isaku Yamahata
yamah...@valinux.co.jp wrote:
consolidate audio_init() and remove references to shoundhw.
Cc: Blue
On Thu, Jan 20, 2011 at 04:15:48PM +0200, Michael S. Tsirkin wrote:
On Thu, Jan 20, 2011 at 03:57:39PM +0900, Isaku Yamahata wrote:
make pci_find_device() ARI aware.
Signed-off-by: Isaku Yamahata yamah...@valinux.co.jp
---
hw/pci.c |7 +++
1 files changed, 7 insertions(+), 0
consolidate audio_init() and remove references to shoundhw.
Cc: Blue Swirl blauwir...@gmail.com
Signed-off-by: Isaku Yamahata yamah...@valinux.co.jp
---
arch_init.c | 35 ++-
arch_init.h |1 +
hw/mips_jazz.c | 24 ++--
hw
remove bogus HAS_AUDIO according to 738012bec4c67e697e766edadab3f522c552a04d.
Cc: Blue Swirl blauwir...@gmail.com
Cc: Huacai Chen zltjiang...@gmail.com
Cc: Aurelien Jarno aurel...@aurel32.net
Signed-off-by: Isaku Yamahata yamah...@valinux.co.jp
---
hw/mips_fulong2e.c |4
1 files changed
use after free in do_wav_capture() on the error path.
Signed-off-by: Isaku Yamahata yamah...@valinux.co.jp
---
monitor.c |1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/monitor.c b/monitor.c
index d291158..cab5f20 100644
--- a/monitor.c
+++ b/monitor.c
@@ -2511,6 +2511,7
On Fri, Jan 21, 2011 at 04:29:41PM +0200, Michael S. Tsirkin wrote:
On Fri, Jan 21, 2011 at 07:44:16PM +0900, Isaku Yamahata wrote:
On Thu, Jan 20, 2011 at 04:15:48PM +0200, Michael S. Tsirkin wrote:
On Thu, Jan 20, 2011 at 03:57:39PM +0900, Isaku Yamahata wrote:
make pci_find_device
make pci_find_device() ARI aware.
Signed-off-by: Isaku Yamahata yamah...@valinux.co.jp
---
hw/pci.c |7 +++
1 files changed, 7 insertions(+), 0 deletions(-)
diff --git a/hw/pci.c b/hw/pci.c
index 8d0e3df..851f350 100644
--- a/hw/pci.c
+++ b/hw/pci.c
@@ -1596,11 +1596,18 @@ PCIBus
use qemu_malloc() instead of direct use of malloc().
Signed-off-by: Isaku Yamahata yamah...@valinux.co.jp
---
hw/pci.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/hw/pci.c b/hw/pci.c
index 851f350..86af0ee 100644
--- a/hw/pci.c
+++ b/hw/pci.c
@@ -2053,7 +2053,7
This patch makes pci bus creation aware of pci domain.
Signed-off-by: Isaku Yamahata yamah...@valinux.co.jp
---
hw/pci.c | 19 ++-
hw/pci.h |7 ---
hw/piix_pci.c |2 +-
3 files changed, 19 insertions(+), 9 deletions(-)
diff --git a/hw/pci.c b/hw/pci.c
deassert intx on device reset.
So far pci_device_reset() is used for system reset.
In that case, interrupt controller is reset at the same time so that
all irq is are deasserted.
But now pci bus reset/flr is supported, and in that case irq needs to be
disabled explicitly.
Signed-off-by: Isaku
use pci_device_deassert_intx().
Signed-off-by: Isaku Yamahata yamah...@valinux.co.jp
---
hw/msi.c |5 +
1 files changed, 1 insertions(+), 4 deletions(-)
diff --git a/hw/msi.c b/hw/msi.c
index f03f519..3dc3a24 100644
--- a/hw/msi.c
+++ b/hw/msi.c
@@ -255,7 +255,6 @@ void msi_write_config
So far pci_device_reset() is used for system reset.
In that case, interrupt controller is also reset so that
all irq is are deasserted.
But now pci bus reset/flr is supported, and in that case irq needs to be
disabled explicitly.
Isaku Yamahata (3):
pci: deassert intx on reset.
msi: simply
use pci_device_deassert_intx().
Signed-off-by: Isaku Yamahata yamah...@valinux.co.jp
---
hw/msix.c |5 +
1 files changed, 1 insertions(+), 4 deletions(-)
diff --git a/hw/msix.c b/hw/msix.c
index e123082..daaf9b7 100644
--- a/hw/msix.c
+++ b/hw/msix.c
@@ -159,7 +159,6 @@ void
How about creating stub functions instead of #ifdefs?
something like
pc-stubs.c
#ifndef CONFIG_VMWARE_VGA
pci_vmsvga_init()
{
error ...
}
#endif
#ifndef CONFIG_...
...
On Wed, Jan 12, 2011 at 11:34:29PM -0700, David Ahern wrote:
David Ahern (8):
fix 'no such file' error from
The code looks good.
Regarding to the format itself, I don't have strong opinion about it.
What cames into my mind while I'm looking at the code is,
Does BusInfo have to have two path functions? get_dev_path and get_fw_dev_path.
Right now only pci supplies get_dev_path, on the other hand
On Wed, Dec 22, 2010 at 02:03:55PM +0200, Michael S. Tsirkin wrote:
On Wed, Dec 22, 2010 at 08:36:40PM +0900, Isaku Yamahata wrote:
On Wed, Dec 22, 2010 at 01:04:43PM +0200, Michael S. Tsirkin wrote:
On Wed, Dec 22, 2010 at 07:54:49PM +0900, Isaku Yamahata wrote:
Introduce a function
Introduce a function to parse fw device path to pci device.
the format is
/p...@{ioport, mmio}/[fw_name]@slot,func/.../[fw_name]@slot,func
ioport = iioport addr in hex
mmio = mmio addr in hex
slot = slot number in hex
func = func number in hex
Signed-off-by: Isaku Yamahata yamah...@valinux.co.jp
This patch series introduces hmp command to inject aer error.
Now fw device path is used to specify pci function.
Changes v10 - v11:
- use qdev id and use fw dev path as fallback
Isaku Yamahata (5):
qdev: export qdev_find_recursive() for later use
pci: introduce a helper function to convert
This patch introduce a helper function to get PCIDevice from qdev id.
This function will be used later.
Signed-off-by: Isaku Yamahata yamah...@valinux.co.jp
---
hw/pci.c | 35 +++
hw/pci.h |1 +
2 files changed, 36 insertions(+), 0 deletions(-)
diff --git
introduce pcie_aer_inject_error command.
Signed-off-by: Isaku Yamahata yamah...@valinux.co.jp
---
Change v10 - v11:
- use qdev id
Changes v9 - v10:
- use fw device path
- error path
- pci-stub.c for CONFIG_PCI=n
Changes v8 - v9:
- revise error code
Changes v7 - v8:
- use
This patch exports qdev_find_recursive() for later use.
Signed-off-by: Isaku Yamahata yamah...@valinux.co.jp
---
hw/qdev.c |2 +-
hw/qdev.h |2 ++
2 files changed, 3 insertions(+), 1 deletions(-)
diff --git a/hw/qdev.c b/hw/qdev.c
index 4747c67..31eb464 100644
--- a/hw/qdev.c
+++ b/hw
pcie_aer_inject command: When qdev id failed, try fw device path as
fallback.
Signed-off-by: Isaku Yamahata yamah...@valinux.co.jp
---
hmp-commands.hx |7 ++-
hw/pcie_aer.c | 12
2 files changed, 14 insertions(+), 5 deletions(-)
diff --git a/hmp-commands.hx b/hmp
On Wed, Dec 22, 2010 at 08:27:17AM +0200, Michael S. Tsirkin wrote:
On Wed, Dec 22, 2010 at 12:13:43PM +0900, Isaku Yamahata wrote:
Right now pcibus_get_dev_path() isn't migration save because
bus number/secondary bus number are set by guest OS.
So it can't be used reliably for qemu
On Tue, Dec 21, 2010 at 02:24:29PM -0600, Adnan Khaleel wrote:
Hello,
Hi.
I have a question regarding how Qemu PCIe devices handle Config Transactions
vs
Memory Transactions (assuming the PCI device is setup to act
as PCI_BASE_ADDRESS_SPACE_MEMORY).
I'm using portions of
This patch series introduces hmp command to inject aer error.
Now fw device path is used to specify pci function.
Isaku Yamahata (3):
build, pci: remove QMP dependency on core PCI code
pci: introduce a parser for fw device path to pci device
pcie/aer: glue aer error injection into qemu
Introduce a function to parse fw device path to pci device.
the format is
/p...@{ioport, mmio}/[fw_name]@slot,func/.../[fw_name]@slot,func
ioport = iioport addr in hex
mmio = mmio addr in hex
slot = slot number in hex
func = func number in hex
Signed-off-by: Isaku Yamahata yamah...@valinux.co.jp
introduce pcie_aer_inject_error command.
Signed-off-by: Isaku Yamahata yamah...@valinux.co.jp
---
Changes v9 - v10:
- use fw device path
- error path
- pci-stub.c for CONFIG_PCI=n
Changes v8 - v9:
- revise error code
Changes v7 - v8:
- use domain:slot.func:slot.func...:slot.func instead
by introducing pci-stub.c, eliminate QMP dependency on core PCI code
rquired by query-pci command.
Signed-off-by: Isaku Yamahata yamah...@valinux.co.jp
---
Makefile.objs |4 +---
Makefile.target |2 ++
hw/pci-stub.c | 37 +
3 files changed, 40
On Wed, Dec 22, 2010 at 01:04:43PM +0200, Michael S. Tsirkin wrote:
On Wed, Dec 22, 2010 at 07:54:49PM +0900, Isaku Yamahata wrote:
Introduce a function to parse fw device path to pci device.
the format is
/p...@{ioport,
mmio}/[fw_name]@slot,func/.../[fw_name]@slot,func
ioport
On Thu, Dec 16, 2010 at 10:36:08AM +0200, Michael S. Tsirkin wrote:
On Thu, Dec 16, 2010 at 04:08:16PM +0900, Isaku Yamahata wrote:
On Wed, Dec 15, 2010 at 08:27:49AM -0700, Alex Williamson wrote:
On Wed, 2010-12-15 at 11:56 +0200, Michael S. Tsirkin wrote:
On Tue, Dec 14, 2010 at 11:34
On Wed, Dec 22, 2010 at 12:20:23AM +0100, Andreas Färber wrote:
From: Hervé Poussineau hpous...@reactos.org
v1:
* Rebased.
Signed-off-by: Hervé Poussineau hpous...@reactos.org
Cc: Michael S. Tsirkin m...@redhat.com
Signed-off-by: Andreas Färber andreas.faer...@web.de
---
Hello
.
It will be addressed for 0.15 release.
Cc: Michael S. Tsirkin m...@redhat.com
Cc: Alex Williamson alex.william...@redhat.com
Cc: Blue Swirl blauwir...@gmail.com
Signed-off-by: Isaku Yamahata yamah...@valinux.co.jp
---
hw/apb_pci.c|9 +
hw/dec_pci.c|6
The change set of b1aeb92666d2fde413c34578b3b42bbfe5f2a506 in pci branch
was mismerged. The compatibility should be kept for 0.13, not for 0.14.
Signed-off-by: Isaku Yamahata yamah...@valinux.co.jp
---
hw/pc_piix.c | 12
1 files changed, 4 insertions(+), 8 deletions(-)
diff --git
601 - 700 of 1486 matches
Mail list logo
