Re: [PATCH] vnc: fix crash when no console attached

2024-10-02 Thread Michael Tokarev
:1607 Fixes: e99441a3793b5 ("ui/curses: Do not use console_select()") Fixes: https://issues.redhat.com/browse/RHEL-50529 Cc: qemu-sta...@nongnu.org Signed-off-by: Marc-André Lureau Reviewed-by: Michael Tokarev I'm picking this one up to trivial-patches tree, as no one else got to i

Re: [PATCH] linux-user/elfload.c: keep GNU0_MAGIC in host byte order

2024-10-02 Thread Michael Tokarev
02.10.2024 16:51, Laurent Vivier wrote: Le 02/10/2024 à 11:11, Michael Tokarev a écrit : Other places of this file operate in host byte order.  Only this constant is defined as little-endian.  This does not work, for example, on s390x host when running an arm64 binary:   qemu-arm64: /usr/bin

Re: [PATCH] qemu-keymap: Release local allocation references

2024-10-02 Thread Michael Tokarev
23.07.2024 11:49, Akihiko Odaki wrote: Commit 2523baf7fb4d ("qemu-keymap: Make references to allocations static") made references to allocations static to ensure LeakSanitizer can track them. This trick unfortunately did not work with gcc version 14.0.1; that compiler is clever enough to know tha

[PATCH] linux-user/elfload.c: keep GNU0_MAGIC in host byte order

2024-10-02 Thread Michael Tokarev
/guest for which debian provides release architectures, namely: amd64 arm64 armel armhf i386 mips64el ppc64el riscv64 s390x Fixes: v5.1.0-2580-g83f990eb5adb "linux-user/elfload: Parse NT_GNU_PROPERTY_TYPE_0 notes" Resolves: https://gitlab.com/qemu-project/qemu/-/issues/2596 Signed-off-b

Re: [PULL 3/5] block/reqlist: allow adding overlapping requests

2024-10-01 Thread Michael Tokarev
30.09.2024 11:43, Vladimir Sementsov-Ogievskiy wrote: From: Fiona Ebner Allow overlapping request by removing the assert that made it impossible. There are only two callers: 1. block_copy_task_create() It already asserts the very same condition before calling reqlist_init_req(). 2. cbw_snaps

[PATCH v9 1/2] linux-user: add openat2 support in linux-user

2024-10-01 Thread Michael Vogt
it seems similar to the exiting behavior when openat() is called with a dirfd to "/proc". Here too the fake file lookup may not catch the special file because no dirfd is used to determine if the path is in /proc. Signed-off-by: Michael Vogt Buglink: https://github.com/osbuild/bootc-image

[PATCH v9 0/2] linux-user: add openat2 support in linux-user

2024-10-01 Thread Michael Vogt
This is v9 of the openat2 support in linux-user. Thanks to Laurent for spotting another missing tswap64() in v8 (and my appologies that I overlooked this). Looking forward to your feedback/ideas! Thanks, Michael v8 -> v9 - use "tswap64()" in strace.c for how.{flags,mode,resol

[PATCH v9 2/2] linux-user: add strace support for openat2

2024-10-01 Thread Michael Vogt
`syscall_defs.h` so that strace.c can use them. Signed-off-by: Michael Vogt --- linux-user/qemu.h | 9 linux-user/strace.c | 44 +++ linux-user/strace.list| 3 +++ linux-user/syscall.c | 8 +-- linux-user/syscall_defs.h

Re: [PATCH v7 0/5] AWS Nitro Enclave emulation support

2024-10-01 Thread Michael S. Tsirkin
On Sun, Sep 22, 2024 at 03:44:36PM +0600, Dorjoy Chowdhury wrote: > [7] https://lists.oasis-open.org/archives/virtio-comment/202310/msg00387.html That list is dead, would you mind reposting to the new list, so we can vote on it? Thanks! -- MST

[PATCH v8 2/2] linux-user: add strace support for openat2

2024-09-30 Thread Michael Vogt
`syscall_defs.h` so that strace.c can use them. Signed-off-by: Michael Vogt --- linux-user/qemu.h | 9 + linux-user/strace.c | 40 +++ linux-user/strace.list| 3 +++ linux-user/syscall.c | 8 +--- linux-user/syscall_defs.h

[PATCH v8 0/2] linux-user: add openat2 support in linux-user

2024-09-30 Thread Michael Vogt
This is v8 of the openat2 support in linux-user. Thanks for the feedback from Laurent on v7, really appreciated. This version addresses the feedback for v7. It's mostly details, see the changelog below. Looking forward to your feedback/ideas! Thanks, Michael v7 -> v8 - use

[PATCH v8 1/2] linux-user: add openat2 support in linux-user

2024-09-30 Thread Michael Vogt
it seems similar to the exiting behavior when openat() is called with a dirfd to "/proc". Here too the fake file lookup may not catch the special file because no dirfd is used to determine if the path is in /proc. Signed-off-by: Michael Vogt Buglink: https://github.com/osbuild/bootc-image

Re: [PATCH v2 14/18] util/timer: avoid deadlock when shutting down

2024-09-30 Thread Michael Tokarev
On 16.09.2024 11:53, Alex Bennée wrote: When we shut down a guest we disable the timers. However this can cause deadlock if the guest has queued some async work that is trying to advance system time and spins forever trying to wind time forward. Pay attention to the return code and bail early if

Re: [PATCH 0/6] refactor RDMA live migration based on rsocket API

2024-09-30 Thread Michael Galaxy
On 9/29/24 17:26, Michael S. Tsirkin wrote: !---| This Message Is From an External Sender This message came from outside your organization. |---! On Sun, Sep

Re: [PATCH 1/1] virtio-pci: fix memory_region_find for VirtIOPCIRegion's MR

2024-09-30 Thread Michael S. Tsirkin
On Tue, Sep 24, 2024 at 02:31:20PM +0200, David Hildenbrand wrote: > On 24.09.24 03:11, Gao Shiyuan wrote: > > Make sure to version your patch series. For example, via > $ git format-patch -v1 ... > > > As shown below, if a virtio PCI device is attached under a pci-bridge, the > > MR > > o

Re: [PATCH 0/6] refactor RDMA live migration based on rsocket API

2024-09-29 Thread Michael S. Tsirkin
On Sun, Sep 29, 2024 at 03:26:58PM -0500, Michael Galaxy wrote: > > On 9/29/24 13:14, Michael S. Tsirkin wrote: > > !---| > >This Message Is From an External Sender > >This message came from o

Re: [PATCH 0/6] refactor RDMA live migration based on rsocket API

2024-09-29 Thread Michael Galaxy
On 9/29/24 13:14, Michael S. Tsirkin wrote: !---| This Message Is From an External Sender This message came from outside your organization. |---! On Sat, Sep

Re: [PATCH 0/6] refactor RDMA live migration based on rsocket API

2024-09-29 Thread Michael S. Tsirkin
On Sat, Sep 28, 2024 at 12:52:08PM -0500, Michael Galaxy wrote: > A bounce buffer defeats the entire purpose of using RDMA in these cases. > When using RDMA for very large transfers like this, the goal here is to map > the entire memory region at once and avoid all CPU interactions (e

Re: [PATCH 0/6] refactor RDMA live migration based on rsocket API

2024-09-28 Thread Michael Galaxy
here is to map the entire memory region at once and avoid all CPU interactions (except for message management within libibverbs) so that the NIC is doing all of the work. I'm sure rsocket has its place with much smaller transfer sizes, but this is very different. - Michael

Re: [PATCH 0/6] refactor RDMA live migration based on rsocket API

2024-09-27 Thread Michael Galaxy
, -Original Message- From: Michael Galaxy [mailto:mgal...@akamai.com] Sent: Monday, September 23, 2024 3:29 AM To: Michael S. Tsirkin ; Peter Xu Cc: Gonglei (Arei) ; qemu-devel@nongnu.org; yu.zh...@ionos.com; elmar.ger...@ionos.com; zhengchuan ; berra...@redhat.com; arm...@redhat.com; lizhij

[PATCH 03/27] qemu-img: global option processing and error printing

2024-09-27 Thread Michael Tokarev
changes command by command, with main() done last. unrecognized_option() and missing_argument() functions prototypes aren't changed by this patch, since they're called from many places and will be removed a few patches later. Only artifical "qemu-img" argv0 is provided in there for

[PATCH 15/27] qemu-img: snapshot: make -l (list) the default, simplify option handling

2024-09-26 Thread Michael Tokarev
-off-by: Michael Tokarev Reviewed-by: Daniel P. Berrangé --- docs/tools/qemu-img.rst | 2 +- qemu-img.c | 52 ++--- 2 files changed, 19 insertions(+), 35 deletions(-) diff --git a/docs/tools/qemu-img.rst b/docs/tools/qemu-img.rst index 9b628c4da5

[PATCH 08/27] qemu-img: simplify --repair error message

2024-09-26 Thread Michael Tokarev
Signed-off-by: Michael Tokarev Reviewed-by: Daniel P. Berrangé --- qemu-img.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/qemu-img.c b/qemu-img.c index 1bd88fcf63..9157a6b45d 100644 --- a/qemu-img.c +++ b/qemu-img.c @@ -859,8 +859,9 @@ static int img_check(const

[PATCH 20/27] qemu-img: amend: refresh options/--help

2024-09-26 Thread Michael Tokarev
Add missing long options and --help output. Signed-off-by: Michael Tokarev --- qemu-img.c | 34 ++ 1 file changed, 26 insertions(+), 8 deletions(-) diff --git a/qemu-img.c b/qemu-img.c index 688c01722c..76000c485c 100644 --- a/qemu-img.c +++ b/qemu-img.c

[PATCH 09/27] qemu-img: commit: refresh options/--help

2024-09-26 Thread Michael Tokarev
Add missing long options and --help output. Signed-off-by: Michael Tokarev --- qemu-img.c | 44 1 file changed, 36 insertions(+), 8 deletions(-) diff --git a/qemu-img.c b/qemu-img.c index 9157a6b45d..7a111bce72 100644 --- a/qemu-img.c +++ b/qemu

[PATCH 14/27] qemu-img: snapshot: allow specifying -f fmt

2024-09-26 Thread Michael Tokarev
For consistency with other commands, and since it already accepts --image-opts, allow specifying -f fmt too. Signed-off-by: Michael Tokarev Reviewed-by: Daniel P. Berrangé --- docs/tools/qemu-img.rst | 2 +- qemu-img-cmds.hx| 4 ++-- qemu-img.c | 9 ++--- 3 files

[PATCH 10/27] qemu-img: compare: refresh options/--help

2024-09-26 Thread Michael Tokarev
Signed-off-by: Michael Tokarev --- qemu-img.c | 45 + 1 file changed, 37 insertions(+), 8 deletions(-) diff --git a/qemu-img.c b/qemu-img.c index 7a111bce72..ea66bfa195 100644 --- a/qemu-img.c +++ b/qemu-img.c @@ -1488,25 +1488,52 @@ static int

[PATCH 24/27] qemu-img: measure: refresh options/--help

2024-09-26 Thread Michael Tokarev
Add missing long options and --help output. Also add -s short option for --size (and remove OPTION_SIZE). Signed-off-by: Michael Tokarev --- qemu-img.c | 53 - 1 file changed, 40 insertions(+), 13 deletions(-) diff --git a/qemu-img.c b/qemu

[PATCH 04/27] qemu-img: pass current cmd info into command handlers

2024-09-26 Thread Michael Tokarev
This info will be used to generate --help output. Signed-off-by: Michael Tokarev Reviewed-by: Daniel P. Berrangé --- qemu-img.c | 34 +- 1 file changed, 17 insertions(+), 17 deletions(-) diff --git a/qemu-img.c b/qemu-img.c index 130188e287..e8234104e5 100644

[PATCH 26/27] qemu-img: inline list of supported commands, remove qemu-img-cmds.h include

2024-09-26 Thread Michael Tokarev
also add short description to each command and use it in --help Signed-off-by: Michael Tokarev Reviewed-by: Daniel P. Berrangé --- qemu-img.c | 40 ++-- 1 file changed, 34 insertions(+), 6 deletions(-) diff --git a/qemu-img.c b/qemu-img.c index 39dfaa5144

[PATCH 19/27] qemu-img: resize: refresh options/--help

2024-09-26 Thread Michael Tokarev
Add missing long options and --help output. Signed-off-by: Michael Tokarev --- qemu-img.c | 38 +- 1 file changed, 29 insertions(+), 9 deletions(-) diff --git a/qemu-img.c b/qemu-img.c index da10fafffc..688c01722c 100644 --- a/qemu-img.c +++ b/qemu-img.c

[PATCH 27/27] qemu-img: extend cvtnum() and use it in more places

2024-09-26 Thread Michael Tokarev
ve allowed size suffixes from the error message as it makes no sense most of the time (should be in help instead). Signed-off-by: Michael Tokarev Reviewed-by: Daniel P. Berrangé --- qemu-img.c | 111 + tests/qemu-iotests/049.out | 9 +-

[PATCH 02/27] qemu-img: create: convert img_size to signed, simplify handling

2024-09-26 Thread Michael Tokarev
Initializing an unsigned as -1, or using temporary sval for conversion is awkward. Since we don't allow other "negative" values anyway, use signed value and pass it to bdrv_img_create() (where it is properly converted to unsigned), simplifying code. Signed-off-by: Michael Tokar

[PATCH 07/27] qemu-img: check: refresh options/--help

2024-09-26 Thread Michael Tokarev
Add missing long options and --help output. Signed-off-by: Michael Tokarev --- qemu-img.c | 38 ++ 1 file changed, 30 insertions(+), 8 deletions(-) diff --git a/qemu-img.c b/qemu-img.c index 08536553c7..1bd88fcf63 100644 --- a/qemu-img.c +++ b/qemu-img.c

[PATCH 25/27] qemu-img: implement short --help, remove global help() function

2024-09-26 Thread Michael Tokarev
unrecognized_option() are now unused, remove them. Signed-off-by: Michael Tokarev Reviewed-by: Daniel P. Berrangé --- qemu-img.c | 172 - 1 file changed, 39 insertions(+), 133 deletions(-) diff --git a/qemu-img.c b/qemu-img.c index 3721cf070b..39dfaa5144

[PATCH 13/27] qemu-img: map: refresh options/--help

2024-09-26 Thread Michael Tokarev
Add missing long options and --help output. While at it, remove unused option_index variable. Signed-off-by: Michael Tokarev --- qemu-img.c | 34 -- 1 file changed, 24 insertions(+), 10 deletions(-) diff --git a/qemu-img.c b/qemu-img.c index 34c4cd86de

[PATCH 22/27] qemu-img: bitmap: refresh options/--help

2024-09-26 Thread Michael Tokarev
Add missing long options and --help output. Signed-off-by: Michael Tokarev --- qemu-img.c | 40 1 file changed, 32 insertions(+), 8 deletions(-) diff --git a/qemu-img.c b/qemu-img.c index fff537df26..7c20a5772d 100644 --- a/qemu-img.c +++ b/qemu-img.c

[PATCH 06/27] qemu-img: factor out parse_output_format() and use it in the code

2024-09-26 Thread Michael Tokarev
Use common code and simplify error message Signed-off-by: Michael Tokarev Reviewed-by: Daniel P. Berrangé --- qemu-img.c | 63 -- 1 file changed, 18 insertions(+), 45 deletions(-) diff --git a/qemu-img.c b/qemu-img.c index 7ed5e6d1a8

[PATCH 21/27] qemu-img: bench: refresh options/--help

2024-09-26 Thread Michael Tokarev
Add missing long options and --help output. Signed-off-by: Michael Tokarev --- qemu-img.c | 64 +- 1 file changed, 54 insertions(+), 10 deletions(-) diff --git a/qemu-img.c b/qemu-img.c index 76000c485c..fff537df26 100644 --- a/qemu-img.c

[PATCH 16/27] qemu-img: snapshot: refresh options/--help

2024-09-26 Thread Michael Tokarev
Add missing long options and --help output. Signed-off-by: Michael Tokarev --- qemu-img.c | 45 - 1 file changed, 36 insertions(+), 9 deletions(-) diff --git a/qemu-img.c b/qemu-img.c index 967f6343de..62f9ce4069 100644 --- a/qemu-img.c +++ b/qemu

[PATCH 17/27] qemu-img: rebase: refresh options/--help

2024-09-26 Thread Michael Tokarev
-off-by: Michael Tokarev --- qemu-img.c | 55 +- 1 file changed, 46 insertions(+), 9 deletions(-) diff --git a/qemu-img.c b/qemu-img.c index 62f9ce4069..47dfa137c1 100644 --- a/qemu-img.c +++ b/qemu-img.c @@ -3793,26 +3793,61 @@ static int

[PATCH 23/27] qemu-img: dd: refresh options/--help

2024-09-26 Thread Michael Tokarev
Add missing long options and --help output. Signed-off-by: Michael Tokarev --- qemu-img.c | 39 +-- 1 file changed, 29 insertions(+), 10 deletions(-) diff --git a/qemu-img.c b/qemu-img.c index 7c20a5772d..b3e521bc09 100644 --- a/qemu-img.c +++ b/qemu-img.c

[PATCH 11/27] qemu-img: convert: refresh options/--help

2024-09-26 Thread Michael Tokarev
Add missing long options and --help output. convert uses -B for --backing, - why not -b? Signed-off-by: Michael Tokarev --- qemu-img.c | 90 -- 1 file changed, 81 insertions(+), 9 deletions(-) diff --git a/qemu-img.c b/qemu-img.c index

[PATCH resend v3 00/27] qemu-img: refersh options and --help handling, cleanups

2024-09-26 Thread Michael Tokarev
7;t fix them all in one go. Changes since v2: - added Dan's R-Bs - refined couple cvtnum conversions - dropped "stop printing error twice in a few places" Michael Tokarev (27): qemu-img: measure: convert img_size to signed, simplify handling qemu-img: create: convert img

[PATCH 18/27] qemu-img: resize: do not always eat last argument

2024-09-26 Thread Michael Tokarev
is not handled right is when there's an option between filename and size, and size is given as decrement, - in this case -size will be treated as option, not as size. Signed-off-by: Michael Tokarev --- qemu-img.c | 41 +++-- 1 file changed, 27 insertions(

[PATCH 12/27] qemu-img: info: refresh options/--help

2024-09-26 Thread Michael Tokarev
Add missing long options and --help output. Also add -b short option for --backing-chain, and remove now-unused OPTION_BACKING_CHAIN. While at it, remove unused option_index variable. Signed-off-by: Michael Tokarev --- qemu-img.c | 40 +++- 1 file changed

[PATCH 01/27] qemu-img: measure: convert img_size to signed, simplify handling

2024-09-26 Thread Michael Tokarev
qemu_opt_set_number() expects signed int64_t. Use int64_t instead of uint64_t for img_size, use -1 as "unset" value instead of UINT64_MAX, and do not require temporary sval for conversion from string. Signed-off-by: Michael Tokarev Reviewed-by: Daniel P. Berrangé --- qemu-

[PATCH 05/27] qemu-img: create: refresh options/--help

2024-09-26 Thread Michael Tokarev
Create helper function cmd_help() to display command-specific help text, and use it to print --help for 'create' subcommand. Add missing long options (eg --format) in img_create(). Remove usage of missing_argument()/unrecognized_option() in img_create(). Signed-off-by: Micha

Re: [PATCH v2] tests/qemu-iotests/testenv: Use the "r2d" machine for sh4

2024-09-26 Thread Michael Tokarev
26.09.2024 13:55, Thomas Huth wrote: .. I'm planning to provide a patch to remove sh4eb-softmmu completely (since it is useless nowadays) ... I can add it there, too. That'll do it too, for sure. Thanks, /mjt

Re: [PATCH v2] tests/qemu-iotests/testenv: Use the "r2d" machine for sh4

2024-09-26 Thread Michael Tokarev
25.09.2024 10:24, Thomas Huth wrote: Commit 0ea0538fae516f9b4 removed the default machine of the sh4 binaries, so a lot of iotests are failing now without such a default machine. Teach the iotest harness to use the "r2d" machine instead to fix this problem. Signed-off-by: Thomas Huth --- v2:

Re: [PATCH] softmmu: Support concurrent bounce buffers

2024-09-26 Thread Michael S. Tsirkin
On Thu, Sep 26, 2024 at 10:58:57AM +0300, Michael Tokarev wrote: > 25.09.2024 13:23, Mattias Nissler wrote: > > On Wed, Sep 25, 2024 at 12:03 PM Michael Tokarev wrote: > .. > > > So, the issue has now become CVE-2024-8612 (information leak), with this > > > commit

Re: [PATCH] softmmu: Support concurrent bounce buffers

2024-09-26 Thread Michael Tokarev
25.09.2024 13:23, Mattias Nissler wrote: On Wed, Sep 25, 2024 at 12:03 PM Michael Tokarev wrote: .. So, the issue has now become CVE-2024-8612 (information leak), with this commit (v9.1.0-134-g637b0aa139) being the fix. Interesting. IIUC, this is triggered by device implementations calling

[PATCH v2] tests/qtest: Add XIVE tests for the powernv10 machine

2024-09-25 Thread Michael Kowal
inject operations Co-authored-by: Frederic Barrat Co-authored-by: Glenn Miles Co-authored-by: Michael Kowal Signed-off-by: Frederic Barrat Signed-off-by: Glenn Miles Signed-off-by: Michael Kowal --- MAINTAINERS| 1 + tests/qtest/pnv-xive2-common.h | 112

Re: [PATCH] softmmu: Support concurrent bounce buffers

2024-09-25 Thread Michael Tokarev
19.08.2024 16:54, Mattias Nissler wrote: When DMA memory can't be directly accessed, as is the case when running the device model in a separate process without shareable DMA file descriptors, bounce buffering is used. It is not uncommon for device models to request mapping of several DMA regions

Re: [PATCH 0/3] Fix WinXP ISO boot using the dc390/am53C974 SCSI device

2024-09-24 Thread Michael S. Tsirkin
On Sun, Sep 22, 2024 at 02:31:08PM +, Ricardo Ribalda wrote: > Mark Cave-Ayland reported that after landing the pre-computed _PRT, the > above mentioned testcase failed to pass. > > It seems that it is due to WinXP not handling properly a variable > package. Let's replace it. Thanks, will me

[PATCH v7 2/2] linux-user: add strace support for openat2

2024-09-23 Thread Michael Vogt
`syscall_defs.h` so that strace.c can use them. Signed-off-by: Michael Vogt --- linux-user/qemu.h | 9 + linux-user/strace.c | 40 +++ linux-user/strace.list| 3 +++ linux-user/syscall.c | 8 +--- linux-user/syscall_defs.h

[PATCH v7 1/2] linux-user: add openat2 support in linux-user

2024-09-23 Thread Michael Vogt
it seems similar to the exiting behavior when openat() is called with a dirfd to "/proc". Here too the fake file lookup may not catch the special file because no dirfd is used to determine if the path is in /proc. Signed-off-by: Michael Vogt Buglink: https://github.com/osbuild/bootc-image

[PATCH v7 0/2] linux-user: add openat2 support in linux-user

2024-09-23 Thread Michael Vogt
dback/ideas! Thanks, Michael v6 -> v7 - use abi_ulong in guest_size - use TARGET_ABI_FMT_lu to format guest size in qemu_log_mask() - drop #ifdef for TARGET_NR_openat2 - fix LTP test by checking for RESOLVE_NO_{MAGIC,SYM}LINKS in maybe_do_fake_open() - add support for openat2 in strace.c - ad

Re: [PATCH 0/6] refactor RDMA live migration based on rsocket API

2024-09-22 Thread Michael Galaxy
configuration that has full libibverbs supports and still allowed for compatibility testing with QEMU, would such an integration not be sufficient to handle the testing burden? Comments welcome, - Michael On 8/27/24 15:57, Michael S. Tsirkin wrote: !

[PATCH v6 1/1] linux-user: add openat2 support in linux-user

2024-09-20 Thread Michael Vogt
)" is used to determine if the path is in /proc. Alternatively to ignoring we could simply fail with `-TARGET_ENOSYS` (or similar) if `resolve` flags are passed and we found something that looks like a file in /proc that needs faking. Signed-off-by: Michael Vogt Buglink: https://github.co

[PATCH v6 0/1] linux-user: add openat2 support in linux-user

2024-09-20 Thread Michael Vogt
setup. Thanks again, Michael v5 -> v6 - do not use get_errno(fd) in do_guest_openat() - do not put declarations in the middle of the code - do not return early in do_openat2() when we get a faked file v4 -> v5 - drop "*use_returned_fd" from maybe_do_fake_open() and use return valu

Re: [PATCH] target/arm: Correct ID_AA64ISAR1_EL1 value for neoverse-v1

2024-09-20 Thread Michael Tokarev
On 20.09.2024 11:10, Marcin Juszkiewicz wrote: W dniu 17.09.2024 o 18:13, Peter Maydell pisze: The Neoverse-V1 TRM is a bit confused about the layout of the ID_AA64ISAR1_EL1 register, and so its table 3-6 has the wrong value for this ID register.  Trust instead section 3.2.74's list of which fie

[PULL 00/22] Trivial patches for 2024-09-20

2024-09-20 Thread Michael Tokarev
/jazz: fix typo in in-built NIC alias Michael Tokarev (3): mark with for-crc32 in a consistent manner linux-user/syscall.c: drop 64 suffix from flock64 &Co linux-user/syscall.c: eliminate other explicit LFS usages Philippe Mathieu-Daudé (8): tests/unit: Really build

[PULL 16/22] target/hexagon: Rename macros.inc -> macros.h.inc

2024-09-20 Thread Michael Tokarev
cros.h.inc". Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Brian Cain Reviewed-by: Anton Johansson Reviewed-by: Richard Henderson Signed-off-by: Michael Tokarev --- target/hexagon/gen_idef_parser_funcs.py | 2 +- target/hexagon/idef-parser/README.rst

[PULL 05/22] hw/mips/jazz: fix typo in in-built NIC alias

2024-09-20 Thread Michael Tokarev
/mips/jazz: use qemu_find_nic_info()") Signed-off-by: Mark Cave-Ayland Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: David Woodhouse Reviewed-by: Michael Tokarev Signed-off-by: Michael Tokarev --- hw/mips/jazz.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/mips/jazz.c b/

[PULL 04/22] ppc: fix incorrect spelling of PowerMac

2024-09-20 Thread Michael Tokarev
From: Tejas Vipin PowerMac is spelled as PowerMAC (Media Access Control) in some places. This is misleading. Resolves: https://gitlab.com/qemu-project/qemu/-/issues/2297 Signed-off-by: Tejas Vipin Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Michael Tokarev Signed-off-by: Michael Tokarev

[PULL 14/22] tests/qemu-iotests/testenv: Use the "r2d" machine for sh4/sh4eb

2024-09-20 Thread Michael Tokarev
From: Thomas Huth Commit 0ea0538fae516f9b4 removed the default machine of the sh4 binaries, so a lot of iotests are failing now without such a default machine. Teach the iotest harness to use the "r2d" machine instead to fix this problem. Signed-off-by: Thomas Huth Signed-off-b

[PULL 21/22] license: Update deprecated SPDX tag GPL-2.0+ to GPL-2.0-or-later

2024-09-20 Thread Michael Tokarev
anical patch running: $ sed -i -e s/GPL-2.0+/GPL-2.0-or-later/ \ $(git grep -lP 'SPDX-License-Identifier: \W+GPL-2.0\+[ $]' \ | egrep -v '^linux-headers|^include/standard-headers') Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Thomas Huth Reviewed-by: Richard H

[PULL 17/22] tests/bench: Rename test_akcipher_keys.inc -> test_akcipher_keys.c.inc

2024-09-20 Thread Michael Tokarev
Reviewed-by: Richard Henderson Signed-off-by: Michael Tokarev --- tests/bench/benchmark-crypto-akcipher.c | 2 +- .../bench/{test_akcipher_keys.inc => test_akcipher_keys.c.inc} | 0 2 files changed, 1 insertion(+), 1 deletion(-) rename tests/bench/{test_akcipher

[PULL 07/22] tests/unit: Really build pbkdf test on macOS

2024-09-20 Thread Michael Tokarev
hieu-Daudé Reviewed-by: Daniel P. Berrangé Reviewed-by: Michael Tokarev Signed-off-by: Michael Tokarev --- tests/unit/test-crypto-pbkdf.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/unit/test-crypto-pbkdf.c b/tests/unit/test-crypto-pbkdf.c index b477cf4e4b..12ee808

[PULL 22/22] license: Update deprecated SPDX tag GPL-2.0 to GPL-2.0-only

2024-09-20 Thread Michael Tokarev
ng: $ sed -i -e s/GPL-2.0/GPL-2.0-only/ \ $(git grep -l 'SPDX-License-Identifier: GPL-2.0[ $]' \ | egrep -v '^linux-headers|^include/standard-headers') Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Thomas Huth Reviewed-by: Richard Henderson Signed-off-by:

[PULL 13/22] tests/qemu-iotests/testenv: Use the "virt" machine for or1k

2024-09-20 Thread Michael Tokarev
ult machine since it provides PCI and thus e.g. support for virtio-blk and virtio-scsi, too. With this change, there are no failing iotests anymore when using the qemu-system-or1k binary for running the tests. Signed-off-by: Thomas Huth Reviewed-by: Richard Henderson Reviewed-by: Michael Tokarev Si

[PULL 19/22] license: Simplify GPL-2.0-or-later license descriptions

2024-09-20 Thread Michael Tokarev
athieu-Daudé Signed-off-by: Michael Tokarev --- block/vdi.c | 4 +++- hw/net/eepro100.c| 4 +++- hw/ppc/rs6000_mc.c | 4 +++- include/qemu/timed-average.h | 4 +++- qemu.nsi | 4 +++- util/timed-average.c | 4 +++- 6 files ch

[PULL 09/22] hw/display: Fix mirrored output in dm163

2024-09-20 Thread Michael Tokarev
From: Inès Varhol DM163 is an emulated 8x8 LED matrix. This commit flips the image horizontally so it's rendered the same way as on the hardware. Signed-off-by: Inès Varhol Signed-off-by: Michael Tokarev --- hw/display/dm163.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

[PULL 20/22] license: Update deprecated SPDX tag LGPL-2.0+ to LGPL-2.0-or-later

2024-09-20 Thread Michael Tokarev
anical patch running: $ sed -i -e s/LGPL-2.0+/LGPL-2.0-or-later/ \ $(git grep -l 'SPDX-License-Identifier: LGPL-2.0+$') Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Thomas Huth Reviewed-by: Richard Henderson Signed-off-by: Michael Tokarev --- gdbstub/gdbstub.c

[PULL 12/22] util/cutils: Remove unused qemu_get_exec_dir

2024-09-20 Thread Michael Tokarev
From: "Dr. David Alan Gilbert" qemu_get_exec_dir has been unused since commit: 5bebe03f51 ("util/cutils: Clean up global variable shadowing in get_relocated_path()") Remove it, and fix up a comment that pointed to it. Signed-off-by: Dr. David Alan Gilbert Reviewed

[PULL 06/22] hw/loongarch/virt: Add description for virt machine type

2024-09-20 Thread Michael Tokarev
n IPI with LoongArch IPI) Signed-off-by: Bibo Mao Reviewed-by: Thomas Huth Reviewed-by: Michael Tokarev Signed-off-by: Michael Tokarev --- hw/loongarch/virt.c | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/loongarch/virt.c b/hw/loongarch/virt.c index 81b1f9486f..75980b6e3c 10064

[PULL 15/22] tests/functional: Put the or1k_sim test into the slow category

2024-09-20 Thread Michael Tokarev
From: Thomas Huth Looks like a copy-n-paste mistake while adding the or1k_sim test here: The test downloads an asset from the internet, so it should be in the thorough category, not in the quick one. Signed-off-by: Thomas Huth Signed-off-by: Michael Tokarev --- tests/functional/meson.build

[PULL 18/22] tests/functional: Correct typo in test_netdev_ethtool.py SPDX tag

2024-09-20 Thread Michael Tokarev
From: Philippe Mathieu-Daudé Cc: Alex Bennée Fixes: 9f95111474 ("tests/avocado: re-factor igb test to avoid timeouts") Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Thomas Huth Reviewed-by: Richard Henderson Signed-off-by: Michael Tokarev --- tests/functional/test_netdev_

[PULL 03/22] linux-user/syscall.c: eliminate other explicit LFS usages

2024-09-20 Thread Michael Tokarev
ftruncate64() lseek64() pread64() pwrite64() This way it can be built on systems where the 64bit variants of everything is not defined (since the system always uses 64bit variants), such as on recent MUSL. Resolves: https://gitlab.com/qemu-project/qemu/-/issues/2215 Signed-off-by: Michael Tokarev

[PULL 08/22] hw/virtio/Kconfig: Include vhost-user-scmi only on arm targets

2024-09-20 Thread Michael Tokarev
From: Thomas Huth The System Control and Management Interface is specific to arm machines, so don't include this device in non-arm targets. Signed-off-by: Thomas Huth Reviewed-by: Milan Zamazal Reviewed-by: Michael Tokarev Signed-off-by: Michael Tokarev --- hw/virtio/Kconfig | 2 +- 1

[PULL 01/22] mark with for-crc32 in a consistent manner

2024-09-20 Thread Michael Tokarev
ke it consistent, and also add a few missing comments, including hw/nvram/mac_nvram.c which uses adler32 instead. There's no code changes. Signed-off-by: Michael Tokarev --- hw/net/cadence_gem.c | 2 +- hw/net/dp8393x.c | 2 +- hw/net/ftgmac100.c |

[PULL 11/22] hw/sysbus: Remove unused sysbus_mmio_unmap

2024-09-20 Thread Michael Tokarev
From: "Dr. David Alan Gilbert" The last use of sysbus_mmio_unmap was removed by 981b1c6266 ("spapr/xive: rework the mapping the KVM memory regions") Remove it. Signed-off-by: Dr. David Alan Gilbert Reviewed-by: Daniel P. Berrangé Reviewed-by: Michael Tokarev Signed-off

[PULL 10/22] envlist: Remove unused envlist_parse

2024-09-20 Thread Michael Tokarev
From: "Dr. David Alan Gilbert" envlist_parse, envlist_parse_set, envlist_parse_unset were added in 2009 but never used, see: 04a6dfebb6 ("linux-user: Add generic env variable handling") Remove them. Signed-off-by: Dr. David Alan Gilbert Reviewed-by: Michael Tokarev Si

qemu-devel@nongnu.org

2024-09-20 Thread Michael Tokarev
for these things anymore. Also fix a misleading comment near safe_fcntl telling us to always use flock64 (since v2.6.0-1311-g435da5e7092a "linux-user: Use safe_syscall wrapper for fcntl"). Reference: https://gitlab.com/qemu-project/qemu/-/issues/2215 Signed-off-by: Michael Tokarev Reviewed-b

Re: [PATCH v3 0/5] license: Fix typos and update SPDX tags

2024-09-20 Thread Michael Tokarev
On 11.09.2024 18:12, Philippe Mathieu-Daudé wrote: Series fully reviewed (thanks Thomas & Richard) Since v2: . Updated few missed "2 | 3+" expressions Since v1: . Updated regex to cover all GPL-2.0* cases. - Fix a pair of typos - Upgrade the deprecated GPL-2.0+/LGPL-2.0+ SPDX tags to GPL-2.

Re: [PATCH 0/2] misc: Rename included template headers using '.inc' suffix

2024-09-20 Thread Michael Tokarev
On 10.09.2024 14:28, Philippe Mathieu-Daudé wrote: Follow Coding Style: If you do use template header files they should be named with the ``.c.inc`` or ``.h.inc`` suffix to make it clear they are being included for expansion. Philippe Mathieu-Daudé (2): target/hexagon: Rename macros

Re: [PATCH] hw/char/stm32l4x5_usart.c: Enable USART ACK bit response

2024-09-19 Thread Michael Tokarev
On 20.09.2024 07:32, Michael Tokarev wrote: ... Though I'm a bit unsure about the target series. !2540 talks about 9.0.2, but 9.0 does not have 87b77e6e01ca which is being fixed by this change.  Is !2540 incorrect? Ah, n/m, !2540 does indeed mention in 9.0 the device were non-functional

Re: [PATCH] hw/char/stm32l4x5_usart.c: Enable USART ACK bit response

2024-09-19 Thread Michael Tokarev
On 11.09.2024 07:32, Jacob Abrams wrote: SW modifying USART_CR1 TE bit should cuase HW to respond by altering USART_ISR TEACK bit, and likewise for RE and REACK bit. This resolves some but not all issues necessary for the official STM USART HAL driver to function as is. Fixes: 87b77e6e01ca ("hw

[ANNOUNCE] QEMU 9.0.3 Stable released

2024-09-19 Thread Michael Tokarev
(stable-9.0-hash master-hash Author Name: Commmit-Subject): 6a54d5cf55 Michael Tokarev: Update version for 9.0.3 release 8686115955 8d5ab746b1 Daniel P. Berrangé: gitlab: fix logic for changing docker tag on stable branches 2409dfefd9 ae23cd0017 Gert Wollny: ui/sdl2: set swap interval explicitly

[ANNOUNCE] QEMU 8.2.7 Stable released

2024-09-19 Thread Michael Tokarev
x27;m extending 8.2.x series for longer time due to demand by ubuntu where 8.2 is used in an LTS release. No promises, but let's see how it goes. /mjt Changelog (stable-8.2-hash master-hash Author Name: Commmit-Subject): 317c999868 Michael Tokarev: Update version for 8.2.7 release

[ANNOUNCE] QEMU 7.2.14 Stable released

2024-09-19 Thread Michael Tokarev
Changelog (stable-7.2-hash master-hash Author Name: Commmit-Subject): 2c7f9dca14 Michael Tokarev: Update version for 7.2.14 release cdc048e810 110684c9a6 Jan Klötzke: hw/intc/arm_gic: fix spurious level triggered interrupts 10ac00f7b2 d0068b746a Alex Bennée: tests/docker: remove debian-armel-cross

[PATCH v5 1/1] linux-user: add openat2 support in linux-user

2024-09-19 Thread Michael Vogt
)" is used to determine if the path is in /proc. Alternatively to ignoring we could simply fail with `-TARGET_ENOSYS` (or similar) if `resolve` flags are passed and we found something that looks like a file in /proc that needs faking. Signed-off-by: Michael Vogt Buglink: https://github.co

[PATCH v5 0/1] linux-user: add openat2 support in linux-user

2024-09-19 Thread Michael Vogt
Hi, This is v5 of the openat2 support in linux-user. Thanks for the excellent feedback from Laurent Vivier on v4. This version is very close to v4 and only tweaks/simplifies based on the code review comments from Laurent, see the below changes for details. Thanks again, Michael v4 ->

[Stable-9.0.3 74/82] crypto: check gnutls & gcrypt support the requested pbkdf hash

2024-09-17 Thread Michael Tokarev
-Daudé Signed-off-by: Daniel P. Berrangé (cherry picked from commit e6c09ea4f9e5f8af92a6453642b84b9efd52892f) Signed-off-by: Michael Tokarev diff --git a/crypto/pbkdf-gcrypt.c b/crypto/pbkdf-gcrypt.c index a8d8e64f4d..bc0719c831 100644 --- a/crypto/pbkdf-gcrypt.c +++ b/crypto/pbkdf-gcrypt.c

[Stable-9.0.3 80/82] hw/intc/arm_gic: fix spurious level triggered interrupts

2024-09-17 Thread Michael Tokarev
4826.3558302-1-jan.kloet...@kernkonzept.com Reviewed-by: Peter Maydell [PMM: expanded comment a little and converted to coding-style form; expanded commit message with the historical backstory] Signed-off-by: Peter Maydell (cherry picked from commit 110684c9a69a02cbabfbddcd3afa921826ad565c) Signed-of

[Stable-9.0.3 71/82] target/ppc: Fix migration of CPUs with TLB_EMB TLB type

2024-09-17 Thread Michael Tokarev
fects the PPC 405, 440, 460 and e200 CPU families. Cc: qemu-sta...@nongnu.org Resolves: https://gitlab.com/qemu-project/qemu/-/issues/2522 Reviewed-by: Peter Maydell Signed-off-by: Arman Nabiev Signed-off-by: Fabiano Rosas (cherry picked from commit 203beb6f047467a4abfc8267c234393cea3f471c) Signe

[Stable-9.0.3 79/82] hw/audio/virtio-sound: fix heap buffer overflow

2024-09-17 Thread Michael Tokarev
. This also prevents a heap buffer overflow. See QEMU issue #2296. Resolves: https://gitlab.com/qemu-project/qemu/-/issues/2296 Signed-off-by: Volker Rümelin Message-Id: <20240901130112.8242-1-vr_q...@t-online.de> Reviewed-by: Michael S. Tsirkin Signed-off-by: Michael S. Tsirkin (cherry

[Stable-9.0.3 81/82] ui/sdl2: set swap interval explicitly when OpenGL is enabled

2024-09-17 Thread Michael Tokarev
commit ae23cd00170baaa2777eb1ee87b70f472dbb3c44) Signed-off-by: Michael Tokarev diff --git a/ui/sdl2.c b/ui/sdl2.c index 0a0eb5a42d..c695d4892f 100644 --- a/ui/sdl2.c +++ b/ui/sdl2.c @@ -115,6 +115,7 @@ void sdl2_window_create(struct sdl2_console *scon) SDL_SetHint(SDL_HINT_RENDER_BATCHI

[Stable-9.0.3 73/82] crypto: run qcrypto_pbkdf2_count_iters in a new thread

2024-09-17 Thread Michael Tokarev
-by: Michael Tokarev diff --git a/crypto/pbkdf.c b/crypto/pbkdf.c index 8d198c152c..d1c06ef3ed 100644 --- a/crypto/pbkdf.c +++ b/crypto/pbkdf.c @@ -19,6 +19,7 @@ */ #include "qemu/osdep.h" +#include "qemu/thread.h" #include "qapi/error.h" #include "crypto

  1   2   3   4   5   6   7   8   9   10   >