Re: [PATCH v3 5/5] target/s390x: AP-passthrough for PV guests

2023-08-23 Thread Michael Mueller
PV-AP can only be enabled if "regular" AP-pt is enabled as well. Note that KVM itself does not enforce this restriction. Signed-off-by: Steffen Eiden Signed-off-by: Michael Mueller with the findings from Thomas H. integrated --- target/s390x/cpu_features.h | 1 + ta

Re: [PATCH v2 2/3] target/s390x/kvm: Refactor AP functionalities

2023-08-17 Thread Michael Mueller
: Steffen Eiden Reviewed-by: Michael Mueller --- target/s390x/kvm/kvm.c | 24 +--- 1 file changed, 17 insertions(+), 7 deletions(-) diff --git a/target/s390x/kvm/kvm.c b/target/s390x/kvm/kvm.c index a9e5880349..a7e2cdf668 100644 --- a/target/s390x/kvm/kvm.c +++ b/target

Re: [PATCH 1/1] virtio-blk-ccw: tweak the default for num_queues

2020-11-11 Thread Michael Mueller
On 11.11.20 13:38, Cornelia Huck wrote: On Wed, 11 Nov 2020 13:26:11 +0100 Michael Mueller wrote: On 10.11.20 15:16, Michael Mueller wrote: On 09.11.20 19:53, Halil Pasic wrote: On Mon, 9 Nov 2020 17:06:16 +0100 Cornelia Huck wrote: @@ -20,6 +21,11 @@ static void

Re: [PATCH 1/1] virtio-blk-ccw: tweak the default for num_queues

2020-11-11 Thread Michael Mueller
On 10.11.20 15:16, Michael Mueller wrote: On 09.11.20 19:53, Halil Pasic wrote: On Mon, 9 Nov 2020 17:06:16 +0100 Cornelia Huck wrote: @@ -20,6 +21,11 @@ static void virtio_ccw_blk_realize(VirtioCcwDevice *ccw_dev, Error **errp)   {   VirtIOBlkCcw *dev = VIRTIO_BLK_CCW(ccw_dev

Re: [PATCH 1/1] virtio-blk-ccw: tweak the default for num_queues

2020-11-10 Thread Michael Mueller
On 09.11.20 19:53, Halil Pasic wrote: On Mon, 9 Nov 2020 17:06:16 +0100 Cornelia Huck wrote: @@ -20,6 +21,11 @@ static void virtio_ccw_blk_realize(VirtioCcwDevice *ccw_dev, Error **errp) { VirtIOBlkCcw *dev = VIRTIO_BLK_CCW(ccw_dev); DeviceState *vdev = DEVICE(&dev->vdev); +

[Qemu-devel] [PATCH] s390x/cpumodel: enum type S390FeatGroup now gets generated

2018-07-25 Thread Michael Mueller
The enumeration type S390FeatGroup is now generated as well. This shall simplify the definition of new feature groups without the requirement to modify existing code. Signed-off-by: Michael Mueller --- target/s390x/cpu_features.c | 1 - target/s390x/cpu_features.h | 19

Re: [Qemu-devel] [PATCH 1/1] s390x/cpumodel: fix feature groups and breakage of MSA8

2018-03-20 Thread Michael Mueller
FEAT_GROUP_MSA_EXT_8, +S390_FEAT_GROUP_MULTIPLE_EPOCH_PTFF, S390_FEAT_GROUP_MAX, } S390FeatGroup; From 978d0b480824248586149ed67dca7b31c6a5e5d8 Mon Sep 17 00:00:00 2001 From: Michael Mueller Date: Tue, 20 Mar 2018 15:56:18 +0100 Subject: [PATCH] target/s390x: enum type S390FeatGroup now gets generated

[Qemu-devel] [PATCH] virtio-input: const_le16 and const_le32 not build time constant

2015-06-01 Thread Michael Mueller
initialization for ‘virtio_keyboard_config[1].u.ids.bustype’) ... Signed-off-by: Michael Mueller --- include/hw/virtio/virtio-input.h | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/include/hw/virtio/virtio-input.h b/include/hw/virtio/virtio-input.h index a265519..bcee355

Re: [Qemu-devel] [PATCH v6 02/17] Add accelerator id and model name to CPUState

2015-05-07 Thread Michael Mueller
On Wed, 6 May 2015 08:41:50 -0300 Eduardo Habkost wrote: > On Wed, May 06, 2015 at 11:59:38AM +0200, Michael Mueller wrote: > > On Tue, 5 May 2015 10:26:02 -0300 > > Eduardo Habkost wrote: > > > > > On Mon, Apr 27, 2015 at 04:53:16PM +0200, Michael Mueller wrote:

Re: [Qemu-devel] [PATCH v6 05/17] Add optional parameters to QMP command query-cpu-definitions

2015-05-07 Thread Michael Mueller
On Wed, 6 May 2015 09:42:26 -0300 Eduardo Habkost wrote: > On Mon, Apr 27, 2015 at 04:53:19PM +0200, Michael Mueller wrote: > [...] > > diff --git a/qapi-schema.json b/qapi-schema.json > > index 215a7bc..285b2d3 100644 > > --- a/qapi-schema.json > > +++ b/qa

Re: [Qemu-devel] [PATCH v6 01/17] Introduce stub routine cpu_desc_avail

2015-05-07 Thread Michael Mueller
On Wed, 6 May 2015 14:06:16 -0300 Eduardo Habkost wrote: > On Wed, May 06, 2015 at 06:23:05PM +0200, Michael Mueller wrote: > > On Wed, 6 May 2015 08:23:32 -0300 > > Eduardo Habkost wrote: > [...] > > > > > >cpudef_init(); > > > > >

Re: [Qemu-devel] [PATCH v6 15/17] target-s390x: Extend arch specific QMP command query-cpu-definitions

2015-05-06 Thread Michael Mueller
On Wed, 6 May 2015 13:00:32 -0300 Eduardo Habkost wrote: > On Wed, May 06, 2015 at 05:31:06PM +0200, Michael Mueller wrote: > > On Tue, 5 May 2015 15:40:34 -0300 > > Eduardo Habkost wrote: > [...] > > > Second, you shouldn't even need to duplicate code in >

Re: [Qemu-devel] [PATCH v6 01/17] Introduce stub routine cpu_desc_avail

2015-05-06 Thread Michael Mueller
On Wed, 6 May 2015 08:23:32 -0300 Eduardo Habkost wrote: > On Wed, May 06, 2015 at 11:17:20AM +0200, Michael Mueller wrote: > > On Tue, 5 May 2015 14:41:01 -0300 > > Eduardo Habkost wrote: > > > > > On Tue, May 05, 2015 at 06:12:16PM +0200, Michael Mueller wrote:

Re: [Qemu-devel] [PATCH v6 15/17] target-s390x: Extend arch specific QMP command query-cpu-definitions

2015-05-06 Thread Michael Mueller
On Tue, 5 May 2015 15:40:34 -0300 Eduardo Habkost wrote: > On Mon, Apr 27, 2015 at 04:53:29PM +0200, Michael Mueller wrote: > [...] > > diff --git a/target-s390x/kvm.c b/target-s390x/kvm.c > > index 4d75ff0..94fede5 100644 > > --- a/target-s390x/kvm.c > > +++ b/tar

Re: [Qemu-devel] [PATCH v6 15/17] target-s390x: Extend arch specific QMP command query-cpu-definitions

2015-05-06 Thread Michael Mueller
On Wed, 6 May 2015 09:37:41 -0300 Eduardo Habkost wrote: > On Mon, Apr 27, 2015 at 04:53:29PM +0200, Michael Mueller wrote: > [...] > > #ifndef CONFIG_USER_ONLY > > +static CpuDefinitionInfoList *qmp_query_cpu_definition_host(void) > > +{ > > +CpuD

Re: [Qemu-devel] [PATCH v6 04/17] Extend HMP command info cpus to display accelerator id and model name

2015-05-06 Thread Michael Mueller
On Wed, 6 May 2015 10:33:55 -0300 Eduardo Habkost wrote: > On Wed, May 06, 2015 at 08:59:56AM -0400, Luiz Capitulino wrote: > > On Wed, 6 May 2015 07:38:53 -0300 > > Eduardo Habkost wrote: > > > > > On Wed, May 06, 2015 at 09:32:58AM +0200, Michael Mueller wrote:

Re: [Qemu-devel] [PATCH v6 02/17] Add accelerator id and model name to CPUState

2015-05-06 Thread Michael Mueller
On Tue, 5 May 2015 10:26:02 -0300 Eduardo Habkost wrote: > On Mon, Apr 27, 2015 at 04:53:16PM +0200, Michael Mueller wrote: > > The patch defines ids per accelerator and adds the accel_id and > > the model_name to the CPUState. The accel_id is initialized by > > common code,

Re: [Qemu-devel] [PATCH v6 03/17] Extend QMP command query-cpus to return accelerator id and model name

2015-05-06 Thread Michael Mueller
On Tue, 5 May 2015 10:11:15 -0300 Eduardo Habkost wrote: > On Mon, Apr 27, 2015 at 04:53:17PM +0200, Michael Mueller wrote: > > The QMP command query-cpus now additionally displays a model name and > > the backing accelerator. Both are omitted if the model name is not

Re: [Qemu-devel] [PATCH v6 02/17] Add accelerator id and model name to CPUState

2015-05-06 Thread Michael Mueller
On Tue, 5 May 2015 11:46:04 -0300 Eduardo Habkost wrote: > On Tue, May 05, 2015 at 08:36:45AM -0600, Eric Blake wrote: > > On 05/05/2015 07:26 AM, Eduardo Habkost wrote: > > >> +{ 'enum': 'AccelId', > > >> + 'data': ['qtest', 'tcg', 'kvm', 'xen'] } > > >> + > > > > > > Not sure if it is better

Re: [Qemu-devel] [PATCH v6 01/17] Introduce stub routine cpu_desc_avail

2015-05-06 Thread Michael Mueller
On Tue, 5 May 2015 14:41:01 -0300 Eduardo Habkost wrote: > On Tue, May 05, 2015 at 06:12:16PM +0200, Michael Mueller wrote: > > On Tue, 5 May 2015 10:55:47 -0300 > > Eduardo Habkost wrote: > > > > > On Mon, Apr 27, 2015 at 04:53:15PM +0200, Michael Mueller wrote:

Re: [Qemu-devel] [PATCH v6 12/17] target-s390x: Add S390 CPU class initialization routines

2015-05-06 Thread Michael Mueller
On Tue, 5 May 2015 11:34:06 -0300 Eduardo Habkost wrote: > On Mon, Apr 27, 2015 at 04:53:26PM +0200, Michael Mueller wrote: > > This patch provides routines to dynamically update the previously defined > > S390 CPU classes in the current host context. The main function perf

Re: [Qemu-devel] [PATCH v6 04/17] Extend HMP command info cpus to display accelerator id and model name

2015-05-06 Thread Michael Mueller
On Tue, 5 May 2015 10:14:32 -0300 Eduardo Habkost wrote: > On Mon, Apr 27, 2015 at 04:53:18PM +0200, Michael Mueller wrote: > > The HMP command info cpus now displays the CPU model name and the > > backing accelerator if part of the CPUState. > > > > (qemu) info

Re: [Qemu-devel] [PATCH v6 01/17] Introduce stub routine cpu_desc_avail

2015-05-05 Thread Michael Mueller
On Tue, 5 May 2015 10:55:47 -0300 Eduardo Habkost wrote: > On Mon, Apr 27, 2015 at 04:53:15PM +0200, Michael Mueller wrote: > > This patch introduces the function cpu_desc_avail() which returns by > > default true if not architecture specific implemented. Its intention > >

[Qemu-devel] [PATCH v6 12/17] target-s390x: Add S390 CPU class initialization routines

2015-04-27 Thread Michael Mueller
u_aliases(), adds cu model aliases - s390_cpu_classes_initialized(), test if CPU classes have been initialized - s390_fac_list_mask_by_machine(), returns facility list mask by machine - s390_current_fac_list_mask(), returns facility list mask of current machine Signed-off-by: Michael Mueller

[Qemu-devel] [PATCH v6 13/17] target-s390x: Prepare accelerator during S390 CPU object realization

2015-04-27 Thread Michael Mueller
This patch implements routine s390_cpu_model_init(). It is called by the realize function during instantiation of an CPU object. Its task is to initialize the current accelerator with the properties of the selected processor model. Signed-off-by: Michael Mueller Acked-by: Christian Borntraeger

[Qemu-devel] [PATCH v6 17/17] target-s390x: Enable S390 CPU model usage

2015-04-27 Thread Michael Mueller
This patch enables QEMU to instantiate S390 CPUs with CPU model types. Signed-off-by: Michael Mueller Acked-by: Christian Borntraeger --- hw/s390x/s390-virtio.c | 12 +++- target-s390x/helper.c | 9 ++--- 2 files changed, 13 insertions(+), 8 deletions(-) diff --git a/hw/s390x

[Qemu-devel] [PATCH v6 16/17] target-s390x: Introduce S390 CPU facility test routine

2015-04-27 Thread Michael Mueller
The patch introduces routine s390_facility_test() which allows to verify if a specific facility bit is set. Signed-off-by: Michael Mueller Acked-by: Christian Borntraeger --- target-s390x/cpu-models.c | 29 + target-s390x/cpu-models.h | 1 + 2 files changed, 30

[Qemu-devel] [PATCH v6 15/17] target-s390x: Extend arch specific QMP command query-cpu-definitions

2015-04-27 Thread Michael Mueller
VM, a KVMstate is established and machine properties are retrieved by cpu_model_get(). In case no KVMstate was established, e.g. during QEMU startup in daemonized mode with the default accelerator TCG, a fallback routine named get_machine_props_fallback() is used to retrieve the KVM machine prope

[Qemu-devel] [PATCH v6 11/17] target-s390x: Add KVM VM attribute interface for S390 CPU models

2015-04-27 Thread Michael Mueller
trace point instrumentation. Signed-off-by: Michael Mueller Acked-by: Christian Borntraeger --- target-s390x/cpu-models.h | 36 - target-s390x/kvm.c| 79 +++ trace-events | 3 ++ 3 files changed, 117 insertions

[Qemu-devel] [PATCH v6 07/17] target-s390x: Generate facility defines per S390 CPU model

2015-04-27 Thread Michael Mueller
T_CPU_S390_SIZE_UINT64 %PRIu32 FAC_LIST_CPU_S390_MASK_QEMU 0x%016PRIx64,0x%016PRIx64,... FAC_LIST_CPU_S390__GA 0x%016PRIx64,0x%016PRIx64,... Signed-off-by: Michael Mueller Acked-by: Christian Borntraeger --- Makefile.target | 2 +- rules.mak | 1 + target-s390x/Makefile.objs

[Qemu-devel] [PATCH v6 14/17] target-s390x: Initialize S390 CPU model name in CPUState

2015-04-27 Thread Michael Mueller
The cpu model name now gets initialized during CPU instance initialization. Signed-off-by: Michael Mueller Acked-by: Christian Borntraeger --- target-s390x/cpu.c | 1 + 1 file changed, 1 insertion(+) diff --git a/target-s390x/cpu.c b/target-s390x/cpu.c index 65dee3e..771acbd 100644 --- a

[Qemu-devel] [PATCH v6 10/17] target-s390x: Add S390 CPU model alias definition routines

2015-04-27 Thread Michael Mueller
This patch implements the infrastructure to dynamically add CPU model aliases. Signed-off-by: Michael Mueller Reviewed-by: Cornelia Huck Acked-by: Christian Borntraeger --- target-s390x/cpu-models.c | 82 +++ target-s390x/cpu-models.h | 13

[Qemu-devel] [PATCH v6 09/17] target-s390x: Define S390 CPU model specific facility lists

2015-04-27 Thread Michael Mueller
current hosting machine model. The also defined qemu side facility mask allows to implement and enable facilities in QEMU land. Signed-off-by: Michael Mueller Acked-by: Christian Borntraeger --- target-s390x/cpu-models.c | 11 +++ target-s390x/cpu-models.h | 8 target-s390x/cpu.c

[Qemu-devel] [PATCH v6 06/17] target-s390x: Introduce S390 CPU facilities

2015-04-27 Thread Michael Mueller
The patch introduces S390 CPU facility bit numbers and names as well as the architectural facility size limit in bytes. Signed-off-by: Michael Mueller Acked-by: Christian Borntraeger --- target-s390x/cpu-facilities.h | 86 +++ 1 file changed, 86

[Qemu-devel] [PATCH v6 08/17] target-s390x: Introduce S390 CPU models

2015-04-27 Thread Michael Mueller
. Furthermore it extends S390CPUClass by model related properties. Signed-off-by: Michael Mueller Acked-by: Christian Borntraeger --- target-s390x/Makefile.objs | 1 + target-s390x/cpu-models.c | 78 ++ target-s390x/cpu-models.h | 72

[Qemu-devel] [PATCH v6 03/17] Extend QMP command query-cpus to return accelerator id and model name

2015-04-27 Thread Michael Mueller
"model": "2827-ga2", "halted": false, "accel": "kvm", "thread_id": 31917 }, ... } Signed-off-by: Michael Mueller Acked-by: Christian Borntraeger --- cpus.c | 4 qapi-schema.json | 7 ++- 2

[Qemu-devel] [PATCH v6 04/17] Extend HMP command info cpus to display accelerator id and model name

2015-04-27 Thread Michael Mueller
The HMP command info cpus now displays the CPU model name and the backing accelerator if part of the CPUState. (qemu) info cpus * CPU #0: (halted) model=2827-ga2 accel=kvm thread_id=1679 Signed-off-by: Michael Mueller Acked-by: Christian Borntraeger --- hmp.c | 7 +++ 1 file changed, 7

[Qemu-devel] [PATCH v6 01/17] Introduce stub routine cpu_desc_avail

2015-04-27 Thread Michael Mueller
evaluating the runtime context instead of putting static cpu model information at display. Signed-off-by: Michael Mueller Reviewed-by: Thomas Huth Acked-by: Christian Borntraeger --- include/qemu-common.h | 2 ++ stubs/Makefile.objs| 1 + stubs/cpu-desc-avail.c | 6 ++ vl.c

[Qemu-devel] [PATCH v6 05/17] Add optional parameters to QMP command query-cpu-definitions

2015-04-27 Thread Michael Mueller
The patch adds optional parameters to the QMP command query-cpu-definitions. Thus the signature of routine arch_query_cpu_definitions needs to be changed for the stub function and all target implementations: target-arm target-i386 target-ppc target-s390 Signed-off-by: Michael Mueller Acked-by

[Qemu-devel] [PATCH v6 02/17] Add accelerator id and model name to CPUState

2015-04-27 Thread Michael Mueller
The patch defines ids per accelerator and adds the accel_id and the model_name to the CPUState. The accel_id is initialized by common code, the model name needs to be initialized by target specific code. Signed-off-by: Michael Mueller Acked-by: Christian Borntraeger --- include/qom/cpu.h | 5

[Qemu-devel] [PATCH v6 00/17] s390 cpu model implementation

2015-04-27 Thread Michael Mueller
fo type updated (13/16) - routine s390_facility_test() factored out (15/16) v1-v2: - QEMU-side facility list mask introduced: this allows to enable guest facilities that are handled by instruction interception handlers implemented on qemu side. Similar to the facilities enabled by means of the K

Re: [Qemu-devel] [PATCH v5 11/17] target-s390x: Add KVM VM attribute interface for S390 CPU models

2015-04-27 Thread Michael Mueller
On Mon, 27 Apr 2015 14:19:13 +0200 Cornelia Huck wrote: > > > >> Would it make sense to do the cast here > > > > > > > > cpu_model_get/set() is used to handle both attributes, > > > > KVM_S390_VM_CPU_MACHINE and KVM_S390_VM_CPU_PROCESSOR. > > > > Both require a different type in the signat

Re: [Qemu-devel] [PATCH v5 11/17] target-s390x: Add KVM VM attribute interface for S390 CPU models

2015-04-27 Thread Michael Mueller
On Mon, 27 Apr 2015 12:52:54 +0200 Christian Borntraeger wrote: > Am 27.04.2015 um 11:43 schrieb Michael Mueller: > > On Mon, 27 Apr 2015 10:15:47 +0200 > > Christian Borntraeger wrote: > > > >> Am 13.04.2015 um 15:56 schrieb Michael Mueller: > >> [...] &

Re: [Qemu-devel] [PATCH v5 06/17] target-s390x: Introduce S390 CPU facilities

2015-04-27 Thread Michael Mueller
On Mon, 27 Apr 2015 12:14:19 +0200 Christian Borntraeger wrote: > +/* z/VM-specific, see: SC24-6179-05 page 953) */ > +FAC_STHYI = 74, picked

Re: [Qemu-devel] [PATCH v5 15/17] target-s390x: Extend arch specific QMP command query-cpu-definitions

2015-04-27 Thread Michael Mueller
On Mon, 27 Apr 2015 10:11:29 +0200 Christian Borntraeger wrote: > > This patch implements the QMP command 'query-cpu-definitions' in the S390 > > context. The command returns a list of cpu definitions in the current host > > context. A runnable and migratable cpu model has the related attributes

Re: [Qemu-devel] [PATCH v5 11/17] target-s390x: Add KVM VM attribute interface for S390 CPU models

2015-04-27 Thread Michael Mueller
On Mon, 27 Apr 2015 10:15:47 +0200 Christian Borntraeger wrote: > Am 13.04.2015 um 15:56 schrieb Michael Mueller: > [...] > > +static int cpu_model_get(KVMState *s, uint64_t attr, uint64_t addr) > > +{ > > +int rc = -ENOSYS; > > +struct kvm_device_attr de

Re: [Qemu-devel] [PATCH v5 06/17] target-s390x: Introduce S390 CPU facilities

2015-04-27 Thread Michael Mueller
On Mon, 27 Apr 2015 10:11:37 +0200 Christian Borntraeger wrote: > Am 13.04.2015 um 15:56 schrieb Michael Mueller: > [...] > > +FAC_TRANSACTIONAL_EXE = 73, > > +/* > > + * The store-hypervisor-information facility #74 is > > + * z/V

Re: [Qemu-devel] [PATCH v5 09/17] target-s390x: Define S390 CPU model specific facility lists

2015-04-27 Thread Michael Mueller
On Mon, 27 Apr 2015 10:11:40 +0200 Christian Borntraeger wrote: > Am 13.04.2015 um 15:56 schrieb Michael Mueller: > > --- a/target-s390x/cpu-models.c > > +++ b/target-s390x/cpu-models.c > > > @@ -76,3 +87,4 @@ S390_PROC_DEF("2827-ga1", CPU_S390_2827_G

[Qemu-devel] [PATCH v5 10/17] target-s390x: Add S390 CPU model alias definition routines

2015-04-13 Thread Michael Mueller
This patch implements the infrastructure to dynamically add CPU model aliases. Signed-off-by: Michael Mueller Reviewed-by: Cornelia Huck --- target-s390x/cpu-models.c | 82 +++ target-s390x/cpu-models.h | 13 target-s390x/cpu.c| 1

[Qemu-devel] [PATCH v5 13/17] target-s390x: Prepare accelerator during S390 CPU object realization

2015-04-13 Thread Michael Mueller
This patch implements routine s390_cpu_model_init(). It is called by the realize function during instantiation of an CPU object. Its task is to initialize the current accelerator with the properties of the selected processor model. Signed-off-by: Michael Mueller --- target-s390x/cpu-models.c

[Qemu-devel] [PATCH v5 12/17] target-s390x: Add S390 CPU class initialization routines

2015-04-13 Thread Michael Mueller
u_aliases(), adds cu model aliases - s390_cpu_classes_initialized(), test if CPU classes have been initialized - s390_fac_list_mask_by_machine(), returns facility list mask by machine - s390_current_fac_list_mask(), returns facility list mask of current machine Signed-off-by: Michael Mueller -

[Qemu-devel] [PATCH v5 14/17] target-s390x: Initialize S390 CPU model name in CPUState

2015-04-13 Thread Michael Mueller
The cpu model name now gets initialized during CPU instance initialization. Signed-off-by: Michael Mueller --- target-s390x/cpu.c | 1 + 1 file changed, 1 insertion(+) diff --git a/target-s390x/cpu.c b/target-s390x/cpu.c index 65dee3e..771acbd 100644 --- a/target-s390x/cpu.c +++ b/target-s390x

[Qemu-devel] [PATCH v5 01/17] Introduce stub routine cpu_desc_avail

2015-04-13 Thread Michael Mueller
evaluating the runtime context instead of putting static cpu model information at display. Signed-off-by: Michael Mueller Reviewed-by: Thomas Huth --- include/qemu-common.h | 2 ++ stubs/Makefile.objs| 1 + stubs/cpu-desc-avail.c | 6 ++ vl.c | 2 +- 4 files changed

[Qemu-devel] [PATCH v5 07/17] target-s390x: Generate facility defines per S390 CPU model

2015-04-13 Thread Michael Mueller
T_CPU_S390_SIZE_UINT64 %PRIu32 FAC_LIST_CPU_S390_MASK_QEMU 0x%016PRIx64,0x%016PRIx64,... FAC_LIST_CPU_S390__GA 0x%016PRIx64,0x%016PRIx64,... Signed-off-by: Michael Mueller --- Makefile.target | 2 +- rules.mak | 1 + target-s390x/Makefile.objs| 20 ++ targe

[Qemu-devel] [PATCH v5 15/17] target-s390x: Extend arch specific QMP command query-cpu-definitions

2015-04-13 Thread Michael Mueller
rue }, ... { "name": "none", "runnable": true } ] } The request arguments are optional and if omitted lead to different answers. Eventually only the CPU model none gets returned as runnable and as default ... {

[Qemu-devel] [PATCH v5 09/17] target-s390x: Define S390 CPU model specific facility lists

2015-04-13 Thread Michael Mueller
current hosting machine model. The also defined qemu side facility mask allows to implement and enable facilities in QEMU land. Signed-off-by: Michael Mueller --- target-s390x/cpu-models.c | 12 target-s390x/cpu-models.h | 8 target-s390x/cpu.c| 1 + 3 files changed

[Qemu-devel] [PATCH v5 03/17] Extend QMP command query-cpus to return accelerator id and model name

2015-04-13 Thread Michael Mueller
"model": "2827-ga2", "halted": false, "accel": "kvm", "thread_id": 31917 }, ... } Signed-off-by: Michael Mueller --- cpus.c | 4 qapi-schema.json | 7 ++- 2 files changed, 10 insertions(+),

[Qemu-devel] [PATCH v5 17/17] target-s390x: Enable S390 CPU model usage

2015-04-13 Thread Michael Mueller
This patch enables QEMU to instantiate S390 CPUs with CPU model types. Signed-off-by: Michael Mueller --- hw/s390x/s390-virtio.c | 12 +++- target-s390x/helper.c | 9 ++--- 2 files changed, 13 insertions(+), 8 deletions(-) diff --git a/hw/s390x/s390-virtio.c b/hw/s390x/s390

[Qemu-devel] [PATCH v5 00/17] s390x cpu model implementation

2015-04-13 Thread Michael Mueller
"query-cpu-definitions" dropped in commit message (13/16) - comment for AccelCpuInfo type updated (13/16) - routine s390_facility_test() factored out (15/16) v1-v2: - QEMU-side facility list mask introduced: this allows to enable guest facilities that are handled by instruction

[Qemu-devel] [PATCH v5 11/17] target-s390x: Add KVM VM attribute interface for S390 CPU models

2015-04-13 Thread Michael Mueller
trace point instrumentation. Signed-off-by: Michael Mueller --- target-s390x/cpu-models.h | 36 - target-s390x/kvm.c| 79 +++ trace-events | 3 ++ 3 files changed, 117 insertions(+), 1 deletion(-) diff --git a

[Qemu-devel] [PATCH v5 02/17] Add accelerator id and model name to CPUState

2015-04-13 Thread Michael Mueller
The patch defines ids per accelerator and adds the accel_id and the model_name to the CPUState. The accel_id is initialized by common code, the model name needs to be initialized by target specific code. Signed-off-by: Michael Mueller --- include/qom/cpu.h | 5 + qapi-schema.json | 9

[Qemu-devel] [PATCH v5 08/17] target-s390x: Introduce S390 CPU models

2015-04-13 Thread Michael Mueller
. Furthermore it extends S390CPUClass by model related properties. Signed-off-by: Michael Mueller --- target-s390x/Makefile.objs | 1 + target-s390x/cpu-models.c | 78 ++ target-s390x/cpu-models.h | 72

[Qemu-devel] [PATCH v5 04/17] Extend HMP command info cpus to display accelerator id and model name

2015-04-13 Thread Michael Mueller
The HMP command info cpus now displays the CPU model name and the backing accelerator if part of the CPUState. (qemu) info cpus * CPU #0: (halted) model=2827-ga2 accel=kvm thread_id=1679 Signed-off-by: Michael Mueller --- hmp.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/hmp.c b

[Qemu-devel] [PATCH v5 06/17] target-s390x: Introduce S390 CPU facilities

2015-04-13 Thread Michael Mueller
The patch introduces S390 CPU facility bit numbers and names as well as the architectural facility size limit in bytes. Signed-off-by: Michael Mueller --- target-s390x/cpu-facilities.h | 86 +++ 1 file changed, 86 insertions(+) create mode 100644 target

[Qemu-devel] [PATCH v5 16/17] target-s390x: Introduce S390 CPU facility test routine

2015-04-13 Thread Michael Mueller
The patch introduces routine s390_facility_test() which allows to verify if a specific facility bit is set. Signed-off-by: Michael Mueller --- target-s390x/cpu-models.c | 29 + target-s390x/cpu-models.h | 1 + 2 files changed, 30 insertions(+) diff --git a/target

[Qemu-devel] [PATCH v5 05/17] Add optional parameters to QMP command query-cpu-definitions

2015-04-13 Thread Michael Mueller
The patch adds optional parameters to the QMP command query-cpu-definitions. Thus the signature of routine arch_query_cpu_definitions needs to be changed for the stub function and all target implementations: target-arm target-i386 target-ppc target-s390 Signed-off-by: Michael Mueller

Re: [Qemu-devel] [PATCH v4 11/15] target-s390x: New QMP command query-cpu-model

2015-04-02 Thread Michael Mueller
On Wed, 1 Apr 2015 20:05:24 -0300 Eduardo Habkost wrote: > > > > > > If you don't want to encode that knowledge in libvirt or other > > > management software for s390, it looks like you need something like a > > > "stable-abi-safe" field on CpuDefinitionInfo? > > > > Exactly that fulfills the

Re: [Qemu-devel] [PATCH v4 11/15] target-s390x: New QMP command query-cpu-model

2015-04-01 Thread Michael Mueller
On Wed, 1 Apr 2015 21:05:31 +0200 Michael Mueller wrote: > And cpu model "none" just means that QEMU does not manage the cpu model. > That's also > the reason why I initially returned an empty "[]" model and not "none". This > somewhat > co

Re: [Qemu-devel] [PATCH v4 11/15] target-s390x: New QMP command query-cpu-model

2015-04-01 Thread Michael Mueller
On Wed, 1 Apr 2015 13:59:05 -0300 Eduardo Habkost wrote: > > Not directly invalid as "-cpu none" will be the same as omitting the -cpu > > option. > > KVM will setup the vcpu properties withou any QEMU control to whatever the > > hosting > > machine and the kvm kernel code offers. That will all

Re: [Qemu-devel] [PATCH v4 11/15] target-s390x: New QMP command query-cpu-model

2015-04-01 Thread Michael Mueller
On Wed, 1 Apr 2015 10:01:13 -0300 Eduardo Habkost wrote: > On Tue, Mar 31, 2015 at 10:09:09PM +0200, Michael Mueller wrote: > > On Tue, 31 Mar 2015 15:35:26 -0300 > > Eduardo Habkost wrote: > > > > > On Mon, Mar 30, 2015 at 04:28:24PM +0200, Michael Mueller wrote:

Re: [Qemu-devel] [PATCH v4 12/15] Add optional parameters to QMP command query-cpu-definitions

2015-03-31 Thread Michael Mueller
On Tue, 31 Mar 2015 16:46:56 -0300 Eduardo Habkost wrote: > On Mon, Mar 30, 2015 at 04:28:25PM +0200, Michael Mueller wrote: > [...] > > ## > > # @query-cpu-definitions: > > # > > # Return a list of supported virtual CPU definitions > > # > > +# @

Re: [Qemu-devel] [PATCH v4 11/15] target-s390x: New QMP command query-cpu-model

2015-03-31 Thread Michael Mueller
On Tue, 31 Mar 2015 15:35:26 -0300 Eduardo Habkost wrote: > On Mon, Mar 30, 2015 at 04:28:24PM +0200, Michael Mueller wrote: > > This patch implements a new QMP request named 'query-cpu-model'. > > It returns the cpu model of cpu 0 and its backing accelerator. > >

Re: [Qemu-devel] [PATCH v4 11/15] target-s390x: New QMP command query-cpu-model

2015-03-31 Thread Michael Mueller
On Mon, 30 Mar 2015 17:17:21 -0300 Eduardo Habkost wrote: > On Mon, Mar 30, 2015 at 04:28:24PM +0200, Michael Mueller wrote: > > This patch implements a new QMP request named 'query-cpu-model'. > > It returns the cpu model of cpu 0 and its backing accelerator. > >

Re: [Qemu-devel] [PATCH v4 10/15] target-s390x: Prepare accelerator during cpu object realization

2015-03-31 Thread Michael Mueller
On Mon, 30 Mar 2015 16:33:51 -0300 Eduardo Habkost wrote: > On Mon, Mar 30, 2015 at 04:28:23PM +0200, Michael Mueller wrote: > > This patch implements routine s390_cpu_model_init(). It is called by the > > realize function during instantiation of an cpu object. Its task is to >

Re: [Qemu-devel] [PATCH v4 11/15] target-s390x: New QMP command query-cpu-model

2015-03-31 Thread Michael Mueller
On Mon, 30 Mar 2015 16:50:20 -0300 Eduardo Habkost wrote: Hello Eduardo, > On Mon, Mar 30, 2015 at 04:28:24PM +0200, Michael Mueller wrote: > [...] > > diff --git a/target-s390x/cpu.c b/target-s390x/cpu.c > > index 829945d..1698b52 100644 > > --- a/target-s390x/cpu.

Re: [Qemu-devel] [PATCH v4 11/15] target-s390x: New QMP command query-cpu-model

2015-03-31 Thread Michael Mueller
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On Mon, 30 Mar 2015 14:19:27 -0600 Eric Blake wrote: > On 03/30/2015 08:28 AM, Michael Mueller wrote: > > This patch implements a new QMP request named 'query-cpu-model'. > > It returns the cpu model of cpu 0 an

Re: [Qemu-devel] [PATCH v4 12/15] Add optional parameters to QMP command query-cpu-definitions

2015-03-31 Thread Michael Mueller
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On Mon, 30 Mar 2015 14:28:01 -0600 Eric Blake wrote: > On 03/30/2015 08:28 AM, Michael Mueller wrote: > > The patch adds optional parameters to the QMP command query-cpu-definitions. > > Thus the signature of routine arch_query_cpu_de

Re: [Qemu-devel] [PATCH v4 07/15] target-s390x: Update linux-headers/asm-s390/kvm.h

2015-03-31 Thread Michael Mueller
On Mon, 30 Mar 2015 21:36:22 +0200 Christian Borntraeger wrote: > Am 30.03.2015 um 16:28 schrieb Michael Mueller: > > Signed-off-by: Michael Mueller > > --- > > linux-headers/asm-s390/kvm.h | 18 +- > > 1 file changed, 9 insertions(+), 9 deletion

[Qemu-devel] [PATCH v4 01/15] Introduce stub routine cpu_desc_avail

2015-03-30 Thread Michael Mueller
evaluating the runtime context instead of putting static cpu model information at display. Signed-off-by: Michael Mueller Reviewed-by: Thomas Huth --- include/qemu-common.h | 2 ++ stubs/Makefile.objs| 1 + stubs/cpu-desc-avail.c | 6 ++ vl.c | 2 +- 4 files changed

[Qemu-devel] [PATCH v4 15/15] target-s390x: Enable cpu model usage

2015-03-30 Thread Michael Mueller
This patch enables QEMU to instantiate S390 CPUs with cpu model types. Signed-off-by: Michael Mueller --- hw/s390x/s390-virtio.c | 12 +++- target-s390x/helper.c | 9 ++--- 2 files changed, 13 insertions(+), 8 deletions(-) diff --git a/hw/s390x/s390-virtio.c b/hw/s390x/s390

[Qemu-devel] [PATCH v4 13/15] target-s390x: Extend QMP command query-cpu-definitions

2015-03-30 Thread Michael Mueller
ot;name":"2827-ga1","runnable":true,"is-default":false}, ... {"name":"2064-ga1","runnable":true,"is-default":false} ] } The request arguments are optional and if omitted only the cpu model na

[Qemu-devel] [PATCH v4 10/15] target-s390x: Prepare accelerator during cpu object realization

2015-03-30 Thread Michael Mueller
This patch implements routine s390_cpu_model_init(). It is called by the realize function during instantiation of an cpu object. Its task is to initialize the current accelerator with the properties of the selected processor model. Signed-off-by: Michael Mueller --- target-s390x/cpu-models.c

[Qemu-devel] [PATCH v4 06/15] target-s390x: Add cpu model alias definition routines

2015-03-30 Thread Michael Mueller
This patch implements the infrastructure to dynamically add cpu model aliases. Signed-off-by: Michael Mueller Reviewed-by: Cornelia Huck --- target-s390x/cpu-models.c | 89 +++ target-s390x/cpu-models.h | 11 ++ target-s390x/cpu.c| 1

[Qemu-devel] [PATCH v4 07/15] target-s390x: Update linux-headers/asm-s390/kvm.h

2015-03-30 Thread Michael Mueller
Signed-off-by: Michael Mueller --- linux-headers/asm-s390/kvm.h | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/linux-headers/asm-s390/kvm.h b/linux-headers/asm-s390/kvm.h index c5a93eb..bfe6925 100644 --- a/linux-headers/asm-s390/kvm.h +++ b/linux-headers

[Qemu-devel] [PATCH v4 11/15] target-s390x: New QMP command query-cpu-model

2015-03-30 Thread Michael Mueller
tion: - s390_cpu_models_used(), returns true if S390 cpu models are in use Signed-off-by: Michael Mueller --- include/sysemu/arch_init.h | 1 + qapi-schema.json | 35 +++ qmp-commands.hx| 6 ++ qmp.c | 5 + stub

[Qemu-devel] [PATCH v4 02/15] target-s390x: Introduce cpu facilities

2015-03-30 Thread Michael Mueller
The patch introduces S390 CPU facility bit numbers and names as well as the architectural facility size limit in bytes. Signed-off-by: Michael Mueller --- target-s390x/cpu-facilities.h | 86 +++ 1 file changed, 86 insertions(+) create mode 100644 target

[Qemu-devel] [PATCH v4 12/15] Add optional parameters to QMP command query-cpu-definitions

2015-03-30 Thread Michael Mueller
The patch adds optional parameters to the QMP command query-cpu-definitions. Thus the signature of routine arch_query_cpu_definitions needs to be changed for the stub function and all target implementations: target-arm target-i386 target-ppc target-s390 Signed-off-by: Michael Mueller

[Qemu-devel] [PATCH v4 03/15] target-s390x: Generate facility defines per cpu model

2015-03-30 Thread Michael Mueller
qemu/foobuild/s390x-softmmu' CCgen-facilities cc1: error: -I/usr/include/pixman-1: No such file or directory [-Werror] cc1: all warnings being treated as errors make[1]: *** [/gen-facilities] Error 1 make[1]: Leaving directory `/home/mimu/REPO/qemu/foobuild/s390x-softmmu' make: *

[Qemu-devel] [PATCH v4 05/15] target-s390x: Define cpu model specific facility lists

2015-03-30 Thread Michael Mueller
current hosting machine model. The also defined qemu side facility mask allows to implement and enable facilities in QEMU land. Signed-off-by: Michael Mueller --- target-s390x/cpu-models.c | 12 target-s390x/cpu-models.h | 8 target-s390x/cpu.c| 1 + 3 files changed

[Qemu-devel] [PATCH v4 08/15] target-s390x: Add KVM VM attribute interface for cpu models

2015-03-30 Thread Michael Mueller
trace point instrumentation. Signed-off-by: Michael Mueller --- target-s390x/cpu-models.h | 34 target-s390x/kvm.c| 79 +++ trace-events | 3 ++ 3 files changed, 116 insertions(+) diff --git a/target-s390x/cpu

[Qemu-devel] [PATCH v4 14/15] target-s390x: Introduce facility test routine

2015-03-30 Thread Michael Mueller
The patch introduces routine s390_facility_test() which allows to verify a specific facility bit is set. Signed-off-by: Michael Mueller --- target-s390x/cpu-models.c | 29 + target-s390x/cpu-models.h | 1 + 2 files changed, 30 insertions(+) diff --git a/target

[Qemu-devel] [PATCH v4 09/15] target-s390x: Add cpu class initialization routines

2015-03-30 Thread Michael Mueller
u_aliases(), adds cu model aliases - s390_cpu_classes_initialized(), test if cpu classes have been initialized - s390_fac_list_mask_by_machine(), returns facility list mask by machine - s390_current_fac_list_mask(), returns facility list mask of current machine Signed-off-by: Michael Mueller -

[Qemu-devel] [PATCH v4 00/15] s390x cpu model implementation

2015-03-30 Thread Michael Mueller
finitions" dropped in commit message (13/16) - comment for AccelCpuInfo type updated (13/16) - routine s390_facility_test() factored out (15/16) v1-v2: - QEMU-side facility list mask introduced: this allows to enable guest facilities that are handled by instruction interception handler

[Qemu-devel] [PATCH v4 04/15] target-s390x: Introduce cpu models

2015-03-30 Thread Michael Mueller
. Furthermore it extends the existing S390CPUClass by model related properties. Signed-off-by: Michael Mueller Reviewed-by: Thomas Huth --- target-s390x/Makefile.objs | 1 + target-s390x/cpu-models.c | 77 ++ target-s390x/cpu-models.h | 72

Re: [Qemu-devel] [PATCH v3 01/16] Introduce probe mode for machine type none

2015-03-05 Thread Michael Mueller
On Wed, 4 Mar 2015 16:19:25 -0300 Eduardo Habkost wrote: > On Tue, Mar 03, 2015 at 11:55:24AM +0100, Michael Mueller wrote: > > On Mon, 02 Mar 2015 17:57:01 +0100 > > Andreas Färber wrote: > > > > > Am 02.03.2015 um 17:43 schrieb Michael Mueller: > > &g

Re: [Qemu-devel] [PATCH v3 14/16] target-s390x: Extend QMP command query-cpu-definitions

2015-03-04 Thread Michael Mueller
On Mon, 2 Mar 2015 16:11:00 -0300 Eduardo Habkost wrote: > On Mon, Mar 02, 2015 at 01:44:06PM +0100, Michael Mueller wrote: > > This patch implements the QMP command 'query-cpu-definitions' in the S390 > > context. The command returns a list of cpu model names in the cu

Re: [Qemu-devel] [PATCH v3 01/16] Introduce probe mode for machine type none

2015-03-03 Thread Michael Mueller
On Mon, 2 Mar 2015 16:17:33 -0300 Eduardo Habkost wrote: > > +if (probe_mode) { > > +/* Use these accelerators in probe mode, tcg should be last */ > > +p = probe_mode_accels; > > I don't fully understand the purpose of this patch yet (I will discuss > it in a r

Re: [Qemu-devel] [PATCH v3 01/16] Introduce probe mode for machine type none

2015-03-03 Thread Michael Mueller
On Mon, 02 Mar 2015 17:57:01 +0100 Andreas Färber wrote: > Am 02.03.2015 um 17:43 schrieb Michael Mueller: > > On Mon, 02 Mar 2015 14:57:21 +0100 > > Andreas Färber wrote: > > > >>> int configure_accelerator(MachineState *ms) > >>> { > >>

Re: [Qemu-devel] [PATCH v3 01/16] Introduce probe mode for machine type none

2015-03-02 Thread Michael Mueller
On Mon, 02 Mar 2015 14:57:21 +0100 Andreas Färber wrote: > > int configure_accelerator(MachineState *ms) > > { > > -const char *p; > > +const char *p, *name; > > char buf[10]; > > int ret; > > bool accel_initialised = false; > > bool init_failed = false; > > Acc

[Qemu-devel] [PATCH v3 09/16] target-s390x: Update linux-headers/asm-s390/kvm.h

2015-03-02 Thread Michael Mueller
Signed-off-by: Michael Mueller --- linux-headers/asm-s390/kvm.h | 20 1 file changed, 20 insertions(+) diff --git a/linux-headers/asm-s390/kvm.h b/linux-headers/asm-s390/kvm.h index d36b2fa..e38c942 100644 --- a/linux-headers/asm-s390/kvm.h +++ b/linux-headers/asm-s390

  1   2   3   >