Re: [Qemu-devel] [PATCH] Fix two XBZRLE corruption issues

2014-02-14 Thread Orit Wasserman
) +int cache_insert(PageCache *cache, uint64_t addr, const uint8_t *pdata) { CacheItem *it = NULL; Reviewed-by: Orit Wasserman owass...@redhat.com

Re: [Qemu-devel] [pve-devel] QEMU LIve Migration - swap_free: Bad swap file entry

2014-02-11 Thread Orit Wasserman
On 02/08/2014 09:23 PM, Stefan Priebe wrote: i could fix it by explicitly disable xbzrle - it seems its automatically on if i do not set the migration caps to false. So it seems to be a xbzrle bug. XBZRLE is disabled by default (actually all capabilities are off by default) What version of

Re: [Qemu-devel] [pve-devel] QEMU LIve Migration - swap_free: Bad swap file entry

2014-02-11 Thread Orit Wasserman
On 02/11/2014 03:33 PM, Stefan Priebe - Profihost AG wrote: Am 11.02.2014 14:32, schrieb Orit Wasserman: On 02/08/2014 09:23 PM, Stefan Priebe wrote: i could fix it by explicitly disable xbzrle - it seems its automatically on if i do not set the migration caps to false. So it seems

Re: [Qemu-devel] migration question: disk images on nfs server

2014-02-07 Thread Orit Wasserman
On 02/07/2014 02:10 PM, Alexey Kardashevskiy wrote: On 07.02.2014 18:46, Orit Wasserman wrote: On 02/07/2014 06:35 AM, Alexey Kardashevskiy wrote: Hi! I have yet another problem with migration. Or NFS. There is one NFS server and 2 test POWER8 machines. There is a shared NFS folder

Re: [Qemu-devel] migration question: disk images on nfs server

2014-02-07 Thread Orit Wasserman
On 02/07/2014 02:54 PM, Marcin Gibuła wrote: It is more a NFS issue, if you have a file in NFS that two users in two different host are accessing (one at least write to it) you will need to enforce the sync option. Even if you flush all the data and close the file the NFS client can still have

Re: [Qemu-devel] migration question: disk images on nfs server

2014-02-07 Thread Orit Wasserman
On 02/07/2014 03:44 PM, Marcin Gibuła wrote: On 07.02.2014 14:36, Orit Wasserman wrote: Do you know if is applies to linux O_DIRECT writes as well? From the man of open: The behaviour of O_DIRECT with NFS will differ from local filesystems. Older kernels, or kernels

Re: [Qemu-devel] QEMU LIve Migration - swap_free: Bad swap file entry

2014-02-06 Thread Orit Wasserman
On 02/06/2014 09:20 AM, Stefan Priebe - Profihost AG wrote: Am 05.02.2014 21:15, schrieb Dr. David Alan Gilbert: * Stefan Priebe (s.pri...@profihost.ag) wrote: Hello, after live migrating machines with a lot of memory (32GB, 48GB, ...) i see pretty often crashing services after migration and

Re: [Qemu-devel] migration question: disk images on nfs server

2014-02-06 Thread Orit Wasserman
On 02/07/2014 06:35 AM, Alexey Kardashevskiy wrote: Hi! I have yet another problem with migration. Or NFS. There is one NFS server and 2 test POWER8 machines. There is a shared NFS folder on the server, mounted to both test hosts. There is an qcow2 image (abc.qcow2) in that shared folder. We

[Qemu-devel] [PATCH] Remove trailing space from error message

2014-02-05 Thread Orit Wasserman
Signed-off-by: Orit Wasserman owass...@redhat.com --- migration.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/migration.c b/migration.c index 25add6f..cc18f6c 100644 --- a/migration.c +++ b/migration.c @@ -482,7 +482,7 @@ void qmp_migrate_set_cache_size(int64_t value

Re: [Qemu-devel] [PATCH 5/8] XBZRLE cache size should not be larger than guest memory size

2014-02-04 Thread Orit Wasserman
On 02/04/2014 06:26 PM, Eric Blake wrote: On 02/04/2014 08:19 AM, Juan Quintela wrote: From: Orit Wasserman owass...@redhat.com Signed-off-by: Orit Wasserman owass...@redhat.com Signed-off-by: Juan Quintela quint...@redhat.com --- migration.c | 7 +++ 1 file changed, 7 insertions

Re: [Qemu-devel] [PATCH 5/6] Don't abort on out of memory when creating page cache

2014-01-30 Thread Orit Wasserman
On 01/30/2014 05:48 PM, Dr. David Alan Gilbert wrote: * Orit Wasserman (owass...@redhat.com) wrote: Signed-off-by: Orit Wasserman owass...@redhat.com --- arch_init.c | 16 ++-- page_cache.c | 18 ++ 2 files changed, 28 insertions(+), 6 deletions(-) diff --git

Re: [Qemu-devel] [PATCH 6/6] Don't abort on memory allocation error

2014-01-30 Thread Orit Wasserman
On 01/30/2014 06:08 PM, Dr. David Alan Gilbert wrote: * Orit Wasserman (owass...@redhat.com) wrote: It is better to fail migration in case of failure to allocate new cache item Does this actually fail migration or just drop back to sending an uncompressed page? (I think the latter, and that's

[Qemu-devel] [PATCH v2 0/6] XBZRLE Fixes

2014-01-30 Thread Orit Wasserman
. Gonglei (Arei) (1): migration:fix free XBZRLE decoded_buf wrong Orit Wasserman (5): Set xbzrle buffers to NULL after freeing them to avoid double free errors Add check for cache size smaller than page size XBZRLE cache size should not be larger than guest memory size Don't abort on out

[Qemu-devel] [PATCH v2 1/6] Set xbzrle buffers to NULL after freeing them to avoid double free errors

2014-01-30 Thread Orit Wasserman
Signed-off-by: Orit Wasserman owass...@redhat.com Reviewed-by: Juan Quintela quint...@redhat.com --- arch_init.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/arch_init.c b/arch_init.c index 77912e7..66f5e82 100644 --- a/arch_init.c +++ b/arch_init.c @@ -617,6 +617,9 @@ static void

[Qemu-devel] [PATCH v2 4/6] XBZRLE cache size should not be larger than guest memory size

2014-01-30 Thread Orit Wasserman
Signed-off-by: Orit Wasserman owass...@redhat.com --- migration.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/migration.c b/migration.c index 46a7305..25add6f 100644 --- a/migration.c +++ b/migration.c @@ -479,6 +479,13 @@ void qmp_migrate_set_cache_size(int64_t value, Error

[Qemu-devel] [PATCH v2 3/6] migration:fix free XBZRLE decoded_buf wrong

2014-01-30 Thread Orit Wasserman
. Signed-off-by: ChenLiang chenlian...@huawei.com Reviewed-by: Peter Maydell peter.mayd...@linaro.org Reviewed-by: Orit Wasserman owass...@redhat.com Signed-off-by: GongLei arei.gong...@huawei.com --- arch_init.c | 22 -- include/migration/migration.h | 1

[Qemu-devel] [PATCH v2 5/6] Don't abort on out of memory when creating page cache

2014-01-30 Thread Orit Wasserman
Signed-off-by: Orit Wasserman owass...@redhat.com --- arch_init.c | 18 -- page_cache.c | 18 ++ 2 files changed, 30 insertions(+), 6 deletions(-) diff --git a/arch_init.c b/arch_init.c index 5eff80b..1fa5f1f 100644 --- a/arch_init.c +++ b/arch_init.c @@ -664,8

[Qemu-devel] [PATCH v2 2/6] Add check for cache size smaller than page size

2014-01-30 Thread Orit Wasserman
Signed-off-by: Orit Wasserman owass...@redhat.com Reviewed-by: Juan Quintela quint...@redhat.com --- arch_init.c | 4 migration.c | 10 +- 2 files changed, 13 insertions(+), 1 deletion(-) diff --git a/arch_init.c b/arch_init.c index 66f5e82..8edeabe 100644 --- a/arch_init.c +++ b

[Qemu-devel] [PATCH v2 6/6] Don't abort on memory allocation error

2014-01-30 Thread Orit Wasserman
It is better to fail migration in case of failure to allocate new cache item Signed-off-by: Orit Wasserman owass...@redhat.com --- arch_init.c| 4 +++- include/migration/page_cache.h | 4 +++- page_cache.c | 16 +++- 3 files changed, 17

Re: [Qemu-devel] [PATCH v2 4/6] XBZRLE cache size should not be larger than guest memory size

2014-01-30 Thread Orit Wasserman
On 01/30/2014 08:23 PM, Dr. David Alan Gilbert wrote: * Orit Wasserman (owass...@redhat.com) wrote: Signed-off-by: Orit Wasserman owass...@redhat.com --- migration.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/migration.c b/migration.c index 46a7305..25add6f 100644

Re: [Qemu-devel] [PATCH v2 4/6] XBZRLE cache size should not be larger than guest memory size

2014-01-30 Thread Orit Wasserman
On 01/30/2014 08:48 PM, Dr. David Alan Gilbert wrote: * Orit Wasserman (owass...@redhat.com) wrote: On 01/30/2014 08:23 PM, Dr. David Alan Gilbert wrote: * Orit Wasserman (owass...@redhat.com) wrote: Signed-off-by: Orit Wasserman owass...@redhat.com --- migration.c | 7 +++ 1 file

[Qemu-devel] [PATCH 3/6] migration:fix free XBZRLE decoded_buf wrong

2014-01-29 Thread Orit Wasserman
. Signed-off-by: ChenLiang chenlian...@huawei.com Reviewed-by: Peter Maydell peter.mayd...@linaro.org Reviewed-by: Orit Wasserman owass...@redhat.com Signed-off-by: GongLei arei.gong...@huawei.com --- arch_init.c | 22 -- include/migration/migration.h | 1

[Qemu-devel] [PATCH 0/6] XBZRLE Fixes

2014-01-29 Thread Orit Wasserman
Fix memory leak and missing NULLs. Better cache size validation checks. Fail migration instead of aborting QEMU in case there is not enough memory for the page cache. Gonglei (Arei) (1): migration:fix free XBZRLE decoded_buf wrong Orit Wasserman (5): Set xbzrle buffers to NULL after freeing

[Qemu-devel] [PATCH 1/6] Set xbzrle buffers to NULL after freeing them to avoid double free errors

2014-01-29 Thread Orit Wasserman
Signed-off-by: Orit Wasserman owass...@redhat.com Reviewed-by: Juan Quintela quint...@redhat.com --- arch_init.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/arch_init.c b/arch_init.c index 77912e7..66f5e82 100644 --- a/arch_init.c +++ b/arch_init.c @@ -617,6 +617,9 @@ static void

[Qemu-devel] [PATCH 5/6] Don't abort on out of memory when creating page cache

2014-01-29 Thread Orit Wasserman
Signed-off-by: Orit Wasserman owass...@redhat.com --- arch_init.c | 16 ++-- page_cache.c | 18 ++ 2 files changed, 28 insertions(+), 6 deletions(-) diff --git a/arch_init.c b/arch_init.c index 5eff80b..806d096 100644 --- a/arch_init.c +++ b/arch_init.c @@ -664,8

[Qemu-devel] [PATCH 2/6] Add check for cache size smaller than page size

2014-01-29 Thread Orit Wasserman
Signed-off-by: Orit Wasserman owass...@redhat.com Reviewed-by: Juan Quintela quint...@redhat.com --- arch_init.c | 4 migration.c | 10 +- 2 files changed, 13 insertions(+), 1 deletion(-) diff --git a/arch_init.c b/arch_init.c index 66f5e82..8edeabe 100644 --- a/arch_init.c +++ b

[Qemu-devel] [PATCH 4/6] XBZRLE cache size should not be larger than guest memory size

2014-01-29 Thread Orit Wasserman
Signed-off-by: Orit Wasserman owass...@redhat.com --- migration.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/migration.c b/migration.c index 46a7305..25add6f 100644 --- a/migration.c +++ b/migration.c @@ -479,6 +479,13 @@ void qmp_migrate_set_cache_size(int64_t value, Error

[Qemu-devel] [PATCH 6/6] Don't abort on memory allocation error

2014-01-29 Thread Orit Wasserman
It is better to fail migration in case of failure to allocate new cache item Signed-off-by: Orit Wasserman owass...@redhat.com --- arch_init.c| 4 +++- include/migration/page_cache.h | 4 +++- page_cache.c | 16 +++- 3 files changed, 17

Re: [Qemu-devel] [PATCH v2] migration:fix free XBZRLE decoded_buf wrong

2014-01-21 Thread Orit Wasserman
On 01/21/2014 02:11 PM, Gonglei (Arei) wrote: Hi, This is an update of my patch. Modifications in v2: * Removing excess check for g_free * The structure of XBZRLE is divided into two halves.One is for * src side, another is for dest side. What is the benefit of splitting the structure?

Re: [Qemu-devel] [PATCH v2] migration:fix free XBZRLE decoded_buf wrong

2014-01-21 Thread Orit Wasserman
On 01/21/2014 02:58 PM, Gonglei (Arei) wrote: -Original Message- From: Orit Wasserman [mailto:owass...@redhat.com] Sent: Tuesday, January 21, 2014 8:24 PM To: Gonglei (Arei); qemu-devel@nongnu.org; qemu-sta...@nongnu.org; Peter Maydell; anth...@codemonkey.ws; pbonz...@redhat.com Cc

[Qemu-devel] [PATCH 2/2] Add check for cache size smaller than page size

2014-01-07 Thread Orit Wasserman
Signed-off-by: Orit Wasserman owass...@redhat.com --- arch_init.c | 4 migration.c | 10 +- 2 files changed, 13 insertions(+), 1 deletion(-) diff --git a/arch_init.c b/arch_init.c index 5c55c68..e52c9ba 100644 --- a/arch_init.c +++ b/arch_init.c @@ -176,6 +176,10 @@ static struct

[Qemu-devel] [PATCH 1/2] Set xbzrle buffers to NULL after freeing them to avoid double free errors

2014-01-07 Thread Orit Wasserman
Signed-off-by: Orit Wasserman owass...@redhat.com --- arch_init.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/arch_init.c b/arch_init.c index e0acbc5..5c55c68 100644 --- a/arch_init.c +++ b/arch_init.c @@ -587,6 +587,9 @@ static void migration_end(void) g_free

Re: [Qemu-devel] [PATCH 01/38] bitmap: use long as index

2013-12-24 Thread Orit Wasserman
) { if (bitmap1[k] bitmap2[k]) { Reviewed-by: Orit Wasserman owass...@redhat.com

Re: [Qemu-devel] [PATCH 32/38] kvm: use directly cpu_physical_memory_* api for tracking dirty pages

2013-12-19 Thread Orit Wasserman
, +TARGET_PAGE_SIZE * hpratio); } while (c != 0); } } Reviewed-by: Orit Wasserman owass...@redhat.com

Re: [Qemu-devel] [PATCH 33/38] kvm: refactor start address calculation

2013-12-19 Thread Orit Wasserman
; +ram_addr = start + addr; cpu_physical_memory_set_dirty_range(ram_addr, TARGET_PAGE_SIZE * hpratio); } while (c != 0); Reviewed-by: Orit Wasserman owass...@redhat.com

Re: [Qemu-devel] [PATCH 34/38] memory: move bitmap synchronization to its own function

2013-12-19 Thread Orit Wasserman
, pages); return 0; } Reviewed-by: Orit Wasserman owass...@redhat.com

Re: [Qemu-devel] [PATCH 35/38] memory: syncronize kvm bitmap using bitmaps operations

2013-12-19 Thread Orit Wasserman
= start + addr; +cpu_physical_memory_set_dirty_range(ram_addr, + TARGET_PAGE_SIZE * hpratio); +} while (c != 0); +} } } } Reviewed-by: Orit Wasserman owass...@redhat.com

Re: [Qemu-devel] [PATCH 36/38] ram: split function that synchronizes a range

2013-12-19 Thread Orit Wasserman
, block-length); } trace_migration_bitmap_sync_end(migration_dirty_pages - num_dirty_pages_init); Reviewed-by: Orit Wasserman owass...@redhat.com

Re: [Qemu-devel] [PATCH 37/38] migration: synchronize memory bitmap 64bits at a time

2013-12-19 Thread Orit Wasserman
, +DIRTY_MEMORY_MIGRATION); +migration_bitmap_set_dirty(start + addr); +} } } } Reviewed-by: Orit Wasserman owass...@redhat.com

Re: [Qemu-devel] [PATCHv2] block: add native support for NFS

2013-12-18 Thread Orit Wasserman
On 12/18/2013 01:03 AM, Peter Lieven wrote: Am 17.12.2013 um 18:32 schrieb Daniel P. Berrange berra...@redhat.com: On Tue, Dec 17, 2013 at 10:15:25AM +0100, Peter Lieven wrote: This patch adds native support for accessing images on NFS shares without the requirement to actually mount the

Re: [Qemu-devel] [PATCH 07/38] memory: make cpu_physical_memory_is_dirty return bool

2013-12-18 Thread Orit Wasserman
= +cpu_physical_memory_get_dirty_flag(addr, MIGRATION_DIRTY_FLAG); +return vga code migration; } static inline int cpu_physical_memory_get_dirty(ram_addr_t start, Reviewed-by: Orit Wasserman owass...@redhat.com

Re: [Qemu-devel] [PATCH 08/38] memory: all users of cpu_physical_memory_get_dirty used only one flag

2013-12-18 Thread Orit Wasserman
; addr end; addr += TARGET_PAGE_SIZE) { -ret |= cpu_physical_memory_get_dirty_flags(addr) dirty_flags; +ret |= cpu_physical_memory_get_dirty_flag(addr, dirty_flag); } return ret; } Reviewed-by: Orit Wasserman owass...@redhat.com

Re: [Qemu-devel] [PATCH 09/38] memory: set single dirty flags when possible

2013-12-18 Thread Orit Wasserman
(addr, MIGRATION_DIRTY_FLAG); +cpu_physical_memory_set_dirty_flag(addr, VGA_DIRTY_FLAG); +cpu_physical_memory_set_dirty_flag(addr, CODE_DIRTY_FLAG); } static inline int cpu_physical_memory_clear_dirty_flags(ram_addr_t addr, Reviewed-by: Orit Wasserman owass...@redhat.com

Re: [Qemu-devel] [PATCH 10/38] memory: cpu_physical_memory_set_dirty_range() always dirty all flags

2013-12-18 Thread Orit Wasserman
, hwaddr size) { assert(mr-terminates); -cpu_physical_memory_set_dirty_range(mr-ram_addr + addr, size, -1); +cpu_physical_memory_set_dirty_range(mr-ram_addr + addr, size); } bool memory_region_test_and_clear_dirty(MemoryRegion *mr, hwaddr addr, Reviewed-by: Orit Wasserman owass

Re: [Qemu-devel] [PATCH 11/38] memory: cpu_physical_memory_mask_dirty_range() always clears a single flag

2013-12-18 Thread Orit Wasserman
client); +client); } void *memory_region_get_ram_ptr(MemoryRegion *mr) Reviewed-by: Orit Wasserman owass...@redhat.com

Re: [Qemu-devel] [PATCH 12/38] memory: use bit 2 for migration

2013-12-18 Thread Orit Wasserman
DIRTY_MEMORY_CODE 1 -#define DIRTY_MEMORY_MIGRATION 3 +#define DIRTY_MEMORY_MIGRATION 2 +#define DIRTY_MEMORY_NUM 3/* num of dirty bits */ struct MemoryRegionMmio { CPUReadMemoryFunc *read[3]; Reviewed-by: Orit Wasserman owass...@redhat.com

Re: [Qemu-devel] [PATCH 13/38] memory: make sure that client is always inside range

2013-12-18 Thread Orit Wasserman
); +assert(client DIRTY_MEMORY_NUM); + return ram_list.phys_dirty[addr TARGET_PAGE_BITS] = mask; } Reviewed-by: Orit Wasserman owass...@redhat.com

Re: [Qemu-devel] [PATCH 15/38] memory: cpu_physical_memory_clear_dirty_flag() result is never used

2013-12-18 Thread Orit Wasserman
ram_list.phys_dirty[addr TARGET_PAGE_BITS] = mask; +ram_list.phys_dirty[addr TARGET_PAGE_BITS] = mask; } static inline void cpu_physical_memory_set_dirty_range(ram_addr_t start, Reviewed-by: Orit Wasserman owass...@redhat.com

Re: [Qemu-devel] [PATCH 14/38] memory: only resize dirty bitmap when memory size increases

2013-12-18 Thread Orit Wasserman
, new_ram_size); +memset(ram_list.phys_dirty + (new_block-offset TARGET_PAGE_BITS), 0, size TARGET_PAGE_BITS); +} cpu_physical_memory_set_dirty_range(new_block-offset, size); qemu_ram_setup_dump(new_block-host, size); Reviewed-by: Orit Wasserman owass

Re: [Qemu-devel] [PATCH 16/38] bitmap: Add bitmap_zero_extend operation

2013-12-18 Thread Orit Wasserman
- old_nbits); +return new; +} + #endif /* BITMAP_H */ Reviewed-by: Orit Wasserman owass...@redhat.com

Re: [Qemu-devel] [PATCH 17/38] memory: split dirty bitmap into three

2013-12-18 Thread Orit Wasserman
bits */ - struct MemoryRegionMmio { CPUReadMemoryFunc *read[3]; CPUWriteMemoryFunc *write[3]; Reviewed-by: Orit Wasserman owass...@redhat.com

Re: [Qemu-devel] [PATCHv2] block: add native support for NFS

2013-12-18 Thread Orit Wasserman
On 12/18/2013 12:18 PM, Daniel P. Berrange wrote: On Wed, Dec 18, 2013 at 12:00:03PM +0200, Orit Wasserman wrote: On 12/18/2013 01:03 AM, Peter Lieven wrote: Am 17.12.2013 um 18:32 schrieb Daniel P. Berrange berra...@redhat.com: On Tue, Dec 17, 2013 at 10:15:25AM +0100, Peter Lieven wrote

Re: [Qemu-devel] [PATCH 18/38] memory: unfold cpu_physical_memory_clear_dirty_flag() in its only user

2013-12-18 Thread Orit Wasserman
= TARGET_PAGE_ALIGN(start + length); start = TARGET_PAGE_MASK; for (addr = start; addr end; addr += TARGET_PAGE_SIZE) { -cpu_physical_memory_clear_dirty_flag(addr, client); +clear_bit(addr TARGET_PAGE_BITS, ram_list.dirty_memory[client]); } } Reviewed-by: Orit Wasserman owass

Re: [Qemu-devel] [PATCH 19/38] memory: unfold cpu_physical_memory_set_dirty() in its only user

2013-12-18 Thread Orit Wasserman
, DIRTY_MEMORY_CODE); } xen_modified_memory(addr, length); } Reviewed-by: Orit Wasserman owass...@redhat.com

Re: [Qemu-devel] [PATCH 20/38] memory: unfold cpu_physical_memory_set_dirty_flag()

2013-12-18 Thread Orit Wasserman
]); } xen_modified_memory(addr, length); } Reviewed-by: Orit Wasserman owass...@redhat.com

Re: [Qemu-devel] [PATCH 21/38] memory: make cpu_physical_memory_get_dirty() the main function

2013-12-18 Thread Orit Wasserman
) { Reviewed-by: Orit Wasserman owass...@redhat.com

Re: [Qemu-devel] [PATCH 22/38] memory: cpu_physical_memory_get_dirty() is used as returning a bool

2013-12-18 Thread Orit Wasserman
[client])) { +return true; +} } -return ret; +return false; } static inline bool cpu_physical_memory_get_dirty_flag(ram_addr_t addr, Reviewed-by: Orit Wasserman owass...@redhat.com

Re: [Qemu-devel] [PATCH 18/38] memory: unfold cpu_physical_memory_clear_dirty_flag() in its only user

2013-12-18 Thread Orit Wasserman
= TARGET_PAGE_ALIGN(start + length); start = TARGET_PAGE_MASK; for (addr = start; addr end; addr += TARGET_PAGE_SIZE) { -cpu_physical_memory_clear_dirty_flag(addr, client); +clear_bit(addr TARGET_PAGE_BITS, ram_list.dirty_memory[client]); } } Reviewed-by: Orit Wasserman owass

Re: [Qemu-devel] [PATCH 23/38] memory: s/mask/clear/ cpu_physical_memory_mask_dirty_range

2013-12-18 Thread Orit Wasserman
, + ram_addr_t length, + unsigned client) { ram_addr_t addr, end; Reviewed-by: Orit Wasserman owass...@redhat.com

Re: [Qemu-devel] [PATCHv2] block: add native support for NFS

2013-12-18 Thread Orit Wasserman
On 12/18/2013 01:11 PM, Peter Lieven wrote: Am 18.12.2013 um 11:00 schrieb Orit Wasserman owass...@redhat.com: On 12/18/2013 01:03 AM, Peter Lieven wrote: Am 17.12.2013 um 18:32 schrieb Daniel P. Berrange berra...@redhat.com: On Tue, Dec 17, 2013 at 10:15:25AM +0100, Peter Lieven wrote

Re: [Qemu-devel] [PATCH 24/38] memory: use find_next_bit() to find dirty bits

2013-12-18 Thread Orit Wasserman
; +page = start TARGET_PAGE_BITS; +next = find_next_bit(ram_list.dirty_memory[client], end, page); + +return next end; } static inline bool cpu_physical_memory_get_dirty_flag(ram_addr_t addr, Reviewed-by: Orit Wasserman owass...@redhat.com

Re: [Qemu-devel] [PATCH 25/38] memory: cpu_physical_memory_set_dirty_range() now uses bitmap operations

2013-12-18 Thread Orit Wasserman
cpu_physical_memory_clear_dirty_range(ram_addr_t start, Reviewed-by: Orit Wasserman owass...@redhat.com

Re: [Qemu-devel] [PATCH 27/38] memory: s/dirty/clean/ in cpu_physical_memory_is_dirty()

2013-12-18 Thread Orit Wasserman
addr, Reviewed-by: Orit Wasserman owass...@redhat.com

Re: [Qemu-devel] [PATCH 28/38] memory: make cpu_physical_memory_reset_dirty() take a length parameter

2013-12-18 Thread Orit Wasserman
, -mr-ram_addr + addr + size, -client); +cpu_physical_memory_reset_dirty(mr-ram_addr + addr, size, client); } void *memory_region_get_ram_ptr(MemoryRegion *mr) Reviewed-by: Orit Wasserman owass...@redhat.com

Re: [Qemu-devel] [PATCH 29/38] memory: cpu_physical_memory_set_dirty_tracking() should return void

2013-12-18 Thread Orit Wasserman
); +cpu_physical_memory_set_dirty_tracking(true); } static void core_log_global_stop(MemoryListener *listener) { -cpu_physical_memory_set_dirty_tracking(0); +cpu_physical_memory_set_dirty_tracking(false); } static MemoryListener core_memory_listener = { Reviewed-by: Orit Wasserman owass...@redhat.com

Re: [Qemu-devel] [PATCH 30/38] memory: split cpu_physical_memory_* functions to its own include

2013-12-18 Thread Orit Wasserman
exec/memory-internal.h +#include exec/ram_addr.h //#define DEBUG_UNASSIGNED Reviewed-by: Orit Wasserman owass...@redhat.com

Re: [Qemu-devel] [PATCH 26/38] memory: cpu_physical_memory_clear_dirty_range() now uses bitmap operations

2013-12-18 Thread Orit Wasserman
[client], page, end - page); } void cpu_physical_memory_reset_dirty(ram_addr_t start, ram_addr_t end, Reviewed-by: Orit Wasserman owass...@redhat.com

Re: [Qemu-devel] [PATCH 31/38] memory: unfold memory_region_test_and_clear()

2013-12-18 Thread Orit Wasserman
, +TARGET_PAGE_SIZE, +DIRTY_MEMORY_MIGRATION); migration_bitmap_set_dirty(block-mr, addr); } } Reviewed-by: Orit Wasserman owass...@redhat.com

Re: [Qemu-devel] [PATCH 0/9] vmstate code split + unit tests

2013-12-05 Thread Orit Wasserman
create mode 100644 vmstate.c Series Reviewed-by: Orit Wasserman owass...@redhat.com (with v2 of patch 8)

Re: [Qemu-devel] [PATCH] The calculation of bytes_xfer in qemu_put_buffer() is wrong

2013-11-20 Thread Orit Wasserman
= size; memcpy(f-buf + f-buf_index, buf, l); -f-bytes_xfer += size; +f-bytes_xfer += l; if (f-ops-writev_buffer) { add_to_iovec(f, f-buf + f-buf_index, l); } Reviewed-by: Orit Wasserman owass...@redhat.com

Re: [Qemu-devel] [PATCH 01/39] Move prototypes to memory.h

2013-11-07 Thread Orit Wasserman
, ram_addr_t *ram_addr); +void qemu_ram_set_idstr(ram_addr_t addr, const char *name, DeviceState *dev); #endif #endif Reviewed-by: Orit Wasserman owass...@redhat.com

Re: [Qemu-devel] [PATCH 02/39] memory: cpu_physical_memory_set_dirty_flags() result is never used

2013-11-07 Thread Orit Wasserman
cpu_physical_memory_set_dirty(ram_addr_t addr) Reviewed-by: Orit Wasserman owass...@redhat.com

Re: [Qemu-devel] [PATCH 03/39] memory: cpu_physical_memory_set_dirty_range() return void

2013-11-07 Thread Orit Wasserman
memory_region_test_and_clear_dirty(MemoryRegion *mr, hwaddr addr, Reviewed-by: Orit Wasserman owass...@redhat.com

Re: [Qemu-devel] [PATCH 04/39] exec: use accessor function to know if memory is dirty

2013-11-07 Thread Orit Wasserman
= current_cpu-env_ptr; tlb_set_dirty(env, env-mem_io_vaddr); } Reviewed-by: Orit Wasserman owass...@redhat.com

Re: [Qemu-devel] [PATCH 05/39] memory: create function to set a single dirty bit

2013-11-07 Thread Orit Wasserman
) +{ +ram_list.phys_dirty[addr TARGET_PAGE_BITS] |= dirty_flag; +} + static inline void cpu_physical_memory_set_dirty(ram_addr_t addr) { cpu_physical_memory_set_dirty_flags(addr, 0xff); Reviewed-by: Orit Wasserman owass...@redhat.com

Re: [Qemu-devel] KVM call for agenda for 2013-10-01

2013-09-30 Thread Orit Wasserman
On 09/24/2013 05:09 PM, Juan Quintela wrote: Hi Please, send any topic that you are interested in covering. Last week I forgot to send the call for topics. We still have a topic there. Thanks, Juan. Agenda so far: - Talk about qemu reverse executing (1st description was done this

Re: [Qemu-devel] [PATCH RFC 0/4] Curling: KVM Fault Tolerance

2013-09-12 Thread Orit Wasserman
On 09/11/2013 04:54 AM, junqing.w...@cs2c.com.cn wrote: Hi, The first is that if the VM failure happen in the middle on the live migration the backup VM state will be inconsistent which means you can't failover to it. Yes, I have concerned about this problem. That is why we need a

Re: [Qemu-devel] [PATCH 3/3 resend v2] arch_init: right return for ram_save_iterate

2013-09-12 Thread Orit Wasserman
On 09/11/2013 02:27 PM, Paolo Bonzini wrote: Il 11/09/2013 13:06, Juan Quintela ha scritto: And I think that the right solution is make qemu_get_rate_limit() to return -1 in case of error (or the error, I don't care). You might do both things, it would avoid the useless g_usleep you pointed

Re: [Qemu-devel] [PATCH RFC 0/4] Curling: KVM Fault Tolerance

2013-09-10 Thread Orit Wasserman
On 09/10/2013 06:43 AM, Jules Wang wrote: The goal of Curling(sports) is to provide a fault tolerant mechanism for KVM, so that in the event of a hardware failure, the virtual machine fails over to the backup in a way that is completely transparent to the guest operating system. Our goal

Re: [Qemu-devel] [PATCH 0/3 resend v2] Migration fix

2013-09-04 Thread Orit Wasserman
| 15 ++- savevm.c|9 - 2 files changed, 18 insertions(+), 6 deletions(-) Looks good, Reviewed-by: Orit Wasserman owass...@redhat.com

Re: [Qemu-devel] [PATCH v2] Fix query-migrate documentation in qmp-commands.hx

2013-08-20 Thread Orit Wasserman
On 08/19/2013 09:41 PM, Luiz Capitulino wrote: On Mon, 12 Aug 2013 10:19:52 -0400 Luiz Capitulino lcapitul...@redhat.com wrote: On Thu, 8 Aug 2013 20:05:48 +0300 Orit Wasserman owass...@redhat.com wrote: ram is present also when migration completes. expected-downtime, total-time

Re: [Qemu-devel] [PATCH for-1.6 4/4] rdma: proper getaddrinfo() handling

2013-08-08 Thread Orit Wasserman
); -rdma-ipv6 = addr-ipv6; } else { ERROR(errp, bad RDMA migration address '%s', host_port); g_free(rdma); Looks good, Reviewed-by: Orit Wasserman owass...@redhat.com

[Qemu-devel] [PATCH] Fix query-migrate documentation in qmp-commands.hx

2013-08-08 Thread Orit Wasserman
ram is present also when migration completes. total-time and downtime are no longer part of ram data. Signed-off-by: Orit Wasserman owass...@redhat.com --- qmp-commands.hx | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/qmp-commands.hx b/qmp-commands.hx index

Re: [Qemu-devel] [PATCH] Fix query-migrate documentation in qmp-commands.hx

2013-08-08 Thread Orit Wasserman
On 08/08/2013 05:50 PM, Luiz Capitulino wrote: On Thu, 8 Aug 2013 11:46:14 +0300 Orit Wasserman owass...@redhat.com wrote: ram is present also when migration completes. total-time and downtime are no longer part of ram data. expected-downtime has to be moved too, looks good otherwise. I

[Qemu-devel] [PATCH v2] Fix query-migrate documentation in qmp-commands.hx

2013-08-08 Thread Orit Wasserman
ram is present also when migration completes. expected-downtime, total-time and downtime are no longer part of ram data. Signed-off-by: Orit Wasserman owass...@redhat.com --- qmp-commands.hx | 20 ++-- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/qmp

Re: [Qemu-devel] [PATCH v3 For-1.6 1/7] rdma: bugfix: make IPv6 support work

2013-08-07 Thread Orit Wasserman
On 08/04/2013 05:54 AM, mrhi...@linux.vnet.ibm.com wrote: From: Michael R. Hines mrhi...@us.ibm.com RDMA does not use sockets, so we cannot use many of the socket helper functions, but we *do* use inet_parse() which gives RDMA all the necessary details of the connection parameters.

Re: [Qemu-devel] [PATCH v3 For-1.6 2/7] rdma: forgot to turn off the debugging flag

2013-08-07 Thread Orit Wasserman
Reviewed-by: Orit Wasserman owass...@redhat.com

Re: [Qemu-devel] [PATCH v3 For-1.6 3/7] rdma: correct newlines in error statements

2013-08-07 Thread Orit Wasserman
rdma_start_outgoing_migration(void *opaque, int ret = 0; if (rdma == NULL) { -ERROR(temp, Failed to initialize RDMA data structures! %d\n, ret); +ERROR(temp, Failed to initialize RDMA data structures! %d, ret); goto err; } Reviewed-by: Orit Wasserman owass

Re: [Qemu-devel] [PATCH 0/3] rdma: validate remote provided RDMAControlHeader::len

2013-08-07 Thread Orit Wasserman
match transferred byte migration-rdma.c | 44 ++-- 1 file changed, 30 insertions(+), 14 deletions(-) Series Reviewed-by: Orit Wasserman owass...@redhat.com

Re: [Qemu-devel] [PATCH] rdma: bugfix: make IPv6 support work

2013-07-31 Thread Orit Wasserman
On 07/31/2013 04:39 PM, Michael R. Hines wrote: On 07/30/2013 11:31 AM, Orit Wasserman wrote: On 07/30/2013 05:57 PM, Michael R. Hines wrote: On 07/30/2013 04:14 AM, Orit Wasserman wrote: On 07/27/2013 05:23 AM, mrhi...@linux.vnet.ibm.com wrote: From: Michael R. Hines mrhi...@us.ibm.com

Re: [Qemu-devel] [PATCH] rdma: bugfix: make IPv6 support work

2013-07-30 Thread Orit Wasserman
On 07/27/2013 05:23 AM, mrhi...@linux.vnet.ibm.com wrote: From: Michael R. Hines mrhi...@us.ibm.com When testing with libvirt, a simple IPv6 migration test failed because we were not using getaddrinfo() properly. This makes IPv6 migration over RDMA work. Also, we forgot to turn the

Re: [Qemu-devel] [PATCH] rdma: bugfix: make IPv6 support work

2013-07-30 Thread Orit Wasserman
On 07/30/2013 05:57 PM, Michael R. Hines wrote: On 07/30/2013 04:14 AM, Orit Wasserman wrote: On 07/27/2013 05:23 AM, mrhi...@linux.vnet.ibm.com wrote: From: Michael R. Hines mrhi...@us.ibm.com When testing with libvirt, a simple IPv6 migration test failed because we were not using

[Qemu-devel] [PATCH 2/2] Fix real mode guest segments dpl value in savevm

2013-07-22 Thread Orit Wasserman
. Signed-off-by: Orit Wasserman owass...@redhat.com --- target-i386/machine.c | 18 ++ 1 file changed, 18 insertions(+) diff --git a/target-i386/machine.c b/target-i386/machine.c index 7e95829..4e39ca9 100644 --- a/target-i386/machine.c +++ b/target-i386/machine.c @@ -252,6 +252,24

[Qemu-devel] [PATCH 1/2] Fix real mode guest migration

2013-07-22 Thread Orit Wasserman
. For example migration from a Penryn host (with kernel 2.6.32) to a Westmere host. Signed-off-by: Orit Wasserman owass...@redhat.com --- target-i386/machine.c | 18 ++ 1 file changed, 18 insertions(+) diff --git a/target-i386/machine.c b/target-i386/machine.c index 3659db9..7e95829

Re: [Qemu-devel] [PATCH] migration: send total time in QMP at completed stage

2013-07-22 Thread Orit Wasserman
; info-total_time = s-total_time; info-has_downtime = true; info-downtime = s-downtime; Reviewed-by: Orit Wasserman owass...@redhat.com

Re: [Qemu-devel] [PATCH] migration: don't use uninitialized variables

2013-07-22 Thread Orit Wasserman
; -params.blk = blk; -params.shared = inc; +params.blk = has_blk blk; +params.shared = has_inc inc; if (s-state == MIG_STATE_ACTIVE) { error_set(errp, QERR_MIGRATION_ACTIVE); Reviewed-by: Orit Wasserman owass...@redhat.com

Re: [Qemu-devel] [PATCH 1/2] Fix real mode guest migration

2013-07-22 Thread Orit Wasserman
On 07/22/2013 12:49 PM, Paolo Bonzini wrote: Il 22/07/2013 08:49, Orit Wasserman ha scritto: Older KVM versions save CS dpl value to an invalid value for real mode guests (0x3). This patch detect this situation when loading CPU state and set all the segments dpl to zero. This will allow

Re: [Qemu-devel] [PATCH 1/2] Fix real mode guest migration

2013-07-22 Thread Orit Wasserman
On 07/22/2013 01:33 PM, Andreas Färber wrote: Am 22.07.2013 11:49, schrieb Paolo Bonzini: Il 22/07/2013 08:49, Orit Wasserman ha scritto: Older KVM versions save CS dpl value to an invalid value for real mode guests (0x3). This patch detect this situation when loading CPU state and set all

[Qemu-devel] [PATCH v2 2/2] Fix real mode guest segments dpl value in savevm

2013-07-22 Thread Orit Wasserman
. Signed-off-by: Orit Wasserman owass...@redhat.com --- target-i386/machine.c | 18 ++ 1 file changed, 18 insertions(+) diff --git a/target-i386/machine.c b/target-i386/machine.c index 83ea6ac..c98f1c9 100644 --- a/target-i386/machine.c +++ b/target-i386/machine.c @@ -252,6 +252,24

[Qemu-devel] [PATCH v2 1/2] Fix real mode guest migration

2013-07-22 Thread Orit Wasserman
. For example migration from a Penryn host (with kernel 2.6.32) to a Westmere host (for real mode guest) will fail with kvm: unhandled exit 8021. Signed-off-by: Orit Wasserman owass...@redhat.com --- target-i386/machine.c | 18 ++ 1 file changed, 18 insertions(+) diff --git

  1   2   3   4   5   6   7   8   >