On Mon, Sep 30, 2024, 06:24 Alex Bennée wrote:
> Stefan Hajnoczi writes:
>
> > On Thu, 26 Sept 2024 at 10:24, Alex Bennée
> wrote:
>
> >> Another potential area for conversion was the VirtIO device and
> >> vhost-user code which could expect to re-use a
On Mon, 1 Jul 2024 at 11:02, Paolo Bonzini wrote:
> +/// A type for which there is a canonical representation as a C datum.
> +pub trait CloneToForeign {
> +/// The representation of `Self` as a C datum. Typically a
> +/// `struct`, though there are exceptions for example `c_char`
> +
g C code.
- Adding Rust bindings to existing subsystems so that new code (e.g.
device models) can optionally be written in Rust while still allowing
new C code.
Let's speak more broadly about "integrating Rust" rather than
"conversion", which is just one of the ways to use Rust in
Am 17.09.24 um 23:55 schrieb Peter Xu:
From: Stefan Weil via
How can I avoid that my author name/email is changed so often?
Will this be fixed automatically before the commit is merged?
Stefan
From: Dmitry Frolov
The product bs->bl.zone_size * (bs->bl.nr_zones - 1) may overflow
uint32.
Found by Linux Verification Center (linuxtesting.org) with SVACE.
Signed-off-by: Dmitry Frolov
Message-id: 20240917080356.270576-2-fro...@swemel.ru
Signed-off-by: Stefan Hajnoczi
---
hw
The following changes since commit ea9cdbcf3a0b8d5497cddf87990f1b39d8f3bb0a:
Merge tag 'hw-misc-20240913' of https://github.com/philmd/qemu into staging
(2024-09-15 18:27:40 +0100)
are available in the Git repository at:
https://gitlab.com/stefanha/qemu.git tags/block-pull-request
for you
/virtio-blk.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Thanks, applied to my block tree:
https://gitlab.com/stefanha/qemu/commits/block
Stefan
signature.asc
Description: PGP signature
On Tue, 17 Sept 2024 at 10:33, Stefan Hajnoczi wrote:
>
> On Thu, Sep 12, 2024 at 04:53:34PM +0200, Albert Esteve wrote:
> > @@ -331,6 +333,37 @@ static void vub_device_realize(DeviceState *dev, Error
> > **errp)
> > do_vhost_user_cleanup(vdev, vub);
> >
On Thu, Sep 12, 2024 at 04:53:34PM +0200, Albert Esteve wrote:
> @@ -331,6 +333,37 @@ static void vub_device_realize(DeviceState *dev, Error
> **errp)
> do_vhost_user_cleanup(vdev, vub);
> }
>
> +ret = vub->vhost_dev.vhost_ops->vhost_get_shmem_config(&vub->vhost_dev,
> +
On Thu, Sep 12, 2024 at 04:53:34PM +0200, Albert Esteve wrote:
> Add a cache BAR in the vhost-user-device
> into which files can be directly mapped.
>
> The number, shmid, and size of the VIRTIO Shared
> Memory subregions is retrieved through a get_shmem_config
> message sent by the vhost-user-bas
On Thu, Sep 12, 2024 at 04:53:33PM +0200, Albert Esteve wrote:
> The frontend can use this command to retrieve
> VIRTIO Shared Memory Regions configuration from
> the backend. The response contains the number of
> shared memory regions, their size, and shmid.
>
> This is useful when the frontend i
On Thu, Sep 12, 2024 at 04:53:33PM +0200, Albert Esteve wrote:
> The frontend can use this command to retrieve
> VIRTIO Shared Memory Regions configuration from
> the backend. The response contains the number of
> shared memory regions, their size, and shmid.
>
> This is useful when the frontend i
On Tue, Sep 17, 2024 at 09:05:34AM +0200, Albert Esteve wrote:
> On Mon, Sep 16, 2024 at 7:57 PM Stefan Hajnoczi wrote:
>
> > This patch series could use tests. The first two patches seem broken and
> > testing would have revealed that the memory allocation and pointers are
&
with
--device vhost-user-device, and then use the qtest API to enumerate and
access the VIRTIO Shared Memory Regions. Unfortunately this involves
writing quite a bit of test code. I can explain it in more detail if you
want.
Does anyone have other ideas for testing?
Stefan
signature.asc
On Thu, Sep 12, 2024 at 04:53:32PM +0200, Albert Esteve wrote:
> Update shmem_list to be able to track
> active mappings on VIRTIO shared memory
> regions. This allows to verify that new
> mapping request received from backends
> do not overlap. If they do, the request
> shall fail in order to adhe
On Thu, Sep 12, 2024 at 04:53:31PM +0200, Albert Esteve wrote:
> Add SHMEM_MAP/UNMAP requests to vhost-user to
> handle VIRTIO Shared Memory mappings.
>
> This request allows backends to dynamically map
> fds into a VIRTIO Shared Memory Region indentified
> by its `shmid`. Then, the fd memory is a
On Thu, Sep 12, 2024 at 04:44:29PM +0200, Albert Esteve wrote:
> As a continuation of the
> "Add SHMEM_MAP/UNMAP requests" patch [1],
> I wanted to split vhost-user spec
> parts into a separate patch, so that
> it could be reviewed and integrated
> separately. Having the specs upstreamed
> would he
On Thu, Sep 12, 2024 at 04:44:30PM +0200, Albert Esteve wrote:
> Add SHMEM_MAP/_UNMAP request to the vhost-user
> spec documentation.
>
> Signed-off-by: Albert Esteve
> ---
> docs/interop/vhost-user.rst | 31 +++
> 1 file changed, 31 insertions(+)
>
> diff --git a/do
On Thu, Sep 12, 2024 at 04:44:32PM +0200, Albert Esteve wrote:
> Add GET_SHMEM_CONFIG vhost-user frontend
> message to the spec documentation.
>
> Signed-off-by: Albert Esteve
> ---
> docs/interop/vhost-user.rst | 39 +
> 1 file changed, 39 insertions(+)
>
>
rMMap defined? Please keep patches
self-contained and in a logical order so they can be reviewed linearly.
Otherwise:
Reviewed-by: Stefan Hajnoczi
> + :reply payload: N/A
> +
> + This message can be submitted by the backends to advertise a new mapping
> + to be made in a given VIRTIO Shar
On Thu, Sep 12, 2024 at 07:19:16PM +0800, Changqi Lu wrote:
> +static int nvme_read_reservation_cb(NvmeReadReservation *reservation)
> +{
> +int rc;
> +NvmeReservationStatus *nvme_status;
> +NvmeRequest *req = reservation->req;
> +NvmeCtrl *n = req->sq->ctrl;
> +NvmeResvKeys *ke
On 9/12/24 12:09 PM, dan tan wrote:
From: dan tan
SPI interface to TPM TIS implementation via swtpm
Apart from Cedric's comments:
Can you say a bit more about the specs you followed and details how many
localities are supported etc. Is this device pnv-specific or can it be
used on other
On Wed, 11 Sept 2024 at 07:58, Albert Esteve wrote:
> On Thu, Sep 5, 2024 at 6:45 PM Stefan Hajnoczi wrote:
>>
>> On Tue, Sep 03, 2024 at 01:54:12PM +0200, Albert Esteve wrote:
>> > On Tue, Sep 3, 2024 at 11:54 AM Albert Esteve wrote:
>> >
>> > >
On Mon, Sep 09, 2024 at 07:34:52PM +0800, Changqi Lu wrote:
> Add reservation acquire, reservation register,
> reservation release and reservation report commands
> in the nvme device layer.
>
> By introducing these commands, this enables the nvme
> device to perform reservation-related tasks, inc
GitHub's CodeQL reports four critical errors which are fixed by this commit:
Unsigned difference expression compared to zero
An expression (u - v > 0) with unsigned values u, v is only false if u == v,
so all changed expressions did not work as expected.
Signed-off-by: Stefan Weil
GitHub's CodeQL reports a critical error which is fixed by using the MIN macro:
Unsigned difference expression compared to zero
Signed-off-by: Stefan Weil
---
net/colo-compare.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/net/colo-compare.c b/net/colo-comp
ibility with < 2.0.16. This would help reduce the potential
combinations of versions and bugs reports.
[...]
I agree. My builds for Windows typically use the very latest versions,
for example mingw-w64-i686-SDL2-2.30.7-1-any for the next build. So
depending on a recent SDL version would be fine for me.
Stefan W.
On Fri, 6 Sept 2024 at 03:06, Albert Esteve wrote:
> On Thu, Sep 5, 2024 at 6:39 PM Stefan Hajnoczi wrote:
>>
>> On Tue, Sep 03, 2024 at 10:42:34AM +0200, Albert Esteve wrote:
>> > Hello all,
>> >
>> > Sorry, I have been a bit disconnected from this thre
On Fri, 6 Sept 2024 at 00:19, David Stevens wrote:
>
> On Fri, Sep 6, 2024 at 12:56 AM Stefan Hajnoczi wrote:
> >
> > On Tue, Jul 16, 2024 at 10:21:35AM +0900, David Stevens wrote:
> > > On Fri, Jul 12, 2024 at 2:47 PM Michael S. Tsirkin
> > > wrote:
> &
On Wed, Sep 04, 2024 at 03:01:06PM +0200, Albert Esteve wrote:
> On Thu, Jul 11, 2024 at 10:55 AM Stefan Hajnoczi
> wrote:
>
> > On Fri, Jun 28, 2024 at 04:57:10PM +0200, Albert Esteve wrote:
> > > Implement function handlers for memory read and write
> > > oper
On Tue, Sep 03, 2024 at 01:54:12PM +0200, Albert Esteve wrote:
> On Tue, Sep 3, 2024 at 11:54 AM Albert Esteve wrote:
>
> >
> >
> > On Thu, Jul 11, 2024 at 9:45 AM Stefan Hajnoczi
> > wrote:
> >
> >> On Fri, Jun 28, 2024 at 04:57:06PM +0200, Al
that frequently MAP/UNMAP like virtiofs. Will virtio-gpu and
virtio-media use MAP/UNMAP often at runtime? They might be able to get
away with this simple solution.
I'd be happy with that. If someone wants to make virtiofs DAX faster,
they can implement READ/WRITE_MEM or another solution later,
> >
> > > > It would be great if this could be standardised between QEMU and crosvm
> > > > (and therefore have a clearer path toward being implemented in other
> > > > VMMs)!
> > >
> > > Setting aside vhost-user for a moment, the DAX exa
On Tue, 3 Sept 2024 at 12:54, Maciej S. Szmigiero
wrote:
>
> On 3.09.2024 15:55, Stefan Hajnoczi wrote:
> > On Tue, 27 Aug 2024 at 13:58, Maciej S. Szmigiero
> > wrote:
> >>
> >> From: "Maciej S. Szmigiero"
> >>
> >> Migrati
On Tue, 27 Aug 2024 at 13:58, Maciej S. Szmigiero
wrote:
>
> From: "Maciej S. Szmigiero"
>
> Migration code wants to manage device data sending threads in one place.
>
> QEMU has an existing thread pool implementation, however it was limited
> to queuing AIO operations only and essentially had a
h. The
code ended up very close to what he suggested.
Suggested-by: Markus Armbruster
Cc: Daniel P. Berrangé
Signed-off-by: Stefan Hajnoczi
---
system/qdev-monitor.c | 44 ---
1 file changed, 29 insertions(+), 15 deletions(-)
diff --git a/system/qde
and use
qmp_device_add().
Cc: Peter Krempa
Reviewed-by: Markus Armbruster
Signed-off-by: Stefan Hajnoczi
---
system/vl.c | 14 --
1 file changed, 4 insertions(+), 10 deletions(-)
diff --git a/system/vl.c b/system/vl.c
index 01b8b8e77a..3db63af764 100644
--- a/system/vl.c
+++ b
device_add (e.g.
virtio-blk-pci,iothread-vq-mapping=). Stop converting from QDict to QemuOpts
and back again as this loses type information and cannot represent non-scalars.
Stefan Hajnoczi (2):
qdev-monitor: avoid QemuOpts in QMP device_add
vl: use qmp_device_add() in qemu_create_cli_devices(
On Tue, Aug 13, 2024 at 09:18:46AM +0100, Paul Durrant wrote:
> On 12/08/2024 19:15, Stefan Hajnoczi wrote:
> > On Fri, Aug 02, 2024 at 10:10:43AM +0200, Markus Armbruster wrote:
> > > Can we additionally cut out the QemuOpts middleman in
> > > usbback_portid_add
On Tue, 27 Aug 2024 at 13:24, David Hildenbrand wrote:
>
> On 27.08.24 18:52, Stefan Hajnoczi wrote:
> > On Tue, 27 Aug 2024 at 04:38, David Hildenbrand wrote:
> >>
> >> As reported by Peter, we might be leaking memory when removing the
> >> highest RAMBlo
L=AfX6A4kScq=vssk0pe...@mail.gmail.com
> Reported-by: Peter Maydell
> Fixes: 5b82b703b69a ("memory: RCU ram_list.dirty_memory[] for safe RAM
> hotplug")
> Cc: qemu-sta...@nongnu.org
> Cc: Stefan Hajnoczi
> Cc: Paolo Bonzini
> Cc: Peter Xu
> Cc: "Philippe Ma
7;/path/to/build/qemu-nbd -L -k /tmp/nbd-sock')
> >
> > def test():
> > sst = Thread(target=start_stop)
> > sst.start()
> > nlt = Thread(target=nbd_list)
> > nlt.start()
> >
> > sst.join()
> > nlt.join()
> >
&g
ever is "qemu", he/she might do the same as you did and
write to the Travis support.
And https://travis-ci.org/qemu/qemu could be replaced by
https://app.travis-ci.com/github/qemu/qemu in MAINTAINERS.
Stefan
ibute__((gcc_struct));',
+ args: '-Werror')
+error('Your compiler does not support __attribute__((gcc_struct)) - please
use GCC instead of Clang')
+ endif
endif
# __sync_fetch_and_and requires at least -march=i486. Many toolchains
Tested-by: Stefan Weil
On Mon, 12 Aug 2024, John Snow wrote:
> On Tue, Apr 16, 2024 at 7:54 AM Stefan Fritsch wrote:
>
> > adding John Snow to CC because he investigated this in 2020.
> >
> > On Fri, 12 Apr 2024, Eric Blake wrote:
> >
> > > On Fri, Apr 12, 2024 at
Fix the misspellings of "overriden" also in code comments.
Signed-off-by: Stefan Weil
---
docs/devel/migration/uadk-compression.rst | 4 ++--
docs/interop/qemu-ga.rst | 2 +-
docs/tools/qemu-vmsr-helper.rst | 4 ++--
hw/arm/smmu-common.c
which still mentions Python 3.7 or even 3.5 and 3.6
could be reviewed and maybe simplified, but I think this is less urgent
and can be done after QEMU release 9.1.0.
Regards
Stefan W.
$ git grep -i python.*3.7
docs/about/build-platforms.rst: As of QEMU |version|, the minimum
supported version of
;
> usbif->ports[port - 1].dev = USB_DEVICE(qdev_device_add(opts,
> &local_err));
>
> Trying this is up to you!
Paul or Anthony: Do you know how to run usbback_portid_add() for
testing? I would like to make sure that suggested the code change works
and don't have experience running the Xen code in QEMU.
Thanks,
Stefan
signature.asc
Description: PGP signature
On Fri, Aug 02, 2024 at 10:01:20AM +0200, Markus Armbruster wrote:
> Stefan Hajnoczi writes:
>
> > The QMP device_add monitor command converts the QDict arguments to
> > QemuOpts and then back again to QDict. This process only supports scalar
> > types. Device properti
The following changes since commit 0f397dcfecc9211d12c2c720c01eb32f0eaa7d23:
Merge tag 'pull-nbd-2024-08-08' of https://repo.or.cz/qemu/ericb into staging
(2024-08-09 08:40:37 +1000)
are available in the Git repository at:
https://gitlab.com/stefanha/qemu.git tags/block-pull-request
for yo
m
Signed-off-by: Stefan Hajnoczi
---
meson.build | 2 ++
block/blkio.c | 6 --
2 files changed, 6 insertions(+), 2 deletions(-)
diff --git a/meson.build b/meson.build
index c2a050b844..81ecd4bae7 100644
--- a/meson.build
+++ b/meson.build
@@ -2305,6 +2305,8 @@ config_host_data.set('CONFIG
+
> block/blkio.c | 6 --
> 2 files changed, 6 insertions(+), 2 deletions(-)
Thanks, applied to my block tree:
https://gitlab.com/stefanha/qemu/commits/block
Stefan
signature.asc
Description: PGP signature
On Fri, Aug 02, 2024 at 11:41:35PM +0200, Philippe Mathieu-Daudé wrote:
> On 2/8/24 21:26, Eric Blake wrote:
> > Error messages from an NBD server must be treated as untrusted; a
> > malicious server can inject escape sequences to try and trigger RCE
> > flaws via escape sequences to whatever termi
and use
qmp_device_add().
Cc: Peter Krempa
Signed-off-by: Stefan Hajnoczi
---
system/vl.c | 14 --
1 file changed, 4 insertions(+), 10 deletions(-)
diff --git a/system/vl.c b/system/vl.c
index 9e8f16f155..0beb8bfb57 100644
--- a/system/vl.c
+++ b/system/vl.c
@@ -2651,17 +2651,11
8 +++---
> 4 files changed, 34 insertions(+), 6 deletions(-)
Reviewed-by: Stefan Hajnoczi
signature.asc
Description: PGP signature
tion and cannot represent non-scalars.
Stefan Hajnoczi (2):
qdev-monitor: avoid QemuOpts in QMP device_add
vl: use qmp_device_add() in qemu_create_cli_devices()
system/qdev-monitor.c | 56 ++-
system/vl.c | 14 ---
2 files changed, 33 in
om_qdict()
so all callers benefit from it automatically. This avoids code
duplication.
Markus helped me figure this out and even provided a draft patch. The
code ended up very close to what he suggested.
Suggested-by: Markus Armbruster
Cc: Daniel P. Berrangé
Signed-off-by: Stefan Hajnoczi
---
s
ks.
Reviewed-by: Stefan Weil
On Wed, 31 Jul 2024 at 09:59, Peter Krempa wrote:
>
> On Tue, Jul 09, 2024 at 16:27:22 +0200, Markus Armbruster wrote:
> > Stefan Hajnoczi writes:
> >
> > > The QMP device_add monitor command converts the QDict arguments to
> > > QemuOpts and then back again
olves: Coverity CID 1547605
Signed-off-by: Peter Maydell
Reviewed-by: Philippe Mathieu-Daudé
Message-id: 20240723150927.1396456-1-peter.mayd...@linaro.org
Signed-off-by: Stefan Hajnoczi
---
util/async.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/util/async.c b/util/as
The following changes since commit 029e13a8a56a2931e7c24c0db52ae7256b932cb0:
Merge tag 'bsd-user-for-9.1-pull-request' of gitlab.com:bsdimp/qemu into
staging (2024-07-25 09:53:57 +1000)
are available in the Git repository at:
https://gitlab.com/stefanha/qemu.git tags/block-pull-request
for
aio_context_set_thread_pool_params() return an error if either min or
> max are negative.
>
> Resolves: Coverity CID 1547605
> Signed-off-by: Peter Maydell
> ---
> util/async.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Thanks, applied to my block tree
On Tue, Jul 09, 2024 at 10:47:05AM +0800, Changqi Lu wrote:
> Add reservation acquire, reservation register,
> reservation release and reservation report commands
> in the nvme device layer.
>
> By introducing these commands, this enables the nvme
> device to perform reservation-related tasks, inc
_co_pr_clear and bdrv_co_pr_preempt.
>
> Signed-off-by: Changqi Lu
> Signed-off-by: zhenwei pi
> ---
> block/iscsi.c | 425 ++
> 1 file changed, 425 insertions(+)
Aside from the g_free() issue I commented on:
Reviewed-by: St
On Tue, Jul 09, 2024 at 10:47:06AM +0800, Changqi Lu wrote:
> Add persistent reservation in/out operations for iscsi driver.
> The following methods are implemented: bdrv_co_pr_read_keys,
> bdrv_co_pr_read_reservation, bdrv_co_pr_register, bdrv_co_pr_reserve,
> bdrv_co_pr_release, bdrv_co_pr_clear
Reviewed-by: Klaus Jensen
> Signed-off-by: Changqi Lu
> Signed-off-by: zhenwei pi
> ---
> hw/nvme/ctrl.c | 3 ++-
> hw/nvme/ns.c | 5 +
> include/block/nvme.h | 2 +-
> 3 files changed, 8 insertions(+), 2 deletions(-)
Reviewed-by: Stefan Hajnoczi
signature.asc
Description: PGP signature
ent manner.
>
> Signed-off-by: Changqi Lu
> Signed-off-by: zhenwei pi
> ---
> hw/scsi/scsi-disk.c | 368
> 1 file changed, 368 insertions(+)
Paolo: Please review this patch, I'm not familiar enough with hw/scsi/.
Reviewed-by: Stefan Hajnoczi
signature.asc
Description: PGP signature
https://lists.nongnu.org/archive/html/qemu-discuss/2024-06/msg3.html
Signed-off-by: Nir Soffer
Message-id: 20240628202058.1964986-3-nsof...@redhat.com
Signed-off-by: Stefan Hajnoczi
---
block/io.c| 9 +-
tests/qemu-iotests/tests/write-zeroes-unmap
From: Nir Soffer
The test works since we punch holes by default even when opening the
image without discard=on or discard=unmap. Fix the test to enable
discard.
Signed-off-by: Stefan Hajnoczi
---
tests/qemu-iotests/245 | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests
The following changes since commit 59084feb256c617063e0dbe7e64821ae8852d7cf:
Merge tag 'pull-aspeed-20240709' of https://github.com/legoater/qemu into
staging (2024-07-09 07:13:55 -0700)
are available in the Git repository at:
https://gitlab.com/stefanha/qemu.git tags/block-pull-request
fo
81 +++
> 4 files changed, 214 insertions(+), 5 deletions(-)
> create mode 100755 tests/qemu-iotests/tests/write-zeroes-unmap
> create mode 100644 tests/qemu-iotests/tests/write-zeroes-unmap.out
>
> --
> 2.45.2
>
Thanks, applied to my block tree:
https://gitlab.com/stefanha/qemu/commits/block
Stefan
signature.asc
Description: PGP signature
| 9 +-
> tests/qemu-iotests/tests/write-zeroes-unmap | 127 ++
> .../qemu-iotests/tests/write-zeroes-unmap.out | 81 +++
> 3 files changed, 213 insertions(+), 4 deletions(-)
> create mode 100755 tests/qemu-iotests/tests/write-zeroes-unmap
> create
ion(+), 1 deletion(-)
Reviewed-by: Stefan Hajnoczi
signature.asc
Description: PGP signature
s use
SHMEM_MAP due to the incomplete memory table that prevents translating
those memory addresses. In other words, if the guest has a device that
uses SHMEM_MAP, then all other vhost-user devices should support
MEM_READ/MEM_WRITE in order to ensure that DMA works with Shared Memory
Regions.
St
On Fri, Jun 28, 2024 at 04:57:10PM +0200, Albert Esteve wrote:
> Implement function handlers for memory read and write
> operations.
>
> Signed-off-by: Albert Esteve
> ---
> hw/virtio/vhost-user.c | 34 ++
> 1 file changed, 30 insertions(+), 4 deletions(-)
>
> di
On Fri, Jun 28, 2024 at 04:57:09PM +0200, Albert Esteve wrote:
> With SHMEM_MAP messages, sharing descriptors between
> devices will cause that these devices do not see the
> mappings, and fail to access these memory regions.
>
> To solve this, introduce MEM_READ/WRITE requests
> that will get tri
On Fri, Jun 28, 2024 at 04:57:08PM +0200, Albert Esteve wrote:
> Add a cache BAR in the vhost-user-device
> into which files can be directly mapped.
>
> The number, shmid, and size of the VIRTIO Shared
> Memory subregions is retrieved through a get_shmem_config
> message sent by the vhost-user-bas
On Fri, Jun 28, 2024 at 04:57:07PM +0200, Albert Esteve wrote:
> The frontend can use this command to retrieve
> VIRTIO Shared Memory Regions configuration from
> the backend. The response contains the number of
> shared memory regions, their size, and shmid.
>
> This is useful when the frontend i
On Fri, Jun 28, 2024 at 04:57:07PM +0200, Albert Esteve wrote:
> The frontend can use this command to retrieve
> VIRTIO Shared Memory Regions configuration from
> the backend. The response contains the number of
> shared memory regions, their size, and shmid.
>
> This is useful when the frontend i
On Fri, Jun 28, 2024 at 04:57:06PM +0200, Albert Esteve wrote:
> Add SHMEM_MAP/UNMAP requests to vhost-user to
> handle VIRTIO Shared Memory mappings.
>
> This request allows backends to dynamically map
> fds into a VIRTIO Shared Memory Region indentified
> by its `shmid`. Then, the fd memory is a
ck
> block/graph-lock: Make WITH_GRAPH_RDLOCK_GUARD() fully checked
>
> include/block/graph-lock.h | 21 ++---
> block/block-copy.c | 4 +++-
> meson.build| 14 +-
> 3 files changed, 30 insertions(+), 9 deletions(-)
>
ncing of
the VIRTIO and Linux communities to add this new concept. Is the concept
of cache metadata (separate from I/O priority in Linux) a thing?
If you can show examples from other storage protocols like NVMe or SCSI,
then that would help in designing a virtio-blk solution too.
Stefan
>
> Thank you,
> Dmitry
>
signature.asc
Description: PGP signature
it 95e1019a4a9), but also that the vhost back-end is connected
> (`hdev = k->get_vhost(); hdev != NULL && hdev->vhost_ops != NULL`).
>
> Signed-off-by: Hanna Czenczek
I think an additional SET_STATUS 0 call is made to the vDPA vhost
backend after this patch, but that seems fine.
ruster
Cc: Daniel P. Berrangé
Signed-off-by: Stefan Hajnoczi
---
system/qdev-monitor.c | 41 -
1 file changed, 28 insertions(+), 13 deletions(-)
diff --git a/system/qdev-monitor.c b/system/qdev-monitor.c
index 6af6ef7d66..1427aa173c 100644
--- a/system/qdev-mo
On Fri, Jul 05, 2024 at 06:56:04PM +0800, Changqi Lu wrote:
> Hi,
>
> Patch v7 has been modified.
> Thanks again to Stefan for reviewing the code.
>
> v6->v7:
> - Add buferlen size check at SCSI layer.
> - Add pr_cap calculation in bdrv_merge_limits() function at bloc
angqi Lu
> Signed-off-by: zhenwei pi
> ---
> include/block/nvme.h | 61
> 1 file changed, 61 insertions(+)
Reviewed-by: Stefan Hajnoczi
signature.asc
Description: PGP signature
On Fri, Jul 05, 2024 at 06:56:14PM +0800, Changqi Lu wrote:
> Add persistent reservation in/out operations for iscsi driver.
> The following methods are implemented: bdrv_co_pr_read_keys,
> bdrv_co_pr_read_reservation, bdrv_co_pr_register, bdrv_co_pr_reserve,
> bdrv_co_pr_release, bdrv_co_pr_clear
buf = scsi_req_get_buf(&r->req);
> +num_keys = MIN(blk_keys->num_keys, ret);
The behavior of scsi_disk_req_check_error() above is strange for
pr_read_keys operations. When --drive ...,rerror=ignore and ret < 0 this
line is reached and we don't want a negative num_keys value. It would be
safer to use (ret > 0 ? ret : 0) instead of the raw value of ret.
Stefan
signature.asc
Description: PGP signature
ed-off-by: Changqi Lu
> Signed-off-by: zhenwei pi
> ---
> hw/nvme/ctrl.c | 3 ++-
> hw/nvme/ns.c | 5 +
> include/block/nvme.h | 2 +-
> 3 files changed, 8 insertions(+), 2 deletions(-)
Reviewed-by: Stefan Hajnoczi
signature.asc
Description: PGP signature
On Thu, Jul 04, 2024 at 08:20:31PM +0200, Stefan Hajnoczi wrote:
> On Thu, Jun 13, 2024 at 03:13:25PM +0800, Changqi Lu wrote:
> > This commit enables ONCS to support the reservation
> > function at the controller level. Also enables rescap
> > function in the namespace by de
I will skip this since Klaus Jensen's review is required for NVMe anyway.
Stefan
signature.asc
Description: PGP signature
On Thu, Jun 13, 2024 at 03:13:27PM +0800, Changqi Lu wrote:
> Add persistent reservation in/out operations for iscsi driver.
> The following methods are implemented: bdrv_co_pr_read_keys,
> bdrv_co_pr_read_reservation, bdrv_co_pr_register, bdrv_co_pr_reserve,
> bdrv_co_pr_release, bdrv_co_pr_clear
On Thu, Jun 13, 2024 at 03:13:23PM +0800, Changqi Lu wrote:
> Add constants for the NVMe persistent command protocol.
> The constants include the reservation command opcode and
> reservation type values defined in section 7 of the NVMe
> 2.0 specification.
>
> Signed-off-by: Changqi Lu
> Signed-o
On Thu, Jun 13, 2024 at 03:13:25PM +0800, Changqi Lu wrote:
> This commit enables ONCS to support the reservation
> function at the controller level. Also enables rescap
> function in the namespace by detecting the supported reservation
> function in the backend driver.
>
> Signed-off-by: Changqi
On Thu, Jun 13, 2024 at 03:13:22PM +0800, Changqi Lu wrote:
> Add persistent reservation in/out operations in the
> SCSI device layer. By introducing the persistent
> reservation in/out api, this enables the SCSI device
> to perform reservation-related tasks, including querying
> keys, querying res
On Thu, Jun 13, 2024 at 03:13:22PM +0800, Changqi Lu wrote:
> Add persistent reservation in/out operations in the
> SCSI device layer. By introducing the persistent
> reservation in/out api, this enables the SCSI device
> to perform reservation-related tasks, including querying
> keys, querying res
u
> Signed-off-by: zhenwei pi
> ---
> include/scsi/utils.h | 8 +
> scsi/utils.c | 81
> 2 files changed, 89 insertions(+)
Reviewed-by: Stefan Hajnoczi
signature.asc
Description: PGP signature
i_proto.h
like the rest of the file, but it's okay because constants.h is not
kept in sync with the Linux headers.
Reviewed-by: Stefan Hajnoczi
signature.asc
Description: PGP signature
_co_pr_clear and bdrv_co_pr_preempt.
>
> Signed-off-by: Changqi Lu
> Signed-off-by: zhenwei pi
> ---
> block/raw-format.c | 56 ++
> 1 file changed, 56 insertions(+)
Reviewed-by: Stefan Hajnoczi
signature.asc
Description: PGP signature
| 40 +++
> include/block/block-io.h | 20 ++
> include/block/block_int-common.h | 84 +++
> include/sysemu/block-backend-io.h | 24 ++
> 6 files changed, 734 insertions(+)
Reviewed-by: Stefan Hajnoczi
signature.asc
Description: PGP signature
1 - 100 of 20204 matches
Mail list logo
