redhat.com/msg0.html
> [2]
> https://lore.kernel.org/linux-fsdevel/20221211103857.25805-1-zhangjiachen.jay...@bytedance.com/
> Suggested-by: Stefan Hajnoczi
> Cc: Connor Kuehl
> Signed-off-by: Jiachen Zhang
> ---
> tools/virtiofsd/fuse_lowlevel.c | 4 ++--
>
Reviewed-by: Stefan Hajnoczi
Reviewed-by: Stefan Hajnoczi
; include/block/aio_task.h | 2 --
> include/block/block-common.h | 1 -
> include/monitor/hmp.h| 1 -
> include/qemu/coroutine.h | 18 +++---
> include/qemu/osdep.h | 16
> 5 files changed, 23 insertions(+), 15 deletions(-)
Reviewed-by: Stefan Hajnoczi
Probably because block layer, aio.h, and coroutine_int.h header files
already include "qemu/coroutine.h"?
Reviewed-by: Stefan Hajnoczi
On Wed, 7 Dec 2022 at 14:11, Stefan Weil wrote:
>
> Am 07.12.22 um 19:22 schrieb Eric Auger:
> >
> > On 12/7/22 17:55, Philippe Mathieu-Daudé wrote:
> >> On 7/12/22 15:33, Eric Auger wrote:
> >>> On 12/7/22 15:09, Stefan Hajnoczi wrote:
> >>&
On Wed, 7 Dec 2022 at 09:34, Eric Auger wrote:
>
> Hi Stefan,
>
> On 12/7/22 15:09, Stefan Hajnoczi wrote:
> > On Wed, 7 Dec 2022 at 08:31, Eric Auger wrote:
> >> On 12/7/22 14:24, Eric Auger wrote:
> >>> Initialize r0-3 to avoid compilation errors when
&g
On Wed, 7 Dec 2022 at 08:31, Eric Auger wrote:
> On 12/7/22 14:24, Eric Auger wrote:
> > Initialize r0-3 to avoid compilation errors when
> > -Werror=maybe-uninitialized is used
> >
> > ../target/i386/ops_sse.h: In function ‘helper_vpermdq_ymm’:
> > ../target/i386/ops_sse.h:2495:13: error: ‘r3’ ma
On Mon, 21 Mar 2022 at 11:59, Alex Bennée wrote:
>
> At a couple of hundred bytes per notifier allocating one for every
> potential queue is very wasteful as most devices only have a few
> queues. Instead of having this handled statically dynamically assign
> them and track in a GPtrArray.
>
> [AJ
Applied, thanks.
Please update the changelog at https://wiki.qemu.org/ChangeLog/7.2 for any
user-visible changes.
signature.asc
Description: PGP signature
On Mon, Dec 05, 2022 at 09:24:28PM +0800, Sam Li wrote:
> Stefan Hajnoczi 于2022年12月5日周一 20:20写道：
> >
> > On Wed, Nov 30, 2022 at 10:24:10AM +0800, Sam Li wrote:
> > > Stefan Hajnoczi 于2022年11月30日周三 10:01写道：
> > > > On Thu, 27 Oct 2022 at 11:46, Sam Li
On Mon, 5 Dec 2022 at 06:38, gaos...@loongson.cn wrote:
>
>
> 在 2022/12/5 18:48, Peter Maydell 写道:
> > On Mon, 5 Dec 2022 at 09:20, gaos...@loongson.cn
> > wrote:
> >>
> >> 在 2022/12/5 15:24, Philippe Mathieu-Daudé 写道:
> >>> On 2/12/22 11:25, Song Gao wrote:
> The following changes since co
On Wed, Nov 30, 2022 at 10:24:10AM +0800, Sam Li wrote:
> Stefan Hajnoczi 于2022年11月30日周三 10:01写道：
> > On Thu, 27 Oct 2022 at 11:46, Sam Li wrote:
> > > @@ -1374,9 +1428,11 @@ static int hdev_probe_blocksizes(BlockDriverState
> > > *bs, BlockSizes *bsz)
> > >
Applied, thanks.
Please update the changelog at https://wiki.qemu.org/ChangeLog/7.2 for any
user-visible changes.
signature.asc
Description: PGP signature
Applied, thanks.
Please update the changelog at https://wiki.qemu.org/ChangeLog/7.2 for any
user-visible changes.
signature.asc
Description: PGP signature
Applied, thanks.
Please update the changelog at https://wiki.qemu.org/ChangeLog/7.2 for any
user-visible changes.
signature.asc
Description: PGP signature
Applied, thanks.
Please update the changelog at https://wiki.qemu.org/ChangeLog/7.2 for any
user-visible changes.
signature.asc
Description: PGP signature
Applied, thanks.
Please update the changelog at https://wiki.qemu.org/ChangeLog/7.2 for any
user-visible changes.
signature.asc
Description: PGP signature
On Thu, 1 Dec 2022 at 11:50, Klaus Jensen wrote:
>
> From: Klaus Jensen
>
> Hi,
>
> The following changes since commit c4ffd91aba1c3d878e99a3e7ba8aad4826728ece:
>
> Update VERSION for v7.2.0-rc3 (2022-11-29 18:15:26 -0500)
>
> are available in the Git repository at:
>
> git://git.infradead.or
On Wed, Nov 30, 2022 at 11:24:38AM +, Alex Bennée wrote:
> ..and use for both virtio-user-blk and virtio-user-gpio. This avoids
> the circular close by deferring shutdown due to disconnection until a
> later point.
I thought re-entrancy was already avoided by Patch 3?
> virtio-user-blk alread
On Fri, Nov 25, 2022 at 09:12:43AM +0100, Stefano Garzarella wrote:
> On Thu, Nov 24, 2022 at 01:36:29PM -0500, Stefan Hajnoczi wrote:
> > On Wed, Nov 23, 2022 at 02:16:30PM +0100, Stefano Garzarella wrote:
> > > Commit 02b61f38d3 ("hw/virtio: incorporate backe
Merged. I will work on supporting graph changes.
Stefan
Merged, thanks!
Stefan
On Mon, 28 Nov 2022 at 15:30, Philippe Mathieu-Daudé wrote:
>
> Since v2:
> - Do not abort checking guest-provided addresses (Stefan)
> - Handle chunked QEMUCursor (Gerd)
>
> Since v1:
> - Moved overrun check in qxl_get_check_slot_offset (Marc-André)
>
> memory_region_get_ram_ptr() returns a host
On Thu, 27 Oct 2022 at 11:46, Sam Li wrote:
> v13:
> - add some tracing points for new zone APIs [Dmitry]
> - change error handling in zone_mgmt [Damien, Stefan]
Hi Sam,
This looks very close! I sent comments.
Stefan
Reviewed-by: Stefan Hajnoczi
On Thu, 27 Oct 2022 at 11:48, Sam Li wrote:
>
> Signed-off-by: Sam Li
> ---
> block/file-posix.c | 3 +++
> block/trace-events | 2 ++
> 2 files changed, 5 insertions(+)
>
> diff --git a/block/file-posix.c b/block/file-posix.c
> index 02
On Thu, 27 Oct 2022 at 11:46, Sam Li wrote:
>
> Add a new zoned_host_device BlockDriver. The zoned_host_device option
> accepts only zoned host block devices. By adding zone management
> operations in this new BlockDriver, users can use the new block
> layer APIs including Report Zone and four zon
Hi,
The following cross-i386-tci migration-test failure was triggered by CI:
>>> MALLOC_PERTURB_=133
>>> G_TEST_DBUS_DAEMON=/builds/qemu-project/qemu/tests/dbus-vmstate-daemon.sh
>>> QTEST_QEMU_BINARY=./qemu-system-i386
>>> /builds/qemu-project/qemu/build/tests/qtest/migration-test --tap -k
―――
Hi Alex,
I'm waiting for a v4 or a confirmation that you've retested and I can
just drop this patch.
Thanks!
Stefan
Waiting for Evgeny's Signed-off-by. It seems a -rc4 tag will be
required anyway for vhost fixes so I'll wait.
Stefan
On Tue, 22 Nov 2022 at 03:22, Kevin Wolf wrote:
>
> Am 21.11.2022 um 22:19 hat Stefan Hajnoczi geschrieben:
> > bdrv_*() APIs expect a valid BlockDriverState. Calling them with bs=NULL
> > leads to undefined behavior.
> >
> > Jonathan Cameron reported this following
Applied, thanks.
Please update the changelog at https://wiki.qemu.org/ChangeLog/7.2 for any
user-visible changes.
signature.asc
Description: PGP signature
Merged, thanks!
Stefan
On Tue, 29 Nov 2022 at 02:39, Philippe Mathieu-Daudé wrote:
>
> On 29/11/22 02:05, Richard Henderson wrote:
> > Fixes the build with gcc 13:
> >
> > replay/replay-time.c:34:6: error: conflicting types for \
> >'replay_read_next_clock' due to enum/integer mismatch; \
> >have 'void(ReplayCl
To find out:
# perf record -e signal:signal_deliver
...wait for QEMU shutdown...
^C
# perf script
qemu-system-x86_64 2319136 [001] 1062886.415312:
signal:signal_deliver: sig=2 errno=0 code=128 sa_handler=7fc6ccfbabc0
sa_flags=1404
sig=2 is SIGINT. This is just an example, I didn't run virtiofs
Cool, thanks for writing up your zoned block emulation work!
Reviewed-by: Stefan Hajnoczi
On Mon, 28 Nov 2022 at 11:42, Alex Bennée wrote:
>
> There was a disconnect here because vdev->host_features was set to
> random rubbish. This caused a weird negotiation between the driver and
> device that took no account of the features provided by the backend.
> To fix this we must set vdev->ho
approach.
Reviewed-by: Stefan Hajnoczi
On Mon, 28 Nov 2022 at 04:28, Thomas Huth wrote:
>
> Our current release tarballs are huge and caused already some trouble
> with the server traffic in the past. However, the biggest chunk (~80%)
> of the tarball is caused by the firmware sources - which most users
> don't need anyway (assuming th
On Mon, 28 Nov 2022 at 10:46, Philippe Mathieu-Daudé wrote:
>
> On 28/11/22 16:32, Stefan Hajnoczi wrote:
> > On Mon, 28 Nov 2022 at 10:25, Philippe Mathieu-Daudé
> > wrote:
> >>
> >> On 28/11/22 16:16, Stefan Hajnoczi wrote:
> >>> On M
On Mon, 28 Nov 2022 at 10:25, Philippe Mathieu-Daudé wrote:
>
> On 28/11/22 16:16, Stefan Hajnoczi wrote:
> > On Mon, 28 Nov 2022 at 08:53, Philippe Mathieu-Daudé
> > wrote:
> >>
> >> Have qxl_get_check_slot_offset() return false if the requested
> >
On Mon, 28 Nov 2022 at 08:50, Philippe Mathieu-Daudé wrote:
>
> Since v1:
> - Addressed Marc-André review comments
> - Moved overrun check in qxl_get_check_slot_offset()
>
> memory_region_get_ram_ptr() returns a host pointer for a
> MemoryRegion. Sometimes we do offset calculation using this
> poi
On Mon, 28 Nov 2022 at 08:53, Philippe Mathieu-Daudé wrote:
>
> Have qxl_get_check_slot_offset() return false if the requested
> buffer size does not fit within the slot memory region.
>
> Similarly qxl_phys2virt() now returns NULL in such case, and
> qxl_dirty_one_surface() aborts.
>
> This avoid
Applied, thanks.
Please update the changelog at https://wiki.qemu.org/ChangeLog/7.2 for any
user-visible changes.
signature.asc
Description: PGP signature
On Mon, Nov 28, 2022, 05:29 Michael S. Tsirkin wrote:
> On Sat, Nov 26, 2022 at 04:25:01PM +0100, Stefan Weil wrote:
> > v3:
> > - Fix description for patch 3
> > - Add patches 5 and 6
> >
> > The patches 3 and 5 still need reviews!
>
> Series:
> Reviewed-by: Michael S. Tsirkin
>
> Stefan you sa
On Sun, 27 Nov 2022 at 13:09, Stefan Hajnoczi wrote:
>
> On Sat, 26 Nov 2022 at 10:25, Stefan Weil wrote:
> >
> > Signed-off-by: Stefan Weil
> > ---
> > MAINTAINERS | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/MAINTAINERS b/MAI
On Sun, 27 Nov 2022 at 13:31, Stefan Weil wrote:
>
> Am 27.11.22 um 19:23 schrieb Stefan Hajnoczi:
>
> We need to wait for Michael to agree to maintainership in patch 5. If
> we run out of time I suggest splitting out patch 5.
>
> Reviewed-by: Stefan Hajnoczi
>
>
>
We need to wait for Michael to agree to maintainership in patch 5. If
we run out of time I suggest splitting out patch 5.
Reviewed-by: Stefan Hajnoczi
On Sat, 26 Nov 2022 at 10:25, Stefan Weil wrote:
>
> Signed-off-by: Stefan Weil
> Reviewed-by: Marc-André Lureau
> Message-Id: <20220422070144.1043697-4...@weilnetz.de>
> Signed-off-by: Laurent Vivier
> ---
> subprojects/libvhost-user/libvhost-user.c | 13 -
> 1 file changed, 12 in
On Sat, 26 Nov 2022 at 10:25, Stefan Weil wrote:
>
> Signed-off-by: Stefan Weil
> ---
> MAINTAINERS | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/MAINTAINERS b/MAINTAINERS
> index cf24910249..6966490c94 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -2005,6 +2005,7 @@ F: docs/int
On Sat, 26 Nov 2022 at 10:25, Stefan Weil wrote:
>
> This fix is required for 32 bit hosts. The bug was detected by CI
> for arm-linux, but is also relevant for i386-linux.
>
> Reported-by: Stefan Hajnoczi
> Signed-off-by: Stefan Weil
> ---
> subprojects/libvhost-
On Sat, 26 Nov 2022 at 09:18, Alex Bennée wrote:
>
>
> Stefan Hajnoczi writes:
>
> > On Sat, 26 Nov 2022 at 04:45, Alex Bennée wrote:
> >>
> >>
> >> Alex Bennée writes:
> >>
> >> > Alex Bennée writes:
> >> >
>
On Sat, 26 Nov 2022 at 04:45, Alex Bennée wrote:
>
>
> Alex Bennée writes:
>
> > Alex Bennée writes:
> >
> >> Hi,
> >>
> >
> >> I can replicate some of the other failures I've been seeing in CI by
> >> running:
> >>
> >> ../../meson/meson.py test --repeat 10 --print-errorlogs
> >> qtest-arm/
Thanks, applied to qemu.git/master.
Stefan
On Wed, Nov 23, 2022 at 02:16:30PM +0100, Stefano Garzarella wrote:
> Commit 02b61f38d3 ("hw/virtio: incorporate backend features in features")
> properly negotiates VHOST_USER_F_PROTOCOL_FEATURES with the vhost-user
> backend, but we forgot to enable vrings as specified in
> docs/interop/vhost-use
On Thu, 24 Nov 2022 at 02:27, Gerd Hoffmann wrote:
>
> The following changes since commit 7c09a7f6ae1770d15535980d15dffdb23f4d9786:
>
> Update VERSION for v7.2.0-rc2 (2022-11-22 18:59:56 -0500)
>
> are available in the Git repository at:
>
> https://gitlab.com/kraxel/qemu.git tags/fixes-202211
Applied, thanks.
Please update the changelog at https://wiki.qemu.org/ChangeLog/7.2 for any
user-visible changes.
signature.asc
Description: PGP signature
Applied, thanks.
Please update the changelog at https://wiki.qemu.org/ChangeLog/7.2 for any
user-visible changes.
signature.asc
Description: PGP signature
Cool, thanks for posting an update.
An short introduction would be nice before diving into the details of ZBDs:
"This summer I worked on adding Zoned Block Device (ZBD) support to
virtio-blk as part of the https://www.outreachy.org/";>Outreachy internship program.
QEMU hasn't directly supported ZB
Applied, thanks.
Please update the changelog at https://wiki.qemu.org/ChangeLog/7.2 for any
user-visible changes.
signature.asc
Description: PGP signature
Applied, thanks.
Please update the changelog at https://wiki.qemu.org/ChangeLog/7.2 for any
user-visible changes.
signature.asc
Description: PGP signature
Applied, thanks.
Please update the changelog at https://wiki.qemu.org/ChangeLog/7.2 for any
user-visible changes.
signature.asc
Description: PGP signature
Applied, thanks.
Please update the changelog at https://wiki.qemu.org/ChangeLog/7.2 for any
user-visible changes.
signature.asc
Description: PGP signature
On Mon, 21 Nov 2022 at 14:25, Alex Bennée wrote:
> Stefan Hajnoczi writes:
>
> > On Mon, 21 Nov 2022 at 09:49, Alex Bennée wrote:
> >>
> >> We have a bunch of variables associated with the device and the vhost
> >> backend which are used inconsistently th
On Mon, 21 Nov 2022 at 16:11, Peter Maydell wrote:
>
> On Mon, 21 Nov 2022 at 15:54, Stefan Hajnoczi wrote:
> >
> > Applied, thanks.
>
> This doesn't seem to have reached https://gitlab.com/qemu-project/qemu.git:
> did something go wrong?
I forgot to push stagi
.
Fixes: baf422684d73 ("virtio-blk: use BDRV_REQ_REGISTERED_BUF optimization
hint")
Co-authored-by: Jonathan Cameron
Signed-off-by: Stefan Hajnoczi
---
block/block-backend.c | 15 +--
1 file changed, 13 insertions(+), 2 deletions(-)
diff --git a/block/block-backend.c b/block/blo
mu-project/qemu/-/jobs/3355901224
>
> tests/qtest/qom-test.c | 22 +++---
> 1 file changed, 19 insertions(+), 3 deletions(-)
Nice!
Reviewed-by: Stefan Hajnoczi
On Mon, 21 Nov 2022 at 12:29, Jonathan Cameron
wrote:
>
> On Mon, 21 Nov 2022 11:47:48 -0500
> Stefan Hajnoczi wrote:
>
> > On Mon, 21 Nov 2022 at 11:22, Jonathan Cameron via
> > wrote:
> > >
> > > First CC list is a guess as I haven't managed to
On Mon, 21 Nov 2022 at 11:22, Jonathan Cameron via
wrote:
>
> First CC list is a guess as I haven't managed to root cause where things are
> going wrong yet.
>
> Originally hit this whilst rebasing some CXL patches on v7.2.0-rc1.
> CXL makes extensive use of memory-backends and most my tests happe
si.c | 1 +
> hw/virtio/vhost-user-fs.c | 1 +
> hw/virtio/vhost-user-gpio.c| 1 +
> hw/virtio/vhost-user-i2c.c | 1 +
> hw/virtio/vhost-user-rng.c | 11 +--
> hw/virtio/vhost-vsock-common.c | 1 +
> net/vhost-vdpa.c | 1 +
> 10 files changed, 18 insertions(+), 2 deletions(-)
Reviewed-by: Stefan Hajnoczi
signature.asc
Description: PGP signature
On Thu, Nov 17, 2022 at 11:55:51AM -0500, Stefan Hajnoczi wrote:
> v3:
> - Add Patch 1 to avoid clobbering tx descriptor bits
> - Add Patch 2 to avoid confusing tx command modes
> - Exclude IP and TCP headers from large send MSS value
>
> The rtl8139 large send offload curren
Applied, thanks.
Please update the changelog at https://wiki.qemu.org/ChangeLog/7.2 for any
user-visible changes.
signature.asc
Description: PGP signature
Applied, thanks.
Please update the changelog at https://wiki.qemu.org/ChangeLog/7.2 for any
user-visible changes.
signature.asc
Description: PGP signature
Applied, thanks.
Please update the changelog at https://wiki.qemu.org/ChangeLog/7.2 for any
user-visible changes.
signature.asc
Description: PGP signature
_features. This is because the function's behavior changed over time.
Clean things up.
Stefan Hajnoczi (2):
virtio: document ->host_features usage in vdc->get_features() callback
virtio: remove unnecessary host_features in ->get_features()
include/hw/virtio/virtio.h | 7 +++
ns host_features. Make all devices
consistent by dropping the unnecessary code.
Cc: Cornelia Huck
Signed-off-by: Stefan Hajnoczi
---
hw/block/virtio-blk.c | 3 ---
hw/char/virtio-serial-bus.c | 1 -
hw/net/virtio-net.c | 3 ---
hw/scsi/vhost-scsi-common.c | 3 ---
hw/scsi/virtio-
Suggested-by: Cornelia Huck
Signed-off-by: Stefan Hajnoczi
---
include/hw/virtio/virtio.h | 7 +++
1 file changed, 7 insertions(+)
diff --git a/include/hw/virtio/virtio.h b/include/hw/virtio/virtio.h
index a973811cbf..b6e09c6d4b 100644
--- a/include/hw/virtio/virtio.h
+++ b/include/hw
ns host_features. Make all devices
consistent by dropping the unnecessary code.
Cc: Cornelia Huck
Signed-off-by: Stefan Hajnoczi
---
hw/block/virtio-blk.c | 3 ---
hw/char/virtio-serial-bus.c | 1 -
hw/net/virtio-net.c | 3 ---
hw/scsi/vhost-scsi-common.c | 3 ---
hw/scsi/virtio-
Suggested-by: Cornelia Huck
Signed-off-by: Stefan Hajnoczi
---
include/hw/virtio/virtio.h | 7 +++
1 file changed, 7 insertions(+)
diff --git a/include/hw/virtio/virtio.h b/include/hw/virtio/virtio.h
index a973811cbf..b6e09c6d4b 100644
--- a/include/hw/virtio/virtio.h
+++ b/include/hw
From: Vaibhav Jain
Kowshik reported that building qemu with GCC 12.2.1 for 'ppc64-softmmu'
target is failing due to following build warnings:
../target/ppc/cpu_init.c:7018:13: error: 'ppc_restore_state_to_opc' defined
but not used [-Werror=unused-function]
7018 | static void ppc_restore_stat
lean things up.
Stefan Hajnoczi (2):
virtio: document ->host_features usage in vdc->get_features() callback
virtio: remove unnecessary host_features in ->get_features()
Vaibhav Jain (1):
target/ppc: Fix build warnings when building with 'disable-tcg'
include/hw/virti
vho_backend_features = 0;
> ./hw/virtio/vhost-user.c:2083: dev->vho_backend_features |= 1ULL <<
> VHOST_USER_F_PROTOCOL_FEATURES;
> One use for saving the availability of a vhost-net feature and another
> for ensuring we add the protocol feature negotiation bit when q
Applied, thanks.
Please update the changelog at https://wiki.qemu.org/ChangeLog/7.2 for any
user-visible changes.
signature.asc
Description: PGP signature
Applied, thanks.
Please update the changelog at https://wiki.qemu.org/ChangeLog/7.2 for any
user-visible changes.
signature.asc
Description: PGP signature
On Sun, 20 Nov 2022 at 23:17, Jason Wang wrote:
>
> On Fri, Nov 18, 2022 at 12:56 AM Stefan Hajnoczi wrote:
> >
> > The device turns the Tx Descriptor into a Tx Status descriptor after
> > fully reading the descriptor. This involves clearing Tx Own (bit 31) to
> >
to 9.1ms for a VM with
> 64 vCPUs and 3 vDPA device(64vq per device).
>
> [1] https://www.mail-archive.com/qemu-devel@nongnu.org/msg921541.html
>
> Signed-off-by: Longpeng
> ---
> hw/virtio/vhost.c | 39 ++-
> 1 file changed, 38 inserti
On Thu, Nov 17, 2022, 15:42 Tobias Fiebig wrote:
> Heho,
> I gave v3 a shot and it performs as expected; For a requested MSS of 1320,
> TSO consistently uses a 1308 MSS. So for me, this patch works. Thanks for
> fixing this. :-)
>
> Sadly, I do not have boxes to test with .1q around; If none of y
Hi Sam,
Please send a git repo URL so Thomas can fetch the commit without
email/file size limitations.
> diff --git a/_posts/2022-11-17-zoned-emulation.md
> b/_posts/2022-11-17-zoned-emulation.md
> new file mode 100644
> index 000..69ce4d7
> --- /dev/null
> +++ b/_posts/2022-11-17-zoned-emula
On Thu, 17 Nov 2022 at 12:53, Russell King (Oracle)
wrote:
> Your subject says "for-7.2" - that's a while off yet! I guess you need
> to update it to "for-6.2" for the next posting of this series.
Sorry if this looked like a Linux patch series. This is a QEMU series
and the next release is 7.2.
in the past here:
https://lore.kernel.org/all/20161114162505.GD26664@stefanha-x1.localdomain/
Reported-by: Russell King - ARM Linux
Reported-by: Tobias Fiebig
Resolves: https://gitlab.com/qemu-project/qemu/-/issues/1312
Signed-off-by: Stefan Hajnoczi
---
hw/net/rtl8139.c | 26
Hi Tobias,
My initial patch was broken. I did some cleanup and sent a v3.
Stefan
variable for Tx Status and preserve Tx Descriptor
in txdw0.
Signed-off-by: Stefan Hajnoczi
---
hw/net/rtl8139.c | 17 ++---
1 file changed, 10 insertions(+), 7 deletions(-)
diff --git a/hw/net/rtl8139.c b/hw/net/rtl8139.c
index e6643e3c9d..ffef3789b5 100644
--- a/hw/net/rtl8139.c
'A' * 4096
s.send(buf)
The device sees a 4150 byte tx descriptor that results in the transmission of 3
Ethernet frames with sizes of 1514, 1514, and 1230 bytes when the large send
MSS value is 1460 bytes.
Stefan Hajnoczi (3):
rtl8139: avoid clobbering tx descriptor bits
rtl8139: ke
distinguish Tx command modes.
This avoids bugs where modes are confused. Note that I didn't find any
actual bugs aside from needlessly computing the IP checksum when the
Large Send bit is enabled.
Signed-off-by: Stefan Hajnoczi
---
hw/net/rtl8139.c | 4 ++--
1 file changed, 2 insertions(+), 2 dele
After looking more closely at txdw0 it seems that the code mixes "Tx
command mode 0", "Tx command mode 1", and "Tx status mode". The bits
have different meanings in each mode, so this leads to confusion :).
Stefan
On Wed, 16 Nov 2022 at 21:49, Tobias Fiebig wrote:
>
> Heho,
> Ok, I just learned more C than I ever wanted to. There is a bit more amiss
> here (ll from 7d7238c72b983cff5064734349d2d45be9c6282c):
>
> In line 1916 of rtl8139.c we set txdw0; If we calculate the MSS at this
> point, it is consiste
I have sent a v2 with a fixed MSS mask constant but haven't tested it.
Thanks,
Stefan
in the past here:
https://lore.kernel.org/all/20161114162505.GD26664@stefanha-x1.localdomain/
Reported-by: Russell King - ARM Linux
Reported-by: Tobias Fiebig
Resolves: https://gitlab.com/qemu-project/qemu/-/issues/1312
Signed-off-by: Stefan Hajnoczi
---
hw/net/rtl8139.c | 21
Applied, thanks.
Please update the changelog at https://wiki.qemu.org/ChangeLog/7.2 for any
user-visible changes.
signature.asc
Description: PGP signature
This pull request causes the following CI failure:
https://gitlab.com/qemu-project/qemu/-/jobs/3328449477
I haven't figured out the root cause of the failure. Maybe the pull
request just exposes a latent failure. Please take a look and we can
try again for -rc2.
Thanks,
Stefan
1901 - 2000 of 10478 matches
Mail list logo
