[PULL v2 2/8] hw/ufs: Support for Query Transfer Requests

2023-08-29 Thread Stefan Hajnoczi
From: Jeuk Kim This commit makes the UFS device support query and nop out transfer requests. The next patch would be support for UFS logical unit and scsi command transfer request. Signed-off-by: Jeuk Kim Reviewed-by: Stefan Hajnoczi Message-id

[PULL v2 4/8] tests/qtest: Introduce tests for UFS

2023-08-29 Thread Stefan Hajnoczi
From: Jeuk Kim This patch includes the following tests Test mmio read Test ufs device initialization and ufs-lu recognition Test I/O (Performs a write followed by a read to verify) Signed-off-by: Jeuk Kim Acked-by: Thomas Huth Reviewed-by: Stefan Hajnoczi Message-id

[PULL v2 6/8] block: add subcluster_size field to BlockDriverInfo

2023-08-29 Thread Stefan Hajnoczi
() implementation, we simply set it equal to the cluster size thus treating each cluster as having a single subcluster. Reviewed-by: Eric Blake Reviewed-by: Denis V. Lunev Signed-off-by: Andrey Drobyshev Reviewed-by: Vladimir Sementsov-Ogievskiy Signed-off-by: Stefan Hajnoczi Message-ID

[PULL v2 5/8] block-migration: Ensure we don't crash during migration cleanup

2023-08-29 Thread Stefan Hajnoczi
0) at ../block.c:7095 #2 0x55bbae13 in block_migration_cleanup_bmds () at ../migration/block.c:690 Signed-off-by: Fabiano Rosas Message-id: 20230731203338.27581-1-faro...@suse.de Signed-off-by: Stefan Hajnoczi --- migration/block.c | 11 +-- 1 file changed, 9 insertions(+), 2 deletions(

[PULL v2 0/8] Block patches

2023-08-29 Thread Stefan Hajnoczi
The following changes since commit 813bac3d8d70d85cb7835f7945eb9eed84c2d8d0: Merge tag '2023q3-bsd-user-pull-request' of https://gitlab.com/bsdimp/qemu into staging (2023-08-29 08:58:00 -0400) are available in the Git repository at: https://gitlab.com/stefanha/qemu.git

[PULL v2 3/8] hw/ufs: Support for UFS logical unit

2023-08-29 Thread Stefan Hajnoczi
From: Jeuk Kim This commit adds support for ufs logical unit. The LU handles processing for the SCSI command, unit descriptor query request. This commit enables the UFS device to process IO requests. Signed-off-by: Jeuk Kim Reviewed-by: Stefan Hajnoczi Message-id

[PATCH v2 4/4] io: follow coroutine AioContext in qio_channel_yield()

2023-08-29 Thread Stefan Hajnoczi
the iohandler AioHandler. Code that formerly called qio_channel_attach_aio_context() now calls qio_channel_set_follow_coroutine_ctx(ioc, true) once after the QIOChannel is created. Signed-off-by: Stefan Hajnoczi --- include/io/channel-util.h| 23 ++ include/io/channel.h

[PATCH v2 1/4] nbd: drop unused nbd_receive_negotiate() aio_context argument

2023-08-29 Thread Stefan Hajnoczi
aio_context is always NULL, so drop it. Suggested-by: Fabiano Rosas Signed-off-by: Stefan Hajnoczi --- include/block/nbd.h | 3 +-- nbd/client-connection.c | 3 +-- nbd/client.c| 5 ++--- qemu-nbd.c | 4 ++-- 4 files changed, 6 insertions(+), 9 deletions(-) diff

[PATCH v2 2/4] nbd: drop unused nbd_start_negotiate() aio_context argument

2023-08-29 Thread Stefan Hajnoczi
aio_context is always NULL, so drop it. Suggested-by: Fabiano Rosas Signed-off-by: Stefan Hajnoczi --- nbd/client.c | 11 +++ 1 file changed, 3 insertions(+), 8 deletions(-) diff --git a/nbd/client.c b/nbd/client.c index 16ec10c8a9..bd7e200136 100644 --- a/nbd/client.c +++ b/nbd

[PATCH v2 3/4] io: check there are no qio_channel_yield() coroutines during ->finalize()

2023-08-29 Thread Stefan Hajnoczi
Callers must clean up their coroutines before calling object_unref(OBJECT(ioc)) to prevent an fd handler leak. Add an assertion to check this. This patch is preparation for the fd handler changes that follow. Signed-off-by: Stefan Hajnoczi Reviewed-by: Daniel P. Berrangé Reviewed-by: Eric

[PATCH v2 0/4] io: follow coroutine AioContext in qio_channel_yield()

2023-08-29 Thread Stefan Hajnoczi
ltiple threads to process I/O in parallel. The nbd block driver is not compatible with the multi-queue block layer yet because QIOChannel cannot be used easily from coroutines running in multiple threads. This series changes the QIOChannel API to make that possible. Stefan Hajnoczi (4): nb

Re: [PULL 00/36] 2023q3 bsd user patches

2023-08-29 Thread Stefan Hajnoczi
Applied, thanks. In the future, please invoke git-request-pull(1) with the public HTTPS repo URL to make it easier for anyone to fetch the changes: > are available in the Git repository at: > > g...@gitlab.com:bsdimp/qemu.git tags/2023q3-bsd-user-pull-request ^^ Please update the

Re: [PULL 00/14] Python, i386 changes for 2023-08-28

2023-08-29 Thread Stefan Hajnoczi
Hi Paolo, I see a new test error that may have been introduced by this pull request: https://gitlab.com/qemu-project/qemu/-/jobs/4968468877#L131 AVOCADO Downloading avocado tests VM image for s390x Failed to load plugin from module "avocado.plugins.journal": ImportError("Module 'sqlite3' is not

Re: [PATCH v2 00/48] tcg patch queue

2023-08-28 Thread Stefan Hajnoczi
On Thu, 24 Aug 2023 at 14:29, Richard Henderson wrote: > > The following changes since commit 50e7a40af372ee5931c99ef7390f5d3d6fbf6ec4: > > Merge tag 'pull-target-arm-20230824' of > https://git.linaro.org/people/pmaydell/qemu-arm into staging (2023-08-24 > 10:08:33 -0400) > > are available in

Re: [PULL 0/5] Devel hppa priv cleanup2 patches

2023-08-28 Thread Stefan Hajnoczi
Applied, thanks. Please update the changelog at https://wiki.qemu.org/ChangeLog/8.2 for any user-visible changes. signature.asc Description: PGP signature

Re: [PULL 00/14] Python, i386 changes for 2023-08-28

2023-08-28 Thread Stefan Hajnoczi
Applied, thanks. Please update the changelog at https://wiki.qemu.org/ChangeLog/8.2 for any user-visible changes. signature.asc Description: PGP signature

Re: [PATCH v2 00/48] tcg patch queue

2023-08-28 Thread Stefan Hajnoczi
Applied, thanks. Please update the changelog at https://wiki.qemu.org/ChangeLog/8.2 for any user-visible changes. signature.asc Description: PGP signature

Re: [PULL 0/3] Dirty page rate and dirty page limit 20230828 patches

2023-08-28 Thread Stefan Hajnoczi
I see you sent a second pull request that includes the emails. Please send a v3 with a signed tag. Thanks! Stefan

Re: [PULL 0/3] Dirty page rate and dirty page limit 20230828 patches

2023-08-28 Thread Stefan Hajnoczi
On Mon, 28 Aug 2023 at 10:36, Hyman Huang wrote: > > From: Hyman > > The following changes since commit 50e7a40af372ee5931c99ef7390f5d3d6fbf6ec4: > > Merge tag 'pull-target-arm-20230824' of > https://git.linaro.org/people/pmaydell/qemu-arm into staging (2023-08-24 > 10:08:33 -0400) > > are

Re: [PATCH 2/2] io: follow coroutine AioContext in qio_channel_yield()

2023-08-24 Thread Stefan Hajnoczi
On Thu, Aug 24, 2023 at 12:26:05PM +0100, Daniel P. Berrangé wrote: > On Wed, Aug 23, 2023 at 07:45:04PM -0400, Stefan Hajnoczi wrote: > > The ongoing QEMU multi-queue block layer effort makes it possible for > > multiple > > threads to process I/O in parallel.

Re: [PATCH 2/2] io: follow coroutine AioContext in qio_channel_yield()

2023-08-24 Thread Stefan Hajnoczi
On Thu, Aug 24, 2023 at 01:09:59PM -0300, Fabiano Rosas wrote: > Stefan Hajnoczi writes: > > > @@ -2089,10 +2088,6 @@ static void nbd_attach_aio_context(BlockDriverState > > *bs, > > * the reconnect_delay_timer cannot be active here. > > */ > >

Re: [PATCH v2 0/3] block: align CoR requests to subclusters

2023-08-24 Thread Stefan Hajnoczi
On Thu, Aug 24, 2023 at 06:47:20PM +0300, Andrey Drobyshev wrote: > On 8/24/23 17:32, Stefan Hajnoczi wrote: > > On Wed, Aug 23, 2023 at 03:50:55PM +0300, Andrey Drobyshev wrote: > >> On 8/22/23 22:58, John Snow wrote: > >>> On Tue, Aug 22, 2023 at 1:33 PM

Re: [PATCH] hw/block/dataplane/virtio-block: Avoid dynamic stack allocation

2023-08-24 Thread Stefan Hajnoczi
/block/dataplane/virtio-blk.c | 11 --- > 1 file changed, 8 insertions(+), 3 deletions(-) Hi Peter, I recently sent a patch series that removes notify_guest_bh() completely: https://lore.kernel.org/qemu-devel/20230817155847.3605115-5-stefa...@redhat.com/ If it's urgent we can merge you

Re: [PATCH 2/2] io: follow coroutine AioContext in qio_channel_yield()

2023-08-24 Thread Stefan Hajnoczi
On Thu, Aug 24, 2023 at 12:26:05PM +0100, Daniel P. Berrangé wrote: > On Wed, Aug 23, 2023 at 07:45:04PM -0400, Stefan Hajnoczi wrote: > > The ongoing QEMU multi-queue block layer effort makes it possible for > > multiple > > threads to process I/O in parallel.

Re: [PATCH] aio-posix: zero out io_uring sqe user_data

2023-08-24 Thread Stefan Hajnoczi
On Wed, Apr 26, 2023 at 05:26:39PM -0400, Stefan Hajnoczi wrote: > liburing does not clear sqe->user_data. We must do it ourselves to avoid > undefined behavior in process_cqe() when user_data is used. > > Note that fdmon-io_uring is currently disabled, so this is a latent

[PULL 8/8] tests/qemu-iotests/197: add testcase for CoR with subclusters

2023-08-24 Thread Stefan Hajnoczi
-io: ../block/io.c:1236: bdrv_co_do_copy_on_readv: Assertion `skip_bytes < pnum' failed. Reviewed-by: Eric Blake Reviewed-by: Denis V. Lunev Signed-off-by: Andrey Drobyshev Reviewed-by: Vladimir Sementsov-Ogievskiy Signed-off-by: Stefan Hajnoczi Message-ID: <20230711172553.23

[PULL 5/8] block-migration: Ensure we don't crash during migration cleanup

2023-08-24 Thread Stefan Hajnoczi
0) at ../block.c:7095 #2 0x55bbae13 in block_migration_cleanup_bmds () at ../migration/block.c:690 Signed-off-by: Fabiano Rosas Message-id: 20230731203338.27581-1-faro...@suse.de Signed-off-by: Stefan Hajnoczi --- migration/block.c | 11 +-- 1 file changed, 9 insertions(+), 2 deletions(

[PULL 7/8] block/io: align requests to subcluster_size

2023-08-24 Thread Stefan Hajnoczi
_on_readv: Assertion `skip_bytes < pnum' failed. Reviewed-by: Eric Blake Reviewed-by: Denis V. Lunev Signed-off-by: Andrey Drobyshev Reviewed-by: Vladimir Sementsov-Ogievskiy Signed-off-by: Stefan Hajnoczi Message-ID: <20230711172553.234055-3-andrey.drobys...@virtuozzo.com> ---

[PULL 3/8] hw/ufs: Support for UFS logical unit

2023-08-24 Thread Stefan Hajnoczi
From: Jeuk Kim This commit adds support for ufs logical unit. The LU handles processing for the SCSI command, unit descriptor query request. This commit enables the UFS device to process IO requests. Signed-off-by: Jeuk Kim Reviewed-by: Stefan Hajnoczi Message-id

[PULL 6/8] block: add subcluster_size field to BlockDriverInfo

2023-08-24 Thread Stefan Hajnoczi
() implementation, we simply set it equal to the cluster size thus treating each cluster as having a single subcluster. Reviewed-by: Eric Blake Reviewed-by: Denis V. Lunev Signed-off-by: Andrey Drobyshev Reviewed-by: Vladimir Sementsov-Ogievskiy Signed-off-by: Stefan Hajnoczi Message-ID

[PULL 4/8] tests/qtest: Introduce tests for UFS

2023-08-24 Thread Stefan Hajnoczi
From: Jeuk Kim This patch includes the following tests Test mmio read Test ufs device initialization and ufs-lu recognition Test I/O (Performs a write followed by a read to verify) Signed-off-by: Jeuk Kim Acked-by: Thomas Huth Reviewed-by: Stefan Hajnoczi Message-id

[PULL 2/8] hw/ufs: Support for Query Transfer Requests

2023-08-24 Thread Stefan Hajnoczi
From: Jeuk Kim This commit makes the UFS device support query and nop out transfer requests. The next patch would be support for UFS logical unit and scsi command transfer request. Signed-off-by: Jeuk Kim Reviewed-by: Stefan Hajnoczi Message-id

[PULL 0/8] Block patches

2023-08-24 Thread Stefan Hajnoczi
The following changes since commit b0dd9a7d6dd15a6898e9c585b521e6bec79b25aa: Open 8.2 development tree (2023-08-22 07:14:07 -0700) are available in the Git repository at: https://gitlab.com/stefanha/qemu.git tags/block-pull-request for you to fetch changes up to

[PULL 1/8] hw/ufs: Initial commit for emulated Universal-Flash-Storage

2023-08-24 Thread Stefan Hajnoczi
to handle UFS logical unit and Transfer Request will follow. Signed-off-by: Jeuk Kim Reviewed-by: Stefan Hajnoczi Message-id: 9f3db32fe1c708090a6bb764d456973b5abef55f.1691062912.git.jeuk20@samsung.com Signed-off-by: Stefan Hajnoczi --- MAINTAINERS |6 + docs/specs/pci-ids.rst

Re: [PULL 00/35] target-arm queue

2023-08-24 Thread Stefan Hajnoczi
Applied, thanks. Please update the changelog at https://wiki.qemu.org/ChangeLog/8.2 for any user-visible changes. signature.asc Description: PGP signature

Re: [PULL 00/31] loongarch-to-apply queue

2023-08-24 Thread Stefan Hajnoczi
Applied, thanks. Please update the changelog at https://wiki.qemu.org/ChangeLog/8.2 for any user-visible changes. signature.asc Description: PGP signature

Re: [PULL 00/12] First batch of s390x patches for QEMU 8.2

2023-08-24 Thread Stefan Hajnoczi
On Thu, 24 Aug 2023 at 02:53, Thomas Huth wrote: > > On 23/08/2023 18.34, Stefan Hajnoczi wrote: > > On Wed, Aug 23, 2023 at 01:45:32PM +0200, Thomas Huth wrote: > >> The following changes since commit > >> b0dd9a7d6dd15a6898e9c585b521e6bec79b25aa: > >> >

Re: [PATCH] .gitlab-ci.d/cirrus.yml: Update FreeBSD to v13.2

2023-08-24 Thread Stefan Hajnoczi
Applied, thanks. Please update the changelog at https://wiki.qemu.org/ChangeLog/8.2 for any user-visible changes. signature.asc Description: PGP signature

Re: [PATCH v2 0/3] block: align CoR requests to subclusters

2023-08-24 Thread Stefan Hajnoczi
On Wed, Aug 23, 2023 at 03:50:55PM +0300, Andrey Drobyshev wrote: > On 8/22/23 22:58, John Snow wrote: > > On Tue, Aug 22, 2023 at 1:33 PM Andrey Drobyshev > > wrote: > >> > >> On 8/16/23 12:22, Andrey Drobyshev wrote: > >>> On 7/31/23 17:51, Andrey Drobyshev wrote: > On 7/24/23 16:11,

Re: [PULL 00/48] tcg patch queue

2023-08-24 Thread Stefan Hajnoczi
On Wed, 23 Aug 2023 at 16:24, Richard Henderson wrote: > > The following changes since commit b0dd9a7d6dd15a6898e9c585b521e6bec79b25aa: > > Open 8.2 development tree (2023-08-22 07:14:07 -0700) > > are available in the Git repository at: > > https://gitlab.com/rth7680/qemu.git

Re: [PATCH v2 1/4] softmmu: Support concurrent bounce buffers

2023-08-24 Thread Stefan Hajnoczi
On Wed, Aug 23, 2023 at 04:54:06PM -0400, Peter Xu wrote: > On Wed, Aug 23, 2023 at 10:08:08PM +0200, Mattias Nissler wrote: > > On Wed, Aug 23, 2023 at 7:35 PM Peter Xu wrote: > > > On Wed, Aug 23, 2023 at 02:29:02AM -0700, Mattias Nissler wrote: > > > > diff --git a/softmmu/vl.c b/softmmu/vl.c

Re: Starting the QEMU 8.2 release cycle

2023-08-24 Thread Stefan Hajnoczi
On Thu, 24 Aug 2023 at 05:25, Peter Maydell wrote: > > On Wed, 23 Aug 2023 at 12:23, Stefan Hajnoczi wrote: > > > > Hi, > > The QEMU 8.2 release cycle has begun. I am merging qemu.git pull > > requests for this release. You do not need to CC me on pull requests &g

[PATCH v2 1/4] block: remove AIOCBInfo->get_aio_context()

2023-08-23 Thread Stefan Hajnoczi
its blk_aio_cancel() caller, and poll the main loop AioContext. The purpose of this cleanup is to identify bdrv_aio_cancel() as an API that does not work with the multi-queue block layer. Signed-off-by: Stefan Hajnoczi --- include/block/aio.h| 1 - include/block/block-global

[PATCH v2 4/4] block-coroutine-wrapper: use qemu_get_current_aio_context()

2023-08-23 Thread Stefan Hajnoczi
is only called with the BQL held from the main loop thread. The output of qemu-iotests 051 is sensitive to event loop activity. Update the output because the monitor BH runs at a different time, causing prompts to be printed differently in the output. Signed-off-by: Stefan Hajnoczi --- scripts

[PATCH v2 0/4] block-backend: process I/O in the current AioContext

2023-08-23 Thread Stefan Hajnoczi
oop thread in addition to the IOThread: https://lore.kernel.org/qemu-devel/20230823234504.1387239-1-stefa...@redhat.com/T/#t Based-on: 20230823234504.1387239-1-stefa...@redhat.com Stefan Hajnoczi (4): block: remove AIOCBInfo->get_aio_context() block-backend: process I/O in the current AioC

[PATCH v2 3/4] block-backend: process zoned requests in the current AioContext

2023-08-23 Thread Stefan Hajnoczi
Process zoned requests in the current thread's AioContext instead of in the BlockBackend's AioContext. There is no need to use the BlockBackend's AioContext thanks to CoMutex bs->wps->colock, which protects zone metadata. Signed-off-by: Stefan Hajnoczi --- block/block-backend.

[PATCH v2 2/4] block-backend: process I/O in the current AioContext

2023-08-23 Thread Stefan Hajnoczi
accessed by the completion callback. - The remaining emulated devices and exports run with qemu_get_aio_context() == blk_get_aio_context(). Signed-off-by: Stefan Hajnoczi --- block/block-backend.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/block/block-backend.c b

[PATCH 2/2] io: follow coroutine AioContext in qio_channel_yield()

2023-08-23 Thread Stefan Hajnoczi
the iohandler AioHandler. Code that formerly called qio_channel_attach_aio_context() now calls qio_channel_set_follow_coroutine_ctx(ioc, true) once after the QIOChannel is created. Signed-off-by: Stefan Hajnoczi --- include/io/channel.h | 34 +++-- include/qemu/vhost-user-server.h

[PATCH 0/2] io: follow coroutine AioContext in qio_channel_yield()

2023-08-23 Thread Stefan Hajnoczi
the QIOChannel API to make that possible. Stefan Hajnoczi (2): io: check there are no qio_channel_yield() coroutines during ->finalize() io: follow coroutine AioContext in qio_channel_yield() include/io/channel.h | 34 - include/qemu/vhost-user-server.h | 1 + bl

[PATCH 1/2] io: check there are no qio_channel_yield() coroutines during ->finalize()

2023-08-23 Thread Stefan Hajnoczi
Callers must clean up their coroutines before calling object_unref(OBJECT(ioc)) to prevent an fd handler leak. Add an assertion to check this. This patch is preparation for the fd handler changes that follow. Signed-off-by: Stefan Hajnoczi --- io/channel.c | 4 1 file changed, 4

Re: [PULL 00/12] First batch of s390x patches for QEMU 8.2

2023-08-23 Thread Stefan Hajnoczi
On Wed, Aug 23, 2023 at 01:45:32PM +0200, Thomas Huth wrote: > The following changes since commit b0dd9a7d6dd15a6898e9c585b521e6bec79b25aa: > > Open 8.2 development tree (2023-08-22 07:14:07 -0700) > > are available in the Git repository at: > > https://gitlab.com/thuth/qemu.git

Re: NVMe ZNS last zone size

2023-08-23 Thread Stefan Hajnoczi
On Wed, 23 Aug 2023 at 14:53, Klaus Jensen wrote: > > On Aug 23 22:58, Sam Li wrote: > > Stefan Hajnoczi 于2023年8月23日周三 22:41写道: > > > > > > On Wed, 23 Aug 2023 at 10:24, Sam Li wrote: > > > > > > > > Hi Stefan, > > > > > >

Re: NVMe ZNS last zone size

2023-08-23 Thread Stefan Hajnoczi
On Wed, 23 Aug 2023 at 10:24, Sam Li wrote: > > Hi Stefan, > > Stefan Hajnoczi 于2023年8月23日周三 21:26写道: > > > > Hi Sam and Klaus, > > Val is adding nvme-io_uring ZNS support to libblkio > > (https://gitlab.com/libblkio/libblkio/-/merge_requests/221) and asked

NVMe ZNS last zone size

2023-08-23 Thread Stefan Hajnoczi
Hi Sam and Klaus, Val is adding nvme-io_uring ZNS support to libblkio (https://gitlab.com/libblkio/libblkio/-/merge_requests/221) and asked how to test the size of the last zone when the namespace's total size is not a multiple of the zone size. My understanding is that the zoned storage model

Re: [PULL 00/12] First batch of s390x patches for QEMU 8.2

2023-08-23 Thread Stefan Hajnoczi
Applied, thanks. Please update the changelog at https://wiki.qemu.org/ChangeLog/8.2 for any user-visible changes. signature.asc Description: PGP signature

Re: [PATCH v2] docs/about/license: Update LICENSE URL

2023-08-23 Thread Stefan Hajnoczi
On Tue, Aug 22, 2023 at 02:57:16PM +0200, Philippe Mathieu-Daudé wrote: > In early 2021 (see commit 2ad784339e "docs: update README to use > GitLab repo URLs") almost all of the code base was converted to > point to GitLab instead of git.qemu.org. During 2023, git.qemu.org > switched from a git

Starting the QEMU 8.2 release cycle

2023-08-23 Thread Stefan Hajnoczi
Hi, The QEMU 8.2 release cycle has begun. I am merging qemu.git pull requests for this release. You do not need to CC me on pull requests because I am monitoring qemu-devel. The proposed schedule is as follows: 2023-08-22 Beginning of development phase 2023-11-14 Soft feature freeze.

Re: [PATCH v2 4/4] iotests: test the zoned format feature for qcow2 file

2023-08-22 Thread Stefan Hajnoczi
zoned-qcow2.out | 140 +++ > 2 files changed, 275 insertions(+) > create mode 100755 tests/qemu-iotests/tests/zoned-qcow2 > create mode 100644 tests/qemu-iotests/tests/zoned-qcow2.out Reviewed-by: Stefan Hajnoczi signature.asc Description: PGP signature

Re: [PATCH v2 3/4] qcow2: add zoned emulation capability

2023-08-22 Thread Stefan Hajnoczi
On Mon, Aug 14, 2023 at 04:58:01PM +0800, Sam Li wrote: > By adding zone operations and zoned metadata, the zoned emulation > capability enables full emulation support of zoned device using > a qcow2 file. The zoned device metadata includes zone type, > zoned device state and write pointer of each

Re: [PATCH 21/21] block: Mark bdrv_add/del_child() and caller GRAPH_WRLOCK

2023-08-22 Thread Stefan Hajnoczi
nged, 27 insertions(+), 30 deletions(-) Reviewed-by: Stefan Hajnoczi signature.asc Description: PGP signature

Re: [PATCH 20/21] block: Mark bdrv_unref_child() GRAPH_WRLOCK

2023-08-22 Thread Stefan Hajnoczi
drv-drain.c | 8 ++-- > 10 files changed, 50 insertions(+), 8 deletions(-) Reviewed-by: Stefan Hajnoczi signature.asc Description: PGP signature

Re: [PATCH 19/21] block: Mark bdrv_root_unref_child() GRAPH_WRLOCK

2023-08-22 Thread Stefan Hajnoczi
| 2 ++ > 4 files changed, 9 insertions(+), 4 deletions(-) Reviewed-by: Stefan Hajnoczi signature.asc Description: PGP signature

Re: [PATCH 17/21] block: Take graph rdlock in bdrv_drop_intermediate()

2023-08-22 Thread Stefan Hajnoczi
On Thu, Aug 17, 2023 at 02:50:16PM +0200, Kevin Wolf wrote: > The function reads the parents list, so it needs to hold the graph lock. > > Signed-off-by: Kevin Wolf > --- > block.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/block.c b/block.c > index 7df8780d6e..a82389f742

Re: [PATCH 16/21] block: Mark bdrv_parent_cb_change_media() GRAPH_RDLOCK

2023-08-22 Thread Stefan Hajnoczi
On Thu, Aug 17, 2023 at 02:50:15PM +0200, Kevin Wolf wrote: > The function reads the parents list, so it needs to hold the graph lock. > > Signed-off-by: Kevin Wolf > --- > block.c | 6 +- > 1 file changed, 5 insertions(+), 1 deletion(-) Reviewed-by: Stefan Hajnocz

Re: [PATCH 15/21] block: Mark bdrv_child_perm() GRAPH_RDLOCK

2023-08-22 Thread Stefan Hajnoczi
bdrv_child_perm() conveniently already hold the lock. > > Signed-off-by: Kevin Wolf > --- > include/block/block_int-common.h | 10 +- > block.c | 11 ++- > block/copy-before-write.c| 10 +- > 3 files changed, 16 insertions(+),

Re: [PATCH 14/21] block: Mark bdrv_get_cumulative_perm() and callers GRAPH_RDLOCK

2023-08-22 Thread Stefan Hajnoczi
| 35 -- > blockdev.c | 6 + > 4 files changed, 40 insertions(+), 14 deletions(-) Reviewed-by: Stefan Hajnoczi signature.asc Description: PGP signature

Re: [PATCH v2 1/9] nvdimm: Reject writing label data to ROM instead of crashing QEMU

2023-08-22 Thread Stefan Hajnoczi
emory-backend-file, readonly=on > option") > Signed-off-by: David Hildenbrand > --- > hw/acpi/nvdimm.c| 11 ++++--- > hw/mem/nvdimm.c | 10 +++--- > hw/ppc/spapr_nvdimm.c | 3 ++- > include/hw/mem/nvdimm.h | 6 ++ > 4 files changed, 23 insertions(+), 7 deletions(-) Reviewed-by: Stefan Hajnoczi signature.asc Description: PGP signature

Re: [PATCH 13/21] block: Mark bdrv_parent_perms_conflict() and callers GRAPH_RDLOCK

2023-08-22 Thread Stefan Hajnoczi
| 6 +++-- > block/mirror.c | 8 ++ > block/vmdk.c| 2 ++ > tests/unit/test-bdrv-graph-mod.c| 4 +++ > 9 files changed, 66 insertions(+), 26 deletions(-) Reviewed-by: Stefan Hajnoczi signature.asc Description: PGP signature

Re: [PATCH 12/21] block: Mark bdrv_attach_child() GRAPH_WRLOCK

2023-08-22 Thread Stefan Hajnoczi
ck/replication.c| 6 ++ > tests/unit/test-bdrv-drain.c | 14 ++ > tests/unit/test-bdrv-graph-mod.c | 10 ++ > 6 files changed, 43 insertions(+), 10 deletions(-) Reviewed-by: Stefan Hajnoczi signature.asc Description: PGP signature

Re: [PATCH 11/21] block: Call transaction callbacks with lock held

2023-08-22 Thread Stefan Hajnoczi
+ > 1 file changed, 44 insertions(+), 17 deletions(-) Reviewed-by: Stefan Hajnoczi signature.asc Description: PGP signature

Re: [PATCH 10/21] block: Mark bdrv_attach_child_common() GRAPH_WRLOCK

2023-08-22 Thread Stefan Hajnoczi
ock/stream.c | 20 ++-- > 2 files changed, 100 insertions(+), 53 deletions(-) Reviewed-by: Stefan Hajnoczi signature.asc Description: PGP signature

Re: [PATCH 09/21] block: Mark bdrv_replace_child_tran() GRAPH_WRLOCK

2023-08-22 Thread Stefan Hajnoczi
e it changes, the transaction > callbacks can be changed, too. > > Signed-off-by: Kevin Wolf > --- > block.c | 78 - > 1 file changed, 50 insertions(+), 28 deletions(-) Reviewed-by: Stefan Hajnoczi signature.asc Description: PGP signature

Re: [PATCH 08/21] block: Mark bdrv_replace_child_noperm() GRAPH_WRLOCK

2023-08-22 Thread Stefan Hajnoczi
which means that they can't call functions that take it > internally. > > Signed-off-by: Kevin Wolf > --- > block.c | 26 +++--- > 1 file changed, 19 insertions(+), 7 deletions(-) Reviewed-by: Stefan Hajnoczi signature.asc Description: PGP signature

Re: [PATCH 07/21] block-coroutine-wrapper: Allow arbitrary parameter names

2023-08-22 Thread Stefan Hajnoczi
d, 4 insertions(+), 3 deletions(-) Reviewed-by: Stefan Hajnoczi signature.asc Description: PGP signature

Re: [PATCH 06/21] block-coroutine-wrapper: Add no_co_wrapper_bdrv_wrlock functions

2023-08-22 Thread Stefan Hajnoczi
utine-wrapper.py | 11 +++ > 2 files changed, 15 insertions(+) Reviewed-by: Stefan Hajnoczi signature.asc Description: PGP signature

Re: [PATCH 05/21] block: Introduce bdrv_schedule_unref()

2023-08-22 Thread Stefan Hajnoczi
On Thu, Aug 17, 2023 at 02:50:04PM +0200, Kevin Wolf wrote: > bdrv_unref() is called by a lot of places that need to hold the graph > lock (it naturally happens in the context of operations that change the > graph). However, bdrv_unref() takes the graph writer lock internally, so > it can't

Re: [PATCH 04/21] block: Take AioContext lock for bdrv_append() more consistently

2023-08-22 Thread Stefan Hajnoczi
rror_start() isn't mentioned in the commit description, but it calls bdrv_append() internally. Reviewed-by: Stefan Hajnoczi signature.asc Description: PGP signature

Re: [PATCH 03/21] preallocate: Don't poll during permission updates

2023-08-22 Thread Stefan Hajnoczi
+-- > 1 file changed, 69 insertions(+), 20 deletions(-) I don't know the permissions code well enough, but the patch matches the commit description: Acked-by: Stefan Hajnoczi signature.asc Description: PGP signature

Re: [PATCH 02/21] preallocate: Factor out preallocate_truncate_to_real_size()

2023-08-22 Thread Stefan Hajnoczi
preallocate.c | 48 + > 1 file changed, 22 insertions(+), 26 deletions(-) Reviewed-by: Stefan Hajnoczi signature.asc Description: PGP signature

Re: [PATCH 01/21] block: Remove unused BlockReopenQueueEntry.perms_checked

2023-08-22 Thread Stefan Hajnoczi
1 deletion(-) Reviewed-by: Stefan Hajnoczi signature.asc Description: PGP signature

Re: [PATCH 00/21] Graph locking part 4 (node management)

2023-08-22 Thread Stefan Hajnoczi
On Thu, Aug 17, 2023 at 02:49:59PM +0200, Kevin Wolf wrote: > The previous parts of the graph locking changes focussed mostly on the > BlockDriver side and taking reader locks while performing I/O. This > series focusses more on the functions managing the graph structure, i.e > adding, removing

Re: [RFC PATCH] docs/style: permit inline loop variables

2023-08-22 Thread Stefan Hajnoczi
> > Signed-off-by: Alex Bennée > --- > docs/devel/style.rst | 9 - > 1 file changed, 8 insertions(+), 1 deletion(-) Reviewed-by: Stefan Hajnoczi > > diff --git a/docs/devel/style.rst b/docs/devel/style.rst > index 3cfcdeb9cd..2f68b50079 100644 > --- a/docs/de

Re: [virtio-comment] virtio queue numbering and optional queues

2023-08-22 Thread Stefan Hajnoczi
On Mon, Aug 21, 2023 at 03:18:50PM -0700, Daniel Verkamp wrote: > Hello virtio folks, Hi Daniel, I have CCed those involved in the free page hint and page reporting features. Stefan > > I noticed a mismatch between the way the specification defines > device-specific virtqueue indexes and the

Re: [PATCH v2] docs/about/license: Update LICENSE URL

2023-08-22 Thread Stefan Hajnoczi
skdarseu7dyo...@mail.gmail.com/ > [2] https://git-scm.com/docs/gitweb#Documentation/gitweb.txt-blobplain > > Reviewed-by: Daniel P. Berrangé > Signed-off-by: Philippe Mathieu-Daudé > --- > v2: Drop '_type=heads' (danpb) > --- > docs/about/license.rst | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Stefan Hajnoczi

Re: [PATCH] docs/about/license: Update LICENSE URL

2023-08-22 Thread Stefan Hajnoczi
t; --- > docs/about/license.rst | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Stefan Hajnoczi

Re: [PATCH 0/2] block-backend: process I/O in the current AioContext

2023-08-21 Thread Stefan Hajnoczi
On Fri, Aug 18, 2023 at 05:24:22PM +0200, Kevin Wolf wrote: > Am 15.08.2023 um 18:05 hat Stefan Hajnoczi geschrieben: > > Switch blk_aio_*() APIs over to multi-queue by using > > qemu_get_current_aio_context() instead of blk_get_aio_context(). This change > > will allow d

Re: [PATCH v2 2/4] qcow2: add configurations for zoned format extension

2023-08-21 Thread Stefan Hajnoczi
On Mon, Aug 14, 2023 at 04:58:00PM +0800, Sam Li wrote: > diff --git a/block/qcow2.h b/block/qcow2.h > index f789ce3ae0..3694c8d217 100644 > --- a/block/qcow2.h > +++ b/block/qcow2.h > @@ -236,6 +236,20 @@ typedef struct Qcow2CryptoHeaderExtension { > uint64_t length; > } QEMU_PACKED

[PATCH v2 1/4] block: rename blk_io_plug_call() API to defer_call()

2023-08-17 Thread Stefan Hajnoczi
-by: Stefan Hajnoczi --- include/sysemu/block-backend-io.h | 6 +- block/blkio.c | 8 +-- block/io_uring.c | 4 +- block/linux-aio.c | 4 +- block/nvme.c | 4 +- block/plug.c | 109

[PATCH v2 4/4] virtio-blk: remove batch notification BH

2023-08-17 Thread Stefan Hajnoczi
. Modern drivers enable EVENT_IDX. Signed-off-by: Stefan Hajnoczi --- hw/block/dataplane/virtio-blk.c | 48 + 1 file changed, 1 insertion(+), 47 deletions(-) diff --git a/hw/block/dataplane/virtio-blk.c b/hw/block/dataplane/virtio-blk.c index da36fcfd0b..f83bb0f116

[PATCH v2 2/4] util/defer-call: move defer_call() to util/

2023-08-17 Thread Stefan Hajnoczi
c, my_obj); <-- another ... defer_call_end(); <-- end of section, my_func(my_obj) is called once Suggested-by: Ilya Maximets Signed-off-by: Stefan Hajnoczi --- MAINTAINERS | 3 ++- include/qemu/defer-call.h | 15 +++ include/sysemu/block-backend-io.h |

[PATCH v2 0/4] virtio-blk: use blk_io_plug_call() instead of notification BH

2023-08-17 Thread Stefan Hajnoczi
layer configuration) compared to no completion batching. iodepth=1 decreases by ~1% but this could be noise. Benchmark details are available here: https://gitlab.com/stefanha/virt-playbooks/-/tree/blk_io_plug-irqfd Stefan Hajnoczi (4): block: rename blk_io_plug_call() API to defer_call() util

[PATCH v2 3/4] virtio: use defer_call() in virtio_irqfd_notify()

2023-08-17 Thread Stefan Hajnoczi
-playbooks/-/tree/blk_io_plug-irqfd This duplicates the BH that virtio-blk uses for batching. The next commit will remove it. Signed-off-by: Stefan Hajnoczi --- block/io_uring.c | 6 ++ block/linux-aio.c | 4 hw/virtio/virtio.c | 11 ++- util/thread-pool.c | 5 + 4 files

Re: [PATCH v1 1/3] softmmu/physmem: fallback to opening guest RAM file as readonly in a MAP_PRIVATE mapping

2023-08-17 Thread Stefan Hajnoczi
, what if someone would > specify: > > -object memory-backend-file,readonly=on > > (because the default is share=off ...) and using it for a R/O NVDIMM, > where we expect any write access to fail. > > > But let's look at the commit that added the "readonly" parameter:

Re: [PATCH 1/2] virtio: use blk_io_plug_call() in virtio_irqfd_notify()

2023-08-16 Thread Stefan Hajnoczi
On Wed, Aug 16, 2023 at 08:30:58PM +0200, Ilya Maximets wrote: > On 8/16/23 17:30, Stefan Hajnoczi wrote: > > On Wed, Aug 16, 2023 at 03:36:32PM +0200, Ilya Maximets wrote: > >> On 8/15/23 14:08, Stefan Hajnoczi wrote: > >>> virtio-blk and virtio-scsi invoke virt

Re: [PATCH v2 3/4] qcow2: add zoned emulation capability

2023-08-16 Thread Stefan Hajnoczi
On Mon, Aug 14, 2023 at 04:58:01PM +0800, Sam Li wrote: > By adding zone operations and zoned metadata, the zoned emulation > capability enables full emulation support of zoned device using > a qcow2 file. The zoned device metadata includes zone type, > zoned device state and write pointer of each

Re: [PATCH v2 2/4] qcow2: add configurations for zoned format extension

2023-08-16 Thread Stefan Hajnoczi
On Mon, Aug 14, 2023 at 04:58:00PM +0800, Sam Li wrote: > To configure the zoned format feature on the qcow2 driver, it > requires following arguments: the device size, zoned profile, > zoned model, zone size, zone capacity, number of conventional > zones, limits on zone resources (max append

Re: [PATCH v2 0/4] Add full zoned storage emulation to qcow2 driver

2023-08-16 Thread Stefan Hajnoczi
On Wed, Aug 16, 2023 at 04:14:08PM +0800, Sam Li wrote: > Klaus Jensen 于2023年8月16日周三 15:37写道: > > > > On Aug 14 16:57, Sam Li wrote: > > > This patch series add a new extension - zoned format - to the > > > qcow2 driver thereby allowing full zoned storage emulation on > > > the qcow2 img file.

Re: [PATCH 1/2] virtio: use blk_io_plug_call() in virtio_irqfd_notify()

2023-08-16 Thread Stefan Hajnoczi
On Wed, Aug 16, 2023 at 03:36:32PM +0200, Ilya Maximets wrote: > On 8/15/23 14:08, Stefan Hajnoczi wrote: > > virtio-blk and virtio-scsi invoke virtio_irqfd_notify() to send Used > > Buffer Notifications from an IOThread. This involves an eventfd > > write(2) syscall. Calling

Re: [PATCH v2 0/3] block: align CoR requests to subclusters

2023-08-16 Thread Stefan Hajnoczi
> 8 files changed, 99 insertions(+), 33 deletions(-) > > -- > 2.39.3 > > Reviewed-by: Stefan Hajnoczi signature.asc Description: PGP signature

[PATCH 0/2] block-backend: process I/O in the current AioContext

2023-08-15 Thread Stefan Hajnoczi
Switch blk_aio_*() APIs over to multi-queue by using qemu_get_current_aio_context() instead of blk_get_aio_context(). This change will allow devices to process I/O in multiple IOThreads in the future. Stefan Hajnoczi (2): block-backend: process I/O in the current AioContext block-backend

<    5   6   7   8   9   10   11   12   13   14   >