Re: [PATCH 4/8] tests/unit/test-smp-parse: Use default parameters=0 when not set in -smp

2024-06-12 Thread Thomas Huth
-smp-parse.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) Reviewed-by: Thomas Huth

Re: [PATCH 3/8] tests/unit/test-smp-parse: Fix an invalid topology case

2024-06-12 Thread Thomas Huth
On 29/05/2024 08.19, Zhao Liu wrote: Adjust the "cpus" parameter to match the comment configuration. Signed-off-by: Zhao Liu --- tests/unit/test-smp-parse.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Thomas Huth

Re: [PATCH 2/8] tests/unit/test-smp-parse: Fix comment of parameters=1 case

2024-06-12 Thread Thomas Huth
arse.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) Reviewed-by: Thomas Huth

Re: [PATCH 1/8] tests/unit/test-smp-parse: Fix comments of drawers and books case

2024-06-12 Thread Thomas Huth
On 29/05/2024 08.19, Zhao Liu wrote: Fix the comments to match the actual configurations. Signed-off-by: Zhao Liu --- tests/unit/test-smp-parse.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) Reviewed-by: Thomas Huth

Re: [PATCH 0/5] s390x: Add Full Boot Order Support

2024-06-07 Thread Thomas Huth
On 06/06/2024 21.22, Jared Rossi wrote: On 6/5/24 4:02 AM, Thomas Huth wrote: On 29/05/2024 17.43, jro...@linux.ibm.com wrote: From: Jared Rossi This patch set primarily adds support for the specification of multiple boot devices, allowing for the guest to automatically use an alternative

Re: [PATCH 3/5] s390x: Build IPLB chain for multiple boot devices

2024-06-07 Thread Thomas Huth
On 05/06/2024 22.01, Jared Rossi wrote: On 6/4/24 2:26 PM, Thomas Huth wrote: On 29/05/2024 17.43, jro...@linux.ibm.com wrote: From: Jared Rossi Write a chain of IPLBs into memory for future use. The IPLB chain is placed immediately before the BIOS in memory at the highest unused page

Re: [PATCH 5/5] s390x: Enable and document boot device fallback on panic

2024-06-06 Thread Thomas Huth
On 05/06/2024 16.48, Jared Rossi wrote: diff --git a/pc-bios/s390-ccw/s390-ccw.h b/pc-bios/s390-ccw/s390-ccw.h index c977a52b50..de3d1f0d5a 100644 --- a/pc-bios/s390-ccw/s390-ccw.h +++ b/pc-bios/s390-ccw/s390-ccw.h @@ -43,6 +43,7 @@ typedef unsigned long long u64;   #include "iplb.h"     /*

Re: [PATCH 5/5] s390x: Enable and document boot device fallback on panic

2024-06-05 Thread Thomas Huth
On 29/05/2024 17.43, jro...@linux.ibm.com wrote: From: Jared Rossi On a panic during IPL (i.e. a device failed to boot) check for another device to boot from, as indicated by the presence of an unused IPLB. If an IPLB is successfully loaded, then jump to the start of BIOS, restarting IPL

Re: [PATCH 4/5] s390x: Add boot device fallback infrastructure

2024-06-05 Thread Thomas Huth
On 05/06/2024 10.20, Thomas Huth wrote: On 29/05/2024 17.43, jro...@linux.ibm.com wrote: From: Jared Rossi Add a routine for loading the next IPLB if a device fails to boot. This includes some minor changes to the List-Directed IPL routine so that the failing device may be retried using

Re: [PATCH 4/5] s390x: Add boot device fallback infrastructure

2024-06-05 Thread Thomas Huth
On 29/05/2024 17.43, jro...@linux.ibm.com wrote: From: Jared Rossi Add a routine for loading the next IPLB if a device fails to boot. This includes some minor changes to the List-Directed IPL routine so that the failing device may be retried using the legacy boot pointers before moving on to

Re: [PATCH 0/5] s390x: Add Full Boot Order Support

2024-06-05 Thread Thomas Huth
On 29/05/2024 17.43, jro...@linux.ibm.com wrote: From: Jared Rossi This patch set primarily adds support for the specification of multiple boot devices, allowing for the guest to automatically use an alternative device on a failed boot without needing to be reconfigured. It additionally

Re: [PATCH 2/5] s390x: Add loadparm to CcwDevice

2024-06-05 Thread Thomas Huth
On 29/05/2024 17.43, jro...@linux.ibm.com wrote: From: Jared Rossi Add a loadparm property to the CcwDevice object so that different loadparms can be defined on a per-device basis when using multiple boot devices. The machine/global loadparm is still supported. If both a global and per-device

Re: [PATCH 0/5] s390x: Add Full Boot Order Support

2024-06-04 Thread Thomas Huth
On 29/05/2024 17.43, jro...@linux.ibm.com wrote: From: Jared Rossi This patch set primarily adds support for the specification of multiple boot devices, allowing for the guest to automatically use an alternative device on a failed boot without needing to be reconfigured. It additionally

Re: [PATCH 3/5] s390x: Build IPLB chain for multiple boot devices

2024-06-04 Thread Thomas Huth
On 29/05/2024 17.43, jro...@linux.ibm.com wrote: From: Jared Rossi Write a chain of IPLBs into memory for future use. The IPLB chain is placed immediately before the BIOS in memory at the highest unused page boundary providing sufficient space to fit the chain. Because this is not a fixed

Re: [PATCH 2/5] s390x: Add loadparm to CcwDevice

2024-06-04 Thread Thomas Huth
On 04/06/2024 18.27, Jared Rossi wrote: Hi Thomas, Firstly, thanks for the reviews and I agree with your suggestions about function names, info messages, simplifications, etc...  I will make those changes. As for the DIAG308_FLAGS_LP_VALID flag... [snip...] @@ -438,40 +473,20 @@ static

Re: [PATCH 2/5] s390x: Add loadparm to CcwDevice

2024-06-04 Thread Thomas Huth
On 29/05/2024 17.43, jro...@linux.ibm.com wrote: From: Jared Rossi Add a loadparm property to the CcwDevice object so that different loadparms can be defined on a per-device basis when using multiple boot devices. The machine/global loadparm is still supported. If both a global and per-device

Re: [PATCH] qtest/x86/numa-test: do not use the obsolete 'pentium' cpu

2024-06-04 Thread Thomas Huth
v=ram -numa node,nodeid=1 " "-numa cpu,node-id=1,socket-id=0 " "-numa cpu,node-id=0,socket-id=1,core-id=0 " Reviewed-by: Thomas Huth

Re: [PATCH 3/5] s390x: Build IPLB chain for multiple boot devices

2024-06-03 Thread Thomas Huth
On 29/05/2024 17.43, jro...@linux.ibm.com wrote: From: Jared Rossi Write a chain of IPLBs into memory for future use. The IPLB chain is placed immediately before the BIOS in memory at the highest unused page boundary providing sufficient space to fit the chain. Because this is not a fixed

Re: [PATCH 1/5] s390x: Create include files for s390x IPL definitions

2024-06-03 Thread Thomas Huth
Hi Jared! On 29/05/2024 17.43, jro...@linux.ibm.com wrote: From: Jared Rossi Currently, stuctures defined in both hw/s390x/ipl.h and pc-bios/s390-ccw/iplb.h Typo: s/stuctures/structures/ must be kept in sync, which is prone to error. Instead, create a new directory at

Re: [PATCH] io/channel-socket: Fix -fsanitize=undefined problem with latest Clang

2024-06-03 Thread Thomas Huth
On 03/06/2024 17.52, Daniel P. Berrangé wrote: On Mon, Jun 03, 2024 at 04:12:34PM +0100, Peter Maydell wrote: On Mon, 3 Jun 2024 at 15:58, Peter Maydell wrote: On Mon, 3 Jun 2024 at 15:49, Daniel P. Berrangé wrote: We can't rely on the sanitizers to catch all cases where we're casting

Re: [PATCH 4/4] update-linux-headers: import linux/kvm_para.h header

2024-06-03 Thread Thomas Huth
tions(+), 1 deletion(-) create mode 100644 include/standard-headers/linux/kvm_para.h create mode 100644 linux-headers/asm-x86/kvm_para.h create mode 100644 linux-headers/linux/kvm_para.h Reviewed-by: Thomas Huth

Re: [PATCH 2/4] update-linux-headers: move pvpanic.h to correct directory

2024-06-03 Thread Thomas Huth
viewed-by: Thomas Huth

Re: [PATCH 1/4] update-linux-headers: fix forwarding to asm-generic headers

2024-06-03 Thread Thomas Huth
$hdrdir/include/asm-generic/$header"; then +# not installed as , but used as such in kernel sources Maybe change the comment to talk about instead of ? +cat <$output/linux-headers/asm-$arch/$header +#include +EOF +fi done if [ $arch = mips ]; then Reviewed-by: Thomas Huth

Re: [PATCH] io/channel-socket: Fix -fsanitize=undefined problem with latest Clang

2024-06-03 Thread Thomas Huth
On 03/06/2024 14.48, Daniel P. Berrangé wrote: On Wed, May 29, 2024 at 02:53:37PM +0100, Peter Maydell wrote: On Wed, 29 May 2024 at 14:32, Thomas Huth wrote: Casting function pointers from one type to another causes undefined behavior errors when compiling with -fsanitize=undefined

Re: [PATCH] target/i386: fix xsave.flat from kvm-unit-tests

2024-06-03 Thread Thomas Huth
92544317fe ("target/i386: implement XSAVE and XRSTOR of AVX registers", 2022-10-18) Reported-by: Thomas Huth Signed-off-by: Paolo Bonzini --- target/i386/tcg/fpu_helper.c | 5 + 1 file changed, 5 insertions(+) diff --git a/target/i386/tcg/fpu_helper.c b/target/i386/tcg/fpu_helper

[PATCH 4/5] tests/lcitool: Install mingw-w64-tools for the Windows cross-builds

2024-06-01 Thread Thomas Huth
Beside g++ we also need the mingw-w64-tools for properly building the code in qga/vss-win32/ , so let's install that package now, too. Signed-off-by: Thomas Huth --- tests/lcitool/projects/qemu-win-installer.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/lcitool/projects/qemu-win

[PATCH 5/5] tests/docker/dockerfiles: Run lcitool-refresh to update Fedora and Alpine

2024-06-01 Thread Thomas Huth
Run "make lcitool-refresh" to update the dockerfiles with the recent changes to the lcitool. Signed-off-by: Thomas Huth --- tests/docker/dockerfiles/alpine.docker | 4 ++-- tests/docker/dockerfiles/fedora-win64-cross.docker | 6 -- tests/docker/dockerfiles/fed

[PATCH 0/5] tests: Update Fedora and Alpine containers via lcitool

2024-06-01 Thread Thomas Huth
of Clang that we use in the "clang-system" Fedora container: We now need to compile with -fno-sanitize=function there until all spots in the source code have been fixed (and that might take while since many of the issues are not trivial). Thomas Huth (5): tests/lcitool: Delete obs

[PATCH 2/5] tests/lcitool: Bump to latest libvirt-ci and update Fedora and Alpine version

2024-06-01 Thread Thomas Huth
hat we can use until somebody updates our Avocado to a newer version. Signed-off-by: Thomas Huth --- tests/lcitool/libvirt-ci| 2 +- tests/lcitool/projects/qemu.yml | 1 + tests/lcitool/refresh | 6 +++--- 3 files changed, 5 insertions(+), 4 deletions(-) diff --git a/tes

[PATCH 1/5] tests/lcitool: Delete obsolete centos-stream-8.yml file

2024-06-01 Thread Thomas Huth
We've missed to delete this file when removing support for CentOS 8. Since the current upstream version of the lcitool removed support for CentOS 8 now, too, we have to remove the file before updating. Signed-off-by: Thomas Huth --- tests/lcitool/targets/centos-stream-8.yml | 3 --- 1 file

[PATCH 3/5] .gitlab-ci.d/buildtest.yml: Use -fno-sanitize=function in the clang-system job

2024-06-01 Thread Thomas Huth
in the failing clang-system job until all spots in the QEMU sources have been tackled. Signed-off-by: Thomas Huth --- .gitlab-ci.d/buildtest.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.gitlab-ci.d/buildtest.yml b/.gitlab-ci.d/buildtest.yml index 91c57efded..0eec570310 100644 --- a/.gitlab-ci.d

Re: [PATCH 0/4] hw/s390x: Alias @dump-skeys -> @dump-s390-skey and deprecate

2024-05-31 Thread Thomas Huth
On 31/05/2024 16.02, Dr. David Alan Gilbert wrote: * Thomas Huth (th...@redhat.com) wrote: On 30/05/2024 09.45, Philippe Mathieu-Daudé wrote: We are trying to unify all qemu-system-FOO to a single binary. In order to do that we need to remove QAPI target specific code. @dump-skeys is only

Re: [PATCH] Use "void *" as parameter for functions that are used for aio_set_event_notifier()

2024-05-30 Thread Thomas Huth
On 29/05/2024 20.22, Stefan Hajnoczi wrote: On Wed, May 29, 2024 at 07:49:48PM +0200, Thomas Huth wrote: aio_set_event_notifier() and aio_set_event_notifier_poll() in util/aio-posix.c and util/aio-win32.c are casting function pointers of functions that take an "EventNotifier *&quo

Re: [PATCH V2 1/3] vl: Allow multiple -overcommit commands

2024-05-30 Thread Thomas Huth
On 30/05/2024 16.01, Zhao Liu wrote: On Mon, May 27, 2024 at 07:19:56AM +0200, Thomas Huth wrote: Date: Mon, 27 May 2024 07:19:56 +0200 From: Thomas Huth Subject: Re: [PATCH V2 1/3] vl: Allow multiple -overcommit commands On 24/05/2024 22.00, Zide Chen wrote: Both cpu-pm and mem-lock

Re: [PATCH 4/4] hw/s390x: Deprecate the QMP @dump-skeys command

2024-05-30 Thread Thomas Huth
On 30/05/2024 09.45, Philippe Mathieu-Daudé wrote: Prefer @dump-s390-skeys which is target agnostic. Signed-off-by: Philippe Mathieu-Daudé --- docs/about/deprecated.rst | 5 + qapi/misc-target.json | 5 + 2 files changed, 10 insertions(+) diff --git a/docs/about/deprecated.rst

Re: [PATCH 0/4] hw/s390x: Alias @dump-skeys -> @dump-s390-skey and deprecate

2024-05-30 Thread Thomas Huth
On 30/05/2024 09.45, Philippe Mathieu-Daudé wrote: We are trying to unify all qemu-system-FOO to a single binary. In order to do that we need to remove QAPI target specific code. @dump-skeys is only available on qemu-system-s390x. This series rename it as @dump-s390-skey, making it available on

[PATCH] Use "void *" as parameter for functions that are used for aio_set_event_notifier()

2024-05-29 Thread Thomas Huth
FI which is currently disabled with -fsanitize-cfi-icall-generalize-pointers. Thus let us avoid the problem by using "void *" as parameter in all spots where it is needed. Signed-off-by: Thomas Huth --- Yes, I know, the patch looks ugly ... but I don't see a better way to tackle this. If someone ha

Re: [PATCH 02/10] docs/devel: update references to centos to non-versioned container

2024-05-29 Thread Thomas Huth
references to the Debian image so we don't have to bump at the next update. Reviewed-by: Richard Henderson Signed-off-by: Alex Bennée Reviewed-by: Thomas Huth

Re: [PATCH 07/10] tests/lcitool: bump to latest version

2024-05-29 Thread Thomas Huth
On 29/05/2024 18.09, Alex Bennée wrote: We have to simultaneously update a few bits on our side as lcitool has already deprecated fedora-38, alpine-3.18 and centos-8-stream. However there is no change to the package list yet. Signed-off-by: Alex Bennée Have you tried a CI run with these

[PATCH] io/channel-socket: Fix -fsanitize=undefined problem with latest Clang

2024-05-29 Thread Thomas Huth
: UndefinedBehaviorSanitizer: undefined-behavior ../io/task.c:78:13 Add a wrapper function to avoid the problem. Signed-off-by: Thomas Huth --- io/channel-socket.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/io/channel-socket.c b/io/channel-socket.c index 3a899b0608

Re: [PATCH] tests/tcg/s390x: Allow specifying extra QEMU options on the command line

2024-05-29 Thread Thomas Huth
$(EXTFLAGS) -kernel LINK_SCRIPT=$(S390X_SRC)/softmmu.ld CFLAGS+=-ggdb -O0 LDFLAGS=-nostdlib -static Reviewed-by: Thomas Huth (sorry, I missed this for my pull request today ... I'll queue this patch for my next one)

[PULL 00/22] s390x, build-oss-fuzz and Clang -fsanitize=undefined fixes

2024-05-29 Thread Thomas Huth
of noreturn in translate_one tests/tcg/s390x: Add per.S Thomas Huth (3): hw/s390x: Remove unused macro VMSTATE_ADAPTER_ROUTES scripts/update-linux-headers.sh: Remove temporary directory inbetween scripts/update-linux-headers.sh: Fix the path of setup_data.h include/hw/s390x

[PULL 20/22] qemu-keymap: Make references to allocations static

2024-05-29 Thread Thomas Huth
Reviewed-by: Philippe Mathieu-Daudé Message-ID: <20240524-xkb-v4-1-2de564e5c...@daynix.com> Signed-off-by: Thomas Huth --- qemu-keymap.c | 8 +++- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/qemu-keymap.c b/qemu-keymap.c index 8c80f7a4ed..701e4332af 100644 ---

[PULL 19/22] scripts/update-linux-headers.sh: Fix the path of setup_data.h

2024-05-29 Thread Thomas Huth
re? Fixes: 66210a1a30 ("scripts/update-linux-headers: Add setup_data.h to import list") Message-ID: <20240527060126.12578-1-th...@redhat.com> Reviewed-by: Cornelia Huck Signed-off-by: Thomas Huth --- scripts/update-linux-headers.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletio

[PULL 22/22] qapi: Do not cast function pointers

2024-05-29 Thread Thomas Huth
the type casts. Resolves: https://gitlab.com/qemu-project/qemu/-/issues/2346 Signed-off-by: Akihiko Odaki Reviewed-by: Markus Armbruster Message-ID: <20240524-xkb-v4-3-2de564e5c...@daynix.com> [thuth: Improve commit message according to Markus' suggestions] Signed-off-by: Thomas Huth --- includ

[PULL 01/22] target/s390x: Do not use unwind for per_check_exception

2024-05-29 Thread Thomas Huth
and is passed to the exception handler. Sync cc_op before the call, which we would have gotten from unwind. Signed-off-by: Richard Henderson Reviewed-by: Ilya Leoshkevich Message-ID: <20240502054417.234340-2-richard.hender...@linaro.org> [thuth: Silence checkpatch.pl errors] Signed-off-by: Thoma

[PULL 18/22] scripts/update-linux-headers.sh: Remove temporary directory inbetween

2024-05-29 Thread Thomas Huth
-th...@redhat.com> Reviewed-by: Michael S. Tsirkin Acked-by: Cornelia Huck Signed-off-by: Thomas Huth --- scripts/update-linux-headers.sh | 1 + 1 file changed, 1 insertion(+) diff --git a/scripts/update-linux-headers.sh b/scripts/update-linux-headers.sh index 8963c39189..fbf7e119bc 100755 --- a/s

[PULL 16/22] fuzz: disable leak-detection for oss-fuzz builds

2024-05-29 Thread Thomas Huth
Message-ID: <20240527150001.325565-1-alx...@bu.edu> Signed-off-by: Thomas Huth --- scripts/oss-fuzz/build.sh | 1 + 1 file changed, 1 insertion(+) diff --git a/scripts/oss-fuzz/build.sh b/scripts/oss-fuzz/build.sh index 5238f83343..7398298173 100755 --- a/scripts/oss-fuzz/build.sh +++ b/s

[PULL 11/22] target/s390x: Fix helper_per_ifetch flags

2024-05-29 Thread Thomas Huth
o.org> Signed-off-by: Thomas Huth --- target/s390x/helper.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target/s390x/helper.h b/target/s390x/helper.h index 5611155ba1..31bd193322 100644 --- a/target/s390x/helper.h +++ b/target/s390x/helper.h @@ -361,7 +361,7 @@ DEF_HELP

[PULL 08/22] target/s390x: Split per_breaking_event from per_branch_*

2024-05-29 Thread Thomas Huth
From: Richard Henderson The breaking-event-address register is updated regardless of PER being enabled. Reviewed-by: Ilya Leoshkevich Signed-off-by: Richard Henderson Message-ID: <20240502054417.234340-9-richard.hender...@linaro.org> Signed-off-by: Thomas Huth --- target/s39

[PULL 06/22] target/s390x: Introduce help_goto_indirect

2024-05-29 Thread Thomas Huth
From: Richard Henderson Add a small helper to handle unconditional indirect jumps. Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Ilya Leoshkevich Signed-off-by: Richard Henderson Message-ID: <20240502054417.234340-7-richard.hender...@linaro.org> Signed-off-by: Thomas Huth ---

[PULL 21/22] lockable: Do not cast function pointers

2024-05-29 Thread Thomas Huth
Odaki Reviewed-by: Philippe Mathieu-Daudé Message-ID: <20240524-xkb-v4-2-2de564e5c...@daynix.com> Signed-off-by: Thomas Huth --- include/qemu/lockable.h | 23 +++ 1 file changed, 19 insertions(+), 4 deletions(-) diff --git a/include/qemu/lockable.h b/include/qemu/lock

[PULL 12/22] target/s390x: Simplify per_ifetch, per_check_exception

2024-05-29 Thread Thomas Huth
-13-richard.hender...@linaro.org> [thuth: Silence checkpatch.pl errors] Signed-off-by: Thomas Huth --- target/s390x/helper.h | 4 ++-- target/s390x/tcg/misc_helper.c | 23 +-- target/s390x/tcg/translate.c | 20 3 files changed, 23 insertions(

[PULL 17/22] hw/s390x: Remove unused macro VMSTATE_ADAPTER_ROUTES

2024-05-29 Thread Thomas Huth
It's not used anywhere, so let's simply remove it. Message-ID: <20240527121351.211266-1-th...@redhat.com> Reviewed-by: Cédric Le Goater Reviewed-by: Eric Farman Signed-off-by: Thomas Huth --- include/hw/s390x/s390_flic.h | 3 --- 1 file changed, 3 deletions(-) diff --git a/include/hw

[PULL 14/22] tests/tcg/s390x: Add per.S

2024-05-29 Thread Thomas Huth
From: Richard Henderson Add a small test to avoid regressions. Signed-off-by: Richard Henderson Acked-by: Ilya Leoshkevich Tested-by: Ilya Leoshkevich Message-ID: <20240502054417.234340-15-richard.hender...@linaro.org> Signed-off-by: Thomas Huth --- tests/tcg/s390x/Makefile.softmmu-

[PULL 15/22] fuzz: specify audiodev for usb-audio

2024-05-29 Thread Thomas Huth
From: Alexander Bulekov Fixes test-failure on Fedora 40 CI. Reported-by: Thomas Huth Signed-off-by: Alexander Bulekov Reviewed-by: Thomas Huth Message-ID: <20240527040711.311865-1-alx...@bu.edu> Signed-off-by: Thomas Huth --- tests/qtest/fuzz/generic_fuzz_configs.h | 3 ++- 1 file c

[PULL 02/22] target/s390x: Move cpu_get_tb_cpu_state out of line

2024-05-29 Thread Thomas Huth
From: Richard Henderson Signed-off-by: Richard Henderson Reviewed-by: Thomas Huth Reviewed-by: Ilya Leoshkevich Message-ID: <20240502054417.234340-3-richard.hender...@linaro.org> Signed-off-by: Thomas Huth --- target/s390x/cpu.h | 23 ++- target/s390x/cpu.

[PULL 04/22] target/s390x: Record separate PER bits in TB flags

2024-05-29 Thread Thomas Huth
-by: Ilya Leoshkevich Message-ID: <20240502054417.234340-5-richard.hender...@linaro.org> Signed-off-by: Thomas Huth --- target/s390x/cpu.h | 44 -- target/s390x/cpu.c | 22 + target/s390x/tcg/misc_helper.

[PULL 10/22] target/s390x: Raise exception from per_store_real

2024-05-29 Thread Thomas Huth
org> Signed-off-by: Thomas Huth --- target/s390x/helper.h | 2 +- target/s390x/tcg/misc_helper.c | 4 +++- target/s390x/tcg/translate.c | 7 --- 3 files changed, 8 insertions(+), 5 deletions(-) diff --git a/target/s390x/helper.h b/target/s390x/helper.h index 061b379065..5611155ba1

[PULL 07/22] target/s390x: Simplify help_branch

2024-05-29 Thread Thomas Huth
of the tcg branch. Reviewed-by: Ilya Leoshkevich Signed-off-by: Richard Henderson Message-ID: <20240502054417.234340-8-richard.hender...@linaro.org> Signed-off-by: Thomas Huth --- target/s390x/tcg/translate.c | 152 --- 1 file changed, 50 insertions(+), 102 del

[PULL 13/22] target/s390x: Adjust check of noreturn in translate_one

2024-05-29 Thread Thomas Huth
ed-off-by: Thomas Huth --- target/s390x/tcg/translate.c | 15 --- 1 file changed, 8 insertions(+), 7 deletions(-) diff --git a/target/s390x/tcg/translate.c b/target/s390x/tcg/translate.c index c9a5a1687e..c81e035dea 100644 --- a/target/s390x/tcg/translate.c +++ b/target/s390x/tcg/trans

[PULL 03/22] target/s390x: Update CR9 bits

2024-05-29 Thread Thomas Huth
From: Richard Henderson Update from the PoO 14th edition. Signed-off-by: Richard Henderson Reviewed-by: Thomas Huth Reviewed-by: Ilya Leoshkevich Message-ID: <20240502054417.234340-4-richard.hender...@linaro.org> Signed-off-by: Thomas Huth --- target/s390x/cpu.h

[PULL 09/22] target/s390x: Raise exception from helper_per_branch

2024-05-29 Thread Thomas Huth
the normal non-exception branch path. Signed-off-by: Richard Henderson Message-ID: <20240502054417.234340-10-richard.hender...@linaro.org> Signed-off-by: Thomas Huth --- target/s390x/helper.h | 2 +- target/s390x/tcg/misc_helper.c | 15 +++ target/s390x/tcg/translate.c

[PULL 05/22] target/s390x: Disable conditional branch-to-next for PER

2024-05-29 Thread Thomas Huth
Henderson Message-ID: <20240502054417.234340-6-richard.hender...@linaro.org> Signed-off-by: Thomas Huth --- target/s390x/tcg/translate.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/target/s390x/tcg/translate.c b/target/s390x/tcg/translate.c index de98

Re: tests/avocado: Add LoongArch machine start test

2024-05-29 Thread Thomas Huth
On 15/05/2023 13.19, Song Gao wrote: Add a new test in tests/avocado to check LoongArch virt machine start. Reviewed-by: Thomas Huth Signed-off-by: Song Gao Reviewed-by: Cédric Le Goater Message-Id: <20230513012744.1885728-1-gaos...@loongson.cn> --- MAINTAINERS

Re: [PATCH 12/14] target/s390x: Simplify per_ifetch, per_check_exception

2024-05-29 Thread Thomas Huth
On 02/05/2024 07.44, Richard Henderson wrote: Set per_address and ilen in per_ifetch; this is valid for all PER exceptions and will last until the end of the instruction. Therefore we don't need to give the same data to per_check_exception. Signed-off-by: Richard Henderson # Conflicts: #

Re: [PATCH] fuzz: disable leak-detection for oss-fuzz builds

2024-05-29 Thread Thomas Huth
On 27/05/2024 16.59, Alexander Bulekov wrote: When we are building for OSS-Fuzz, we want to ensure that the fuzzer targets are actually created, regardless of leaks. Leaks will be detected by the subsequent tests of the individual fuzz-targets. Signed-off-by: Alexander Bulekov ---

Re: [PATCH v4 0/4] Fix sanitizer errors with clang 18.1.1

2024-05-29 Thread Thomas Huth
a concern with it. To: Michael Tokarev To: Laurent Vivier To: Paolo Bonzini To: Marc-André Lureau To: Daniel P. Berrangé To: Thomas Huth To: Philippe Mathieu-Daudé To: Alex Bennée To: Wainer dos Santos Moschetta To: Beraldo Leal To: Richard Henderson To: Laurent Vivier Cc: qemu-devel@nongnu.

Re: [PATCH] tests/qtest: Add numa test for loongarch system

2024-05-29 Thread Thomas Huth
hanged, 54 insertions(+), 1 deletion(-) Acked-by: Thomas Huth I assume this will also go through the loongarch tree? Let me know if you want to have this merged via the qtest tree instead.

Re: [PATCH] tests/libqos: Add loongarch virt machine node

2024-05-29 Thread Thomas Huth
est/libqos/loongarch-virt-machine.c @@ -0,0 +1,114 @@ +/* + * libqos driver framework + * + * Copyright (c) 2018 Emanuele Giuseppe Esposito + * Don't you want to add your information here, too? Anyway: Acked-by: Thomas Huth I assume this will go through the loongarch tree. Let me know if you want to get this merged through the qtest tree instead.

Re: [PATCH v5 22/23] target/i386: Remove X86CPU::kvm_no_smi_migration field

2024-05-29 Thread Thomas Huth
/i386/cpu.c | 2 -- target/i386/kvm/kvm.c | 7 +-- 3 files changed, 1 insertion(+), 11 deletions(-) Reviewed-by: Thomas Huth

Re: [PATCH v5 21/23] hw/i386/pc: Simplify DEFINE_I440FX_MACHINE() macro

2024-05-29 Thread Thomas Huth
++- 1 file changed, 29 insertions(+), 33 deletions(-) Reviewed-by: Thomas Huth

Re: [PATCH v5 20/23] hw/i386/pc: Remove deprecated pc-i440fx-2.3 machine

2024-05-29 Thread Thomas Huth
docs/about/deprecated.rst | 4 ++-- docs/about/removed-features.rst | 2 +- hw/i386/pc.c| 25 - hw/i386/pc_piix.c | 19 --- 4 files changed, 3 insertions(+), 47 deletions(-) Reviewed-by: Thomas Huth

Re: [PATCH] fuzz: disable leak-detection for oss-fuzz builds

2024-05-29 Thread Thomas Huth
On 27/05/2024 16.59, Alexander Bulekov wrote: When we are building for OSS-Fuzz, we want to ensure that the fuzzer targets are actually created, regardless of leaks. Leaks will be detected by the subsequent tests of the individual fuzz-targets. Signed-off-by: Alexander Bulekov ---

Re: [PATCH] scripts/update-linux-headers.sh: Remove temporary directory inbetween

2024-05-28 Thread Thomas Huth
On 28/05/2024 17.56, Michael S. Tsirkin wrote: On Mon, May 27, 2024 at 08:02:43AM +0200, Thomas Huth wrote: We are reusing the same temporary directory for installing the headers of all targets, so there could be stale files here when switching from one target to another. Make sure to delete

Re: [PATCH 2/4] usb: add config options for the hub and hid devices

2024-05-28 Thread Thomas Huth
On 28/05/2024 11.54, Gerd Hoffmann wrote: Signed-off-by: Gerd Hoffmann --- hw/usb/Kconfig | 10 ++ hw/usb/meson.build | 4 ++-- 2 files changed, 12 insertions(+), 2 deletions(-) Reviewed-by: Thomas Huth

Re: [PATCH 3/4] usb/ohci-pci: deprecate, don't build by default

2024-05-28 Thread Thomas Huth
On 28/05/2024 11.54, Gerd Hoffmann wrote: The xhci host adapter is the much better choice. Signed-off-by: Gerd Hoffmann --- hw/usb/hcd-ohci-pci.c | 1 + hw/usb/Kconfig| 1 - 2 files changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/usb/hcd-ohci-pci.c b/hw/usb/hcd-ohci-pci.c

Re: [PATCH 3/4] tests/vm: update centos.aarch64 image to 9

2024-05-28 Thread Thomas Huth
(+), 5 deletions(-) Reviewed-by: Thomas Huth

Re: [PATCH 2/4] docs/devel: update references to centos to later version

2024-05-28 Thread Thomas Huth
On 21/05/2024 14.53, Alex Bennée wrote: From the website: "After May 31, 2024, CentOS Stream 8 will be archived and no further updates will be provided." We have updated a few bits but there are still references that need fixing. Signed-off-by: Alex Bennée --- docs/devel/testing.rst | 8

Re: [PATCH v2 4/6] tests/qtest/migration-test: Quieten ppc64 QEMU warnigns

2024-05-28 Thread Thomas Huth
I just noticed that there is a typo in the subject: s/warnigns/warnings/ On 28/05/2024 02.42, Nicholas Piggin wrote: Reviewed-by: Thomas Huth Signed-off-by: Nicholas Piggin --- tests/qtest/migration-test.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/tests

Re: [PATCH v2 3/6] tests/qtest: Move common define from libqos-spapr.h to new ppc-util.h

2024-05-28 Thread Thomas Huth
+++ tests/qtest/boot-serial-test.c| 2 +- tests/qtest/prom-env-test.c | 2 +- tests/qtest/pxe-test.c| 2 +- 5 files changed, 22 insertions(+), 10 deletions(-) create mode 100644 tests/qtest/ppc-util.h Reviewed-by: Thomas Huth

Re: [PATCH v2 1/6] tests/qtest/migration: Run test_mode_reboot outside gitlab CI

2024-05-28 Thread Thomas Huth
On 28/05/2024 02.42, Nicholas Piggin wrote: As Fabiano points out, this test isn't flaky it just can't run under gitlab CI since runners have a very small shm size. Suggested-by: Fabiano Rosas Signed-off-by: Nicholas Piggin --- tests/qtest/migration-test.c | 18 +- 1 file

Re: [PATCH] scripts/update-linux-headers.sh: Remove temporary directory inbetween

2024-05-27 Thread Thomas Huth
On 27/05/2024 17.04, Cornelia Huck wrote: On Mon, May 27 2024, Thomas Huth wrote: We are reusing the same temporary directory for installing the headers of all targets, so there could be stale files here when switching from one target to another. Make sure to delete the folder before

[PATCH] hw/s390x: Remove unused macro VMSTATE_ADAPTER_ROUTES

2024-05-27 Thread Thomas Huth
It's not used anywhere, so let's simply remove it. Signed-off-by: Thomas Huth --- include/hw/s390x/s390_flic.h | 3 --- 1 file changed, 3 deletions(-) diff --git a/include/hw/s390x/s390_flic.h b/include/hw/s390x/s390_flic.h index bcb081def5..382d9833f1 100644 --- a/include/hw/s390x/s390_flic.h

Re: [PATCH 1/3] tests/qtest/migration-test: Quieten ppc64 QEMU warnigns

2024-05-27 Thread Thomas Huth
On 27/05/2024 13.26, Nicholas Piggin wrote: On Mon May 27, 2024 at 5:32 PM AEST, Thomas Huth wrote: On 25/05/2024 05.13, Nicholas Piggin wrote: Signed-off-by: Nicholas Piggin --- tests/qtest/migration-test.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/tests

Re: qemu CI & ccache: cache size is too small

2024-05-27 Thread Thomas Huth
On 27/05/2024 12.49, Michael Tokarev wrote: Hi! Noticed today that a rebuild of basically the same tree (a few commits apart) in CI result in just 11% hit rate of ccache: https://gitlab.com/mjt0k/qemu/-/jobs/6947445337#L5054 For me, the results look better:

Re: [PATCH 2/3] tests/qtest/migration-test: Enable on ppc64

2024-05-27 Thread Thomas Huth
m on s390x, you could maybe adjust the comment in case you respin ... OTOH, it will get removed anyway once we merge the s390x fix, so no need to respin just because of this. Reviewed-by: Thomas Huth

Re: [PATCH 1/3] tests/qtest/migration-test: Quieten ppc64 QEMU warnigns

2024-05-27 Thread Thomas Huth
intf("-nodefaults " +"-machine " PSERIES_DEFAULT_CAPABILITIES); } else if (strcmp(arch, "aarch64") == 0) { memory_size = "150M"; machine_alias = "virt"; Reviewed-by: Thomas Huth

Re: [RFC PATCH 0/3] Fix s390x flic migration and add some more qtests

2024-05-27 Thread Thomas Huth
seems to be gone, indeed! Pretty cool, thanks for digging into this! Tested-by: Thomas Huth

Re: [PATCH v8 1/8] scripts/update-linux-headers: Copy setup_data.h to correct directory

2024-05-27 Thread Thomas Huth
; +"$output/include/standard-headers/asm-x86" I just ran into the same issue! Reviewed-by: Thomas Huth

Re: [PATCH 0/7] s390x/ccw: Error reporting cleanups

2024-05-27 Thread Thomas Huth
/s390x/ccw: Remove local Error variable from s390_ccw_realize() s390x/css: Make S390CCWDeviceClass::realize return bool vfio/ccw: Use the 'Error **errp' argument of vfio_ccw_realize() vfio/{ap,ccw}: Use warn_report_err() for IRQ notifier registration errors Series Reviewed-by: Thomas

[PATCH] scripts/update-linux-headers.sh: Remove temporary directory inbetween

2024-05-27 Thread Thomas Huth
We are reusing the same temporary directory for installing the headers of all targets, so there could be stale files here when switching from one target to another. Make sure to delete the folder before installing a new set of target headers into it. Signed-off-by: Thomas Huth --- scripts

[PATCH] scripts/update-linux-headers.sh: Fix the path of setup_data.h

2024-05-27 Thread Thomas Huth
re? Fixes: 66210a1a30 ("scripts/update-linux-headers: Add setup_data.h to import list") Signed-off-by: Thomas Huth --- scripts/update-linux-headers.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scripts/update-linux-headers.sh b/scripts/update-linux-headers.sh index fb

Re: [RFC PATCH 1/3] hw/intc/s390_flic: Migrate pending state

2024-05-26 Thread Thomas Huth
On 26/05/2024 22.33, David Hildenbrand wrote: Am 26.05.24 um 21:44 schrieb Richard Henderson: On 5/26/24 08:53, David Hildenbrand wrote: Am 25.05.24 um 15:12 schrieb Nicholas Piggin: The flic pending state is not migrated, so if the machine is migrated while an interrupt is pending, it can be

Re: [PATCH] fuzz: specify audiodev for usb-audio

2024-05-26 Thread Thomas Huth
On 27/05/2024 06.07, Alexander Bulekov wrote: Fixes test-failure on Fedora 40 CI. Reported-by: Thomas Huth Signed-off-by: Alexander Bulekov --- tests/qtest/fuzz/generic_fuzz_configs.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/tests/qtest/fuzz

Re: [PATCH V2 1/3] vl: Allow multiple -overcommit commands

2024-05-26 Thread Thomas Huth
to specify their behavior. e.g., in the following example, the cpu-pm command is quietly overwritten, and it's not easy to notice it without careful inspection. --overcommit mem-lock=on --overcommit cpu-pm=on Fixes: c8c9dc42b7ca ("Remove the deprecated -realtime option") Suggested-by: T

Re: [PATCH] tests/qtest/migration-test: Run some basic tests on s390x and ppc64 with TCG, too

2024-05-23 Thread Thomas Huth
On 24/05/2024 02.05, Nicholas Piggin wrote: On Wed May 22, 2024 at 7:12 PM AEST, Thomas Huth wrote: On s390x, we recently had a regression that broke migration / savevm (see commit bebe9603fc ("hw/intc/s390_flic: Fix crash that occurs when saving the machine state"). The problem

Re: [PULL 10/38] tests/qtest/migration: Add a test for the analyze-migration script

2024-05-22 Thread Thomas Huth
On 22/05/2024 14.48, Fabiano Rosas wrote: Thomas Huth writes: On 21/05/2024 14.46, Fabiano Rosas wrote: Alex Bennée writes: Juan Quintela writes: From: Fabiano Rosas Add a smoke test that migrates to a file and gives it to the script. It should catch the most annoying errors

Re: [PATCH 1/4] MAINTAINERS: drop audio maintainership

2024-05-22 Thread Thomas Huth
grade from R: to M: or that we change the status to Orphan JACK Audio Connection Kit backend -M: Gerd Hoffmann R: Christian Schoenebeck S: Odd Fixes F: audio/jackaudio.c dito SDL Audio backend -M: Gerd Hoffmann R: Thomas Huth I'm fine if you update my entry from R: to M: her

Re: [PATCH rfcv2 17/17] tests/qtest: Add intel-iommu test

2024-05-22 Thread Thomas Huth
ou whether you want to respin your patch with it or not. Anyway: Acked-by: Thomas Huth Do you want me to pick this up through the qtest tree, or shall this go through some x86-related tree instead? Thomas

<    1   2   3   4   5   6   7   8   9   10   >