[PULL 00/22] s390x, build-oss-fuzz and Clang -fsanitize=undefined fixes

2024-05-29 Thread Thomas Huth
of noreturn in translate_one tests/tcg/s390x: Add per.S Thomas Huth (3): hw/s390x: Remove unused macro VMSTATE_ADAPTER_ROUTES scripts/update-linux-headers.sh: Remove temporary directory inbetween scripts/update-linux-headers.sh: Fix the path of setup_data.h include/hw/s390x

[PULL 20/22] qemu-keymap: Make references to allocations static

2024-05-29 Thread Thomas Huth
Reviewed-by: Philippe Mathieu-Daudé Message-ID: <20240524-xkb-v4-1-2de564e5c...@daynix.com> Signed-off-by: Thomas Huth --- qemu-keymap.c | 8 +++- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/qemu-keymap.c b/qemu-keymap.c index 8c80f7a4ed..701e4332af 100644 ---

[PULL 19/22] scripts/update-linux-headers.sh: Fix the path of setup_data.h

2024-05-29 Thread Thomas Huth
re? Fixes: 66210a1a30 ("scripts/update-linux-headers: Add setup_data.h to import list") Message-ID: <20240527060126.12578-1-th...@redhat.com> Reviewed-by: Cornelia Huck Signed-off-by: Thomas Huth --- scripts/update-linux-headers.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletio

[PULL 22/22] qapi: Do not cast function pointers

2024-05-29 Thread Thomas Huth
the type casts. Resolves: https://gitlab.com/qemu-project/qemu/-/issues/2346 Signed-off-by: Akihiko Odaki Reviewed-by: Markus Armbruster Message-ID: <20240524-xkb-v4-3-2de564e5c...@daynix.com> [thuth: Improve commit message according to Markus' suggestions] Signed-off-by: Thomas Huth --- includ

[PULL 01/22] target/s390x: Do not use unwind for per_check_exception

2024-05-29 Thread Thomas Huth
and is passed to the exception handler. Sync cc_op before the call, which we would have gotten from unwind. Signed-off-by: Richard Henderson Reviewed-by: Ilya Leoshkevich Message-ID: <20240502054417.234340-2-richard.hender...@linaro.org> [thuth: Silence checkpatch.pl errors] Signed-off-by: Thoma

[PULL 18/22] scripts/update-linux-headers.sh: Remove temporary directory inbetween

2024-05-29 Thread Thomas Huth
-th...@redhat.com> Reviewed-by: Michael S. Tsirkin Acked-by: Cornelia Huck Signed-off-by: Thomas Huth --- scripts/update-linux-headers.sh | 1 + 1 file changed, 1 insertion(+) diff --git a/scripts/update-linux-headers.sh b/scripts/update-linux-headers.sh index 8963c39189..fbf7e119bc 100755 --- a/s

[PULL 16/22] fuzz: disable leak-detection for oss-fuzz builds

2024-05-29 Thread Thomas Huth
Message-ID: <20240527150001.325565-1-alx...@bu.edu> Signed-off-by: Thomas Huth --- scripts/oss-fuzz/build.sh | 1 + 1 file changed, 1 insertion(+) diff --git a/scripts/oss-fuzz/build.sh b/scripts/oss-fuzz/build.sh index 5238f83343..7398298173 100755 --- a/scripts/oss-fuzz/build.sh +++ b/s

[PULL 11/22] target/s390x: Fix helper_per_ifetch flags

2024-05-29 Thread Thomas Huth
o.org> Signed-off-by: Thomas Huth --- target/s390x/helper.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target/s390x/helper.h b/target/s390x/helper.h index 5611155ba1..31bd193322 100644 --- a/target/s390x/helper.h +++ b/target/s390x/helper.h @@ -361,7 +361,7 @@ DEF_HELP

[PULL 08/22] target/s390x: Split per_breaking_event from per_branch_*

2024-05-29 Thread Thomas Huth
From: Richard Henderson The breaking-event-address register is updated regardless of PER being enabled. Reviewed-by: Ilya Leoshkevich Signed-off-by: Richard Henderson Message-ID: <20240502054417.234340-9-richard.hender...@linaro.org> Signed-off-by: Thomas Huth --- target/s39

[PULL 06/22] target/s390x: Introduce help_goto_indirect

2024-05-29 Thread Thomas Huth
From: Richard Henderson Add a small helper to handle unconditional indirect jumps. Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Ilya Leoshkevich Signed-off-by: Richard Henderson Message-ID: <20240502054417.234340-7-richard.hender...@linaro.org> Signed-off-by: Thomas Huth ---

[PULL 21/22] lockable: Do not cast function pointers

2024-05-29 Thread Thomas Huth
Odaki Reviewed-by: Philippe Mathieu-Daudé Message-ID: <20240524-xkb-v4-2-2de564e5c...@daynix.com> Signed-off-by: Thomas Huth --- include/qemu/lockable.h | 23 +++ 1 file changed, 19 insertions(+), 4 deletions(-) diff --git a/include/qemu/lockable.h b/include/qemu/lock

[PULL 12/22] target/s390x: Simplify per_ifetch, per_check_exception

2024-05-29 Thread Thomas Huth
-13-richard.hender...@linaro.org> [thuth: Silence checkpatch.pl errors] Signed-off-by: Thomas Huth --- target/s390x/helper.h | 4 ++-- target/s390x/tcg/misc_helper.c | 23 +-- target/s390x/tcg/translate.c | 20 3 files changed, 23 insertions(

[PULL 17/22] hw/s390x: Remove unused macro VMSTATE_ADAPTER_ROUTES

2024-05-29 Thread Thomas Huth
It's not used anywhere, so let's simply remove it. Message-ID: <20240527121351.211266-1-th...@redhat.com> Reviewed-by: Cédric Le Goater Reviewed-by: Eric Farman Signed-off-by: Thomas Huth --- include/hw/s390x/s390_flic.h | 3 --- 1 file changed, 3 deletions(-) diff --git a/include/hw

[PULL 14/22] tests/tcg/s390x: Add per.S

2024-05-29 Thread Thomas Huth
From: Richard Henderson Add a small test to avoid regressions. Signed-off-by: Richard Henderson Acked-by: Ilya Leoshkevich Tested-by: Ilya Leoshkevich Message-ID: <20240502054417.234340-15-richard.hender...@linaro.org> Signed-off-by: Thomas Huth --- tests/tcg/s390x/Makefile.softmmu-

[PULL 15/22] fuzz: specify audiodev for usb-audio

2024-05-29 Thread Thomas Huth
From: Alexander Bulekov Fixes test-failure on Fedora 40 CI. Reported-by: Thomas Huth Signed-off-by: Alexander Bulekov Reviewed-by: Thomas Huth Message-ID: <20240527040711.311865-1-alx...@bu.edu> Signed-off-by: Thomas Huth --- tests/qtest/fuzz/generic_fuzz_configs.h | 3 ++- 1 file c

[PULL 02/22] target/s390x: Move cpu_get_tb_cpu_state out of line

2024-05-29 Thread Thomas Huth
From: Richard Henderson Signed-off-by: Richard Henderson Reviewed-by: Thomas Huth Reviewed-by: Ilya Leoshkevich Message-ID: <20240502054417.234340-3-richard.hender...@linaro.org> Signed-off-by: Thomas Huth --- target/s390x/cpu.h | 23 ++- target/s390x/cpu.

[PULL 04/22] target/s390x: Record separate PER bits in TB flags

2024-05-29 Thread Thomas Huth
-by: Ilya Leoshkevich Message-ID: <20240502054417.234340-5-richard.hender...@linaro.org> Signed-off-by: Thomas Huth --- target/s390x/cpu.h | 44 -- target/s390x/cpu.c | 22 + target/s390x/tcg/misc_helper.

[PULL 10/22] target/s390x: Raise exception from per_store_real

2024-05-29 Thread Thomas Huth
org> Signed-off-by: Thomas Huth --- target/s390x/helper.h | 2 +- target/s390x/tcg/misc_helper.c | 4 +++- target/s390x/tcg/translate.c | 7 --- 3 files changed, 8 insertions(+), 5 deletions(-) diff --git a/target/s390x/helper.h b/target/s390x/helper.h index 061b379065..5611155ba1

[PULL 07/22] target/s390x: Simplify help_branch

2024-05-29 Thread Thomas Huth
of the tcg branch. Reviewed-by: Ilya Leoshkevich Signed-off-by: Richard Henderson Message-ID: <20240502054417.234340-8-richard.hender...@linaro.org> Signed-off-by: Thomas Huth --- target/s390x/tcg/translate.c | 152 --- 1 file changed, 50 insertions(+), 102 del

[PULL 13/22] target/s390x: Adjust check of noreturn in translate_one

2024-05-29 Thread Thomas Huth
ed-off-by: Thomas Huth --- target/s390x/tcg/translate.c | 15 --- 1 file changed, 8 insertions(+), 7 deletions(-) diff --git a/target/s390x/tcg/translate.c b/target/s390x/tcg/translate.c index c9a5a1687e..c81e035dea 100644 --- a/target/s390x/tcg/translate.c +++ b/target/s390x/tcg/trans

[PULL 03/22] target/s390x: Update CR9 bits

2024-05-29 Thread Thomas Huth
From: Richard Henderson Update from the PoO 14th edition. Signed-off-by: Richard Henderson Reviewed-by: Thomas Huth Reviewed-by: Ilya Leoshkevich Message-ID: <20240502054417.234340-4-richard.hender...@linaro.org> Signed-off-by: Thomas Huth --- target/s390x/cpu.h

[PULL 09/22] target/s390x: Raise exception from helper_per_branch

2024-05-29 Thread Thomas Huth
the normal non-exception branch path. Signed-off-by: Richard Henderson Message-ID: <20240502054417.234340-10-richard.hender...@linaro.org> Signed-off-by: Thomas Huth --- target/s390x/helper.h | 2 +- target/s390x/tcg/misc_helper.c | 15 +++ target/s390x/tcg/translate.c

[PULL 05/22] target/s390x: Disable conditional branch-to-next for PER

2024-05-29 Thread Thomas Huth
Henderson Message-ID: <20240502054417.234340-6-richard.hender...@linaro.org> Signed-off-by: Thomas Huth --- target/s390x/tcg/translate.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/target/s390x/tcg/translate.c b/target/s390x/tcg/translate.c index de98

Re: tests/avocado: Add LoongArch machine start test

2024-05-29 Thread Thomas Huth
On 15/05/2023 13.19, Song Gao wrote: Add a new test in tests/avocado to check LoongArch virt machine start. Reviewed-by: Thomas Huth Signed-off-by: Song Gao Reviewed-by: Cédric Le Goater Message-Id: <20230513012744.1885728-1-gaos...@loongson.cn> --- MAINTAINERS

Re: [PATCH 12/14] target/s390x: Simplify per_ifetch, per_check_exception

2024-05-29 Thread Thomas Huth
On 02/05/2024 07.44, Richard Henderson wrote: Set per_address and ilen in per_ifetch; this is valid for all PER exceptions and will last until the end of the instruction. Therefore we don't need to give the same data to per_check_exception. Signed-off-by: Richard Henderson # Conflicts: #

Re: [PATCH] fuzz: disable leak-detection for oss-fuzz builds

2024-05-29 Thread Thomas Huth
On 27/05/2024 16.59, Alexander Bulekov wrote: When we are building for OSS-Fuzz, we want to ensure that the fuzzer targets are actually created, regardless of leaks. Leaks will be detected by the subsequent tests of the individual fuzz-targets. Signed-off-by: Alexander Bulekov ---

Re: [PATCH v4 0/4] Fix sanitizer errors with clang 18.1.1

2024-05-29 Thread Thomas Huth
a concern with it. To: Michael Tokarev To: Laurent Vivier To: Paolo Bonzini To: Marc-André Lureau To: Daniel P. Berrangé To: Thomas Huth To: Philippe Mathieu-Daudé To: Alex Bennée To: Wainer dos Santos Moschetta To: Beraldo Leal To: Richard Henderson To: Laurent Vivier Cc: qemu-devel@nongnu.

Re: [PATCH] tests/qtest: Add numa test for loongarch system

2024-05-29 Thread Thomas Huth
hanged, 54 insertions(+), 1 deletion(-) Acked-by: Thomas Huth I assume this will also go through the loongarch tree? Let me know if you want to have this merged via the qtest tree instead.

Re: [PATCH] tests/libqos: Add loongarch virt machine node

2024-05-29 Thread Thomas Huth
est/libqos/loongarch-virt-machine.c @@ -0,0 +1,114 @@ +/* + * libqos driver framework + * + * Copyright (c) 2018 Emanuele Giuseppe Esposito + * Don't you want to add your information here, too? Anyway: Acked-by: Thomas Huth I assume this will go through the loongarch tree. Let me know if you want to get this merged through the qtest tree instead.

Re: [PATCH v5 22/23] target/i386: Remove X86CPU::kvm_no_smi_migration field

2024-05-29 Thread Thomas Huth
/i386/cpu.c | 2 -- target/i386/kvm/kvm.c | 7 +-- 3 files changed, 1 insertion(+), 11 deletions(-) Reviewed-by: Thomas Huth

Re: [PATCH v5 21/23] hw/i386/pc: Simplify DEFINE_I440FX_MACHINE() macro

2024-05-29 Thread Thomas Huth
++- 1 file changed, 29 insertions(+), 33 deletions(-) Reviewed-by: Thomas Huth

Re: [PATCH v5 20/23] hw/i386/pc: Remove deprecated pc-i440fx-2.3 machine

2024-05-29 Thread Thomas Huth
docs/about/deprecated.rst | 4 ++-- docs/about/removed-features.rst | 2 +- hw/i386/pc.c| 25 - hw/i386/pc_piix.c | 19 --- 4 files changed, 3 insertions(+), 47 deletions(-) Reviewed-by: Thomas Huth

Re: [PATCH] fuzz: disable leak-detection for oss-fuzz builds

2024-05-29 Thread Thomas Huth
On 27/05/2024 16.59, Alexander Bulekov wrote: When we are building for OSS-Fuzz, we want to ensure that the fuzzer targets are actually created, regardless of leaks. Leaks will be detected by the subsequent tests of the individual fuzz-targets. Signed-off-by: Alexander Bulekov ---

Re: [PATCH] scripts/update-linux-headers.sh: Remove temporary directory inbetween

2024-05-28 Thread Thomas Huth
On 28/05/2024 17.56, Michael S. Tsirkin wrote: On Mon, May 27, 2024 at 08:02:43AM +0200, Thomas Huth wrote: We are reusing the same temporary directory for installing the headers of all targets, so there could be stale files here when switching from one target to another. Make sure to delete

Re: [PATCH 2/4] usb: add config options for the hub and hid devices

2024-05-28 Thread Thomas Huth
On 28/05/2024 11.54, Gerd Hoffmann wrote: Signed-off-by: Gerd Hoffmann --- hw/usb/Kconfig | 10 ++ hw/usb/meson.build | 4 ++-- 2 files changed, 12 insertions(+), 2 deletions(-) Reviewed-by: Thomas Huth

Re: [PATCH 3/4] usb/ohci-pci: deprecate, don't build by default

2024-05-28 Thread Thomas Huth
On 28/05/2024 11.54, Gerd Hoffmann wrote: The xhci host adapter is the much better choice. Signed-off-by: Gerd Hoffmann --- hw/usb/hcd-ohci-pci.c | 1 + hw/usb/Kconfig| 1 - 2 files changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/usb/hcd-ohci-pci.c b/hw/usb/hcd-ohci-pci.c

Re: [PATCH 3/4] tests/vm: update centos.aarch64 image to 9

2024-05-28 Thread Thomas Huth
(+), 5 deletions(-) Reviewed-by: Thomas Huth

Re: [PATCH 2/4] docs/devel: update references to centos to later version

2024-05-28 Thread Thomas Huth
On 21/05/2024 14.53, Alex Bennée wrote: From the website: "After May 31, 2024, CentOS Stream 8 will be archived and no further updates will be provided." We have updated a few bits but there are still references that need fixing. Signed-off-by: Alex Bennée --- docs/devel/testing.rst | 8

Re: [PATCH v2 4/6] tests/qtest/migration-test: Quieten ppc64 QEMU warnigns

2024-05-28 Thread Thomas Huth
I just noticed that there is a typo in the subject: s/warnigns/warnings/ On 28/05/2024 02.42, Nicholas Piggin wrote: Reviewed-by: Thomas Huth Signed-off-by: Nicholas Piggin --- tests/qtest/migration-test.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/tests

Re: [PATCH v2 3/6] tests/qtest: Move common define from libqos-spapr.h to new ppc-util.h

2024-05-28 Thread Thomas Huth
+++ tests/qtest/boot-serial-test.c| 2 +- tests/qtest/prom-env-test.c | 2 +- tests/qtest/pxe-test.c| 2 +- 5 files changed, 22 insertions(+), 10 deletions(-) create mode 100644 tests/qtest/ppc-util.h Reviewed-by: Thomas Huth

Re: [PATCH v2 1/6] tests/qtest/migration: Run test_mode_reboot outside gitlab CI

2024-05-28 Thread Thomas Huth
On 28/05/2024 02.42, Nicholas Piggin wrote: As Fabiano points out, this test isn't flaky it just can't run under gitlab CI since runners have a very small shm size. Suggested-by: Fabiano Rosas Signed-off-by: Nicholas Piggin --- tests/qtest/migration-test.c | 18 +- 1 file

Re: [PATCH] scripts/update-linux-headers.sh: Remove temporary directory inbetween

2024-05-27 Thread Thomas Huth
On 27/05/2024 17.04, Cornelia Huck wrote: On Mon, May 27 2024, Thomas Huth wrote: We are reusing the same temporary directory for installing the headers of all targets, so there could be stale files here when switching from one target to another. Make sure to delete the folder before

[PATCH] hw/s390x: Remove unused macro VMSTATE_ADAPTER_ROUTES

2024-05-27 Thread Thomas Huth
It's not used anywhere, so let's simply remove it. Signed-off-by: Thomas Huth --- include/hw/s390x/s390_flic.h | 3 --- 1 file changed, 3 deletions(-) diff --git a/include/hw/s390x/s390_flic.h b/include/hw/s390x/s390_flic.h index bcb081def5..382d9833f1 100644 --- a/include/hw/s390x/s390_flic.h

Re: [PATCH 1/3] tests/qtest/migration-test: Quieten ppc64 QEMU warnigns

2024-05-27 Thread Thomas Huth
On 27/05/2024 13.26, Nicholas Piggin wrote: On Mon May 27, 2024 at 5:32 PM AEST, Thomas Huth wrote: On 25/05/2024 05.13, Nicholas Piggin wrote: Signed-off-by: Nicholas Piggin --- tests/qtest/migration-test.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/tests

Re: qemu CI & ccache: cache size is too small

2024-05-27 Thread Thomas Huth
On 27/05/2024 12.49, Michael Tokarev wrote: Hi! Noticed today that a rebuild of basically the same tree (a few commits apart) in CI result in just 11% hit rate of ccache: https://gitlab.com/mjt0k/qemu/-/jobs/6947445337#L5054 For me, the results look better:

Re: [PATCH 2/3] tests/qtest/migration-test: Enable on ppc64

2024-05-27 Thread Thomas Huth
m on s390x, you could maybe adjust the comment in case you respin ... OTOH, it will get removed anyway once we merge the s390x fix, so no need to respin just because of this. Reviewed-by: Thomas Huth

Re: [PATCH 1/3] tests/qtest/migration-test: Quieten ppc64 QEMU warnigns

2024-05-27 Thread Thomas Huth
intf("-nodefaults " +"-machine " PSERIES_DEFAULT_CAPABILITIES); } else if (strcmp(arch, "aarch64") == 0) { memory_size = "150M"; machine_alias = "virt"; Reviewed-by: Thomas Huth

Re: [RFC PATCH 0/3] Fix s390x flic migration and add some more qtests

2024-05-27 Thread Thomas Huth
seems to be gone, indeed! Pretty cool, thanks for digging into this! Tested-by: Thomas Huth

Re: [PATCH v8 1/8] scripts/update-linux-headers: Copy setup_data.h to correct directory

2024-05-27 Thread Thomas Huth
; +"$output/include/standard-headers/asm-x86" I just ran into the same issue! Reviewed-by: Thomas Huth

Re: [PATCH 0/7] s390x/ccw: Error reporting cleanups

2024-05-27 Thread Thomas Huth
/s390x/ccw: Remove local Error variable from s390_ccw_realize() s390x/css: Make S390CCWDeviceClass::realize return bool vfio/ccw: Use the 'Error **errp' argument of vfio_ccw_realize() vfio/{ap,ccw}: Use warn_report_err() for IRQ notifier registration errors Series Reviewed-by: Thomas

[PATCH] scripts/update-linux-headers.sh: Remove temporary directory inbetween

2024-05-27 Thread Thomas Huth
We are reusing the same temporary directory for installing the headers of all targets, so there could be stale files here when switching from one target to another. Make sure to delete the folder before installing a new set of target headers into it. Signed-off-by: Thomas Huth --- scripts

[PATCH] scripts/update-linux-headers.sh: Fix the path of setup_data.h

2024-05-27 Thread Thomas Huth
re? Fixes: 66210a1a30 ("scripts/update-linux-headers: Add setup_data.h to import list") Signed-off-by: Thomas Huth --- scripts/update-linux-headers.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scripts/update-linux-headers.sh b/scripts/update-linux-headers.sh index fb

Re: [RFC PATCH 1/3] hw/intc/s390_flic: Migrate pending state

2024-05-26 Thread Thomas Huth
On 26/05/2024 22.33, David Hildenbrand wrote: Am 26.05.24 um 21:44 schrieb Richard Henderson: On 5/26/24 08:53, David Hildenbrand wrote: Am 25.05.24 um 15:12 schrieb Nicholas Piggin: The flic pending state is not migrated, so if the machine is migrated while an interrupt is pending, it can be

Re: [PATCH] fuzz: specify audiodev for usb-audio

2024-05-26 Thread Thomas Huth
On 27/05/2024 06.07, Alexander Bulekov wrote: Fixes test-failure on Fedora 40 CI. Reported-by: Thomas Huth Signed-off-by: Alexander Bulekov --- tests/qtest/fuzz/generic_fuzz_configs.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/tests/qtest/fuzz

Re: [PATCH V2 1/3] vl: Allow multiple -overcommit commands

2024-05-26 Thread Thomas Huth
to specify their behavior. e.g., in the following example, the cpu-pm command is quietly overwritten, and it's not easy to notice it without careful inspection. --overcommit mem-lock=on --overcommit cpu-pm=on Fixes: c8c9dc42b7ca ("Remove the deprecated -realtime option") Suggested-by: T

Re: [PATCH] tests/qtest/migration-test: Run some basic tests on s390x and ppc64 with TCG, too

2024-05-23 Thread Thomas Huth
On 24/05/2024 02.05, Nicholas Piggin wrote: On Wed May 22, 2024 at 7:12 PM AEST, Thomas Huth wrote: On s390x, we recently had a regression that broke migration / savevm (see commit bebe9603fc ("hw/intc/s390_flic: Fix crash that occurs when saving the machine state"). The problem

Re: [PULL 10/38] tests/qtest/migration: Add a test for the analyze-migration script

2024-05-22 Thread Thomas Huth
On 22/05/2024 14.48, Fabiano Rosas wrote: Thomas Huth writes: On 21/05/2024 14.46, Fabiano Rosas wrote: Alex Bennée writes: Juan Quintela writes: From: Fabiano Rosas Add a smoke test that migrates to a file and gives it to the script. It should catch the most annoying errors

Re: [PATCH 1/4] MAINTAINERS: drop audio maintainership

2024-05-22 Thread Thomas Huth
grade from R: to M: or that we change the status to Orphan JACK Audio Connection Kit backend -M: Gerd Hoffmann R: Christian Schoenebeck S: Odd Fixes F: audio/jackaudio.c dito SDL Audio backend -M: Gerd Hoffmann R: Thomas Huth I'm fine if you update my entry from R: to M: her

Re: [PATCH rfcv2 17/17] tests/qtest: Add intel-iommu test

2024-05-22 Thread Thomas Huth
ou whether you want to respin your patch with it or not. Anyway: Acked-by: Thomas Huth Do you want me to pick this up through the qtest tree, or shall this go through some x86-related tree instead? Thomas

Re: [PATCH v3 2/3] meson: Add -fno-sanitize=function

2024-05-22 Thread Thomas Huth
On 22/05/2024 12.48, Akihiko Odaki wrote: -fsanitize=function enforces the consistency of function types, but include/qemu/lockable.h contains function pointer casts, which violate the rule. We already disables exact type checks for CFI with -fsanitize-cfi-icall-generalize-pointers so disable

[PATCH] tests/qtest/migration-test: Fix the check for a successful run of analyze-migration.py

2024-05-22 Thread Thomas Huth
= s->qemu_pid' failed. ok 2 /x86_64/migration/analyze-script ... Let's better fail the test in case the child did not exit properly, too. Signed-off-by: Thomas Huth --- tests/qtest/migration-test.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/qtest/migration-te

[PATCH] tests/qtest/migration-test: Run some basic tests on s390x and ppc64 with TCG, too

2024-05-22 Thread Thomas Huth
tests before checking for KVM on s390x or ppc64 (this also fixes the problem that the "analyze-script" test was not run on s390x at all anymore since it got disabled again by accident in a previous refactoring of the code). Signed-off-by: Thomas Huth --- PS: Before anyone asks, yes, the quoted

Re: [PULL 10/38] tests/qtest/migration: Add a test for the analyze-migration script

2024-05-21 Thread Thomas Huth
way harder to figure out what is causing the script to fail, the person making the change is the most likely to know right away what the problem is. Signed-off-by: Fabiano Rosas Acked-by: Thomas Huth Reviewed-by: Juan Quintela Signed-off-by: Juan Quintela Message-ID: <20231009184326.15777-7-f

Re: [PATCH 4/4] tests/vm: remove plain centos image

2024-05-21 Thread Thomas Huth
changed, 52 deletions(-) delete mode 100755 tests/vm/centos Reviewed-by: Thomas Huth

Re: [PATCH 1/3] vl: Allow multiple -overcommit commands

2024-05-20 Thread Thomas Huth
On 21/05/2024 07.08, Thomas Huth wrote: On 20/05/2024 19.47, Zide Chen wrote: Both cpu-pm and mem-lock are related to system resource overcommit, but they are separate from each other, in terms of how they are realized, and of course, they are applied to different system resources. It's

Re: [PATCH 1/3] vl: Allow multiple -overcommit commands

2024-05-20 Thread Thomas Huth
+enable_mlock = enable_mlock || +qemu_opt_get_bool(opts, "mem-lock", false); +enable_cpu_pm = enable_cpu_pm || +qemu_opt_get_bool(opts, "cpu-pm", false); break; case QEMU_OPTION_compat: { Reviewed-by: Thomas Huth

[PULL 6/6] hw/intc/s390_flic: Fix crash that occurs when saving the machine state

2024-05-17 Thread Thomas Huth
0_get_flic() to get the correct device here instead. Reported-by: Marc Hartmayer Fixes: 9d1b0f5bf5 ("s390_flic: add migration-enabled property") Message-ID: <20240517061553.564529-1-th...@redhat.com> Reviewed-by: Cédric Le Goater Tested-by: Marc Hartmayer Signed-off-by: Thomas Huth --

[PULL 4/6] tests/lcitool/projects/qemu.yml: Sort entries alphabetically again

2024-05-17 Thread Thomas Huth
Let's try to keep the entries in alphabetical order here! Message-ID: <20240516084059.511463-5-th...@redhat.com> Reviewed-by: Daniel P. Berrangé Signed-off-by: Thomas Huth --- tests/lcitool/projects/qemu.yml | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff

[PULL 2/6] tests/lcitool: Remove 'xfsprogs' from QEMU

2024-05-17 Thread Thomas Huth
Message-ID: <20240516084059.511463-3-th...@redhat.com> Reviewed-by: Daniel P. Berrangé Signed-off-by: Thomas Huth --- tests/lcitool/projects/qemu.yml | 1 - 1 file changed, 1 deletion(-) diff --git a/tests/lcitool/projects/qemu.yml b/tests/lcitool/projects/qemu.yml index 149b15de57..9173d1e36e 100644 ---

[PULL 5/6] tests/docker/dockerfiles: Update container files with "lcitool-refresh"

2024-05-17 Thread Thomas Huth
iewed-by: Daniel P. Berrangé Signed-off-by: Thomas Huth --- tests/docker/dockerfiles/alpine.docker| 4 tests/docker/dockerfiles/centos9.docker | 4 tests/docker/dockerfiles/debian-amd64-cross.docker| 4 tests/docker/dockerfiles/debian-arm64-cro

[PULL 1/6] tests/lcitool/refresh: Treat the output of lcitool as text, not as bytes

2024-05-17 Thread Thomas Huth
In case lcitool fails (e.g. with a python backtrace), this makes the output of lcitool much more readable. Suggested-by: Daniel P. Berrangé Message-ID: <20240516084059.511463-2-th...@redhat.com> Reviewed-by: Daniel P. Berrangé Signed-off-by: Thomas Huth --- tests/lcitool/refresh | 4 +

[PULL 0/6] Fix s390x crash and clean up container images

2024-05-17 Thread Thomas Huth
* Decrease size of CI containers by removing unnecessary packages Philippe Mathieu-Daudé (1): tests/lcitool: Remove 'xfsprogs' from QEMU Thomas Huth (5): tests/lcitool/refresh: Treat the output of lcitool as text

[PULL 3/6] tests/lcitool: Remove g++ from the containers (except for the MinGW one)

2024-05-17 Thread Thomas Huth
it there with an extra project yml file instead. Message-ID: <20240516084059.511463-4-th...@redhat.com> Reviewed-by: Daniel P. Berrangé Signed-off-by: Thomas Huth --- tests/lcitool/projects/qemu-minimal.yml | 1 - tests/lcitool/projects/qemu-win-installer.yml | 4 tests/lcitool/pr

Re: [PATCH] gitlab-ci: Replace Docker with Kaniko

2024-05-17 Thread Thomas Huth
On 16/05/2024 20.24, Daniel P. Berrangé wrote: On Thu, May 16, 2024 at 05:52:43PM +0100, Camilla Conte wrote: Enables caching from the qemu-project repository. Uses a dedicated "$NAME-cache" tag for caching, to address limitations. See issue "when using --cache=true, kaniko fail to push cache

[PATCH] hw/intc/s390_flic: Fix crash that occurs when saving the machine state

2024-05-17 Thread Thomas Huth
0_get_flic() to get the correct device here instead. Reported-by: Marc Hartmayer Fixes: 9d1b0f5bf5 ("s390_flic: add migration-enabled property") Signed-off-by: Thomas Huth --- hw/intc/s390_flic.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/intc/s390_flic.c b/hw/in

Re: [PATCH 02/13] s390_flic: add migration-enabled property

2024-05-16 Thread Thomas Huth
On 16/05/2024 16.42, Marc Hartmayer wrote: On Thu, May 09, 2024 at 07:00 PM +0200, Paolo Bonzini wrote: Instead of mucking with css_migration_enabled(), add a property specific to the FLIC device, similar to what is done for TYPE_S390_STATTRIB. Signed-off-by: Paolo Bonzini ---

Re: [PATCH v2 1/3] docs: introduce dedicated page about code provenance / sign-off

2024-05-16 Thread Thomas Huth
On 16/05/2024 19.43, Peter Maydell wrote: On Thu, 16 May 2024 at 18:34, Michael S. Tsirkin wrote: On Thu, May 16, 2024 at 06:29:39PM +0100, Peter Maydell wrote: On Thu, 16 May 2024 at 17:22, Daniel P. Berrangé wrote: Currently we have a short paragraph saying that patches must include a

[PATCH v2 4/5] tests/lcitool/projects/qemu.yml: Sort entries alphabetically again

2024-05-16 Thread Thomas Huth
Let's try to keep the entries in alphabetical order here! Signed-off-by: Thomas Huth --- tests/lcitool/projects/qemu.yml | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/tests/lcitool/projects/qemu.yml b/tests/lcitool/projects/qemu.yml index b63b6bd850

[PATCH v2 1/5] tests/lcitool/refresh: Treat the output of lcitool as text, not as bytes

2024-05-16 Thread Thomas Huth
In case lcitool fails (e.g. with a python backtrace), this makes the output of lcitool much more readable. Suggested-by: Daniel P. Berrangé Signed-off-by: Thomas Huth --- tests/lcitool/refresh | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/lcitool/refresh b

[PATCH v2 5/5] tests/docker/dockerfiles: Update container files with "lcitool-refresh"

2024-05-16 Thread Thomas Huth
Run "make lcitool-refresh" after the previous changes to the lcitool files. This removes the g++ and xfslibs-dev packages from the dockerfiles (except for the fedora-win64-cross dockerfile where we keep the C++ compiler). Signed-off-by: Thomas Huth --- tests/docker/dockerfiles/alp

[PATCH v2 2/5] tests/lcitool: Remove 'xfsprogs' from QEMU

2024-05-16 Thread Thomas Huth
From: Philippe Mathieu-Daudé QEMU's commit a5730b8bd3 ("block/file-posix: Simplify the XFS_IOC_DIOINFO handling") removed the need for the 'xfsprogs' package. Signed-off-by: Philippe Mathieu-Daudé [thuth: Adjusted the patch from the lcitools repo to QEMU's repo] Signed-off-by: T

[PATCH v2 0/5] tests: Remove xfsprogs and g++ from the dockerfiles

2024-05-16 Thread Thomas Huth
her issues are resolved. Philippe Mathieu-Daudé (1): tests/lcitool: Remove 'xfsprogs' from QEMU Thomas Huth (4): tests/lcitool/refresh: Treat the output of lcitool as text, not as bytes tests/lcitool: Remove g++ from the containers (except for the MinGW one) tests/lcitool/projects/qemu

[PATCH v2 3/5] tests/lcitool: Remove g++ from the containers (except for the MinGW one)

2024-05-16 Thread Thomas Huth
it there with an extra project yml file instead. Signed-off-by: Thomas Huth --- tests/lcitool/projects/qemu-minimal.yml | 1 - tests/lcitool/projects/qemu-win-installer.yml | 4 tests/lcitool/projects/qemu.yml | 1 - tests/lcitool/refresh | 1 + 4 files

[PULL 11/11] util/uri: Remove the old URI parsing code

2024-05-14 Thread Thomas Huth
Now that we switched all consumers of the URI code to use the URI parsing functions from glib instead, we can remove our internal URI parsing code since it is not used anymore. Reviewed-by: Eric Blake Message-ID: <20240418101056.302103-14-th...@redhat.com> Signed-off-by: Thoma

[PULL 10/11] block/ssh: Use URI parsing code from glib

2024-05-14 Thread Thomas Huth
or other mistakes. Reviewed-by: Richard W.M. Jones Message-ID: <20240418101056.302103-13-th...@redhat.com> Signed-off-by: Thomas Huth --- block/ssh.c | 75 - 1 file changed, 40 insertions(+), 35 deletions(-) diff --git a/block/ssh.c b

[PULL 01/11] configure: Fix error message when C compiler is not working

2024-05-14 Thread Thomas Huth
this case since it is rather misleading than helpful. Fixes: 264b803721 ("configure: remove compiler sanity check") Message-ID: <20240513114010.51608-1-th...@redhat.com> Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Thomas Huth --- configure | 11 ++- 1 file ch

[PULL 04/11] gitlab: use 'setarch -R' to workaround tsan bug

2024-05-14 Thread Thomas Huth
nly supports upto '28'. LLVM 18 can support upto '30', and failing that will re-exec itself to turn off VA randomization. Our LLVM is too old for now, but we can run with 'setarch -R make ..' to turn off VA randomization ourselves. Signed-off-by: Daniel P. Berrangé Reviewed-by: Thomas Huth Message

[PULL 06/11] Remove glib compatibility code that is not required anymore

2024-05-14 Thread Thomas Huth
Now that we bumped the minimum glib version to 2.66, we can drop the old code. Suggested-by: Paolo Bonzini Reviewed-by: Daniel P. Berrangé Message-ID: <20240418101056.302103-9-th...@redhat.com> Signed-off-by: Thomas Huth --- qga/commands-posix-ssh.c | 8 util/error-re

[PULL 03/11] gitlab: use $MAKE instead of 'make'

2024-05-14 Thread Thomas Huth
From: Daniel P. Berrangé The lcitool generated containers have '$MAKE' set to the path of the right 'make' binary. Using the env variable makes it possible to override the choice per job. Signed-off-by: Daniel P. Berrangé Reviewed-by: Thomas Huth Reviewed-by: Philippe Mathieu-Daudé Message

[PULL 08/11] block/nbd: Use URI parsing code from glib

2024-05-14 Thread Thomas Huth
. Reviewed-by: Richard W.M. Jones Reviewed-by: Eric Blake Message-ID: <20240418101056.302103-11-th...@redhat.com> Signed-off-by: Thomas Huth --- block/nbd.c | 76 ++--- 1 file changed, 37 insertions(+), 39 deletions(-) diff --git a/block/nbd.c b

[PULL 07/11] block/gluster: Use URI parsing code from glib

2024-05-14 Thread Thomas Huth
of g_uri_get_path() as input). Reviewed-by: Eric Blake Reviewed-by: Daniel P. Berrangé Message-Id: <20240418101056.302103-10-th...@redhat.com> Signed-off-by: Thomas Huth --- block/gluster.c | 69 - 1 file changed, 34 insertions(+), 35 deletions(-)

[PULL 09/11] block/nfs: Use URI parsing code from glib

2024-05-14 Thread Thomas Huth
ce the latter rather sounds like the users were breaking a law here. Reviewed-by: Eric Blake Message-ID: <20240418101056.302103-12-th...@redhat.com> Signed-off-by: Thomas Huth --- block/nfs.c | 110 ++-- 1 file changed, 54 insertions(+), 5

[PULL 05/11] Bump minimum glib version to v2.66

2024-05-14 Thread Thomas Huth
which will allow further clean-ups in the following patches. Reviewed-by: Daniel P. Berrangé Message-ID: <20240418101056.302103-8-th...@redhat.com> Signed-off-by: Thomas Huth --- meson.build | 16 +--- include/glib-compat.h| 27 ++- qga/co

[PULL 00/11] gitlab CI fix and glib update

2024-05-14 Thread Thomas Huth
AKE instead of 'make' gitlab: use 'setarch -R' to workaround tsan bug Thomas Huth (8): configure: Fix error message when C compiler is not working Bump minimum glib version to v2.66 Remove glib compatibility code that is not required anymore block/gluster: Use URI pa

[PULL 02/11] dockerfiles: add 'MAKE' env variable to remaining containers

2024-05-14 Thread Thomas Huth
From: Daniel P. Berrangé All the lcitool generated containers define a "MAKE" env. It will be convenient for later patches if all containers do this. Signed-off-by: Daniel P. Berrangé Reviewed-by: Thomas Huth Reviewed-by: Philippe Mathieu-Daudé Message-ID: <20240513111551.4

Re: [PATCH 2/4] tests/lcitool: Remove g++ from the containers (except for the MinGW one)

2024-05-13 Thread Thomas Huth
On 13/05/2024 14.11, Daniel P. Berrangé wrote: On Mon, May 13, 2024 at 02:05:16PM +0200, Thomas Huth wrote: On 13/05/2024 12.28, Daniel P. Berrangé wrote: On Mon, May 13, 2024 at 12:22:50PM +0200, Thomas Huth wrote: We don't need C++ for the normal QEMU builds anymore, so installing g

Re: [PATCH 2/4] tests/lcitool: Remove g++ from the containers (except for the MinGW one)

2024-05-13 Thread Thomas Huth
On 13/05/2024 12.28, Daniel P. Berrangé wrote: On Mon, May 13, 2024 at 12:22:50PM +0200, Thomas Huth wrote: We don't need C++ for the normal QEMU builds anymore, so installing g++ in each and every container seems to be a waste of time and disk space. The only container that still needs

[PATCH v2] configure: Fix error message when C compiler is not working

2024-05-13 Thread Thomas Huth
this case since it is rather misleading than helpful. Fixes: 264b803721 ("configure: remove compiler sanity check") Signed-off-by: Thomas Huth --- v2: Reworked the patch according to Peter's suggestions: https://lists.gnu.org/archive/html/qemu-devel/2024-03/msg04643.html configure

Re: [PATCH 3/3] gitlab: use 'setarch -R' to workaround tsan bug

2024-05-13 Thread Thomas Huth
R make Thanks for tackling this! Reviewed-by: Thomas Huth

Re: [PATCH 2/3] gitlab: use $MAKE instead of 'make'

2024-05-13 Thread Thomas Huth
+++--- 1 file changed, 3 insertions(+), 3 deletions(-) Reviewed-by: Thomas Huth

<    1   2   3   4   5   6   7   8   9   10   >