[PATCH] Use "void *" as parameter for functions that are used for aio_set_event_notifier()

2024-05-29 Thread Thomas Huth
ich is currently disabled with -fsanitize-cfi-icall-generalize-pointers. Thus let us avoid the problem by using "void *" as parameter in all spots where it is needed. Signed-off-by: Thomas Huth --- Yes, I know, the patch looks ugly ... but I don't see a better way to tackle this. If someo

Re: [PATCH 02/10] docs/devel: update references to centos to non-versioned container

2024-05-29 Thread Thomas Huth
ferences to the Debian image so we don't have to bump at the next update. Reviewed-by: Richard Henderson Signed-off-by: Alex Bennée Reviewed-by: Thomas Huth

Re: [PATCH 07/10] tests/lcitool: bump to latest version

2024-05-29 Thread Thomas Huth
them, or whether we disable the error detection instead. - build-oss-fuzz job was failing, but that should get fixed with the patches from my PR from today (thanks to Alexander Bulekov for the patches) So unless I missed something, you've got to postpone this patch a little bit. Thomas

[PATCH] io/channel-socket: Fix -fsanitize=undefined problem with latest Clang

2024-05-29 Thread Thomas Huth
e SUMMARY: UndefinedBehaviorSanitizer: undefined-behavior ../io/task.c:78:13 Add a wrapper function to avoid the problem. Signed-off-by: Thomas Huth --- io/channel-socket.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/io/channel-socket.c b/io/channel-socket.c index

Re: [PATCH] tests/tcg/s390x: Allow specifying extra QEMU options on the command line

2024-05-29 Thread Thomas Huth
$(EXTFLAGS) -kernel LINK_SCRIPT=$(S390X_SRC)/softmmu.ld CFLAGS+=-ggdb -O0 LDFLAGS=-nostdlib -static Reviewed-by: Thomas Huth (sorry, I missed this for my pull request today ... I'll queue this patch for my next one)

[PULL 00/22] s390x, build-oss-fuzz and Clang -fsanitize=undefined fixes

2024-05-29 Thread Thomas Huth
t check of noreturn in translate_one tests/tcg/s390x: Add per.S Thomas Huth (3): hw/s390x: Remove unused macro VMSTATE_ADAPTER_ROUTES scripts/update-linux-headers.sh: Remove temporary directory inbetween scripts/update-linux-headers.sh: Fix the path of setup_data.h includ

[PULL 20/22] qemu-keymap: Make references to allocations static

2024-05-29 Thread Thomas Huth
Reviewed-by: Philippe Mathieu-Daudé Message-ID: <20240524-xkb-v4-1-2de564e5c...@daynix.com> Signed-off-by: Thomas Huth --- qemu-keymap.c | 8 +++- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/qemu-keymap.c b/qemu-keymap.c index 8c80f7a4ed..701e4332af 100644 ---

[PULL 19/22] scripts/update-linux-headers.sh: Fix the path of setup_data.h

2024-05-29 Thread Thomas Huth
re? Fixes: 66210a1a30 ("scripts/update-linux-headers: Add setup_data.h to import list") Message-ID: <20240527060126.12578-1-th...@redhat.com> Reviewed-by: Cornelia Huck Signed-off-by: Thomas Huth --- scripts/update-linux-headers.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletio

[PULL 22/22] qapi: Do not cast function pointers

2024-05-29 Thread Thomas Huth
d thus the type casts. Resolves: https://gitlab.com/qemu-project/qemu/-/issues/2346 Signed-off-by: Akihiko Odaki Reviewed-by: Markus Armbruster Message-ID: <20240524-xkb-v4-3-2de564e5c...@daynix.com> [thuth: Improve commit message according to Markus' suggestions] Signed-off-by: Thomas Hu

[PULL 01/22] target/s390x: Do not use unwind for per_check_exception

2024-05-29 Thread Thomas Huth
passed to the exception handler. Sync cc_op before the call, which we would have gotten from unwind. Signed-off-by: Richard Henderson Reviewed-by: Ilya Leoshkevich Message-ID: <20240502054417.234340-2-richard.hender...@linaro.org> [thuth: Silence checkpatch.pl errors] Signed-off-by: Thoma

[PULL 18/22] scripts/update-linux-headers.sh: Remove temporary directory inbetween

2024-05-29 Thread Thomas Huth
-th...@redhat.com> Reviewed-by: Michael S. Tsirkin Acked-by: Cornelia Huck Signed-off-by: Thomas Huth --- scripts/update-linux-headers.sh | 1 + 1 file changed, 1 insertion(+) diff --git a/scripts/update-linux-headers.sh b/scripts/update-linux-headers.sh index 8963c39189..fbf7e119bc 100755 --- a/s

[PULL 16/22] fuzz: disable leak-detection for oss-fuzz builds

2024-05-29 Thread Thomas Huth
Message-ID: <20240527150001.325565-1-alx...@bu.edu> Signed-off-by: Thomas Huth --- scripts/oss-fuzz/build.sh | 1 + 1 file changed, 1 insertion(+) diff --git a/scripts/oss-fuzz/build.sh b/scripts/oss-fuzz/build.sh index 5238f83343..7398298173 100755 --- a/scripts/oss-fuzz/build.sh +++ b/s

[PULL 11/22] target/s390x: Fix helper_per_ifetch flags

2024-05-29 Thread Thomas Huth
o.org> Signed-off-by: Thomas Huth --- target/s390x/helper.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target/s390x/helper.h b/target/s390x/helper.h index 5611155ba1..31bd193322 100644 --- a/target/s390x/helper.h +++ b/target/s390x/helper.h @@ -361,7 +361,7 @@ DEF_HELP

[PULL 08/22] target/s390x: Split per_breaking_event from per_branch_*

2024-05-29 Thread Thomas Huth
From: Richard Henderson The breaking-event-address register is updated regardless of PER being enabled. Reviewed-by: Ilya Leoshkevich Signed-off-by: Richard Henderson Message-ID: <20240502054417.234340-9-richard.hender...@linaro.org> Signed-off-by: Thomas Huth --- target/s39

[PULL 06/22] target/s390x: Introduce help_goto_indirect

2024-05-29 Thread Thomas Huth
From: Richard Henderson Add a small helper to handle unconditional indirect jumps. Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Ilya Leoshkevich Signed-off-by: Richard Henderson Message-ID: <20240502054417.234340-7-richard.hender...@linaro.org> Signed-off-by: Thomas Huth ---

[PULL 21/22] lockable: Do not cast function pointers

2024-05-29 Thread Thomas Huth
Odaki Reviewed-by: Philippe Mathieu-Daudé Message-ID: <20240524-xkb-v4-2-2de564e5c...@daynix.com> Signed-off-by: Thomas Huth --- include/qemu/lockable.h | 23 +++ 1 file changed, 19 insertions(+), 4 deletions(-) diff --git a/include/qemu/lockable.h b/include/qemu/lock

[PULL 12/22] target/s390x: Simplify per_ifetch, per_check_exception

2024-05-29 Thread Thomas Huth
34340-13-richard.hender...@linaro.org> [thuth: Silence checkpatch.pl errors] Signed-off-by: Thomas Huth --- target/s390x/helper.h | 4 ++-- target/s390x/tcg/misc_helper.c | 23 +-- target/s390x/tcg/translate.c | 20 3 files changed, 23 insert

[PULL 17/22] hw/s390x: Remove unused macro VMSTATE_ADAPTER_ROUTES

2024-05-29 Thread Thomas Huth
It's not used anywhere, so let's simply remove it. Message-ID: <20240527121351.211266-1-th...@redhat.com> Reviewed-by: Cédric Le Goater Reviewed-by: Eric Farman Signed-off-by: Thomas Huth --- include/hw/s390x/s390_flic.h | 3 --- 1 file changed, 3 deletions(-) diff --git a/

[PULL 14/22] tests/tcg/s390x: Add per.S

2024-05-29 Thread Thomas Huth
From: Richard Henderson Add a small test to avoid regressions. Signed-off-by: Richard Henderson Acked-by: Ilya Leoshkevich Tested-by: Ilya Leoshkevich Message-ID: <20240502054417.234340-15-richard.hender...@linaro.org> Signed-off-by: Thomas Huth --- tests/tcg/s390x/Makefile.softmmu-

[PULL 15/22] fuzz: specify audiodev for usb-audio

2024-05-29 Thread Thomas Huth
From: Alexander Bulekov Fixes test-failure on Fedora 40 CI. Reported-by: Thomas Huth Signed-off-by: Alexander Bulekov Reviewed-by: Thomas Huth Message-ID: <20240527040711.311865-1-alx...@bu.edu> Signed-off-by: Thomas Huth --- tests/qtest/fuzz/generic_fuzz_configs.h | 3 ++- 1 file c

[PULL 02/22] target/s390x: Move cpu_get_tb_cpu_state out of line

2024-05-29 Thread Thomas Huth
From: Richard Henderson Signed-off-by: Richard Henderson Reviewed-by: Thomas Huth Reviewed-by: Ilya Leoshkevich Message-ID: <20240502054417.234340-3-richard.hender...@linaro.org> Signed-off-by: Thomas Huth --- target/s390x/cpu.h | 23 ++- target/s390x/cpu.

[PULL 04/22] target/s390x: Record separate PER bits in TB flags

2024-05-29 Thread Thomas Huth
: Ilya Leoshkevich Message-ID: <20240502054417.234340-5-richard.hender...@linaro.org> Signed-off-by: Thomas Huth --- target/s390x/cpu.h | 44 -- target/s390x/cpu.c | 22 + target/s390x/tcg/misc_helper.

[PULL 10/22] target/s390x: Raise exception from per_store_real

2024-05-29 Thread Thomas Huth
naro.org> Signed-off-by: Thomas Huth --- target/s390x/helper.h | 2 +- target/s390x/tcg/misc_helper.c | 4 +++- target/s390x/tcg/translate.c | 7 --- 3 files changed, 8 insertions(+), 5 deletions(-) diff --git a/target/s390x/helper.h b/target/s390x/helper.h index 061b379065..561115

[PULL 07/22] target/s390x: Simplify help_branch

2024-05-29 Thread Thomas Huth
tcg branch. Reviewed-by: Ilya Leoshkevich Signed-off-by: Richard Henderson Message-ID: <20240502054417.234340-8-richard.hender...@linaro.org> Signed-off-by: Thomas Huth --- target/s390x/tcg/translate.c | 152 --- 1 file changed, 50 insertions(+), 102 del

[PULL 13/22] target/s390x: Adjust check of noreturn in translate_one

2024-05-29 Thread Thomas Huth
off-by: Thomas Huth --- target/s390x/tcg/translate.c | 15 --- 1 file changed, 8 insertions(+), 7 deletions(-) diff --git a/target/s390x/tcg/translate.c b/target/s390x/tcg/translate.c index c9a5a1687e..c81e035dea 100644 --- a/target/s390x/tcg/translate.c +++ b/target/s390x/tcg/trans

[PULL 03/22] target/s390x: Update CR9 bits

2024-05-29 Thread Thomas Huth
From: Richard Henderson Update from the PoO 14th edition. Signed-off-by: Richard Henderson Reviewed-by: Thomas Huth Reviewed-by: Ilya Leoshkevich Message-ID: <20240502054417.234340-4-richard.hender...@linaro.org> Signed-off-by: Thomas Huth --- target/s390x/cpu.h

[PULL 09/22] target/s390x: Raise exception from helper_per_branch

2024-05-29 Thread Thomas Huth
normal non-exception branch path. Signed-off-by: Richard Henderson Message-ID: <20240502054417.234340-10-richard.hender...@linaro.org> Signed-off-by: Thomas Huth --- target/s390x/helper.h | 2 +- target/s390x/tcg/misc_helper.c | 15 +++ target/s390x/tcg/translate.c

[PULL 05/22] target/s390x: Disable conditional branch-to-next for PER

2024-05-29 Thread Thomas Huth
Henderson Message-ID: <20240502054417.234340-6-richard.hender...@linaro.org> Signed-off-by: Thomas Huth --- target/s390x/tcg/translate.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/target/s390x/tcg/translate.c b/target/s390x/tcg/translate.c index de98

Re: tests/avocado: Add LoongArch machine start test

2024-05-29 Thread Thomas Huth
On 15/05/2023 13.19, Song Gao wrote: Add a new test in tests/avocado to check LoongArch virt machine start. Reviewed-by: Thomas Huth Signed-off-by: Song Gao Reviewed-by: Cédric Le Goater Message-Id: <20230513012744.1885728-1-gaos...@loongson.cn> --- MAINTAINERS

Re: [PATCH 12/14] target/s390x: Simplify per_ifetch, per_check_exception

2024-05-29 Thread Thomas Huth
x64 "\n", + env->per_address); FYI, checkpatch.pl complains: ERROR: Don't use '#' flag of printf format ('%#') in format strings, use '0x' prefix instead #84: FILE: target/s390x/tcg/misc_helper.c:651: + qemu_log_mask(CPU_LOG_INT, "PER interrupt before %#" PRIx64 I'll fix it up while picking up your patch. Thomas

Re: [PATCH] fuzz: disable leak-detection for oss-fuzz builds

2024-05-29 Thread Thomas Huth
uot; | head -n 1)" I've applied your patch, but it seems the leak is not detected later in the individual fuzz-targets anymore. That's strange... did you have a closer look already where this leak here comes from? Thomas

Re: [PATCH v4 0/4] Fix sanitizer errors with clang 18.1.1

2024-05-29 Thread Thomas Huth
ncern with it. To: Michael Tokarev To: Laurent Vivier To: Paolo Bonzini To: Marc-André Lureau To: Daniel P. Berrangé To: Thomas Huth To: Philippe Mathieu-Daudé To: Alex Bennée To: Wainer dos Santos Moschetta To: Beraldo Leal To: Richard Henderson To: Laurent Vivier Cc: qemu-devel@nongnu.

Re: [PATCH] tests/qtest: Add numa test for loongarch system

2024-05-29 Thread Thomas Huth
hanged, 54 insertions(+), 1 deletion(-) Acked-by: Thomas Huth I assume this will also go through the loongarch tree? Let me know if you want to have this merged via the qtest tree instead.

Re: [PATCH] tests/libqos: Add loongarch virt machine node

2024-05-29 Thread Thomas Huth
est/libqos/loongarch-virt-machine.c @@ -0,0 +1,114 @@ +/* + * libqos driver framework + * + * Copyright (c) 2018 Emanuele Giuseppe Esposito + * Don't you want to add your information here, too? Anyway: Acked-by: Thomas Huth I assume this will go through the loongarch tree. Let me know if you want to get this merged through the qtest tree instead.

Re: [PATCH v5 22/23] target/i386: Remove X86CPU::kvm_no_smi_migration field

2024-05-28 Thread Thomas Huth
/i386/cpu.c | 2 -- target/i386/kvm/kvm.c | 7 +-- 3 files changed, 1 insertion(+), 11 deletions(-) Reviewed-by: Thomas Huth

Re: [PATCH v5 21/23] hw/i386/pc: Simplify DEFINE_I440FX_MACHINE() macro

2024-05-28 Thread Thomas Huth
iix.c | 62 ++- 1 file changed, 29 insertions(+), 33 deletions(-) Reviewed-by: Thomas Huth

Re: [PATCH v5 20/23] hw/i386/pc: Remove deprecated pc-i440fx-2.3 machine

2024-05-28 Thread Thomas Huth
docs/about/deprecated.rst | 4 ++-- docs/about/removed-features.rst | 2 +- hw/i386/pc.c| 25 - hw/i386/pc_piix.c | 19 --- 4 files changed, 3 insertions(+), 47 deletions(-) Reviewed-by: Thomas Huth

Re: [PATCH] fuzz: disable leak-detection for oss-fuzz builds

2024-05-28 Thread Thomas Huth
ot; | head -n 1)" Would it maybe also make sense to check that $targets is not empty and error out in case it is? Thomas

Re: [PATCH] scripts/update-linux-headers.sh: Remove temporary directory inbetween

2024-05-28 Thread Thomas Huth
On 28/05/2024 17.56, Michael S. Tsirkin wrote: On Mon, May 27, 2024 at 08:02:43AM +0200, Thomas Huth wrote: We are reusing the same temporary directory for installing the headers of all targets, so there could be stale files here when switching from one target to another. Make sure to delete

Re: [PATCH 2/4] usb: add config options for the hub and hid devices

2024-05-28 Thread Thomas Huth
On 28/05/2024 11.54, Gerd Hoffmann wrote: Signed-off-by: Gerd Hoffmann --- hw/usb/Kconfig | 10 ++ hw/usb/meson.build | 4 ++-- 2 files changed, 12 insertions(+), 2 deletions(-) Reviewed-by: Thomas Huth

Re: [PATCH 3/4] usb/ohci-pci: deprecate, don't build by default

2024-05-28 Thread Thomas Huth
imply USB_OHCI_PCI pseries could certainly continue without OHCI AFAICT, but the others? Maybe this needs some discussion first... (thus putting some more people on CC:) Thomas

Re: [PATCH 3/4] tests/vm: update centos.aarch64 image to 9

2024-05-27 Thread Thomas Huth
tions(+), 5 deletions(-) Reviewed-by: Thomas Huth

Re: [PATCH 2/4] docs/devel: update references to centos to later version

2024-05-27 Thread Thomas Huth
hat about using @fedora instead of @centos9 ? Thomas

Re: [PATCH v2 4/6] tests/qtest/migration-test: Quieten ppc64 QEMU warnigns

2024-05-27 Thread Thomas Huth
I just noticed that there is a typo in the subject: s/warnigns/warnings/ On 28/05/2024 02.42, Nicholas Piggin wrote: Reviewed-by: Thomas Huth Signed-off-by: Nicholas Piggin --- tests/qtest/migration-test.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/tests

Re: [PATCH v2 3/6] tests/qtest: Move common define from libqos-spapr.h to new ppc-util.h

2024-05-27 Thread Thomas Huth
+++ tests/qtest/boot-serial-test.c| 2 +- tests/qtest/prom-env-test.c | 2 +- tests/qtest/pxe-test.c| 2 +- 5 files changed, 22 insertions(+), 10 deletions(-) create mode 100644 tests/qtest/ppc-util.h Reviewed-by: Thomas Huth

Re: [PATCH v2 1/6] tests/qtest/migration: Run test_mode_reboot outside gitlab CI

2024-05-27 Thread Thomas Huth
ther constraints container environments ... so it might be better to check whether enough space is available than to tie this to an environment variable (or even better change away from /dev/shm if possible like you did in your other patch - but I don't have a clue whether that's ok or not for these tests) Thomas

Re: [PATCH] scripts/update-linux-headers.sh: Remove temporary directory inbetween

2024-05-27 Thread Thomas Huth
On 27/05/2024 17.04, Cornelia Huck wrote: On Mon, May 27 2024, Thomas Huth wrote: We are reusing the same temporary directory for installing the headers of all targets, so there could be stale files here when switching from one target to another. Make sure to delete the folder before

[PATCH] hw/s390x: Remove unused macro VMSTATE_ADAPTER_ROUTES

2024-05-27 Thread Thomas Huth
It's not used anywhere, so let's simply remove it. Signed-off-by: Thomas Huth --- include/hw/s390x/s390_flic.h | 3 --- 1 file changed, 3 deletions(-) diff --git a/include/hw/s390x/s390_flic.h b/include/hw/s390x/s390_flic.h index bcb081def5..382d9833f1 100644 --- a/include/hw/s390x/s

Re: [PATCH 1/3] tests/qtest/migration-test: Quieten ppc64 QEMU warnigns

2024-05-27 Thread Thomas Huth
On 27/05/2024 13.26, Nicholas Piggin wrote: On Mon May 27, 2024 at 5:32 PM AEST, Thomas Huth wrote: On 25/05/2024 05.13, Nicholas Piggin wrote: Signed-off-by: Nicholas Piggin --- tests/qtest/migration-test.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/tests

Re: qemu CI & ccache: cache size is too small

2024-05-27 Thread Thomas Huth
nches before that run? ... I guess that could have invalidated most of the cached files since we switched from CentOS 8 to 9 recently...? Thomas

Re: [PATCH 2/3] tests/qtest/migration-test: Enable on ppc64

2024-05-27 Thread Thomas Huth
the problem on s390x, you could maybe adjust the comment in case you respin ... OTOH, it will get removed anyway once we merge the s390x fix, so no need to respin just because of this. Reviewed-by: Thomas Huth

Re: [PATCH 1/3] tests/qtest/migration-test: Quieten ppc64 QEMU warnigns

2024-05-27 Thread Thomas Huth
_strdup_printf("-nodefaults " +"-machine " PSERIES_DEFAULT_CAPABILITIES); } else if (strcmp(arch, "aarch64") == 0) { memory_size = "150M"; machine_alias = "virt"; Reviewed-by: Thomas Huth

Re: [RFC PATCH 0/3] Fix s390x flic migration and add some more qtests

2024-05-27 Thread Thomas Huth
d the hang seems to be gone, indeed! Pretty cool, thanks for digging into this! Tested-by: Thomas Huth

Re: [PATCH v8 1/8] scripts/update-linux-headers: Copy setup_data.h to correct directory

2024-05-26 Thread Thomas Huth
On 27/05/2024 08.27, Thomas Weißschuh wrote: Add the missing "include/" path component, so the files ends up in the correct place like the other headers. Fixes: 66210a1a30f2 ("scripts/update-linux-headers: Add setup_data.h to import list") Signed-off-by: Thomas Weißschuh

[PATCH v8 2/8] linux-headers: update to 6.10-rc1

2024-05-26 Thread Thomas Weißschuh
Signed-off-by: Thomas Weißschuh --- include/standard-headers/linux/ethtool.h| 55 +++ include/standard-headers/linux/pci_regs.h | 6 ++ include/standard-headers/linux/pvpanic.h| 7 +- include/standard-headers/linux/virtio_bt.h | 1 - include/standard-headers/linux

[PATCH v8 6/8] pvpanic: Emit GUEST_PVSHUTDOWN QMP event on pvpanic shutdown signal

2024-05-26 Thread Thomas Weißschuh
From: Alejandro Jimenez Emit a QMP event on receiving a PVPANIC_SHUTDOWN event. Even though a typical SHUTDOWN event will be sent, it will be indistinguishable from a shutdown originating from other cases (e.g. KVM exit due to KVM_SYSTEM_EVENT_SHUTDOWN) that also issue the guest-shutdown cause. A

[PATCH v8 8/8] Revert "docs/specs/pvpanic: mark shutdown event as not implemented"

2024-05-26 Thread Thomas Weißschuh
The missing functionality has been implemented now. This reverts commit e739d1935c461d0668057e9dbba9d06f728d29ec. Signed-off-by: Thomas Weißschuh --- docs/specs/pvpanic.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/specs/pvpanic.rst b/docs/specs/pvpanic.rst index

[PATCH v8 7/8] tests/qtest/pvpanic: add tests for pvshutdown event

2024-05-26 Thread Thomas Weißschuh
Validate that a shutdown via the pvpanic device emits the correct QMP events. Signed-off-by: Thomas Weißschuh Reviewed-by: Thomas Huth --- tests/qtest/pvpanic-pci-test.c | 39 +++ tests/qtest/pvpanic-test.c | 29 + 2 files

[PATCH v8 1/8] scripts/update-linux-headers: Copy setup_data.h to correct directory

2024-05-26 Thread Thomas Weißschuh
Add the missing "include/" path component, so the files ends up in the correct place like the other headers. Fixes: 66210a1a30f2 ("scripts/update-linux-headers: Add setup_data.h to import list") Signed-off-by: Thomas Weißschuh --- scripts/update-linux-headers.sh | 2 +

[PATCH v8 4/8] tests/qtest/pvpanic: use centralized definition of supported events

2024-05-26 Thread Thomas Weißschuh
Avoid the necessity to update all tests when new events are added to the device. Acked-by: Thomas Huth Reviewed-by: Cornelia Huck Signed-off-by: Thomas Weißschuh --- tests/qtest/pvpanic-pci-test.c | 5 +++-- tests/qtest/pvpanic-test.c | 5 +++-- 2 files changed, 6 insertions(+), 4

[PATCH v8 5/8] hw/misc/pvpanic: add support for normal shutdowns

2024-05-26 Thread Thomas Weißschuh
Shutdown requests are normally hardware dependent. By extending pvpanic to also handle shutdown requests, guests can submit such requests with an easily implementable and cross-platform mechanism. Acked-by: Cornelia Huck Signed-off-by: Thomas Weißschuh --- hw/misc/pvpanic.c | 5

[PATCH v8 0/8] update linux headers to v6.10-rc1 and shutdown support for pvpanic

2024-05-26 Thread Thomas Weißschuh
. Tsirkin To: Cornelia Huck To: Paolo Bonzini To: Thomas Huth To: Laurent Vivier To: Eric Blake To: Markus Armbruster Cc: qemu-devel@nongnu.org Cc: Alejandro Jimenez Cc: k...@vger.kernel.org Signed-off-by: Thomas Weißschuh Changes in v8: - Import linux headers from v6.10-rc1 (and update series

[PATCH v8 3/8] hw/misc/pvpanic: centralize definition of supported events

2024-05-26 Thread Thomas Weißschuh
The different components of pvpanic duplicate the list of supported events. Move it to the shared header file to minimize changes when new events are added. Reviewed-by: Thomas Huth Reviewed-by: Cornelia Huck Signed-off-by: Thomas Weißschuh --- hw/misc/pvpanic-isa.c | 3 +-- hw/misc

Re: [PATCH 0/7] s390x/ccw: Error reporting cleanups

2024-05-26 Thread Thomas Huth
bool hw/s390x/ccw: Remove local Error variable from s390_ccw_realize() s390x/css: Make S390CCWDeviceClass::realize return bool vfio/ccw: Use the 'Error **errp' argument of vfio_ccw_realize() vfio/{ap,ccw}: Use warn_report_err() for IRQ notifier registration errors Series

[PATCH] scripts/update-linux-headers.sh: Remove temporary directory inbetween

2024-05-26 Thread Thomas Huth
We are reusing the same temporary directory for installing the headers of all targets, so there could be stale files here when switching from one target to another. Make sure to delete the folder before installing a new set of target headers into it. Signed-off-by: Thomas Huth --- scripts

[PATCH] scripts/update-linux-headers.sh: Fix the path of setup_data.h

2024-05-26 Thread Thomas Huth
re? Fixes: 66210a1a30 ("scripts/update-linux-headers: Add setup_data.h to import list") Signed-off-by: Thomas Huth --- scripts/update-linux-headers.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scripts/update-linux-headers.sh b/scripts/update-linux-headers.sh index fb

Re: [RFC PATCH 1/3] hw/intc/s390_flic: Migrate pending state

2024-05-26 Thread Thomas Huth
for the new field. That way we would at least support forward migrations without too much hassle. Thomas

Re: [PATCH] fuzz: specify audiodev for usb-audio

2024-05-26 Thread Thomas Huth
On 27/05/2024 06.07, Alexander Bulekov wrote: Fixes test-failure on Fedora 40 CI. Reported-by: Thomas Huth Signed-off-by: Alexander Bulekov --- tests/qtest/fuzz/generic_fuzz_configs.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/tests/qtest/fuzz

Re: [PATCH V2 1/3] vl: Allow multiple -overcommit commands

2024-05-26 Thread Thomas Huth
es to specify their behavior. e.g., in the following example, the cpu-pm command is quietly overwritten, and it's not easy to notice it without careful inspection. --overcommit mem-lock=on --overcommit cpu-pm=on Fixes: c8c9dc42b7ca ("Remove the deprecated -realtime option") Sugge

Re: [PATCH] tests/qtest/migration-test: Run some basic tests on s390x and ppc64 with TCG, too

2024-05-23 Thread Thomas Huth
On 24/05/2024 02.05, Nicholas Piggin wrote: On Wed May 22, 2024 at 7:12 PM AEST, Thomas Huth wrote: On s390x, we recently had a regression that broke migration / savevm (see commit bebe9603fc ("hw/intc/s390_flic: Fix crash that occurs when saving the machine state"). The problem

[PATCH] hw: debugexit: use runstate API instead of plain exit()

2024-05-23 Thread Thomas Weißschuh
Directly calling exit() prevents any kind of management or handling. Instead use the corresponding runstate API. The default behavior of the runstate API is the same as exit(). Signed-off-by: Thomas Weißschuh --- hw/misc/debugexit.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff

Re: [PULL 10/38] tests/qtest/migration: Add a test for the analyze-migration script

2024-05-22 Thread Thomas Huth
On 22/05/2024 14.48, Fabiano Rosas wrote: Thomas Huth writes: On 21/05/2024 14.46, Fabiano Rosas wrote: Alex Bennée writes: Juan Quintela writes: From: Fabiano Rosas Add a smoke test that migrates to a file and gives it to the script. It should catch the most annoying errors such as

Re: [PATCH 1/4] MAINTAINERS: drop audio maintainership

2024-05-22 Thread Thomas Huth
er upgrade from R: to M: or that we change the status to Orphan JACK Audio Connection Kit backend -M: Gerd Hoffmann R: Christian Schoenebeck S: Odd Fixes F: audio/jackaudio.c dito SDL Audio backend -M: Gerd Hoffmann R: Thomas Huth I'm fine if you update my entry from R:

Re: [PATCH rfcv2 17/17] tests/qtest: Add intel-iommu test

2024-05-22 Thread Thomas Huth
u whether you want to respin your patch with it or not. Anyway: Acked-by: Thomas Huth Do you want me to pick this up through the qtest tree, or shall this go through some x86-related tree instead? Thomas

Re: [PATCH v3 2/3] meson: Add -fno-sanitize=function

2024-05-22 Thread Thomas Huth
flags = [] With GCC, I get: cc: error: unrecognized argument to ‘-fno-sanitize=’ option: ‘function’ I think you need to add this via cc.get_supported_arguments() to make sure that we only add it for compilers that support this option. Thomas

[PATCH] tests/qtest/migration-test: Fix the check for a successful run of analyze-migration.py

2024-05-22 Thread Thomas Huth
pid == s->qemu_pid' failed. ok 2 /x86_64/migration/analyze-script ... Let's better fail the test in case the child did not exit properly, too. Signed-off-by: Thomas Huth --- tests/qtest/migration-test.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/qte

[PATCH] tests/qtest/migration-test: Run some basic tests on s390x and ppc64 with TCG, too

2024-05-22 Thread Thomas Huth
sts before checking for KVM on s390x or ppc64 (this also fixes the problem that the "analyze-script" test was not run on s390x at all anymore since it got disabled again by accident in a previous refactoring of the code). Signed-off-by: Thomas Huth --- PS: Before anyone asks, yes, the quoted

Re: [PULL 10/38] tests/qtest/migration: Add a test for the analyze-migration script

2024-05-21 Thread Thomas Huth
way harder to figure out what is causing the script to fail, the person making the change is the most likely to know right away what the problem is. Signed-off-by: Fabiano Rosas Acked-by: Thomas Huth Reviewed-by: Juan Quintela Signed-off-by: Juan Quintela Message-ID: <20231009184326.15777-7-f

Re: [PATCH 4/4] tests/vm: remove plain centos image

2024-05-21 Thread Thomas Huth
files changed, 52 deletions(-) delete mode 100755 tests/vm/centos Reviewed-by: Thomas Huth

Re: [PATCH 1/3] vl: Allow multiple -overcommit commands

2024-05-20 Thread Thomas Huth
On 21/05/2024 07.08, Thomas Huth wrote: On 20/05/2024 19.47, Zide Chen wrote: Both cpu-pm and mem-lock are related to system resource overcommit, but they are separate from each other, in terms of how they are realized, and of course, they are applied to different system resources. It&#

Re: [PATCH 1/3] vl: Allow multiple -overcommit commands

2024-05-20 Thread Thomas Huth
ption if set */ +enable_mlock = enable_mlock || +qemu_opt_get_bool(opts, "mem-lock", false); +enable_cpu_pm = enable_cpu_pm || +qemu_opt_get_bool(opts, "cpu-pm", false); break; case QEMU_OPTION_compat: { Reviewed-by: Thomas Huth

[PULL 6/6] hw/intc/s390_flic: Fix crash that occurs when saving the machine state

2024-05-17 Thread Thomas Huth
_flic() to get the correct device here instead. Reported-by: Marc Hartmayer Fixes: 9d1b0f5bf5 ("s390_flic: add migration-enabled property") Message-ID: <20240517061553.564529-1-th...@redhat.com> Reviewed-by: Cédric Le Goater Tested-by: Marc Hartmayer Signed-off-by: Thomas Huth --

[PULL 4/6] tests/lcitool/projects/qemu.yml: Sort entries alphabetically again

2024-05-17 Thread Thomas Huth
Let's try to keep the entries in alphabetical order here! Message-ID: <20240516084059.511463-5-th...@redhat.com> Reviewed-by: Daniel P. Berrangé Signed-off-by: Thomas Huth --- tests/lcitool/projects/qemu.yml | 16 1 file changed, 8 insertions(+), 8 deletions(-) d

[PULL 2/6] tests/lcitool: Remove 'xfsprogs' from QEMU

2024-05-17 Thread Thomas Huth
o QEMU's repo] Message-ID: <20240516084059.511463-3-th...@redhat.com> Reviewed-by: Daniel P. Berrangé Signed-off-by: Thomas Huth --- tests/lcitool/projects/qemu.yml | 1 - 1 file changed, 1 deletion(-) diff --git a/tests/lcitool/projects/qemu.yml b/tests/lcitool/projects/qemu.yml index 149b15de57..9

[PULL 5/6] tests/docker/dockerfiles: Update container files with "lcitool-refresh"

2024-05-17 Thread Thomas Huth
iewed-by: Daniel P. Berrangé Signed-off-by: Thomas Huth --- tests/docker/dockerfiles/alpine.docker| 4 tests/docker/dockerfiles/centos9.docker | 4 tests/docker/dockerfiles/debian-amd64-cross.docker| 4 tests/docker/dockerfiles/debian-arm64-cro

[PULL 1/6] tests/lcitool/refresh: Treat the output of lcitool as text, not as bytes

2024-05-17 Thread Thomas Huth
In case lcitool fails (e.g. with a python backtrace), this makes the output of lcitool much more readable. Suggested-by: Daniel P. Berrangé Message-ID: <20240516084059.511463-2-th...@redhat.com> Reviewed-by: Daniel P. Berrangé Signed-off-by: Thomas Huth --- tests/lcitool/refresh | 4 +

[PULL 0/6] Fix s390x crash and clean up container images

2024-05-17 Thread Thomas Huth
n / savevm * Decrease size of CI containers by removing unnecessary packages Philippe Mathieu-Daudé (1): tests/lcitool: Remove 'xfsprogs' from QEMU Thomas Huth (5): tests/lcitool/refresh: Treat the output of lci

[PULL 3/6] tests/lcitool: Remove g++ from the containers (except for the MinGW one)

2024-05-17 Thread Thomas Huth
ll it there with an extra project yml file instead. Message-ID: <20240516084059.511463-4-th...@redhat.com> Reviewed-by: Daniel P. Berrangé Signed-off-by: Thomas Huth --- tests/lcitool/projects/qemu-minimal.yml | 1 - tests/lcitool/projects/qemu-win-installer.yml | 4 tests/lcito

Re: [PATCH] gitlab-ci: Replace Docker with Kaniko

2024-05-16 Thread Thomas Huth
Will this patch fix the issues that we are currently seeing with the k8s runners not working in the upstream CI? If so, I think that would be enough benefit, wouldn't it? Thomas

[PATCH] hw/intc/s390_flic: Fix crash that occurs when saving the machine state

2024-05-16 Thread Thomas Huth
_flic() to get the correct device here instead. Reported-by: Marc Hartmayer Fixes: 9d1b0f5bf5 ("s390_flic: add migration-enabled property") Signed-off-by: Thomas Huth --- hw/intc/s390_flic.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/intc/s390_flic.c b/hw/in

Re: [PATCH 02/13] s390_flic: add migration-enabled property

2024-05-16 Thread Thomas Huth
c.c @@ -459,7 +459,7 @@ type_init(qemu_s390_flic_register_types) static bool adapter_info_so_needed(void *opaque) { -S390FLICState *fs = S390_FLIC_COMMON(opaque); +S390FLICState *fs = s390_get_flic(); return fs->migration_enabled; } I'll send it as a proper patch... Thomas

Re: [PATCH v2 1/3] docs: introduce dedicated page about code provenance / sign-off

2024-05-16 Thread Thomas Huth
e to sign a patch (not an alias or acronym)." But it got lost in that rework, I assume by accident? So IMHO we had a consensus once to not allow anonymous contributions. I'm in favor of adding such a sentence back here now. Thomas

[PATCH v2 4/5] tests/lcitool/projects/qemu.yml: Sort entries alphabetically again

2024-05-16 Thread Thomas Huth
Let's try to keep the entries in alphabetical order here! Signed-off-by: Thomas Huth --- tests/lcitool/projects/qemu.yml | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/tests/lcitool/projects/qemu.yml b/tests/lcitool/projects/qemu.yml index b63b6

[PATCH v2 1/5] tests/lcitool/refresh: Treat the output of lcitool as text, not as bytes

2024-05-16 Thread Thomas Huth
In case lcitool fails (e.g. with a python backtrace), this makes the output of lcitool much more readable. Suggested-by: Daniel P. Berrangé Signed-off-by: Thomas Huth --- tests/lcitool/refresh | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/lcitool/refresh b

[PATCH v2 5/5] tests/docker/dockerfiles: Update container files with "lcitool-refresh"

2024-05-16 Thread Thomas Huth
Run "make lcitool-refresh" after the previous changes to the lcitool files. This removes the g++ and xfslibs-dev packages from the dockerfiles (except for the fedora-win64-cross dockerfile where we keep the C++ compiler). Signed-off-by: Thomas Huth --- tests/docker/dockerfiles/alp

[PATCH v2 2/5] tests/lcitool: Remove 'xfsprogs' from QEMU

2024-05-16 Thread Thomas Huth
From: Philippe Mathieu-Daudé QEMU's commit a5730b8bd3 ("block/file-posix: Simplify the XFS_IOC_DIOINFO handling") removed the need for the 'xfsprogs' package. Signed-off-by: Philippe Mathieu-Daudé [thuth: Adjusted the patch from the lcitools repo to QEMU's re

[PATCH v2 0/5] tests: Remove xfsprogs and g++ from the dockerfiles

2024-05-16 Thread Thomas Huth
ther issues are resolved. Philippe Mathieu-Daudé (1): tests/lcitool: Remove 'xfsprogs' from QEMU Thomas Huth (4): tests/lcitool/refresh: Treat the output of lcitool as text, not as bytes tests/lcitool: Remove g++ from the containers (except for the MinGW one) tests/lcitoo

[PATCH v2 3/5] tests/lcitool: Remove g++ from the containers (except for the MinGW one)

2024-05-16 Thread Thomas Huth
ll it there with an extra project yml file instead. Signed-off-by: Thomas Huth --- tests/lcitool/projects/qemu-minimal.yml | 1 - tests/lcitool/projects/qemu-win-installer.yml | 4 tests/lcitool/projects/qemu.yml | 1 - tests/lcitool/refresh | 1 + 4

[PULL 11/11] util/uri: Remove the old URI parsing code

2024-05-14 Thread Thomas Huth
Now that we switched all consumers of the URI code to use the URI parsing functions from glib instead, we can remove our internal URI parsing code since it is not used anymore. Reviewed-by: Eric Blake Message-ID: <20240418101056.302103-14-th...@redhat.com> Signed-off-by: Thoma

[PULL 10/11] block/ssh: Use URI parsing code from glib

2024-05-14 Thread Thomas Huth
os or other mistakes. Reviewed-by: Richard W.M. Jones Message-ID: <20240418101056.302103-13-th...@redhat.com> Signed-off-by: Thomas Huth --- block/ssh.c | 75 - 1 file changed, 40 insertions(+), 35 deletions(-) diff --git a/block/ss

<    4   5   6   7   8   9   10   11   12   13   >