Re: [PULL v2 00/88] virtio: features,fixes

2024-07-03 Thread Thomas Huth
On 03/07/2024 21.45, Michael S. Tsirkin wrote: On Wed, Jul 03, 2024 at 08:46:38PM +0200, Thomas Huth wrote: On 03/07/2024 19.01, Richard Henderson wrote: On 7/3/24 09:51, Michael S. Tsirkin wrote: On Wed, Jul 03, 2024 at 09:31:45AM -0700, Richard Henderson wrote: On 7/2/24 13:15, Michael S

Re: [PULL v2 00/88] virtio: features,fixes

2024-07-03 Thread Thomas Huth
On 03/07/2024 22.26, Michael S. Tsirkin wrote: On Wed, Jul 03, 2024 at 08:46:38PM +0200, Thomas Huth wrote: On 03/07/2024 19.01, Richard Henderson wrote: On 7/3/24 09:51, Michael S. Tsirkin wrote: On Wed, Jul 03, 2024 at 09:31:45AM -0700, Richard Henderson wrote: On 7/2/24 13:15, Michael S

Re: [PULL v2 00/88] virtio: features,fixes

2024-07-03 Thread Thomas Huth
tive debugging, so that's likely the best way to tackle such issues. HTH, Thomas

Re: [PATCH v2 2/2] docs: remove Sphinx 1.x compatibility code

2024-07-03 Thread Thomas Huth
-- docs/sphinx/kernellog.py | 28 docs/sphinx/qapidoc.py | 29 +++-- 4 files changed, 19 insertions(+), 97 deletions(-) delete mode 100644 docs/sphinx/kernellog.py Reviewed-by: Thomas Huth

Re: [PATCH v2 1/2] Python: bump minimum sphinx version to 3.4.3

2024-07-03 Thread Thomas Huth
PyPI. Signed-off-by: John Snow Acked-by: Paolo Bonzini Acked-by: Markus Armbruster --- docs/conf.py| 7 +++ pythondeps.toml | 2 +- 2 files changed, 4 insertions(+), 5 deletions(-) Reviewed-by: Thomas Huth

[PATCH] hw: Fix crash that happens when introspecting scsi-block on older machine types

2024-07-03 Thread Thomas Huth
's fix the problem by only changing the property on the devices that really have this property. Fixes: b4912afa5f ("scsi-disk: Fix crash for VM configured with USB CDROM after live migration") Signed-off-by: Thomas Huth --- hw/core/machine.c | 3 ++- 1 file changed, 2 insertions(+), 1

[PULL 03/12] tests/qtest: Use qtest_add_data_func_full()

2024-07-02 Thread Thomas Huth
627-san-v2-10-750bb0946...@daynix.com> Reviewed-by: Thomas Huth Signed-off-by: Thomas Huth --- tests/qtest/device-introspect-test.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/tests/qtest/device-introspect-test.c b/tests/qtest/device-introspect-test.c index 5b0f

[PULL 05/12] tests/qtest: Free old machine variable name

2024-07-02 Thread Thomas Huth
From: Akihiko Odaki This fixes LeakSanitizer warnings. Signed-off-by: Akihiko Odaki Reviewed-by: Peter Maydell Reviewed-by: Michael S. Tsirkin Message-ID: <20240627-san-v2-12-750bb0946...@daynix.com> Signed-off-by: Thomas Huth --- tests/qtest/libqtest.c | 1 + 1 file changed, 1 ins

[PULL 04/12] tests/qtest: Free unused QMP response

2024-07-02 Thread Thomas Huth
From: Akihiko Odaki This fixes LeakSanitizer warnings. Signed-off-by: Akihiko Odaki Reviewed-by: Michael S. Tsirkin Message-ID: <20240627-san-v2-11-750bb0946...@daynix.com> Signed-off-by: Thomas Huth --- tests/qtest/libqtest.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a

[PULL 10/12] tests/avocado: add hotplug_blk test

2024-07-02 Thread Thomas Huth
From: Vladimir Sementsov-Ogievskiy Introduce a test, that checks that plug/unplug of virtio-blk device works. (the test is developed by copying hotplug_cpu.py, so keep original copyright) Signed-off-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Thomas Huth Message-ID: <20240409065854.366

[PULL 09/12] hw/s390x: Attach default virtio-net devices to the /machine/virtual-css-bridge

2024-07-02 Thread Thomas Huth
Reviewed-by: Cédric Le Goater Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Thomas Huth --- hw/s390x/s390-virtio-ccw.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/hw/s390x/s390-virtio-ccw.c b/hw/s390x/s390-virtio-ccw.c index f87ca36264..c1edbd9131 100644 --- a/hw/s390x/s390-virtio-

[PULL 11/12] .travis.yml: Install python3-tomli in all build jobs

2024-07-02 Thread Thomas Huth
Since commit 1f97715c83 ('Revert "python: use vendored tomli"') this package is a hard requirement for compiling QEMU, so install it now in all Travis jobs, too. Message-ID: <20240624094807.182313-1-th...@redhat.com> Acked-by: Alex Bennée Signed-off-by: Thomas

[PULL 02/12] tests/qtest/migration-test: enable on s390x with TCG

2024-07-02 Thread Thomas Huth
From: Nicholas Piggin s390x with TCG is more stable now. Enable it. Signed-off-by: Nicholas Piggin Message-Id: <20240525131241.378473-3-npig...@gmail.com> Reviewed-by: Prasad Pandit [thuth: Added "with TCG" to the commit message] Signed-off-by: Thomas Huth --- tests/qtest/

[PULL 12/12] pc-bios/s390-ccw: Remove duplicated LDFLAGS

2024-07-02 Thread Thomas Huth
The -Wl,-pie and -nostdlib flags are added to LDFLAGS twice. Merge the two lines to get rid of the duplicates. Message-ID: <20240621082422.136217-2-th...@redhat.com> Signed-off-by: Thomas Huth --- pc-bios/s390-ccw/Makefile | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff -

[PULL 07/12] tests/qtest: Free GThread

2024-07-02 Thread Thomas Huth
From: Akihiko Odaki These GThreads are never referenced. Signed-off-by: Akihiko Odaki Reviewed-by: Peter Maydell Reviewed-by: Michael S. Tsirkin Message-ID: <20240627-san-v2-15-750bb0946...@daynix.com> Signed-off-by: Thomas Huth --- tests/qtest/vhost-user-test.c | 6 +++--- 1 file c

[PULL 08/12] docs: add precision about capstone for execlog plugin

2024-07-02 Thread Thomas Huth
ge-ID: <20240620135731.977377-1-erdn...@crans.org> Signed-off-by: Thomas Huth --- docs/devel/tcg-plugins.rst | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/docs/devel/tcg-plugins.rst b/docs/devel/tcg-plugins.rst index 9cc09d8c3d..f7d7b9e3a4 100644 --- a/docs/devel/tcg-plugins.rst +++ b

[PULL 06/12] tests/qtest: Free paths

2024-07-02 Thread Thomas Huth
From: Akihiko Odaki This fixes LeakSanitizer warnings. Signed-off-by: Akihiko Odaki Reviewed-by: Michael S. Tsirkin Message-ID: <20240627-san-v2-14-750bb0946...@daynix.com> Signed-off-by: Thomas Huth --- tests/qtest/qos-test.c | 16 1 file changed, 12 insertions

[PULL 01/12] hw/intc/s390_flic: Fix interrupt controller migration on s390x with TCG

2024-07-02 Thread Thomas Huth
e, so s390_cpu_exec_interrupt falls through to halting again." Thus let's finally migrate the pending state, and to be on the safe side, also the other state variables of the QEMUS390FLICState structure. Message-ID: <20240619144421.261342-1-th...@redhat.com> Signed-off-by: Thomas Huth

[PULL 00/12] qtest, s390x, avocado and doc patches

2024-07-02 Thread Thomas Huth
Piggin (1): tests/qtest/migration-test: enable on s390x with TCG Thomas Huth (4): hw/intc/s390_flic: Fix interrupt controller migration on s390x with TCG hw/s390x: Attach default virtio-net devices to the /machine/virtual-css-bridge .travis.yml: Install python3-tomli in all build job

Re: [PATCH v2 13/15] tests/qtest: Delete previous boot file

2024-07-02 Thread Thomas Huth
x27;A' followed by an endless string of 'B's I think the better fix would be to call bootfile_create() only once from main() since we don't have to create the bootfile multiple times, do we? Thomas

Re: [PATCH v2 00/15] Fix check-qtest-ppc64 sanitizer errors

2024-07-01 Thread Thomas Huth
ally or other misc areas. I can take the qtest patches through my tree. Thomas

Re: [PATCH v2 10/15] tests/qtest: Use qtest_add_data_func_full()

2024-07-01 Thread Thomas Huth
-introspect-test.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) Reviewed-by: Thomas Huth

[PATCH] hw/s390x: Attach default virtio-net devices to the /machine/virtual-css-bridge

2024-07-01 Thread Thomas Huth
The initial virtio-net-ccw devices currently do not have a proper parent in the QOM tree, so they show up under /machine/unattached - which is somewhat ugly. Let's attach them to /machine/virtual-css-bridge/virtual-css instead. Signed-off-by: Thomas Huth --- hw/s390x/s390-virtio-ccw.

Re: [PATCH] hw/virtio: Fix the de-initialization of vhost-user devices

2024-07-01 Thread Thomas Huth
On 01/07/2024 17.06, Michael S. Tsirkin wrote: On Mon, Jul 01, 2024 at 04:07:56PM +0200, Thomas Huth wrote: On 18/06/2024 14.19, Thomas Huth wrote: The unrealize functions of the various vhost-user devices are calling the corresponding vhost_*_set_status() functions with a status of 0 to shut

Re: [PATCH] hw/virtio: Fix the de-initialization of vhost-user devices

2024-07-01 Thread Thomas Huth
On 18/06/2024 14.19, Thomas Huth wrote: The unrealize functions of the various vhost-user devices are calling the corresponding vhost_*_set_status() functions with a status of 0 to shut down the device correctly. Now these vhost_*_set_status() functions all follow this scheme: bool

[PATCH] Remove inclusion of hw/hw.h from files that don't need it

2024-07-01 Thread Thomas Huth
hw/hw.h only contains the prototype of hw_error() nowadays, so files that don't use this function don't need to include this header. Signed-off-by: Thomas Huth --- include/hw/misc/xlnx-cfi-if.h | 1 - hw/misc/edu.c | 1 - hw/vfio/container.c | 1 - 3 files

Re: [PATCH v2 07/14] hw/i386: convert 'q35' machine definitions to use new macros

2024-07-01 Thread Thomas Huth
- hw/i386/pc_q35.c | 215 --- 1 file changed, 90 insertions(+), 125 deletions(-) Reviewed-by: Thomas Huth

Re: [PATCH v2 06/14] hw/i386: convert 'i440fx' machine definitions to use new macros

2024-07-01 Thread Thomas Huth
thrice in three different formats in the calls to DEFINE_I440FX_MACHINE. Signed-off-by: Daniel P. Berrangé --- hw/i386/pc_piix.c| 219 +++ include/hw/i386/pc.h | 26 + 2 files changed, 122 insertions(+), 123 deletions(-) Reviewed-by: Thomas Huth

Re: [PATCH 0/7] pc-bios/s390-ccw: Merge the netboot loader into s390-ccw.img

2024-07-01 Thread Thomas Huth
On 28/06/2024 20.01, Jared Rossi wrote: On 6/24/24 1:55 AM, Thomas Huth wrote: [...] I think it should be fine, both functions are basically just a wrapper around the write() function in sclp.c, with sclp_print() being rather dumb while printf() is doing the usual string formatting before

Re: [PATCH v3 15/17] tests/qtest: Disable npcm7xx_sdhci tests using hardcoded RCA

2024-06-27 Thread Thomas Huth
This g_test_skip here does not make too much sense (since you're doing it in the caller site, too) ... could you please replace it with a proper comment why this code needs to be reworked? Thanks! Thomas sdhci_cmd_regs(qts, NPCM7XX_MMC_BA

[PATCH] docs/system/devices/usb: Replace the non-existing "qemu" binary

2024-06-26 Thread Thomas Huth
We don't ship a binary that is simply called "qemu", so we should avoid this in the documentation. Use the configurable binary name via "|qemu_system|" instead. Signed-off-by: Thomas Huth --- docs/system/devices/usb.rst | 2 +- 1 file changed, 1 insertion(+), 1 delet

Re: [RFC PATCH v3 2/2] tests/qtest: QTest example for RISC-V CSR register

2024-06-26 Thread Thomas Huth
int csrno, uint64_t *val) +{ +uint64_t res = 0; + +res = qtest_csr_call(qts, name, cpu, csrno, val); + +return res; +} This wrapper function looks completely unnecessary, just call qtest_csr_call() everywhere directly instead? Thomas +static int qcsr_get_csr(QTestState

Re: [RFC PATCH v3 1/2] target/riscv: Add RISC-V CSR qtest support

2024-06-26 Thread Thomas Huth
t64_t qtest_csr_call(QTestState *s, const char *name, + uint64_t cpu, int csr, + unsigned long *val); + /** * qtest_bufread: * @s: #QTestState instance to operate on. For the tests/qtest part: Acked-by: Thomas Huth

Re: [PATCH] tests/avocado: add hotplug_blk test

2024-06-26 Thread Thomas Huth
cado: tags=arch:x86_64 +:avocado: tags=machine:q35 +:avocado: tags=accel:kvm +""" + self.require_accelerator('kvm') +self.vm.add_args('-accel', 'kvm') +self.vm.add_args('-device', 'pcie-pci-bridge,id=pci.1,bus=pcie.0') + +self.launch_and_wait() +self.blockdev_add() + +self.plug() +self.unplug() Reviewed-by: Thomas Huth

Re: [RFC PATCH] testing: restore some testing for i686

2024-06-25 Thread Thomas Huth
ould be ok to re-introduce this job. Partially revert but using the debian-i686 cross build images this time as fedora has deprecated the 32 bit stuff. Reported-by: Richard Henderson Suggested-by: Thomas Huth Signed-off-by: Alex Bennée --- .gitlab-ci.d/crossbuilds.yml | 10 ++ 1 fi

Re: Help improve 32-bit testing

2024-06-25 Thread Thomas Huth
nt to go a step backwards, then basically just revert commit 4f9a8315e65561bafa03651518aa5d22af09bdee and use the i686-debian-cross-container image instead of the removed i386-fedora-cross-container image. HTH, Thomas

Re: [PATCH 1/1] include/qemu: Provide a C++ compatible version of typeof_strip_qual

2024-06-24 Thread Thomas Huth
ur C++-enabled downstream repository. Thomas

Re: [PATCH] .travis.yml: Install python3-tomli in all build jobs

2024-06-24 Thread Thomas Huth
On 24/06/2024 12.09, Alex Bennée wrote: Thomas Huth writes: Since commit 1f97715c83 ('Revert "python: use vendored tomli"') this package is a hard requirement for compiling QEMU, so install it now in all Travis jobs, too. AFAICT the only repo currently running these

Re: [PATCH v2] scsi-disk: Fix crash for VM configured with USB CDROM after live migration

2024-06-24 Thread Thomas Huth
ty maybe rather be added to the "scsi-disk-base" class instead? Or should hw_compat_9_0 rather list the devices that have the property instead of using the parent class? Could you please have a look? Thanks, Thomas

[PATCH] .travis.yml: Install python3-tomli in all build jobs

2024-06-24 Thread Thomas Huth
Since commit 1f97715c83 ('Revert "python: use vendored tomli"') this package is a hard requirement for compiling QEMU, so install it now in all Travis jobs, too. Signed-off-by: Thomas Huth --- .travis.yml | 6 ++ 1 file changed, 6 insertions(+) diff --git a/.travis.yml

[PULL 05/11] vfio/ccw: Use the 'Error **errp' argument of vfio_ccw_realize()

2024-06-24 Thread Thomas Huth
Goater Reviewed-by: Zhenzhong Duan Reviewed-by: Anthony Krowiak Reviewed-by: Eric Farman Reviewed-by: Thomas Huth Message-ID: <20240522170107.289532-6-...@redhat.com> Signed-off-by: Thomas Huth --- hw/vfio/ccw.c | 12 +--- 1 file changed, 5 insertions(+), 7 deletions(-) diff --gi

[PULL 04/11] s390x/css: Make S390CCWDeviceClass::realize return bool

2024-06-24 Thread Thomas Huth
zhong Duan Reviewed-by: Anthony Krowiak Reviewed-by: Eric Farman Reviewed-by: Thomas Huth Message-ID: <20240522170107.289532-5-...@redhat.com> Signed-off-by: Thomas Huth --- include/hw/s390x/s390-ccw.h | 2 +- hw/s390x/s390-ccw.c | 7 --- hw/vfio/ccw.c | 3 +-- 3

[PULL 08/11] tests/qtest/fuzz: fix memleak in qos_fuzz.c

2024-06-24 Thread Thomas Huth
From: Dmitry Frolov Found with fuzzing for qemu-8.2, but also relevant for master Signed-off-by: Dmitry Frolov Reviewed-by: Thomas Huth Reviewed-by: Alexander Bulekov Message-ID: <20240521103106.119021-3-fro...@swemel.ru> Signed-off-by: Thomas Huth --- tests/qtest/fuzz/qos_fuzz.c |

[PULL 07/11] vfio/{ap, ccw}: Use warn_report_err() for IRQ notifier registration errors

2024-06-24 Thread Thomas Huth
: Zhenzhong Duan Reviewed-by: Anthony Krowiak Reviewed-by: Eric Farman Reviewed-by: Thomas Huth Message-ID: <20240522170107.289532-8-...@redhat.com> Signed-off-by: Thomas Huth --- hw/vfio/ap.c | 2 +- hw/vfio/ccw.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/vfi

[PULL 09/11] target/s390x/arch_dump: use correct byte order for pid

2024-06-24 Thread Thomas Huth
From: Omar Sandoval The pid field of prstatus needs to be big endian like all of the other fields. Fixes: f738f296eaae ("s390x/arch_dump: pass cpuid into notes sections") Signed-off-by: Omar Sandoval Reviewed-by: Thomas Huth Message-ID: <5929f76d536d355afd04af51bf293695a10651

[PULL 11/11] target/s390x: Add a CONFIG switch to disable legacy CPUs

2024-06-24 Thread Thomas Huth
used to disable them (and old machine types that use them by default). Message-Id: <20240614125019.588928-1-th...@redhat.com> Signed-off-by: Thomas Huth --- hw/s390x/s390-virtio-ccw.c | 5 + target/s390x/cpu_models.c | 9 + target/s390x/Kconfig | 5 + 3 files chang

[PULL 00/11] s390x and qtest patches 2024-06-24

2024-06-24 Thread Thomas Huth
r() for IRQ notifier registration errors Dmitry Frolov (1): tests/qtest/fuzz: fix memleak in qos_fuzz.c Omar Sandoval (1): target/s390x/arch_dump: use correct byte order for pid Thomas Huth (2): MAINTAINERS: Cover all tests/qtest/migration-* files target/s390x: Add a CONFIG switch to

[PULL 06/11] vfio/ccw: Fix the missed unrealize() call in error path

2024-06-24 Thread Thomas Huth
ric Farman Reviewed-by: Thomas Huth Message-ID: <20240522170107.289532-7-...@redhat.com> Signed-off-by: Thomas Huth --- hw/vfio/ccw.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/hw/vfio/ccw.c b/hw/vfio/ccw.c index a468fa2342..36f2677a44 100644 --- a/hw/vfio/ccw.c +++

[PULL 03/11] hw/s390x/ccw: Remove local Error variable from s390_ccw_realize()

2024-06-24 Thread Thomas Huth
From: Cédric Le Goater Use the 'Error **errp' argument of s390_ccw_realize() instead and remove the error_propagate() call. Signed-off-by: Cédric Le Goater Reviewed-by: Zhenzhong Duan Reviewed-by: Anthony Krowiak Reviewed-by: Eric Farman Reviewed-by: Thomas Huth

[PULL 10/11] MAINTAINERS: Cover all tests/qtest/migration-* files

2024-06-24 Thread Thomas Huth
thieu-Daudé Acked-by: Fabiano Rosas Reviewed-by: Peter Xu Signed-off-by: Thomas Huth --- MAINTAINERS | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index cef54de759..f144b5af44 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -3312,6 +3312,7 @@ F: test

[PULL 01/11] hw/s390x/ccw: Make s390_ccw_get_dev_info() return a bool

2024-06-24 Thread Thomas Huth
y: Anthony Krowiak Reviewed-by: Eric Farman Reviewed-by: Thomas Huth Message-ID: <20240522170107.289532-2-...@redhat.com> Signed-off-by: Thomas Huth --- hw/s390x/s390-ccw.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/hw/s390x/s390-ccw.c b/hw/s390x/

[PULL 02/11] s390x/css: Make CCWDeviceClass::realize return bool

2024-06-24 Thread Thomas Huth
zhong Duan Reviewed-by: Anthony Krowiak Reviewed-by: Eric Farman Reviewed-by: Thomas Huth Message-ID: <20240522170107.289532-3-...@redhat.com> Signed-off-by: Thomas Huth --- hw/s390x/ccw-device.h | 2 +- hw/s390x/ccw-device.c | 3 ++- hw/s390x/s390-ccw.c | 3 +-- 3 files changed, 4 insertions

[PATCH v3] vritio-net: Notify the guest with the latest available idx

2024-06-24 Thread thomas
Patch 06b12970174 ("virtio-net: fix network stall under load") added double-check to test whether the available buffer size can satisfy the request or not, in case the guest has added some buffers to the avail ring simultaneously after the first check. It will be lucky if the available buffer size

Re: [PATCH 0/2] arch_dump: fix prstatus pid on s390x and ppc

2024-06-23 Thread Thomas Huth
changed, 13 insertions(+), 10 deletions(-) I'm going to pick up patch 1 for my s390x tree ... for the second patch, it would be good if someone of the ppc guys could have a look at it first. Thomas

Re: [PATCH 0/7] pc-bios/s390-ccw: Merge the netboot loader into s390-ccw.img

2024-06-23 Thread Thomas Huth
On 21/06/2024 22.51, Eric Farman wrote: On Fri, 2024-06-21 at 10:24 +0200, Thomas Huth wrote: We originally built a separate binary for the netboot code since it was considered as experimental and we could not be sure that the necessary SLOF module had been checked out. Time passed, the netboot

Re: [PATCH v8 3/8] hw/misc/pvpanic: centralize definition of supported events

2024-06-21 Thread Thomas Weißschuh
On 2024-06-21 06:26:19+, Michael S. Tsirkin wrote: > On Mon, May 27, 2024 at 08:27:49AM +0200, Thomas Weißschuh wrote: > > diff --git a/hw/misc/pvpanic.c b/hw/misc/pvpanic.c > > index 1540e9091a45..a4982cc5928e 100644 > > --- a/hw/misc/pvpanic.c > > +++ b/hw/m

Re: [PATCH 0/7] pc-bios/s390-ccw: Merge the netboot loader into s390-ccw.img

2024-06-21 Thread Thomas Huth
not sure whether we want to commit this separately or wait 'til Jared finished his series, too). Sorry, I should have mentioned it in the cover letter. Thomas

Re: How to use designware-root-port and designware-root-host devices ?

2024-06-21 Thread Thomas Huth
pe", and/or possibly "you didn't tell the kernel to output on the serial port". By the way, it seems like we don't even have an avocado test for that machine available. Peter, do you know whether there is a kernel for this machine available somewhere that we could use for testing? Thomas

[PATCH 7/7] docs/system/s390x/bootdevices: Update the documentation about network booting

2024-06-21 Thread Thomas Huth
Remove the information about the separate s390-netboot.img from the documentation. Signed-off-by: Thomas Huth --- docs/system/s390x/bootdevices.rst | 20 +++- 1 file changed, 7 insertions(+), 13 deletions(-) diff --git a/docs/system/s390x/bootdevices.rst b/docs/system/s390x

[PATCH 5/7] hw/s390x: Remove the possibility to load the s390-netboot.img binary

2024-06-21 Thread Thomas Huth
Since the netboot code has now been merged into the main s390-ccw.img binary, we don't need the separate s390-netboot.img anymore. Remove it and the code that was responsible for loading it. Signed-off-by: Thomas Huth --- hw/s390x/ipl.h | 12 +++- hw/s390x/

[PATCH 3/7] pc-bios/s390-ccw: Use the libc from SLOF for the main s390-ccw.img binary, too

2024-06-21 Thread Thomas Huth
s390-ccw bios (see commit bf6903f6944f), we can drop the simple implementation and use the SLOF libc for the s390-ccw.img binary, too. Signed-off-by: Thomas Huth --- pc-bios/s390-ccw/netboot.mak | 3 -- pc-bios/s390-ccw/libc.h | 89 pc-bios/s390-ccw

[PATCH 4/7] pc-bios/s390-ccw: Link the netboot code into the main s390-ccw.img binary

2024-06-21 Thread Thomas Huth
device. Signed-off-by: Thomas Huth --- pc-bios/s390-ccw/netboot.mak | 14 -- pc-bios/s390-ccw/cio.h | 2 ++ pc-bios/s390-ccw/iplb.h | 4 ++-- pc-bios/s390-ccw/s390-ccw.h | 3 +++ pc-bios/s390-ccw/virtio.h| 1 - pc-bios/s390-ccw/bootmap.c | 2 +- pc-bios/s390-ccw

[PATCH 2/7] hw/s390x/ipl: Provide more memory to the s390-ccw.img firmware

2024-06-21 Thread Thomas Huth
emory assigned to the machine before blindly using it. Signed-off-by: Thomas Huth --- hw/s390x/ipl.c | 10 +- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/hw/s390x/ipl.c b/hw/s390x/ipl.c index e934bf89d1..9362de0b6f 100644 --- a/hw/s390x/ipl.c +++ b/hw/s390x/ipl.c @@ -45,6

[PATCH 6/7] pc-bios/s390-ccw: Merge netboot.mak into the main Makefile

2024-06-21 Thread Thomas Huth
Now that the netboot code has been merged into the main s390-ccw.img, it also does not make sense to keep the build rules in a separate file. Thus let's merge netboot.mak into the main Makefile. Signed-off-by: Thomas Huth --- pc-bios/s390-ccw/netboot.mak

[PATCH 1/7] pc-bios/s390-ccw: Remove duplicated LDFLAGS

2024-06-21 Thread Thomas Huth
The -Wl,-pie and -nostdlib flags are added to LDFLAGS twice. Merge the two lines to get rid of the duplicates. Signed-off-by: Thomas Huth --- pc-bios/s390-ccw/Makefile | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/pc-bios/s390-ccw/Makefile b/pc-bios/s390-ccw/Makefile

[PATCH 0/7] pc-bios/s390-ccw: Merge the netboot loader into s390-ccw.img

2024-06-21 Thread Thomas Huth
much sense anymore to keep the netboot code in a separate binary. To make it easier to support a more flexible boot process soon that supports more than one boot device via the bootindex properties, let's finally merge the netboot code into the main s390-ccw.img binary now. Thomas Huth (7): p

Re: How to use designware-root-port and designware-root-host devices ?

2024-06-20 Thread Thomas Huth
the code that creates the machine. Can you please help me to use designware-root-host/port devices ? It seems like the i.MX7 SABRE machine is using this device, so instead of "-M virt", you could have a try with "-M mcimx7d-sabre" (and a kernel that supports this machine) instead. HTH, Thomas

Re: [PATCH v2 09/14] include/hw: temporarily disable deletion of versioned machine types

2024-06-20 Thread Thomas Huth
rn; \ +} \ } \ } while (0) Reviewed-by: Thomas Huth

Re: [PATCH v2 09/12] plugins: add migration blocker

2024-06-20 Thread Thomas Huth
"TCG plugin time control does not support migration"); +migrate_add_blocker(&migration_blocker, NULL); +#endif return &has_control; } return NULL; Reviewed-by: Thomas Huth

Re: [PATCH 5/5] s390x: Enable and document boot device fallback on panic

2024-06-20 Thread Thomas Huth
On 17/06/2024 16.49, Christian Borntraeger wrote: Am 05.06.24 um 15:37 schrieb Thomas Huth: On 29/05/2024 17.43, jro...@linux.ibm.com wrote: From: Jared Rossi On a panic during IPL (i.e. a device failed to boot) check for another device to boot from, as indicated by the presence of an

Re: [PATCH 5/5] s390x: Enable and document boot device fallback on panic

2024-06-20 Thread Thomas Huth
On 17/06/2024 01.44, Jared Rossi wrote: On 6/7/24 1:57 AM, Thomas Huth wrote: On 05/06/2024 16.48, Jared Rossi wrote: diff --git a/pc-bios/s390-ccw/s390-ccw.h b/pc-bios/s390-ccw/s390-ccw.h index c977a52b50..de3d1f0d5a 100644 --- a/pc-bios/s390-ccw/s390-ccw.h +++ b/pc-bios/s390-ccw/s390

Re: [PATCH] configure: detect --cpu=mipsisa64r6

2024-06-19 Thread Thomas Huth
On 19/06/2024 15.34, Paolo Bonzini wrote: On Wed, Jun 19, 2024 at 2:49 PM Thomas Huth wrote: On 19/06/2024 13.46, Paolo Bonzini wrote: Treat it as a MIPS64 machine. ... diff --git a/configure b/configure index d0703ea279d..3669eec86e5 100755 --- a/configure +++ b/configure @@ -452,7 +452,7

Re: [PATCH] hw/core: Rename CpuTopology to CPUTopology

2024-06-19 Thread Thomas Huth
cceptable to me... ... but in case somebody else wants to merge this, FWIW: s390x parts Acked-by: Thomas Huth On Mon, May 27, 2024 at 09:18:37PM +0800, Zhao Liu wrote: Date: Mon, 27 May 2024 21:18:37 +0800 From: Zhao Liu Subject: [PATCH] hw/core: Rename CpuTopology to CPUTopology X-Mailer:

[PATCH] hw/intc/s390_flic: Fix interrupt controller migration on s390x with TCG

2024-06-19 Thread Thomas Huth
e, so s390_cpu_exec_interrupt falls through to halting again." Thus let's finally migrate the pending state, and to be on the safe side, also the other state variables of the QEMUS390FLICState structure. Signed-off-by: Thomas Huth --- Once this has been merged, we can enable the migration-t

Re: [PATCH] configure: detect --cpu=mipsisa64r6

2024-06-19 Thread Thomas Huth
+++ b/configure @@ -452,7 +452,7 @@ case "$cpu" in linux_arch=loongarch ;; - mips64*) + mips64*|mipsisa64*) Maybe simply switch to mips*64*) ? cpu=mips64 host_arch=mips linux_arch=mips Thomas

Re: [PATCH 2/2] target/ppc/arch_dump: set prstatus pid to cpuid

2024-06-18 Thread Thomas Huth
d); note_size = sizeof(arg.note) - sizeof(arg.note.contents) + nf->contents_size; Reviewed-by: Thomas Huth

Re: [PATCH 1/2] target/s390x/arch_dump: use correct byte order for pid

2024-06-18 Thread Thomas Huth
gs->acrs[i] = cpu_to_be32(cpu->env.aregs[i]); regs->gprs[i] = cpu_to_be64(cpu->env.regs[i]); } -note->contents.prstatus.pid = id; +note->contents.prstatus.pid = cpu_to_be32(id); } static void s390x_write_elf64_fpregset(Note *note, S390CPU *cpu, int id) Reviewed-by: Thomas Huth

[PATCH] MAINTAINERS: Cover all tests/qtest/migration-* files

2024-06-18 Thread Thomas Huth
ready. Since the test is under very active development, it was causing a lot of distraction to the generic qtest maintainers with regards to the patches that need to be reviewed by the migration maintainers anyway. Signed-off-by: Thomas Huth --- MAINTAINERS | 3 ++- 1 file changed, 2 insertions(

Re: [PATCH v2 0/2] target/s390x: Fix tracing header path in TCG mem_helper.c

2024-06-18 Thread Thomas Huth
vents | 4 target/s390x/trace-events | 4 6 files changed, 47 insertions(+), 25 deletions(-) Series Reviewed-by: Thomas Huth

[PATCH] hw/virtio: Fix the de-initialization of vhost-user devices

2024-06-18 Thread Thomas Huth
he same purpose, it should be fine to fix it in this central place there without any risk to change the behavior of other code. Fixes: 9f6bcfd99f ("hw/virtio: move vm_running check to virtio_device_started") Buglink: https://issues.redhat.com/browse/RHEL-40708 Signed-off-by: Thomas Huth ---

Re: [RFC PATCH v2 1/2] Add RISC-V CSR qtest support

2024-06-18 Thread Thomas Huth
64_t cpu, int csr, + uint64_t *val) +{ +qtest_sendf(s, "csr %s 0x%"PRIx64" %d 0x%"PRIx64"\n", +name, cpu, csr, *val); + +qtest_rsp_csr(s, val); Just a matter of taste, but I think I'd rather inline the contents of qtest_rsp_csr() here since both functions are not very big yet. (unless you need qtest_rsp_csr() in another function later, then it's of course better to keep it separate) +return 0; +} Thomas

[PATCH v2] Update event idx if guest has made extra buffers during double check

2024-06-16 Thread thomas
If guest has made some buffers available during double check, but the total buffer size available is lower than @bufsize, notify the guest with the latest available idx(event idx) seen by the host. Fixes: 06b12970174 ("virtio-net: fix network stall under load") Signed-off-by: wencheng Yang --- h

[PATCH v2] target/s390x: Add a CONFIG switch to disable legacy CPUs

2024-06-14 Thread Thomas Huth
used to disable them (and old machine types that use them by default). Signed-off-by: Thomas Huth --- v2: - Add comment in source code - Only consider z9 and older as legacy hw/s390x/s390-virtio-ccw.c | 5 + target/s390x/cpu_models.c | 9 + target/s390x/Kconfig | 5 +

Re: [PATCH] target/s390x: Add a CONFIG switch to disable legacy CPUs

2024-06-14 Thread Thomas Huth
On 14/06/2024 10.17, Christian Borntraeger wrote: Am 14.06.24 um 09:15 schrieb Thomas Huth: On 14/06/2024 08.07, Christian Borntraeger wrote: Am 13.06.24 um 19:07 schrieb Thomas Huth: Old CPU models are not officially supported anymore by IBM, and for downstream builds of QEMU, we would

Re: [PATCH] target/s390x: Add a CONFIG switch to disable legacy CPUs

2024-06-14 Thread Thomas Huth
On 14/06/2024 08.07, Christian Borntraeger wrote: Am 13.06.24 um 19:07 schrieb Thomas Huth: Old CPU models are not officially supported anymore by IBM, and for downstream builds of QEMU, we would like to be able to disable these CPUs in the build. Thus add a CONFIG switch that can be used to

Re: [PATCH] target/s390x: Add a CONFIG switch to disable legacy CPUs

2024-06-13 Thread Thomas Huth
On 13/06/2024 19.17, Philippe Mathieu-Daudé wrote: Hi Thomas, On 13/6/24 19:07, Thomas Huth wrote: Old CPU models are not officially supported anymore by IBM, and for downstream builds of QEMU, we would like to be able to disable these CPUs in the build. Thus add a CONFIG switch that can be

Re: [PATCH] tests/qtest/fuzz/virtio_net_fuzz.c: fix virtio_net_fuzz_multi

2024-06-13 Thread Thomas Huth
On 13/06/2024 13.59, Дмитрий Фролов wrote: On 13.06.2024 13:08, Thomas Huth wrote: On 23/05/2024 12.28, Dmitry Frolov wrote: If QTestState was already CLOSED due to error, calling qtest_clock_step() afterwards makes no sense and only raises false-crash with message: "assertion timer !=

[PATCH] target/s390x: Add a CONFIG switch to disable legacy CPUs

2024-06-13 Thread Thomas Huth
Old CPU models are not officially supported anymore by IBM, and for downstream builds of QEMU, we would like to be able to disable these CPUs in the build. Thus add a CONFIG switch that can be used to disable these CPUs (and old machine types that use them by default). Signed-off-by: Thomas Huth

Re: [PATCH] tests/qtest/fuzz/virtio_net_fuzz.c: fix virtio_net_fuzz_multi

2024-06-13 Thread Thomas Huth
) ? ... or where does the QTestState get closed? During flush_events() ? Thomas

Re: [PATCH 2/2] QTest example for RISC-V CSR register

2024-06-13 Thread Thomas Huth
; You don't need --nographic, it's been taken care off by the libqtest framework already. +g_test_run(); + +qtest_quit(global_qtest); + +return 0; You should return the result of g_test_run() here, otherwise your test will look like it always succeeds. +} Thomas

Re: [PATCH] tests/qtest/fuzz: fix memleak in qos_fuzz.c

2024-06-13 Thread Thomas Huth
); } Reviewed-by: Thomas Huth

Re: Qemu License question

2024-06-13 Thread Thomas Huth
GPLv2 as intended). Maybe it could be included in the stable releases before 9.0, too? CC:-ing qemu-stable for this now. Thomas

[PATCH] Update event idx if guest has made extra buffers during double check

2024-06-12 Thread thomas
Fixes: 06b12970174 ("virtio-net: fix network stall under load") If guest has made some buffers available during double check, but the total buffer size available is lower than @bufsize, notify the guest with the latest available idx(event idx) seen by the host. --- hw/net/virtio-net.c | 1 + 1 fi

[PULL 13/15] tests/unit/test-smp-parse: Test "modules" and "dies" combination case

2024-06-12 Thread Thomas Huth
25.350323-8-zhao1@intel.com> Signed-off-by: Thomas Huth --- tests/unit/test-smp-parse.c | 103 1 file changed, 103 insertions(+) diff --git a/tests/unit/test-smp-parse.c b/tests/unit/test-smp-parse.c index 01832e5eda..2ca8530e93 100644 --- a/tests/u

[PULL 03/15] tests/qtest/libqtest: add qtest_has_cpu_model() api

2024-06-12 Thread Thomas Huth
older cpu models after checking if QEMU actually supported these models. Signed-off-by: Ani Sinha Reviewed-by: Reviewed-by: Daniel P. Berrangé Message-ID: <20240610155303.7933-3-anisi...@redhat.com> Signed-off-by: Thomas Huth --- tests/qtest/libqtest.h | 8 tests/qtest/libqtest.

[PULL 15/15] tests/tcg/s390x: Allow specifying extra QEMU options on the command line

2024-06-12 Thread Thomas Huth
t with the other architectures. Signed-off-by: Ilya Leoshkevich Reviewed-by: Thomas Huth Message-ID: <20240522184116.35975-1-...@linux.ibm.com> Signed-off-by: Thomas Huth --- tests/tcg/s390x/Makefile.softmmu-target | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a

[PULL 04/15] tests/qtest/x86: check for availability of older cpu models before running tests

2024-06-12 Thread Thomas Huth
: <20240610155303.7933-4-anisi...@redhat.com> Signed-off-by: Thomas Huth --- tests/qtest/test-x86-cpuid-compat.c | 170 ++-- 1 file changed, 108 insertions(+), 62 deletions(-) diff --git a/tests/qtest/test-x86-cpuid-compat.c b/tests/qtest/test-x86-cpuid-compat.c index 6a394

[PULL 14/15] tests/unit/test-smp-parse: Test the full 8-levels topology hierarchy

2024-06-12 Thread Thomas Huth
From: Zhao Liu With module level, QEMU now support 8-levels topology hierarchy. Cover "modules" in SMP_CONFIG_WITH_FULL_TOPO related cases. Signed-off-by: Zhao Liu Tested-by: Yongwei Ma Message-ID: <20240529061925.350323-9-zhao1@intel.com> Signed-off-by: Thomas Huth ---

[PULL 12/15] tests/unit/test-smp-parse: Test "modules" parameter in -smp

2024-06-12 Thread Thomas Huth
From: Zhao Liu Cover the module cases in test-smp-parse. Signed-off-by: Zhao Liu Tested-by: Yongwei Ma Message-ID: <20240529061925.350323-7-zhao1@intel.com> Signed-off-by: Thomas Huth --- tests/unit/test-smp-parse.c | 112 +--- 1 file change

[PULL 00/15] CPU-related test updates

2024-06-12 Thread Thomas Huth
The following changes since commit 80e8f0602168f451a93e71cbb1d59e93d745e62e: Merge tag 'bsd-user-misc-2024q2-pull-request' of gitlab.com:bsdimp/qemu into staging (2024-06-09 11:21:55 -0700) are available in the Git repository at: https://gitlab.com/thuth/qemu.git tags/pull-request-2024-06-1

<    5   6   7   8   9   10   11   12   13   14   >