On Mon, 25 Apr 2022 at 06:47, Markus Armbruster wrote:
>
> Gautam Agrawal writes:
>
> > This patch is in regards to this
> > issue:https://gitlab.com/qemu-project/qemu/-/issues/581#.
> > A global boolean variable "vga_interface_created"(declared in
> > softmmu/globals.c)
> > has been used to
Gautam Agrawal writes:
> This patch is in regards to this
> issue:https://gitlab.com/qemu-project/qemu/-/issues/581#.
> A global boolean variable "vga_interface_created"(declared in
> softmmu/globals.c)
> has been used to track the creation of vga interface. If the vga flag is
> passed in the
Hi,
On 12/04/2022 22.25, Gautam Agrawal wrote:
[...]>> On 08/04/2022 12.45, Gautam Agrawal wrote:
This patch is in regards to this
issue:https://gitlab.com/qemu-project/qemu/-/issues/581#.
Better write this right in front of your Signed-off-by line:
Resolves:
hi,
> thanks for your patch, looks pretty good already, but there is a small
> issue: Try for example:
>
> ./qemu-system-s390x -vga none
>
> ... and it will print the warning "qemu-system-s390x: warning: No vga device
> is created", though the user only asked for no VGA device. This seems to
>
On Tue, 12 Apr 2022 at 13:13, Thomas Huth wrote:
> On 08/04/2022 12.45, Gautam Agrawal wrote:
> > +if (!vga_interface_created && !default_vga) {
> > +warn_report("No vga device is created");
>
> I'm not a native speaker, and maybe it's just a matter of taste, but I'd
> rather say it
Hi,
thanks for your patch, looks pretty good already, but there is a small
issue: Try for example:
./qemu-system-s390x -vga none
... and it will print the warning "qemu-system-s390x: warning: No vga device
is created", though the user only asked for no VGA device. This seems to
happen
This patch is in regards to this
issue:https://gitlab.com/qemu-project/qemu/-/issues/581#.
A global boolean variable "vga_interface_created"(declared in softmmu/globals.c)
has been used to track the creation of vga interface. If the vga flag is passed
in the command
line "default_vga"(declared
