Re: [PATCH 05/22] hw/arm: Select VIRTIO_NET for virt machine

2023-05-09 Thread Paolo Bonzini
On 5/9/23 13:37, Alex Bennée wrote: Then, an accurate description that uses "functional" in that sense could be as follows: The Kconfig system will include any devices and subsystems that are mandatory for a given machine type, and will flag any configuration conflicts. However, the person

Re: [PATCH 05/22] hw/arm: Select VIRTIO_NET for virt machine

2023-05-09 Thread Alex Bennée
Paolo Bonzini writes: > On 5/9/23 12:00, Peter Maydell wrote: >> On Tue, 9 May 2023 at 10:42, Paolo Bonzini wrote: >>> >>> On 5/9/23 11:27, Peter Maydell wrote: On Mon, 8 May 2023 at 23:24, Paolo Bonzini wrote: > --without-default-devices is not about choosing to not build > some

Re: [PATCH 05/22] hw/arm: Select VIRTIO_NET for virt machine

2023-05-09 Thread Paolo Bonzini
On 5/9/23 12:00, Peter Maydell wrote: On Tue, 9 May 2023 at 10:42, Paolo Bonzini wrote: On 5/9/23 11:27, Peter Maydell wrote: On Mon, 8 May 2023 at 23:24, Paolo Bonzini wrote: --without-default-devices is not about choosing to not build some devices; it is about making non-selected devices

Re: [PATCH 05/22] hw/arm: Select VIRTIO_NET for virt machine

2023-05-09 Thread Peter Maydell
On Tue, 9 May 2023 at 10:42, Paolo Bonzini wrote: > > On 5/9/23 11:27, Peter Maydell wrote: > > On Mon, 8 May 2023 at 23:24, Paolo Bonzini wrote: > >> --without-default-devices is not about choosing to not build > >> some devices; it is about making non-selected devices opt-in > >> rather than op

Re: [PATCH 05/22] hw/arm: Select VIRTIO_NET for virt machine

2023-05-09 Thread Paolo Bonzini
On 5/9/23 11:27, Peter Maydell wrote: On Mon, 8 May 2023 at 23:24, Paolo Bonzini wrote: --without-default-devices is not about choosing to not build some devices; it is about making non-selected devices opt-in rather than opt-out. Hmm, so it's basically "the person doing the configuration nee

Re: [PATCH 05/22] hw/arm: Select VIRTIO_NET for virt machine

2023-05-09 Thread Peter Maydell
On Mon, 8 May 2023 at 23:24, Paolo Bonzini wrote: > --without-default-devices is not about choosing to not build > some devices; it is about making non-selected devices opt-in > rather than opt-out. Hmm, so it's basically "the person doing the configuration needs to know what they're doing, the K

Re: [PATCH 05/22] hw/arm: Select VIRTIO_NET for virt machine

2023-05-08 Thread Paolo Bonzini
Il gio 4 mag 2023, 14:56 Fabiano Rosas ha scritto: > > It's a bit hard to maintain the original intention with just > documentation. Couldn't we require that --without-default-devices always > be accompanied by --with-devices? Maybe, but why would it be bad to just patch the default .mak file?

Re: [PATCH 05/22] hw/arm: Select VIRTIO_NET for virt machine

2023-05-04 Thread Fabiano Rosas
Paolo Bonzini writes: > On 5/3/23 20:32, Peter Maydell wrote: >> Do we really want to build a QEMU that then barfs unless >> you pass -nodefaults, though ? That doesn't seem very useful. >> Something somewhere ought to be saying "if you want the >> virt board then you almost certainly want these"

Re: [PATCH 05/22] hw/arm: Select VIRTIO_NET for virt machine

2023-05-04 Thread Paolo Bonzini
On 5/3/23 20:32, Peter Maydell wrote: Do we really want to build a QEMU that then barfs unless you pass -nodefaults, though ? That doesn't seem very useful. Something somewhere ought to be saying "if you want the virt board then you almost certainly want these". Well, the point is that --withou

Re: [PATCH 05/22] hw/arm: Select VIRTIO_NET for virt machine

2023-05-04 Thread Alex Bennée
Thomas Huth writes: > On 03/05/2023 20.32, Peter Maydell wrote: >> On Wed, 3 May 2023 at 18:06, Paolo Bonzini wrote: >>> >>> On 5/3/23 17:35, Alex Bennée wrote: > You should select a device only if you cannot even start > the machine without --nodefaults. Which is the case he

Re: [PATCH 05/22] hw/arm: Select VIRTIO_NET for virt machine

2023-05-03 Thread Thomas Huth
On 03/05/2023 20.32, Peter Maydell wrote: On Wed, 3 May 2023 at 18:06, Paolo Bonzini wrote: On 5/3/23 17:35, Alex Bennée wrote: You should select a device only if you cannot even start the machine without --nodefaults. Which is the case here right? We could skip tests that explicitly instan

Re: [PATCH 05/22] hw/arm: Select VIRTIO_NET for virt machine

2023-05-03 Thread Peter Maydell
On Wed, 3 May 2023 at 18:06, Paolo Bonzini wrote: > > On 5/3/23 17:35, Alex Bennée wrote: > >> You should select a device only if you cannot even start > >> the machine without --nodefaults. > > > > Which is the case here right? We could skip tests that explicitly > > instantiate a device but thes

Re: [PATCH 05/22] hw/arm: Select VIRTIO_NET for virt machine

2023-05-03 Thread Paolo Bonzini
On 5/3/23 17:35, Alex Bennée wrote: You should select a device only if you cannot even start the machine without --nodefaults. Which is the case here right? We could skip tests that explicitly instantiate a device but these are tests failing with default devices the machine tries to instantiate

Re: [PATCH 05/22] hw/arm: Select VIRTIO_NET for virt machine

2023-05-03 Thread Alex Bennée
Paolo Bonzini writes: > On 5/3/23 11:12, Alex Bennée wrote: >> From: Fabiano Rosas >> The 'virt' machine uses virtio-net-pci as a fallback when no other >> network driver has been selected via command line. Select VIRTIO_NET >> and VIRTIO_PCI from CONFIG_ARM_VIRT to avoid errors when PCI_DEVIC

Re: [PATCH 05/22] hw/arm: Select VIRTIO_NET for virt machine

2023-05-03 Thread Fabiano Rosas
Paolo Bonzini writes: > On 5/3/23 11:12, Alex Bennée wrote: >> From: Fabiano Rosas >> >> The 'virt' machine uses virtio-net-pci as a fallback when no other >> network driver has been selected via command line. Select VIRTIO_NET >> and VIRTIO_PCI from CONFIG_ARM_VIRT to avoid errors when PCI_DEV

Re: [PATCH 05/22] hw/arm: Select VIRTIO_NET for virt machine

2023-05-03 Thread Paolo Bonzini
On 5/3/23 11:12, Alex Bennée wrote: From: Fabiano Rosas The 'virt' machine uses virtio-net-pci as a fallback when no other network driver has been selected via command line. Select VIRTIO_NET and VIRTIO_PCI from CONFIG_ARM_VIRT to avoid errors when PCI_DEVICES=n (due to e.g. --without-default-d

Re: [PATCH 05/22] hw/arm: Select VIRTIO_NET for virt machine

2023-05-03 Thread Richard Henderson
On 5/3/23 10:12, Alex Bennée wrote: From: Fabiano Rosas The 'virt' machine uses virtio-net-pci as a fallback when no other network driver has been selected via command line. Select VIRTIO_NET and VIRTIO_PCI from CONFIG_ARM_VIRT to avoid errors when PCI_DEVICES=n (due to e.g. --without-default-de

[PATCH 05/22] hw/arm: Select VIRTIO_NET for virt machine

2023-05-03 Thread Alex Bennée
From: Fabiano Rosas The 'virt' machine uses virtio-net-pci as a fallback when no other network driver has been selected via command line. Select VIRTIO_NET and VIRTIO_PCI from CONFIG_ARM_VIRT to avoid errors when PCI_DEVICES=n (due to e.g. --without-default-devices): $ ./qemu-system-aarch64 -M v