Re: [PATCH 1/2] qom: Rename Object::class into Object::klass

On Tue, Jun 25, 2024 at 10:23:54AM +0100, Peter Maydell wrote: > On Tue, 25 Jun 2024 at 03:20, Philippe Mathieu-Daudé > wrote: > > Since you are posting different C++ enablement cleanups, > > I suggest you add a section in our docs/devel/style.rst > > requesting to keep headers C++ compatible, by

Re: [PATCH 1/2] qom: Rename Object::class into Object::klass

On Tue, 25 Jun 2024 at 03:20, Philippe Mathieu-Daudé wrote: > Since you are posting different C++ enablement cleanups, > I suggest you add a section in our docs/devel/style.rst > requesting to keep headers C++ compatible, by not using > C++ reserved keywords, etc... > > In particular because the m

Re: [PATCH 1/2] qom: Rename Object::class into Object::klass

On Mon, Jun 24, 2024 at 08:43:59PM +, Felix Wu wrote: > From: Roman Kiryanov > > 'class' is a C++ keyword and it prevents from > using the QEMU headers with a C++ compiler. > > Google-Bug-Id: 331190993 > Change-Id: I9ab7d2d77edef654a9c7b7cb9cd01795a6ed65a2 Please remove both of these lines

Re: [PATCH 1/2] qom: Rename Object::class into Object::klass

Hi Felix, On 24/6/24 22:43, Felix Wu wrote: From: Roman Kiryanov 'class' is a C++ keyword and it prevents from using the QEMU headers with a C++ compiler. Google-Bug-Id: 331190993 I asked Roman twice about this tag meaning: https://lore.kernel.org/qemu-devel/e865d8e3-e768-4b1f-86d3-aeabe8f1

[PATCH 1/2] qom: Rename Object::class into Object::klass

From: Roman Kiryanov 'class' is a C++ keyword and it prevents from using the QEMU headers with a C++ compiler. Google-Bug-Id: 331190993 Change-Id: I9ab7d2d77edef654a9c7b7cb9cd01795a6ed65a2 Signed-off-by: Felix Wu Signed-off-by: Roman Kiryanov --- hw/core/qdev-properties-system.c | 2 +- incl