Re: [Qemu-devel] [PATCH] Do not try loading option ROM for hotplug PCI device in pc-0.11 compat mode

2010-07-31 Thread Aurelien Jarno
On Sat, Jul 31, 2010 at 05:21:34PM +0200, Jes Sorensen wrote: > On 07/31/10 17:13, Aurelien Jarno wrote: > > On Sat, Jul 31, 2010 at 04:40:05PM +0200, Jes Sorensen wrote: > >> If you want that, please do it in a separate patch for the entire file, > >> otherwise it will never become consistent. How

Re: [Qemu-devel] [PATCH] Do not try loading option ROM for hotplug PCI device in pc-0.11 compat mode

2010-07-31 Thread Jes Sorensen
On 07/31/10 17:13, Aurelien Jarno wrote: > On Sat, Jul 31, 2010 at 04:40:05PM +0200, Jes Sorensen wrote: >> If you want that, please do it in a separate patch for the entire file, >> otherwise it will never become consistent. However it doesn't change the >> issue either that putting braces around

Re: [Qemu-devel] [PATCH] Do not try loading option ROM for hotplug PCI device in pc-0.11 compat mode

2010-07-31 Thread Aurelien Jarno
On Sat, Jul 31, 2010 at 04:40:05PM +0200, Jes Sorensen wrote: > On 07/31/10 16:19, Aurelien Jarno wrote: > > On Sat, Jul 31, 2010 at 11:16:45AM +0200, Jes Sorensen wrote: > >> On 07/30/10 23:08, Aurelien Jarno wrote: > >>> Missing braces around the return 0 line. > >> > >> Half the QEMU code base

Re: [Qemu-devel] [PATCH] Do not try loading option ROM for hotplug PCI device in pc-0.11 compat mode

2010-07-31 Thread Jes Sorensen
On 07/31/10 16:19, Aurelien Jarno wrote: > On Sat, Jul 31, 2010 at 11:16:45AM +0200, Jes Sorensen wrote: >> On 07/30/10 23:08, Aurelien Jarno wrote: >>> Missing braces around the return 0 line. >> >> Half the QEMU code base doesn't have braces around single line if >> statements, including in hw/p

Re: [Qemu-devel] [PATCH] Do not try loading option ROM for hotplug PCI device in pc-0.11 compat mode

2010-07-31 Thread Aurelien Jarno
On Sat, Jul 31, 2010 at 11:16:45AM +0200, Jes Sorensen wrote: > On 07/30/10 23:08, Aurelien Jarno wrote: > > On Fri, Jul 23, 2010 at 05:56:38PM +0200, jes.soren...@redhat.com wrote: > >> From: Jes Sorensen > >> > >> pc-0.11 and older uses fw_cfg to provide option ROMs. As fw_cfg is setup > >> at i

Re: [Qemu-devel] [PATCH] Do not try loading option ROM for hotplug PCI device in pc-0.11 compat mode

2010-07-31 Thread Jes Sorensen
On 07/30/10 23:08, Aurelien Jarno wrote: > On Fri, Jul 23, 2010 at 05:56:38PM +0200, jes.soren...@redhat.com wrote: >> From: Jes Sorensen >> >> pc-0.11 and older uses fw_cfg to provide option ROMs. As fw_cfg is setup >> at init time, it is not possible to load an option ROM for a hotplug >> device

Re: [Qemu-devel] [PATCH] Do not try loading option ROM for hotplug PCI device in pc-0.11 compat mode

2010-07-30 Thread Aurelien Jarno
On Fri, Jul 23, 2010 at 05:56:38PM +0200, jes.soren...@redhat.com wrote: > From: Jes Sorensen > > pc-0.11 and older uses fw_cfg to provide option ROMs. As fw_cfg is setup > at init time, it is not possible to load an option ROM for a hotplug > device when running in compat mode. > > v2: Alex Wil

[Qemu-devel] [PATCH] Do not try loading option ROM for hotplug PCI device in pc-0.11 compat mode

2010-07-23 Thread Jes . Sorensen
From: Jes Sorensen pc-0.11 and older uses fw_cfg to provide option ROMs. As fw_cfg is setup at init time, it is not possible to load an option ROM for a hotplug device when running in compat mode. v2: Alex Williamson pointed out that one can get to qdev directly from pci_dev, so no need to pass

Re: [Qemu-devel] [PATCH] Do not try loading option ROM for hotplug PCI device in pc-0.11 compat mode

2010-07-23 Thread Markus Armbruster
jes.soren...@redhat.com writes: > From: Jes Sorensen > > pc-0.11 and older uses fw_cfg to provide option ROMs. As fw_cfg is setup > at init time, it is not possible to load an option ROM for a hotplug > device when running in compat mode. Example: $ qemu -M pc-0.11 -S -monitor stdio QEM

[Qemu-devel] [PATCH] Do not try loading option ROM for hotplug PCI device in pc-0.11 compat mode

2010-07-23 Thread Jes . Sorensen
From: Jes Sorensen pc-0.11 and older uses fw_cfg to provide option ROMs. As fw_cfg is setup at init time, it is not possible to load an option ROM for a hotplug device when running in compat mode. Signed-off-by: Jes Sorensen --- hw/pci.c | 14 +- 1 files changed, 9 insertions(+),