Re: [Qemu-devel] [PATCH] Exynos4: added RTC device

2012-07-02 Thread Andreas Färber
Am 02.07.2012 11:37, schrieb Paolo Bonzini: > Il 02/07/2012 11:31, Peter Maydell ha scritto: >> On 2 July 2012 10:08, Igor Mitsyanko wrote: >>> So, what's the consensus here, for now new devices go to >>> hw/arm/Makefile.objs while somebody moves all new and old not cpu-specific >>> devices (not j

Re: [Qemu-devel] [PATCH] Exynos4: added RTC device

2012-07-02 Thread Peter Maydell
On 2 July 2012 13:04, Andreas Färber wrote: > Am 02.07.2012 11:31, schrieb Peter Maydell: >> On 2 July 2012 10:08, Igor Mitsyanko wrote: >>> So, what's the consensus here, for now new devices go to >>> hw/arm/Makefile.objs while somebody moves all new and old not cpu-specific >>> devices (not jus

Re: [Qemu-devel] [PATCH] Exynos4: added RTC device

2012-07-02 Thread Igor Mitsyanko
On 07/02/2012 03:44 PM, Andreas Färber wrote: Am 01.07.2012 17:26, schrieb Paolo Bonzini: Il 29/06/2012 14:26, Andreas Färber ha scritto: Oh, I see. Should we place this device to hw/Makefile.objs in v2? That would've been nice, but I'll do it as a follow-up now. Yes, so we can also use Ant

Re: [Qemu-devel] [PATCH] Exynos4: added RTC device

2012-07-02 Thread Andreas Färber
Am 02.07.2012 11:31, schrieb Peter Maydell: > On 2 July 2012 10:08, Igor Mitsyanko wrote: >> So, what's the consensus here, for now new devices go to >> hw/arm/Makefile.objs while somebody moves all new and old not cpu-specific >> devices (not just exynos-related) from hw/arm/Makefile.objs to >> h

Re: [Qemu-devel] [PATCH] Exynos4: added RTC device

2012-07-02 Thread Andreas Färber
Am 01.07.2012 17:26, schrieb Paolo Bonzini: > Il 29/06/2012 14:26, Andreas Färber ha scritto: Oh, I see. Should we place this device to hw/Makefile.objs in v2? >> That would've been nice, but I'll do it as a follow-up now. > > Yes, so we can also use Anthony's new CONFIG_ARCH_ARM (introd

Re: [Qemu-devel] [PATCH] Exynos4: added RTC device

2012-07-02 Thread Paolo Bonzini
Il 02/07/2012 11:37, Paolo Bonzini ha scritto: > Il 02/07/2012 11:31, Peter Maydell ha scritto: >> On 2 July 2012 10:08, Igor Mitsyanko wrote: >>> So, what's the consensus here, for now new devices go to >>> hw/arm/Makefile.objs while somebody moves all new and old not cpu-specific >>> devices (no

Re: [Qemu-devel] [PATCH] Exynos4: added RTC device

2012-07-02 Thread Paolo Bonzini
Il 02/07/2012 11:44, Peter Maydell ha scritto: > On 2 July 2012 10:42, Paolo Bonzini wrote: >> > Personally, I believe it'd be best if board descriptions were moved to >> > hw/ARCH, even if all the required hardware is in hw/ and even if the >> > file can be moved from obj-y to hw-obj-y. However,

Re: [Qemu-devel] [PATCH] Exynos4: added RTC device

2012-07-02 Thread Peter Maydell
On 2 July 2012 10:42, Paolo Bonzini wrote: > Personally, I believe it'd be best if board descriptions were moved to > hw/ARCH, even if all the required hardware is in hw/ and even if the > file can be moved from obj-y to hw-obj-y.  However, this can be left > open to later discussion, and is compl

Re: [Qemu-devel] [PATCH] Exynos4: added RTC device

2012-07-02 Thread Paolo Bonzini
Il 02/07/2012 11:31, Peter Maydell ha scritto: > On 2 July 2012 10:08, Igor Mitsyanko wrote: >> So, what's the consensus here, for now new devices go to >> hw/arm/Makefile.objs while somebody moves all new and old not cpu-specific >> devices (not just exynos-related) from hw/arm/Makefile.objs to >

Re: [Qemu-devel] [PATCH] Exynos4: added RTC device

2012-07-02 Thread Peter Maydell
On 2 July 2012 10:08, Igor Mitsyanko wrote: > So, what's the consensus here, for now new devices go to > hw/arm/Makefile.objs while somebody moves all new and old not cpu-specific > devices (not just exynos-related) from hw/arm/Makefile.objs to > hw/Makefile.objs with one commit? Because having on

Re: [Qemu-devel] [PATCH] Exynos4: added RTC device

2012-07-02 Thread Igor Mitsyanko
On 07/01/2012 07:26 PM, Paolo Bonzini wrote: Il 29/06/2012 14:26, Andreas Färber ha scritto: Oh, I see. Should we place this device to hw/Makefile.objs in v2? That would've been nice, but I'll do it as a follow-up now. Yes, so we can also use Anthony's new CONFIG_ARCH_ARM (introducing CONFIG

Re: [Qemu-devel] [PATCH] Exynos4: added RTC device

2012-07-01 Thread Paolo Bonzini
Il 29/06/2012 14:26, Andreas Färber ha scritto: >> > >> > Oh, I see. Should we place this device to hw/Makefile.objs in v2? > That would've been nice, but I'll do it as a follow-up now. Yes, so we can also use Anthony's new CONFIG_ARCH_ARM (introducing CONFIG_EXYNOS can be done later). Paolo

Re: [Qemu-devel] [PATCH] Exynos4: added RTC device

2012-06-29 Thread Andreas Färber
Am 29.06.2012 15:06, schrieb Peter Maydell: > On 29 June 2012 13:26, Andreas Färber wrote: >> Am 26.06.2012 05:18, schrieb Evgeny Voevodin: >>> Oh, I see. Should we place this device to hw/Makefile.objs in v2? >> >> That would've been nice, but I'll do it as a follow-up now. > > It's not clear to

Re: [Qemu-devel] [PATCH] Exynos4: added RTC device

2012-06-29 Thread Peter Maydell
On 29 June 2012 13:26, Andreas Färber wrote: > Am 26.06.2012 05:18, schrieb Evgeny Voevodin: >> Oh, I see. Should we place this device to hw/Makefile.objs in v2? > > That would've been nice, but I'll do it as a follow-up now. It's not clear to me that we actually have consensus on what goes in hw

Re: [Qemu-devel] [PATCH] Exynos4: added RTC device

2012-06-29 Thread Andreas Färber
Am 26.06.2012 05:18, schrieb Evgeny Voevodin: > On 25.06.2012 16:00, Andreas Färber wrote: >> Am 25.06.2012 13:46, schrieb Evgeny Voevodin: >>> On 25.06.2012 13:24, Andreas Färber wrote: Am 25.06.2012 09:55, schrieb Oleg Ogurtsov: > Signed-off-by: Oleg Ogurtsov > --- >hw/arm/Ma

Re: [Qemu-devel] [PATCH] Exynos4: added RTC device

2012-06-25 Thread Evgeny Voevodin
On 25.06.2012 16:00, Andreas Färber wrote: Am 25.06.2012 13:46, schrieb Evgeny Voevodin: On 25.06.2012 13:24, Andreas Färber wrote: Am 25.06.2012 09:55, schrieb Oleg Ogurtsov: Signed-off-by: Oleg Ogurtsov --- hw/arm/Makefile.objs |1 + hw/exynos4210.c |8 + hw/exynos4210_rt

Re: [Qemu-devel] [PATCH] Exynos4: added RTC device

2012-06-25 Thread Andreas Färber
Am 25.06.2012 13:46, schrieb Evgeny Voevodin: > On 25.06.2012 13:24, Andreas Färber wrote: >> Am 25.06.2012 09:55, schrieb Oleg Ogurtsov: >>> Signed-off-by: Oleg Ogurtsov >>> --- >>> hw/arm/Makefile.objs |1 + >>> hw/exynos4210.c |8 + >>> hw/exynos4210_rtc.c | 607 >>> ++

Re: [Qemu-devel] [PATCH] Exynos4: added RTC device

2012-06-25 Thread Evgeny Voevodin
On 25.06.2012 13:24, Andreas Färber wrote: Am 25.06.2012 09:55, schrieb Oleg Ogurtsov: Signed-off-by: Oleg Ogurtsov --- hw/arm/Makefile.objs |1 + hw/exynos4210.c |8 + hw/exynos4210_rtc.c | 607 ++ 3 files changed, 616 insertio

Re: [Qemu-devel] [PATCH] Exynos4: added RTC device

2012-06-25 Thread Peter Maydell
On 25 June 2012 08:55, Oleg Ogurtsov wrote: > Subject: [PATCH] Exynos4: added RTC device "add", please. > > Signed-off-by: Oleg Ogurtsov (You don't need to send a cover letter for a single patch, by the way.) > +#define     BCDSEC          0x0070 > +#define     BDCMIN          0x0074 typo,

Re: [Qemu-devel] [PATCH] Exynos4: added RTC device

2012-06-25 Thread Andreas Färber
Am 25.06.2012 09:55, schrieb Oleg Ogurtsov: > Signed-off-by: Oleg Ogurtsov > --- > hw/arm/Makefile.objs |1 + > hw/exynos4210.c |8 + > hw/exynos4210_rtc.c | 607 > ++ > 3 files changed, 616 insertions(+), 0 deletions(-) > create mo

Re: [Qemu-devel] [PATCH] Exynos4: added RTC device

2012-06-25 Thread Evgeny Voevodin
On 25.06.2012 11:55, Oleg Ogurtsov wrote: Signed-off-by: Oleg Ogurtsov --- hw/arm/Makefile.objs |1 + hw/exynos4210.c |8 + hw/exynos4210_rtc.c | 607 ++ 3 files changed, 616 insertions(+), 0 deletions(-) create mode 100644 hw/

[Qemu-devel] [PATCH] Exynos4: added RTC device

2012-06-25 Thread Oleg Ogurtsov
Signed-off-by: Oleg Ogurtsov --- hw/arm/Makefile.objs |1 + hw/exynos4210.c |8 + hw/exynos4210_rtc.c | 607 ++ 3 files changed, 616 insertions(+), 0 deletions(-) create mode 100644 hw/exynos4210_rtc.c diff --git a/hw/arm/Makefile.

[Qemu-devel] [PATCH] Exynos4: added RTC device

2012-06-25 Thread Oleg Ogurtsov
This patch add RTC device Oleg Ogurtsov (1): Exynos4: added RTC device hw/arm/Makefile.objs |1 + hw/exynos4210.c |8 + hw/exynos4210_rtc.c | 607 ++ 3 files changed, 616 insertions(+), 0 deletions(-) create mode 100644 hw/exynos4