Re: [Qemu-devel] [PATCH] Get coding style closer to the real world

2009-12-05 Thread Avi Kivity
On 12/05/2009 12:30 AM, Anthony Liguori wrote: Paul Brook wrote: On Monday 30 November 2009, Alexander Graf wrote: Currently we have this stupid role of disallowing: if (r) break; This has been discussed to death several times, in several different paces, and with no clear resolutio

Re: [Qemu-devel] [PATCH] Get coding style closer to the real world

2009-12-04 Thread Alexander Graf
On 04.12.2009, at 18:47, Paul Brook wrote: > On Monday 30 November 2009, Alexander Graf wrote: >> Currently we have this stupid role of disallowing: >> >> if (r) >> break; > > This has been discussed to death several times, in several different paces, > and with no clear resolution or co

Re: [Qemu-devel] [PATCH] Get coding style closer to the real world

2009-12-04 Thread Anthony Liguori
Paul Brook wrote: On Monday 30 November 2009, Alexander Graf wrote: Currently we have this stupid role of disallowing: if (r) break; This has been discussed to death several times, in several different paces, and with no clear resolution or consensus, so I'm going to make an

Re: [Qemu-devel] [PATCH] Get coding style closer to the real world

2009-12-04 Thread Paul Brook
On Monday 30 November 2009, Alexander Graf wrote: > Currently we have this stupid role of disallowing: > > if (r) > break; This has been discussed to death several times, in several different paces, and with no clear resolution or consensus, so I'm going to make an executive decision:

Re: [Qemu-devel] [PATCH] Get coding style closer to the real world

2009-12-01 Thread Markus Armbruster
Alexander Graf writes: > Currently we have this stupid role of disallowing: > > if (r) > break; > > By disallowing this we clutter the code, making it less readable without > buying us anything. In fact, nobody actually sticks to this because it'd show > just how much bad taste the progra

[Qemu-devel] [PATCH] Get coding style closer to the real world

2009-11-30 Thread Alexander Graf
Currently we have this stupid role of disallowing: if (r) break; By disallowing this we clutter the code, making it less readable without buying us anything. In fact, nobody actually sticks to this because it'd show just how much bad taste the programmer doing this would have. So IMHO we