Fam Zheng f...@redhat.com writes:
On Thu, 03/13 14:25, Markus Armbruster wrote:
Fam Zheng f...@redhat.com writes:
On Wed, 03/12 18:00, Markus Armbruster wrote:
Opening an encrypted image takes an additional step: setting the key.
Between open and the key set, the image must not be used.
Paolo Bonzini pbonz...@redhat.com writes:
Il 13/03/2014 16:00, Markus Armbruster ha scritto:
Paolo Bonzini pbonz...@redhat.com writes:
Il 13/03/2014 14:18, Markus Armbruster ha scritto:
Paolo Bonzini pbonz...@redhat.com writes:
Il 12/03/2014 18:00, Markus Armbruster ha scritto:
+}
On Wed, 03/12 18:00, Markus Armbruster wrote:
Opening an encrypted image takes an additional step: setting the key.
Between open and the key set, the image must not be used.
We have some protection against accidental use in place: you can't
unpause a guest while we're missing keys. You can,
Il 12/03/2014 18:00, Markus Armbruster ha scritto:
+} else if (!runstate_check(RUN_STATE_PRELAUNCH)
+ !runstate_check(RUN_STATE_PAUSED)) { /* HACK */
Why not if (runstate_is_running())?
Paolo
+error_setg(errp,
+ Guest must be stopped for opening of
Paolo Bonzini pbonz...@redhat.com writes:
Il 12/03/2014 18:00, Markus Armbruster ha scritto:
+} else if (!runstate_check(RUN_STATE_PRELAUNCH)
+ !runstate_check(RUN_STATE_PAUSED)) { /* HACK */
Why not if (runstate_is_running())?
The predicate actually wanted here is monitor
Fam Zheng f...@redhat.com writes:
On Wed, 03/12 18:00, Markus Armbruster wrote:
Opening an encrypted image takes an additional step: setting the key.
Between open and the key set, the image must not be used.
We have some protection against accidental use in place: you can't
unpause a guest
On 03/13/2014 04:43 AM, Paolo Bonzini wrote:
Il 12/03/2014 18:00, Markus Armbruster ha scritto:
+} else if (!runstate_check(RUN_STATE_PRELAUNCH)
+ !runstate_check(RUN_STATE_PAUSED)) { /* HACK */
Why not if (runstate_is_running())?
Because that lacks PRELAUNCH, but PRELAUNCH
Il 13/03/2014 14:27, Eric Blake ha scritto:
+} else if (!runstate_check(RUN_STATE_PRELAUNCH)
+ !runstate_check(RUN_STATE_PAUSED)) { /* HACK */
Why not if (runstate_is_running())?
Because that lacks PRELAUNCH, but PRELAUNCH also needs the protection.
Nope, PRELAUNCH does
Il 13/03/2014 14:18, Markus Armbruster ha scritto:
Paolo Bonzini pbonz...@redhat.com writes:
Il 12/03/2014 18:00, Markus Armbruster ha scritto:
+} else if (!runstate_check(RUN_STATE_PRELAUNCH)
+ !runstate_check(RUN_STATE_PAUSED)) { /* HACK */
Why not if
Il 13/03/2014 16:00, Markus Armbruster ha scritto:
Paolo Bonzini pbonz...@redhat.com writes:
Il 13/03/2014 14:18, Markus Armbruster ha scritto:
Paolo Bonzini pbonz...@redhat.com writes:
Il 12/03/2014 18:00, Markus Armbruster ha scritto:
+} else if (!runstate_check(RUN_STATE_PRELAUNCH)
Paolo Bonzini pbonz...@redhat.com writes:
Il 13/03/2014 14:18, Markus Armbruster ha scritto:
Paolo Bonzini pbonz...@redhat.com writes:
Il 12/03/2014 18:00, Markus Armbruster ha scritto:
+} else if (!runstate_check(RUN_STATE_PRELAUNCH)
+ !runstate_check(RUN_STATE_PAUSED)) {
On Thu, 03/13 14:25, Markus Armbruster wrote:
Fam Zheng f...@redhat.com writes:
On Wed, 03/12 18:00, Markus Armbruster wrote:
Opening an encrypted image takes an additional step: setting the key.
Between open and the key set, the image must not be used.
We have some protection
Opening an encrypted image takes an additional step: setting the key.
Between open and the key set, the image must not be used.
We have some protection against accidental use in place: you can't
unpause a guest while we're missing keys. You can, however, hot-plug
block devices lacking keys into
On 03/12/2014 11:00 AM, Markus Armbruster wrote:
Opening an encrypted image takes an additional step: setting the key.
Between open and the key set, the image must not be used.
We have some protection against accidental use in place: you can't
unpause a guest while we're missing keys. You
14 matches
Mail list logo