Re: [Qemu-devel] [PATCH] checkpatch: consider git extended headers valid patches

2016-07-18 Thread Paolo Bonzini
On 18/07/2016 14:15, Stefan Hajnoczi wrote: > On Fri, Jul 15, 2016 at 10:46:54AM +0100, Stefan Hajnoczi wrote: >> Renames look like this with git-diff(1) when diff.renames = true is set: >> >> diff --git a/a b/b >> similarity index 100% >> rename from a >> rename to b >> >> This raises

Re: [Qemu-devel] [PATCH] checkpatch: consider git extended headers valid patches

2016-07-18 Thread Stefan Hajnoczi
On Fri, Jul 15, 2016 at 10:46:54AM +0100, Stefan Hajnoczi wrote: > Renames look like this with git-diff(1) when diff.renames = true is set: > > diff --git a/a b/b > similarity index 100% > rename from a > rename to b > > This raises the "Does not appear to be a unified-diff format patch"

Re: [Qemu-devel] [PATCH] checkpatch: consider git extended headers valid patches

2016-07-15 Thread Eric Blake
On 07/15/2016 03:46 AM, Stefan Hajnoczi wrote: > Renames look like this with git-diff(1) when diff.renames = true is set: > > diff --git a/a b/b > similarity index 100% > rename from a > rename to b > > This raises the "Does not appear to be a unified-diff format patch" > error because

[Qemu-devel] [PATCH] checkpatch: consider git extended headers valid patches

2016-07-15 Thread Stefan Hajnoczi
Renames look like this with git-diff(1) when diff.renames = true is set: diff --git a/a b/b similarity index 100% rename from a rename to b This raises the "Does not appear to be a unified-diff format patch" error because checkpatch.pl only considers a diff valid if it contains at least