Re: [Qemu-devel] [PATCH] configure: avoid compiler warning in pipe2 detection

2012-10-24 Thread Peter Maydell
Ping! Just ran into this bug today and noticed this patch never got applied. Patch still applies OK, patchwork url is: http://patchwork.ozlabs.org/patch/178920/ thanks -- PMM On 20 August 2012 19:45, Bruce Rogers brog...@suse.com wrote: When building qemu-kvm for openSUSE:Factory, I am getting

Re: [Qemu-devel] [PATCH] configure: avoid compiler warning in pipe2 detection

2012-10-24 Thread Andreas Färber
Am 24.10.2012 18:48, schrieb Peter Maydell: Ping! Just ran into this bug today and noticed this patch never got applied. Patch still applies OK, patchwork url is: http://patchwork.ozlabs.org/patch/178920/ ...and since it was noticed while packaging v1.2, it should go into stable as well

Re: [Qemu-devel] [PATCH] configure: Fix CONFIG_QEMU_HELPERDIR generation

2012-10-22 Thread Aurelien Jarno
On Sun, Oct 21, 2012 at 10:58:37PM +0400, Michael Tokarev wrote: On 19.10.2012 23:33, Aurelien Jarno wrote: On Wed, Oct 17, 2012 at 07:09:25PM +0200, Jan Kiszka wrote: We need to evaluate $libexecdir in configure, otherwise we literally end up with ${prefix}/libexec instead of the absolute

Re: [Qemu-devel] [PATCH] configure: Fix CONFIG_QEMU_HELPERDIR generation

2012-10-21 Thread Michael Tokarev
On 19.10.2012 23:33, Aurelien Jarno wrote: On Wed, Oct 17, 2012 at 07:09:25PM +0200, Jan Kiszka wrote: We need to evaluate $libexecdir in configure, otherwise we literally end up with ${prefix}/libexec instead of the absolute path as CONFIG_QEMU_HELPERDIR. Signed-off-by: Jan Kiszka

[Qemu-devel] [PATCH] configure: Remove stray debug output

2012-10-20 Thread Peter Maydell
Rather than printing a message saying we're silently falling back to gthread coroutines when running on MacOS, actually do it silently. Signed-off-by: Peter Maydell peter.mayd...@linaro.org --- I guess this is a self-falsifying echo :-) configure | 2 -- 1 file changed, 2 deletions(-) diff

Re: [Qemu-devel] [PATCH] configure: Fix CONFIG_QEMU_HELPERDIR generation

2012-10-19 Thread Aurelien Jarno
On Wed, Oct 17, 2012 at 07:09:25PM +0200, Jan Kiszka wrote: We need to evaluate $libexecdir in configure, otherwise we literally end up with ${prefix}/libexec instead of the absolute path as CONFIG_QEMU_HELPERDIR. Signed-off-by: Jan Kiszka jan.kis...@siemens.com --- configure |2 +-

[Qemu-devel] [PATCH] configure: Fix CONFIG_QEMU_HELPERDIR generation

2012-10-17 Thread Jan Kiszka
We need to evaluate $libexecdir in configure, otherwise we literally end up with ${prefix}/libexec instead of the absolute path as CONFIG_QEMU_HELPERDIR. Signed-off-by: Jan Kiszka jan.kis...@siemens.com --- configure |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git

Re: [Qemu-devel] [PATCH] configure: Disable (clang) initializer-overrides warnings

2012-10-16 Thread Stefan Weil
Am 14.10.2012 22:24, schrieb Peter Maydell: On 14 October 2012 21:15, Blue Swirlblauwir...@gmail.com wrote: On Sun, Oct 14, 2012 at 8:00 PM, Peter Maydellpeter.mayd...@linaro.org wrote: Blue Swirl previously submitted a patch which enabled this flag (among others):

Re: [Qemu-devel] [PATCH] configure: Disable (clang) initializer-overrides warnings

2012-10-16 Thread Peter Maydell
On 16 October 2012 21:20, Stefan Weil s...@weilnetz.de wrote: Hi Peter, hi Blue, gcc uses a different flag -Wno-override-init to disable initializer override warnings. I tested the following patch which uses -Wextra with gcc-4.4 and gcc-4.7. It allows compilation of QEMU without warnings.

Re: [Qemu-devel] [PATCH] configure: Disable (clang) initializer-overrides warnings

2012-10-14 Thread Blue Swirl
On Sun, Oct 14, 2012 at 8:00 PM, Peter Maydell peter.mayd...@linaro.org wrote: Disable clang's initializer-overrides warnings, as QEMU makes significant use of the pattern of initializing an array with a range-based default entry like [0 ... 0x1ff] = { GPIO_NONE, 0 } followed by specific

[Qemu-devel] [PATCH] configure: Disable (clang) initializer-overrides warnings

2012-10-14 Thread Peter Maydell
Disable clang's initializer-overrides warnings, as QEMU makes significant use of the pattern of initializing an array with a range-based default entry like [0 ... 0x1ff] = { GPIO_NONE, 0 } followed by specific entries which override that default, and clang would otherwise warn initializer

Re: [Qemu-devel] [PATCH] configure: Disable (clang) initializer-overrides warnings

2012-10-14 Thread Peter Maydell
On 14 October 2012 21:15, Blue Swirl blauwir...@gmail.com wrote: On Sun, Oct 14, 2012 at 8:00 PM, Peter Maydell peter.mayd...@linaro.org wrote: Blue Swirl previously submitted a patch which enabled this flag (among others): http://lists.gnu.org/archive/html/qemu-devel/2012-07/msg04203.html

[Qemu-devel] [PATCH] configure: Remove unused parameters from main function

2012-10-14 Thread Stefan Weil
This modification is required if compiler option -Wunused-parameter is activated. Signed-off-by: Stefan Weil s...@weilnetz.de --- configure |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/configure b/configure index 353d788..499ad81 100755 --- a/configure +++

Re: [Qemu-devel] [PATCH] configure: Support empty target list (--target-list=)

2012-10-05 Thread Stefan Hajnoczi
On Wed, Sep 26, 2012 at 10:04:38PM +0200, Stefan Weil wrote: Specifying an empty target list with --target-list= is shorter than specifying --disable-user --disable-system. Both variants should give the same result: no targets at all. This modification implements that feature. It uses a

[Qemu-devel] [PATCH] configure: Tidy up remnants of non-64-bit physaddrs

2012-10-05 Thread Peter Maydell
Tidy up some remnants of code to support non-64-bit physaddrs which were accidentally omitted from commit 4be403c8. Signed-off-by: Peter Maydell peter.mayd...@linaro.org --- configure |2 -- 1 file changed, 2 deletions(-) diff --git a/configure b/configure index e58846d..11b0e21 100755 ---

Re: [Qemu-devel] [PATCH] configure: Allow builds without any system or user emulation

2012-09-26 Thread Anthony Liguori
Stefan Weil s...@weilnetz.de writes: The old code aborted configure when no emulation target was selected. Even after removing the 'exit 1', it tried to read from STDIN when QEMU was configured with configure' '--disable-user' '--disable-system' This is fixed here. Signed-off-by:

[Qemu-devel] [PATCH] configure: Support empty target list (--target-list=)

2012-09-26 Thread Stefan Weil
Specifying an empty target list with --target-list= is shorter than specifying --disable-user --disable-system. Both variants should give the same result: no targets at all. This modification implements that feature. It uses a trick which works with POSIX compliant shells to test whether

Re: [Qemu-devel] [PATCH] configure: Allow builds without any system or user emulation

2012-09-24 Thread Laurent Desnogues
On Sat, Sep 22, 2012 at 11:37 PM, Stefan Weil s...@weilnetz.de wrote: Am 14.09.2012 19:02, schrieb Stefan Weil: The old code aborted configure when no emulation target was selected. Even after removing the 'exit 1', it tried to read from STDIN when QEMU was configured with configure'

Re: [Qemu-devel] [PATCH] configure: Allow builds without any system or user emulation

2012-09-24 Thread Stefan Weil
Am 24.09.2012 12:57, schrieb Laurent Desnogues: On Sat, Sep 22, 2012 at 11:37 PM, Stefan Weils...@weilnetz.de wrote: Am 14.09.2012 19:02, schrieb Stefan Weil: The old code aborted configure when no emulation target was selected. Even after removing the 'exit 1', it tried to read from STDIN

Re: [Qemu-devel] [PATCH] configure: Allow builds without any system or user emulation

2012-09-22 Thread Stefan Weil
Am 14.09.2012 19:02, schrieb Stefan Weil: The old code aborted configure when no emulation target was selected. Even after removing the 'exit 1', it tried to read from STDIN when QEMU was configured with configure' '--disable-user' '--disable-system' This is fixed here. Signed-off-by:

Re: [Qemu-devel] [PATCH] configure: do not quote $PKG_CONFIG

2012-09-17 Thread Sergei Trofimovich
On Sun, 16 Sep 2012 22:21:31 +0200 Stefan Weil s...@weilnetz.de wrote: Am 16.09.2012 21:52, schrieb Mike Frysinger: On Sunday 15 July 2012 15:54:51 Stefan Weil wrote: Am 15.07.2012 22:26, schrieb Mike Frysinger: We should not quote the PKG_CONFIG setting as this deviates from the

Re: [Qemu-devel] [PATCH] configure: do not quote $PKG_CONFIG

2012-09-17 Thread Anthony Liguori
Mike Frysinger vap...@gentoo.org writes: We should not quote the PKG_CONFIG setting as this deviates from the canonical upstream behavior that gets integrated with all other build systems, and deviates from how we treat all other toolchain variables that we get from the environment.

Re: [Qemu-devel] [PATCH] configure: do not quote $PKG_CONFIG

2012-09-17 Thread Eric Blake
On 09/17/2012 01:38 PM, Anthony Liguori wrote: Mike Frysinger vap...@gentoo.org writes: We should not quote the PKG_CONFIG setting as this deviates from the canonical upstream behavior that gets integrated with all other build systems, and deviates from how we treat all other toolchain

Re: [Qemu-devel] [PATCH] configure: do not quote $PKG_CONFIG

2012-09-16 Thread Stefan Weil
Am 16.09.2012 21:52, schrieb Mike Frysinger: On Sunday 15 July 2012 15:54:51 Stefan Weil wrote: Am 15.07.2012 22:26, schrieb Mike Frysinger: We should not quote the PKG_CONFIG setting as this deviates from the canonical upstream behavior that gets integrated with all other build systems, and

Re: [Qemu-devel] [PATCH] configure: fix --target-list=target, target, ... option

2012-09-14 Thread Peter Maydell
On 12 September 2012 14:20, Laurent Desnogues laurent.desnog...@gmail.com wrote: Sorry, I had missed this patch... On Tue, Sep 11, 2012 at 9:02 PM, Eduardo Habkost ehabk...@redhat.com wrote: commit 66d5499b3754b83c09487259c08fe2ce73188a59 broke the support for comma-separated target lists on

Re: [Qemu-devel] [PATCH] configure: fix --target-list=target, target, ... option

2012-09-14 Thread Anthony Liguori
Peter Maydell peter.mayd...@linaro.org writes: On 12 September 2012 14:20, Laurent Desnogues laurent.desnog...@gmail.com wrote: Sorry, I had missed this patch... On Tue, Sep 11, 2012 at 9:02 PM, Eduardo Habkost ehabk...@redhat.com wrote: commit 66d5499b3754b83c09487259c08fe2ce73188a59 broke

Re: [Qemu-devel] [PATCH] configure: fix --target-list=target, target, ... option

2012-09-14 Thread Daniel P. Berrange
On Fri, Sep 14, 2012 at 01:53:11PM +0100, Peter Maydell wrote: On 12 September 2012 14:20, Laurent Desnogues laurent.desnog...@gmail.com wrote: Sorry, I had missed this patch... On Tue, Sep 11, 2012 at 9:02 PM, Eduardo Habkost ehabk...@redhat.com wrote: commit

[Qemu-devel] [PATCH] configure: Allow builds without any system or user emulation

2012-09-14 Thread Stefan Weil
The old code aborted configure when no emulation target was selected. Even after removing the 'exit 1', it tried to read from STDIN when QEMU was configured with configure' '--disable-user' '--disable-system' This is fixed here. Signed-off-by: Stefan Weil s...@weilnetz.de --- This patch

Re: [Qemu-devel] [PATCH] configure: fix --target-list=target, target, ... option

2012-09-14 Thread Stefan Weil
Am 14.09.2012 14:53, schrieb Peter Maydell: On 12 September 2012 14:20, Laurent Desnogues laurent.desnog...@gmail.com wrote: Sorry, I had missed this patch... On Tue, Sep 11, 2012 at 9:02 PM, Eduardo Habkostehabk...@redhat.com wrote: commit 66d5499b3754b83c09487259c08fe2ce73188a59 broke the

[Qemu-devel] [PATCH] configure: Fix configure: usbredir fixes to not break softmmu builds

2012-09-13 Thread Hans de Goede
Feel free to merge this into the original commit at that is not upstream yet. Signed-off-by: Hans de Goede hdego...@redhat.com CC: Aurelien Jarno aurel...@aurel32.net --- configure | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configure b/configure index 1854b0b..d63530a

Re: [Qemu-devel] [PATCH] configure: Fix configure: usbredir fixes to not break softmmu builds

2012-09-13 Thread Gerd Hoffmann
On 09/13/12 09:31, Hans de Goede wrote: -libs_softmmu=$LIBS $usb_redir_libs +libs_softmmu=$libs_softmmu $usb_redir_libs Good point ;) Fix squashed in. thanks, Gerd

Re: [Qemu-devel] [PATCH] configure: usbredir fixes

2012-09-12 Thread Gerd Hoffmann
On 09/11/12 20:57, Aurelien Jarno wrote: usbredir is only used by system emulation, so add the libraries to libs_softmmu instead of LIBS. Patch added to usb patch queue. thanks, Gerd

Re: [Qemu-devel] [PATCH] configure: fix --target-list=target, target, ... option

2012-09-12 Thread Laurent Desnogues
Sorry, I had missed this patch... On Tue, Sep 11, 2012 at 9:02 PM, Eduardo Habkost ehabk...@redhat.com wrote: commit 66d5499b3754b83c09487259c08fe2ce73188a59 broke the support for comma-separated target lists on the --target-list option. e.g.: $ ./configure

[Qemu-devel] [PATCH] configure: fix --target-list=target, target, ... option

2012-09-11 Thread Eduardo Habkost
commit 66d5499b3754b83c09487259c08fe2ce73188a59 broke the support for comma-separated target lists on the --target-list option. e.g.: $ ./configure --target-list=x86_64-linux-user,x86_64-softmmu [...] ERROR: Target 'x86_64-linux-user,x86_64-softmmu' not recognised $ This patch restores

[Qemu-devel] [PATCH] configure: usbredir fixes

2012-09-11 Thread Aurelien Jarno
usbredir is only used by system emulation, so add the libraries to libs_softmmu instead of LIBS. Cc: Michael Tokarev m...@tls.msk.ru Cc: Gerd Hoffmann kra...@redhat.com Signed-off-by: Aurelien Jarno aurel...@aurel32.net --- configure |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

Re: [Qemu-devel] [PATCH] configure: fix --target-list=target, target, ... option

2012-09-11 Thread Peter Crosthwaite
On Wed, Sep 12, 2012 at 5:02 AM, Eduardo Habkost ehabk...@redhat.com wrote: commit 66d5499b3754b83c09487259c08fe2ce73188a59 broke the support for comma-separated target lists on the --target-list option. e.g.: $ ./configure --target-list=x86_64-linux-user,x86_64-softmmu [...] ERROR:

Re: [Qemu-devel] [PATCH] configure: usbredir fixes

2012-09-11 Thread Michael Tokarev
On 11.09.2012 22:57, Aurelien Jarno wrote: usbredir is only used by system emulation, so add the libraries to libs_softmmu instead of LIBS. Fwiw, original code breaks user-static build - not it only tries to link with unused library but also some distros does not package/provide static (.a)

Re: [Qemu-devel] [PATCH] configure: fix seccomp check

2012-09-07 Thread Andreas Färber
Am 06.09.2012 22:40, schrieb Yann E. MORIN: Currently, if libseccomp is missing but the user explicitly requested seccomp support using --enable-seccomp, configure silently ignores the situation and disables seccomp support. This is unlike all other tests that explicitly fail in such

[Qemu-devel] [PATCH] configure: fix seccomp check

2012-09-06 Thread Yann E. MORIN
Currently, if libseccomp is missing but the user explicitly requested seccomp support using --enable-seccomp, configure silently ignores the situation and disables seccomp support. This is unlike all other tests that explicitly fail in such situation. Fix that. Signed-off-by: Yann E. MORIN

[Qemu-devel] [PATCH] configure: some fixes for OpenBSD

2012-08-24 Thread Brad Smith
OpenBSD's uname works as expected with the -s flag so remove the special handling when determining the target OS. Use arch -s to retrieve the hardware architecture as uname -m will return the meta architecture instead of the hardware architecture (.e.g. macppc vs powerpc). Signed-off-by: Brad

Re: [Qemu-devel] [PATCH] configure: some fixes for OpenBSD

2012-08-24 Thread Peter Maydell
On 24 August 2012 10:47, Brad Smith b...@comstyle.com wrote: OpenBSD's uname works as expected with the -s flag so remove the special handling when determining the target OS. Use arch -s to retrieve the hardware architecture as uname -m will return the meta architecture instead of the hardware

Re: [Qemu-devel] [PATCH] configure: some fixes for OpenBSD

2012-08-24 Thread Brad Smith
On Fri, Aug 24, 2012 at 10:55:10AM +0100, Peter Maydell wrote: On 24 August 2012 10:47, Brad Smith b...@comstyle.com wrote: OpenBSD's uname works as expected with the -s flag so remove the special handling when determining the target OS. Use arch -s to retrieve the hardware architecture as

Re: [Qemu-devel] [PATCH] configure: some fixes for OpenBSD

2012-08-24 Thread Paolo Bonzini
Il 24/08/2012 11:55, Peter Maydell ha scritto: OpenBSD's uname works as expected with the -s flag so remove the special handling when determining the target OS. Use arch -s to retrieve the hardware architecture as uname -m will return the meta architecture instead of the hardware

Re: [Qemu-devel] [PATCH] configure: some fixes for OpenBSD

2012-08-24 Thread Brad Smith
On Fri, Aug 24, 2012 at 01:56:31PM +0200, Paolo Bonzini wrote: Il 24/08/2012 11:55, Peter Maydell ha scritto: OpenBSD's uname works as expected with the -s flag so remove the special handling when determining the target OS. Use arch -s to retrieve the hardware architecture as uname -m

Re: [Qemu-devel] [PATCH] configure: some fixes for OpenBSD

2012-08-24 Thread Paolo Bonzini
Il 24/08/2012 14:00, Brad Smith ha scritto: OpenBSD's uname works as expected with the -s flag so remove the special handling when determining the target OS. Use arch -s to retrieve the hardware architecture as uname -m will return the meta architecture instead of the

Re: [Qemu-devel] [PATCH] configure: some fixes for OpenBSD

2012-08-24 Thread Brad Smith
On Fri, Aug 24, 2012 at 02:02:57PM +0200, Paolo Bonzini wrote: Il 24/08/2012 14:00, Brad Smith ha scritto: OpenBSD's uname works as expected with the -s flag so remove the special handling when determining the target OS. Use arch -s to retrieve the hardware architecture

[Qemu-devel] [PATCH] configure: avoid compiler warning in pipe2 detection

2012-08-20 Thread Bruce Rogers
When building qemu-kvm for openSUSE:Factory, I am getting a warning in the pipe2 detection performed by configure, which prevents using --enable-werror. Change detection code to use return value of pipe2. Signed-off-by: Bruce Rogers brog...@suse.com --- configure |3 +-- 1 files changed, 1

Re: [Qemu-devel] [PATCH] configure: avoid compiler warning in pipe2 detection

2012-08-20 Thread Peter Maydell
On 20 August 2012 19:45, Bruce Rogers brog...@suse.com wrote: When building qemu-kvm for openSUSE:Factory, I am getting a warning in the pipe2 detection performed by configure, which prevents using --enable-werror. Change detection code to use return value of pipe2. Signed-off-by: Bruce

[Qemu-devel] [PATCH] configure: Don't override user's --cpu on MacOS and Solaris

2012-08-14 Thread Peter Maydell
Both MacOS and Solaris have special case handling for the CPU type, because the check_define probes will return i386 even if the hardware is 64 bit and x86_64 would be preferable. Move these checks earlier in the configure probing so that we can do them only if the user didn't specify a CPU with

Re: [Qemu-devel] [PATCH] configure: Don't override user's --cpu on MacOS and Solaris

2012-08-14 Thread Andreas Färber
Am 14.08.2012 16:35, schrieb Peter Maydell: Both MacOS and Solaris have special case handling for the CPU type, because the check_define probes will return i386 even if the hardware is 64 bit and x86_64 would be preferable. Move these checks earlier in the configure probing so that we can do

Re: [Qemu-devel] [PATCH] configure: Don't override user's --cpu on MacOS and Solaris

2012-08-14 Thread Schindler Karl-Michael
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Pathetic case (32bit qemu on 64bit hw under Mac OS X 10.6) tested succesfully. Thanks for your patience and help. Michael -BEGIN PGP SIGNATURE- Version: GnuPG/MacGPG2 v2.0.18 (Darwin) Comment: GPGTools - http://gpgtools.org

[Qemu-devel] [PATCH] configure: fix double check tests with Clang

2012-08-09 Thread Blue Swirl
Configuring with Clang compiler with -Werror would not work after improved checks: /tmp/qemu-conf--25992-.c:4:32: error: self-comparison always evaluates to true [-Werror,-Wtautological-compare] int main(void) { return preadv == preadv; } /tmp/qemu-conf--25992-.c:13:26: error: self-comparison

Re: [Qemu-devel] [PATCH] configure: fix double check tests with Clang

2012-08-09 Thread Peter Maydell
On 9 August 2012 21:31, Blue Swirl blauwir...@gmail.com wrote: Configuring with Clang compiler with -Werror would not work after improved checks: /tmp/qemu-conf--25992-.c:4:32: error: self-comparison always evaluates to true [-Werror,-Wtautological-compare] int main(void) { return preadv ==

Re: [Qemu-devel] [PATCH] configure: Don't implicitly hardcode list of KVM architectures

2012-08-02 Thread Peter Maydell
Ping? -- PMM On 18 July 2012 12:10, Peter Maydell peter.mayd...@linaro.org wrote: The code creating the symlink from linux-headers/asm to the architecture specific linux-headers/asm-$arch directory was implicitly hardcoding a list of KVM supporting architectures. Add a default case for the

Re: [Qemu-devel] [PATCH] configure: Don't implicitly hardcode list of KVM architectures

2012-08-02 Thread Andreas Färber
Am 02.08.2012 17:41, schrieb Peter Maydell: Ping? Alex? Christian? -- PMM On 18 July 2012 12:10, Peter Maydell peter.mayd...@linaro.org wrote: The code creating the symlink from linux-headers/asm to the architecture specific linux-headers/asm-$arch directory was implicitly hardcoding a

Re: [Qemu-devel] [PATCH] configure: Don't implicitly hardcode list of KVM architectures

2012-08-02 Thread Alexander Graf
On 02.08.2012, at 17:46, Andreas Färber wrote: Am 02.08.2012 17:41, schrieb Peter Maydell: Ping? Alex? Christian? Looks good to me, and should probably go in through the kvm queue. Avi, Marcelo? -- PMM On 18 July 2012 12:10, Peter Maydell peter.mayd...@linaro.org wrote: The code

Re: [Qemu-devel] [PATCH] configure: Don't implicitly hardcode list of KVM architectures

2012-08-02 Thread Andreas Färber
Am 18.07.2012 13:10, schrieb Peter Maydell: The code creating the symlink from linux-headers/asm to the architecture specific linux-headers/asm-$arch directory was implicitly hardcoding a list of KVM supporting architectures. Add a default case for the common Linux architecture name and QEMU

Re: [Qemu-devel] [PATCH] configure: Don't implicitly hardcode list of KVM architectures

2012-08-02 Thread Peter Maydell
On 2 August 2012 17:01, Andreas Färber afaer...@suse.de wrote: One minor nit: The indentation seems off here - esac 2 spaces, if 4. configure's indentation is pretty inconsistent generally between 2 or 4 spaces. I usually go for 4 for new code but don't reindent old code. (There's a lot more

Re: [Qemu-devel] [PATCH] configure: Don't implicitly hardcode list of KVM architectures

2012-08-02 Thread Andreas Färber
Am 02.08.2012 18:22, schrieb Peter Maydell: On 2 August 2012 17:01, Andreas Färber afaer...@suse.de wrote: One minor nit: The indentation seems off here - esac 2 spaces, if 4. configure's indentation is pretty inconsistent generally between 2 or 4 spaces. I usually go for 4 for new code but

Re: [Qemu-devel] [PATCH] configure: Don't implicitly hardcode list of KVM architectures

2012-08-02 Thread Marcelo Tosatti
On Thu, Aug 02, 2012 at 05:53:37PM +0200, Alexander Graf wrote: On 02.08.2012, at 17:46, Andreas Färber wrote: Am 02.08.2012 17:41, schrieb Peter Maydell: Ping? Alex? Christian? Looks good to me, and should probably go in through the kvm queue. Avi, Marcelo? Sure, please send

[Qemu-devel] [PATCH] configure: Fix configure error with --enable-virtfs

2012-07-31 Thread Aneesh Kumar K.V
From: Aneesh Kumar K.V aneesh.ku...@linux.vnet.ibm.com This fix the below error on ubuntu 12.04 a.c: In function ‘main’: a.c:3:24: error: variable ‘caps’ set but not used [-Werror=unused-but-set-variable] a.c:3:1: error: control reaches end of non-void function [-Werror=return-type]

Re: [Qemu-devel] [PATCH] configure: fix libcap detection

2012-07-31 Thread Aneesh Kumar K.V
Avi Kivity a...@redhat.com writes: - avoid assigned-but-not-used error - avoid missing return error Signed-off-by: Avi Kivity a...@redhat.com Acked-by: Aneesh Kumar K.V aneesh.ku...@linux.vnet.ibm.com --- configure | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [Qemu-devel] [PATCH] configure: fix libcap detection

2012-07-31 Thread Stefan Weil
Am 31.07.2012 08:52, schrieb Aneesh Kumar K.V: Avi Kivity a...@redhat.com writes: - avoid assigned-but-not-used error - avoid missing return error Signed-off-by: Avi Kivity a...@redhat.com Acked-by: Aneesh Kumar K.V aneesh.ku...@linux.vnet.ibm.com --- configure | 2 +- 1

Re: [Qemu-devel] [PATCH] configure: fix libcap detection

2012-07-31 Thread Peter Maydell
On 31 July 2012 17:33, Stefan Weil s...@weilnetz.de wrote: please apply http://patchwork.ozlabs.org/patch/171067/, or we'll get a 4th bug fix for this. Peter sent a series with this one and more patches on 2012-07-18 (1st: http://patchwork.ozlabs.org/patch/171686/). At least the first 10 of

Re: [Qemu-devel] [PATCH] configure: fix libcap detection

2012-07-31 Thread Blue Swirl
On Tue, Jul 31, 2012 at 4:40 PM, Peter Maydell peter.mayd...@linaro.org wrote: On 31 July 2012 17:33, Stefan Weil s...@weilnetz.de wrote: please apply http://patchwork.ozlabs.org/patch/171067/, or we'll get a 4th bug fix for this. Peter sent a series with this one and more patches on

Re: [Qemu-devel] [PATCH] configure: fix libcap detection

2012-07-31 Thread Aneesh Kumar K.V
Stefan Weil s...@weilnetz.de writes: Am 31.07.2012 08:52, schrieb Aneesh Kumar K.V: Avi Kivity a...@redhat.com writes: - avoid assigned-but-not-used error - avoid missing return error Signed-off-by: Avi Kivity a...@redhat.com Acked-by: Aneesh Kumar K.V aneesh.ku...@linux.vnet.ibm.com

Re: [Qemu-devel] [PATCH] configure: fix libcap detection

2012-07-31 Thread Blue Swirl
On Tue, Jul 31, 2012 at 4:40 PM, Peter Maydell peter.mayd...@linaro.org wrote: On 31 July 2012 17:33, Stefan Weil s...@weilnetz.de wrote: please apply http://patchwork.ozlabs.org/patch/171067/, or we'll get a 4th bug fix for this. Peter sent a series with this one and more patches on

Re: [Qemu-devel] [PATCH] configure: fix libcap detection

2012-07-31 Thread Peter Maydell
On 31 July 2012 18:56, Blue Swirl blauwir...@gmail.com wrote: On Tue, Jul 31, 2012 at 4:40 PM, Peter Maydell peter.mayd...@linaro.org wrote: I believe the valgrind test patch should fix the issues Blue Swirl was seeing with the 11-patch series (and I tested it on debian squeeze which I think

Re: [Qemu-devel] [PATCH] configure: Split valgrind test into pragma test and valgrind.h test

2012-07-31 Thread Blue Swirl
Thanks, applied. On Mon, Jul 30, 2012 at 3:13 PM, Peter Maydell peter.mayd...@linaro.org wrote: Split the configure test that checks for valgrind into two, one part checking whether we have the gcc pragma to disable unused-but-set variables, and the other part checking for the existence of

[Qemu-devel] [PATCH] configure: fix libcap detection

2012-07-30 Thread Avi Kivity
- avoid assigned-but-not-used error - avoid missing return error Signed-off-by: Avi Kivity a...@redhat.com --- configure | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configure b/configure index 7767aca..5fb449d 100755 --- a/configure +++ b/configure @@ -2099,7 +2099,7 @@

Re: [Qemu-devel] [PATCH] configure: fix libcap detection

2012-07-30 Thread Peter Maydell
On 30 July 2012 12:41, Avi Kivity a...@redhat.com wrote: - avoid assigned-but-not-used error - avoid missing return error Signed-off-by: Avi Kivity a...@redhat.com There's already a patch on the list for this: http://patchwork.ozlabs.org/patch/171704/ -- PMM

[Qemu-devel] [PATCH] configure: Split valgrind test into pragma test and valgrind.h test

2012-07-30 Thread Peter Maydell
Split the configure test that checks for valgrind into two, one part checking whether we have the gcc pragma to disable unused-but-set variables, and the other part checking for the existence of valgrind.h. The first of these has to be compiled with -Werror and the second does not and shouldn't

Re: [Qemu-devel] [PATCH] configure: fix libcap detection

2012-07-30 Thread Richard W.M. Jones
On Mon, Jul 30, 2012 at 02:41:33PM +0300, Avi Kivity wrote: - avoid assigned-but-not-used error - avoid missing return error Signed-off-by: Avi Kivity a...@redhat.com --- configure | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configure b/configure index

[Qemu-devel] [PATCH] configure: Fix xen probe with Xen 4.2 and later.

2012-07-26 Thread Anthony PERARD
The xs.h header is now deprecated and produce a warning. This prevent the configure script from enabling xen with Xen unstable whom will become 4.2. As this header is not anymore common to every version of Xen, we just remove it from the early probe for Xen. Signed-off-by: Anthony PERARD

Re: [Qemu-devel] [PATCH] configure: Fix xen probe with Xen 4.2 and later.

2012-07-26 Thread Stefano Stabellini
On Thu, 26 Jul 2012, Anthony PERARD wrote: The xs.h header is now deprecated and produce a warning. This prevent the configure script from enabling xen with Xen unstable whom will become 4.2. As this header is not anymore common to every version of Xen, we just remove it from the early probe

Re: [Qemu-devel] [PATCH] configure: Fix xen probe with Xen 4.2 and later.

2012-07-26 Thread Andreas Färber
Am 26.07.2012 12:09, schrieb Anthony PERARD: The xs.h header is now deprecated and produce a warning. This prevent the produces, prevents Stefano, can you fix in your queue? Regards, /-F configure script from enabling xen with Xen unstable whom will become 4.2. As this header is not anymore

Re: [Qemu-devel] [PATCH] configure: Fix xen probe with Xen 4.2 and later.

2012-07-26 Thread Stefano Stabellini
On Thu, 26 Jul 2012, Andreas Färber wrote: Am 26.07.2012 12:09, schrieb Anthony PERARD: The xs.h header is now deprecated and produce a warning. This prevent the produces, prevents Stefano, can you fix in your queue? Yep, I'll submit a pull request with the fixup.

Re: [Qemu-devel] [PATCH] configure: fix ALSA configure test

2012-07-23 Thread Blue Swirl
On Tue, Jul 17, 2012 at 7:28 PM, Peter Maydell peter.mayd...@linaro.org wrote: On 17 July 2012 20:24, Stefan Weil s...@weilnetz.de wrote: The arguments why -Werror is a bad idea for some configure tests are reasonable. Nevertheless the QEMU community was able to produce thousands of lines of

Re: [Qemu-devel] [PATCH] configure: fix ALSA configure test

2012-07-23 Thread Peter Maydell
On 23 July 2012 18:40, Blue Swirl blauwir...@gmail.com wrote: On Tue, Jul 17, 2012 at 7:28 PM, Peter Maydell peter.mayd...@linaro.org wrote: The trouble is that the warnings and errors here don't cause the build to fail noisily; that's a big distinction IMHO. I suppose we could make

Re: [Qemu-devel] [PATCH] configure: Support system emulation with large memory on w32 hosts

2012-07-23 Thread Blue Swirl
On Fri, Jul 20, 2012 at 5:19 PM, Stefan Weil s...@weilnetz.de wrote: Am 20.07.2012 08:38, schrieb Alexey Kardashevskiy: On 20/07/12 16:05, Alexey Kardashevskiy wrote: On 20/07/12 15:37, Alexey Kardashevskiy wrote: On 20/07/12 15:23, Stefan Weil wrote: Am 20.07.2012 05:53, schrieb Alexey

Re: [Qemu-devel] [PATCH] configure: fix ALSA configure test

2012-07-23 Thread Peter Maydell
On 23 July 2012 18:45, Peter Maydell peter.mayd...@linaro.org wrote: On 23 July 2012 18:40, Blue Swirl blauwir...@gmail.com wrote: On Tue, Jul 17, 2012 at 7:28 PM, Peter Maydell peter.mayd...@linaro.org wrote: The trouble is that the warnings and errors here don't cause the build to fail

[Qemu-devel] [PATCH] configure: fix libcacard check

2012-07-22 Thread Alon Levy
SRC_PATH is undefined during configure run time, it is only defined in makefiles generated by it. Replace with source_path which is defined. Signed-off-by: Alon Levy al...@redhat.com --- configure |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configure b/configure index

Re: [Qemu-devel] [PATCH] configure: fix libcacard check

2012-07-22 Thread Peter Maydell
On 22 July 2012 12:00, Alon Levy al...@redhat.com wrote: SRC_PATH is undefined during configure run time, it is only defined in makefiles generated by it. Replace with source_path which is defined. There's a (slightly different) patch to address this issue in my configure series I posted

Re: [Qemu-devel] [PATCH] configure: fix libcacard check

2012-07-22 Thread Alon Levy
On Sun, Jul 22, 2012 at 12:30:27PM +0100, Peter Maydell wrote: On 22 July 2012 12:00, Alon Levy al...@redhat.com wrote: SRC_PATH is undefined during configure run time, it is only defined in makefiles generated by it. Replace with source_path which is defined. There's a (slightly

Re: [Qemu-devel] [PATCH] configure: adapt vde test to -Werror

2012-07-21 Thread Stefan Hajnoczi
On Mon, Jul 16, 2012 at 12:10 PM, Stefan Hajnoczi stefa...@gmail.com wrote: On Sun, Jul 15, 2012 at 09:38:25PM +0200, Laszlo Ersek wrote: ... after commit 417c9d72 (configure: add -Werror to QEMU_CFLAGS early) Signed-off-by: Laszlo Ersek ler...@redhat.com --- configure |2 +- 1 files

Re: [Qemu-devel] [PATCH] configure: Support system emulation with large memory on w32 hosts

2012-07-20 Thread Alexey Kardashevskiy
On 20/07/12 15:37, Alexey Kardashevskiy wrote: On 20/07/12 15:23, Stefan Weil wrote: Am 20.07.2012 05:53, schrieb Alexey Kardashevskiy: On 19/07/12 02:37, Stefan Weil wrote: 32-bit applications on Windows normally only get virtual memory in the lower 2 GiB address space. Because of memory

Re: [Qemu-devel] [PATCH] configure: Support system emulation with large memory on w32 hosts

2012-07-20 Thread Alexey Kardashevskiy
On 20/07/12 16:05, Alexey Kardashevskiy wrote: On 20/07/12 15:37, Alexey Kardashevskiy wrote: On 20/07/12 15:23, Stefan Weil wrote: Am 20.07.2012 05:53, schrieb Alexey Kardashevskiy: On 19/07/12 02:37, Stefan Weil wrote: 32-bit applications on Windows normally only get virtual memory in the

Re: [Qemu-devel] [PATCH] configure: Support system emulation with large memory on w32 hosts

2012-07-20 Thread Stefan Weil
Am 20.07.2012 08:38, schrieb Alexey Kardashevskiy: On 20/07/12 16:05, Alexey Kardashevskiy wrote: On 20/07/12 15:37, Alexey Kardashevskiy wrote: On 20/07/12 15:23, Stefan Weil wrote: Am 20.07.2012 05:53, schrieb Alexey Kardashevskiy: On 19/07/12 02:37, Stefan Weil wrote: 32-bit applications

Re: [Qemu-devel] [PATCH] configure: Support system emulation with large memory on w32 hosts

2012-07-19 Thread Alexey Kardashevskiy
On 19/07/12 02:37, Stefan Weil wrote: 32-bit applications on Windows normally only get virtual memory in the lower 2 GiB address space. Because of memory fragmentation, VirtualAlloc() usually won't get 1 GiB of contiguous virtual memory in that address space. Therefore running system

Re: [Qemu-devel] [PATCH] configure: Support system emulation with large memory on w32 hosts

2012-07-19 Thread Stefan Weil
Am 20.07.2012 05:53, schrieb Alexey Kardashevskiy: On 19/07/12 02:37, Stefan Weil wrote: 32-bit applications on Windows normally only get virtual memory in the lower 2 GiB address space. Because of memory fragmentation, VirtualAlloc() usually won't get 1 GiB of contiguous virtual memory in

Re: [Qemu-devel] [PATCH] configure: Support system emulation with large memory on w32 hosts

2012-07-19 Thread Alexey Kardashevskiy
On 20/07/12 15:23, Stefan Weil wrote: Am 20.07.2012 05:53, schrieb Alexey Kardashevskiy: On 19/07/12 02:37, Stefan Weil wrote: 32-bit applications on Windows normally only get virtual memory in the lower 2 GiB address space. Because of memory fragmentation, VirtualAlloc() usually won't get 1

[Qemu-devel] [PATCH] configure: Don't implicitly hardcode list of KVM architectures

2012-07-18 Thread Peter Maydell
The code creating the symlink from linux-headers/asm to the architecture specific linux-headers/asm-$arch directory was implicitly hardcoding a list of KVM supporting architectures. Add a default case for the common Linux architecture name and QEMU CPU name match case, so future architectures will

Re: [Qemu-devel] [PATCH] configure: do not quote $PKG_CONFIG

2012-07-18 Thread Mike Frysinger
On Monday 16 July 2012 11:58:55 Stefan Weil wrote: Am 16.07.2012 17:39, schrieb Eric Blake: On 07/15/2012 01:54 PM, Stefan Weil wrote: Am 15.07.2012 22:26, schrieb Mike Frysinger: We should not quote the PKG_CONFIG setting as this deviates from the canonical upstream behavior that gets

[Qemu-devel] [PATCH] configure: Support system emulation with large memory on w32 hosts

2012-07-18 Thread Stefan Weil
32-bit applications on Windows normally only get virtual memory in the lower 2 GiB address space. Because of memory fragmentation, VirtualAlloc() usually won't get 1 GiB of contiguous virtual memory in that address space. Therefore running system emulations with 1 GiB or more RAM will abort with

[Qemu-devel] [PATCH] configure: fix ALSA configure test

2012-07-17 Thread Igor Mitsyanko
After commit 417c9d72d48275d19c60861896efd4962d21aca2 all configure tests are executed with -Werror flag. Current ALSA configure test program invokes a warning: warning: ‘handle’ is used uninitialized in this function [-Wuninitialized] which results in error with -Werror flag and, consequently,

Re: [Qemu-devel] [PATCH] configure: fix ALSA configure test

2012-07-17 Thread Igor Mitsyanko
I see now that this bug was already noticed, please ignore this mail On 07/17/2012 09:34 PM, Igor Mitsyanko wrote: After commit 417c9d72d48275d19c60861896efd4962d21aca2 all configure tests are executed with -Werror flag. Current ALSA configure test program invokes a warning: warning: ‘handle’

Re: [Qemu-devel] [PATCH] configure: fix ALSA configure test

2012-07-17 Thread Stefan Weil
Am 17.07.2012 20:03, schrieb Igor Mitsyanko: I see now that this bug was already noticed, please ignore this mail On 07/17/2012 09:34 PM, Igor Mitsyanko wrote: After commit 417c9d72d48275d19c60861896efd4962d21aca2 all configure tests are executed with -Werror flag. Current ALSA configure test

Re: [Qemu-devel] [PATCH] configure: fix ALSA configure test

2012-07-17 Thread Peter Maydell
On 17 July 2012 19:32, Stefan Weil s...@weilnetz.de wrote: Hello Anthony, hello Blue, these patches fix broken builds, therefore I expected that they would be applied fast: http://patchwork.ozlabs.org/patch/171066/ http://patchwork.ozlabs.org/patch/171067/

Re: [Qemu-devel] [PATCH] configure: fix ALSA configure test

2012-07-17 Thread Stefan Weil
Am 17.07.2012 20:46, schrieb Peter Maydell: On 17 July 2012 19:32, Stefan Weil s...@weilnetz.de wrote: Hello Anthony, hello Blue, these patches fix broken builds, therefore I expected that they would be applied fast: http://patchwork.ozlabs.org/patch/171066/

[Qemu-devel] [PATCH] configure: Don't run configure tests with -Werror enabled

2012-07-17 Thread Peter Maydell
Don't run configure tests with -Werror in the compiler flags. The idea of -Werror is that it makes problems very obvious to developers, so they get fixed quickly. However, when running configure tests, failures due to -Werror are far from obvious -- they simply result in the test quietly failing

<    4   5   6   7   8   9   10   11   12   >