QOM splits the destruction of a device in two phases:
- unrealize, also known as "exit" from qdev times, should isolate
the device from the guest. After unrealize returns, the guest
should not be able to issue new requests.
- instance_finalize will reclaim the memory. This is only called
Am 04.06.2013 20:51, schrieb Paolo Bonzini:
> This series changes all PCI devices (the sole to support hotplug
> _and_ use MemoryRegions) to do memory_region_del_subregion at
> unrealize time, and memory_region_destroy at instance_finalize
> time.
The general idea looks good.
Could you please fol
On Wed, Jun 05, 2013 at 11:50:52AM +0200, Andreas Färber wrote:
> Am 04.06.2013 20:51, schrieb Paolo Bonzini:
> > This series changes all PCI devices (the sole to support hotplug
> > _and_ use MemoryRegions) to do memory_region_del_subregion at
> > unrealize time, and memory_region_destroy at insta
Am 05.06.2013 13:10, schrieb Michael S. Tsirkin:
> On Wed, Jun 05, 2013 at 11:50:52AM +0200, Andreas Färber wrote:
>> Am 04.06.2013 20:51, schrieb Paolo Bonzini:
>>> This series changes all PCI devices (the sole to support hotplug
>>> _and_ use MemoryRegions) to do memory_region_del_subregion at
>>
On 5 June 2013 12:10, Michael S. Tsirkin wrote:
> unrealize is not a word in english:
The OED says:
# unˈrealize, v.
# trans. To make unreal; to deprive of reality.
with the earliest citation from 1804.
so if it seems like the best term (and it does make
clear the pairing with realize, which I
On Wed, Jun 05, 2013 at 12:38:35PM +0100, Peter Maydell wrote:
> On 5 June 2013 12:10, Michael S. Tsirkin wrote:
> > unrealize is not a word in english:
>
> The OED says:
> # unˈrealize, v.
> # trans. To make unreal; to deprive of reality.
>
> with the earliest citation from 1804.
>
> so if it
On Wed, Jun 05, 2013 at 01:32:17PM +0200, Andreas Färber wrote:
> Am 05.06.2013 13:10, schrieb Michael S. Tsirkin:
> > On Wed, Jun 05, 2013 at 11:50:52AM +0200, Andreas Färber wrote:
> >> Am 04.06.2013 20:51, schrieb Paolo Bonzini:
> >>> This series changes all PCI devices (the sole to support hotp
On Wed, Jun 05, 2013 at 12:38:35PM +0100, Peter Maydell wrote:
> On 5 June 2013 12:10, Michael S. Tsirkin wrote:
> > unrealize is not a word in english:
>
> The OED says:
> # unˈrealize, v.
> # trans. To make unreal; to deprive of reality.
>
> with the earliest citation from 1804.
So someone so
Am 05.06.2013 14:06, schrieb Michael S. Tsirkin:
> On Wed, Jun 05, 2013 at 01:32:17PM +0200, Andreas Färber wrote:
>> Am 05.06.2013 13:10, schrieb Michael S. Tsirkin:
>>> On Wed, Jun 05, 2013 at 11:50:52AM +0200, Andreas Färber wrote:
Am 04.06.2013 20:51, schrieb Paolo Bonzini:
> This seri
On Wed, Jun 05, 2013 at 02:23:03PM +0200, Andreas Färber wrote:
> Am 05.06.2013 14:06, schrieb Michael S. Tsirkin:
> > On Wed, Jun 05, 2013 at 01:32:17PM +0200, Andreas Färber wrote:
> >> Am 05.06.2013 13:10, schrieb Michael S. Tsirkin:
> >>> On Wed, Jun 05, 2013 at 11:50:52AM +0200, Andreas Färber
Am 05.06.2013 14:36, schrieb Michael S. Tsirkin:
>> Anyway, my point was, when moving stuff out of exit, we should also
>> change the signature to the new one - DeviceState* and (unused) Error**.
>> Then we're getting closer to removing the old exit field, and at that
>> point renaming individual h
"Michael S. Tsirkin" writes:
> On Wed, Jun 05, 2013 at 11:50:52AM +0200, Andreas Färber wrote:
>> Am 04.06.2013 20:51, schrieb Paolo Bonzini:
>> > This series changes all PCI devices (the sole to support hotplug
>> > _and_ use MemoryRegions) to do memory_region_del_subregion at
>> > unrealize tim
On Wed, Jun 05, 2013 at 07:53:05AM -0500, Anthony Liguori wrote:
> "Michael S. Tsirkin" writes:
>
> > On Wed, Jun 05, 2013 at 11:50:52AM +0200, Andreas Färber wrote:
> >> Am 04.06.2013 20:51, schrieb Paolo Bonzini:
> >> > This series changes all PCI devices (the sole to support hotplug
> >> > _an
Paolo Bonzini writes:
> QOM splits the destruction of a device in two phases:
>
> - unrealize, also known as "exit" from qdev times, should isolate
> the device from the guest. After unrealize returns, the guest
> should not be able to issue new requests.
>
> - instance_finalize will reclaim
On Wed, Jun 05, 2013 at 10:33:05AM -0500, Anthony Liguori wrote:
> "Michael S. Tsirkin" writes:
>
> > On Wed, Jun 05, 2013 at 07:53:05AM -0500, Anthony Liguori wrote:
> >> "Michael S. Tsirkin" writes:
> >>
> >> > On Wed, Jun 05, 2013 at 11:50:52AM +0200, Andreas Färber wrote:
> >> >> Am 04.06.2
"Michael S. Tsirkin" writes:
> On Wed, Jun 05, 2013 at 07:53:05AM -0500, Anthony Liguori wrote:
>> "Michael S. Tsirkin" writes:
>>
>> > On Wed, Jun 05, 2013 at 11:50:52AM +0200, Andreas Färber wrote:
>> >> Am 04.06.2013 20:51, schrieb Paolo Bonzini:
>> >> > This series changes all PCI devices (
On 5 June 2013 16:44, Michael S. Tsirkin wrote:
> On Wed, Jun 05, 2013 at 10:33:05AM -0500, Anthony Liguori wrote:
>> "finalize" is the standard name of the hook that gets called before
>> garbage collection as Andreas previously pointed out.
>
> I am simply asking for function names to tell us
>
Il 05/06/2013 05:50, Andreas Färber ha scritto:
> Am 04.06.2013 20:51, schrieb Paolo Bonzini:
>> This series changes all PCI devices (the sole to support hotplug
>> _and_ use MemoryRegions) to do memory_region_del_subregion at
>> unrealize time, and memory_region_destroy at instance_finalize
>> tim
Am 07.06.2013 03:03, schrieb Paolo Bonzini:
> Il 05/06/2013 05:50, Andreas Färber ha scritto:
>> Also I notice some patches are accessing parent fields directly - please
>> use BUS(), PCI_DEVICE() etc. to hide this.
>
> I'm always using them. For example:
>
> +static void intel_hda_instance_fina
Hi,
On Jun 7, 2013 11:04 AM, "Paolo Bonzini" wrote:
>
> Il 05/06/2013 05:50, Andreas Färber ha scritto:
> > Am 04.06.2013 20:51, schrieb Paolo Bonzini:
> >> This series changes all PCI devices (the sole to support hotplug
> >> _and_ use MemoryRegions) to do memory_region_del_subregion at
> >> unr
Il 07/06/2013 03:45, Andreas Färber ha scritto:
> Am 07.06.2013 03:03, schrieb Paolo Bonzini:
>> Il 05/06/2013 05:50, Andreas Färber ha scritto:
>>> Also I notice some patches are accessing parent fields directly - please
>>> use BUS(), PCI_DEVICE() etc. to hide this.
>>
>> I'm always using them.
Hi Peter,
Am 07.06.2013 10:41, schrieb Peter Crosthwaite:
> I have a series that fixes all qom cast macros for all PCI devices tree
> wide. Can post. Qom cast macros added as needed.
Sounds promising! I just CC'ed you on my ISA series v2, which touches on
PCI_BUS() in the final patch, dropping FR
22 matches
Mail list logo