On Wed, 05/02 09:44, Thomas Huth wrote:
> On 02.05.2018 09:29, Fam Zheng wrote:
> > On Tue, 05/01 22:41, Samuel Thibault wrote:
> >> Hello,
> >>
> >> I'm sorry I didn't find the time to have a look at it before.
> >>
> >> In general it looks good, just a few things:
> >>
> >> Samuel
> >>
> >> Fam Z
On 02.05.2018 09:45, Samuel Thibault wrote:
> Fam Zheng, le mer. 02 mai 2018 15:29:36 +0800, a ecrit:
>> On Tue, 05/01 22:41, Samuel Thibault wrote:
>>> I'm sorry I didn't find the time to have a look at it before.
>>>
>>> In general it looks good, just a few things:
>>>
>>> Samuel
>>>
>>> Fam Zhen
Fam Zheng, le mer. 02 mai 2018 15:29:36 +0800, a ecrit:
> On Tue, 05/01 22:41, Samuel Thibault wrote:
> > I'm sorry I didn't find the time to have a look at it before.
> >
> > In general it looks good, just a few things:
> >
> > Samuel
> >
> > Fam Zheng, le ven. 16 mars 2018 14:28:21 +0800, a ec
On 02.05.2018 09:29, Fam Zheng wrote:
> On Tue, 05/01 22:41, Samuel Thibault wrote:
>> Hello,
>>
>> I'm sorry I didn't find the time to have a look at it before.
>>
>> In general it looks good, just a few things:
>>
>> Samuel
>>
>> Fam Zheng, le ven. 16 mars 2018 14:28:21 +0800, a ecrit:
>>> +
On Tue, 05/01 22:41, Samuel Thibault wrote:
> Hello,
>
> I'm sorry I didn't find the time to have a look at it before.
>
> In general it looks good, just a few things:
>
> Samuel
>
> Fam Zheng, le ven. 16 mars 2018 14:28:21 +0800, a ecrit:
> > +if (!net_hub_id_for_client(&s->nc, &vlan))
Hello,
I'm sorry I didn't find the time to have a look at it before.
In general it looks good, just a few things:
Samuel
Fam Zheng, le ven. 16 mars 2018 14:28:21 +0800, a ecrit:
> +if (!net_hub_id_for_client(&s->nc, &vlan)) {
That makes me think that IIUC, we shouldn't call them vlan,
HMP "info usernet" has been available but it isn't ideal for programmed
use cases. This closes the gap in QMP by adding a counterpart
"query-usernet" command. It is basically translated from
the HMP slirp_connection_info() loop, which now calls the QMP
implementation and prints the data, just like
