Re: [Qemu-devel] [PATCH v2 02/13] hvf: add code base from Google's QEMU repository

2017-09-06 Thread Izik Eidus
On Wed, Sep 6, 2017 at 5:28 PM, Paolo Bonzini wrote: > Il 06 set 2017 3:29 PM, "Izik Eidus" ha scritto: > > Paolo, I was reviewing more and more our code and found another issue > regarding licensing of gpl2v+: the file x86_descr.c include: > #define

Re: [Qemu-devel] [PATCH v2 02/13] hvf: add code base from Google's QEMU repository

2017-09-06 Thread Paolo Bonzini
Il 06 set 2017 3:29 PM, "Izik Eidus" ha scritto: Paolo, I was reviewing more and more our code and found another issue regarding licensing of gpl2v+: the file x86_descr.c include: #define VMX_SEGMENT_FIELD(seg) that is coming from KVM that is gpl2 code. I don't think that's

Re: [Qemu-devel] [PATCH v2 02/13] hvf: add code base from Google's QEMU repository

2017-09-06 Thread Izik Eidus
On Mon, Sep 4, 2017 at 9:47 AM, Paolo Bonzini wrote: > > > > Il 03 set 2017 8:49 PM, "Izik Eidus" ha scritto: > > For now i want to get hypervisor framework merged into QEMU in required > license. I did offer to open source everything needed from anka to

Re: [Qemu-devel] [PATCH v2 02/13] hvf: add code base from Google's QEMU repository

2017-09-04 Thread Paolo Bonzini
Il 03 set 2017 8:49 PM, "Izik Eidus" ha scritto: For now i want to get hypervisor framework merged into QEMU in required license. I did offer to open source everything needed from anka to the make QEMU being able to run any os using hypervisor.framework. Having such code as

Re: [Qemu-devel] [PATCH v2 02/13] hvf: add code base from Google's QEMU repository

2017-09-03 Thread Izik Eidus
On Sun, Sep 3, 2017 at 8:13 PM, Paolo Bonzini > wrote: > > > Il 03 set 2017 6:54 PM, "Izik Eidus" > ha scritto: > > > What code is derived from v2-only

Re: [Qemu-devel] [PATCH v2 02/13] hvf: add code base from Google's QEMU repository

2017-09-03 Thread Paolo Bonzini
Il 03 set 2017 6:54 PM, "Izik Eidus" ha scritto: > What code is derived from v2-only sources? IIRC the task switch code is > derived from KVM, is there anything else? Yes this is exactly the code that I found as well, however considering the fact that I didn't even know it was

Re: [Qemu-devel] [PATCH v2 02/13] hvf: add code base from Google's QEMU repository

2017-09-03 Thread Izik Eidus
On Sun, Sep 3, 2017 at 7:35 PM, Paolo Bonzini wrote: > > > Il 03 set 2017 6:17 PM, "Izik Eidus" ha scritto: > > Hi, > > Paolo, my biggest challenge right now is: > hvf-all.c > it include currently the following copyright: > > // Copyright 2008 IBM

Re: [Qemu-devel] [PATCH v2 02/13] hvf: add code base from Google's QEMU repository

2017-09-03 Thread Sergio Andrés Gómez del Real
Just saw your last message. Will wait for Paolo's response. On Sun, Sep 3, 2017 at 11:33 AM, Sergio Andrés Gómez del Real < sergio.g.delr...@gmail.com> wrote: > Izik, sorry for the late response. Tell me if you have any further issue. > What are the 2 functions that couldn't be relicensed? > >

Re: [Qemu-devel] [PATCH v2 02/13] hvf: add code base from Google's QEMU repository

2017-09-03 Thread Paolo Bonzini
Il 03 set 2017 6:17 PM, "Izik Eidus" ha scritto: Hi, Paolo, my biggest challenge right now is: hvf-all.c it include currently the following copyright: // Copyright 2008 IBM Corporation // 2008 Red Hat, Inc. // Copyright 2011 Intel Corporation // Copyright 2016

Re: [Qemu-devel] [PATCH v2 02/13] hvf: add code base from Google's QEMU repository

2017-09-03 Thread Sergio Andrés Gómez del Real
Izik, sorry for the late response. Tell me if you have any further issue. What are the 2 functions that couldn't be relicensed? Stefan, as soon as relicensing is available I'll send v3 of the patchset. On Sun, Sep 3, 2017 at 8:00 AM, Izik Eidus wrote: > > > On Sun, Sep 3, 2017

Re: [Qemu-devel] [PATCH v2 02/13] hvf: add code base from Google's QEMU repository

2017-09-03 Thread Izik Eidus
Hi, Paolo, my biggest challenge right now is: hvf-all.c it include currently the following copyright: // Copyright 2008 IBM Corporation // 2008 Red Hat, Inc. // Copyright 2011 Intel Corporation // Copyright 2016 Veertu, Inc. // Copyright 2017 The Android Open Source Project and it

Re: [Qemu-devel] [PATCH v2 02/13] hvf: add code base from Google's QEMU repository

2017-09-03 Thread Izik Eidus
On Sun, Sep 3, 2017 at 9:23 AM, Paolo Bonzini wrote: > Il 01 set 2017 7:59 PM, "Izik Eidus" ha scritto: > > Hi, > > Sergio, I was trying to applying patch 1/13 and 2/13 and then I ran: > ./configure and saw: 'HVF support yes' > after that 'make' was

Re: [Qemu-devel] [PATCH v2 02/13] hvf: add code base from Google's QEMU repository

2017-09-03 Thread Paolo Bonzini
Il 01 set 2017 7:59 PM, "Izik Eidus" ha scritto: Hi, Sergio, I was trying to applying patch 1/13 and 2/13 and then I ran: ./configure and saw: 'HVF support yes' after that 'make' was happy and: ./x86_64-softmmu/qemu-system-x86_64 --help | grep accel \

Re: [Qemu-devel] [PATCH v2 02/13] hvf: add code base from Google's QEMU repository

2017-09-02 Thread Izik Eidus
On Fri, Sep 1, 2017 at 12:21 AM, Paolo Bonzini wrote: > Il 31 ago 2017 3:54 PM, "Izik Eidus" ha scritto: > > > Izik, Vincent (assuming you are the right person to contact at Google), > > can you reply to Daniel and Stefan? > > > > Hi, > > What I suggest is

Re: [Qemu-devel] [PATCH v2 02/13] hvf: add code base from Google's QEMU repository

2017-09-01 Thread Izik Eidus
Hi, Sergio, I was trying to applying patch 1/13 and 2/13 and then I ran: ./configure and saw: 'HVF support yes' after that 'make' was happy and: ./x86_64-softmmu/qemu-system-x86_64 --help | grep accel \property accel=accel1[:accel2[:...]] selects accelerator

Re: [Qemu-devel] [PATCH v2 02/13] hvf: add code base from Google's QEMU repository

2017-09-01 Thread Daniel P. Berrange
On Fri, Sep 01, 2017 at 01:10:54AM +0300, Izik Eidus wrote: > (BTW, I am pretty sure the copyright message that include GPLv2/GPLv3 and > created all this mess was taken from QEMU itself ... :)) Sigh, you are right there. I've just checked and found a random splattering of files with

Re: [Qemu-devel] [PATCH v2 02/13] hvf: add code base from Google's QEMU repository

2017-09-01 Thread Frank Yang via Qemu-devel
+ our product manager If I understand correctly, we will need to reconsider things if I included any additional technology in my port. However, I didn't include any additional references/source in my port compared to Veertu, that was not in the qemu code already (e.g., hax-all/kvm-all) so I think

Re: [Qemu-devel] [PATCH v2 02/13] hvf: add code base from Google's QEMU repository

2017-08-31 Thread Izik Eidus
On Fri, Sep 1, 2017 at 1:02 AM, Frank Yang wrote: > + our product manager > > If I understand correctly, we will need to reconsider things if I included > any additional technology in my port. However, I didn't include any > additional references/source in my port compared to

Re: [Qemu-devel] [PATCH v2 02/13] hvf: add code base from Google's QEMU repository

2017-08-31 Thread Sergio Andrés Gómez del Real
Hello, Mr. Frank Yang was the guy at Google that introduced the HVF port to Google's Android Emulator QEMU branch. Frank, in this thread we are discussing the licensing issue with the HVF files (their being GPL v2-only). Paolo from Red Hat was asking to Veertu developer Izik Eidus if the code in

Re: [Qemu-devel] [PATCH v2 02/13] hvf: add code base from Google's QEMU repository

2017-08-31 Thread Izik Eidus
On Fri, Sep 1, 2017 at 12:21 AM, Paolo Bonzini wrote: > Il 31 ago 2017 3:54 PM, "Izik Eidus" ha scritto: > > > Izik, Vincent (assuming you are the right person to contact at Google), > > can you reply to Daniel and Stefan? > > > > Hi, > > What I suggest is

Re: [Qemu-devel] [PATCH v2 02/13] hvf: add code base from Google's QEMU repository

2017-08-31 Thread Paolo Bonzini
Il 31 ago 2017 3:54 PM, "Izik Eidus" ha scritto: > Izik, Vincent (assuming you are the right person to contact at Google), > can you reply to Daniel and Stefan? > Hi, What I suggest is that we will send our patch' again as gpl2+ and clean the entire stuff to make sure they are

Re: [Qemu-devel] [PATCH v2 02/13] hvf: add code base from Google's QEMU repository

2017-08-31 Thread Izik Eidus
On Thu, Aug 31, 2017 at 2:26 PM, Paolo Bonzini wrote: > > > Il 31 ago 2017 9:43 AM, "Stefan Hajnoczi" ha scritto: > > On Wed, Aug 30, 2017 at 03:07:38PM +0100, Daniel P. Berrange wrote: > > On Wed, Aug 30, 2017 at 03:26:51AM -0500, Sergio Andres Gomez

Re: [Qemu-devel] [PATCH v2 02/13] hvf: add code base from Google's QEMU repository

2017-08-31 Thread Paolo Bonzini
Il 31 ago 2017 9:43 AM, "Stefan Hajnoczi" ha scritto: On Wed, Aug 30, 2017 at 03:07:38PM +0100, Daniel P. Berrange wrote: > On Wed, Aug 30, 2017 at 03:26:51AM -0500, Sergio Andres Gomez Del Real wrote: > > diff --git a/target/i386/hvf-utils/x86.c b/target/i386/hvf-utils/x86.c

Re: [Qemu-devel] [PATCH v2 02/13] hvf: add code base from Google's QEMU repository

2017-08-31 Thread Stefan Hajnoczi
On Wed, Aug 30, 2017 at 03:26:51AM -0500, Sergio Andres Gomez Del Real wrote: > This file begins tracking the files that will be the code base for HVF > support in QEMU. This code base is part of Google's QEMU version of > their Android emulator, and can be found at >

Re: [Qemu-devel] [PATCH v2 02/13] hvf: add code base from Google's QEMU repository

2017-08-31 Thread Stefan Hajnoczi
On Wed, Aug 30, 2017 at 03:07:38PM +0100, Daniel P. Berrange wrote: > On Wed, Aug 30, 2017 at 03:26:51AM -0500, Sergio Andres Gomez Del Real wrote: > > diff --git a/target/i386/hvf-utils/x86.c b/target/i386/hvf-utils/x86.c > > new file mode 100644 > > index 00..e3db2c9c8b > > --- /dev/null

Re: [Qemu-devel] [PATCH v2 02/13] hvf: add code base from Google's QEMU repository

2017-08-30 Thread Daniel P. Berrange
On Wed, Aug 30, 2017 at 03:26:51AM -0500, Sergio Andres Gomez Del Real wrote: > This file begins tracking the files that will be the code base for HVF > support in QEMU. This code base is part of Google's QEMU version of > their Android emulator, and can be found at >