Re: [Qemu-devel] [PATCH v3 4/5] qmp: add monitor command to add/remove a child

2015-09-16 Thread Wen Congyang
On 09/15/2015 03:49 PM, Markus Armbruster wrote: > Wen Congyang writes: > >> On 09/14/2015 10:36 PM, Markus Armbruster wrote: >>> Wen Congyang writes: >>> Signed-off-by: Wen Congyang Signed-off-by: zhanghailiang

Re: [Qemu-devel] [PATCH v3 4/5] qmp: add monitor command to add/remove a child

2015-09-16 Thread Markus Armbruster
Wen Congyang writes: > On 09/15/2015 03:49 PM, Markus Armbruster wrote: >> Wen Congyang writes: >> >>> On 09/14/2015 10:36 PM, Markus Armbruster wrote: Wen Congyang writes: > Signed-off-by: Wen Congyang

Re: [Qemu-devel] [PATCH v3 4/5] qmp: add monitor command to add/remove a child

2015-09-15 Thread Wen Congyang
On 09/15/2015 03:49 PM, Markus Armbruster wrote: > Wen Congyang writes: > >> On 09/14/2015 10:36 PM, Markus Armbruster wrote: >>> Wen Congyang writes: >>> Signed-off-by: Wen Congyang Signed-off-by: zhanghailiang

Re: [Qemu-devel] [PATCH v3 4/5] qmp: add monitor command to add/remove a child

2015-09-15 Thread Markus Armbruster
Wen Congyang writes: > On 09/14/2015 10:36 PM, Markus Armbruster wrote: >> Wen Congyang writes: >> >>> Signed-off-by: Wen Congyang >>> Signed-off-by: zhanghailiang >>> Signed-off-by: Gonglei

Re: [Qemu-devel] [PATCH v3 4/5] qmp: add monitor command to add/remove a child

2015-09-15 Thread Alberto Garcia
On Mon 14 Sep 2015 05:37:00 PM CEST, Kevin Wolf wrote: >> +{ 'command': 'x-child-add', >> + 'data' : { 'parent': 'str', 'child': 'str' } } > > This is probably not future-proof and only made for the special case > of quorum. Specifically, one thing I'm missing is some way to

Re: [Qemu-devel] [PATCH v3 4/5] qmp: add monitor command to add/remove a child

2015-09-15 Thread Kevin Wolf
Am 15.09.2015 um 10:56 hat Alberto Garcia geschrieben: > On Mon 14 Sep 2015 05:37:00 PM CEST, Kevin Wolf wrote: > > >> +{ 'command': 'x-child-add', > >> + 'data' : { 'parent': 'str', 'child': 'str' } } > > > > This is probably not future-proof and only made for the special

Re: [Qemu-devel] [PATCH v3 4/5] qmp: add monitor command to add/remove a child

2015-09-14 Thread Markus Armbruster
Wen Congyang writes: > Signed-off-by: Wen Congyang > Signed-off-by: zhanghailiang > Signed-off-by: Gonglei > --- > blockdev.c | 47 ++ >

Re: [Qemu-devel] [PATCH v3 4/5] qmp: add monitor command to add/remove a child

2015-09-14 Thread Kevin Wolf
Am 14.09.2015 um 16:36 hat Markus Armbruster geschrieben: > Wen Congyang writes: > > diff --git a/qmp-commands.hx b/qmp-commands.hx > > index 495670b..139a23b 100644 > > --- a/qmp-commands.hx > > +++ b/qmp-commands.hx > > @@ -4053,6 +4053,59 @@ Example: > > EQMP > > > >

Re: [Qemu-devel] [PATCH v3 4/5] qmp: add monitor command to add/remove a child

2015-09-14 Thread Kevin Wolf
Am 10.09.2015 um 11:55 hat Wen Congyang geschrieben: > +## > +# @x-child-add > +# > +# Add a new child to the parent BDS. Currently only the Quorum driver > +# implements this feature. This is useful to fix a broken quorum child. > +# > +# @parent: graph node name or id which the child will be

Re: [Qemu-devel] [PATCH v3 4/5] qmp: add monitor command to add/remove a child

2015-09-14 Thread Markus Armbruster
Kevin Wolf writes: > Am 14.09.2015 um 16:36 hat Markus Armbruster geschrieben: >> Wen Congyang writes: >> > diff --git a/qmp-commands.hx b/qmp-commands.hx >> > index 495670b..139a23b 100644 >> > --- a/qmp-commands.hx >> > +++ b/qmp-commands.hx >> > @@

Re: [Qemu-devel] [PATCH v3 4/5] qmp: add monitor command to add/remove a child

2015-09-14 Thread Wen Congyang
On 09/14/2015 10:36 PM, Markus Armbruster wrote: > Wen Congyang writes: > >> Signed-off-by: Wen Congyang >> Signed-off-by: zhanghailiang >> Signed-off-by: Gonglei >> --- >> blockdev.c

Re: [Qemu-devel] [PATCH v3 4/5] qmp: add monitor command to add/remove a child

2015-09-14 Thread Wen Congyang
On 09/14/2015 11:37 PM, Kevin Wolf wrote: > Am 10.09.2015 um 11:55 hat Wen Congyang geschrieben: >> +## >> +# @x-child-add >> +# >> +# Add a new child to the parent BDS. Currently only the Quorum driver >> +# implements this feature. This is useful to fix a broken quorum child. >> +# >> +#

[Qemu-devel] [PATCH v3 4/5] qmp: add monitor command to add/remove a child

2015-09-10 Thread Wen Congyang
Signed-off-by: Wen Congyang Signed-off-by: zhanghailiang Signed-off-by: Gonglei --- blockdev.c | 47 ++ qapi/block-core.json | 34

Re: [Qemu-devel] [PATCH v3 4/5] qmp: add monitor command to add/remove a child

2015-09-10 Thread Wen Congyang
On 09/10/2015 06:04 PM, Daniel P. Berrange wrote: > On Thu, Sep 10, 2015 at 05:55:04PM +0800, Wen Congyang wrote: >> Signed-off-by: Wen Congyang >> Signed-off-by: zhanghailiang >> Signed-off-by: Gonglei >> --- >>

Re: [Qemu-devel] [PATCH v3 4/5] qmp: add monitor command to add/remove a child

2015-09-10 Thread Daniel P. Berrange
On Thu, Sep 10, 2015 at 05:55:04PM +0800, Wen Congyang wrote: > Signed-off-by: Wen Congyang > Signed-off-by: zhanghailiang > Signed-off-by: Gonglei > --- > blockdev.c | 47