On Thu, Nov 22, 2012 at 2:22 PM, Christian Borntraeger
wrote:
> On 22/11/12 13:02, Markus Armbruster wrote:
>
> Thanks for the review, Stefan already applied the patch, though.
> Is there anything that you really want to have a followup patch
> besides this one?
Follow-up patches are probably the
Christian Borntraeger writes:
> On 22/11/12 13:02, Markus Armbruster wrote:
>
> Thanks for the review, Stefan already applied the patch, though.
> Is there anything that you really want to have a followup patch
> besides this one?
"Really want" is too strong, but improving the comment on the def
Markus Armbruster writes:
> Christian Borntraeger writes:
>
>> There are QEMUMachines that have neither IF_IDE nor IF_SCSI as a
>> default/standard interface to their block devices / drives. Therefore,
>> this patch introduces a new field default_block_type per QEMUMachine
>> struct. The prior u
On 22/11/12 13:02, Markus Armbruster wrote:
Thanks for the review, Stefan already applied the patch, though.
Is there anything that you really want to have a followup patch
besides this one?
> There's just one caller that passes IF_DEFAULT. We could change it to
> pass machine->block_default_typ
On Tue, Nov 20, 2012 at 03:30:34PM +0100, Christian Borntraeger wrote:
> There are QEMUMachines that have neither IF_IDE nor IF_SCSI as a
> default/standard interface to their block devices / drives. Therefore,
> this patch introduces a new field default_block_type per QEMUMachine
> struct. The pri
Christian Borntraeger writes:
> There are QEMUMachines that have neither IF_IDE nor IF_SCSI as a
> default/standard interface to their block devices / drives. Therefore,
> this patch introduces a new field default_block_type per QEMUMachine
> struct. The prior use_scsi field becomes thereby obsol
On 21/11/12 13:07, Igor Mitsyanko wrote:
> This version of patch doesn't change anything for majority of machines, its
> just that later we can
> choose ourself which default block interface to use. So, nothing to review
> from Exynos point of view, but patch
> is OK, except realview_pb_a8 part (
This version of patch doesn't change anything for majority of machines,
its just that later we can
choose ourself which default block interface to use. So, nothing to
review from Exynos point of view, but patch
is OK, except realview_pb_a8 part (see bellow):
Acked-by: Igor Mitsyanko
On 11/20
On 20/11/12 15:49, Alexander Graf wrote:
> On 11/20/2012 03:30 PM, Christian Borntraeger wrote:
>> There are QEMUMachines that have neither IF_IDE nor IF_SCSI as a
>> default/standard interface to their block devices / drives. Therefore,
>> this patch introduces a new field default_block_type per Q
On 11/20/2012 03:30 PM, Christian Borntraeger wrote:
There are QEMUMachines that have neither IF_IDE nor IF_SCSI as a
default/standard interface to their block devices / drives. Therefore,
this patch introduces a new field default_block_type per QEMUMachine
struct. The prior use_scsi field become
There are QEMUMachines that have neither IF_IDE nor IF_SCSI as a
default/standard interface to their block devices / drives. Therefore,
this patch introduces a new field default_block_type per QEMUMachine
struct. The prior use_scsi field becomes thereby obsolete and is
replaced through .default_blo
11 matches
Mail list logo
