Re: [Qemu-devel] [PATCHv4 09/13] lance: move TYPE_LANCE and SysBusPCNetState from lance.c to lance.h

2017-10-30 Thread Mark Cave-Ayland
On 30/10/17 18:45, Philippe Mathieu-Daudé wrote: >>> +/* >>> + * QEMU AMD PC-Net II (Am79C970A) emulation >> >> Filename says this is Lance ethernet, but the comment says it's PC-Net ? > > According to the datasheet for Am79C970A, the original Lance is an > Am7990 devic

Re: [Qemu-devel] [PATCHv4 09/13] lance: move TYPE_LANCE and SysBusPCNetState from lance.c to lance.h

2017-10-30 Thread Philippe Mathieu-Daudé
Hi Mark, >> +/* >> + * QEMU AMD PC-Net II (Am79C970A) emulation > > Filename says this is Lance ethernet, but the comment says it's PC-Net ? According to the datasheet for Am79C970A, the original Lance is an Am7990 device and the Am79C970A aka PCNet-PCI II as emulate

Re: [Qemu-devel] [PATCHv4 09/13] lance: move TYPE_LANCE and SysBusPCNetState from lance.c to lance.h

2017-10-30 Thread Mark Cave-Ayland
On 30/10/17 13:22, Peter Maydell wrote: > On 30 October 2017 at 13:10, Mark Cave-Ayland > wrote: >> On 26/10/17 11:12, Mark Cave-Ayland wrote: >>> On 25/10/17 18:47, Peter Maydell wrote: On 25 October 2017 at 16:59, Mark Cave-Ayland wrote: > --- /dev/null > +++ b/include/hw/net/lance

Re: [Qemu-devel] [PATCHv4 09/13] lance: move TYPE_LANCE and SysBusPCNetState from lance.c to lance.h

2017-10-30 Thread Peter Maydell
On 30 October 2017 at 13:10, Mark Cave-Ayland wrote: > On 26/10/17 11:12, Mark Cave-Ayland wrote: >> On 25/10/17 18:47, Peter Maydell wrote: >>> On 25 October 2017 at 16:59, Mark Cave-Ayland wrote: --- /dev/null +++ b/include/hw/net/lance.h @@ -0,0 +1,41 @@ +/* + * QEMU AM

Re: [Qemu-devel] [PATCHv4 09/13] lance: move TYPE_LANCE and SysBusPCNetState from lance.c to lance.h

2017-10-30 Thread Mark Cave-Ayland
On 26/10/17 11:12, Mark Cave-Ayland wrote: > On 25/10/17 18:47, Peter Maydell wrote: > >> On 25 October 2017 at 16:59, Mark Cave-Ayland >> wrote: >>> This enables them to be used outside of lance.c. >>> >>> Signed-off-by: Mark Cave-Ayland >>> CC: Jason Wang >> >> >>> diff --git a/include/hw/ne

Re: [Qemu-devel] [PATCHv4 09/13] lance: move TYPE_LANCE and SysBusPCNetState from lance.c to lance.h

2017-10-27 Thread Philippe Mathieu-Daudé
On 10/25/2017 12:59 PM, Mark Cave-Ayland wrote: > This enables them to be used outside of lance.c. > > Signed-off-by: Mark Cave-Ayland Reviewed-by: Philippe Mathieu-Daudé > CC: Jason Wang > --- > hw/net/lance.c | 11 +-- > include/hw/net/lance.h | 41 +

Re: [Qemu-devel] [PATCHv4 09/13] lance: move TYPE_LANCE and SysBusPCNetState from lance.c to lance.h

2017-10-26 Thread Mark Cave-Ayland
On 25/10/17 18:47, Peter Maydell wrote: > On 25 October 2017 at 16:59, Mark Cave-Ayland > wrote: >> This enables them to be used outside of lance.c. >> >> Signed-off-by: Mark Cave-Ayland >> CC: Jason Wang > > >> diff --git a/include/hw/net/lance.h b/include/hw/net/lance.h >> new file mode 100

Re: [Qemu-devel] [PATCHv4 09/13] lance: move TYPE_LANCE and SysBusPCNetState from lance.c to lance.h

2017-10-25 Thread Peter Maydell
On 25 October 2017 at 16:59, Mark Cave-Ayland wrote: > This enables them to be used outside of lance.c. > > Signed-off-by: Mark Cave-Ayland > CC: Jason Wang > diff --git a/include/hw/net/lance.h b/include/hw/net/lance.h > new file mode 100644 > index 000..c112fbc > --- /dev/null > +++ b/in

[Qemu-devel] [PATCHv4 09/13] lance: move TYPE_LANCE and SysBusPCNetState from lance.c to lance.h

2017-10-25 Thread Mark Cave-Ayland
This enables them to be used outside of lance.c. Signed-off-by: Mark Cave-Ayland CC: Jason Wang --- hw/net/lance.c | 11 +-- include/hw/net/lance.h | 41 + 2 files changed, 42 insertions(+), 10 deletions(-) create mode 100644 include/