Re: [PATCH v2 0/8] aspeed: Add boot from eMMC support (AST2600)

2024-07-18 Thread Cédric Le Goater
On 7/17/24 08:30, Cédric Le Goater wrote: Hello, This series enables boot from eMMC on the rainier-bmc machine, which is the default behavior and also on the AST2600 EVB using a machine option to change the default. First 6 patches adjust the machine setup and HW strapping to boot from eMMC, th

Re: [PATCH v2 0/8] aspeed: Add boot from eMMC support (AST2600)

2024-07-17 Thread Philippe Mathieu-Daudé
On 17/7/24 08:30, Cédric Le Goater wrote: Cédric Le Goater (8): aspeed: Change type of eMMC device aspeed: Load eMMC first boot area as a boot rom aspeed/scu: Add boot-from-eMMC HW strapping bit for AST2600 SoC aspeed: Introduce a AspeedSoCClass 'boot_from_emmc' handler aspeed: Tu

[PATCH v2 0/8] aspeed: Add boot from eMMC support (AST2600)

2024-07-16 Thread Cédric Le Goater
Hello, This series enables boot from eMMC on the rainier-bmc machine, which is the default behavior and also on the AST2600 EVB using a machine option to change the default. First 6 patches adjust the machine setup and HW strapping to boot from eMMC, the last 2 are for the AST2600 EVB and are opt

Re: [PATCH v49 00/11] hw/sd/sdcard: Add eMMC support

2024-07-16 Thread Philippe Mathieu-Daudé
Series queued, thanks.

[PULL 01/11] hw/sd/sdcard: Basis for eMMC support

2024-07-16 Thread Philippe Mathieu-Daudé
From: Philippe Mathieu-Daudé Since eMMC are soldered on boards, it is not user-creatable. RCA register is initialized to 0x0001, per spec v4.3, chapter 8.5 "RCA register": The default value of the RCA register is 0x0001. The value 0x is reserved to set all cards into the Stand-by Stat

Re: [PATCH v49 00/11] hw/sd/sdcard: Add eMMC support

2024-07-12 Thread Cédric Le Goater
uc Michel (1): hw/sd/sdcard: Implement eMMC sleep state (CMD5) Philippe Mathieu-Daudé (5): hw/sd/sdcard: Basis for eMMC support hw/sd/sdcard: Register generic command handlers hw/sd/sdcard: Register unimplemented command handlers hw/sd/sdcard: Add emmc_cmd_PROGRAM_CID handler (CMD26)

[PATCH v49 00/11] hw/sd/sdcard: Add eMMC support

2024-07-12 Thread Philippe Mathieu-Daudé
oater (2): hw/sd/sdcard: Add emmc_cmd_SET_RELATIVE_ADDR handler (CMD3) hw/sd/sdcard: Fix SET_BLOCK_COUNT command argument on eMMC (CMD23) Joel Stanley (1): hw/sd/sdcard: Support boot area in emmc image Luc Michel (1): hw/sd/sdcard: Implement eMMC sleep state (CMD5) Philippe Mathieu-Daudé (5): hw/sd/sdcard:

[PATCH v49 01/11] hw/sd/sdcard: Basis for eMMC support

2024-07-12 Thread Philippe Mathieu-Daudé
From: Philippe Mathieu-Daudé Since eMMC are soldered on boards, it is not user-creatable. RCA register is initialized to 0x0001, per spec v4.3, chapter 8.5 "RCA register": The default value of the RCA register is 0x0001. The value 0x is reserved to set all cards into the Stand-by Stat

Re: [PATCH v48 00/12] hw/sd/sdcard: Add eMMC support

2024-07-11 Thread Philippe Mathieu-Daudé
On 11/7/24 13:03, Cédric Le Goater wrote: Hello, On 7/10/24 4:13 PM, Philippe Mathieu-Daudé wrote: Tag to test Aspeed tree:    https://gitlab.com/philmd/qemu/-/tags/aspeed_emmc-v8 I gave this branch a try and the rainier machine boots correctly with a baked emmc image :   Tested-by: Cédric

Re: [PATCH v48 00/12] hw/sd/sdcard: Add eMMC support

2024-07-11 Thread Cédric Le Goater
: Fix SET_BLOCK_COUNT command argument on eMMC (CMD23) Joel Stanley (1): hw/sd/sdcard: Support boot area in emmc image Luc Michel (1): hw/sd/sdcard: Implement eMMC sleep state (CMD5) Philippe Mathieu-Daudé (6): hw/sd/sdcard: Basis for eMMC support hw/sd/sdcard: Register generic com

Re: [PATCH v48 00/12] hw/sd/sdcard: Add eMMC support

2024-07-10 Thread Cédric Le Goater
-Daudé (6):    hw/sd/sdcard: Basis for eMMC support    hw/sd/sdcard: Register generic command handlers    hw/sd/sdcard: Register unimplemented command handlers    hw/sd/sdcard: Add mmc_cmd_PROGRAM_CID handler (CMD26)    hw/sd/sdcard: Add eMMC 'boot-size' property    hw/sd/sdcard: Implement

Re: [PATCH v48 00/12] hw/sd/sdcard: Add eMMC support

2024-07-10 Thread Philippe Mathieu-Daudé
emmc_cmd_SET_RELATIVE_ADDR handler (CMD3)    hw/sd/sdcard: Fix SET_BLOCK_COUNT command argument on eMMC (CMD23) Joel Stanley (1):    hw/sd/sdcard: Support boot area in emmc image Luc Michel (1):    hw/sd/sdcard: Implement eMMC sleep state (CMD5) Philippe Mathieu-Daudé (6):    hw/sd/sdcard: Basis for eMMC support

Re: [PATCH v48 00/12] hw/sd/sdcard: Add eMMC support

2024-07-10 Thread Cédric Le Goater
upport boot area in emmc image Luc Michel (1): hw/sd/sdcard: Implement eMMC sleep state (CMD5) Philippe Mathieu-Daudé (6): hw/sd/sdcard: Basis for eMMC support hw/sd/sdcard: Register generic command handlers hw/sd/sdcard: Register unimplemented command handlers hw/sd/sdcard: Add mmc

[PATCH v48 00/12] hw/sd/sdcard: Add eMMC support

2024-07-10 Thread Philippe Mathieu-Daudé
rd: Implement eMMC sleep state (CMD5) Philippe Mathieu-Daudé (6): hw/sd/sdcard: Basis for eMMC support hw/sd/sdcard: Register generic command handlers hw/sd/sdcard: Register unimplemented command handlers hw/sd/sdcard: Add mmc_cmd_PROGRAM_CID handler (CMD26) hw/sd/sdcard: Add eMMC 

[PATCH v48 01/12] hw/sd/sdcard: Basis for eMMC support

2024-07-10 Thread Philippe Mathieu-Daudé
From: Philippe Mathieu-Daudé Since eMMC are soldered on boards, it is not user-creatable. RCA register is initialized to 0x0001, per spec v4.3, chapter 8.5 "RCA register": The default value of the RCA register is 0x0001. The value 0x is reserved to set all cards into the Stand-by Stat

Re: [PATCH v47 00/19] hw/sd/sdcard: Add eMMC support

2024-07-10 Thread Cédric Le Goater
On 7/10/24 6:58 AM, Cédric Le Goater wrote: On 7/9/24 11:39 PM, Philippe Mathieu-Daudé wrote: On 9/7/24 17:58, Cédric Le Goater wrote: On 7/9/24 5:25 PM, Philippe Mathieu-Daudé wrote: Since v42: - Stick to spec v4.3 (re-simplified EXT_CSD register & migrate) - Fill CID register - Few changes t

Re: [PATCH v47 00/19] hw/sd/sdcard: Add eMMC support

2024-07-09 Thread Cédric Le Goater
On 7/9/24 11:39 PM, Philippe Mathieu-Daudé wrote: On 9/7/24 17:58, Cédric Le Goater wrote: On 7/9/24 5:25 PM, Philippe Mathieu-Daudé wrote: Since v42: - Stick to spec v4.3 (re-simplified EXT_CSD register & migrate) - Fill CID register - Few changes to CSD register - Implement 'boot-mode' reset

Re: [PATCH v47 00/19] hw/sd/sdcard: Add eMMC support

2024-07-09 Thread Philippe Mathieu-Daudé
On 9/7/24 17:58, Cédric Le Goater wrote: On 7/9/24 5:25 PM, Philippe Mathieu-Daudé wrote: Since v42: - Stick to spec v4.3 (re-simplified EXT_CSD register & migrate) - Fill CID register - Few changes to CSD register - Implement 'boot-mode' reset timing - Add 'boot-size' property Change required

Re: [PATCH v47 00/19] hw/sd/sdcard: Add eMMC support

2024-07-09 Thread Cédric Le Goater
rt boot area in emmc image hw/sd/sdcard: Subtract bootarea size from blk hw/sd/sdcard: Add boot config support Luc Michel (1): hw/sd/sdcard: Implement eMMC sleep state (CMD5) Philippe Mathieu-Daudé (11): hw/sd/sdcard: Basis for eMMC support hw/sd/sdcard: Register generic command hand

[PATCH v47 01/19] hw/sd/sdcard: Basis for eMMC support

2024-07-09 Thread Philippe Mathieu-Daudé
From: Philippe Mathieu-Daudé Add basis for supporting eMMC. Since eMMC are soldered on boards, it is not user-creatable. Currently TYPE_EMMC is just a stub, so disabled (marked abstract). RCA register is initialized to 1, per spec v4.3, chapter 8.5 "RCA register": The default value of the R

[PATCH v47 00/19] hw/sd/sdcard: Add eMMC support

2024-07-09 Thread Philippe Mathieu-Daudé
el Stanley (3): hw/sd/sdcard: Support boot area in emmc image hw/sd/sdcard: Subtract bootarea size from blk hw/sd/sdcard: Add boot config support Luc Michel (1): hw/sd/sdcard: Implement eMMC sleep state (CMD5) Philippe Mathieu-Daudé (11): hw/sd/sdcard: Basis for eMMC support hw/sd/sdca

Re: [PATCH v46 0/5] hw/sd/sdcard: Cleanups before adding eMMC support

2024-07-05 Thread Philippe Mathieu-Daudé
On 3/7/24 15:43, Philippe Mathieu-Daudé wrote: Philippe Mathieu-Daudé (5): hw/sd/sdcard: Use spec v3.01 by default hw/sd/sdcard: Add sd_cmd_GEN_CMD handler (CMD56) hw/sd/sdcard: Rename sd_cmd_SEND_OP_COND handler hw/sd/sdcard: Introduce set_csd/set_cid handlers hw/sd/sdcard: Extra

Re: [PATCH v46 0/5] hw/sd/sdcard: Cleanups before adding eMMC support

2024-07-05 Thread Cédric Le Goater
On 7/3/24 3:43 PM, Philippe Mathieu-Daudé wrote: (patches from v42 already reviewed not reposted) Since v45: - RAZ/WI on GEN_CMD (Luc & Manos) - Rename sd_cmd_SEND_OP_COND - Introduce TYPE_SDMMC_COMMON Philippe Mathieu-Daudé (5): hw/sd/sdcard: Use spec v3.01 by default hw/sd/sdcard: Add s

Re: [PATCH v46 0/5] hw/sd/sdcard: Cleanups before adding eMMC support

2024-07-05 Thread Philippe Mathieu-Daudé
On 3/7/24 15:43, Philippe Mathieu-Daudé wrote: (patches from v42 already reviewed not reposted) Since v45: - RAZ/WI on GEN_CMD (Luc & Manos) - Rename sd_cmd_SEND_OP_COND - Introduce TYPE_SDMMC_COMMON Philippe Mathieu-Daudé (5): hw/sd/sdcard: Use spec v3.01 by default hw/sd/sdcard: Add sd_

Re: [PATCH 0/8] aspeed: Add boot from eMMC support (AST2600)

2024-07-04 Thread Andrew Jeffery
On Thu, 2024-07-04 at 07:36 +0200, Cédric Le Goater wrote: > From: Cédric Le Goater > > Hello, > > This series enables boot from eMMC on the rainier-bmc machine, which > is the default behavior and also on the AST2600 EVB using a machine > option to change the default. > > It depends solely on

[PATCH 0/8] aspeed: Add boot from eMMC support (AST2600)

2024-07-03 Thread Cédric Le Goater
From: Cédric Le Goater Hello, This series enables boot from eMMC on the rainier-bmc machine, which is the default behavior and also on the AST2600 EVB using a machine option to change the default. It depends solely on the availability of an eMMC device model which is currently being discussed u

[PATCH v46 0/5] hw/sd/sdcard: Cleanups before adding eMMC support

2024-07-03 Thread Philippe Mathieu-Daudé
(patches from v42 already reviewed not reposted) Since v45: - RAZ/WI on GEN_CMD (Luc & Manos) - Rename sd_cmd_SEND_OP_COND - Introduce TYPE_SDMMC_COMMON Philippe Mathieu-Daudé (5): hw/sd/sdcard: Use spec v3.01 by default hw/sd/sdcard: Add sd_cmd_GEN_CMD handler (CMD56) hw/sd/sdcard: Rename

[PATCH v45 0/3] hw/sd/sdcard: Cleanups before adding eMMC support

2024-07-03 Thread Philippe Mathieu-Daudé
(patches from v42 already reviewed not reposted) - Addressed review comments from Daniel & Luc wrt migration - Remove old comment Philippe Mathieu-Daudé (3): hw/sd/sdcard: Remove leftover comment about removed 'spi' Property hw/sd/sdcard: Use spec v3.01 by default hw/sd/sdcard: Do not store

[PATCH v44 0/3] hw/sd/sdcard: Cleanups before adding eMMC support

2024-07-03 Thread Philippe Mathieu-Daudé
(patches from v42 already reviewed not reposted) - Addressed review comments from Daniel & Luc wrt migration - Remove old comment Philippe Mathieu-Daudé (3): hw/sd/sdcard: Use spec v3.01 by default hw/sd/sdcard: Do not store vendor data on block drive (CMD56) hw/sd/sdcard: Remove leftover c

[PATCH v43 0/2] hw/sd/sdcard: Cleanups before adding eMMC support

2024-07-02 Thread Philippe Mathieu-Daudé
Addressing review comments from Daniel on v42: https://lore.kernel.org/qemu-devel/20240628070216.92609-1-phi...@linaro.org/ (patches already reviewed not reposted) Supersedes: <20240628070216.92609-1-phi...@linaro.org> Philippe Mathieu-Daudé (2): hw/sd/sdcard: Use spec v3.01 by default hw/sd/

Re: [PATCH v42 00/98] hw/sd/sdcard: Add eMMC support

2024-06-28 Thread Cédric Le Goater
On 6/28/24 9:00 AM, Philippe Mathieu-Daudé wrote: Cédric asked for one big series to review instead of various tiny ones... Thanks for all this work ! I plan to send a pull request before v9.1 soft freeze with at least patches 1-81 (prerequisistes before the "Basis for eMMC support&q

[PATCH v42 82/98] hw/sd/sdcard: Basis for eMMC support

2024-06-28 Thread Philippe Mathieu-Daudé
From: Philippe Mathieu-Daudé Signed-off-by: Philippe Mathieu-Daudé Signed-off-by: Cédric Le Goater Signed-off-by: Philippe Mathieu-Daudé --- include/hw/sd/sd.h | 3 +++ hw/sd/sd.c | 34 ++ 2 files changed, 37 insertions(+) diff --git a/include/hw/sd/s

[PATCH v42 00/98] hw/sd/sdcard: Add eMMC support

2024-06-28 Thread Philippe Mathieu-Daudé
Cédric asked for one big series to review instead of various tiny ones... I plan to send a pull request before v9.1 soft freeze with at least patches 1-81 (prerequisistes before the "Basis for eMMC support" patch) except qtest patch #15. Also available as: https://gitlab.com/p

[PATCH 03/19] hw/sd/sdcard: Basis for eMMC support

2024-06-27 Thread Philippe Mathieu-Daudé
From: Cédric Le Goater Signed-off-by: Cédric Le Goater Signed-off-by: Philippe Mathieu-Daudé --- include/hw/sd/sd.h | 3 +++ hw/sd/sd.c | 34 ++ 2 files changed, 37 insertions(+) diff --git a/include/hw/sd/sd.h b/include/hw/sd/sd.h index 0d6d9e452b..d3

Re: [PATCH 00/32] hw/sd: eMMC support

2024-05-21 Thread Cédric Le Goater
PR. I plan to include the rest of this series in the next aspeed PR, for QEMU 9.1 Thanks, C. Thanks, C. patch 14-27    - adds eMMC support    - need better commit logs patch 28-32 (for later)    - aspeed wiring Please comment the core part, we can leave out the aspeed part for now. I

Re: [PATCH 00/32] hw/sd: eMMC support

2023-08-28 Thread Cédric Le Goater
- adds eMMC support - need better commit logs patch 28-32 (for later) - aspeed wiring Please comment the core part, we can leave out the aspeed part for now. I won't have much time to fix the issues unless it's about compile and style issues. If someone is interested and

[PATCH 14/32] hw/sd: Basis for eMMC support

2023-07-03 Thread Cédric Le Goater
From: Philippe Mathieu-Daudé The initial eMMC support from Vincent Palatin was largely reworked to match the current SD framework. Signed-off-by: Cédric Le Goater --- include/hw/sd/sd.h | 3 +++ hw/sd/sd.c | 44 2 files changed, 47

[PATCH 00/32] hw/sd: eMMC support

2023-07-03 Thread Cédric Le Goater
/20220318132824.1134400-1-...@kaod.org/ patch 1-12 - introduce SDProto structure - could be merged. They have been reviewed. patch 13 - adds a SPI variant model patch 14-27 - adds eMMC support - need better commit logs patch 28-32 (for later) - aspeed wiring Please comment the core

Re: [PATCH v2 00/25] hw/sd: Rework models for eMMC support

2022-05-31 Thread Cédric Le Goater
On 5/31/22 21:07, Philippe Mathieu-Daudé wrote: On 31/5/22 11:19, Cédric Le Goater wrote: On 5/30/22 21:37, Philippe Mathieu-Daudé wrote: From: Philippe Mathieu-Daudé Rebase/respin of Cédric RFC: https://lore.kernel.org/qemu-devel/20220318132824.1134400-1-...@kaod.org/ (sorry it took me so lo

Re: [PATCH v2 00/25] hw/sd: Rework models for eMMC support

2022-05-31 Thread Philippe Mathieu-Daudé via
On 31/5/22 11:19, Cédric Le Goater wrote: On 5/30/22 21:37, Philippe Mathieu-Daudé wrote: From: Philippe Mathieu-Daudé Rebase/respin of Cédric RFC: https://lore.kernel.org/qemu-devel/20220318132824.1134400-1-...@kaod.org/ (sorry it took me so long guys...) Pushed at https://gitlab.com/philmd/

Re: [PATCH v2 00/25] hw/sd: Rework models for eMMC support

2022-05-31 Thread Cédric Le Goater
() handler hw/sd: Add sd_cmd_SEND_OP_CMD() handler hw/sd: Add sd_cmd_ALL_SEND_CID() handler hw/sd: Add sd_cmd_SEND_RELATIVE_ADDR() handler hw/sd: Add sd_cmd_SET_BLOCK_COUNT() handler hw/sd: Basis for eMMC support Sai Pavan Boddu (2): hw/sd: Add CMD21 tuning sequence hw/sd: Add mmc

Re: [PATCH v2 14/25] hw/sd: Basis for eMMC support

2022-05-31 Thread Cédric Le Goater
On 5/30/22 21:38, Philippe Mathieu-Daudé wrote: From: Philippe Mathieu-Daudé The initial eMMC support from Vincent Palatin was largely reworked to match the current SD framework. Signed-off-by: Cédric Le Goater Signed-off-by: Philippe Mathieu-Daudé --- TODO: Do not inherit TYPE_SD_CARD

Re: [PATCH v2 14/25] hw/sd: Basis for eMMC support

2022-05-31 Thread Cédric Le Goater
On 5/30/22 21:38, Philippe Mathieu-Daudé wrote: From: Philippe Mathieu-Daudé The initial eMMC support from Vincent Palatin was largely reworked to match the current SD framework. Signed-off-by: Cédric Le Goater Signed-off-by: Philippe Mathieu-Daudé --- TODO: Do not inherit TYPE_SD_CARD

Re: [RFC PATCH 11/17] hw/sd: Add eMMC support

2022-05-31 Thread Cédric Le Goater
On 5/31/22 10:03, Philippe Mathieu-Daudé wrote: On 31/5/22 07:58, Cédric Le Goater wrote: On 5/30/22 19:40, Philippe Mathieu-Daudé wrote: On 18/3/22 14:28, Cédric Le Goater wrote: The initial eMMC support from Vincent Palatin was largely reworked to match the current SD framework. The

Re: [RFC PATCH 11/17] hw/sd: Add eMMC support

2022-05-31 Thread Philippe Mathieu-Daudé via
On 31/5/22 07:58, Cédric Le Goater wrote: On 5/30/22 19:40, Philippe Mathieu-Daudé wrote: On 18/3/22 14:28, Cédric Le Goater wrote: The initial eMMC support from Vincent Palatin was largely reworked to match the current SD framework. The parameters mimick a real 4GB eMMC, but it can be set to

Re: [PATCH v2 00/25] hw/sd: Rework models for eMMC support

2022-05-31 Thread Philippe Mathieu-Daudé via
On Tue, May 31, 2022 at 9:56 AM Philippe Mathieu-Daudé wrote: > On 31/5/22 08:31, Cédric Le Goater wrote: > > On 5/30/22 21:37, Philippe Mathieu-Daudé wrote: > >> I plan to queue patches 1-12 via sdmmc-next later this week. > >> > >> Cédric, if you are happy with this series, it should be easy to

Re: [PATCH v2 00/25] hw/sd: Rework models for eMMC support

2022-05-31 Thread Philippe Mathieu-Daudé via
On 31/5/22 08:31, Cédric Le Goater wrote: On 5/30/22 21:37, Philippe Mathieu-Daudé wrote: From: Philippe Mathieu-Daudé Rebase/respin of Cédric RFC: https://lore.kernel.org/qemu-devel/20220318132824.1134400-1-...@kaod.org/ (sorry it took me so long guys...) Pushed at https://gitlab.com/philmd/

Re: [PATCH v2 14/25] hw/sd: Basis for eMMC support

2022-05-31 Thread Philippe Mathieu-Daudé via
On 30/5/22 21:38, Philippe Mathieu-Daudé wrote: From: Philippe Mathieu-Daudé I missed something during the cherry-pick, this should be: From: Cédric Le Goater The initial eMMC support from Vincent Palatin was largely reworked to match the current SD framework. Signed-off-by: Cédric Le

Re: [PATCH v2 00/25] hw/sd: Rework models for eMMC support

2022-05-30 Thread Cédric Le Goater
sd_cmd_unimplemented() handler hw/sd: Add sd_cmd_GO_IDLE_STATE() handler hw/sd: Add sd_cmd_SEND_OP_CMD() handler hw/sd: Add sd_cmd_ALL_SEND_CID() handler hw/sd: Add sd_cmd_SEND_RELATIVE_ADDR() handler hw/sd: Add sd_cmd_SET_BLOCK_COUNT() handler hw/sd: Basis for eMMC support Sai Pavan Boddu (2

Re: [RFC PATCH 11/17] hw/sd: Add eMMC support

2022-05-30 Thread Cédric Le Goater
On 5/30/22 20:29, Philippe Mathieu-Daudé wrote: On 18/3/22 14:28, Cédric Le Goater wrote: The initial eMMC support from Vincent Palatin was largely reworked to match the current SD framework. The parameters mimick a real 4GB eMMC, but it can be set to various sizes. This adds a new QOM object

Re: [RFC PATCH 11/17] hw/sd: Add eMMC support

2022-05-30 Thread Cédric Le Goater
On 5/30/22 19:40, Philippe Mathieu-Daudé wrote: On 18/3/22 14:28, Cédric Le Goater wrote: The initial eMMC support from Vincent Palatin was largely reworked to match the current SD framework. The parameters mimick a real 4GB eMMC, but it can be set to various sizes. This adds a new QOM object

Re: [RFC PATCH 11/17] hw/sd: Add eMMC support

2022-05-30 Thread Cédric Le Goater
On 5/30/22 19:02, Philippe Mathieu-Daudé wrote: Hi Cédric, On 18/3/22 14:28, Cédric Le Goater wrote: The initial eMMC support from Vincent Palatin was largely reworked to match the current SD framework. The parameters mimick a real 4GB eMMC, but it can be set to various sizes. This adds a new

[PATCH v2 14/25] hw/sd: Basis for eMMC support

2022-05-30 Thread Philippe Mathieu-Daudé
From: Philippe Mathieu-Daudé The initial eMMC support from Vincent Palatin was largely reworked to match the current SD framework. Signed-off-by: Cédric Le Goater Signed-off-by: Philippe Mathieu-Daudé --- TODO: Do not inherit TYPE_SD_CARD, duplicate sd_class_init() --- hw/sd/sd.c

[PATCH v2 00/25] hw/sd: Rework models for eMMC support

2022-05-30 Thread Philippe Mathieu-Daudé
sd_cmd_SEND_RELATIVE_ADDR() handler hw/sd: Add sd_cmd_SET_BLOCK_COUNT() handler hw/sd: Basis for eMMC support Sai Pavan Boddu (2): hw/sd: Add CMD21 tuning sequence hw/sd: Add mmc switch function support hw/sd/sd.c | 645 + hw/sd/sdmmc-internal.c

Re: [RFC PATCH 11/17] hw/sd: Add eMMC support

2022-05-30 Thread Philippe Mathieu-Daudé via
On 18/3/22 14:28, Cédric Le Goater wrote: The initial eMMC support from Vincent Palatin was largely reworked to match the current SD framework. The parameters mimick a real 4GB eMMC, but it can be set to various sizes. This adds a new QOM object class for EMMC devices. Signed-off-by: Vincent

Re: [RFC PATCH 11/17] hw/sd: Add eMMC support

2022-05-30 Thread Philippe Mathieu-Daudé via
On 18/3/22 14:28, Cédric Le Goater wrote: The initial eMMC support from Vincent Palatin was largely reworked to match the current SD framework. The parameters mimick a real 4GB eMMC, but it can be set to various sizes. This adds a new QOM object class for EMMC devices. Signed-off-by: Vincent

Re: [RFC PATCH 11/17] hw/sd: Add eMMC support

2022-05-30 Thread Philippe Mathieu-Daudé via
Hi Cédric, On 18/3/22 14:28, Cédric Le Goater wrote: The initial eMMC support from Vincent Palatin was largely reworked to match the current SD framework. The parameters mimick a real 4GB eMMC, but it can be set to various sizes. This adds a new QOM object class for EMMC devices. Signed-off

Re: [RFC PATCH 11/17] hw/sd: Add eMMC support

2022-05-10 Thread Cédric Le Goater
On 5/10/22 09:15, Cédric Le Goater wrote: [ ... ] Do you mind splitting as: - Add TYPE_EMMC, emmc_class_init and sd_proto_emmc[] with    already existing handlers (1 patch) - Add new handlers, from smaller to sd_emmc_set_csd(),    and finally mmc_set_ext_csd() with the EXT_CSD definitions   

Re: [RFC PATCH 11/17] hw/sd: Add eMMC support

2022-05-10 Thread Cédric Le Goater
[ ... ] Do you mind splitting as: - Add TYPE_EMMC, emmc_class_init and sd_proto_emmc[] with   already existing handlers (1 patch) - Add new handlers, from smaller to sd_emmc_set_csd(),   and finally mmc_set_ext_csd() with the EXT_CSD definitions   (various patches). Sure, I will reorgani

Re: [RFC PATCH 11/17] hw/sd: Add eMMC support

2022-05-09 Thread Philippe Mathieu-Daudé via
Hi Cédric, On 18/3/22 14:28, Cédric Le Goater wrote: The initial eMMC support from Vincent Palatin was largely reworked to match the current SD framework. The parameters mimick a real 4GB eMMC, but it can be set to various sizes. This adds a new QOM object class for EMMC devices. Signed-off

Re: [RFC PATCH 00/17] hw/sd: Rework models for eMMC support

2022-04-21 Thread Cédric Le Goater
Hello, On 3/18/22 14:28, Cédric Le Goater wrote: Hello Philippe, I am restarting the discussion we started in : http://patchwork.ozlabs.org/project/qemu-devel/list/?series=250563 This series adds an extension for a new eMMC device using the framework you put in place. It's not perfect but

Re: [RFC PATCH 11/17] hw/sd: Add eMMC support

2022-03-28 Thread Cédric Le Goater
Hello Jerome, On 3/28/22 14:10, Jerome Forissier wrote: Hi Cédric, On 3/18/22 14:28, Cédric Le Goater wrote: The initial eMMC support from Vincent Palatin was largely reworked to match the current SD framework. The parameters mimick a real 4GB eMMC, but it can be set to various sizes. This

Re: [RFC PATCH 11/17] hw/sd: Add eMMC support

2022-03-28 Thread Jerome Forissier
Hi Cédric, On 3/18/22 14:28, Cédric Le Goater wrote: > The initial eMMC support from Vincent Palatin was largely reworked to > match the current SD framework. The parameters mimick a real 4GB eMMC, > but it can be set to various sizes. > > This adds a new QOM object class for EMMC

[RFC PATCH 00/17] hw/sd: Rework models for eMMC support

2022-03-18 Thread Cédric Le Goater
need its own class I suppose and there are more cleanups to be done in the set of commands. Please comment ! Thanks, C. Cédric Le Goater (2): hw/sd: Add eMMC support hw/sd: Fix SET_BLOCK_COUNT command argument Joel Stanley (3): hw/sd: Add sd_cmd_SEND_TUNING_BLOCK() handler hw/sd: Support

[RFC PATCH 11/17] hw/sd: Add eMMC support

2022-03-18 Thread Cédric Le Goater
The initial eMMC support from Vincent Palatin was largely reworked to match the current SD framework. The parameters mimick a real 4GB eMMC, but it can be set to various sizes. This adds a new QOM object class for EMMC devices. Signed-off-by: Vincent Palatin Link: https://lore.kernel.org/r

Re: [PATCH v3 00/21] eMMC support

2021-03-02 Thread Cédric Le Goater
o added boot partition access support. I > expect them to make a follow-up series to use it with aspeed machines.> > Present series adds eMMC support to Versal SOC. > > Initial patch series version is RFC > Changes for V2: > Split Patch 1 > Add comments for e

Re: [PATCH v3 16/21] sd: emmc: Support boot area in emmc image

2021-03-01 Thread Cédric Le Goater
On 2/28/21 8:33 PM, Sai Pavan Boddu wrote: > From: Joel Stanley > > This assumes a specially constructued image: > > dd if=/dev/zero of=mmc-bootarea.img count=2 bs=1M > dd if=u-boot-spl.bin of=mmc-bootarea.img conv=notrunc > dd if=u-boot.bin of=mmc-bootarea.img conv=notrunc count=64 bs=1K

[PATCH v3 16/21] sd: emmc: Support boot area in emmc image

2021-02-28 Thread Sai Pavan Boddu
From: Joel Stanley This assumes a specially constructued image: dd if=/dev/zero of=mmc-bootarea.img count=2 bs=1M dd if=u-boot-spl.bin of=mmc-bootarea.img conv=notrunc dd if=u-boot.bin of=mmc-bootarea.img conv=notrunc count=64 bs=1K cat mmc-bootarea.img obmc-phosphor-image.wic > mmc.img

[PATCH v3 21/21] docs: arm: xlnx-versal-virt: Add eMMC support documentation

2021-02-28 Thread Sai Pavan Boddu
Add details of eMMC specific machine property and example for passing eMMC device. Signed-off-by: Sai Pavan Boddu --- docs/system/arm/xlnx-versal-virt.rst | 14 ++ 1 file changed, 14 insertions(+) diff --git a/docs/system/arm/xlnx-versal-virt.rst b/docs/system/arm/xlnx-versal-virt.

[PATCH v3 00/21] eMMC support

2021-02-28 Thread Sai Pavan Boddu
Hi, This patch series add support for eMMC cards. This work was previosly submitted by Vincent, rebased few changes on top. Cedric & Joel has helped to added boot partition access support. I expect them to make a follow-up series to use it with aspeed machines. Present series adds eMMC sup

[PATCH v3 10/21] sd: emmc: support idle state in CMD2

2021-02-28 Thread Sai Pavan Boddu
eMMC is expected to be in idle-state post CMD1. Ready state is an intermediate stage which we don't come across in Device identification mode. Signed-off-by: Sai Pavan Boddu Signed-off-by: Edgar E. Iglesias Reviewed-by: Alistair Francis --- hw/sd/sd.c | 4 1 file changed, 4 insertions(+)

[PATCH v2 10/22] sd: emmc: support idle state in CMD2

2021-02-22 Thread Sai Pavan Boddu
eMMC is expected to be in idle-state post CMD1. Ready state is an intermediate stage which we don't come across in Device identification mode. Signed-off-by: Sai Pavan Boddu Signed-off-by: Edgar E. Iglesias Reviewed-by: Alistair Francis --- hw/sd/sd.c | 4 1 file changed, 4 insertions(+)

[PATCH v2 17/22] sd: emmc: Support boot area in emmc image

2021-02-22 Thread Sai Pavan Boddu
From: Joel Stanley This assumes a specially constructued image: dd if=/dev/zero of=mmc-bootarea.img count=2 bs=1M dd if=u-boot-spl.bin of=mmc-bootarea.img conv=notrunc dd if=u-boot.bin of=mmc-bootarea.img conv=notrunc count=64 bs=1K cat mmc-bootarea.img obmc-phosphor-image.wic > mmc.img

[PATCH v2 22/22] docs: arm: xlnx-versal-virt: Add eMMC support documentation

2021-02-22 Thread Sai Pavan Boddu
Add details of eMMC specific machine property. Signed-off-by: Sai Pavan Boddu --- docs/system/arm/xlnx-versal-virt.rst | 10 ++ 1 file changed, 10 insertions(+) diff --git a/docs/system/arm/xlnx-versal-virt.rst b/docs/system/arm/xlnx-versal-virt.rst index 2602d0f..a48a88d 100644 --- a/

[PATCH v2 00/22] eMMC support

2021-02-22 Thread Sai Pavan Boddu
Hi, This patch series add support for eMMC cards. This work was previosly submitted by Vincent, rebased few changes on top. Cedric & Joel has helped to added boot partition access support. I expect them to make a follow-up series to use it with aspeed machines. Present series adds eMMC sup

Re: [RFC PATCH 02/15] sd: add eMMC support

2021-02-13 Thread Luc Michel
On 2/11/21 9:17 AM, Sai Pavan Boddu wrote: From: Vincent Palatin The parameters mimick a real 4GB eMMC, but it can be set to various sizes. Signed-off-by: Vincent Palatin [SPB: Rebased the patch over qemu 5.1, Mark eMMC to support all timing modes] Signed-off-by: Sai Pavan Boddu Signe

Re: [RFC PATCH 12/15] sd: emmc: Support boot area in emmc image

2021-02-12 Thread Alistair Francis
On Thu, Feb 11, 2021 at 12:15 AM Sai Pavan Boddu wrote: > > From: Joel Stanley > > This assumes a specially constructued image: > > dd if=/dev/zero of=mmc-bootarea.img count=2 bs=1M > dd if=u-boot-spl.bin of=mmc-bootarea.img conv=notrunc > dd if=u-boot.bin of=mmc-bootarea.img conv=notrunc c

Re: [RFC PATCH 05/15] sd: emmc: support idle state in CMD2

2021-02-12 Thread Alistair Francis
On Thu, Feb 11, 2021 at 12:18 AM Sai Pavan Boddu wrote: > > eMMC is expected to be in idle-state post CMD1. Ready state is an > intermediate stage which we don't come across in Device identification > mode. > > Signed-off-by: Sai Pavan Boddu > Signed-off-by: Edgar E. Iglesias Acked-by: Alistair

[RFC PATCH 02/15] sd: add eMMC support

2021-02-11 Thread Sai Pavan Boddu
From: Vincent Palatin The parameters mimick a real 4GB eMMC, but it can be set to various sizes. Signed-off-by: Vincent Palatin [SPB: Rebased the patch over qemu 5.1, Mark eMMC to support all timing modes] Signed-off-by: Sai Pavan Boddu Signed-off-by: Joel Stanley Signed-off-by: Cédric

[RFC PATCH 05/15] sd: emmc: support idle state in CMD2

2021-02-11 Thread Sai Pavan Boddu
eMMC is expected to be in idle-state post CMD1. Ready state is an intermediate stage which we don't come across in Device identification mode. Signed-off-by: Sai Pavan Boddu Signed-off-by: Edgar E. Iglesias --- hw/sd/sd.c | 4 1 file changed, 4 insertions(+) diff --git a/hw/sd/sd.c b/hw/s

[RFC PATCH 12/15] sd: emmc: Support boot area in emmc image

2021-02-11 Thread Sai Pavan Boddu
From: Joel Stanley This assumes a specially constructued image: dd if=/dev/zero of=mmc-bootarea.img count=2 bs=1M dd if=u-boot-spl.bin of=mmc-bootarea.img conv=notrunc dd if=u-boot.bin of=mmc-bootarea.img conv=notrunc count=64 bs=1K cat mmc-bootarea.img obmc-phosphor-image.wic > mmc.img

[RFC PATCH 00/15] eMMC support

2021-02-11 Thread Sai Pavan Boddu
Hi, This patch series add support for eMMC cards. This work was previosly submitted by Vincent, rebased few changes on top. Cedric & Joel has helped to added boot partition access support. I expect them to make a follow-up series to use it with aspeed machines. Present series adds eMMC sup

RE: eMMC support

2021-02-10 Thread Sai Pavan Boddu
Hi Joel > -Original Message- > From: Joel Stanley > Sent: Wednesday, February 10, 2021 6:35 PM > To: Cédric Le Goater > Cc: Sai Pavan Boddu ; Edgar Iglesias ; > Andrew Jeffery ; qemu-devel@nongnu.org; Philippe > Mathieu-Daudé > Subject: Re: eMMC support >

Re: eMMC support

2021-02-10 Thread Cédric Le Goater
On 2/10/21 2:05 PM, Joel Stanley wrote: > On Wed, 10 Feb 2021 at 09:56, Cédric Le Goater wrote: >> >> Hello Sai Pavan, >> >> [ ... ] >> > The patchset is in the aspeed-6.0 branch : > > df91d012672c Cédric Le Goater - hw/arm/aspeed: Load eMMC first boot >

Re: eMMC support

2021-02-10 Thread Joel Stanley
On Wed, 10 Feb 2021 at 09:56, Cédric Le Goater wrote: > > Hello Sai Pavan, > > [ ... ] > > >>> The patchset is in the aspeed-6.0 branch : > >>> > >>> df91d012672c Cédric Le Goater - hw/arm/aspeed: Load eMMC first boot > >>> area as a boot rom > >>> 27b75

RE: eMMC support

2021-02-10 Thread Sai Pavan Boddu
Hi Cedric > -Original Message- > From: Cédric Le Goater > Sent: Wednesday, February 10, 2021 3:27 PM > To: Sai Pavan Boddu ; Edgar Iglesias ; > Joel Stanley ; Andrew Jeffery > Cc: qemu-devel@nongnu.org; Philippe Mathieu-Daudé > Subject: Re: eMMC support

Re: eMMC support

2021-02-10 Thread Cédric Le Goater
Hello Sai Pavan, [ ... ] >>> The patchset is in the aspeed-6.0 branch : >>> >>> df91d012672c Cédric Le Goater - hw/arm/aspeed: Load eMMC first boot >>> area as a boot rom >>> 27b75a7ad322 Cédric Le Goater - hw/arm/aspeed: Add eMMC property >>> 2836

RE: eMMC support

2021-02-09 Thread Sai Pavan Boddu
Hi Cedric, > -Original Message- > From: Cédric Le Goater > Sent: Tuesday, February 2, 2021 3:37 AM > To: Sai Pavan Boddu ; Edgar Iglesias ; > Joel Stanley ; Andrew Jeffery > Cc: qemu-devel@nongnu.org; Philippe Mathieu-Daudé > Subject: Re: eMMC support > > On

Re: eMMC support

2021-02-01 Thread Cédric Le Goater
df0452923b56 Cédric Le Goater - sd: mmc: Add Extended CSD register > definitions > 416c02bbfd32 Sai Pavan Boddu - sd: mmc: Add mmc switch function support > a228aef1a209 Sai Pavan Boddu - sd: mmc: add CMD21 tuning sequence > 9b177d7baf8e Sai Pavan Boddu - sd: mmc: Update CMD1 definition for MMC > 6677e4eb6812 Vincent Palatin - sd: add eMMC support here : https://github.com/legoater/qemu/commits/aspeed-6.0 C.

Re: eMMC support

2021-02-01 Thread Cédric Le Goater
mmc: add CMD21 tuning sequence 9b177d7baf8e Sai Pavan Boddu - sd: mmc: Update CMD1 definition for MMC 6677e4eb6812 Vincent Palatin - sd: add eMMC support Also based on Vincent Palatin initial patches, reworked by Joel and I. Booting an aspeed machine requires a bit of work since you need

RE: eMMC support

2021-02-01 Thread Sai Pavan Boddu
Hi Cédric From: Edgar Iglesias Sent: Wednesday, January 20, 2021 9:30 PM To: Cédric Le Goater ; Sai Pavan Boddu ; Joel Stanley Cc: qemu-devel@nongnu.org; Philippe Mathieu-Daudé Subject: Re: eMMC support On 20 Jan 2021 09:55, Cédric Le Goater mailto:c...@kaod.org>> wrote: > >

Re: eMMC support

2021-01-20 Thread Edgar Iglesias
On 20 Jan 2021 09:55, Cédric Le Goater wrote: > > On 9/17/20 8:25 AM, Cédric Le Goater wrote: > > On 9/17/20 2:55 AM, Joel Stanley wrote: > >> On Wed, 16 Sep 2020 at 18:35, Sai Pavan Boddu wrote: > >>> > >>> Hi Philippe, > >>> > >&g

Re: eMMC support

2021-01-20 Thread Cédric Le Goater
On 9/17/20 8:25 AM, Cédric Le Goater wrote: > On 9/17/20 2:55 AM, Joel Stanley wrote: >> On Wed, 16 Sep 2020 at 18:35, Sai Pavan Boddu wrote: >>> >>> Hi Philippe, >>> >>> >>> >>> We are looking to add eMMC support, I searched the

RE: eMMC support

2020-09-21 Thread Sai Pavan Boddu
Hi Joel, > -Original Message- > From: Joel Stanley > Sent: Thursday, September 17, 2020 6:25 AM > To: Sai Pavan Boddu ; Cédric Le Goater > > Cc: Philippe Mathieu-Daudé ; Edgar Iglesias > ; qemu-devel@nongnu.org > Subject: Re: eMMC support > > On Wed, 1

RE: eMMC support

2020-09-21 Thread Sai Pavan Boddu
Hi Cedric, > -Original Message- > From: Cédric Le Goater > Sent: Thursday, September 17, 2020 11:55 AM > To: Joel Stanley ; Sai Pavan Boddu > Cc: Philippe Mathieu-Daudé ; Edgar Iglesias > ; qemu-devel@nongnu.org > Subject: Re: eMMC support > > On 9/17/20

Re: eMMC support

2020-09-16 Thread Cédric Le Goater
On 9/17/20 2:55 AM, Joel Stanley wrote: > On Wed, 16 Sep 2020 at 18:35, Sai Pavan Boddu wrote: >> >> Hi Philippe, >> >> >> >> We are looking to add eMMC support, I searched the mailing list and found a >> series posted on eMMC by “Vincent Palatin”

Re: eMMC support

2020-09-16 Thread Joel Stanley
On Wed, 16 Sep 2020 at 18:35, Sai Pavan Boddu wrote: > > Hi Philippe, > > > > We are looking to add eMMC support, I searched the mailing list and found a > series posted on eMMC by “Vincent Palatin” > > https://lists.gnu.org/archive/html/qemu-devel/2011-07/msg02833.htm

eMMC support

2020-09-16 Thread Sai Pavan Boddu
Hi Philippe, We are looking to add eMMC support, I searched the mailing list and found a series posted on eMMC by "Vincent Palatin" https://lists.gnu.org/archive/html/qemu-devel/2011-07/msg02833.html I would like to consider the above work and mix-up with more changes to start addi

Re: [Qemu-devel] sd: add SDHCI and eMMC support

2011-12-13 Thread Stefan Hajnoczi
On Tue, Jul 26, 2011 at 12:19 AM, Vincent Palatin wrote: > This patchset adds the support for eMMC as found soldered on many embedded > board > in addition to current support for SD/SDHC cards. > It also adds a standard SDHCI controller emulation. > The first patches are a couple of fixes to the

[Qemu-devel] [PATCH 4/7] sd: add eMMC support

2011-07-25 Thread Vincent Palatin
The parameters mimick a real 4GB eMMC, but it can be set to various sizes. Signed-off-by: Vincent Palatin --- hw/sd.c | 155 +++ 1 files changed, 136 insertions(+), 19 deletions(-) diff --git a/hw/sd.c b/hw/sd.c index de477fe..0db8d78

  1   2   >