[Qemu-devel] [PATCH] virtio-spec: clarify ro/rw bits and updating rule of virtio-net status field

2012-03-20 Thread Jason Wang
This patch clarifies VIRTIO_NET_S_LINK_UP as a read-only bit and VIRTIO_NET_S_ANNOUNCE as a read-writable bit. Also introduce the write 1 to clear semantics for all read-writable bits of config status field. This could help to reduce the config status field updating race between host and guest and

[Qemu-devel] [Bug 959852] [NEW] Build fails: osx 10.7, deprecated CoreAudio APIs

2012-03-20 Thread Hans Simer
Public bug reported: Virtual audio driver for darwin is using deprecated APIs. ○ → ./configure --cc=/usr/bin/gcc --disable-darwin-user --disable-bsd- user --disable-guest-agent ○ → make . . . CCaudio/noaudio.o CCaudio/wavaudio.o CCaudio/mixeng.o CCaudio/coreaudio.o

Re: [Qemu-devel] [PATCH 2/6] Redesign of pciinit.c (take 2)

2012-03-20 Thread Alexey Korolev
On 16/03/12 13:55, Kevin O'Connor wrote: On Thu, Mar 15, 2012 at 04:29:30PM +1300, Alexey Korolev wrote: On 14/03/12 13:48, Kevin O'Connor wrote: On Tue, Mar 13, 2012 at 05:45:19PM +1300, Alexey Korolev wrote: Added pci_region_entry structure and list operations to pciinit.c List is filled

Re: [Qemu-devel] [PATCH 8/9] vl: add -query-capabilities

2012-03-20 Thread Gerd Hoffmann
On 03/19/12 16:09, Anthony Liguori wrote: This dumps the results of query-version, query-commands, and query-config-capabilities into a single JSON object on stdout. I think libvirt needs a query-devices too. cheers, Gerd

Re: [Qemu-devel] [RFC PATCH 0/9] qemu capabilities reporting and config changes

2012-03-20 Thread Gerd Hoffmann
Hi, I have a few patches here that convert almost every option that matters into QemuOpts so that -writeconfig records it: -m, -bios, -localtime, -S, -M, -smp, -numa, -nodefaults, -no-shutdown, -no-reboot. The only thing that is left basically is -display, where I chickened out. This

Re: [Qemu-devel] [PATCH v4 0/9] VMXNET3 paravirtual NIC device implementation

2012-03-20 Thread Dmitry Fleytman
Hello, Gerhard I've tested telnet connections on Knoppix running on QEMU-KVM with patch V5. Everything works fine on my setup. What is your network setup? How do you connect tap1 interface to the outer world? Also, since you have ping failure to init MSI-X is not related to the problem - device

[Qemu-devel] [PATCH 00/12] convert many options to QemuOpts

2012-03-20 Thread Paolo Bonzini
This converts a lot of commonly-used options to QemuOpts. Most of them get in -machine, but I don't intend -machine to become a catch-all option. In fact I refrained from converting those that should go in -display (like -keyboard) or should be moved to enum device properties. With the exception

[Qemu-devel] [PATCH 05/12] cmdline: implement -bios with QemuOpts

2012-03-20 Thread Paolo Bonzini
This becomes -machine bios. Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- qemu-config.c |4 vl.c |4 +++- 2 files changed, 7 insertions(+), 1 deletions(-) diff --git a/qemu-config.c b/qemu-config.c index 3a313de..89706df 100644 --- a/qemu-config.c +++

[Qemu-devel] [PATCH 12/12] cmdline: convert -no-shutdown and -no-reboot to QemuOpts

2012-03-20 Thread Paolo Bonzini
They are also moved inside -machine. Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- qemu-config.c |8 vl.c|6 -- 2 files changed, 12 insertions(+), 2 deletions(-) diff --git a/qemu-config.c b/qemu-config.c index 6e97ff6..e901826 100644 ---

[Qemu-devel] [PATCH 02/12] QemuOpts: use strtosz

2012-03-20 Thread Paolo Bonzini
This will simplify conversion of -numa node,mem=... and -m to QemuOpts. Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- qemu-option.c | 41 ++--- 1 files changed, 10 insertions(+), 31 deletions(-) diff --git a/qemu-option.c b/qemu-option.c index

[Qemu-devel] [PATCH 09/12] cmdline: reindent numa_add

2012-03-20 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- vl.c | 72 +- 1 files changed, 36 insertions(+), 36 deletions(-) diff --git a/vl.c b/vl.c index ce55468..d9a9cac 100644 --- a/vl.c +++ b/vl.c @@ -950,49 +950,49 @@ static void

Re: [Qemu-devel] help with helper functions

2012-03-20 Thread Peter Maydell
On 19 March 2012 22:34, João Corrêa joao.l...@gmail.com wrote: I'm trying to use some helper functions to instrument translated code, but I'm getting some segfaults while doing it. Here are some code I've placed: target-i386/helper.h DEF_HELPER_1(foo, void, tl) target-i386/op_helper.c

[Qemu-devel] [PATCH 10/12] cmdline: convert -numa to QemuOpts

2012-03-20 Thread Paolo Bonzini
This requires some special casing to skip the fake node option and to handle the automatic -numa node syntax. Besides this, the option parsing maps easily to QemuOpts. Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- qemu-config.c | 22 ++ vl.c | 50

[Qemu-devel] [Bug 932487] Re: win32: git rev 59f971d crashes when accessing disk (coroutine issue)

2012-03-20 Thread Roy Tam
coroutine issue again, when booting tinycore_3.3.iso: C:\msys\home\User\qemu\i386-softmmugdb --args qemu-system-i386.exe -L ..\pc-bios -cdrom tinycore_3.3.iso GNU gdb (GDB) 7.3 Copyright (C) 2011 Free Software Foundation, Inc. License GPLv3+: GNU GPL version 3 or later

Re: [Qemu-devel] How many floppy can a computer install ? Thank you very much!

2012-03-20 Thread Cao,Bing Bu
On 03/20/2012 10:34 AM, Zhi Hui Li wrote: Hi,Zhi Hui I am not very sure,but I think it is 2. -- Best Regards, Cao,Bing Bu

[Qemu-devel] [Bug 959992] [NEW] segfault in apic_report_irq_delivered when booting tinycore_3.3.iso

2012-03-20 Thread Roy Tam
Public bug reported: it git head (33cf629) sometimes it segfaults in apic_report_irq_delivered() and backtrace is looping in apic_update_irq(#3-#4) Log: C:\msys\home\User\qemu\i386-softmmugdb --args qemu-system-i386.exe -L ..\pc-bios -cdrom tinycore_3.3.iso GNU gdb (GDB) 7.3 Copyright (C) 2011

[Qemu-devel] [PATCH 03/12] cmdline: implement -m with QemuOpts

2012-03-20 Thread Paolo Bonzini
This becomes -machine ram_size. Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- qemu-config.c |4 vl.c | 41 - 2 files changed, 16 insertions(+), 29 deletions(-) diff --git a/qemu-config.c b/qemu-config.c index be84a03..6569acd

Re: [Qemu-devel] [PATCH] readconfig: add emulation of /dev/fd/ to platforms that that lacks this API

2012-03-20 Thread ronnie sahlberg
None. No platforms that I care about. On Tue, Mar 20, 2012 at 3:43 AM, Anthony Liguori anth...@codemonkey.ws wrote: On 03/03/2012 01:49 AM, Ronnie Sahlberg wrote: Please find a patch to -readconfig. On many platforms -readconfig /dev/fd/n  can be used to read from an already opened and

[Qemu-devel] [PATCH 04/12] cmdline: implement -S with QemuOpts

2012-03-20 Thread Paolo Bonzini
This becomes -machine autostart. Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- qemu-config.c |4 vl.c |3 ++- 2 files changed, 6 insertions(+), 1 deletions(-) diff --git a/qemu-config.c b/qemu-config.c index 6569acd..3a313de 100644 --- a/qemu-config.c +++

[Qemu-devel] [PATCH 08/12] cmdline: convert -smp to QemuOpts

2012-03-20 Thread Paolo Bonzini
This introduces a new option group, but it is mostly trivial. Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- qemu-config.c | 31 + vl.c | 61 +--- 2 files changed, 58 insertions(+), 34 deletions(-)

[Qemu-devel] KVM call agenda for Tuesday 20th

2012-03-20 Thread Juan Quintela
Hi Please send in any agenda items you are interested in covering. Cheers, Juan.

[Qemu-devel] [PATCH 01/12] vga: disable default VGA if appropriate -device is used

2012-03-20 Thread Paolo Bonzini
This is a partial revert of commits a369da5 (vga: improve VGA logic, committed 2012-01-22) and c5bd4f3 (vga: fix -nodefaults -device VGA, 2012-01-24) which broke command-line option parsing in different ways. Since commit a369da5 it has become impossible to specify a VGA device entirely with

Re: [Qemu-devel] [PATCH 12/12] cmdline: convert -no-shutdown and -no-reboot to QemuOpts

2012-03-20 Thread Peter Maydell
On 20 March 2012 08:01, Paolo Bonzini pbonz...@redhat.com wrote: They are also moved inside -machine. So why no_reboot and no_shutdown but autostart rather than no_autostart? -- PMM

Re: [Qemu-devel] [PATCH v2 0/7] vdi: convert to coroutines

2012-03-20 Thread Kevin Wolf
Am 19.03.2012 18:07, schrieb Paolo Bonzini: This squashes in the fix for GCC's uninitialized variables false positive. Paolo Bonzini (7): vdi: basic conversion to coroutines vdi: move end-of-I/O handling at the end vdi: merge aio_read_cb and aio_write_cb into callers vdi: move

[Qemu-devel] [PATCH 07/12] cmdline: make -M a simple alias for -machine type

2012-03-20 Thread Paolo Bonzini
machine_parse is still being called from the -M handler. Remove this, and just call machine_parse based on the -machine type value. Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- vl.c | 27 ++- 1 files changed, 14 insertions(+), 13 deletions(-) diff --git a/vl.c

Re: [Qemu-devel] [PATCH 12/12] cmdline: convert -no-shutdown and -no-reboot to QemuOpts

2012-03-20 Thread Paolo Bonzini
Il 20/03/2012 10:04, Peter Maydell ha scritto: They are also moved inside -machine. So why no_reboot and no_shutdown but autostart rather than no_autostart? Because. :) Seriously, perhaps we want two enum options on_reboot/on_shutdown with items reboot/stop/quit? Paolo

[Qemu-devel] [PATCH 11/12] cmdline: implement -nodefaults with qemuopts

2012-03-20 Thread Paolo Bonzini
This becomes -machine default_devices. Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- qemu-config.c |4 vl.c | 40 ++-- 2 files changed, 22 insertions(+), 22 deletions(-) diff --git a/qemu-config.c b/qemu-config.c index

[Qemu-devel] [Bug 932487] Re: win32: git rev 59f971d crashes when accessing disk (coroutine issue)

2012-03-20 Thread Stefan Weil
Please try a newer compiler. gcc-4.6.2 compiles thread local storage correctly, gcc-4.3.3 obviously doesn't. If you can confirm that newer compilers fix this bug, I'd like to close this ticket. -- You received this bug notification because you are a member of qemu- devel-ml, which is

Re: [Qemu-devel] [PATCH 10/12] trace: [tracetool] Automatically establish available backends and formats

2012-03-20 Thread Stefan Hajnoczi
2012/3/13 Lluís Vilanova vilan...@ac.upc.edu: Adds decorators to establish which backend and/or format each routine is meant to process. With this, tables enumerating format and backend routines can be eliminated and part of the usage message can be computed in a more generic way.

Re: [Qemu-devel] [PATCH 1/6] arm: move neon_tbl to neon_helper.c

2012-03-20 Thread Laurent Desnogues
On Mon, Mar 19, 2012 at 11:10 PM, Peter Maydell peter.mayd...@linaro.org wrote: On 19 March 2012 21:56, Blue Swirl blauwir...@gmail.com wrote: -DEF_HELPER_4(neon_tbl, i32, i32, i32, i32, i32) +DEF_HELPER_5(neon_tbl, i32, env, i32, i32, i32, i32) --- a/target-arm/translate.c +++

Re: [Qemu-devel] [PATCH 00/12] Rewrite tracetool using python

2012-03-20 Thread Stefan Hajnoczi
2012/3/13 Lluís Vilanova vilan...@ac.upc.edu: The first patch in the series (by Harsh Prateek) is a rewrite of the tracetool shell script in python, which is easier to handle given the current complexity of the script. The following patches (by Lluís Vilanova) add a series of random code

Re: [Qemu-devel] [PATCH 12/12] trace: [tracetool] Add error-reporting functions

2012-03-20 Thread Stefan Hajnoczi
On Tue, Mar 13, 2012 at 09:03:43PM +0100, Lluís Vilanova wrote: @@ -514,8 +521,9 @@ def main(): try: opts, args = getopt.getopt(sys.argv[1:], , long_options) except getopt.GetoptError, err: -# print help information and exit: -print str(err) # will print

Re: [Qemu-devel] [PATCHv4 04/11] consolidate qemu_iovec_memset{, _skip}() into single function and use existing iov_memset()

2012-03-20 Thread Stefan Hajnoczi
On Tue, Mar 20, 2012 at 12:04:36AM +0400, Michael Tokarev wrote: I don't have bandwidth for non-trivial cosmetic stuff at the moment, sorry. What's bandwidth in this context? Time. My review queue is 120 patches at the moment. I'm tackling those which are blocked on me and which fix

Re: [Qemu-devel] [PATCH] block: add the support to drain throttled requests

2012-03-20 Thread Zhi Yong Wu
HI, Kevin, We hope that I/O throttling can be shipped without known issue in QEMU 1.1, so if you are available, can you give this patch some love? On Tue, Mar 13, 2012 at 9:53 AM, zwu.ker...@gmail.com wrote: From: Zhi Yong Wu wu...@linux.vnet.ibm.com Signed-off-by: Zhi Yong Wu

Re: [Qemu-devel] [PATCH] block: add the support to drain throttled requests

2012-03-20 Thread Paolo Bonzini
Il 20/03/2012 10:40, Zhi Yong Wu ha scritto: HI, Kevin, We hope that I/O throttling can be shipped without known issue in QEMU 1.1, so if you are available, can you give this patch some love? I'm sorry to say this, but I think I/O throttling is impossible to save. As it is implemented now,

Re: [Qemu-devel] [Bug 932487] Re: win32: git rev 59f971d crashes when accessing disk (coroutine issue)

2012-03-20 Thread Roy Tam
2012/3/20 Stefan Weil 932...@bugs.launchpad.net: Please try a newer compiler. gcc-4.6.2 compiles thread local storage correctly, gcc-4.3.3 obviously doesn't. If you can confirm that newer compilers fix this bug, I'd like to close this ticket. I'm using gcc-4.6.2 now. -- You received

[Qemu-devel] [PATCH 0/6] fix w32 sockets

2012-03-20 Thread Paolo Bonzini
The w32 main loop has been mostly broken by the introduction of the glib main loop. glib's g_poll does not use sockets on w32, so we need a separate approach. Patch 1 is a simple cleanup that is needed later in the series. Patch 2 and patch 3 completely separate the way the main loop waits on

[Qemu-devel] [PATCH 5/6] main-loop: replace WaitForMultipleObjects with g_poll

2012-03-20 Thread Paolo Bonzini
On w32, glib implements g_poll using WaitForMultipleObjects or MsgWaitForMultipleObjects. This means that we can simplify our code by switching to g_poll, and at the same time prepare for adding back glib sources. Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- main-loop.c | 40

[Qemu-devel] [PATCH 4/6] main-loop: interrupt wait when data arrives on a socket

2012-03-20 Thread Paolo Bonzini
Right now, the main loop is not interrupted when data arrives on a socket. To fix this, register each socket to interrupt the main loop with WSAEventSelect. This does not replace select, it only communicates a change in socket state that requires a select call. Since the interrupt fires only

[Qemu-devel] [PATCH 1/6] slirp: use socket_set_nonblock

2012-03-20 Thread Paolo Bonzini
Cc: Jan Kiszka jan.kis...@siemens.de Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- slirp/misc.c | 46 +- slirp/tcp_subr.c |4 ++-- 2 files changed, 3 insertions(+), 47 deletions(-) diff --git a/slirp/misc.c b/slirp/misc.c index

Re: [Qemu-devel] [PATCH] block: add the support to drain throttled requests

2012-03-20 Thread Kevin Wolf
Am 20.03.2012 10:40, schrieb Zhi Yong Wu: HI, Kevin, We hope that I/O throttling can be shipped without known issue in QEMU 1.1, so if you are available, can you give this patch some love? Sorry, haven't had the time to follow the discussion closely. Are all review comments addressed now?

Re: [Qemu-devel] [PATCH] Remove PCI class code from virtio balloon device

2012-03-20 Thread Stefan Hajnoczi
On Tue, Mar 20, 2012 at 12:42 AM, David Gibson da...@gibson.dropbear.id.au wrote: On Mon, Mar 19, 2012 at 11:33:10AM +, Stefan Hajnoczi wrote: On Mon, Mar 19, 2012 at 03:59:23PM +1100, David Gibson wrote: Currently the virtio balloon device, when using the virtio-pci interface advertises

Re: [Qemu-devel] [PATCH] block: add the support to drain throttled requests

2012-03-20 Thread Kevin Wolf
Am 20.03.2012 10:47, schrieb Paolo Bonzini: Il 20/03/2012 10:40, Zhi Yong Wu ha scritto: HI, Kevin, We hope that I/O throttling can be shipped without known issue in QEMU 1.1, so if you are available, can you give this patch some love? I'm sorry to say this, but I think I/O throttling is

Re: [Qemu-devel] [PATCH 0/2 v3] kvm: notify host when guest panicked

2012-03-20 Thread Wen Congyang
At 03/19/2012 03:33 PM, Wen Congyang Wrote: At 03/08/2012 03:57 PM, Wen Congyang Wrote: We can know the guest is paniced when the guest runs on xen. But we do not have such feature on kvm. Another purpose of this feature is: management app(for example: libvirt) can do auto dump when the

[Qemu-devel] [PATCH 2/6] main loop: use msec-based timeout in glib_select_fill

2012-03-20 Thread Paolo Bonzini
The timeval-based timeout is not needed until we actually invoke select, so compute it only then. Also group the two calls that modify the timeout, glib_select_fill and os_host_main_loop_wait. Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- main-loop.c | 22 ++ 1

Re: [Qemu-devel] [PATCH 0/6] ARM: AREG0 conversion

2012-03-20 Thread Laurent Desnogues
On Mon, Mar 19, 2012 at 10:55 PM, Blue Swirl blauwir...@gmail.com wrote: Convert ARM to AREG0 free operation. Survives simple tests. After fixing the issue about tbl helper usage, I could run some simple linux-user tests and boot a rather large Linux image. It looks like the kernel boot is about

Re: [Qemu-devel] [Bug 932487] Re: win32: git rev 59f971d crashes when accessing disk (coroutine issue)

2012-03-20 Thread Paolo Bonzini
Il 20/03/2012 10:35, Roy Tam ha scritto: 2012/3/20 Stefan Weil 932...@bugs.launchpad.net: Please try a newer compiler. gcc-4.6.2 compiles thread local storage correctly, gcc-4.3.3 obviously doesn't. If you can confirm that newer compilers fix this bug, I'd like to close this ticket. I'm

[Qemu-devel] [Bug 916720] Re: select fails on windows because a non-socket fd is in the rfds set

2012-03-20 Thread Paolo Bonzini
Patches posted to the list. http://permalink.gmane.org/gmane.comp.emulators.qemu/142634 -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/916720 Title: select fails on windows because a non-socket fd

[Qemu-devel] [PATCH 6/6] main-loop: integrate glib sources for w32

2012-03-20 Thread Paolo Bonzini
Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- main-loop.c | 21 +++-- 1 files changed, 15 insertions(+), 6 deletions(-) diff --git a/main-loop.c b/main-loop.c index 4d02568..7e163f9 100644 --- a/main-loop.c +++ b/main-loop.c @@ -221,11 +221,10 @@ int main_loop_init(void)

[Qemu-devel] [PATCH 3/6] main-loop: disable fd_set-based glib integration under w32

2012-03-20 Thread Paolo Bonzini
Using select with glib pollfds is wrong under w32. Restrict the code to the POSIX case. Signed-off-by: Paolo Bonzini pbonz...@redhat.com --- main-loop.c | 63 ++ 1 files changed, 33 insertions(+), 30 deletions(-) diff --git

Re: [Qemu-devel] Build broken -- qemu-ga: add guest-network-get-interfaces command

2012-03-20 Thread Michal Privoznik
On 18.03.2012 02:09, Brad Smith wrote: Michal, http://git.qemu.org/?p=qemu.git;a=commit;h=3424fc9f16a1e7d1c48eb6d605eb0ca63e199ec2 This broke the build. Un-break the tree. Can you please be more specific? It works for me so I don't have a clue what are you referring to. I mean, what

Re: [Qemu-devel] [PATCH] Remove PCI class code from virtio balloon device

2012-03-20 Thread David Gibson
On Tue, Mar 20, 2012 at 09:54:20AM +, Stefan Hajnoczi wrote: On Tue, Mar 20, 2012 at 12:42 AM, David Gibson da...@gibson.dropbear.id.au wrote: On Mon, Mar 19, 2012 at 11:33:10AM +, Stefan Hajnoczi wrote: On Mon, Mar 19, 2012 at 03:59:23PM +1100, David Gibson wrote: Currently the

Re: [Qemu-devel] [PATCH 8/9] vl: add -query-capabilities

2012-03-20 Thread Daniel P. Berrange
On Tue, Mar 20, 2012 at 08:49:11AM +0100, Gerd Hoffmann wrote: On 03/19/12 16:09, Anthony Liguori wrote: This dumps the results of query-version, query-commands, and query-config-capabilities into a single JSON object on stdout. I think libvirt needs a query-devices too. Currently we get

Re: [Qemu-devel] [PATCH] Remove PCI class code from virtio balloon device

2012-03-20 Thread Michael S. Tsirkin
On Tue, Mar 20, 2012 at 11:42:06AM +1100, David Gibson wrote: On Mon, Mar 19, 2012 at 11:33:10AM +, Stefan Hajnoczi wrote: On Mon, Mar 19, 2012 at 03:59:23PM +1100, David Gibson wrote: Currently the virtio balloon device, when using the virtio-pci interface advertises itself with PCI

Re: [Qemu-devel] [Bug 959852] [NEW] Build fails: osx 10.7, deprecated CoreAudio APIs

2012-03-20 Thread Andreas Färber
Am 20.03.2012 02:13, schrieb Hans Simer: Public bug reported: Virtual audio driver for darwin is using deprecated APIs. [...] ○ → make . . . CCaudio/noaudio.o CCaudio/wavaudio.o CCaudio/mixeng.o CCaudio/coreaudio.o audio/coreaudio.c: In function ‘isPlaying’:

Re: [Qemu-devel] [PATCH v4 1/2] qemu-socket: change inet_connect() to to support nonblock socket

2012-03-20 Thread Orit Wasserman
On 03/19/2012 04:11 PM, Amos Kong wrote: Change inet_connect(const char *str, int socktype) to inet_connect(const char *str, bool block, int *sock_err), socktype is unused, block is used to assign if set socket to block/nonblock, sock_err is used to restore socket error. It is more common to

[Qemu-devel] [PATCH] spice: fix 32bit build

2012-03-20 Thread Gerd Hoffmann
New 32bit warnings sneaked in, this time in ui/spice-display.c, fix them. This gets annonying, /me sets up a ubuntu buildbot slave for 32bit spice testbuilds. Signed-off-by: Gerd Hoffmann kra...@redhat.com --- roms/seabios |2 +- ui/spice-display.c | 12 ++-- 2 files

Re: [Qemu-devel] [PATCH] spice: fix 32bit build

2012-03-20 Thread Peter Maydell
On 20 March 2012 11:26, Gerd Hoffmann kra...@redhat.com wrote: New 32bit warnings sneaked in, this time in ui/spice-display.c, fix them. This gets annonying, /me sets up a ubuntu buildbot slave for 32bit spice testbuilds. Signed-off-by: Gerd Hoffmann kra...@redhat.com ---  roms/seabios    

Re: [Qemu-devel] [PATCH] block: add the support to drain throttled requests

2012-03-20 Thread Stefan Hajnoczi
On Tue, Mar 20, 2012 at 10:58:10AM +0100, Kevin Wolf wrote: Am 20.03.2012 10:47, schrieb Paolo Bonzini: Il 20/03/2012 10:40, Zhi Yong Wu ha scritto: HI, Kevin, We hope that I/O throttling can be shipped without known issue in QEMU 1.1, so if you are available, can you give this patch

Re: [Qemu-devel] [PATCH 0/2] linux-user: Support prctl PR_GET/SET_NAME

2012-03-20 Thread Peter Maydell
Ping^3 (past the six-week mark now...) -- PMM On 8 March 2012 14:20, Peter Maydell peter.mayd...@linaro.org wrote: Ping^2 ? -- PMM On 22 February 2012 22:55, Peter Maydell peter.mayd...@linaro.org wrote: Ping? On 3 February 2012 13:53, Peter Maydell peter.mayd...@linaro.org wrote: These

Re: [Qemu-devel] [PATCH 23/36] arm: save always 32 fpu registers

2012-03-20 Thread Peter Maydell
On 19 March 2012 22:57, Juan Quintela quint...@redhat.com wrote: This way, we fix a bug (we were overwritten the 16 first registers on load), and we don't need to check for ARM_FEATUR_VPF3, we always send the 32 registers. This commit message is out of date -- the overwriting bug was fixed in

[Qemu-devel] ARM QOM conversion / class hierarchy

2012-03-20 Thread Peter Maydell
(I can't find the relevant patches in the mailing list at this point. I'm talking about this tree from Andreas: http://repo.or.cz/w/qemu/afaerber.git/shortlog/refs/heads/qom-cpu-arm ) So in an IRC discussion yesterday we didn't seem to make much headway on what the right class hierarchy is here.

Re: [Qemu-devel] [PATCH] spice: fix 32bit build

2012-03-20 Thread Gerd Hoffmann
Hi, What's the roms/seabios change doing here? Just a missing git submodule update and the diff from that sneaking in. Also, isn't the ui/spice-display.c patch the same as this one from me from a couple of weeks back? http://patchwork.ozlabs.org/patch/145269/ It is. Picked that one up

Re: [Qemu-devel] [PATCH] spice: fix 32bit build

2012-03-20 Thread Peter Maydell
On 20 March 2012 12:13, Gerd Hoffmann kra...@redhat.com wrote: Also, isn't the ui/spice-display.c patch the same as this one from me from a couple of weeks back? http://patchwork.ozlabs.org/patch/145269/ It is.  Picked that one up instead. /me is confused, I through I had that one already

Re: [Qemu-devel] [RFC/RFA PATCH] qapi: detect extra members inside structs

2012-03-20 Thread Luiz Capitulino
On Mon, 19 Mar 2012 19:49:46 -0500 Anthony Liguori anth...@codemonkey.ws wrote: On 03/19/2012 06:45 PM, Michael Roth wrote: So IMO, returning arguments actually seems easier for both clients and the server, and is more resilient to downstream changes. It does require a more formal

Re: [Qemu-devel] [PATCH v4 0/7] RTC: New logic to emulate RTC

2012-03-20 Thread Paolo Bonzini
Il 19/03/2012 07:13, Zhang, Yang Z ha scritto: Current RTC emulation uses periodic timer(2 timers per second) to update RTC clock. And it will stop CPU staying at deep C-state for long period. Our experience shows the Pkg C6 residency reduced 6% when running 64 idle guest. The following patch

Re: [Qemu-devel] [PATCH 23/36] arm: save always 32 fpu registers

2012-03-20 Thread Juan Quintela
Peter Maydell peter.mayd...@linaro.org wrote: On 19 March 2012 22:57, Juan Quintela quint...@redhat.com wrote: This way, we fix a bug (we were overwritten the 16 first registers on load), and we don't need to check for ARM_FEATUR_VPF3, we always send the 32 registers. This commit message is

[Qemu-devel] [PATCH] kvm: allow arbitrarily sized mmio ioeventfd

2012-03-20 Thread Michael S. Tsirkin
We use a 2 byte ioeventfd for virtio memory, add support for this. Signed-off-by: Michael S. Tsirkin m...@redhat.com --- hw/ivshmem.c |8 kvm-all.c| 15 --- kvm-stub.c |2 +- kvm.h|3 ++- 4 files changed, 15 insertions(+), 13 deletions(-) diff

Re: [Qemu-devel] [PATCH] spice: fix 32bit build

2012-03-20 Thread Michael Tokarev
20.03.2012 15:26, Gerd Hoffmann wrote: New 32bit warnings sneaked in, this time in ui/spice-display.c, fix them. This gets annonying, /me sets up a ubuntu buildbot slave for 32bit spice testbuilds. Um, is it worth to watch/fix? Note that spice does not work on 32bits anyway, qemu segfaults

Re: [Qemu-devel] [PATCH 2/2] Expose tsc deadline timer cpuid to guest

2012-03-20 Thread Liu, Jinsong
Rik van Riel wrote: On 03/09/2012 01:27 PM, Liu, Jinsong wrote: As for 'tsc deadline' feature exposing, my patch (as attached) just obey qemu general cpuid exposing method, and also satisfied your target I think. One question. Why is TSC_DEADLINE not exposed in the cpuid allowed

Re: [Qemu-devel] [PATCH] spice: fix 32bit build

2012-03-20 Thread Alon Levy
On Tue, Mar 20, 2012 at 04:45:26PM +0400, Michael Tokarev wrote: 20.03.2012 15:26, Gerd Hoffmann wrote: New 32bit warnings sneaked in, this time in ui/spice-display.c, fix them. This gets annonying, /me sets up a ubuntu buildbot slave for 32bit spice testbuilds. Um, is it worth to

Re: [Qemu-devel] [PATCH V2 2/3] exynos4210: add exynos4210 GPIO implementation

2012-03-20 Thread Peter Maydell
On 15 March 2012 07:35, Igor Mitsyanko i.mitsya...@samsung.com wrote: Now that we have GPIO emulation for exynos4210 SoC we can use it to properly hook up IRQ line to lan9215 controller on SMDK board. +#elif EXYNOS4210_GPIO_DEBUG == 1 +#define DPRINT_L1(fmt, args...)       \ +    do

Re: [Qemu-devel] Build broken -- qemu-ga: add guest-network-get-interfaces command

2012-03-20 Thread Brad Smith
On 20/03/12 6:14 AM, Michal Privoznik wrote: On 18.03.2012 02:09, Brad Smith wrote: Michal, http://git.qemu.org/?p=qemu.git;a=commit;h=3424fc9f16a1e7d1c48eb6d605eb0ca63e199ec2 This broke the build. Un-break the tree. Can you please be more specific? It works for me so I don't have a clue

Re: [Qemu-devel] [PATCH 2/2] Expose tsc deadline timer cpuid to guest

2012-03-20 Thread Eduardo Habkost
On Tue, Mar 20, 2012 at 12:53:57PM +, Liu, Jinsong wrote: Rik van Riel wrote: On 03/09/2012 01:27 PM, Liu, Jinsong wrote: As for 'tsc deadline' feature exposing, my patch (as attached) just obey qemu general cpuid exposing method, and also satisfied your target I think. One

[Qemu-devel] [PATCH] tracetool dtrace disabled-events fix

2012-03-20 Thread Lee Essen
If there are disabled entries in the trace-events file then linetod_nop() is called if the backend is dtrace, it's currently not present. Signed-off-by: Lee Essen lee.es...@nowonline.co.uk -- diff --git a/scripts/tracetool b/scripts/tracetool index 65bd0a1..d5e5591 100755 ---

Re: [Qemu-devel] [PATCH] spice: fix 32bit build

2012-03-20 Thread Peter Maydell
On 20 March 2012 12:45, Michael Tokarev m...@tls.msk.ru wrote: Um, is it worth to watch/fix?  Note that spice does not work on 32bits anyway, qemu segfaults at startup... I've had conflicting answers about this -- the Spice FAQ says it doesn't work on 32 bits but in this message:

Re: [Qemu-devel] KVM call agenda for Tuesday 20th

2012-03-20 Thread Juan Quintela
Juan Quintela quint...@redhat.com wrote: Hi Please send in any agenda items you are interested in covering. As there are no topics, call is cancelled. Happy hacking, Juan.

Re: [Qemu-devel] [PATCH 23/36] arm: save always 32 fpu registers

2012-03-20 Thread Peter Maydell
On 20 March 2012 12:27, Juan Quintela quint...@redhat.com wrote: Peter Maydell peter.mayd...@linaro.org wrote: This commit message is out of date -- the overwriting bug was fixed in commit 15180256 last year. Possibly the patch should be dropped from your series? (If not, ARM_FEATURE_VFP3.)

Re: [Qemu-devel] [PATCH v2 0/2] qapi: fix double free in QMP OV cleanup, add test case

2012-03-20 Thread Luiz Capitulino
On Tue, 20 Mar 2012 11:22:47 +0100 Laszlo Ersek ler...@redhat.com wrote: v1-v2: added Paolo's test case as second patch in the series. Also tried to come up with a better subject for 1/2. Applied to the qmp branch, thanks. Laszlo Ersek (1): qapi: fix double free in

[Qemu-devel] [PATCH v3] qapi: add c_fun to escape function names

2012-03-20 Thread Federico Simoncelli
Signed-off-by: Federico Simoncelli fsimo...@redhat.com --- scripts/qapi-commands.py | 14 +++--- scripts/qapi-types.py|4 ++-- scripts/qapi-visit.py|4 ++-- scripts/qapi.py |5 - 4 files changed, 15 insertions(+), 12 deletions(-) diff --git

Re: [Qemu-devel] [PATCH] use bdrv_aio functions in fdc.c

2012-03-20 Thread Stefan Hajnoczi
On Mon, Mar 19, 2012 at 05:17:15PM +0800, Li Zhi Hui wrote: @@ -1196,107 +1322,108 @@ static int fdctrl_transfer_handler (void *opaque, int nchan, return 0; } cur_drv = get_cur_drv(fdctrl); -if (fdctrl-data_dir == FD_DIR_SCANE || fdctrl-data_dir == FD_DIR_SCANL ||

Re: [Qemu-devel] [PATCH 10/12] trace: [tracetool] Automatically establish available backends and formats

2012-03-20 Thread Lluís Vilanova
Stefan Hajnoczi writes: 2012/3/13 Lluís Vilanova vilan...@ac.upc.edu: Adds decorators to establish which backend and/or format each routine is meant to process. With this, tables enumerating format and backend routines can be eliminated and part of the usage message can be computed in

Re: [Qemu-devel] [PATCH v4 1/7] RTC: Remove the logic to update time format when DM bit changed

2012-03-20 Thread Stefano Stabellini
On Mon, 19 Mar 2012, Zhang, Yang Z wrote: Change DM(date mode) and 24/12 control bit don't affect the internal registers. It only indicates what format is using for those registers. So we don't need to update time format when it is modified. That might be true, but if the user changes

Re: [Qemu-devel] ARM QOM conversion / class hierarchy

2012-03-20 Thread Paul Brook
Option two looks kind of nice, but I'm not sure whether it would actually work. I think you could do 95% of what you need for a different CPU that way (lots of properties for value of ID_MMFR1, value of ID_MMFR2, reset value of SCTLR, etc etc, plus properties for all our existing

Re: [Qemu-devel] [PATCH 09/36] vmstate: introduce float32 arrays

2012-03-20 Thread Peter Maydell
On 19 March 2012 22:57, Juan Quintela quint...@redhat.com wrote: +/* 32 bit float */ + +typedef union { +    float32 f; +    uint32_t i; +} VMStateFloat32; + +static int get_float32(QEMUFile *f, void *pv, size_t size) +{ +    float32 *v = pv; +    VMStateFloat32 u; +    

Re: [Qemu-devel] [PATCH v4 2/7] RTC: Update the RTC clock only when reading it

2012-03-20 Thread Stefano Stabellini
On Mon, 19 Mar 2012, Zhang, Yang Z wrote: There has no need to use two periodic timer to update RTC time. In this patch, we only update it when guest reading it. So the basic idea here is that we don't need to two periodic timers because we are going to calculate the RTC guest time from QEMU's

Re: [Qemu-devel] [PATCH v4 3/7] RTC: Add UIP(update in progress) check logic

2012-03-20 Thread Stefano Stabellini
On Mon, 19 Mar 2012, Zhang, Yang Z wrote: The UIP(update in progress) is set when RTC is updating. And the update cycle begins 244us later after UIP is set. And it is cleared when update end. this patch seems good to me Signed-off-by: Yang Zhang yang.z.zh...@intel.com ---

[Qemu-devel] [Bug 957622] Re: kvm -kernel with grub multiboot kernel dumps core or exits

2012-03-20 Thread Serge Hallyn
** Description changed: I attempted to use kvm -kernel with a grub multiboot image, specifically grub-maverick-20100729.img at [1]. That file was built using [2] $

Re: [Qemu-devel] [PATCH RFC] virtio-pci: add MMIO property

2012-03-20 Thread Avi Kivity
On 03/19/2012 08:57 PM, Michael S. Tsirkin wrote: Should be done via an extra BAR (with the same layout, perhaps extended) so compatibility is preserved. No, that would need guest changes to be of use. The point of this hack is to make things work for Linux guests where PIO does not

Re: [Qemu-devel] ARM QOM conversion / class hierarchy

2012-03-20 Thread Peter Maydell
On 20 March 2012 14:08, Paul Brook p...@codesourcery.com wrote: Option two looks kind of nice, but I'm not sure whether it would actually work. I think you could do 95% of what you need for a different CPU that way (lots of properties for value of ID_MMFR1, value of ID_MMFR2, reset value of

Re: [Qemu-devel] [PATCH] fix multiboot loading if load_end_addr == 0 (fwd)

2012-03-20 Thread Serge E. Hallyn
Quoting Scott Moser (smo...@ubuntu.com): Re-sending to qemu-devel. I'd originally sent this to kvm mailing list. -- Forwarded message -- Date: Sat, 17 Mar 2012 00:08:06 From: Scott Moser smo...@ubuntu.com To: k...@vger.kernel.org Subject: [PATCH] fix multiboot loading if

[Qemu-devel] [PATCH] qemu-ga: Make guest-network-get-interfaces Linux only

2012-03-20 Thread Michal Privoznik
Currently, the implementation of that command is full of Linux specific code. Before any brave man will step into and port it to other OSes, make this function Linux only. Signed-off-by: Michal Privoznik mpriv...@redhat.com --- qga/commands-posix.c | 11 +++ 1 files changed, 11

Re: [Qemu-devel] [PATCH] hw/vexpress.c: Add NOR flash model

2012-03-20 Thread Peter Maydell
On 20 March 2012 14:57, Liming Wang walimis...@gmail.com wrote: Vexpress motherboard has two 2x16 NOR flash, but pflash_cfi01 doesn't support interleaving, so here only models two 1x32 flash. Although it's not exactly modeled, it works fine for running linux. Signed-off-by: Liming Wang

[Qemu-devel] [Bug 957622] Re: kvm -kernel with grub multiboot kernel dumps core or exits

2012-03-20 Thread Serge Hallyn
Thanks, Scott, the patch worked for me so I'll push it. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/957622 Title: kvm -kernel with grub multiboot kernel dumps core or exits Status in QEMU:

Re: [Qemu-devel] [PATCH 09/36] vmstate: introduce float32 arrays

2012-03-20 Thread Juan Quintela
Peter Maydell peter.mayd...@linaro.org wrote: On 19 March 2012 22:57, Juan Quintela quint...@redhat.com wrote: +/* 32 bit float */ + +typedef union { +    float32 f; +    uint32_t i; +} VMStateFloat32; + +static int get_float32(QEMUFile *f, void *pv, size_t size) +{ +    float32 *v =

[Qemu-devel] [PATCH] softfloat: make USE_SOFTFLOAT_STRUCT_TYPES compile

2012-03-20 Thread Juan Quintela
This change makes it compile and return the same value than the #undef one. Signed-off-by: Juan Quintela quint...@redhat.com --- fpu/softfloat.c |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/fpu/softfloat.c b/fpu/softfloat.c index 81a7d1a..a1f4527 100644 ---

[Qemu-devel] [Bug 957622] Re: kvm -kernel with grub multiboot kernel dumps core or exits

2012-03-20 Thread Launchpad Bug Tracker
This bug was fixed in the package qemu-kvm - 1.0+noroms-0ubuntu9 --- qemu-kvm (1.0+noroms-0ubuntu9) precise; urgency=low * debian/patches/multiboot-load-fix.diff: fix bug when loading multiboot images such as grub via -kernel parameter (LP: #957622) -- Scott Moser

Re: [Qemu-devel] [PATCH] softfloat: make USE_SOFTFLOAT_STRUCT_TYPES compile

2012-03-20 Thread Peter Maydell
On 20 March 2012 15:24, Juan Quintela quint...@redhat.com wrote: This change makes it compile and return the same value than the #undef one. Signed-off-by: Juan Quintela quint...@redhat.com Oops, that would have been my fault when I put in the fused multiply accumulate support. Reviewed-by:

Re: [Qemu-devel] [PATCH] softfloat: make USE_SOFTFLOAT_STRUCT_TYPES compile

2012-03-20 Thread Andreas Färber
Am 20.03.2012 16:24, schrieb Juan Quintela: This change makes it compile and return the same value than the #undef one. Signed-off-by: Juan Quintela quint...@redhat.com Cool, Acked-by: Andreas Färber afaer...@suse.de Tested the default, non-struct version only. Juan, would it make sense to

Re: [Qemu-devel] [RFC PATCH 08/10] qed: add bdrv_post_incoming_migration operation checking the image

2012-03-20 Thread Stefan Hajnoczi
On Tue, Mar 06, 2012 at 06:32:27PM +0100, Benoît Canet wrote: @@ -1529,6 +1529,19 @@ static int bdrv_qed_change_backing_file(BlockDriverState *bs, return ret; } +static void bdrv_qed_check_if_needed(BlockDriverState *bs) +{ +/* close the block device if the verification fail

  1   2   >