://www.linux-kvm.org/page/VMchannel_Requirements
Signed-off-by: Amit Shah amit.s...@redhat.com
---
hw/virtio-console.c | 37 +
1 files changed, 37 insertions(+), 0 deletions(-)
diff --git a/hw/virtio-console.c b/hw/virtio-console.c
index b2e4eb1..fc0c239 100644
VIRTIO_PCI_QUEUE_MAX is redefined in hw/virtio.c. Let's just keep it in
hw/virtio.h.
Also, bump up the value of the maximum allowed virtqueues to 32. This is
in preparation to allow multiple ports per virtio-console device.
Signed-off-by: Amit Shah amit.s...@redhat.com
---
hw/virtio.c |2
.
Signed-off-by: Amit Shah amit.s...@redhat.com
---
Makefile.target|2 +-
hw/pc.c|9 -
hw/ppc440_bamboo.c |7 -
hw/qdev.c |8 +-
hw/s390-virtio-bus.c | 16 +-
hw/s390-virtio-bus.h |1 +
hw/virtio-console.c| 186 --
hw
On (Tue) Dec 22 2009 [18:55:16], Alexander Graf wrote:
Amit Shah wrote:
This patch migrates virtio-console to the qdev infrastructure and
creates a new virtio-serial bus on which multiple ports are exposed as
devices. The bulk of the code now resides in a new file with
virtio-console.c
*
- * Copyright IBM, Corp. 2008
+ * Copyright Red Hat, Inc. 2009
*
* Authors:
- * Christian Ehrhardt ehrha...@linux.vnet.ibm.com
+ * Amit Shah amit.s...@redhat.com
Please don't remove copyrights.
It seems that way due to file name changes. This is actually a new file
that has
On (Wed) Dec 23 2009 [14:54:55], Markus Armbruster wrote:
Amit Shah amit.s...@redhat.com writes:
This patch migrates virtio-console to the qdev infrastructure and
creates a new virtio-serial bus on which multiple ports are exposed as
devices. The bulk of the code now resides in a new file
On (Wed) Dec 23 2009 [20:02:19], Markus Armbruster wrote:
Amit Shah amit.s...@redhat.com writes:
On (Wed) Dec 23 2009 [14:54:55], Markus Armbruster wrote:
Amit Shah amit.s...@redhat.com writes:
This patch migrates virtio-console to the qdev infrastructure and
creates a new virtio
).
- Locking isn't perfect, a few extra locks are needed, but it doesn't
matter as long as qemu doesn't run it all separately (I've tested
with the kvm tree with -smp 2 as well and it runs fine).
Amit Shah (8):
virtio: Remove duplicate macro definition for max. virtqueues, bump
up the max
VIRTIO_PCI_QUEUE_MAX is redefined in hw/virtio.c. Let's just keep it in
hw/virtio.h.
Also, bump up the value of the maximum allowed virtqueues to 32. This is
in preparation to allow multiple ports per virtio-console device.
Signed-off-by: Amit Shah amit.s...@redhat.com
---
hw/virtio.c |2
port
open/close, sending port properties over to the guest, etc.
This commit is a part of a series of other commits to get the full
implementation of multiport support. Future commits will add other
support as well as ride on the savevm version that we bump up here.
Signed-off-by: Amit Shah amit.s
Via control channel messages, the guest can tell us whether a port got
opened or closed. Similarly, we can also indicate to the guest of host
port open/close events.
Signed-off-by: Amit Shah amit.s...@redhat.com
---
hw/virtio-serial-bus.c | 73
script can pick up this name and create the symlink
mentioned above.
Signed-off-by: Amit Shah amit.s...@redhat.com
---
hw/virtio-serial-bus.c | 16
hw/virtio-serial.c |1 +
hw/virtio-serial.h |8
3 files changed, 25 insertions(+), 0 deletions(-)
diff
the guest to restart sending data.
Signed-off-by: Amit Shah amit.s...@redhat.com
---
hw/virtio-serial-bus.c | 315 +++-
hw/virtio-serial.c |7 +
hw/virtio-serial.h | 44 +++
3 files changed, 364 insertions(+), 2 deletions(-)
diff --git a/hw
Signed-off-by: Amit Shah amit.s...@redhat.com
---
hw/virtio-serial-bus.c |2 ++
hw/virtio-serial.h |1 +
2 files changed, 3 insertions(+), 0 deletions(-)
diff --git a/hw/virtio-serial-bus.c b/hw/virtio-serial-bus.c
index 12317ba..0a85f6e 100644
--- a/hw/virtio-serial-bus.c
+++ b/hw
OOM conditions,
etc.
Sample uses for such a device can be obtaining info from the
guest like the file systems used, apps installed, etc. for
offline usage and logged-in users, clipboard copy-paste, etc.
for online usage.
Signed-off-by: Amit Shah amit.s...@redhat.com
---
hw/virtio-serial.c | 36
There's nothing target-dependent in the virtio-serial code so allow it
to be compiled just once for all the targets.
Signed-off-by: Amit Shah amit.s...@redhat.com
---
Makefile.hw |2 +-
Makefile.target |2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/Makefile.hw
On (Wed) Dec 23 2009 [23:07:24], Markus Armbruster wrote:
Do you expect devices other than virtconsole to go on this bus?
Yes; virtserialport, as the next patch in the series introduces.
Also, virtserialvnc, etc.
Since all devices on this bus need the same device address property
On (Wed) Dec 23 2009 [17:12:22], Anthony Liguori wrote:
On 12/23/2009 01:52 PM, Amit Shah wrote:
This commit converts the virtio-console device to create a new
virtio-serial bus that can host console and generic serial ports. The
file hosting this code is now called virtio-serial-bus.c
On (Wed) Dec 23 2009 [17:14:28], Anthony Liguori wrote:
+/*
+ * Items in struct VirtIOSerialPort.
+ */
+QTAILQ_FOREACH(port,s-ports, next) {
+/*
+ * We put the port number because we may not have an active
+ * port at id 0 that's reserved for a
On (Thu) Dec 24 2009 [11:28:25], Alexander Graf wrote:
ag...@s390t27:/tmp/qemu ./s390x-softmmu/qemu-system-s390x -enable-kvm -vnc
:0 -kernel /boot/image
Did not find PCI bus for virtio-serial-pci
Did not find virtio-serial-bus bus for virtconsole
^cag...@s390t27:/tmp/qemu
On (Thu) Dec 24 2009 [11:26:00], Alexander Graf wrote:
On 23.12.2009, at 20:52, Amit Shah wrote:
Hello,
This series splits up the patches by functionality. Note, however,
that patches 2-6 introduce some functionality that's advertised to the
guest as having to work all at once
On (Thu) Dec 24 2009 [12:33:17], Alexander Graf wrote:
On 24.12.2009, at 11:34, Amit Shah wrote:
On (Thu) Dec 24 2009 [11:28:25], Alexander Graf wrote:
ag...@s390t27:/tmp/qemu ./s390x-softmmu/qemu-system-s390x -enable-kvm
-vnc :0 -kernel /boot/image
Did not find PCI bus for virtio
-console.c file is completely removed and a new
virtio-serial.c is introduced so that reviewing is easier. I can send a
later patch to rename virtio-serial.c back to virtio-console.c.
Amit Shah (8):
virtio: Remove duplicate macro definition for max. virtqueues, bump
up the max
virtio-console: qdev
open/close, sending port properties over to the guest, etc.
This commit is a part of a series of other commits to get the full
implementation of multiport support. Future commits will add other
support as well as ride on the savevm version that we bump up here.
Signed-off-by: Amit Shah amit.s
Via control channel messages, the guest can tell us whether a port got
opened or closed. Similarly, we can also indicate to the guest of host
port open/close events.
Signed-off-by: Amit Shah amit.s...@redhat.com
---
hw/virtio-serial-bus.c | 73
script can pick up this name and create the symlink
mentioned above.
Signed-off-by: Amit Shah amit.s...@redhat.com
---
hw/virtio-serial-bus.c | 16
hw/virtio-serial.c |1 +
hw/virtio-serial.h |8
3 files changed, 25 insertions(+), 0 deletions(-)
diff
Signed-off-by: Amit Shah amit.s...@redhat.com
---
hw/virtio-serial-bus.c |2 ++
hw/virtio-serial.h |1 +
2 files changed, 3 insertions(+), 0 deletions(-)
diff --git a/hw/virtio-serial-bus.c b/hw/virtio-serial-bus.c
index bc47629..cf532f6 100644
--- a/hw/virtio-serial-bus.c
+++ b/hw
There's nothing target-dependent in the virtio-serial code so allow it
to be compiled just once for all the targets.
Signed-off-by: Amit Shah amit.s...@redhat.com
---
Makefile.hw |2 +-
Makefile.target |2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/Makefile.hw
the guest to restart sending data.
Signed-off-by: Amit Shah amit.s...@redhat.com
---
hw/virtio-serial-bus.c | 305 +++-
hw/virtio-serial.c | 11 +-
hw/virtio-serial.h | 39 ++
3 files changed, 348 insertions(+), 7 deletions(-)
diff --git a/hw
OOM conditions,
etc.
Sample uses for such a device can be obtaining info from the
guest like the file systems used, apps installed, etc. for
offline usage and logged-in users, clipboard copy-paste, etc.
for online usage.
Signed-off-by: Amit Shah amit.s...@redhat.com
---
hw/virtio-serial.c | 36
Hey Anthony
[skipping the part Gerd already answered]
On (Tue) Jan 05 2010 [10:42:39], Anthony Liguori wrote:
+static size_t send_control_msg(VirtIOSerialPort *port, void *buf, size_t
len)
+{
+VirtQueueElement elem;
+VirtQueue *vq;
+struct virtio_console_control *cpkt;
+
+
On (Tue) Jan 05 2010 [10:27:19], Gerd Hoffmann wrote:
Hi,
+/* Guest wants to notify us of some event */
+static void handle_control_message(VirtIOSerial *vser, void *buf)
+{
+cpkt-event = le16_to_cpu(cpkt-event);
+cpkt-value = le16_to_cpu(cpkt-value);
Does this modify guest
On (Mon) Jan 04 2010 [14:46:58], Anthony Liguori wrote:
I'll annotate and read/write using the le format.
Just use ldl_p and stl_p. (or ldw/stw as appropriate).
OK, I've switched to ldl/stl.
I'll send out the new series once the one I posted yesterday gets some
time on the list.
+static
. They are split only for easier reviewability.
The older virtio-console.c file is completely removed and a new
virtio-serial.c is introduced so that reviewing is easier. I can send a
later patch to rename virtio-serial.c back to virtio-console.c.
Amit Shah (8):
virtio: Remove duplicate macro
VIRTIO_PCI_QUEUE_MAX is redefined in hw/virtio.c. Let's just keep it in
hw/virtio.h.
Also, bump up the value of the maximum allowed virtqueues to 64. This is
in preparation to allow multiple ports per virtio-console device.
Signed-off-by: Amit Shah amit.s...@redhat.com
---
hw/virtio.c |2
open/close, sending port properties over to the guest, etc.
This commit is a part of a series of other commits to get the full
implementation of multiport support. Future commits will add other
support as well as ride on the savevm version that we bump up here.
Signed-off-by: Amit Shah amit.s
Via control channel messages, the guest can tell us whether a port got
opened or closed. Similarly, we can also indicate to the guest of host
port open/close events.
Signed-off-by: Amit Shah amit.s...@redhat.com
---
hw/virtio-serial-bus.c | 91
script can pick up this name and create the symlink
mentioned above.
Signed-off-by: Amit Shah amit.s...@redhat.com
---
hw/virtio-serial-bus.c | 17 +
hw/virtio-serial.c |1 +
hw/virtio-serial.h |8
3 files changed, 26 insertions(+), 0 deletions(-)
diff
the guest to restart sending data.
Signed-off-by: Amit Shah amit.s...@redhat.com
---
hw/virtio-serial-bus.c | 309 +++-
hw/virtio-serial.c | 11 +-
hw/virtio-serial.h | 39 ++
3 files changed, 352 insertions(+), 7 deletions(-)
diff --git a/hw
Signed-off-by: Amit Shah amit.s...@redhat.com
---
hw/virtio-serial-bus.c |2 ++
hw/virtio-serial.h |1 +
2 files changed, 3 insertions(+), 0 deletions(-)
diff --git a/hw/virtio-serial-bus.c b/hw/virtio-serial-bus.c
index c947143..6b3273d 100644
--- a/hw/virtio-serial-bus.c
+++ b/hw
OOM conditions,
etc.
Sample uses for such a device can be obtaining info from the
guest like the file systems used, apps installed, etc. for
offline usage and logged-in users, clipboard copy-paste, etc.
for online usage.
Signed-off-by: Amit Shah amit.s...@redhat.com
---
hw/virtio-serial.c | 36
There's nothing target-dependent in the virtio-serial code so allow it
to be compiled just once for all the targets.
Signed-off-by: Amit Shah amit.s...@redhat.com
---
Makefile.hw |2 +-
Makefile.target |2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/Makefile.hw
On (Fri) Jan 08 2010 [01:41:48], Andreas Färber wrote:
Am 07.01.2010 um 08:31 schrieb Amit Shah:
There's nothing target-dependent in the virtio-serial code so allow it
to be compiled just once for all the targets.
Signed-off-by: Amit Shah amit.s...@redhat.com
---
Makefile.hw |2
On (Fri) Jan 08 2010 [01:12:31], Jamie Lokier wrote:
Amit Shah wrote:
Guests send us one buffer at a time. Current guests send buffers sized
4K bytes. If guest userspace applications sent out 4K bytes in one
write() syscall, the write request actually sends out multiple buffers,
each
On (Fri) Jan 08 2010 [13:35:03], Jamie Lokier wrote:
Since VNC is clearly designed to work over TCP, and is written by
people who know this, I'm wondering why you think it needs to be
different for virtio-serial.
For vnc putting stuff from a guest clipboard into vnc client clipboard
using
On (Fri) Jan 08 2010 [10:26:59], Anthony Liguori wrote:
On 01/08/2010 07:35 AM, Jamie Lokier wrote:
Sometimes it looks like TCP is maintaining write boundaries, but it is
just an artifact of its behaviour on many systems, and is not reliable
even on those systems where it seems to happen most
On (Mon) Jan 11 2010 [10:45:53], Jamie Lokier wrote:
Amit Shah wrote:
On (Fri) Jan 08 2010 [13:35:03], Jamie Lokier wrote:
Since VNC is clearly designed to work over TCP, and is written by
people who know this, I'm wondering why you think it needs to be
different for virtio-serial
On (Mon) Jan 11 2010 [18:28:52], Anthony Liguori wrote:
I would think that any buffering should be pushed back to the guest.
IOW, if there's available data from the char driver, but the guest
doesn't have a buffer. Don't select on the char driver until the guest
has a buffer available. If
On (Mon) Jan 11 2010 [23:33:56], Jamie Lokier wrote:
Amit Shah wrote:
Are you talking about a VNC protocol command between qemu's VNC server
and the user's VNC client, or a private protocol between the guest and
qemu's VNC server?
What happens is:
1. Guest puts something on its
On (Tue) Jan 12 2010 [09:00:52], Anthony Liguori wrote:
On 01/12/2010 01:16 AM, Amit Shah wrote:
BTW I don't really want this too, I can get rid of it if everyone agrees
we won't support clipboard writes 4k over vnc or if there's a better
idea.
Why bother trying to preserve message
On (Tue) Jan 12 2010 [09:46:55], Anthony Liguori wrote:
On 01/12/2010 09:13 AM, Amit Shah wrote:
On (Tue) Jan 12 2010 [09:00:52], Anthony Liguori wrote:
On 01/12/2010 01:16 AM, Amit Shah wrote:
BTW I don't really want this too, I can get rid of it if everyone agrees
we won't
On (Tue) Jan 12 2010 [09:55:41], Anthony Liguori wrote:
On 01/12/2010 09:49 AM, Amit Shah wrote:
On (Tue) Jan 12 2010 [09:46:55], Anthony Liguori wrote:
On 01/12/2010 09:13 AM, Amit Shah wrote:
On (Tue) Jan 12 2010 [09:00:52], Anthony Liguori wrote:
On 01/12/2010 01:16
Hello,
Here's a run of the clang analyzer on qemu sources for the x86_64
target.
See
http://amitshah.fedorapeople.org/clang-output/2010-01-12-9/
for the results.
There are a few results there which look dubious but a lot of the output
can be useful to fix the bugs.
What's nice about the tool
On (Tue) Jan 12 2010 [19:35:08], Blue Swirl wrote:
On Tue, Jan 12, 2010 at 6:13 PM, Amit Shah amit.s...@redhat.com wrote:
Hello,
Here's a run of the clang analyzer on qemu sources for the x86_64
target.
See
http://amitshah.fedorapeople.org/clang-output/2010-01-12-9
On (Tue) Jan 12 2010 [22:01:15], malc wrote:
Both audio.c issues are wrong, dma/sb16 is of useless operation variety
nevertheless the fix is pushed, hopefuly clang shouldn't complain about
them anymore.
Yes, the count went down to 95 from 98 after your commits.
There are a few false
Running the static checker clang-analyzer on the qemu sources, I found
a few dead assignments.
This patchset removes a few of those.
Amit Shah (6):
vl.c: Remove dead assignment
virtio: net: remove dead assignment
x86: translate.c: remove dead assignment
hw/vga.c: remove dead assignment
clang-analyzer pointed out the value of 'sockets' is never reused.
Signed-off-by: Amit Shah amit.s...@redhat.com
CC: Andre Przywara andre.przyw...@amd.com
---
vl.c |6 +-
1 files changed, 1 insertions(+), 5 deletions(-)
diff --git a/vl.c b/vl.c
index b048e89..e49e7bd 100644
--- a/vl.c
clang-analyzer points out value assigned to 'len' is not used.
Signed-off-by: Amit Shah amit.s...@redhat.com
---
hw/virtio-net.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/hw/virtio-net.c b/hw/virtio-net.c
index 02d9180..6e48997 100644
--- a/hw/virtio-net.c
+++ b
clang-analyzer points out a redundant assignment.
Signed-off-by: Amit Shah amit.s...@redhat.com
---
target-i386/translate.c |2 --
1 files changed, 0 insertions(+), 2 deletions(-)
diff --git a/target-i386/translate.c b/target-i386/translate.c
index 511a4ea..8078112 100644
--- a/target-i386
clang-analyzer points out a redundant assignment.
Signed-off-by: Amit Shah amit.s...@redhat.com
---
hw/vga.c |1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/hw/vga.c b/hw/vga.c
index d05f1f9..6a1a059 100644
--- a/hw/vga.c
+++ b/hw/vga.c
@@ -1303,7 +1303,6 @@ static void
clang-analyzer points out a redundant assignment.
Signed-off-by: Amit Shah amit.s...@redhat.com
---
block/qcow2-refcount.c |1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/block/qcow2-refcount.c b/block/qcow2-refcount.c
index 54b19f8..3a2d44a 100644
--- a/block/qcow2
clang-analyzer points out a redundant increment.
Signed-off-by: Amit Shah amit.s...@redhat.com
---
json-parser.c |2 --
1 files changed, 0 insertions(+), 2 deletions(-)
diff --git a/json-parser.c b/json-parser.c
index 7624c0f..e04932f 100644
--- a/json-parser.c
+++ b/json-parser.c
@@ -247,8
On (Wed) Jan 13 2010 [12:46:22], Paolo Bonzini wrote:
On 01/13/2010 11:54 AM, Amit Shah wrote:
clang-analyzer points out a redundant assignment.
Signed-off-by: Amit Shahamit.s...@redhat.com
---
block/qcow2-refcount.c |1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git
On (Wed) Jan 13 2010 [19:08:11], Blue Swirl wrote:
Thanks. I fixed the warnings related to Sparc32. Were there really no
new warnings for Sparc64?
Looks like it; vl.c gets reported three times at the same locations so 3
arches have been compiled.
My test machine is down ATM, I can confirm
There's nothing target-dependent in the virtio-serial code so allow it
to be compiled just once for all the targets.
Signed-off-by: Amit Shah amit.s...@redhat.com
---
Makefile.objs |2 +-
Makefile.target |2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git
script can pick up this name and create the symlink
mentioned above.
Signed-off-by: Amit Shah amit.s...@redhat.com
---
hw/virtio-serial-bus.c | 17 +
hw/virtio-serial.c |1 +
hw/virtio-serial.h |8
3 files changed, 26 insertions(+), 0 deletions(-)
diff
open/close, sending port properties over to the guest, etc.
This commit is a part of a series of other commits to get the full
implementation of multiport support. Future commits will add other
support as well as ride on the savevm version that we bump up here.
Signed-off-by: Amit Shah amit.s
Signed-off-by: Amit Shah amit.s...@redhat.com
---
hw/virtio-serial-bus.c |2 ++
hw/virtio-serial.h |1 +
2 files changed, 3 insertions(+), 0 deletions(-)
diff --git a/hw/virtio-serial-bus.c b/hw/virtio-serial-bus.c
index 1ec67d2..d045ea5 100644
--- a/hw/virtio-serial-bus.c
+++ b/hw
. When
the number of bytes cached go lesser than the limit specified, we tell
the guest to restart sending data.
Signed-off-by: Amit Shah amit.s...@redhat.com
---
hw/virtio-serial-bus.c | 215 +++-
hw/virtio-serial.c |6 --
hw/virtio-serial.h
is completely removed and a new
virtio-serial.c is introduced so that reviewing is easier. I can send a
later patch to rename virtio-serial.c back to virtio-console.c.
Amit Shah (8):
virtio: Remove duplicate macro definition for max. virtqueues, bump
up the max
virtio-console: qdev conversion, new
Via control channel messages, the guest can tell us whether a port got
opened or closed. Similarly, we can also indicate to the guest of host
port open/close events.
Signed-off-by: Amit Shah amit.s...@redhat.com
---
hw/virtio-serial-bus.c | 91
VIRTIO_PCI_QUEUE_MAX is redefined in hw/virtio.c. Let's just keep it in
hw/virtio.h.
Also, bump up the value of the maximum allowed virtqueues to 64. This is
in preparation to allow multiple ports per virtio-console device.
Signed-off-by: Amit Shah amit.s...@redhat.com
---
hw/virtio.c |2
On (Tue) Jan 19 2010 [17:59:33], Jamie Lokier wrote:
What happens if the guest crashes, kexecs or whatever when it's half
way through sending a cut buffer? A stream protocol will not have a
nice way to recover from that unless there is an additional out of
band way to say I'm starting
to rename virtio-serial.c back to virtio-console.c.
Amit Shah (8):
virtio: Remove duplicate macro definition for max. virtqueues, bump
up the max
virtio-console: qdev conversion, new virtio-serial-bus
virtio-serial-bus: Maintain guest and host port open/close state
virtio-serial-bus
VIRTIO_PCI_QUEUE_MAX is redefined in hw/virtio.c. Let's just keep it in
hw/virtio.h.
Also, bump up the value of the maximum allowed virtqueues to 64. This is
in preparation to allow multiple ports per virtio-console device.
Signed-off-by: Amit Shah amit.s...@redhat.com
---
hw/virtio.c |2
Via control channel messages, the guest can tell us whether a port got
opened or closed. Similarly, we can also indicate to the guest of host
port open/close events.
Signed-off-by: Amit Shah amit.s...@redhat.com
---
hw/virtio-serial-bus.c | 94
script can pick up this name and create the symlink
mentioned above.
Signed-off-by: Amit Shah amit.s...@redhat.com
---
hw/virtio-serial-bus.c | 17 +
hw/virtio-serial.c |1 +
hw/virtio-serial.h |8
3 files changed, 26 insertions(+), 0 deletions(-)
diff
, etc. for online usage.
Signed-off-by: Amit Shah amit.s...@redhat.com
---
hw/virtio-serial.c | 34 ++
1 files changed, 34 insertions(+), 0 deletions(-)
diff --git a/hw/virtio-serial.c b/hw/virtio-serial.c
index 9c2c93c..bd44ec6 100644
--- a/hw/virtio-serial.c
There's nothing target-dependent in the virtio-serial code so allow it
to be compiled just once for all the targets.
Signed-off-by: Amit Shah amit.s...@redhat.com
---
Makefile.objs |2 +-
Makefile.target |2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git
This commit enables the use of MSI interrupts for virtqueue
notifications for ports. We use nr_ports + 1 (for control channel) msi
entries for the ports, as only the in_vq operations need an interrupt on
the guest.
Signed-off-by: Amit Shah amit.s...@redhat.com
---
hw/virtio-pci.c |4
1
On (Thu) Jan 21 2010 [10:53:36], Markus Armbruster wrote:
Amit, what about renaming hw/virtio-serial.c to a less misleading name
now?
I'm going to push that upstream; Anthony in the past indicated he was ok
with it.
Amit
This file was renamed to ease the reviews of the recent changes
that went in.
Now that the changes are done, rename the file back to its original
name.
Signed-off-by: Amit Shah amit.s...@redhat.com
---
Makefile.objs|2 +-
hw/{virtio-serial.c = virtio-console.c
These hunks got dropped off mysteriously during the rebasing of my
virtio-serial series. Thanks go to Markus for noticing it.
Without these fixes, -virtioconsole doesn't actually have any effect.
Signed-off-by: Amit Shah amit.s...@redhat.com
Reported-by: Markus Armbruster arm...@redhat.com
On (Wed) Jan 13 2010 [12:32:54], Amit Shah wrote:
I'd be very interested in the results of Sparc32 and Sparc64 analyses.
OK, I added the two targets to the run and got the following result:
http://amitshah.fedorapeople.org/clang-output/2010-01-13-1/
The bug count went up from 95
This commit enables one to use multiple virtio-serial devices and to
assign ports to arbitrary devices like this:
-device virtio-serial,id=foo -device virtio-serial,id=bar \
-device virtserialport,bus=foo.0,name=foo \
-device virtserialport,bus=bar.0,name=bar
Signed-off-by: Amit Shah
We have some duplicated code in the CONFIG_IOTHREAD #ifdef and #else
cases. Fix that.
Signed-off-by: Amit Shah amit.s...@redhat.com
---
kvm-all.c |9 +++--
1 files changed, 3 insertions(+), 6 deletions(-)
diff --git a/kvm-all.c b/kvm-all.c
index 15ec38e..a2bd78e 100644
--- a/kvm-all.c
Just a 1-1 conversion for now.
Signed-off-by: Amit Shah amit.s...@redhat.com
---
vnc.c | 73 -
vnc.h |5 ++-
2 files changed, 30 insertions(+), 48 deletions(-)
diff --git a/vnc.c b/vnc.c
index 92facde..16fc4e9 100644
Just a 1-1 conversion for now.
Signed-off-by: Amit Shah amit.s...@redhat.com
---
v2:
- QTAILQ_INIT the queue.
vnc.c | 74
vnc.h |5 ++-
2 files changed, 31 insertions(+), 48 deletions(-)
diff --git a/vnc.c b/vnc.c
index
Hello,
In my testing of virtio-console, I found qemu-kvm.git introduces a lot
of overhead in thread scheduling compared to qemu.git.
My test sends a 260M file from the host to a guest via a virtio-console
port and then computes the sha1sum of the file on the host as well as on
the guest,
On (Mon) Feb 08 2010 [08:57:05], Anthony Liguori wrote:
On 02/08/2010 07:46 AM, Amit Shah wrote:
Hello,
In my testing of virtio-console, I found qemu-kvm.git introduces a lot
of overhead in thread scheduling compared to qemu.git.
My test sends a 260M file from the host to a guest via
On (Fri) Feb 12 2010 [15:42:14], Michael S. Tsirkin wrote:
Since commit 98b19252cf1bd97c54bc4613f3537c5ec0aae263, all
serial devices declare MULTIPORT feature.
To allow 0.12 compatibility, we should clear this when
max_nr_ports is 1.
In addition to this, setting max_nr_ports to 1 is needed
On (Mon) Feb 15 2010 [10:03:34], Gerd Hoffmann wrote:
On 02/12/10 15:23, Amit Shah wrote:
On (Fri) Feb 12 2010 [15:42:14], Michael S. Tsirkin wrote:
Since commit 98b19252cf1bd97c54bc4613f3537c5ec0aae263, all
serial devices declare MULTIPORT feature.
To allow 0.12 compatibility, we should
The version 0.13 will be the new default and compatibility options will
be added to the 0.12 version.
Signed-off-by: Amit Shah amit.s...@redhat.com
---
hw/pc.c |9 -
1 files changed, 8 insertions(+), 1 deletions(-)
diff --git a/hw/pc.c b/hw/pc.c
index 6fbe98b..7c9a24e 100644
virtio-serial-pci can support multiple ports in the current development
version that will become 0.13. Add compatibility options for the 0.12
and 0.11 pc machine types.
Signed-off-by: Amit Shah amit.s...@redhat.com
---
hw/pc.c | 29 +
1 files changed, 29 insertions
From: Michael S. Tsirkin m...@redhat.com
Since commit 98b19252cf1bd97c54bc4613f3537c5ec0aae263, all
serial devices declare MULTIPORT feature.
To allow 0.12 compatibility, we should clear this when
max_nr_ports is 1.
Signed-off-by: Michael S. Tsirkin m...@redhat.com
Signed-off-by: Amit Shah
On (Mon) Feb 15 2010 [15:36:34], Gerd Hoffmann wrote:
@@ -1143,6 +1171,7 @@ static QEMUMachine isapc_machine = {
static void pc_machine_init(void)
{
qemu_register_machine(pc_machine);
+qemu_register_machine(pc_machine_v0_12);
qemu_register_machine(pc_machine_v0_11);
On (Mon) Feb 15 2010 [16:07:28], Michael S. Tsirkin wrote:
On Mon, Feb 15, 2010 at 06:51:31PM +0530, Amit Shah wrote:
On (Fri) Feb 12 2010 [15:42:14], Michael S. Tsirkin wrote:
Since commit 98b19252cf1bd97c54bc4613f3537c5ec0aae263, all
serial devices declare MULTIPORT feature.
To allow
From: Michael S. Tsirkin m...@redhat.com
Since commit 98b19252cf1bd97c54bc4613f3537c5ec0aae263, all
serial devices declare MULTIPORT feature.
To allow 0.12 compatibility, we should clear this when
max_nr_ports is 1.
Signed-off-by: Michael S. Tsirkin m...@redhat.com
Signed-off-by: Amit Shah
The version 0.13 will be the new default and compatibility options will
be added to the 0.12 version.
Signed-off-by: Amit Shah amit.s...@redhat.com
---
v2: register the 0.12 version in this patch instead of the next one.
hw/pc.c | 10 +-
1 files changed, 9 insertions(+), 1 deletions
Hello,
These are fixes for qemu's char layer. All of the patches have been sent
earlier, this is just a resend with the fix for console char devs included
in the series that was sent separately earlier.
Amit Shah (4):
char: check for initial_reset_issued unnecessary
char: rename
301 - 400 of 1939 matches
Mail list logo
