Re: connection notes across TLS?

2006-08-09 Thread Michael Holzt
No, the connect hook has already fired by the time that the TLS connection is established. But if the switch to TLS has basically the same effect as opening a new connection, we should probably run the connect-hook again at that time. Or we could have an additional 'connect_tls' (or

Re: connection notes across TLS?

2006-08-09 Thread John Peacock
Michael Holzt wrote: But if the switch to TLS has basically the same effect as opening a new connection, we should probably run the connect-hook again at that time. Or we could have an additional 'connect_tls' (or 'connect_restart'?) hook (which could also be used on port 465 for the deprecated

Re: connection notes across TLS?

2006-08-09 Thread Matt Sergeant
On 9-Aug-06, at 7:17 AM, Michael Holzt wrote: I consider TLS beeing implemented by unrecognized_command unclean anyway. Ironically I consider the way AUTH was implemented to be unclean. It's all a matter of perspective.

Re: connection notes across TLS?

2006-08-09 Thread Matt Sergeant
On 9-Aug-06, at 12:47 PM, Michael Holzt wrote: I consider TLS beeing implemented by unrecognized_command unclean anyway. Ironically I consider the way AUTH was implemented to be unclean. It's all a matter of perspective. Oh, i'm sure we can agree that both ways are not too clean. I think the

connection notes across TLS?

2006-08-08 Thread sub-qp-stuff
I am running 0.32 forkserver with mostly custom/customized plugins. I have a connection plugin (connect hook) which happens to set some connection notes, but when TLS runs, the notes are no longer there. I think that sounds appropriate, as TLS essentially starts a new connection.

Re: connection notes across TLS?

2006-08-08 Thread John Peacock
[EMAIL PROTECTED] wrote: I think that sounds appropriate, as TLS essentially starts a new connection. It's a required part of the RFC, see RFC-2487 Section 5.2: Upon completion of the TLS handshake, ... [t]he server MUST discard any knowledge obtained from the client... Can

Re: connection notes across TLS?

2006-08-08 Thread sub-qp-stuff
On Tue, 8 Aug 2006, John Peacock wrote: [EMAIL PROTECTED] wrote: Can anyone please suggest a simple way to pass a note from the connection plugin to everything after TLS? You can't. What information are you trying to pass? Can you redo whatever analysis you performed before, say in