Yes, we do all our development and most of our testing on Linux. Truth be
told, a lot of our Windows support is provided by third parties right now.
Unfortunately, a lot of our dependencies are not really tested well on
Windows, so it's difficult to support.
You will have the best luck with a
Submitted as Issue 1536.
Thanks,
Michael
On Mar 9, 3:26 pm, Christian Hammond chip...@chipx86.com wrote:
Would you mind filing a bug so we can track it for 1.5? This sounds bad and
I want to make sure it doesn't slip.
I've looked through the code and can't determine why this would happen
A couple of questions about alternatives for me:
1. I figure I can have everyone create a local username that matches
their AD login name.
If I later on turn on AD in RB can I do something to the database to
effectively switch those users to AD without having to delete and
recreate accounts?
Christian,
That was a great idea, I found the issue : the setting in the database
for some reason was still pointing to the old 0.9 installation path.
Here are the result for the MEDIA_ROOT values:
print settings.MEDIA_ROOT
/var/www/html/reviewboard/htdocs/media
load_site_config()
print
I noticed something surprising today. Besides my RB root account, I
have my personal account set up with staff permissions (so I and
others can e.g. add users without using the superuser account), but
apparently this power includes the ability to make anyone superuser. Is
there a permission to
Staff means you have the ability to create/delete/modify anything in the
database that you have permissions for (by default, this is everything, I
believe). Superuser means you have it no matter what permissions are set.
You basically have every single permission automatically.
This is a Django
Hi Michael,
If AD is set, Review Board will use AD to authenticate for that user,
regardless of whether there was previously a user entry created with the
built-in authentication mechanism. What will happen is that there will be a
database entry for that user created through either method, and if
Ah, glad that was it!
Christian
--
Christian Hammond - chip...@chipx86.com
Review Board - http://www.reviewboard.org
VMware, Inc. - http://www.vmware.com
On Wed, Mar 10, 2010 at 9:09 AM, hschnit herve.schnitz...@gmail.com wrote:
Christian,
That was a great idea, I found the issue : the
On 2010-03-10 15:07, Christian Hammond wrote:
Staff means you have the ability to create/delete/modify anything in the
database that you have permissions for (by default, this is everything, I
believe). Superuser means you have it no matter what permissions are set.
You basically have every
I would be pretty curious to see what they say about this. I've never
thought about it.
Looks like you're no the first to notice this:
http://stackoverflow.com/questions/2297377/how-do-i-prevent-permission-escalation-in-django-admin-when-granting-user-change
We probably could make a custom
I think Clearcase can be used in a way where that type of extended
path is valid. You should double check if you can open that file path
directly yourself and perhaps see why it might think that is the
previous version. I don't really understand the logic used to find
previous revisions in
I would generalize Stephen's idea and just call it general support for
distributed vcs workflow since RB isn't really built around that model
and we're kind of stuffing it in after the fact.
I'd also love to see performance improvements. I haven't done any real
comparisons, but Rietveld and
Agreed on both parts.
There's a bit more that Review Board does than Gerrit and Rietveld under the
hood, but we should certainly strive to make things faster. Is there a
specific area where Review Board feels slower to you?
Christian
--
Christian Hammond - chip...@chipx86.com
Review Board -
I think it's just a general performance comparison, though initial
diff loading is particularly slow. I haven't profiled it, but if you
compare loading reviews.reviewboard.org dashboard to
review.source.android.com, or one of the diffs, the latter just feels
much more instantaneous. I don't know
I spent some time on review.source.android.com a bit earlier and you're
right, it's much snappier.
I'm going to spend some time looking into what the slowdowns are. Part of it
may be due to the Django templating. Part of it is likely Pygments syntax
highlighting. I'll spend some time poking
Hi, Christian.
I think the post-review tools can make some improvements on CVS like
file-revision-independent Repository. As to the dashboard of
Reviewboard, If it gives users ( super user ) the ability to Creating
and Customizing New columns, that would be cool. And more strict
permission system
Hi,
The post-review tool has an option named --branch, I am using
CVS Repository now, But I am not sure whether this branch is equal to
CVS branch.
I had view source of Cvs.py _cat_specific_file() fucntion.
Hi,
The --branch option can actually be any string. It's not even required. It's
basically a way to tell reviewers here's the branch the work is being done
on. It can really be anything you specify, though, as it's for display
purposes only.
Christian
--
Christian Hammond - chip...@chipx86.com
Ok :) So question to authors.
How this should looks like?
On Mar 10, 10:26 pm, Dan Savilonis d...@n-cube.org wrote:
I think Clearcase can be used in a way where that type of extended
path is valid. You should double check if you can open that file path
directly yourself and perhaps see why it
On Wednesday 10 March 2010 08:44:48 am Christian Hammond wrote:
Hi everyone,
We've signed up again this year to take part in Google's Summer of Code.
We're still awaiting acceptance, but want to brainstorm some ideas that
students can work on.
I'd like to see integration with buildbot (via
I would love integration like this, but it's going to have to wait until we
land Extensions support in 2.0. Otherwise we end up complicating the
codebase, dependencies, UI and settings.
Christian
--
Christian Hammond - chip...@chipx86.com
Review Board - http://www.reviewboard.org
VMware, Inc. -
On Thursday 11 March 2010 05:39:29 pm Christian Hammond wrote:
I would love integration like this, but it's going to have to wait until we
land Extensions support in 2.0. Otherwise we end up complicating the
codebase, dependencies, UI and settings.
I respect your call on this, but my (hackish)
It's not the complexity so much.
LDAP, AD, and S3 are things masked by auth and storage backends in Django.
We can get those cheaply and there's no user-facing UI for any of it.
Furthermore, those are needed for core operations of Review Board.
Features like advanced bug tracker integration or
Status: New
Owner:
Labels: Type-Defect Priority-Medium
New issue 1536 by sierragolfoneniner: Enabling Active Directory causes
complete lockout (even local superuser cannot log back in)
http://code.google.com/p/reviewboard/issues/detail?id=1536
I can set up a site, create an admin user
Status: New
Owner:
Labels: Type-Defect Priority-Medium
New issue 1537 by eversding: post-review (RBTools 0.2rc1) fails when
submitting p4 changelist with add'l changes
http://code.google.com/p/reviewboard/issues/detail?id=1537
*NOTE: Do not post confidential information in this bug
Comment #4 on issue 1510 by chipx86: Exception thrown during post-review
-- 'rsp' is used before being defined
http://code.google.com/p/reviewboard/issues/detail?id=1510
Issue 1537 has been merged into this issue.
--
You received this message because you are listed in the owner
or CC fields
Updates:
Status: Duplicate
Mergedinto: 1510
Comment #1 on issue 1537 by chipx86: post-review (RBTools 0.2rc1) fails
when submitting p4 changelist with add'l changes
http://code.google.com/p/reviewboard/issues/detail?id=1537
This was fixed after RC1, in the nightlies. A new
Updates:
Labels: Milestone-Release1.5
Comment #1 on issue 1538 by chipx86: Groups cannot be starred in 1.5 Beta1
http://code.google.com/p/reviewboard/issues/detail?id=1538
(No comment was entered for this change.)
--
You received this message because you are listed in the owner
or CC
Status: New
Owner:
Labels: Type-Defect Priority-Medium
New issue 1539 by lonico: 'WatchedGroupDataGrid' object has no
attribute 'counts'
http://code.google.com/p/reviewboard/issues/detail?id=1539
*NOTE: Do not post confidential information in this bug report.*
What version are you
Comment #8 on issue 1166 by lonico: view diff failed for files contain Mac
newline char (i.e. CR \r) -- use SVN client
http://code.google.com/p/reviewboard/issues/detail?id=1166
Using the following file as an example (all termination characters are CR
(or \r)):
Sample file.
Should
Status: New
Owner:
Labels: Type-Defect Priority-Medium
New issue 1541 by KoRoN.KaoriYa: Multibyte characters in diff fragments are
broken with syntax highlighting.
http://code.google.com/p/reviewboard/issues/detail?id=1541
I use reviewboard 1.5 beta1. I manage some repositries which
31 matches
Mail list logo
