Re: Review Request 64411: Log Search UI: fixes for search box autocomplete

2017-12-07 Thread Andrii Tkach
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64411/#review193109 --- Ship it! Ship It! - Andrii Tkach On Dec. 7, 2017, 1:23 p.m

Re: Review Request 64225: Implemented additional functionality on the Configure Download screen.

2017-12-04 Thread Andrii Tkach
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64225/#review192710 --- Ship it! Ship It! - Andrii Tkach On Dec. 1, 2017, 4:28 p.m

Re: Review Request 64225: Implemented additional functionality on the Configure Download screen.

2017-12-01 Thread Andrii Tkach
> On Dec. 1, 2017, 11:05 a.m., Andrii Tkach wrote: > > ambari-web/app/routes/installer.js > > Lines 291 (patched) > > <https://reviews.apache.org/r/64225/diff/1/?file=1904854#file1904854line291> > > > > Could you elaborate on your problem, cause Ember

Re: Review Request 64225: Implemented additional functionality on the Configure Download screen.

2017-12-01 Thread Andrii Tkach
tps://reviews.apache.org/r/64225/#comment270620> Could you elaborate on your problem, cause Ember upgrade requires a huge change in the codebase and not feasible in near future? - Andrii Tkach On Nov. 30, 2017, 9:01 p.m., Jason Golieb

Re: Review Request 64050: Ambari UI changes to support Isilon OneFS

2017-11-23 Thread Andrii Tkach
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64050/#review191799 --- Ship it! Ship It! - Andrii Tkach On Nov. 23, 2017, 3:31 p.m

Re: Review Request 63947: Log Search UI: implement access logs table

2017-11-20 Thread Andrii Tkach
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63947/#review191497 --- Ship it! Ship It! - Andrii Tkach On Nov. 20, 2017, 11:34

Re: Review Request 63840: Improved service/component dependency support

2017-11-16 Thread Andrii Tkach
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63840/#review191180 --- Ship it! Ship It! - Andrii Tkach On Nov. 16, 2017, 12:56

Re: Review Request 63840: Improved service/component dependency support

2017-11-16 Thread Andrii Tkach
che.org/r/63840/#comment268795> From performance perspectives, this better be done in a single loop ambari-web/app/models/stack_service.js Lines 147 (patched) <https://reviews.apache.org/r/63840/#comment268792> You can use someProperty instead. - A

Re: Review Request 63722: Remove IPA integration from experimental status

2017-11-10 Thread Andrii Tkach
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63722/#review190719 --- Ship it! Ship It! - Andrii Tkach On Nov. 10, 2017, 11:22

Re: Review Request 63624: Log Search UI: add navigation to first and last page

2017-11-07 Thread Andrii Tkach
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63624/#review190308 --- Ship it! Ship It! - Andrii Tkach On Nov. 7, 2017, 3:01 p.m

Re: Review Request 63616: Log Search UI: button with caret doesn't toggle dropdown is some cases

2017-11-07 Thread Andrii Tkach
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63616/#review190297 --- Ship it! Ship It! - Andrii Tkach On Nov. 7, 2017, 1:27 p.m

Re: Review Request 63143: Log Search UI: provide navigation between Service and Audit Logs

2017-10-19 Thread Andrii Tkach
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63143/#review188670 --- Ship it! Ship It! - Andrii Tkach On Oct. 19, 2017, 12:13

Re: Review Request 62896: Log Search UI: small fixes for top part of Service Logs page

2017-10-11 Thread Andrii Tkach
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62896/#review187668 --- Ship it! Ship It! - Andrii Tkach On Oct. 11, 2017, 4:30 p.m

Re: Review Request 62770: Log Search UI: reorganize classes structure

2017-10-04 Thread Andrii Tkach
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62770/#review187085 --- Ship it! Ship It! - Andrii Tkach On Oct. 4, 2017, 12:44 p.m

Re: Review Request 62770: Log Search UI: reorganize classes structure

2017-10-04 Thread Andrii Tkach
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62770/#review187086 --- Ship it! Ship It! - Andrii Tkach On Oct. 4, 2017, 12:44 p.m

Re: Review Request 62549: Log Search UI: implement 'Capture' functionality

2017-09-25 Thread Andrii Tkach
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62549/#review186140 --- Ship it! Ship It! - Andrii Tkach On Sept. 25, 2017, 5:03

Re: Review Request 62433: Log Search UI: implement 'Excluded' filter

2017-09-20 Thread Andrii Tkach
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62433/#review185784 --- Ship it! Ship It! - Andrii Tkach On Sept. 20, 2017, 10:11

Re: Review Request 61971: Log Search UI GA - merge into trunk

2017-08-29 Thread Andrii Tkach
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61971/#review184068 --- Ship it! Ship It! - Andrii Tkach On Aug. 29, 2017, 4:29 p.m

Re: Review Request 61819: Log Search UI: implement timezone picker

2017-08-22 Thread Andrii Tkach
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61819/#review183499 --- Ship it! Ship It! - Andrii Tkach On Aug. 22, 2017, 5:45 p.m

Re: Review Request 61717: Log Search UI: set interval between values for service logs histogram depending on time range

2017-08-17 Thread Andrii Tkach
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61717/#review183139 --- Ship it! Ship It! - Andrii Tkach On Aug. 17, 2017, 3:33 p.m

Re: Review Request 61659: Log Search UI: fix typos in license

2017-08-15 Thread Andrii Tkach
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61659/#review182945 --- Ship it! Ship It! - Andrii Tkach On Aug. 15, 2017, 2:33 p.m

Re: Review Request 61658: Log Search UI: columns set for logs list should be customized by user

2017-08-15 Thread Andrii Tkach
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61658/#review182944 --- Ship it! Ship It! - Andrii Tkach On Aug. 15, 2017, 2:21 p.m

Re: Review Request 61162: Ooozie quicklink configuration doesn't work with https

2017-07-27 Thread Andrii Tkach
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61162/#review181549 --- Ship it! Ship It! - Andrii Tkach On July 26, 2017, 9:22 p.m

Re: Review Request 60864: Log Search UI: implement pagination for logs list

2017-07-14 Thread Andrii Tkach
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60864/#review180520 --- Ship it! Ship It! - Andrii Tkach On July 14, 2017, 12:24

Re: Review Request 60430: Log Search UI: production build doesn't work

2017-06-26 Thread Andrii Tkach
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60430/#review178887 --- Ship it! Ship It! - Andrii Tkach On June 26, 2017, 1:13 p.m

Review Request 59336: When adding services, new versions of configs get added for the config types associated with config groups

2017-05-17 Thread Andrii Tkach
js 7d8721d ambari-web/test/mixins/common/configs/configs_saver_test.js 6e65cf9 Diff: https://reviews.apache.org/r/59336/diff/1/ Testing --- branch-2.5: 30383 passing (30s) 157 pending trunk: 20696 passing (26s) 128 pending Thanks, Andrii Tkach

Review Request 58237: Add Stomp client adapter

2017-04-06 Thread Andrii Tkach
/1/ Testing --- 20690 passing (36s) 128 pending Thanks, Andrii Tkach

Re: Review Request 57721: Custom properties of Alert Target are not reset after last Alert Target being created

2017-03-22 Thread Andrii Tkach
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57721/#review169754 --- Ship it! Ship It! - Andrii Tkach On March 22, 2017, 1:48

Re: Review Request 57813: Service quick links not showing up in the UI

2017-03-22 Thread Andrii Tkach
/ Changes: https://reviews.apache.org/r/57813/diff/1-2/ Testing --- 30380 passing (38s) 157 pending Thanks, Andrii Tkach

Review Request 57813: Service quick links not showing up in the UI

2017-03-21 Thread Andrii Tkach
Thanks, Andrii Tkach

Review Request 57642: Upgrade pre-checks screen does not show CONFIG_MERGE warning

2017-03-15 Thread Andrii Tkach
613f4b ambari-web/test/controllers/main/admin/stack_and_upgrade_controller_test.js 1d88913 ambari-web/test/views/common/modal_popups/cluster_check_popup_test.js d70379b Diff: https://reviews.apache.org/r/57642/diff/1/ Testing --- 20570 passing (32s) 153 pending Thanks, Andrii Tkach

Re: Review Request 57639: Dependent Configurations popup: cells with current and recommended value can have different width

2017-03-15 Thread Andrii Tkach
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57639/#review168993 --- Ship it! Ship It! - Andrii Tkach On March 15, 2017, 11:38

Re: Review Request 57554: JS error when filtering config history table

2017-03-13 Thread Andrii Tkach
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57554/#review168751 --- Ship it! Ship It! - Andrii Tkach On March 13, 2017, 11:40

Review Request 57475: Host Page filter doesn't work after sort by name

2017-03-09 Thread Andrii Tkach
/controllers/main/host/combo_search_box.js dedd290 Diff: https://reviews.apache.org/r/57475/diff/1/ Testing --- 30367 passing (35s) 157 pending Thanks, Andrii Tkach

Re: Review Request 57464: Error during moving ResourceManager without Tez installed

2017-03-09 Thread Andrii Tkach
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57464/#review168457 --- Ship it! Ship It! - Andrii Tkach On March 9, 2017, 2:50 p.m

Review Request 57247: Create Widget: Metrics select is empty after refresh

2017-03-02 Thread Andrii Tkach
/expression_view.js c4a1a3e Diff: https://reviews.apache.org/r/57247/diff/1/ Testing --- 20574 passing (34s) 153 pending Thanks, Andrii Tkach

Review Request 57245: Call to fetch Quick Links host fails

2017-03-02 Thread Andrii Tkach
Diff: https://reviews.apache.org/r/57245/diff/1/ Testing --- 20574 passing (32s) 153 pending Thanks, Andrii Tkach

Review Request 57202: Sometimes the Hosts page shows a different page for page 1

2017-03-01 Thread Andrii Tkach
t/mixins/common/table_server_view_mixin_test.js 2a9c409 ambari-web/test/views/common/table_view_test.js 37dd911 ambari-web/test/views/main/host_test.js a5fce45 Diff: https://reviews.apache.org/r/57202/diff/1/ Testing --- 20574 passing (34s) 153 pending Thanks, Andrii Tkach

Re: Review Request 57034: Handle on UI error on services API while trying to start all services with atleast one component in INSTALL_FAILED state

2017-02-24 Thread Andrii Tkach
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57034/#review166682 --- Ship it! Ship It! - Andrii Tkach On Feb. 24, 2017, 11:31

Review Request 57026: Cover NameNode HA wizard with unit tests

2017-02-24 Thread Andrii Tkach
/wizard_controller_test.js PRE-CREATION Diff: https://reviews.apache.org/r/57026/diff/ Testing --- 20490 passing (33s) 153 pending Thanks, Andrii Tkach

Re: Review Request 56923: Add polyfills for Array.includes and String.includes

2017-02-22 Thread Andrii Tkach
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56923/#review166354 --- Ship it! Ship It! - Andrii Tkach On Feb. 22, 2017, 11:33

Review Request 56679: Hosts page moving through pages gets progressively slower to the point of being unusable

2017-02-14 Thread Andrii Tkach
702e284 ambari-web/test/models/rack_test.js a63eaba ambari-web/test/models/stack_service_test.js bc101e0 ambari-web/test/utils/http_client_test.js 589c44e Diff: https://reviews.apache.org/r/56679/diff/ Testing --- 20340 passing (34s) 153 pending Thanks, Andrii Tkach

Re: Review Request 56596: Admin View: issues with Users/Groups table filters

2017-02-13 Thread Andrii Tkach
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56596/#review165312 --- Ship it! Ship It! - Andrii Tkach On Feb. 13, 2017, 11:49

Review Request 56548: Clicking on the login button (or hitting page refresh) to seeing the dashboard takes a while on a 1000-node cluster

2017-02-10 Thread Andrii Tkach
hanks, Andrii Tkach

Review Request 56502: Unexpected paging behavior on Hosts page

2017-02-09 Thread Andrii Tkach
56502/diff/ Testing --- 30312 passing (34s) 157 pending Thanks, Andrii Tkach

Review Request 56486: Restart Indicator in Service > Config page does not disappear automatically - page refresh required

2017-02-09 Thread Andrii Tkach
/app/mappers/component_config_mapper.js c1568e0 Diff: https://reviews.apache.org/r/56486/diff/ Testing --- 20337 passing (35s) 153 pending Thanks, Andrii Tkach

Re: Review Request 56441: Js errors appear when user try to delete widgets from dashboard

2017-02-08 Thread Andrii Tkach
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56441/#review164668 --- Ship it! Ship It! - Andrii Tkach On Feb. 8, 2017, 12:15 p.m

Review Request 56337: Ambari Web UI is unusably irresponsive on a 1000-node perf cluster after adding AMS (restart indicator loading is too heavy)

2017-02-06 Thread Andrii Tkach
e9dc327 ambari-web/app/views/main/service/menu.js aad718d ambari-web/test/controllers/main/service_test.js 0421a43 ambari-web/test/models/service_test.js e527e1e Diff: https://reviews.apache.org/r/56337/diff/ Testing --- 20326 passing (36s) 153 pending Thanks, Andrii Tkach

Re: Review Request 56298: AMBARI-19871 - Config version switch/compare/revert doesn't work

2017-02-06 Thread Andrii Tkach
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56298/#review164337 --- Ship it! Ship It! - Andrii Tkach On Feb. 4, 2017, 3:32 a.m

Re: Review Request 56298: AMBARI-19871 - Config version switch/compare/revert doesn't work

2017-02-06 Thread Andrii Tkach
52) <https://reviews.apache.org/r/56298/#comment236026> Please remove hoveredServiceVersion completely since we don't use it - Andrii Tkach On Feb. 4, 2017, 3:32 a.m., Richard Zang wrote: > > --- > This is an aut

Re: Review Request 55099: Disable auto start before RU/EU and enable during finalization phase

2017-02-02 Thread Andrii Tkach
--- 19845 passing (24s) 153 pending Thanks, Andrii Tkach

Review Request 56081: Normalize upgrade status label in Upgrade History

2017-01-30 Thread Andrii Tkach
/templates/main/admin/stack_upgrade/upgrade_history.hbs e023fbb ambari-web/app/utils/string_utils.js f4e3674 ambari-web/test/utils/string_utils_test.js 3c7b077 Diff: https://reviews.apache.org/r/56081/diff/ Testing --- 20330 passing (34s) 153 pending Thanks, Andrii Tkach

Review Request 55984: Refreshing the page (browser refresh) when on the tez view goes back to the main views page (non admin user)

2017-01-26 Thread Andrii Tkach
/main.js 382818b Diff: https://reviews.apache.org/r/55984/diff/ Testing --- 20323 passing (33s) 153 pending Thanks, Andrii Tkach

Review Request 55930: Unable to register HDP version 2.6.0.0 on cluster with HDP 2.5.3.0

2017-01-25 Thread Andrii Tkach
Diffs - ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/stackVersions/StackVersionsCreateCtrl.js 3c16963 Diff: https://reviews.apache.org/r/55930/diff/ Testing --- PhantomJS 1.9.8 (Linux): Executed 76 of 76 SUCCESS (0.554 secs / 0.548 secs) Thanks, Andrii

Re: Review Request 55919: "Add Config Property" causes JS-error

2017-01-25 Thread Andrii Tkach
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55919/#review162931 --- Ship it! Ship It! - Andrii Tkach On Jan. 25, 2017, 10:03

Review Request 55918: Move HS2 does not install dependent components on the target host

2017-01-25 Thread Andrii Tkach
, Andrii Tkach

Re: Review Request 55838: Alert Popup doesn't execute callback if it's closed without click on "Primary"

2017-01-23 Thread Andrii Tkach
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55838/#review162614 --- Ship it! Ship It! - Andrii Tkach On Jan. 23, 2017, 11:33

Re: Review Request 55765: llow user to add custom property for log4j

2017-01-23 Thread Andrii Tkach
/resources/stacks/HDP/2.6/services/ATLAS/configuration/atlas-log4j.xml ec93b63 Diff: https://reviews.apache.org/r/55765/diff/ Testing --- Manually tested. Thanks, Andrii Tkach

Review Request 55765: llow user to add custom property for log4j

2017-01-20 Thread Andrii Tkach
tested. Thanks, Andrii Tkach

Re: Review Request 55756: Make the config changes for Add / Delete Service flow more prominent

2017-01-20 Thread Andrii Tkach
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55756/#review162409 --- Ship it! Ship It! - Andrii Tkach On Jan. 20, 2017, 11:27

Review Request 55711: Admin View: add spinners for tables in loading state

2017-01-19 Thread Andrii Tkach
/ui/admin-web/app/views/stackVersions/list.html 5ac78ca ambari-admin/src/main/resources/ui/admin-web/app/views/users/list.html 9e93032 Diff: https://reviews.apache.org/r/55711/diff/ Testing --- PhantomJS 1.9.8 (Linux): Executed 86 of 86 SUCCESS (0.601 secs / 0.6 secs) Thanks, Andrii

Re: Review Request 55673: Add UI UT for alerts

2017-01-18 Thread Andrii Tkach
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55673/#review162074 --- Ship it! Ship It! - Andrii Tkach On Jan. 18, 2017, noon

Re: Review Request 55426: JS error when user click Alert Link in the popup on the service summary page

2017-01-11 Thread Andrii Tkach
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55426/#review161233 --- Ship it! Ship It! - Andrii Tkach On Jan. 11, 2017, 1:52 p.m

Re: Review Request 55380: Add macros `existsInByKey` and `notExistsInByKey`

2017-01-10 Thread Andrii Tkach
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55380/#review161066 --- Ship it! Ship It! - Andrii Tkach On Jan. 10, 2017, 1:34 p.m

Review Request 55376: Ambari should add warning when LogSearch selected without Ambari-Infra

2017-01-10 Thread Andrii Tkach
9b21cf ambari-web/test/utils/configs/theme/theme_test.js c9abf78 Diff: https://reviews.apache.org/r/55376/diff/ Testing --- 20212 passing (36s) 153 pending Thanks, Andrii Tkach

Re: Review Request 55262: Add new macros `ifThenElseByKeys` and write UT

2017-01-06 Thread Andrii Tkach
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55262/#review160705 --- Ship it! Ship It! - Andrii Tkach On Jan. 6, 2017, 11:58 a.m

Re: Review Request 55261: Reconfigure after adding/deleting ZooKeeper Server is not performed if Atlas is installed

2017-01-06 Thread Andrii Tkach
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55261/#review160698 --- Ship it! Ship It! - Andrii Tkach On Jan. 6, 2017, 10:46 a.m

Re: Review Request 55210: Config Groups: Save button not enabled while trying to overwrite configs

2017-01-05 Thread Andrii Tkach
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55210/#review160584 --- Ship it! Ship It! - Andrii Tkach On Jan. 5, 2017, 1:46 p.m

Review Request 55172: Cover JournalNode HA wizard with unit tests

2017-01-04 Thread Andrii Tkach
: https://reviews.apache.org/r/55172/diff/ Testing --- 19935 passing (28s) 153 pending Thanks, Andrii Tkach

Review Request 55100: yarn.nodemanager.linux-container-executor.cgroups.mount-path need to be added to "Isolated" group on UI for yarn configs

2016-12-30 Thread Andrii Tkach
js 3d7ac6d Diff: https://reviews.apache.org/r/55100/diff/ Testing --- 19857 passing (26s) 153 pending Thanks, Andrii Tkach

Review Request 55099: Disable auto start before RU/EU and enable during finalization phase

2016-12-30 Thread Andrii Tkach
/r/55099/diff/ Testing --- 19845 passing (24s) 153 pending Thanks, Andrii Tkach

Re: Review Request 55081: Adding custom property should trim white spaces in the prefix and suffix of the key names

2016-12-29 Thread Andrii Tkach
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55081/#review160274 --- Ship it! Ship It! - Andrii Tkach On Dec. 29, 2016, 12:16

Re: Review Request 55070: UI should validate Ranger user password be more than 8 chars

2016-12-28 Thread Andrii Tkach
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55070/#review160220 --- Ship it! Ship It! - Andrii Tkach On Dec. 28, 2016, 10:38

Re: Review Request 55049: JS-error on the Host details page

2016-12-27 Thread Andrii Tkach
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55049/#review160162 --- Ship it! Ship It! - Andrii Tkach On Dec. 27, 2016, 2:02 p.m

Review Request 55047: Wrong number of filtered hosts

2016-12-27 Thread Andrii Tkach
ambari-web/app/utils/http_client.js dbfc640 Diff: https://reviews.apache.org/r/55047/diff/ Testing --- 19829 passing (25s) 153 pending Thanks, Andrii Tkach

Review Request 54973: Cover global controllers with unit tests

2016-12-22 Thread Andrii Tkach
, Andrii Tkach

Review Request 54865: Ambari UI should use "hosts_with_failures" from "host_resolution_check" in host check

2016-12-19 Thread Andrii Tkach
19725 passing (25s) 153 pending Thanks, Andrii Tkach

Review Request 54789: Integrate karma with babel preprocessor

2016-12-15 Thread Andrii Tkach
--- 19757 passing (24s) 153 pending Thanks, Andrii Tkach

Re: Review Request 54786: DataNodes Live widget can't be edited

2016-12-15 Thread Andrii Tkach
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54786/#review159307 --- Ship it! Ship It! - Andrii Tkach On Dec. 15, 2016, 3:39 p.m

Review Request 54780: Restore styles of remove repository icon

2016-12-15 Thread Andrii Tkach
://reviews.apache.org/r/54780/diff/ Testing --- 19726 passing (26s) 153 pending Thanks, Andrii Tkach

Re: Review Request 54779: SMTP Username and SMTP Password are not highlighted

2016-12-15 Thread Andrii Tkach
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54779/#review159285 --- Ship it! Ship It! - Andrii Tkach On Dec. 15, 2016, 12:37

Review Request 54742: Turning OFF maintenance mode shows a popup on all hosts

2016-12-14 Thread Andrii Tkach
/controllers/global/cluster_controller_test.js fa95c3e Diff: https://reviews.apache.org/r/54742/diff/ Testing --- 19726 passing (28s) 153 pending Thanks, Andrii Tkach

Re: Review Request 54704: Remove UI logic to set or expect hive_server_interactive_host

2016-12-13 Thread Andrii Tkach
053b900 Diff: https://reviews.apache.org/r/54704/diff/ Testing --- 19701 passing (32s) 153 pending Thanks, Andrii Tkach

Re: Review Request 54704: Remove UI logic to set or expect hive_server_interactive_host

2016-12-13 Thread Andrii Tkach
Thanks, Andrii Tkach

Review Request 54704: Remove UI logic to set or expect hive_server_interactive_host

2016-12-13 Thread Andrii Tkach
/controllers/wizard/step7/assign_master_controller_test.js 053b900 ambari-web/test/mixins/main/service/configs/component_actions_by_configs_test.js 1a93a26 Diff: https://reviews.apache.org/r/54704/diff/ Testing --- 19701 passing (32s) 153 pending Thanks, Andrii Tkach

Review Request 54668: Version in process of downgrade isn't displayed by selecting any filter

2016-12-12 Thread Andrii Tkach
ck_upgrade/upgrade_version_box_view_test.js 8087c67 ambari-web/test/views/main/admin/stack_upgrade/version_view_test.js b9e8e6d Diff: https://reviews.apache.org/r/54668/diff/ Testing --- 19881 tests complete (28 seconds) 153 tests pending Thanks, Andrii Tkach

Review Request 54588: Perf: UI hangs after click on button, on step

2016-12-09 Thread Andrii Tkach
st.js eb48ad5 Diff: https://reviews.apache.org/r/54588/diff/ Testing --- 19878 tests complete (27 seconds) 155 tests pending Thanks, Andrii Tkach

Review Request 54581: Wrong filter groups names "Missing translation" on "Upgrade history" tab of Stack and Versions

2016-12-09 Thread Andrii Tkach
re are not "Failed Upgrade" and "Failed Downgrade" in filters. Diffs - ambari-web/app/messages.js 945acfb Diff: https://reviews.apache.org/r/54581/diff/ Testing --- 25565 tests complete (21 seconds) 57 tests pending Thanks, Andrii Tkach

Review Request 54579: Refactor widget instance view on Dashboard

2016-12-09 Thread Andrii Tkach
--- 19874 tests complete (27 seconds) 155 tests pending Thanks, Andrii Tkach

Re: Review Request 54425: Perf: Web UI can't load json with host check info

2016-12-06 Thread Andrii Tkach
the result fails with timeout. Diffs (updated) - ambari-web/app/mixins/main/host/details/actions/check_host.js 532353f Diff: https://reviews.apache.org/r/54425/diff/ Testing --- 19921 tests complete (25 seconds) 155 tests pending Thanks, Andrii Tkach

Review Request 54425: Perf: Web UI can't load json with host check info

2016-12-06 Thread Andrii Tkach
t. Diffs - ambari-web/app/controllers/wizard/step3_controller.js 0e3acd2 ambari-web/app/utils/ajax/ajax.js 09da497 Diff: https://reviews.apache.org/r/54425/diff/ Testing --- 19921 tests complete (25 seconds) 155 tests pending Thanks, Andrii Tkach

Re: Review Request 54379: Host Ordered upgrade should not show as an Upgrade option in UI

2016-12-06 Thread Andrii Tkach
Testing --- 19917 tests complete (27 seconds) 155 tests pending Thanks, Andrii Tkach

Review Request 54379: Host Ordered upgrade should not show as an Upgrade option in UI

2016-12-05 Thread Andrii Tkach
ck_upgrade/upgrade_options.hbs 18fcfcf Diff: https://reviews.apache.org/r/54379/diff/ Testing --- 19917 tests complete (27 seconds) 155 tests pending Thanks, Andrii Tkach

Re: Review Request 54376: Custom property added to the Notification settings appears twice

2016-12-05 Thread Andrii Tkach
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54376/#review157997 --- Ship it! Ship It! - Andrii Tkach On Dec. 5, 2016, 3:11 p.m

Re: Review Request 54369: JS error on "User RedHat Satellite" click on step1 installer

2016-12-05 Thread Andrii Tkach
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54369/#review157981 --- Ship it! Ship It! - Andrii Tkach On Dec. 5, 2016, 11:30 a.m

Review Request 54308: Refactor widgets on Dashboard page

2016-12-02 Thread Andrii Tkach
/diff/ Testing --- 19919 tests complete (29 seconds) 155 tests pending Thanks, Andrii Tkach

Re: Review Request 54254: Delete service action should show the config recommendation popup

2016-12-01 Thread Andrii Tkach
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54254/#review157589 --- Ship it! Ship It! - Andrii Tkach On Dec. 1, 2016, 2 p.m

Re: Review Request 54253: Select Versions page: 'Remove' tooltip does not disappear

2016-12-01 Thread Andrii Tkach
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54253/#review157581 --- Ship it! Ship It! - Andrii Tkach On Dec. 1, 2016, 12:22 p.m

Re: Review Request 54224: Upgrade History Displays Wrong Upgrade Type

2016-12-01 Thread Andrii Tkach
de_history_view.js 31e1478 Diff: https://reviews.apache.org/r/54224/diff/ Testing --- 20020 tests complete (27 seconds) 155 tests pending Thanks, Andrii Tkach

Review Request 54224: Upgrade History Displays Wrong Upgrade Type

2016-11-30 Thread Andrii Tkach
views.apache.org/r/54224/diff/ Testing --- 20020 tests complete (27 seconds) 155 tests pending Thanks, Andrii Tkach

  1   2   >