Re: Review Request 58927: AMBARI-20908 Kafka advertised.listeners replaced in Kerberos Mode

> On Jan. 23, 2018, 5:13 p.m., Jayush Luniya wrote: > > Ship It! Bharat, Can you commit this patch to trunk and branch-2.6 so that it gets picked up in the next Ambari release? - Jayush --- This is an automatically generat

Re: Review Request 58927: AMBARI-20908 Kafka advertised.listeners replaced in Kerberos Mode

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58927/#review196035 --- Ship it! Ship It! - Jayush Luniya On May 2, 2017, 5:28 p.m

Re: Review Request 64693: Add service group dependencies

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64693/#review194150 --- Unit tests? - Jayush Luniya On Dec. 18, 2017, 11:53 p.m

Re: Review Request 64637: Livy/Livy2 Unable To Start Due to Address Already In Use

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64637/#review193872 --- Ship it! Ship It! - Jayush Luniya On Dec. 15, 2017, 3:03

Re: Review Request 64594: AMBARI-22649. Library for querying clusterSettings and stackSettings for its contents in command*.json

/functions/stack_settings.py Lines 24 (patched) <https://reviews.apache.org/r/64594/#comment272454> STACK_NAME_SETTING_KEY or STACK_NAME_PROPERTY Lets try not to use CONFIG to avoid confusion. - Jayush Luniya On Dec. 14, 2017, 9:02 a.m., Swapan Shridhar

Re: Review Request 64528: Zeppelin Interpreter settings are getting updated after zeppelin restart

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64528/#review193570 --- Ship it! Ship It! - Jayush Luniya On Dec. 12, 2017, 4:21

Re: Review Request 64397: AMBARI-22602. Add 'clusterSettings' and 'stackSettings' parameters in Execution Command.

ent271961> settings or stackSettings instead of params? - Jayush Luniya On Dec. 7, 2017, 8:11 a.m., Swapan Shridhar wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://re

Re: Review Request 63923: Unable to enable hdfs, hive plugin in ranger

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63923/#review191389 --- Ship it! Ship It! - Jayush Luniya On Nov. 17, 2017, 6:01

Re: Review Request 63742: Add service dependencies

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63742/#review190786 --- Ship it! Ship It! - Jayush Luniya On Nov. 10, 2017, 11:11

Re: Review Request 63653: Add service group dependencies

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63653/#review190612 --- Ship it! Ship It! - Jayush Luniya On Nov. 9, 2017, 12:16

Re: Review Request 63205: AMBARI-22198. Implement read only API for getting stack level settings.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63205/#review189819 --- Ship it! Ship It! - Jayush Luniya On Oct. 25, 2017, 6:44

Re: Review Request 63441: Remove Slider from Ambari stack definition of HDP 3.0

any changes to HDP-3.0 stack for now. - Jayush Luniya On Oct. 31, 2017, 1:35 p.m., Miklos Gergely wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Re: Review Request 63457: Add service dependencies

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63457/#review189815 --- Ship it! Ship It! - Jayush Luniya On Nov. 1, 2017, 12:20

Re: Review Request 63457: Add service dependencies

Lines 172 (patched) <https://reviews.apache.org/r/63457/#comment267023> Similar feedback for using id as primary key as in the case of servicegroupdependencies. Please address those in a follow up commit. - Jayush Luniya On Nov. 1, 2017, 12:20 a.m., Vitalyi Brodetskyi

Re: Review Request 63051: Add service group dependencies

changes in a separate patch. - Jayush Luniya On Oct. 25, 2017, 11:18 p.m., Vitalyi Brodetskyi wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache

Re: Review Request 63051: Add service group dependencies

INT NOT NULL DEFAULT 0, service_name VARCHAR(255), CONSTRAINT PK_alert_group PRIMARY KEY (group_id), CONSTRAINT uni_alert_group_name UNIQUE(cluster_id,group_name) ); - Jayush Luniya On Oct. 25, 2017, 11:18 p.m., Vi

Re: Review Request 63051: Add service group dependencies

: 2, "dependency_cluster_name" : "fff", "dependency_service_group_id" : 5, "dependency_service_group_name" : "test2" } } {code} - Jayush Luniya On Oct. 25, 2017, 11:18 p.m., Vitalyi Brodetskyi wrote: > >

Re: Review Request 63205: AMBARI-22198. Implement read only API for getting stack level settings.

/services/StacksService.java Lines 1065 (patched) <https://reviews.apache.org/r/63205/#comment265915> Rename to {stackName}/versions/{stackVersion}/settings instead? - Jayush Luniya On Oct. 22, 2017, 11:46 a.m., Swapan Shridhar

Re: Review Request 63051: Add service group dependencies

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63051/#review188693 --- Can you add some sample POST, GET APIs? - Jayush Luniya On Oct

Re: Review Request 62989: AMBARI-22238 : Maven cleanup of ambari utility, logsearch and ambari metrics modules

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62989/#review188059 --- Ship it! Ship It! - Jayush Luniya On Oct. 13, 2017, 8:50

Re: Review Request 62856: Remove cluster-stackid dependency related to Configs

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62856/#review188038 --- Ship it! Ship It! - Jayush Luniya On Oct. 12, 2017, 11:47

Re: Review Request 62802: AMBARI-22196. Refactor non-stack cluster-env configs to cluster settings.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62802/#review187736 --- Ship it! Ship It! - Jayush Luniya On Oct. 11, 2017, 8:26

Re: Review Request 62895: HdpCoreMpack: Quick Links should show NN web UI links

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62895/#review187702 --- Ship it! Ship It! - Jayush Luniya On Oct. 11, 2017, 4:17

Re: Review Request 62895: HdpCoreMpack: Quick Links should show NN web UI links

017, 4:17 p.m.) > > > Review request for Ambari, Dmitro Lisnichenko, Jayush Luniya, and Madhuvanthi > Radhakrishnan. > > > Bugs: AMBARI-22209 > https://issues.apache.org/jira/browse/AMBARI-22209 > > > Repository: ambari > > > Description > ---

Re: Review Request 62895: HdpCoreMpack: Quick Links should show NN web UI links

gt; Why not set quickLinksConfigurations itself? - Jayush Luniya On Oct. 11, 2017, 4:17 p.m., Vitalyi Brodetskyi wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://re

Re: Review Request 62802: AMBARI-22196. Refactor non-stack cluster-env configs to cluster settings.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62802/#review187686 --- Ship it! Ship It! - Jayush Luniya On Oct. 11, 2017, 8:13

Re: Review Request 62802: AMBARI-22196. Refactor non-stack cluster-env configs to cluster settings.

tomatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/62802/ > --- > > (Updated Oct. 11, 2017, 8:13 a.m.) > > > Review request for Ambari, Jayush Luniya and Madhuvanthi Radhakrishnan. > &g

Re: Review Request 62802: AMBARI-22196. Refactor non-stack cluster-env configs to cluster settings.

? ambari-server/src/main/java/org/apache/ambari/server/controller/spi/Resource.java Lines 78 (patched) <https://reviews.apache.org/r/62802/#comment264677> RootClusterSetting - Jayush Luniya On Oct. 11, 2017, 5:27 a.m

Re: Review Request 62802: AMBARI-22196. Refactor non-stack cluster-env configs to cluster settings.

- > > (Updated Oct. 11, 2017, 5:27 a.m.) > > > Review request for Ambari, Jayush Luniya and Madhuvanthi Radhakrishnan. > > > Bugs: AMBARI-22196 > https://issues.apache.org/jira/browse/AMBARI-22196 > > > Repository: amba

Re: Review Request 62856: Remove cluster-stackid dependency related to Configs

> On Oct. 10, 2017, 7:23 a.m., Jayush Luniya wrote: > > ambari-server/src/main/java/org/apache/ambari/server/checks/AbstractCheckDescriptor.java > > Line 248 (original), 246 (patched) > > <https://reviews.apache.org/r/62856/diff/1/?file=1850073#file1850073line248

Re: Review Request 62856: Remove cluster-stackid dependency related to Configs

> On Oct. 10, 2017, 7:23 a.m., Jayush Luniya wrote: > > ambari-server/src/main/java/org/apache/ambari/server/checks/AbstractCheckDescriptor.java > > Line 248 (original), 246 (patched) > > <https://reviews.apache.org/r/62856/diff/1/?file=1850073#file1850073line248

Re: Review Request 62756: Refactor AMS logic in stack advisors to service advisors

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62756/#review187229 --- Ship it! Ship It! - Jayush Luniya On Oct. 5, 2017, 2:22 p.m

Re: Review Request 62756: Refactor AMS logic in stack advisors to service advisors

common-services/LOGSEARCH/test_service_advisor.py - Jayush Luniya On Oct. 4, 2017, 9:03 p.m., Vitalyi Brodetskyi wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.

Re: Review Request 62756: Refactor AMS logic in stack advisors to service advisors

> On Oct. 4, 2017, 12:54 a.m., Jayush Luniya wrote: > > ambari-server/src/main/resources/common-services/AMBARI_METRICS/0.1.0/service_advisor.py > > Lines 21 (patched) > > <https://reviews.apache.org/r/62756/diff/1/?file=1845302#file1845302line21> > > > &g

Re: Review Request 62756: Refactor AMS logic in stack advisors to service advisors

<https://reviews.apache.org/r/62756/#comment263991> Fix Typo "AMS Validator" instead of "Storm Validator" - Jayush Luniya On Oct. 3, 2017, 7:48 p.m., Vitalyi Brodetskyi wrote: > > --- > This is an automatically g

Re: Review Request 62756: Refactor AMS logic in stack advisors to service advisors

/service_advisor.py Line 77 (original), 77 (patched) <https://reviews.apache.org/r/62756/#comment263990> Is this change to ATLAS service advisor supposed to be part of the patch? - Jayush Luniya On Oct. 3, 2017, 7:48 p.m., Vitalyi Brodetskyi

Re: Review Request 62712: AMBARI-22102 Ranger KMS should add proxy user for Spark2 user

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62712/#review186880 --- Ship it! Ship It! - Jayush Luniya On Sept. 30, 2017, 9:58

Re: Review Request 62699: Devdeploy: HiveServer2 Interactive Start failed

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62699/#review186854 --- Ship it! Ship It! - Jayush Luniya On Sept. 30, 2017, 5:31

Re: Review Request 62699: Devdeploy: HiveServer2 Interactive Start failed

eks".format(config_type)) - Jayush Luniya On Sept. 30, 2017, 5:03 a.m., Madhuvanthi Radhakrishnan wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https:

Re: Review Request 62699: Devdeploy: HiveServer2 Interactive Start failed

/CustomServiceOrchestrator.py Line 284 (original), 284 (patched) <https://reviews.apache.org/r/62699/#comment263554> Will role ever be null? I am thinking about service checks etc. Might want to add service_name as fall back just in case. - Jayush Luniya On Sept. 29, 2017, 10:14 p.m., Madhuvanthi Radhakr

Re: Review Request 62599: Remove user to group hardcoded logic in hooks

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62599/#review186529 --- Ship it! Ship It! - Jayush Luniya On Sept. 27, 2017, 9:52

Re: Review Request 62599: Remove user to group hardcoded logic in hooks

p.m., Vitalyi Brodetskyi wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/62599/ > --- > > (Updated Se

Re: Review Request 62599: Remove user to group hardcoded logic in hooks

-ANY/scripts/params.py Line 246 (original) <https://reviews.apache.org/r/62599/#comment262973> Lets also fix the Ganglia configs. - Jayush Luniya On Sept. 26, 2017, 11:23 p.m., Vitalyi Brodetskyi

Re: Review Request 62364: Set tez.runtime.shuffle.ssl.enable=false in Ambari for HSI

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62364/#review185522 --- Ship it! Ship It! - Jayush Luniya On Sept. 16, 2017, 12:45

Re: Review Request 61994: Service repoinfo.xml needs to expose component for Ubuntu repos

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61994/#review185458 --- Ship it! Ship It! - Jayush Luniya On Sept. 14, 2017, 10:47

Re: Review Request 61994: Service repoinfo.xml needs to expose component for Ubuntu repos

n-free - Jayush Luniya On Sept. 13, 2017, 5:37 p.m., Vitalyi Brodetskyi wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.

Re: Review Request 62250: AMBARI-21939 : Ambari HDFS Heatmaps are not showing data (Not Applicable) for bytes read, bytes written & DataNode Process Network I/O Utilization

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62250/#review185250 --- Ship it! Ship It! - Jayush Luniya On Sept. 12, 2017, 4:58

Re: Review Request 62249: Do not export YARN_CONF_DIR in 'yarn-env.sh' file

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62249/#review185211 --- Ship it! Ship It! - Jayush Luniya On Sept. 12, 2017, 4:47

Re: Review Request 62224: NullPointerException during blueprint generation

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62224/#review185126 --- Ship it! Ship It! - Jayush Luniya On Sept. 11, 2017, 10:16

Re: Review Request 62224: NullPointerException during blueprint generation

/internal/BlueprintConfigurationProcessor.java Line 1044 (original), 1045 (patched) <https://reviews.apache.org/r/62224/#comment261347> Why not add the null check in splitAndTrimStrings? splitAndTrimStrings() is used in other places too that dont have null checks. - Jayush Luniya O

Re: Review Request 61994: Service repoinfo.xml needs to expose component for Ubuntu repos

> On Sept. 7, 2017, 8:55 p.m., Jayush Luniya wrote: > > ambari-server/src/main/resources/stacks/HDP/2.6/repos/repoinfo.xml > > Lines 95 (patched) > > <https://reviews.apache.org/r/61994/diff/2/?file=1817744#file1817744line95> > > > > We

Re: Review Request 61994: Service repoinfo.xml needs to expose component for Ubuntu repos

stable. "distribution" should be an optional parameter. - Jayush Luniya On Sept. 7, 2017, 8:40 p.m., Vitalyi Brodetskyi wrote: > > --- > This is an automatically generated e-ma

Re: Review Request 61917: AMBARI-21824. MultiEverything : Make services as sub-resource of ServiceGroups and use Servicegroup while doing Creation, Update and retrieval of HostComponents and ServiceCo

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61917/#review184091 --- Ship it! Ship It! - Jayush Luniya On Aug. 29, 2017, 7:37

Re: Review Request 61917: AMBARI-21824. MultiEverything : Make services as sub-resource of ServiceGroups and use Servicegroup while doing Creation, Update and retrieval of HostComponents and ServiceCo

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61917/#review184047 --- Ship it! Ship It! - Jayush Luniya On Aug. 28, 2017, 9:08

Re: Review Request 61917: AMBARI-21824. MultiEverything : Make services as sub-resource of ServiceGroups and use Servicegroup while doing Creation, Update and retrieval of HostComponents and ServiceCo

/AmbariManagementControllerImpl.java Line 3555 (original), 3559 (patched) <https://reviews.apache.org/r/61917/#comment260026> Rename to findService? - Jayush Luniya On Aug. 28, 2017, 9:08 a.m., Swapan Shridhar

Re: Review Request 61813: Storm Service should not have ranger 'ranger-admin-site' and 'ranger-ugsync-site' dependencies

/browse/AMBARI-14202. Removing this dependency will cause issues when WE is enabled. We need to improve our overall restart required logic but that is a larger improvement to be done. Unfortunatel, for now though we will need to keep these dependencies. - Jayush Luniya On Aug. 22, 2017, 1:42 p.m

Re: Review Request 61709: Ambari should expose whether a service is able to rolling-restart instead of hard coding service name

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61709/#review183449 --- Ship it! Ship It! - Jayush Luniya On Aug. 17, 2017, 7:22

Re: Review Request 61201: AMBARI-21594. MultiEverything : Add Servicegroup as a subresource of Cluster.

> On Aug. 1, 2017, 5:51 a.m., Jayush Luniya wrote: > > ambari-server/src/main/java/org/apache/ambari/server/controller/internal/ServiceGroupResourceProvider.java > > Lines 234 (patched) > > <https://reviews.apache.org/r/61201/diff/4/?file=1786100#file1786100line23

Re: Review Request 61201: AMBARI-21594. MultiEverything : Add Servicegroup as a subresource of Cluster.

erName() + "/" + request.getServiceGroupName()); } - Jayush Luniya On July 31, 2017, 9:06 p.m., Swapan Shridhar wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https:

Re: Review Request 61201: AMBARI-21594. MultiEverything : Add Servicegroup as a subresource of Cluster.

y key should be service group id. - Jayush Luniya On July 28, 2017, 3:48 a.m., Swapan Shridhar wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://re

Re: Review Request 61201: AMBARI-21594. MultiEverything : Add Servicegroup as a subresource of Cluster.

/entities/ServiceGroupEntity.java Lines 57 (patched) <https://reviews.apache.org/r/61201/#comment257341> Primary key in DB should be service group id and not service group name - Jayush Luniya On July 28, 2017, 3:48 a.m., Swapan Shridhar

Re: Review Request 61201: AMBARI-21594. MultiEverything : Add Servicegroup as a subresource of Cluster.

/services/ServiceGroupService.java Lines 201 (patched) <https://reviews.apache.org/r/61201/#comment257339> Bulk update for multiple service groups shouldnt take "serviceGroupName" path param. - Jayush Luniya On July 28, 2017, 3:48 a.m., Swapa

Re: Review Request 61083: AMBARI-21563 : Copy Hadoop core-site.xml to Atlas conf when hadoop is configured for LDAP/AD.

/package/scripts/metadata.py Lines 210 (patched) <https://reviews.apache.org/r/61083/#comment256715> Why do we need to delete? - Jayush Luniya On July 24, 2017, 2:51 p.m., Vishal Suvagia wrote: > > --- > This is a

Re: Review Request 60126: Ambari 2.5.1 upgrade fails with HDPSearch mpack installed

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60126/#review178395 --- Ship it! Ship It! - Jayush Luniya On June 20, 2017, 3:48

Re: Review Request 60126: Ambari 2.5.1 upgrade fails with HDPSearch mpack installed

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60126/#review178323 --- Ship it! Ship It! - Jayush Luniya On June 19, 2017, 10:38

Re: Review Request 60126: Ambari 2.5.1 upgrade fails with HDPSearch mpack installed

Line 428 (original), 428 (patched) <https://reviews.apache.org/r/60126/#comment252128> Any unit tests to cover this? - Jayush Luniya On June 15, 2017, 5:11 p.m., Vitalyi Brodetskyi wrote: > > --- > This is an automatica

Re: Review Request 60126: Ambari 2.5.1 upgrade fails with HDPSearch mpack installed

hence is a symlink. - Jayush Luniya On June 15, 2017, 5:11 p.m., Vitalyi Brodetskyi wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.

Re: Review Request 59718: mpack install fails when using https links

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59718/#review176624 --- Ship it! Address review comment and commit - Jayush Luniya

Re: Review Request 59718: mpack install fails when using https links

81 (patched) <https://reviews.apache.org/r/59718/#comment249987> Looks like this is accidentally commented out - Jayush Luniya On June 1, 2017, 3:03 p.m., Vitalyi Brodetskyi wrote: > > --- > This is an automatically g

Re: Review Request 59718: mpack install fails when using https links

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59718/#review176613 --- Ship it! Ship It! - Jayush Luniya On June 1, 2017, 1:46 p.m

Re: Review Request 59364: AMBARI-21053 Reverting Beacon stack advisor recommendation

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59364/#review175516 --- Ship it! Ship It! - Jayush Luniya On May 18, 2017, 3:03 p.m

Re: Review Request 59113: Ambari fails to start due to NPE after installation of HDF mpack

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59113/#review174420 --- Ship it! - Jayush Luniya On May 10, 2017, 12:21 a.m

Re: Review Request 58995: AMBARI-20932 : Ranger plugin setup should handle Nifi service

--- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58995/ > --- > > (Updated May 4, 2017, 3:16 p.m.) > > > Review request for Ambari, Alejandro

Re: Review Request 58492: Add NIFI StackFeatures to HDP StackFeatures

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58492/#review172397 --- Ship it! Ship It! - Jayush Luniya On April 19, 2017, 7:28

Re: Review Request 58492: Add NIFI StackFeatures to HDP StackFeatures

On April 19, 2017, 5:25 p.m., Madhuvanthi Radhakrishnan wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58492/ > --- > > (Updated April 19, 2017, 5:25 p.

Re: Review Request 58489: VersionAdvertised should be set to False by default in stack_tool.py

--- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58489/ > ------- > > (Updated April 18, 2017, 12:31 a.m.) > > >

Re: Review Request 58489: VersionAdvertised should be set to False by default in stack_tool.py

r_path or not os.path.exists(stack_selector_path): Logger.info('Skipping get_stack_version since " + stack_selector_tool + " is not yet available') return None # lazy fail - Jayush Luniya On April 18, 2017, 12:31 a.m., Madhuvanthi Rad

Re: Review Request 58489: VersionAdvertised should be set to False by default in stack_tool.py

/functions/stack_tools.py Line 49 (original), 49 (patched) <https://reviews.apache.org/r/58489/#comment245319> I believe you will need to fix the unit test command.json files to set the versionAdvertised correctly otherwise it will cause the unit tests to fail. - Jayush Luniya On April 18

Re: Review Request 58356: AMBARI-20735. Checkstyle rule to ensure that all API endpoints are documented

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58356/#review171939 --- Ship it! Ship It! - Jayush Luniya On April 13, 2017, 3:44

Re: Review Request 58277: Skip calling stack selector, conf selector tools for Nifi, Streamline, Registry custom services in HDP cluster

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58277/#review171808 --- Ship it! Ship It! - Jayush Luniya On April 12, 2017, 9:55

Re: Review Request 58277: Skip calling stack selector, conf selector tools for Nifi, Streamline, Registry custom services in HDP cluster

nv.xml Line 89 (original), 89 (patched) <https://reviews.apache.org/r/58277/#comment244803> This change has been reverted and hence we no longer need to include it in the patch - Jayush Luniya On April 12, 2017, 6:04 p.m., Madhuvanthi Radhakr

Re: Review Request 58277: Skip calling stack selector, conf selector tools for Nifi, Streamline, Registry custom services in HDP cluster

nce we should not skip calling stack/conf selector. - Jayush Luniya On April 12, 2017, 6:04 p.m., Madhuvanthi Radhakrishnan wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.

Re: Review Request 58277: Skip calling stack selector, conf selector tools for Nifi, Streamline, Registry custom services in HDP cluster

> This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58277/ > ------- > > (Updated April 12, 2017, 6:04 p.m.) > > > Review request for Ambari, Jonathan Hurley, Jayush Luniya, Nate Cole, and >

Re: Review Request 58277: Skip calling stack selector, conf selector tools for Nifi, Streamline, Registry custom services in HDP cluster

/ExecutionCommand.java Lines 421 (patched) <https://reviews.apache.org/r/58277/#comment244637> Are we using this constant anywhere? - Jayush Luniya On April 11, 2017, 9:50 p.m., Madhuvanthi Radhakrishnan

Re: Review Request 58277: Skip calling stack selector, conf selector tools for Nifi, Streamline, Registry custom services in HDP cluster

t244635> Space after "," - Jayush Luniya On April 11, 2017, 9:50 p.m., Madhuvanthi Radhakrishnan wrote: > > --- > This is an automatically generated e-mail. To rep

Re: Review Request 58277: Skip calling stack selector, conf selector tools for Nifi, Streamline, Registry custom services in HDP cluster

nstead in get_stack_tool you should log the message that cannot return the stack selector tool since versionAdvertised=False. - Jayush Luniya On April 11, 2017, 9:50 p.m., Madhuvanthi Radhakrishnan wrote: > > --- > This is an automatically g

Re: Review Request 58277: Skip calling stack selector, conf selector tools for Nifi, Streamline, Registry custom services in HDP cluster

-- > > (Updated April 11, 2017, 9:50 p.m.) > > > Review request for Ambari, Jonathan Hurley, Jayush Luniya, Nate Cole, and > Sumit Mohanty. > > > Bugs: AMBARI-20696 > https://issues.apache.org/jira/browse/AMB

Re: Review Request 58277: Skip calling stack selector, conf selector tools for Nifi, Streamline, Registry custom services in HDP cluster

> This should actually be False by default. > > Jayush Luniya wrote: > Technically yes default should be False. However we have to ensure that > there are no regressions if versionAdvertised is not passed in some code path > in the command.json. Using versionAdvertis

Re: Review Request 58277: Skip calling stack selector, conf selector tools for Nifi, Streamline, Registry custom services in HDP cluster

omatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58277/ > --- > > (Updated April 7, 2017, 11:47 p.m.) > > > Review request for Ambari, Jayush Luniya and Sumit Mohanty. > > > Bugs: AMBARI-20696 > https://issues.ap

Re: Review Request 58277: Skip calling stack selector, conf selector tools for Nifi, Streamline, Registry custom services in HDP cluster

7 p.m., Madhuvanthi Radhakrishnan wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58277/ > --- > > (Updated April 7, 2017, 11:47 p.m.

Re: Review Request 58031: Ensure only HMS can be deployed with an external store on a cluster

> On March 30, 2017, 4:46 p.m., Jayush Luniya wrote: > > ambari-server/src/test/python/stacks/2.1/HIVE/test_hive_metastore.py > > Lines 203 (patched) > > <https://reviews.apache.org/r/58031/diff/3/?file=1680492#file1680492line203> > > > > Why

Re: Review Request 58051: Misc fixes for ambari-server swagger integration prototype

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58051/#review170616 --- Ship it! Ship It! - Jayush Luniya On March 29, 2017, 10:51

Re: Review Request 58031: Ensure only HMS can be deployed with an external store on a cluster

/test_hive_metastore.py Lines 203 (patched) <https://reviews.apache.org/r/58031/#comment243457> Why is this commented out? - Jayush Luniya On March 29, 2017, 11:57 p.m., Madhuvanthi Radhakrishnan wrote: > > --- > This is an automatica

Re: Review Request 58009: Fetching running application logs results in 'java.io.IOException'

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58009/#review170356 --- Ship it! Ship It! - Jayush Luniya On March 29, 2017, 12:20

Re: Review Request 57863: Alerts Which Fallback To A Port In Absence of a URI Fail

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57863/#review170203 --- Ship it! Ship It! - Jayush Luniya On March 22, 2017, 11:58

Re: Review Request 57795: While generating hash for ambari-server to fill agent cache, all the symlinks should be traversed too.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57795/#review169578 --- Ship it! Ship It! - Jayush Luniya On March 21, 2017, 12:27

Re: Review Request 57253: Credential Store should be enabled by default on fresh installs

that upgrading an existing cluster does not enable the credential store for already deployed services? - Jayush Luniya On March 2, 2017, 7:48 p.m., Madhuvanthi Radhakrishnan wrote: > > --- > This is an automatically generated e-mail. To rep

Re: Review Request 57115: AMBARI-20219 : Grafana Start Failed on HDF cluster

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57115/#review166978 --- Ship it! Ship It! - Jayush Luniya On Feb. 28, 2017, 12:46

Re: Review Request 57089: HDP 3.0 support for Slider with configs, kerberos, widgets, metrics, quicklinks, and themes

> On Feb. 27, 2017, 6:43 p.m., Alejandro Fernandez wrote: > > ambari-server/src/main/resources/stacks/HDP/3.0/services/SLIDER/metainfo.xml, > > line 24 > > > > > > This should be a brand new version of Slider. > >

Re: Review Request 57096: Remove HDP version check in KAFKA service

/stack_features.json (line 25) <https://reviews.apache.org/r/57096/#comment239011> Can you add this to ambari/ambari-server/src/main/resources/stacks/HDP/3.0/properties/stack_features.jsonas well? - Jayush Luniya On Feb. 27, 2017, 7:10 p.m., Madhuvanthi Radhakrishnan

  1   2   3   4   5   >