Re: Review Request 64344: AMBARI-22589 Ambari web UI stack version page is empty due to NPE when target stack does not contain all services from the current stack

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64344/#review193007 --- Ship it! Ship It! - Sangeeta Ravindran On Dec. 5, 2017, 6

Review Request 60489: Typo in stack advisor error message for yarn and mr queue config issues

/resources/stacks/ODPi/2.0/services/stack_advisor.py 5a95fe3 Diff: https://reviews.apache.org/r/60489/diff/1/ Testing --- Manual testing. Ran python tests cleanly. Thanks, Sangeeta Ravindran

Review Request 60488: Ability to delete a view instance from view instance list

488/diff/1/ Testing --- Manual testing. Thanks, Sangeeta Ravindran

Re: Review Request 59756: Delete view privileges from the Groups page

> On June 27, 2017, 12:24 p.m., Sangeeta Ravindran wrote: > > Ship It! > > Anita Jebaraj wrote: > Hi Sangeeta, can you please help in pushing the changes? Done. You can close this review. - Sangeeta --- This i

Re: Review Request 59756: Delete view privileges from the Groups page

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59756/#review178979 --- Ship it! Ship It! - Sangeeta Ravindran On June 2, 2017, 6

Re: Review Request 59913: AMBARI-21197 Disable Kerberos UI step by step panel misalign with the Complete button at the bottom of the page

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59913/#review177327 --- Ship it! Ship It! - Sangeeta Ravindran On June 8, 2017, 12

Re: Review Request 59609: Export cluster_name in the cluster template file

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59609/#review176474 --- Ship it! Ship It! - Sangeeta Ravindran On May 30, 2017, 10

Review Request 59613: Roles below Cluster Administrator should not be allowed to edit repositories and install stack versions

iff: https://reviews.apache.org/r/59613/diff/1/ Testing --- Manual testing. Updated test case. mvn clean test Thanks, Sangeeta Ravindran

Re: Review Request 59497: Customize services shows inconsistent config-groups after clicking on Back

> On May 26, 2017, 5:31 p.m., Sangeeta Ravindran wrote: > > Ship It! > > Amruta Borkar wrote: > Thank you Sangeeta, could you please help me push this to trunk? I've commited this to trunk. Please close t

Re: Review Request 59497: Customize services shows inconsistent config-groups after clicking on Back

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59497/#review176212 --- Ship it! Ship It! - Sangeeta Ravindran On May 23, 2017, 11

Re: Review Request 59532: Add Confirmation pop up for 'Generate Blueprint' button

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59532/#review176025 --- Ship it! Ship It! - Sangeeta Ravindran On May 24, 2017, 10

Re: Review Request 59496: Enable opening views in a new tab

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59496/#review175952 --- Ship it! Ship It! - Sangeeta Ravindran On May 23, 2017, 6

Re: Review Request 59382: Regex pattern for version number in Register Version UI should depend on stack's version dir

enerated e-mail. To reply, visit: https://reviews.apache.org/r/59382/#review175503 --- On May 19, 2017, 5:23 a.m., Sangeeta Ravindran wrote: > > --- > This is an automati

Re: Review Request 59382: Regex pattern for version number in Register Version UI should depend on stack's version dir

https://reviews.apache.org/r/59382/diff/1-2/ Testing --- Manual Testing. I updated the test case because $scope.subversionPattern has been removed as part of this fix. Thanks, Sangeeta Ravindran

Re: Review Request 59382: Regex pattern for version number in Register Version UI should depend on stack's version dir

- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59382/#review175475 --- On May 19, 2017, 5:23 a.m., Sangeeta Ravindran wrote: > > -

Re: Review Request 59373: Address config-groups while exporting blueprint from UI

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/59373/#review175527 --- Ship it! Ship It! - Sangeeta Ravindran On May 19, 2017, 5

Review Request 59382: Regex pattern for version number in Register Version UI should depend on stack's version dir

d the test case because $scope.subversionPattern has been removed as part of this fix. Thanks, Sangeeta Ravindran

Review Request 59222: Hive 1.5.0 view does not load in Internet Explorer 11

ontrib/views/hive-next/src/main/resources/ui/hive-web/app/routes/splash.js 087bab3 Diff: https://reviews.apache.org/r/59222/diff/1/ Testing --- Manual testing in FF, Chrome and IE Thanks, Sangeeta Ravindran

Re: Review Request 58864: AMBARI-20698 Ability to export blueprint via Ambari installer UI

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58864/#review174230 --- Ship it! Ship It! - Sangeeta Ravindran On May 8, 2017, 9:45

Review Request 58981: Service Auto-Start behavior is incorrect for Service Administrator and Service Operator Roles

1f881e0 ambari-web/app/views/main/admin.js 0fa84e8 ambari-web/app/views/main/menu.js 6e79aba Diff: https://reviews.apache.org/r/58981/diff/1/ Testing --- Manual Testing with all 5 roles and Ambari admin. mvn clean test. Thanks, Sangeeta Ravindran

Re: Review Request 58864: AMBARI-20698 Ability to export blueprint via Ambari installer UI

) <https://reviews.apache.org/r/58864/#comment246864> You can use the download icon. - Sangeeta Ravindran On May 1, 2017, 9:06 p.m., Amruta Borkar wrote: > > --- > This is an automatically generated e-mail. To reply,

Re: Review Request 58864: AMBARI-20698 Ability to export blueprint via Ambari installer UI

) <https://reviews.apache.org/r/58864/#comment246847> If this patch intends to add the functionality only during cluster install and not Add Service wizard, then the button should displayed conditionally. - Sangeeta Ravindran On May 1, 2017, 9:06 p.m., Amruta Borkar

Re: Review Request 58864: AMBARI-20698 Ability to export blueprint via Ambari installer UI

(patched) <https://reviews.apache.org/r/58864/#comment246838> Good practice to add a semi-colon. - Sangeeta Ravindran On May 1, 2017, 9:06 p.m., Amruta Borkar wrote: > > --- > This is an automatically generated e-mail.

Re: Review Request 58480: Files View: In non-HA environment, Files view executes with error when "List of NameNodes" property is cleared

/58480/diff/2/ Changes: https://reviews.apache.org/r/58480/diff/1-2/ Testing --- Manual testing. Thanks, Sangeeta Ravindran

Re: Review Request 58590: Provide an optional attribute for custom commands to specify title used in operations window title

al Testing. Added new test cases. Thanks, Sangeeta Ravindran

Re: Review Request 58590: Provide an optional attribute for custom commands to specify title used in operations window title

36 Diff: https://reviews.apache.org/r/58590/diff/2/ Testing --- Manual Testing. Added new test cases. Thanks, Sangeeta Ravindran

Re: Review Request 58590: Provide an optional attribute for custom commands to allow using command name in operations window title

his is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58590/#review172542 --- On April 24, 2017, 11:33 p.m., Sangeeta Ravindran wrote: > > -

Re: Review Request 58590: Provide an optional attribute for custom commands to allow using command name in operations window title

---- On April 24, 2017, 11:33 p.m., Sangeeta Ravindran wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58590/ > -

Re: Review Request 58590: Provide an optional attribute for custom commands to allow using command name in operations window title

adable. > > Alejandro Fernandez wrote: > Sangeeta, what do you think about this? I think it will be more flexible > in the long run. > > Sangeeta Ravindran wrote: > Hi Alejandro, > > Yes I think, it would be better to have a field to allow custo

Re: Review Request 58590: Provide an optional attribute for custom commands to allow using command name in operations window title

Testing --- Manual Testing. Added new test cases. Thanks, Sangeeta Ravindran

Re: Review Request 58590: Provide an optional attribute for custom commands to allow using command name in operations window title

ed patch based on your suggestion and will attach it shortly. - Sangeeta --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58590/#review172549 -----

Re: Review Request 58590: Provide an optional attribute for custom commands to allow using command name in operations window title

js 4b9ec36 Diff: https://reviews.apache.org/r/58590/diff/1/ Testing --- Manual Testing. Added new test cases. Thanks, Sangeeta Ravindran

Review Request 58590: Provide an optional attribute for custom commands to specify string used in operations window title

js c615cae ambari-web/app/views/wizard/step9/hostLogPopupBody_view.js d983252 ambari-web/test/utils/helper_test.js 4b9ec36 Diff: https://reviews.apache.org/r/58590/diff/1/ Testing --- Manual Testing. Added new test cases. Thanks, Sangeeta Ravindran

Re: Review Request 58534: AMBARI-20784 Able to hide the "Why public repo not selected" when no stacks have repoinfo.xml with the "latest" section

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58534/#review172360 --- Ship it! Ship It! - Sangeeta Ravindran On April 19, 2017, 4

Review Request 58480: Files View: In non-HA environment, Files view executes with error when "List of NameNodes" property is cleared

fs.ha.namenodes.list namenodes count is not exactly 2 Diffs - contrib/views/utils/src/main/java/org/apache/ambari/view/utils/hdfs/ConfigurationBuilder.java 7e174a7 Diff: https://reviews.apache.org/r/58480/diff/1/ Testing --- Manual testing. Thanks, Sangeeta Ravindran

Re: Review Request 58423: AMBARI-20757 - Selecting ignore service checks results in blank dialog box when hitting an error

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58423/#review171908 --- Ship it! Ship It! - Sangeeta Ravindran On April 13, 2017, 6

Review Request 58425: Remove Server attribute from the HTTP response headers

. Thanks, Sangeeta Ravindran

Re: Review Request 58371: AMBARI-20737 Able to hide the Use Public Repository option on Register Version page on Ambari Admin View

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58371/#review171898 --- Ship it! Ship It! - Sangeeta Ravindran On April 11, 2017, 9

Re: Review Request 58211: AMBARI-20674 About to hide the Delete menu item from UI for a given service

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58211/#review171157 --- Ship it! Ship It! - Sangeeta Ravindran On April 5, 2017, 3

Re: Review Request 57709: Yarn Queue manager capacity field allows entering invalid values

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57709/#review169575 --- Ship it! Ship It! - Sangeeta Ravindran On March 16, 2017

Review Request 57525: Assign Slaves and Clients page displays incorrect configuration unless a change is made in Assign Masters page

30367 passing (41s) 157 pending Thanks, Sangeeta Ravindran

Re: Review Request 57467: After clearing the content of Users in Yarn Queue Manager, it still shows the user in effective administrators

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57467/#review168489 --- Ship it! Ship It! - Sangeeta Ravindran On March 9, 2017, 5

Re: Review Request 57346: Value for "User Limit Factor" should be float instead of integer in YARN Queue Manager.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57346/#review168488 --- Ship it! Ship It! - Sangeeta Ravindran On March 8, 2017, 11

Review Request 57429: WFM: Page numbers on workflow dashboard are not calculated correctly

ain/resources/ui/app/components/search-table.js 5f92d6f Diff: https://reviews.apache.org/r/57429/diff/1/ Testing --- Manual Tessting. Build failure is unrelated. Thanks, Sangeeta Ravindran

Re: Review Request 57168: Include option to filter out properties from APi that returns ambari.properties file

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57168/#review168317 --- Ship it! Ship It! - Sangeeta Ravindran On March 8, 2017, 5

Review Request 56503: Cannot change user passwords

server/security/authorization/TestUsers.java 875fd46 Diff: https://reviews.apache.org/r/56503/diff/ Testing --- Manual testing. Ran mvn test. Thanks, Sangeeta Ravindran

Review Request 56051: Workflow Manager View : Separate log file into its own directory similar to other views

/var/log/ambari-server/wfmanager-view Thanks, Sangeeta Ravindran

Review Request 55993: On Capacity Scheduler view, click "*" button for "Node label Access" the 2nd time should de-select all node labels, but it doesn't

--- contrib/views/capacity-scheduler/src/main/resources/ui/app/models/queue.js df0c684 Diff: https://reviews.apache.org/r/55993/diff/ Testing --- Manual Testing. Enabling disabling the * button. Ran mvn test. Thanks, Sangeeta Ravindran

Review Request 55992: Workflow Manager: Path does not get set to selected directory when creating FS action node.

). Diffs - contrib/views/wfmanager/src/main/resources/ui/app/components/prepare-config-fs.js ba9b91e Diff: https://reviews.apache.org/r/55992/diff/ Testing --- Tested manually. Build failure is unrelated to the patch. Thanks, Sangeeta Ravindran

Re: Review Request 55990: AMBARI-19728: Custom command name rendered incorrectly

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55990/#review163148 --- Ship it! Ship It! - Sangeeta Ravindran On Jan. 26, 2017, 6

Re: Review Request 55847: AMBARI-19657: Downgrade button does not work after restart Ambari server when upgrade wizard was left open

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55847/#review162666 --- Ship it! Ship It! - Sangeeta Ravindran On Jan. 23, 2017, 4

Re: Review Request 55516: Workflow Manager View: Start record set to 1 even when there are no records

Testing --- Manual testing. Thanks, Sangeeta Ravindran

Re: Review Request 55516: Workflow Manager View: Start record set to 1 even when there are no records

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55516/#review161916 ------- On Jan. 17, 2017, 9:45 p.m., Sangeeta Ravindran wrote: > >

Review Request 55586: Cannot change group/user privileges in list view if the user has VIEW.USER privilege

.USER privilege. Diffs - ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/clusters/UserAccessListCtrl.js 9869d0b Diff: https://reviews.apache.org/r/55586/diff/ Testing --- Manual testing Ran mvn test Thanks, Sangeeta Ravindran

Review Request 55523: When viewing details of a group, the group type is sometimes empty

t once the group type has been retrieved by the REST call. Diffs - ambari-admin/src/main/resources/ui/admin-web/app/scripts/controllers/groups/GroupsEditCtrl.js aa6af2a Diff: https://reviews.apache.org/r/55523/diff/ Testing --- Manual testing. Ran mvn test. Thanks, Sangeeta Ravindran

Review Request 55522: Incorrect error message when trying to add a group to multiple roles

n. Ran mvn test. Thanks, Sangeeta Ravindran

Review Request 55518: When defining yarn.scheduler.capacity..accessible-node-labels with space, Yarn Queue Manager shows error for the queue

ps://reviews.apache.org/r/55518/diff/ Testing --- Manual test. mvn test Build failure is unrelated to the change. Also, I could not reproduce the build failure. The capacity scheduler code compiles cleanly. Thanks, Sangeeta Ravindran

Review Request 55516: Workflow Manager View: Start record set to 1 even when there are no records

by default. Fix is to set the start record to 0, if the total records is 0. Diffs - contrib/views/wfmanager/src/main/resources/ui/app/routes/design/dashboardtab.js 78bc1c9 Diff: https://reviews.apache.org/r/55516/diff/ Testing --- Manual testing. Thanks, Sangeeta Ravindran

Re: Review Request 54911: When Namenode HA is enabled, hbase.rootdir property for ambari-metrics (distributed) does not get updated

-a69e7c1220d2__AMBARI-19206.patch Thanks, Sangeeta Ravindran

Review Request 54911: When Namenode HA is enabled, hbase.rootdir property for ambari-metrics (distributed) does not get updated

, Sangeeta Ravindran

Review Request 54815: Exception when running Slider view - java.lang.NoClassDefFoundError: org/apache/hadoop/yarn/api/protocolrecords/GetLabelsToNodesResponse

- contrib/views/slider/pom.xml bb1b150 Diff: https://reviews.apache.org/r/54815/diff/ Testing --- Manual testing. View execution does not throw execption any more and application can be added. Thanks, Sangeeta Ravindran

Re: Review Request 54314: AMBARI-18926: Kerberos Wizard UI creates duplicate radio buttons for FreeIPA

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54314/#review157801 --- Ship it! Ship It! - Sangeeta Ravindran On Dec. 2, 2016, 6

Re: Review Request 53103: Workflow Designer View: When logs are empty, you see the spinner, instead of a message

b5d-f157db437624__AMBARI-18600.patch Thanks, Sangeeta Ravindran

Re: Review Request 53788: HTTP responses needs to have the character encoding specified in the content type header

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53788/#review156162 --- Ship it! Ship It! - Sangeeta Ravindran On Nov. 15, 2016, 10

Re: Review Request 52455: Ambari UI changes to support PAM authentication

h for 2.5 https://reviews.apache.org/media/uploaded/files/2016/11/16/0d18da03-21c2-4360-90fa-b144d728ee2d__AMBARI-18476_2.5patch Final patch for ambari trunk https://reviews.apache.org/media/uploaded/files/2016/11/16/72fbbb65-b7f4-4e7b-bbf8-63cf872cc725__AMBARI-18476_0411.patch Thanks, San

Re: Review Request 52455: Ambari UI changes to support PAM authentication

r 2.5 https://reviews.apache.org/media/uploaded/files/2016/11/16/0d18da03-21c2-4360-90fa-b144d728ee2d__AMBARI-18476_2.5patch Final patch for ambari trunk https://reviews.apache.org/media/uploaded/files/2016/11/16/72fbbb65-b7f4-4e7b-bbf8-63cf872cc725__AMBARI-18476_0411.patch Thanks, San

Re: Review Request 52455: Ambari UI changes to support PAM authentication

-90fa-b144d728ee2d__AMBARI-18476_2.5patch Thanks, Sangeeta Ravindran

Re: Review Request 52455: Ambari UI changes to support PAM authentication

ally generated e-mail. To reply, visit: https://reviews.apache.org/r/52455/#review154910 --- On Nov. 4, 2016, 9:23 a.m., Sangeeta Ravindran wrote: > > --- > This is an automat

Re: Review Request 52455: Ambari UI changes to support PAM authentication

-4a0c-9a49-0802a21c99fd__AMBARI-18476.patch Patch based on latest code https://reviews.apache.org/media/uploaded/files/2016/11/04/7fa50e96-c66b-4c5e-9321-13b623ab0710__AMBARI-18476.patch Thanks, Sangeeta Ravindran

Re: Review Request 53104: Workflow Designer View: Filtering suggestion for Status on the Workflow Dashboard does not include all status options

g/r/53104/#review154241 --- On Oct. 27, 2016, 9:20 p.m., Sangeeta Ravindran wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://revie

Re: Review Request 53104: Workflow Designer View: Filtering suggestion for Status on the Workflow Dashboard does not include all status options

iew154096 --- On Oct. 27, 2016, 9:20 p.m., Sangeeta Ravindran wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://revie

Re: Review Request 53143: Workflow Designer View: Folder hint does not get overwritten when you type folder name when creating folder in File Browser

iew153743 --- On Oct. 27, 2016, 8:24 p.m., Sangeeta Ravindran wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://revie

Re: Review Request 53143: Workflow Designer View: Folder hint does not get overwritten when you type folder name when creating folder in File Browser

> On Oct. 28, 2016, 7:09 p.m., DIPAYAN BHOWMICK wrote: > > Ship It! > > Sangeeta Ravindran wrote: > Thank you Dipayan. Can you please help push the fix? > > DIPAYAN BHOWMICK wrote: > Done, committed to trunk, branch-2.5 Than

Re: Review Request 53143: Workflow Designer View: Folder hint does not get overwritten when you type folder name when creating folder in File Browser

g/r/53143/#review154163 --- On Oct. 27, 2016, 8:24 p.m., Sangeeta Ravindran wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://revie

Re: Review Request 53103: Workflow Designer View: When logs are empty, you see the spinner, instead of a message

Hence, it is not always an error notification. - Sangeeta --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53103/#review154095 -------

Re: Review Request 53103: Workflow Designer View: When logs are empty, you see the spinner, instead of a message

b5d-f157db437624__AMBARI-18600.patch Thanks, Sangeeta Ravindran

Re: Review Request 53104: Workflow Designer View: Filtering suggestion for Status on the Workflow Dashboard does not include all status options

80dbe88e-524a-4dfa-9a71-2ca31528eb5e__AMBARI-18604.patch Thanks, Sangeeta Ravindran

Re: Review Request 53143: Workflow Designer View: Folder hint does not get overwritten when you type folder name when creating folder in File Browser

__AMBARI-18667.patch Thanks, Sangeeta Ravindran

Re: Review Request 53144: Workflow Designer View: Tooltip for Edit button shows "Back"

To reply, visit: https://reviews.apache.org/r/53144/#review153740 --- On Oct. 24, 2016, 5:20 p.m., Sangeeta Ravindran wrote: > > --- > This is an automatically generated e-mail.

Re: Review Request 53075: Fix JSHint errors in Workflow Manager view

r/53075/#review153593 --- On Oct. 21, 2016, 6:28 p.m., Sangeeta Ravindran wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > h

Re: Review Request 53143: Workflow Designer View: Folder hint does not get overwritten when you type folder name when creating folder in File Browser

/views/wfmanager/src/main/resources/ui/app/templates/components/hdfs-browser.hbs d3233b6 Diff: https://reviews.apache.org/r/53143/diff/ Testing --- Manual Testing. Test failures are not related to the changes in this patch. Thanks, Sangeeta Ravindran

Review Request 53143: Workflow Designer View: Folder hint does not get overwritten when you type folder name when creating folder in File Browser

ces/ui/app/templates/components/hdfs-browser.hbs d3233b6 Diff: https://reviews.apache.org/r/53143/diff/ Testing --- Manual Testing. Test failures are not related to the changes in this patch. Thanks, Sangeeta Ravindran

Review Request 53144: Workflow Designer View: Tooltip for Edit button shows "Back"

trib/views/wfmanager/src/main/resources/ui/app/templates/components/job-details.hbs 872cdbb Diff: https://reviews.apache.org/r/53144/diff/ Testing --- Manual testing. Test failures are unrelated to the changes in this patch. Thanks, Sangeeta Ravindran

Review Request 53104: Workflow Designer View: Filtering suggestion for Status on the Workflow Dashboard does not include all status options

ing. Thanks, Sangeeta Ravindran

Re: Review Request 53103: Workflow Designer View: When logs are empty, you see the spinner, instead of a message

sts. Thanks, Sangeeta Ravindran

Review Request 53103: Workflow Designer View: When logs are empty, you see the spinner, instead of a message

update interval of oss.sonatype.org has elapsed or updates are forced -> [Help 1] Diffs - contrib/views/wfmanager/src/main/resources/ui/app/components/job-details.js ce78e59 Diff: https://reviews.apache.org/r/53103/diff/ Testing --- Manual tests. Thanks, Sangeeta Ravindran

Re: Review Request 53075: Fix JSHint errors in Workflow Manager view

iew153564 --- On Oct. 21, 2016, 6:28 p.m., Sangeeta Ravindran wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://revie

Re: Review Request 53075: Fix JSHint errors in Workflow Manager view

tead of an exact null ? same as previous comment. matches is a array. - Sangeeta --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53075/#review153457

Review Request 53075: Fix JSHint errors in Workflow Manager view

ldOutputJSHint_error.txt Thanks, Sangeeta Ravindran

Re: Review Request 52456: Modify HTTP headers to follow best security practices

> On Oct. 9, 2016, 10:39 p.m., Robert Levas wrote: > > Ship It! > > Sangeeta Ravindran wrote: > Thank you Robert. > Can you please help push the fix? > > Robert Levas wrote: > Pushed to trunk: > > ``` > commit 34c5686c3a0f80

Re: Review Request 52456: Modify HTTP headers to follow best security practices

g/r/52456/#review151944 --- On Oct. 4, 2016, 4:45 p.m., Sangeeta Ravindran wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://revie

Re: Review Request 52456: Modify HTTP headers to follow best security practices

iew151168 --- On Oct. 4, 2016, 4:45 p.m., Sangeeta Ravindran wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://revie

Re: Review Request 52456: Modify HTTP headers to follow best security practices

r/52456/#review151148 --- On Oct. 4, 2016, 4:45 p.m., Sangeeta Ravindran wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > h

Re: Review Request 52455: Ambari UI changes to support PAM authentication

25c3b-1f60-4a0c-9a49-0802a21c99fd__AMBARI-18476.patch Thanks, Sangeeta Ravindran

Re: Review Request 52455: Ambari UI changes to support PAM authentication

file in diff files list. You were able > > to build UI without this files ? UI should fail upon building because of > > declared file that does not exist > > Sangeeta Ravindran wrote: > Hi Aleksandr, > > I accidentally missed adding the file when I creat

Re: Review Request 52456: Modify HTTP headers to follow best security practices

-- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52456/#review151148 --- On Oct. 3, 2016, 4:44 p.m., Sangeeta Ravindran wrote: > > -

Re: Review Request 52456: Modify HTTP headers to follow best security practices

/2016/10/04/32920075-a5ab-481b-bc47-e1be6b569605__AMBARI-17311.patch Updated patch with review comments addressed https://reviews.apache.org/media/uploaded/files/2016/10/04/674db481-c4e0-4afb-98cb-b051d785c710__AMBARI-17311.patch Thanks, Sangeeta Ravindran

Re: Review Request 52455: Ambari UI changes to support PAM authentication

file in diff files list. You were able > > to build UI without this files ? UI should fail upon building because of > > declared file that does not exist > > Sangeeta Ravindran wrote: > Hi Aleksandr, > > I accidentally missed adding the file when I creat

Re: Review Request 52455: Ambari UI changes to support PAM authentication

dded it. New patch has been uplaoded. - Sangeeta --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52455/#review151170 --- On

Re: Review Request 52456: Modify HTTP headers to follow best security practices

Diff: https://reviews.apache.org/r/52456/diff/ Testing --- Test cases have been updated to test with the new headers added. Also did manual testing. Thanks, Sangeeta Ravindran

  1   2   >