Re: Review Request 53980: AMBARI-18945 Allowing user to edit service name while enabling ranger plugin

2016-12-14 Thread Gautam Borad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53980/#review159123 --- Ship it! Ship It! - Gautam Borad On Dec. 13, 2016, 12:40

Re: Review Request 53980: AMBARI-18945 Allowing user to edit service name while enabling ranger plugin

2016-12-13 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53980/#review159040 --- Ship it! Ship It! - Alejandro Fernandez On Dec. 13, 2016,

Re: Review Request 53980: AMBARI-18945 Allowing user to edit service name while enabling ranger plugin

2016-12-13 Thread Mugdha Varadkar
> On Dec. 8, 2016, 2:37 p.m., Jonathan Hurley wrote: > > One thing I'm not clear on is how this will affect an existing > > installation. Won't Ranger have a problem if you change the name of a repo > > on an already running cluster? Reverting the logic > On Dec. 8, 2016, 2:37 p.m.,

Re: Review Request 53980: AMBARI-18945 Allowing user to edit service name while enabling ranger plugin

2016-12-13 Thread Mugdha Varadkar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53980/ --- (Updated Dec. 13, 2016, 12:40 p.m.) Review request for Ambari, Alejandro

Re: Review Request 53980: AMBARI-18945 Allowing user to edit service name while enabling ranger plugin

2016-12-08 Thread Jonathan Hurley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53980/#review158525 --- One thing I'm not clear on is how this will affect an existing

Re: Review Request 53980: AMBARI-18945 Allowing user to edit service name while enabling ranger plugin

2016-12-07 Thread Mugdha Varadkar
> On Dec. 5, 2016, 7:36 p.m., Alejandro Fernandez wrote: > > ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog250.java, > > line 267 > > > > > > Same comment as Jonathan. The behavior of

Re: Review Request 53980: AMBARI-18945 Allowing user to edit service name while enabling ranger plugin

2016-12-07 Thread Mugdha Varadkar
> On Dec. 5, 2016, 3:53 p.m., Jonathan Hurley wrote: > > ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog250.java, > > lines 137-145 > > > > > > All of these essentially do the same

Re: Review Request 53980: AMBARI-18945 Allowing user to edit service name while enabling ranger plugin

2016-12-07 Thread Mugdha Varadkar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53980/ --- (Updated Dec. 7, 2016, 7:36 p.m.) Review request for Ambari, Alejandro

Re: Review Request 53980: AMBARI-18945 Allowing user to edit service name while enabling ranger plugin

2016-12-05 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53980/#review158045 ---

Re: Review Request 53980: AMBARI-18945 Allowing user to edit service name while enabling ranger plugin

2016-12-05 Thread Jonathan Hurley
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53980/#review158001 ---

Re: Review Request 53980: AMBARI-18945 Allowing user to edit service name while enabling ranger plugin

2016-11-29 Thread Mugdha Varadkar
> On Nov. 28, 2016, 7:57 p.m., Alejandro Fernandez wrote: > > ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/configuration/ranger-kms-security.xml, > > line 24 > > > > > > Existing clusters

Re: Review Request 53980: AMBARI-18945 Allowing user to edit service name while enabling ranger plugin

2016-11-28 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53980/#review157126 ---

Re: Review Request 53980: AMBARI-18945 Allowing user to edit service name while enabling ranger plugin

2016-11-22 Thread Mugdha Varadkar
> On Nov. 22, 2016, 10:15 p.m., Alejandro Fernandez wrote: > > ambari-server/src/main/resources/common-services/RANGER_KMS/0.5.0.2.3/configuration/ranger-kms-security.xml, > > line 24 > > > > > > Should the value of

Re: Review Request 53980: AMBARI-18945 Allowing user to edit service name while enabling ranger plugin

2016-11-22 Thread Alejandro Fernandez
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53980/#review156651 ---

Review Request 53980: AMBARI-18945 Allowing user to edit service name while enabling ranger plugin

2016-11-22 Thread Mugdha Varadkar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53980/ --- Review request for Ambari, Alejandro Fernandez, Gautam Borad, Jonathan Hurley,