Re: Review Request 42328: Add metric for counting uncaught exceptions in async executor.

2016-01-15 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42328/#review114724 --- Ship it! NEWS (line 26)

Re: Review Request 42332: Trigger shutdown on task pruning failure.

2016-01-15 Thread Maxim Khutornenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42332/#review114732 --- History prunner is regsistered as a service. Shouldn't its failure

Re: Review Request 42328: Add metric for counting uncaught exceptions in async executor.

2016-01-15 Thread Zameer Manji
> On Jan. 15, 2016, 9:42 a.m., Maxim Khutornenko wrote: > > NEWS, line 26 > > > > > > It this really news-worthy? I'd expect it to be a low noise feature > > related summary. IMO, adding a stat does not clear that

Re: Review Request 42328: Add metric for counting uncaught exceptions in async executor.

2016-01-15 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42328/#review114748 --- Master (b563679) is green with this patch.

Re: Review Request 42328: Add metric for counting uncaught exceptions in async executor.

2016-01-15 Thread Zameer Manji
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42328/ --- (Updated Jan. 15, 2016, 10:28 a.m.) Review request for Aurora, John Sirois and

Re: Review Request 42332: Trigger shutdown on task pruning failure.

2016-01-15 Thread Zameer Manji
> On Jan. 15, 2016, 9:57 a.m., Maxim Khutornenko wrote: > > History prunner is regsistered as a service. Shouldn't its failure triger a > > shutdown according to this: https://reviews.apache.org/r/39631? `TaskHistoryPruner` is not a service, only `JobUpdateHistoryPruner` is. Even if this was

Re: Review Request 42375: Make required mesos log args required.

2016-01-15 Thread John Sirois
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42375/ --- (Updated Jan. 15, 2016, 8:41 p.m.) Review request for Aurora, Dmitriy

Re: Review Request 42375: Make required mesos log args required.

2016-01-15 Thread John Sirois
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42375/ --- (Updated Jan. 15, 2016, 8:35 p.m.) Review request for Aurora, Dmitriy

Re: Review Request 42375: Make required mesos log args required.

2016-01-15 Thread John Sirois
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42375/ --- (Updated Jan. 15, 2016, 8:35 p.m.) Review request for Aurora, Dmitriy

Re: Review Request 42375: Make required mesos log args required.

2016-01-15 Thread Bill Farner
> On Jan. 15, 2016, 5:09 p.m., Bill Farner wrote: > > I believe this will break invocation of the application that don't use the > > replicated log, for example `./gradlew run`. > > John Sirois wrote: > Yes - thanks for pointing out `./gradlew run`. This is a bit of a nasty > situation

Re: Review Request 42332: Trigger shutdown on task pruning failure.

2016-01-15 Thread John Sirois
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42332/#review114795 ---

Re: Review Request 42375: Make required mesos log args required.

2016-01-15 Thread Bill Farner
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42375/#review114823 --- I believe this will break invocation of the application that don't

Re: Review Request 42332: Trigger shutdown on task pruning failure.

2016-01-15 Thread Zameer Manji
> On Jan. 15, 2016, 3:33 p.m., John Sirois wrote: > > src/main/java/org/apache/aurora/scheduler/pruning/TaskHistoryPruner.java, > > line 152 > > > > > > You could centralize this handling in deleteTasks - it has

Re: Review Request 42375: Make required mesos log args required.

2016-01-15 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42375/#review114821 --- Master (b563679) is green with this patch.

Review Request 42375: Make required mesos log args required.

2016-01-15 Thread John Sirois
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42375/ --- Review request for Aurora, Dmitriy Shirchenko and Zameer Manji. Bugs:

Re: Review Request 42375: Make required mesos log args required.

2016-01-15 Thread Aurora ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42375/#review114840 --- Master (b563679) is green with this patch.

Review Request 42387: working version of jessie builds

2016-01-15 Thread Dmitriy Shirchenko
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/42387/ --- Review request for Aurora, John Sirois and Bill Farner. Repository: